GitLab

Currently, when there are two registration and above one is unregistered, console message by above registration is left in top console box though the bottom one goes to the top. Then, the message in each box is set to the message recorded internally when update() is called.

BUG=418568
TEST=N/A

Review URL: https://codereview.chromium.org/653283004

Cr-Commit-Position: refs/heads/master@{#300027}

Now that crbug.com/422508 is fixed, we can remove the call that made the
test work.

BUG=422508

Review URL: https://codereview.chromium.org/657283003

Cr-Commit-Position: refs/heads/master@{#300026}

There are some DEBUG_CHECKs here verifying that a size_t is >= 0. Since a size_t is unsigned, these are trivially true and with the default warning settings for CrOS builds, the warning generated here will cause a build failure.

BUG=424334
TEST=ensure existing builds pass

Review URL: https://codereview.chromium.org/642263006

Cr-Commit-Position: refs/heads/master@{#300025}

Cleanup to make future migration to std::move() easier.

BUG=423621

Review URL: https://codereview.chromium.org/660883003

Cr-Commit-Position: refs/heads/master@{#300024}

$ git log f9e401bab..a57d7db40 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-10-15 maruel Add --cache to isolateserver.py download.
2014-10-15 maruel Preparation work to enable isolateserver.py download to use a local cache.

TBR=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/664493002

Cr-Commit-Position: refs/heads/master@{#300023}

Revert of Revert of Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchs… (patchset #1 id:1 of https://codereview.chromium.org/658903004/)

Reason for revert:
Speculatively reverting (second time) for https://crbug.com/422703 .

Original issue's description:
> Revert of Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchs… (patchset #1 id:1 of https://codereview.chromium.org/653123002/)
>
> Reason for revert:
> The speculative revert didn't help.
>
> Original issue's description:
> > Revert of ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread. (patchset #17 id:320001 of https://codereview.chromium.org/620563002/)
> >
> > Reason for revert:
> > Speculatively reverting for https://crbug.com/422703
> >
> > Original issue's description:
> > > ChromeOS NetworkScreenHandler should not call CheckAndResolveLocale on UI thread.
> > >
> > > BUG=419030
> > >
> > > Committed: https://crrev.com/d52dffddbf0abe5ca55509a9cdedcd9b0674bb1c
> > > Cr-Commit-Position: refs/heads/master@{#298860}
> >
> > TBR=dzhioev@chromium.org,nkostylev@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=422703
> >
> > Committed: https://crrev.com/f09329c436f4929c1f9ffd59e49aa4aef441338b
> > Cr-Commit-Position: refs/heads/master@{#299480}
>
> TBR=dzhioev@chromium.org,nkostylev@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=422703
>
> Committed: https://crrev.com/f4af00363b57344b5d024791b751d966a34b0eb8
> Cr-Commit-Position: refs/heads/master@{#299883}

TBR=dzhioev@chromium.org,nkostylev@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=422703

Review URL: https://codereview.chromium.org/664503003

Cr-Commit-Position: refs/heads/master@{#300022}

Before this change, MojoApplicatioHost was activated only if some
browser-side modules requested it. There was no way for renderer
to activate it.

This CL let MojoApplicationHost always get activated. Now
renderer can request services it needs without its own activation flow.

R=darin@chromium.org,tsepez@chromium.org
TEST=none
BUG=none

Committed: https://crrev.com/bd0aa4dc467c10a4301e44084d8abbba92a35e56
Cr-Commit-Position: refs/heads/master@{#294969}

Committed: https://crrev.com/2c0a563d3019940343e804c7e975bef1bd0f5b54
Cr-Commit-Position: refs/heads/master@{#297551}

Review URL: https://codereview.chromium.org/563373002

Cr-Commit-Position: refs/heads/master@{#300021}

BUG=423621

Review URL: https://codereview.chromium.org/646483009

Cr-Commit-Position: refs/heads/master@{#300020}

BUG=421695
TEST=gpu_unittests, webgl_conformance_tests
R=bajones@chromium.org

Review URL: https://codereview.chromium.org/653203004

Cr-Commit-Position: refs/heads/master@{#300019}

R=mek@chromium.org
BUG=414526

Review URL: https://codereview.chromium.org/655143003

Cr-Commit-Position: refs/heads/master@{#300018}

Implemented all the stages of the controller out-of-box.
Known issues:
* Most of the stages are not shown now during the real out-of-box, because C++
  part is not ready yet.
* Some transitions look bad/don't work.
* Spinner is wrong.

BUG=375191
TEST=manually

Review URL: https://codereview.chromium.org/642313002

Cr-Commit-Position: refs/heads/master@{#300017}

BUG=423621

Review URL: https://codereview.chromium.org/640353003

Cr-Commit-Position: refs/heads/master@{#300016}

This is another followup of crrev.com/297738 and crrev.com/298333.
We need to set 0 to border-top, border-bottom, margin-top, and
margin-bottom in order that a static text element has no height.

BUG=421338

Review URL: https://codereview.chromium.org/655403002

Cr-Commit-Position: refs/heads/master@{#300015}

This splits the macro into two:

int a = 1;
ALLOW_UNUSED_LOCAL(a);

and

typedef Foo Bar ALLOW_UNUSED_TYPE;
void foo() ALLOW_UNUSED_TYPE;  // ALLOW_UNUSED_TYPE_OR_FUNC seemed too verbose

This matches changes that have already been made in Blink.

BUG=81439
TEST=none
TBR=ben

Review URL: https://codereview.chromium.org/650393002

Cr-Commit-Position: refs/heads/master@{#300014}

Cleanup to make future migration to std::move() easier.

BUG=423621

Review URL: https://codereview.chromium.org/659183002

Cr-Commit-Position: refs/heads/master@{#300013}

- Implements WebMimeRegistryImpl::supportsMediaSourceMIMEType().
- Changes NullEncryptedMediaPlayerSupport to return a callback
  bound to NOTIMPLEMENTED() for the NeedKeyCB.

BUG=423416
TEST=basic mse player plays!

Review URL: https://codereview.chromium.org/653213002

Cr-Commit-Position: refs/heads/master@{#300012}

BUG=417463

Review URL: https://codereview.chromium.org/658223002

Cr-Commit-Position: refs/heads/master@{#300011}

When IPC messages are sent via RenderFrameProxyHost::Send, the message's routing ID is reset to the RFPH's routing ID before the message is actually sent.  This doesn't work for control messages, which are represented with a special routing ID.  As a result, control messages were routed incorrectly in the renderer when ChildThread::OnMessageReceived checked for (msg.routing_id() == MSG_ROUTING_CONTROL).  Currently, this only affects FrameMsg_NewFrameProxy, which is the only control message sent through RFPH.

BUG=423538

Review URL: https://codereview.chromium.org/656293005

Cr-Commit-Position: refs/heads/master@{#300010}

BUG=none

Review URL: https://codereview.chromium.org/658233002

Cr-Commit-Position: refs/heads/master@{#300009}

This pulls in the following Native Client changes:

r13916: (mseaborn) Remove some mostly-unused debug logging for printing memory layout
r13917: (sbc) Update newlib version
r13918: (mcgrathr) toolchain_build: Update gcc revision
r13919: (sbc) Report S_IFCHR in windows sel_ldr stat()/fstat() calls.
r13920: (dschuff) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13921: (sbc) Update newlib-based toolchain versions.

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg

Review URL: https://codereview.chromium.org/654413002

Cr-Commit-Position: refs/heads/master@{#300008}

Our Android hit testing walks up the tree and returns the highest
ancestor that's either (1) a leaf node, or (2) focusable and doesn't
have focusable children.

The bug is that (2) shouldn't include the root element of the tree, which
is indeed focusable. If there are no focusable elements on the page, we don't
want all hit tests to return the root - we want them to return the original
object hit.

BUG=424350

Review URL: https://codereview.chromium.org/665513002

Cr-Commit-Position: refs/heads/master@{#300007}

BUG=None

Review URL: https://codereview.chromium.org/650033004

Cr-Commit-Position: refs/heads/master@{#300006}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/481d9a8..6998a13

TBR=cbiesinger@chromium.org,dstockwell@chromium.org

Review URL: https://codereview.chromium.org/641223003

Cr-Commit-Position: refs/heads/master@{#300005}

As of http://crrev.com/638313002 this is now handled in Blink.

BUG=351446

Review URL: https://codereview.chromium.org/641903003

Cr-Commit-Position: refs/heads/master@{#300004}

This is a very preliminary pass and not tested very well. Open issues:

It seems there is no way to wait on a mojo data pipe without using chromium message loops, which I was reluctant to do in my example. We'll need this before doing any nontrivial sending or receiving, including testing of the infrastructure.

We need to be able to pass the net work type (IPv4 or v6) to the connect function that bypasses bind. I removed the code here and documented that it doesn't work yet.

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/657113002

Cr-Commit-Position: refs/heads/master@{#300003}

net: add a batch of HSTS preloads.
Cr-Commit-Position: refs/heads/master@{#300002}

Review URL: https://codereview.chromium.org/665503002

Cr-Commit-Position: refs/heads/master@{#300001}

BUG=395286

Review URL: https://codereview.chromium.org/659153002

Cr-Commit-Position: refs/heads/master@{#300000}

BUG=414026

Review URL: https://codereview.chromium.org/645123003

Cr-Commit-Position: refs/heads/master@{#299999}

BUG=424060

Review URL: https://codereview.chromium.org/637423003

Cr-Commit-Position: refs/heads/master@{#299998}

This CL tests against regressions of http://crbug.com/402347

BUG=402347

Review URL: https://codereview.chromium.org/652573002

Cr-Commit-Position: refs/heads/master@{#299997}

Previously this file could not be formatted because of all the shader
code in magic macros to make it less irritating to edit.  It turns out
"clang-format off" and "clang-format on" in comments make it possible to
selectively apply formatting, so do this for all the shaders.

R=danakj@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/658153003

Cr-Commit-Position: refs/heads/master@{#299996}

The problem: In various cases we have seen that the user setting to ignore the restore option (nothing / all) gets ignored.
Examples: Per user command line changes enforce a restart of chrome after login. After update, ...

On ChromeOS we need only to overwrite the user setting when chrome crashed - which would be identified by the commandline option.

I run all browser tests and changed some tests to respect this behavior.

BUG=395925
TEST=existing unit tests

Review URL: https://codereview.chromium.org/653773003

Cr-Commit-Position: refs/heads/master@{#299995}

This is a revival of [1], which was reverted [2] due to triggering
huge crash. Now the cause of the crash is fixed by [3].
This CHECK() aims to prevent similar bug in the future.

[1] crrev.com/d3e91b36
[2] crrev.com/9a04b3c3
[3] crrev.com/dcdb02fa

R=nasko@chromium.org, kareng@chromium.org
BUG=381990

Review URL: https://codereview.chromium.org/640223005

Cr-Commit-Position: refs/heads/master@{#299994}

He's no longer working on the project so shouldn't be asked for reviews.

Review URL: https://codereview.chromium.org/662513002

Cr-Commit-Position: refs/heads/master@{#299993}

Currently there's only a limited test for the new type. More complete testing to come in a followup patch.

BUG=423017

Review URL: https://codereview.chromium.org/654843005

Cr-Commit-Position: refs/heads/master@{#299992}

BUG=422953
TEST=base_unittests --gtest_filter=DiscardableMemoryTests*
TBR=danakj@chromium.org

Review URL: https://codereview.chromium.org/659143002

Cr-Commit-Position: refs/heads/master@{#299991}

Review URL: https://codereview.chromium.org/638053003

Cr-Commit-Position: refs/heads/master@{#299990}

... instead of naming them just so that arraysize can be used (instead
of ARRAYSIZE_UNSAFE), since C++11 removes this restriction. Also remove
some comments about this.

(Note that the change was automatically formatted, as required by the
presubmit check. Arguably, the entire file should be reformatted for
consistency, but that should be done separately.)

R=ajuma@chromium.org
BUG=423134

Review URL: https://codereview.chromium.org/660103002

Cr-Commit-Position: refs/heads/master@{#299989}

BUG=365528

Review URL: https://codereview.chromium.org/646943005

Cr-Commit-Position: refs/heads/master@{#299988}