GitLab

Fixes <http://webkit.org/b/57046> LayerTreeHostMac's code should be shareable with Windows

Reviewed by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj:

* WebProcess/WebPage/ca/LayerTreeHostCA.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/ca/LayerTreeHostCA.mm.
(WebKit::LayerTreeHostCA::LayerTreeHostCA): Moved some Mac-specific code to
LayerTreeHostCAMac.mm.
(WebKit::LayerTreeHostCA::~LayerTreeHostCA): Wrapped some Mac-specific code in
PLATFORM(MAC).

(WebKit::LayerTreeHostCA::invalidate):
(WebKit::LayerTreeHostCA::sizeDidChange):
(WebKit::LayerTreeHostCA::forceRepaint):
Moved some Mac-specific code to LayerTreeHostCAMac.mm.

(WebKit::LayerTreeHostCA::performScheduledLayerFlush): Renamed from
flushPendingLayerChangesRunLoopObserverCallback. Moved some code from here...
(WebKit::LayerTreeHostCA::didPerformScheduledLayerFlush): ...to here. Moved some
Mac-specific code to LayerTreeHostCAMac.mm.

* WebProcess/WebPage/ca/LayerTreeHostCA.h: Added new functions, wrapped some Mac-specific
declarations in PLATFORM(MAC).

* WebProcess/WebPage/ca/mac/LayerTreeHostCAMac.mm: Added.
(WebKit::LayerTreeHostCA::platformInitialize):
(WebKit::LayerTreeHostCA::scheduleLayerFlush):
(WebKit::LayerTreeHostCA::platformInvalidate):
(WebKit::LayerTreeHostCA::platformSizeDidChange):
(WebKit::LayerTreeHostCA::platformForceRepaint):
(WebKit::LayerTreeHostCA::flushPendingLayerChangesRunLoopObserverCallback):
(WebKit::LayerTreeHostCA::platformDidPerformScheduledLayerFlush):
Code was extracted from LayerTreeHostCA.cpp.

git-svn-id: svn://svn.chromium.org/blink/trunk@81903 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the first step toward sharing code with Windows.

Fixes <http://webkit.org/b/57051>.

Reviewed by Anders Carlsson.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
Updated for rename.

* WebProcess/WebPage/ca/LayerTreeHostCA.h: Renamed from Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.h.
* WebProcess/WebPage/ca/LayerTreeHostCA.mm: Renamed from Source/WebKit2/WebProcess/WebPage/mac/LayerTreeHostMac.mm.

git-svn-id: svn://svn.chromium.org/blink/trunk@81902 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Maciej Stachowiak.

        WebKit2: Cancelling full screen early leaves full screen window up.
        https://bugs.webkit.org/show_bug.cgi?id=56589

        No new tests, as WebKitTestRunner does not currently support the new Full Screen API.

        Notify the UIProcess when it needs to tear down its layer hosting view, turn off
        the background layer when not in accelerated rendering mode and don't swap out
        the web view unnecessarily

        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController beganExitFullScreenAnimation]): Check before swapping _webView.
        (-[WKFullScreenWindowController enterAcceleratedCompositingMode:]): Add the _layerHostingView
            to the full screen window's animationView, not its contentsView.
        (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Hide the background layer.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer): If given a null rootLayer, tell
            the client to exit accelerated mode.

git-svn-id: svn://svn.chromium.org/blink/trunk@81901 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Geoffrey Garen.

        REGRESSION (r79987-r80210): Crash in JSWeakObjectMapClear
        https://bugs.webkit.org/show_bug.cgi?id=55671

        This is no longer necessary, and it seems that with the new weakmap
        model it's simply unsafe, so this reduces it to a no-op.

        * API/JSWeakObjectMapRefPrivate.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@81900 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Russell.

        preserveDrawingBuffer=true is ignored
        https://bugs.webkit.org/show_bug.cgi?id=56987

        Add code to the V8 and JSC bindings to support grabbing the value of
        preserveDrawingBuffer from the input context attributes. Also, in
        WebGLRenderingContext use the WebGLContextAttributes that were input
        directly, not those from the GraphicsContext3D which could have been
        changed.

        No new tests, as this can't be tested with DRT. However, this works
        when tested manually.

        * bindings/js/JSHTMLCanvasElementCustom.cpp:
        (WebCore::JSHTMLCanvasElement::getContext):
        * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
        (WebCore::V8HTMLCanvasElement::getContextCallback):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::clearIfComposited):
        (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):

git-svn-id: svn://svn.chromium.org/blink/trunk@81899 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=56975
<rdar://problem/8915066>
        
Reviewed by Alexey Proskuryakov.

Source/WebCore: 

Adding support in WebCore to implement readSelectionFromPasteboard
to support Mac OS X services from WebKit2.

* WebCore.exp.in:
* editing/Editor.h:
* editing/mac/EditorMac.mm:
(WebCore::Editor::readSelectionFromPasteboard): Added entry point
to call the paste functions with the specified pasteboard.

Source/WebKit2: 

Adding missing entry point to support Mac OS X services in WebKit2.

* UIProcess/API/mac/WKView.mm:
(-[WKView readSelectionFromPasteboard:]): Added.
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::readSelectionFromPasteboard): Added.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Added synchronous
message.
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::readSelectionFromPasteboard): Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@81898 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Pavel Feldman.

        Web Inspector: Inspector does not show correct transfer size for synchronous requests
        https://bugs.webkit.org/show_bug.cgi?id=56951

        Fixed transfer size for synchronous load.

        * http/tests/inspector/network/network-size-sync-expected.txt: Added.
        * http/tests/inspector/network/network-size-sync.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-03-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Inspector does not show correct transfer size for synchronous requests
        https://bugs.webkit.org/show_bug.cgi?id=56951

        Fixed transfer size for synchronous load.

        Test: http/tests/inspector/network/network-size-sync.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::willLoadMediaElementURL):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::loadResourceSynchronously):
        (WebCore::FrameLoader::loadedResourceFromMemoryCache):
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):
        * loader/ResourceLoadNotifier.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@81897 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Dismissed reversion suggestion is incorrectly learned.
        https://bugs.webkit.org/show_bug.cgi?id=57039

        CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
        [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
        is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
        incorrect automatic learning.

        * WebCoreSupport/CorrectionPanel.mm:
        (CorrectionPanel::dismissInternal):
2011-03-24  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        Dismissed reversion suggestion is incorrectly learned.
        https://bugs.webkit.org/show_bug.cgi?id=57039

        CorrectionPanel should always use [NSSpellChecker dismissCorrectionBubbleForView].
        [NSSpellChecker cancelCorrectionBubbleForView] is reserved for situation where correction panel
        is dismissed explicitly by ESC key or clicking the dimiss button. Misusing these causes
        incorrect automatic learning.

        * UIProcess/mac/CorrectionPanel.mm:
        (WebKit::CorrectionPanel::dismissInternal):

git-svn-id: svn://svn.chromium.org/blink/trunk@81896 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=49830
<rdar://problem/8705951>

Reviewed by Adam Roben.

Copy code from WebKit1 to WebKit2 to handle initializing fake scrollbars so 
IBM machines with a trackpad send us WM_VSCROLL and WM_HSCROLL messages.

Listen for the WM_VSCROLL and WM_HSCROLL messages, and turn the values into
ScrollDirection and ScrollGranularity, and send a scroll command to the
WebProcess.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::scrollBy): Send a message to the WebProcess.
* UIProcess/WebPageProxy.h:
* UIProcess/win/WebView.cpp:
(WebKit::WebView::wndProc): Add WM_VSCROLL and WM_HSCROLL message handling.
(WebKit::WebView::initialize): Call shouldInitializeTrackPointHack.
(WebKit::WebView::onHorizontalScroll): Turn wParam into a ScrollDirection and ScrollGranularity. 
(WebKit::WebView::onVerticalScroll): Ditto.
(WebKit::WebView::shouldInitializeTrackPointHack): Check the registry for keys that indicate
    the machine has a IBM Trackpoint driver.
* UIProcess/win/WebView.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scrollBy): Call scroll method.
(WebKit::WebPage::scroll): Moved from WebPageMac and WebPageWin.
(WebKit::WebPage::logicalScroll): Ditto.
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in: Add a new scrollBy message. 
* WebProcess/WebPage/mac/WebPageMac.mm: Remove scroll and logicalScroll, they are now in WebPage.cpp.
* WebProcess/WebPage/win/WebPageWin.cpp: Ditto.



git-svn-id: svn://svn.chromium.org/blink/trunk@81895 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* platform/qt/editing/pasteboard/5065605-expected.txt:
* platform/qt/editing/pasteboard/display-block-on-spans-expected.txt:
* platform/qt/editing/pasteboard/paste-text-011-expected.txt:
* platform/qt/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@81893 bbb929c8-8fbe-4397-9dbb-9b2b20218538

REGRESSION (r81782): http/tests/inspector/extensions-resources-redirect.html sometimes crashes WebKit2's 
web process while handling a WebIconDatabaseProxy::ReceivedIconLoadDecision message

Reviewed by Adam Roben.

The callback objects had some bogus ASSERTs and missed a relevant null check. If a callback was waiting on
a message back from the UIProcess, but was invalidated from within the WebProcess in the meantime, it's
perfectly valid to attempt to performCallback() after the callback function pointer has been cleared.

* loader/icon/IconDatabaseBase.h:
(WebCore::EnumCallback::performCallback):
(WebCore::EnumCallback::invalidate):
(WebCore::EnumCallback::EnumCallback):
(WebCore::ObjectCallback::performCallback):
(WebCore::ObjectCallback::invalidate):
(WebCore::ObjectCallback::ObjectCallback):

LayoutTests: Resolving https://bugs.webkit.org/show_bug.cgi?id=57030, unskip the busted test.

Reviewed by Adam Roben.

* platform/mac-wk2/Skipped:



git-svn-id: svn://svn.chromium.org/blink/trunk@81892 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<rdar://problem/9078569>
https://bugs.webkit.org/show_bug.cgi?id=56995

Reviewed by Darin Adler.

../WebCore: 

* WebCore.exp.in:
Add some editing related exports needed by WebKit2.

../WebKit2: 

* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h:
Add options dictionary.

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::didPerformDictionaryLookup):
Add path that can pass options through.

* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::lookUpInDictionary):
Use the new performDictionaryLookupForSelection which can extract context
if supported.

* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::characterRangeAtPositionForPoint):
(WebKit::characterRangeAtPoint):
Split functionality out of characterRangeAtPoint and into 
characterRangeAtPositionForPoint to avoid doing duplicate work 
if you already have the position.

(WebKit::isPositionInRange):
(WebKit::shouldUseSelection):
Add predicate to determine if we should use the selection instead
of expanding to find the word we are over.

(WebKit::WebPage::performDictionaryLookupAtLocation):
If available, use the surrounding paragraph as context to get better extraction
and to get lexicographical information about the word. Also, clean up and use 
editing APIs to make the code more concise and understandable.

(WebKit::WebPage::performDictionaryLookupForSelection):
Use similar logic as in performDictionaryLookupAtLocation to extract additional
details from a selection for use in the dictionary popup.

(WebKit::WebPage::performDictionaryLookupForRange):
Pass options to WebProcess if available.



git-svn-id: svn://svn.chromium.org/blink/trunk@81890 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Eric Seidel.

        REGRESSION (r80231): Bad cast in HTMLTreeBuilder with closed </form> tags
        https://bugs.webkit.org/show_bug.cgi?id=56836

        During fragment parsing, HTMLConstructionSite holds a reference to the
        fragment context's closest form ancestor. If a misnested form end tag is
        then encountered as the first node of the fragment, we will check to see
        if a corresponding form start tag is in scope even though no such tag
        exists. This led to isScope() walking the HTMLElementStack all the way
        to the root DocumentFragment and attempting to cast it to Element*.

        Fix this by ensuring that the inScope() family of functions operate in
        terms of ContainerNodes to account for the fragment case.

        Test: fast/parser/fragment-closest-form-ancestor.html

        * html/parser/HTMLElementStack.cpp:
        (WebCore::HTMLNames::isRootNode):
        (WebCore::HTMLNames::isScopeMarker):
        (WebCore::HTMLNames::isTableScopeMarker):
        (WebCore::HTMLNames::isTableBodyScopeMarker):
        (WebCore::HTMLNames::isTableRowScopeMarker):
        (WebCore::HTMLElementStack::hasOnlyHTMLElementsInScope):
        (WebCore::HTMLElementStack::inScope):
2011-03-24  Andy Estes  <aestes@apple.com>

        Reviewed by Eric Seidel.

        REGRESSION (r80231): Bad cast in HTMLTreeBuilder with closed </form> tags
        https://bugs.webkit.org/show_bug.cgi?id=56836

        * fast/parser/fragment-closest-form-ancestor-expected.txt: Added.
        * fast/parser/fragment-closest-form-ancestor.html: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@81889 bbb929c8-8fbe-4397-9dbb-9b2b20218538

<rdar://problem/8690506>
https://bugs.webkit.org/show_bug.cgi?id=56874
        
Reviewed by Darin Adler.

When we calculate the style to apply at the insertion point we compare the initial
style at the insertion point against the style calculated at the span we wrap the
copied markup fragment with. We could end up with a series of unnecessary spans
to remove the initial style that simply grow our markup.
The consists in moving the insertion point outside any inline element that could
affect the fragment being inserted when we are not pasting and matching the style.

Test: editing/pasteboard/paste-text-with-style.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::isInlineNodeWithStyle): Added.
(WebCore::ReplaceSelectionCommand::doApply): Added logic to change the insertion
point according to the new rules.

LayoutTests: Repeated copy and paste-in-place operation results in increasingly verbose HTML.
<rdar://problem/8690506>
https://bugs.webkit.org/show_bug.cgi?id=56874

Reviewed by Darin Adler.

* editing/pasteboard/paste-text-with-style-expected.txt: Added.
* editing/pasteboard/paste-text-with-style.html: Added.
The following are new results for existing tests that now produce
a different markup.
* platform/mac/editing/pasteboard/5065605-expected.txt:
* platform/mac/editing/pasteboard/display-block-on-spans-expected.txt:
* platform/mac/editing/pasteboard/paste-text-011-expected.txt:
* platform/mac/editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
* platform/mac/editing/pasteboard/paste-text-at-tabspan-002-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@81887 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
        https://bugs.webkit.org/show_bug.cgi?id=40884

        The software fallback is now only needed for corner cases like a manual rendering
        of the page to QImage.

        Keeping the image with the last pixel values is no longer needed. Removing it reduce the
        performance for real-time rendering on software surface, but this case should no longer be
        supported.

        The conversion from OpenGL color space and coordinates is done manually for performance. This
        also fix the bug of the inverted X axis due to the transformation.

        The tests and benchmarks are done through Qt API tests.

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::swapBgrToRgb):
        (WebCore::GraphicsContext3DInternal::paint):
        (WebCore::GraphicsContext3D::reshape):
2011-03-24  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] When we render WebGL offscreen, color conversion cost a lot of CPU cycles
        https://bugs.webkit.org/show_bug.cgi?id=40884

        Add tests and benchmarks for the software fallback of WebGL.

        * tests/benchmarks/webgl/10000_triangles.html: Added.
        * tests/benchmarks/webgl/tst_webgl.cpp: Added.
        (GraphicsView::GraphicsView):
        (GraphicsView::resizeEvent):
        (tst_WebGlPerformance::init):
        (tst_WebGlPerformance::cleanup):
        (tst_WebGlPerformance::benchSoftwareFallbackRgb16):
        (tst_WebGlPerformance::benchSoftwareFallbackRgb32):
        (tst_WebGlPerformance::benchSoftwareFallbackArgb32):
        (tst_WebGlPerformance::benchSoftwareFallbackArgb32Premultiplied):
        (tst_WebGlPerformance::benchmarkFrameRenderingOnImage):
        * tests/benchmarks/webgl/tst_webgl.qrc: Added.
        * tests/benchmarks/webgl/webgl.pro: Added.
        * tests/qgraphicswebview/qgraphicswebview.pro:
        * tests/qgraphicswebview/resources/pointing_right.html: Added.
        * tests/qgraphicswebview/resources/pointing_up.html: Added.
        * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
        (compareImagesFuzzyPixelCount):
        (GraphicsView::GraphicsView):
        (tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
        (tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):
        (tst_QGraphicsWebView::compareCanvasToImage):
        * tests/qgraphicswebview/tst_qgraphicswebview.qrc:
        * tests/tests.pro:

git-svn-id: svn://svn.chromium.org/blink/trunk@81886 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by James Robinson.

        [chromium] Remove bool that forces compositor HUD to always be enabled
        https://bugs.webkit.org/show_bug.cgi?id=57034

        * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
        (WebCore::CCHeadsUpDisplay::enabled):

git-svn-id: svn://svn.chromium.org/blink/trunk@81884 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Joseph Pecoraro.

* Plugins/WebPluginContainerPrivate.h: Changed value of
ENABLE_PLUGIN_PROXY_FOR_VIDEO from 1 to 0.

git-svn-id: svn://svn.chromium.org/blink/trunk@81883 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=20302
        Correct implementation of signbit on Solaris

        * wtf/MathExtras.h:
        (signbit):

git-svn-id: svn://svn.chromium.org/blink/trunk@81882 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Kenneth Russell.

        [chromium] Add traceEvents to compositor
        https://bugs.webkit.org/show_bug.cgi?id=56965

        * WebCore.gypi:
        * platform/chromium/TraceEvent.h: Added.
        (WebCore::internal::ScopeTracer::ScopeTracer):
        (WebCore::internal::ScopeTracer::~ScopeTracer):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updateRootLayerContents):
        (WebCore::LayerRendererChromium::updateRootLayerScrollbars):
        (WebCore::LayerRendererChromium::updateLayers):
        (WebCore::LayerRendererChromium::drawLayers):
        (WebCore::LayerRendererChromium::finish):
        (WebCore::LayerRendererChromium::present):
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::update):
2011-03-24  Nat Duca  <nduca@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Add traceEvents to compositor
        https://bugs.webkit.org/show_bug.cgi?id=56965

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::composite):

git-svn-id: svn://svn.chromium.org/blink/trunk@81881 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        WebKit2: Tabbing from the last focused field to a non-webpage element leaves the selection in a weird state
        <rdar://problem/8553962>

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::setFocused): When the page loses focus, clear out any selection in the frame

git-svn-id: svn://svn.chromium.org/blink/trunk@81880 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rubber-stamped by Sam Weinig.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDefaultBehaviorForKeyEvent): It should be a logical or,
    not a bitwise or.



git-svn-id: svn://svn.chromium.org/blink/trunk@81879 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Yury Semikhatsky.

        Web Inspector: render XHRs matching JSON regex as JSON.
        https://bugs.webkit.org/show_bug.cgi?id=57035

        * English.lproj/localizedStrings.js:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/NetworkItemView.js:
        (WebInspector.NetworkItemView):
        * inspector/front-end/RemoteObject.js:
        (WebInspector.LocalJSONObject.prototype.get description.switch.case):
        (WebInspector.LocalJSONObject.prototype.get description):
        (WebInspector.LocalJSONObject.prototype._concatenate):
        (WebInspector.LocalJSONObject.prototype.getProperties):
        (WebInspector.LocalJSONObject.prototype._children):
        * inspector/front-end/ResourceJSONView.js: Added.
        (WebInspector.ResourceJSONView):
        (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype.hasContent):
        (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype.show):
        (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (.resource-view.json):
        * inspector/front-end/inspector.html:

git-svn-id: svn://svn.chromium.org/blink/trunk@81878 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
(WebKit::InjectedBundle::setHostAllowsAnyHTTPSCertificate): USE(CF_NETWORK) should be USE(CFNETWORK)



git-svn-id: svn://svn.chromium.org/blink/trunk@81877 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Benjamin Poulain.

        Avoided ASCII-cast warnings for WebKit.

        Normally they won't be enabled anyway, but if you build webkit from
        within the Qt mother repository it will pick up Qt's default build
        settings, which do enable it. We need to disable them because
        warnings are treated as errors and there are way too many of them in
        the WebKit code.

        [Qt] Avoid ASCII-cast warnings for WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=57016

        * QtWebKit.pro:

git-svn-id: svn://svn.chromium.org/blink/trunk@81876 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        Add accessibilityObject accessor to WebDocument (needed for
        building an accessibility tree that includes iframes).
        https://bugs.webkit.org/show_bug.cgi?id=56984

        * public/WebDocument.h:
        * src/WebDocument.cpp:
        (WebKit::WebDocument::accessibilityObject):

git-svn-id: svn://svn.chromium.org/blink/trunk@81875 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The failures are tracked by <http://webkit.org/b/57027> and <http://webkit.org/b/57030>.

* platform/mac-wk2/Skipped: Added http/tests/inspector/extensions-resources-redirect.html.
* platform/win-wk2/Skipped: Added inspector/debugger/source-frame.html.

git-svn-id: svn://svn.chromium.org/blink/trunk@81874 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        Expose Node::isFocusable() in the Chromium WebKit API
        In service of https://code.google.com/p/chromium/issues/detail?id=72918
        https://bugs.webkit.org/show_bug.cgi?id=56809

        * public/WebNode.h:
        * src/WebNode.cpp:
        (WebKit::WebNode::isFocusable):

git-svn-id: svn://svn.chromium.org/blink/trunk@81873 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Move media controls subtree creation into one method.
        https://bugs.webkit.org/show_bug.cgi?id=56969

        Mechanical move, no changes in functionality.

        The purpose of this patch is to align existing code closer with its
        future version, when MediaControls is an element whose tree is created
        at the instantiation.

        * html/shadow/MediaControls.cpp:
        (WebCore::MediaControls::create): Added, consolidating all subtree generation logic into one place.
        (WebCore::MediaControls::update): Replaced methods with one call.
        * html/shadow/MediaControls.h: Updated decls.
        * rendering/MediaControlElements.cpp:
        (WebCore::MediaControlTimelineElement::create): Moved setting of attributes here.
        (WebCore::MediaControlVolumeSliderElement::create): Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@81872 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=57028
<rdar://problem/9181955>

Reviewed by Darin Adler.

* platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::getWebLocData):



git-svn-id: svn://svn.chromium.org/blink/trunk@81871 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test passes on Windows but fails on Mac. <http://webkit.org/b/56988> tracks the Mac
failure.

* platform/win-wk2/fast/css/pseudo-any-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@81870 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=32821
        Fix conditionals which had an int for one case and a pointer for another.
        Fix is similar to https://bugs.webkit.org/show_bug.cgi?id=56198

        No new tests. Fix compilation on Solaris 10 with SunStudio 12 C++

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::valueForShadow):

git-svn-id: svn://svn.chromium.org/blink/trunk@81869 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Benjamin Poulain.

        [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
        https://bugs.webkit.org/show_bug.cgi?id=29595

        Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
        ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
        prepending the current directory.

        By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
        will end up loading "about:blank", but keeping it as a requested URL.

        This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
        is filled for the loaded URLs as well, we can use it in every case.

        Three new autotests were added, to better cover the expected behavior of setting
        the QUrl() in a QWebFrame.

        * Api/qwebframe.cpp:
        (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
        (QWebFrame::requestedUrl): always use m_lastRequestedUrl.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
        anymore, since we always rely on it even for loaded frames.

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
        the reduction of the bug report.
        (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
        (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.

git-svn-id: svn://svn.chromium.org/blink/trunk@81868 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide live edit callback to source frame delegate.
        https://bugs.webkit.org/show_bug.cgi?id=57003

        * inspector/debugger/live-edit.html:
2011-03-24  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide live edit callback to source frame delegate.
        https://bugs.webkit.org/show_bug.cgi?id=57003

        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.editScriptSource):
        (WebInspector.DebuggerModel.prototype._didEditScriptSource):
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
        (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._createSourceFrame):
        (WebInspector.SourceFrameDelegateForScriptsPanel):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):

git-svn-id: svn://svn.chromium.org/blink/trunk@81867 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=46251

Patch by Joe Wild <joseph.wild@nokia.com> on 2011-03-24
Reviewed by Csaba Osztrogonác.

Updated tests the print out character 0xFFFF for Qt Platform.
QString.toUtf8() converts non-defined Unicode char values, like
0xFFFF to a replacement character ('?') as documented.  Other
platforms leave the character as 0xFFFF (but utf8 encoded).
Converting to a real printable char seems reasonable and may
be more reliable.

* platform/qt/Skipped:
* platform/qt/fast/js/regexp-range-bound-ffff-expected.txt: Added.
* platform/qt/fast/js/switch-behaviour-expected.txt: Added.
* platform/qt/fast/url: Added.
* platform/qt/fast/url/anchor-expected.txt: Added.
* platform/qt/fast/url/path-expected.txt: Added.
* platform/qt/http/tests/websocket: Added.
* platform/qt/http/tests/websocket/tests: Added.
* platform/qt/http/tests/websocket/tests/bad-sub-protocol-non-ascii-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@81866 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Not reviewed: removing newly added inspector test that fails on release bots.

        * http/tests/inspector/network/network-redirect-expected.txt: Removed.
        * http/tests/inspector/network/network-redirect.html: Removed.
        * platform/chromium/test_expectations.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@81865 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Not reviewed: updated chromium expectations.

        * platform/chromium/test_expectations.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@81864 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Andreas Kling.

        Regression: WebKit does not build with Python 3 following 56807
        https://bugs.webkit.org/show_bug.cgi?id=56923

        The module string does not have the function replace in Python 3. The str.replace function
        can do the same operation in this case and works with the versions 2 and 3.

        * inspector/generate-inspector-idl:

git-svn-id: svn://svn.chromium.org/blink/trunk@81863 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Not reviewed: fix chromium compilation.

        * public/WebDevToolsAgent.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@81862 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Yury Semikhatsky.

        Web Inspector: brush up Network agent API.
        https://bugs.webkit.org/show_bug.cgi?id=57001

        * http/tests/inspector/network/network-redirect-expected.txt: Added.
        * http/tests/inspector/network/network-redirect.html: Added.
        * inspector/timeline/timeline-network-resource-expected.txt:
        * platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
2011-03-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: brush up Network agent API.
        https://bugs.webkit.org/show_bug.cgi?id=57001

        * inspector/Inspector.json:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::willSendRequestImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::willSendRequest):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForResourceRequest):
        (WebCore::buildObjectForResourceResponse):
        (WebCore::buildObjectForCachedResource):
        (WebCore::InspectorResourceAgent::willSendRequest):
        (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
        (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
        (WebCore::InspectorResourceAgent::setExtraHeaders):
        * inspector/InspectorResourceAgent.h:
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest):
        (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
        (WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource):
        (WebInspector.NetworkDispatcher.prototype.willSendRequest):
        (WebInspector.NetworkDispatcher.prototype.didReceiveWebSocketHandshakeResponse):
        (WebInspector.NetworkDispatcher.prototype.didCloseWebSocket):
        * inspector/front-end/Resource.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        * loader/ResourceLoadNotifier.cpp:
        (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
        (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::createResourceHandle):
2011-03-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: brush up Network agent API.
        https://bugs.webkit.org/show_bug.cgi?id=57001

        * public/WebDevToolsAgent.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest):
        (WebKit::WebDevToolsAgentImpl::willSendRequest):
        * src/WebDevToolsAgentImpl.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@81861 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Jeremy Orlow.

        JNIType is not specific to JNI so should be renamed
        https://bugs.webkit.org/show_bug.cgi?id=56197

        This patch renames JNIType to JavaType, renames the values of
        the enum, and moves it out of JNIUtility.h to its own file.
        Also renames the corresponding JavaField and JavaMethod getters.

        No new tests, refactoring only.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * bridge/jni/JNIUtility.cpp:
        (JSC::Bindings::javaTypeFromClassName):
        (JSC::Bindings::signatureFromJavaType):
        (JSC::Bindings::javaTypeFromPrimitiveType):
        (JSC::Bindings::getJNIField):
        (JSC::Bindings::callJNIMethod):
        * bridge/jni/JNIUtility.h:
        * bridge/jni/JavaMethod.cpp:
        (JavaMethod::JavaMethod):
        (JavaMethod::signature):
        * bridge/jni/JavaMethod.h:
        (JSC::Bindings::JavaMethod::returnTypeClassName):
        (JSC::Bindings::JavaMethod::returnType):
        * bridge/jni/JavaType.h: Copied from Source/WebCore/bridge/jni/JavaMethod.h.
        * bridge/jni/jni_jsobject.mm:
        (JavaJSObject::toString):
        * bridge/jni/jni_objc.mm:
        (JSC::Bindings::dispatchJNICall):
        * bridge/jni/jsc/JNIUtilityPrivate.cpp:
        (JSC::Bindings::convertArrayInstanceToJavaArray):
        (JSC::Bindings::convertValueToJValue):
        * bridge/jni/jsc/JNIUtilityPrivate.h:
        * bridge/jni/jsc/JavaArrayJSC.cpp:
        (JavaArray::setValueAt):
        (JavaArray::valueAt):
        * bridge/jni/jsc/JavaClassJSC.cpp:
        * bridge/jni/jsc/JavaFieldJSC.cpp:
        (JavaField::JavaField):
        (JavaField::dispatchValueFromInstance):
        (JavaField::valueFromInstance):
        (JavaField::dispatchSetValueToInstance):
        (JavaField::setValueToInstance):
        * bridge/jni/jsc/JavaFieldJSC.h:
        (JSC::Bindings::JavaField::typeClassName):
        (JSC::Bindings::JavaField::type):
        * bridge/jni/jsc/JavaInstanceJSC.cpp:
        (JavaInstance::invokeMethod):
        * bridge/jni/v8/JNIUtilityPrivate.cpp:
        (JSC::Bindings::convertNPVariantToJValue):
        (JSC::Bindings::convertJValueToNPVariant):
        * bridge/jni/v8/JNIUtilityPrivate.h:
        * bridge/jni/v8/JavaFieldV8.cpp:
        (JavaField::JavaField):
        * bridge/jni/v8/JavaFieldV8.h:
        (JSC::Bindings::JavaField::typeClassName):
        (JSC::Bindings::JavaField::type):
        * bridge/jni/v8/JavaInstanceV8.cpp:
        (JavaInstance::invokeMethod):
        (JavaInstance::getField):
        * bridge/jni/v8/JavaNPObjectV8.cpp:
        (JSC::Bindings::JavaNPObjectInvoke):
        (JSC::Bindings::JavaNPObjectGetProperty):

git-svn-id: svn://svn.chromium.org/blink/trunk@81860 bbb929c8-8fbe-4397-9dbb-9b2b20218538