GitLab

TBR=rockot@chromium.org

Review-Url: https://codereview.chromium.org/2865493002
Cr-Commit-Position: refs/heads/master@{#469405}

- Use more StringPieces and C++11.
- Merge some repeated code.
- Fix nits.

Review-Url: https://codereview.chromium.org/2858213002
Cr-Commit-Position: refs/heads/master@{#469404}

This change will suppress all fling cancel events unless the last event
was a fling event. Also it generates a proper sequence of a scroll
event with zero distance.

BUG=590754
TEST=Fling and touch the touchpad after fling. Should stop scrolling
motion in android apps.

Review-Url: https://codereview.chromium.org/2840113002
Cr-Commit-Position: refs/heads/master@{#469403}

The best practice is apparently not to do this and to use
Serialize()/Deserialize() functions directly. This also removes an
EnumTraits test that isn't super useful.

BUG=none

Review-Url: https://codereview.chromium.org/2857033002
Cr-Commit-Position: refs/heads/master@{#469402}

TBR=bajones@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2863603003
Cr-Commit-Position: refs/heads/master@{#469401}

https://pdfium.googlesource.com/pdfium.git/+log/df673c28191c..dcefccc9f0f2

$ git log df673c281..dcefccc9f --date=short --no-merges --format='%ad %ae %s'
2017-05-04 dsinclair Removing unused IFX_Pause parameters

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ib8116680974b8967fe03da054cdfad05a6dfd721
Reviewed-on: https://chromium-review.googlesource.com/495490
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469400}

BUG=718445

Review-Url: https://codereview.chromium.org/2862863002
Cr-Commit-Position: refs/heads/master@{#469399}

NameMap, which after the previous patch is no longer used by the shader/program managers, is removed, and the tests updated.

Tests are also added for GetOriginalNameFromHashedName, though these don't actually hit the original error case in the bug report. That's a difficult integration issue and is tested instead by the WebGL conformance tests.

Usages of GetOriginalNameFromHashedName are replaced with more specific methods calls in Program::{GetTransformFeedbackVaryings,GetUniformBlocks}. This avoids querying the unnecessary extra four info maps.

BUG=716018
TEST=https://github.com/KhronosGroup/WebGL/pull/2388
TEST=https://github.com/KhronosGroup/WebGL/pull/2389
TEST=ShaderManagerTest.DoCompile
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2852923004
Cr-Commit-Position: refs/heads/master@{#469398}

In the Payment Sheet and the Address selector, display the shipping
option error.

BUG=710004
TEST=browser_tests

Review-Url: https://codereview.chromium.org/2855203002
Cr-Commit-Position: refs/heads/master@{#469397}

BUG=706683

Review-Url: https://codereview.chromium.org/2855033002
Cr-Commit-Position: refs/heads/master@{#469396}

Revert of MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility (patchset #2 id:20001 of https://codereview.chromium.org/2852433003/ )

Reason for revert:
This caused pageVisibility sub-objects to no longer be undefined which (counter intuitively) causes the sub sections to no longer be visible.

There was some discussion about various approaches to fix this here:
https://codereview.chromium.org/2861443003/

However no agreement was reached, so I am reverting this CL.

Original issue's description:
> MD Settings: Elim SettingsSubpageBrowsertest and SettingsPageVisibility
>
> This CL:
> * Removes SettingsSubpageBrowsertest which required extra complexity
>   in the Settings page visibility code and only tested coarse load
>   times of subpages; this testing no longer has much value.
> * Eliminates SettingsPageVisibility which was creating multiple
>   definitions of pageVisibility and generally confusing things.
> * Defines pageVisibility in all cases (not just guest mode). This will
>   allow  the use of dom-if and allows conditional pages
>   (i.e. androidApps) to use the same pageVisibility system. Pages still
>    default to visibile unless explicity set to 'false'.
>
> BUG=709442
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2852433003
> Cr-Commit-Position: refs/heads/master@{#468702}
> Committed: https://chromium.googlesource.com/chromium/src/+/1362453f54271dc1036fc104a01cad436c3da26c

TBR=dpapad@chromium.org,hcarmona@chromium.org,michaelpg@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=709442

Review-Url: https://codereview.chromium.org/2866463002
Cr-Commit-Position: refs/heads/master@{#469395}

The toolbar color was changed in https://codereview.chromium.org/2809923003
for Chrome Home. The specified color, #424242, would have required
updating tablet tab strip assets to a darker grey, which violated
accessibility standards. Reverting to the old color.

BUG=716351,695973

Review-Url: https://codereview.chromium.org/2859933004
Cr-Commit-Position: refs/heads/master@{#469394}

This CL moves the interactions with android.media.FaceDetector
because they are slow and trigger a "StrictMode policy violation"
(at least in Debug build).  Some of the parameters are made final
to use them inside a Runnable.

BUG=718275

Review-Url: https://codereview.chromium.org/2863553002
Cr-Commit-Position: refs/heads/master@{#469393}

This has been a source of confusion for several developers since the
old instructions are ambiguous about the last step.

BUG=

Review-Url: https://codereview.chromium.org/2864433005
Cr-Commit-Position: refs/heads/master@{#469392}

TBR=skobes@chromium.org

Review-Url: https://codereview.chromium.org/2860893004
Cr-Commit-Position: refs/heads/master@{#469391}

Part of what this test tests is canceling an in-progress find session by
searching for another search term. The problem that was causing the
flakiness was that the find session that was meant to get canceled
actually finished (rarely) before the subsequent request made it to the
renderer, and so the completed session was not reported as canceled. The
small adjustment made in this CL is to only attempt to cancel the search
that has many results, so that its find session is much less likely to
complete before the next find request comes through.

BUG=710486

Review-Url: https://codereview.chromium.org/2857953004
Cr-Commit-Position: refs/heads/master@{#469390}

BUG=

Review-Url: https://codereview.chromium.org/2860113002
Cr-Commit-Position: refs/heads/master@{#469389}

This patch also  makes the SB throttle pass-through if there isn't a valid
DB manager.

BUG=717590

Review-Url: https://codereview.chromium.org/2858483003
Cr-Commit-Position: refs/heads/master@{#469388}

This lets tests interested in testing features related to the
prefs_services inject their own into TestShellDelegate and
register in it whatever prefs they want.

BUG=718472

Review-Url: https://codereview.chromium.org/2861873004
Cr-Commit-Position: refs/heads/master@{#469387}

Fix a potential crash when we have an active user, but its profile
is not ready yet.

BUG=713934

Review-Url: https://codereview.chromium.org/2864453003
Cr-Commit-Position: refs/heads/master@{#469386}

This CL adds a test for a feature added in CL 2839653002, merged to M59.
The test has been implemented along with the original CL but is uploaded
separately to speed up the process (avoiding deps changes).

BUG=705572

Review-Url: https://codereview.chromium.org/2852383002
Cr-Commit-Position: refs/heads/master@{#469385}

Re-disables WebVrTest#testScreenTapsRegisteredOnCardboard, but only on L
instead of of everything.

TBR=dtrainor@chromium.org
BUG=713781

Review-Url: https://codereview.chromium.org/2855123006
Cr-Commit-Position: refs/heads/master@{#469384}

Change compile targets for Linux Clang Analyzer from "all" to "chrome".

R=dpranke@chromium.org
BUG=689095

Review-Url: https://codereview.chromium.org/2850853002
Cr-Commit-Position: refs/heads/master@{#469383}

This is somewhat catastrophic (it results in blank contents or black
tiles), so be sure that it is captured in about:gpu.

BUG=574014

Review-Url: https://codereview.chromium.org/2858683004
Cr-Commit-Position: refs/heads/master@{#469382}

Extends PromoDialog to support vector drawables, and replaces
the large search_sogou.png asset with a vector drawable.

Replaces 131,070 bytes with 4,834.

BUG=666062

Review-Url: https://codereview.chromium.org/2857893003
Cr-Commit-Position: refs/heads/master@{#469381}

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL24_part1.

Goal of CL24:
The interface content::VideoCaptureProvider currently has one implementation
called InProcessVideoCaptureProvider, which is essentially a factory for the
legacy in-process video capture stack. This CL adds a second implementation
called MojoServiceVideoCaptureProvider which is essentially a wrapper for
connecting to and communicating with the new video capture service.

Changes in part1:
* Add class MojoServiceVideoCaptureProvider
* Add skeletons for classes MojoServiceVideoCaptureDeviceLauncher and
  MojoServiceLaunchedVideoCaptureDevice
* Introduce a build flag enable_mojo_video_capture to prevent the new and
  incomplete code from going into builds.

BUG=584797
TEST=
  service_unittests --gtest_filter="*Video*"
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2848973002
Cr-Commit-Position: refs/heads/master@{#469380}

In the JUnit4 conversion CL (https://codereview.chromium.org/2815453003)
super.tearDown() call was mistakenly removed.

BUG=718454

Review-Url: https://codereview.chromium.org/2861433006
Cr-Commit-Position: refs/heads/master@{#469379}

Hard-code TEMPDIR/TMPDIR for "Xvfb" to "/tmp" in webkitpy's Linux layout
test port. The Xvfb tool's "xkb" library compiles in "/tmp" in several
places, and hard-linking expectations get violated if TEMPDIR and "/tmp"
are on different filesystems.

BUG=chromium:715848
TEST=local
  - Ran without patch and TEMPDIR/TMPDIR overrides, verified hardlink
    failure from bug.
  - Ran with patch, no more hardlink failure!

Review-Url: https://codereview.chromium.org/2859703002
Cr-Commit-Position: refs/heads/master@{#469378}

- Consolidate callback factories in OutOfProcessInstance.
- Make PDFEngine::Create() return a unique_ptr.
- Unify LoadUrl methods.

Review-Url: https://codereview.chromium.org/2837663002
Cr-Commit-Position: refs/heads/master@{#469377}

https://pdfium.googlesource.com/pdfium.git/+log/8384757b2b00..df673c28191c

$ git log 8384757b2..df673c281 --date=short --no-merges --format='%ad %ae %s'
2017-05-04 dsinclair Cleanup more null IFX_Pause parameters
2017-05-04 dsinclair Remove some unused IFX_Pause params

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I6195944d1434725871e800f62e1097275e84f5f7
Reviewed-on: https://chromium-review.googlesource.com/495411
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469376}

On Mac, //base/threading uses CoreFoundation, which causes forked child
processes to violate the framework's requirement that CF may not be used
after-fork-before-exec.

BUG=717490
R=mark@chromium.org

Review-Url: https://codereview.chromium.org/2865453002
Cr-Commit-Position: refs/heads/master@{#469375}

Seems the option isn't ready to click on immediately.
Wait until the option is non-null before moving forward.

BUG=718461

Review-Url: https://codereview.chromium.org/2861003002
Cr-Commit-Position: refs/heads/master@{#469374}

Review-Url: https://codereview.chromium.org/2854263004
Cr-Commit-Position: refs/heads/master@{#469373}

Bugs causing split-project and use-gradle-resources to not work
correctly. Also fix the jinja template.

BUG=620034

Review-Url: https://codereview.chromium.org/2858233002
Cr-Commit-Position: refs/heads/master@{#469372}

- Add the BackgroundDownloadService interface and associated files.  Set
up the test hooks and tie it into the proper Chrome and
component_unittest targets.

BUG=717180

Review-Url: https://codereview.chromium.org/2851303003
Cr-Commit-Position: refs/heads/master@{#469371}

The existing logic for checking whether the compositor has a scroll
corner layer is insufficient.  When the compositor runs
UpdateOverflowControlsLayers, it will delete its scroll corner layer
if the scroll corner isn't visible.  In this case, the paint code
should not try to paint the scroll corner.

The existing code causes a number of crashes in compositing tests
when this patch is applied:

https://codereview.chromium.org/2860433002

BUG=701575
R=pdr@chromium.org,chrishtr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2857333004
Cr-Commit-Position: refs/heads/master@{#469370}

This patch adds web platform tests that verify behavior of
PaymentRequest constructor. To match the spec, PaymentRequest
constructor in this patch has been changed to:
- Check for secure context before validating any parameters.
- Check the amount value first before checking the rest of the fields in
  each line item.
- Determine the selected shipping option even if requestShipping is
  false.
- Validate shipping options even if requestShipping is false.
- Validate shipping options before checking for duplicate shipping
  option IDs.
- Allow empty line item labels (but discourage via a console warning).
- Allow empty shipping option ID (but discourage via a console warning).
- Allow empty list of modifiers.

Because of changes in the WebIDL, certain conditions are not possible,
so they are ensured via DCHECK() in this patch instead of if statements
before this patch:
- Total is always present.
- Every line item has a label and amount.
- Every amount has value and currency.
- Every shipping option has an ID.
- Shipping type is always valid.

Invalid shipping type ("delivery", "shipping", or "pickup") is now
impossible because the WebIDL specifies it as an enum. Therefore,
there's no need for additional validation there.

To help developers better decipher the behavior of the API, error
messages have been improved in this patch. For example:
  "'-1/3' is not a valid amount for total."

Spec:
https://w3c.github.io/browser-payment-api/#constructor

BUG=705252

Review-Url: https://codereview.chromium.org/2851383002
Cr-Commit-Position: refs/heads/master@{#469369}

Previously only overflow shelf to main shelf, now bidirectional.

TEST=ash_unittests --gtest_filter="ShelfViewTest.*"
BUG=710228

Review-Url: https://codereview.chromium.org/2820693004
Cr-Commit-Position: refs/heads/master@{#469368}

Also removes obsolete config for
UMA_EnableCellularLogUpload.

BUG=none

Review-Url: https://codereview.chromium.org/2860103002
Cr-Commit-Position: refs/heads/master@{#469367}

The delay not fix the bug on Rialto, so I'm removing it.

BUG=chromium:710716
TEST=unit test

Review-Url: https://codereview.chromium.org/2854393003
Cr-Commit-Position: refs/heads/master@{#469366}