- 10 Apr, 2018 40 commits
-
-
Anna Offenwanger authored
Adding a histogram to track how the user got into XR Presentation. Bug: 808589 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iad597f74fe22afac5709ebee1525c0b342cc24a4 Reviewed-on: https://chromium-review.googlesource.com/999019 Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#549658}
-
Erik Luo authored
This extends [Affects=Nothing] to mark attributes/accessors with getter callbacks that produce no JS-observable side effect. This also marks Node's isConnectedAttributeGetter as side-effect-free. Bug: 829571 Change-Id: I21211b477a95e51e10cade1ffbd0249171684d1c Reviewed-on: https://chromium-review.googlesource.com/999304 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549657}
-
Dale Curtis authored
This allows us to avoid a preload=metadata suspend if we know playback would start once we reach the HaveEnoughData state. There are still cases where the play() call might come in after Start(), but this should capture a significant chunk. In order to test this change, I've built up significant infrastructure inside HTMLMediaElementTest and WebMediaPlayerImplTest. The WMPI test can now fully start the media pipeline and execute up to the metadata state. This is sufficient for testing this feature and an improvement to the state of our existing WMPI tests. Note: Extending the WMPI tests required fixing up instances of const& base::TimeDelta usage by the MediaPlayerManager interfaces to avoid presubmit errors. BUG=827396 TEST=new unittests. Change-Id: I8b5c3dea1ecc3e3b519e2b26bfc45b9d9204fb81 Reviewed-on: https://chromium-review.googlesource.com/996632 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#549656}
-
Nate Chapin authored
Bug: 829119 Change-Id: I6b85f4776e54fdc3f5cc036cfe46b6ef53e250b1 Reviewed-on: https://chromium-review.googlesource.com/1000518Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#549655}
-
Nasko Oskov authored
The goal of this CL is to break down the TimeToReadyToCommit metric into cases where we perform cross-process navigation vs same-process one. This will allow us to analyze whether regressions are due to change of process or potentially other differences in code. Bug: 808114 Change-Id: Ic98c2f9f5b7a6a21ee44e34bc8668af61e4a0f9e Reviewed-on: https://chromium-review.googlesource.com/1003290Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#549654}
-
Daniel Murphy authored
Bug: 830909, 756447, 829125, 829141 Change-Id: Iaf467fbe9cf2c836bfcd761d558c3f7c0e7379a8 Reviewed-on: https://chromium-review.googlesource.com/1003281Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#549653}
-
Lukasz Anforowicz authored
This reverts commit a9d4f347. We verified that high-volume kills reported in https://crbug.com/831082 go away after reverting. Simple repro that would have resulted in a renderer kill before the revert: $ out/rel/chrome --disable-features=NavigationMojoResponse \ --user-data-dir=$HOME/.chrome-kill-x1 --site-per-process \ http://chromium.org Bug: 831082 Change-Id: Ibbb9b08862e4c611c7d8bd139b96970edbebf460 Tbr: kinuko@chromium.org Tbr: clamy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1005792 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#549652}
-
Dave Schuyler authored
This CL adds some unit tests for search_suggestion_parser which previously had none. This set of tests can be expanded upon, this is just a start. Bug: None Change-Id: I445865beee434674e2d11c3d3cb9e708d19336ff Reviewed-on: https://chromium-review.googlesource.com/999297 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#549651}
-
Matthew Wang authored
Creating histograms for roam complete for FT and non-FT networks and for PSK and 802.1X authentication. This is a success metrics to show roaming reliability improvements from FT. Histograms are implemented in CL:957442. Bug: 791202 Change-Id: Ia9174e6239804187bd5c16445de6f6229f3e55a3 Reviewed-on: https://chromium-review.googlesource.com/972591 Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Reviewed-by:
Kevin Cernekee <cernekee@chromium.org> Reviewed-by:
-
Dominick Ng authored
This CL fixes a bug introduced during the refactoring of ArcNavigationThrottle to AppsNavigationThrottle where the intent picker could be shown multiple times during a redirect chain. If the user has ARC apps installed which handle all URLs (e.g. Chrome Beta/Chrome Dev), we could get into a situation where we show the intent picker but reset our internal state to be not showing. The fix is to only set the internal |ui_displayed_| state to false if the apps list sent back to AppsNavigationThrottle is empty. BUG=824598 Change-Id: I990d00d90665d362ee9e894ad71a71454e78ebea Reviewed-on: https://chromium-review.googlesource.com/1003812Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#549649}
-
mrefaat authored
Handle iTunes bundle URLs regularly, instead of launching storekit for them. The reason is StoreKit view controller doesn't present bundles correctly. Bug: 829302 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idcd6fd1ef42fd48550b589330ec3191484619a2b Reviewed-on: https://chromium-review.googlesource.com/1005443Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#549648}
-
Chris Blume authored
The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. LocalSurfaceIdProvider is one such call site. BUG=759031 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I85aad90edc9d61ae1c2924d3bbc5fc92b3b9376b Reviewed-on: https://chromium-review.googlesource.com/1005801Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#549647}
-
Jun Choi authored
Currently GetAssertionTask will return an error if sign in response received after user verification includes an user entity object. This is not entirely correct. CTAP spec[1] specifies that "user identifiable information" must not be present. This includes user image url, user display name, and user name. User key handle, however, is not part of user identifiable information. Thus user entity with only user key handle should be allowed. [1]: https://drafts.fidoalliance.org/fido-2/latest/fido-client-to-authenticator-protocol-v2.0-wd-20180305.html#authenticatorGetAssertion Bug: 780078 Change-Id: I9320646346a92838ade1dd41419808c89ed9f76d Reviewed-on: https://chromium-review.googlesource.com/1003389 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#549646}
-
Rayan Kanso authored
Update the database manager task wrappers to use the metadata proto directly. The following files were moved and slightly updated to make naming consistent throughout: * create_registration_task.(cc|h) -> create_metadata_task.(cc|h) * get_registration_task.(cc|h) -> get_metadata_task.(cc|h) The metadata to registration conversion logic was removed from get_registration_task.cc. Also added tests. Bug: 826257 Change-Id: I7a8cedf76df3b935ebeddf6536ba5cda639420db Reviewed-on: https://chromium-review.googlesource.com/993054 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549645}
-
https://chromium.googlesource.com/catapult.git/+log/1bae362e7789..2c59f678c7ed $ git log 1bae362e7..2c59f678c --date=short --no-merges --format='%ad %ae %s' 2018-04-10 eyaich Printing out full benchmark/story path in logs for ease of grepping. 2018-04-10 simonhatch HistogramSet - Merge by test paths in add_reserved_diagnostics. 2018-04-10 perezju [devil] Simplify condition for `ps` on Android O+ Created with: roll-dep src/third_party/catapult BUG=chromium:779634,chromium:686716 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: If842962b8580606c939cbc1c597d5bcb8a9f507a Reviewed-on: https://chromium-review.googlesource.com/1005778Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549644}
-
Theresa authored
Remove the toasts and Java-layer clustering used during prototyping. BUG=822945 Change-Id: I391c2eb051c448cf1c9df88a9039b25db04fffeb Reviewed-on: https://chromium-review.googlesource.com/1005502Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#549643}
-
Xiaohan Wang authored
See screen shot at https://photos.app.goo.gl/gi8yNPJMhEePzOu62 For Protected Content icon update on Android, see https://chromium-review.googlesource.com/c/chromium/src/+/996754 Bug: 454980 Test: Manually inspected. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I299f31d185f7a927cc3c3596f8ff6ff91b5b9b61 Reviewed-on: https://chromium-review.googlesource.com/1003146 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#549642}
-
Kevin Marshall authored
Removing the "shell" capability allows packaged apps to load dynamic libraries from the package. In addition, it prevents the app from using any system-provided libraries, in favor of the package supplying all of its data and dynamic library dependencies. This CL includes the system libraries from the SDK's "dist" directory in packages built using the package() GN template. Bug: 823927 Change-Id: I7c0eaef08765f8119bec9a67d381014d07ba4606 Reviewed-on: https://chromium-review.googlesource.com/985474Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
James Robinson <jamesr@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#549641}
-
Xiaoqian Dai authored
The CL has been merged back to M66. So revert this CL on tot. This reverts commit cf5e5473. TBR=xiyuan@chromium.org Bug: 827322 Change-Id: I9d5ca5abf7399318e5bf950c5e25d01bc2ff9093 Reviewed-on: https://chromium-review.googlesource.com/1005615Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#549640}
-
Greg Thompson authored
A change in Windows made absolute moves to coordinate 0,0 not work. It seems that moving to 1,1 (normalized) does the trick. 1,1 will round down to 0,0 for any display we care about. BUG=827549 Change-Id: I76fac0313901ba68bb35ed624c475aed23592029 Reviewed-on: https://chromium-review.googlesource.com/1004734Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#549639}
-
Scott Violet authored
BUG=none TEST=none Change-Id: Idf1a83b0582eefea99b26e5cb956624dbd9c83e9 Reviewed-on: https://chromium-review.googlesource.com/1005499Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#549638}
-
Corentin Wallez authored
BUG=chromium:815092 Change-Id: I63d8a6f3987769b3c16a2a8134e46acb044514b2 Reviewed-on: https://chromium-review.googlesource.com/1005420Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#549637}
-
Michael Thiessen authored
No functional changes intended. This moves the static DaydreamApi calls onto VrClassesWrapper to avoid having to create the DaydreamApi instance and close it. Change-Id: I738b5f966d33f735077d616a4fe2d48f95aa88dd Reviewed-on: https://chromium-review.googlesource.com/1003092 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549636}
-
David Bienvenu authored
This should fix an OOM crash in PartitionAllocTest.DumpMemoryStats because it will make the ReturnNull tests run in a separate process, and not exhaust process memory for subsequent tests. Bug: 722911 Change-Id: I841b846ea3322328a1d10391332c190b59db6db0 Reviewed-on: https://chromium-review.googlesource.com/1005506Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Leonard Grey authored
Constants and logic brought over from chrome/browser/ui/cocoa/browser_window_controller.h Bug: 827199 Change-Id: Ida44f197ba2039c060824b1dcf247c889d99b470 Reviewed-on: https://chromium-review.googlesource.com/1005001Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#549634}
-
Yuwei Huang authored
This reverts commit 8b79a3c6. Reason for revert: This change is not good enough to fix the keypress issue we see. We need to rework the way we send keypress, which will undo the change we do here. Original change's description: > [CRD iOS] Translate "\n" into an enter keypress > > iOS is sending a "\n" unicode text event to the host when the user taps > the `return` key. On Windows this doesn't always generate a newline. > > This CL fixes this issue by translating the "\n" text event into a > ENTER keypress before sending it to the host. > > Bug: 830959 > Change-Id: Ib94caf6ce2036cc5654f1b59f1e0136c81c9eec1 > Reviewed-on: https://chromium-review.googlesource.com/1003598 > Commit-Queue: Yuwei Huang <yuweih@chromium.org> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549385} TBR=jamiewalch@chromium.org,yuweih@chromium.org Change-Id: Icba4c28dccc7154f30a41b90dc2cbc62feae2824 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 830959 Reviewed-on: https://chromium-review.googlesource.com/1005697Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#549633}
-
Jamie Walch authored
This reverts commit 8ec33b04. Reason for revert: Breaks vp9 decode, as determined by bisect. See https://bugs.chromium.org/p/chromium/issues/detail?id=828656 for context. Original change's description: > update video decoder shim to gfx::ColorSpace > > This is a re-land of 865455, which actually works. > > TEST=ran video_decoder ppapi example > > Bug: 754986 > Change-Id: Ibf0e20244173b8ade0c1fca134825b2cd2ace660 > Reviewed-on: https://chromium-review.googlesource.com/902459 > Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547051} TBR=bbudge@chromium.org,ccameron@chromium.org,hubbe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 754986 Change-Id: Ic6b672154942e210997c736fccf6a714e354889f Reviewed-on: https://chromium-review.googlesource.com/1005734Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#549632}
-
https://chromium.googlesource.com/angle/angle.git/+log/26084d0aae38..4416247c9d91 $ git log 26084d0aa..4416247c9 --date=short --no-merges --format='%ad %ae %s' 2018-04-06 lucferron Vulkan: Enable point sprite end2end tests 2018-04-06 lucferron Vulkan: Implement support for structs in uniforms Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Id16117e7cc138bd6f3c76089899e26cfdd5c6220 Reviewed-on: https://chromium-review.googlesource.com/1005411Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549631}
-
Jao-ke Chin-Lee authored
TBR=tandrii@chromium.org Change-Id: I9228dc1d6597926630b627ac483385cc46a20b25 Reviewed-on: https://chromium-review.googlesource.com/1005813Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
-
Roger McFarlane authored
Bug: 803946 Change-Id: Ia1f3232e60115a2cb881799605850e7c6f58efb0 Reviewed-on: https://chromium-review.googlesource.com/966581Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
-
Joel Einbinder authored
This adds a _serializedFileOperation method to IsolatedFileSystem which waits for all pending DevTools reads/writes to finish for a file path. Change-Id: I5a1dd55dbe40ae0bf8335bc8e1994c1209fcc999 Reviewed-on: https://chromium-review.googlesource.com/991201 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#549628}
-
Ned Nguyen authored
Bug:830957 Change-Id: Ia977b531e4c12bed0faa9c216754b191d8b3fadb TBR=eyaich@chromium.org NOTRY=true # all tests are in PRESUBMIT Change-Id: Ia977b531e4c12bed0faa9c216754b191d8b3fadb Reviewed-on: https://chromium-review.googlesource.com/1005884 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#549627}
-
Gustav Sennton authored
Support converting a (webkit) ServiceWorkerWebSettings object into a boundary interface that the support library can use. Bug: TODO b/77808798 Change-Id: Ie1d98b0983a4b136da2e898cefbf62ee47323b42 Reviewed-on: https://chromium-review.googlesource.com/1005066Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#549626}
-
Troy Hildebrandt authored
This fix removes the specialized LocationBarTablet call to getUrlContainerViewsForMargin since the tablet doesn't need its own version when using the action container. Original Description: On tablets, the layout for the location bar is overridden by the XML in layout-sw600dp, which means instead of the url_action_container used elsewhere, it's a series of FrameLayouts for action buttons with manually calculated margins. This CL breaks the url_action_container into its own file to be included on both phone and tablet, and gets rid of the tablet-specific layout update for calculating the margin of the action buttons. Bug: 820273 Change-Id: I84fe2a5ba1c8438bc287142bdb52d3e7ce42efa3 Reviewed-on: https://chromium-review.googlesource.com/999026Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549625}
-
Qiang Xu authored
changes: This CL is DEPS update for crrev.com/c/986889. Bug: 812504 Test: none Change-Id: Icb2524d3a915c45f4ddade040e4c00e68d85a922 Reviewed-on: https://chromium-review.googlesource.com/988340Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#549624}
-
Xiaoqian Dai authored
See https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html#project-resizing for the spec. Also update some constants according to the spec. Bug: 825034 Change-Id: I0328fde32376d7b53a1913f03107da051137eb85 Reviewed-on: https://chromium-review.googlesource.com/992775 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#549623}
-
Jao-ke Chin-Lee authored
Bug: 790607,790323 Change-Id: I8901f53e2fbb1393cbde492aa069fe8b8a6ecee9 Reviewed-on: https://chromium-review.googlesource.com/1005848Reviewed-by:
-
Christopher Cameron authored
Add synchronous calls to RenderWidgetHostNSViewClient to call into TextInputClientMac. At present, synchronous doesn't mean anything, but when the NSView is a separate process, these will correspond to synchronous IPCs to the browser process. This covers all calls from Cocoa into TextInputClientMac except for attributedSubstringForProposedRange, which is idiosyncratic. Bug: 821651 Change-Id: Ib64f9823907ed96154a0c15ad18f96da2c58ad30 Reviewed-on: https://chromium-review.googlesource.com/1004296Reviewed-by:
-
Calder Kitagawa authored
With recent refactoring by etiennep@ marking high bits is no longer required. This removes checks for existing high bits which were previously filtered out to avoid conflicts with the marking system used. Change-Id: Iab929b19ade5c9faaf7c6be073136352170c794a Reviewed-on: https://chromium-review.googlesource.com/1002862 Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#549620}
-
Ashley Enstad authored
NOTRY=true Bug: 575318 Change-Id: I87541d2d30d66d8726d6ee1fc1896a086dae41d6 Reviewed-on: https://chromium-review.googlesource.com/1005351 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
-
