- 14 May, 2018 40 commits
-
-
Eric Roman authored
This was documentation relating to the internally available crash frontends and mailinglists. Change-Id: Ie4a89bb9cc663eaf9222f5dded29137dc39e2df8 Reviewed-on: https://chromium-review.googlesource.com/1055932 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#558511}
-
Hiroshige Hayashizaki authored
This CL removes |num_sources| arguments of WebLocalFrame::ExecuteScriptInIsolatedWorld() methods, because |num_sources| is always 1. This CL also renames WebLocalFrame::ExecuteScriptInIsolatedWorld() with |results| argument to WebLocalFrame::ExecuteScriptInIsolatedWorldAndReturnValue(). This CL shouldn't change the behavior. This is preparation for https://chromium-review.googlesource.com/721862. Bug: 841466 Change-Id: I4a6b2d9da9bfd052cabe9147dac8c9f7818367c4 Reviewed-on: https://chromium-review.googlesource.com/1048323Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#558510}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Iab0de9202356fb5105b93aade17ac4dd4dfeb19c Reviewed-on: https://chromium-review.googlesource.com/1058377 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558509}
-
Philip Rogers authored
CompositedLayerMapping::UpdateInternalHierarchy will orphan the main graphics layer if there are no special ancestor layers (for clips or squashing). PaintLayerCompositor::UpdateIfNeeded was responsible for re-parenting the main graphics layer using ParentForContentLayers, but this had a bug and would not re-parent in test configurations, leaving the graphics layer orphaned. Bug: 841423 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id5c9fe5b87e9a5c2d47cff4a105c13a885d82d48 Reviewed-on: https://chromium-review.googlesource.com/1056056 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558508}
-
Peter Boström authored
Adds a top-chrome-md entry for Touchable Material Refresh under chrome://flags which is Refresh with a looser Touchable layout. This change adds MATERIAL_TOUCH_REFRESH to MaterialDesignController which enables both IsTouchOptimizedUiEnabled() and IsNewerMaterialUi(). All calls to GetMode() have been audited to make sure MATERIAL_TOUCH_REFRESH doesn't go out of bounds for kValue[mode] indexes. Most of these values have been filled in with the same values as Touchable (except for NTB size and tab insets) but they are subject to change as this mode gets audited further. A new method IsRefreshUi() is added to the MaterialDesignController which is true for MATERIAL_REFRESH and MATERIAL_TOUCH_REFRESH. All explicit MATERIAL_REFRESH checks have been updated to use IsRefreshUi() instead of MATERIAL_REFRESH directly. Where this is incorrect and Touchable should take precedence the code will have to be updated to look at IsTouchOptimizedUiEnabled() first (in separate future changes). Bug: chromium:839972 Change-Id: If0c8bfbd3ce0b33c578260b9e4c8af9e7edc93e9 Reviewed-on: https://chromium-review.googlesource.com/1055875Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#558507}
-
Tom Sepez authored
Change-Id: Ib72f8206079d69805205fcd26591f7606ff6f9fa Reviewed-on: https://chromium-review.googlesource.com/1054143 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#558506}
-
Sigurdur Asgeirsson authored
The previous implementation read /proc/pid/task/tid/stat for each thread in the process. This had two issues: 1. When threads die, their CPU cost dies with them and so cumulative CPU cost for a process can go backwards. Reading /proc/pid/stat accounts for the cost due to dead threads. 2. It incurs a extra overhead to open all the individual task files that can be avoided by having the kernel do the tally in a single system call, and grabbing the relevant locks only once. For back story see e.g. https://crbug.com/546565. Bug: 841355 Change-Id: I82582e69187e4cd4069cf9dd02a4b62c326897e6 Reviewed-on: https://chromium-review.googlesource.com/1052811Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558505}
-
John Abd-El-Malek authored
I should have done this initially, but they're now past the point where they're large enough to be in their own file. TBR=nasko@chromium.org Change-Id: I328e03aea5f5a43407c5adb57f265cb64f300b82 Reviewed-on: https://chromium-review.googlesource.com/1057841 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#558504}
-
Johannes Henkel authored
This takes care of a mechanical part of https://chromium-review.googlesource.com/c/chromium/src/+/1035091. web_url_error.h is a public header file, so it's possible to then depend on this. Bug: 838291 Change-Id: Ib7dfb28094466661e0aa5e28a94926b923dbbf1f Reviewed-on: https://chromium-review.googlesource.com/1057950Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#558503}
-
Lukasz Anforowicz authored
Bug: 841549 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I259234712ef9dbef570bca26ce3e5028da6a83a3 Reviewed-on: https://chromium-review.googlesource.com/1053243 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#558502}
-
Bailey Berro authored
This change adds username and password as arguments that are passed from the Add Smb Share Dialog to Smb Browser Proxy to Smb Handler. This enables users to mount shares that require authentication. Bug: chromium:757625 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1cbc94e45a85cb6fe048a7456a8ff340c6fcd220 Reviewed-on: https://chromium-review.googlesource.com/1054694 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#558501}
-
Tibor Goldschwendt authored
If going to DD home and back to Chrome we won't always recreate VrShell. This could result in no assets being loaded. Load the assets in OnResume instead. This will also apply assets that may have been updated during a VR session. Bug: 812411 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I2fc6cf2d38a71f7483f5f818e46e48e3cc9bdb0e Reviewed-on: https://chromium-review.googlesource.com/1057870Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#558500}
-
Peng Huang authored
Bug: 842162 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9b99d9230b59f5962399be14ace79215c0d4988e Reviewed-on: https://chromium-review.googlesource.com/1054163Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558499}
-
Michael Spang authored
This fixes a validation error in vulkan_tests: [160937:160937:0511/145413.931833:81810095976:WARNING:vulkan_implementation.cc(39)] Object: 0x0 | vkCreateRenderPass: pCreateInfo->pAtta chments[0].format is VK_FORMAT_UNDEFINED. The spec valid usage text states 'format must be a valid VkFormat value' (https://www.khronos. org/registry/vulkan/specs/1.0/html/vkspec.html#VUID-VkAttachmentDescription-format-parameter) Bug: 840470 Test: vulkan_tests Change-Id: I71e978d93077a3bddfe3e454ceab55929494e4c8 Reviewed-on: https://chromium-review.googlesource.com/1055786 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
-
Owen Min authored
The dialog will be displayed during Chrome launch if it's blocked by network request. screenshot: https://drive.google.com/open?id=1v4nbbCyY5mo6yTffelxjGhhg-vwYJOrv https://drive.google.com/open?id=1qigP2YSjQNhuzbWtLDfIZZO5Jyoxy91u Bug: 840018 Change-Id: I95f07bc68ef0837d071004598d0473719e2cb528 Reviewed-on: https://chromium-review.googlesource.com/1045548Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558497}
-
Fady Samuel authored
This CL reduces IPC traffic if nnothing has changed on the parent side. We will only consider the LocalSurfaceId dirty if the parent sequence number or embed token has changed. Otherwise, we will not consider the LocalSurfaceId dirty and we will not send an unnecessary IPC that contains information that the child is already aware of. Bug: 672962 Change-Id: I35da312e74166d21d95ff5b24157f3cc20163160 Reviewed-on: https://chromium-review.googlesource.com/1057893 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#558496}
-
Christopher Grant authored
Child elements may align themselves to the edge of a parent, but may also contribute to parent boundaries. A particular element can't do both. We've been walking in a gray area by declaring that an element's size has been computed, but then finishing layout, and modifying size again. This CL moves to the following sequence: - Lay out all elements that contribute to parent boundaries - Compute parent boundary and set size - Lay out all elements that do not contribute to parent boundaries DCHECKs are added to catch elements that request positioning relative to their parent, but also claim to contribute to parent bounds. This CL is groundwork for potential new layout support, such as allowing a child to size according to its parent. BUG= Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: Id39da770847a2f275cd25110956629aba1e0649f Reviewed-on: https://chromium-review.googlesource.com/1054428 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#558495}
-
Xiaohan Wang authored
This helper makes it easier to pass in null callbacks by avoiding the long callback names. Also, base::NullCallback() would be more explicit that the callback is null than FooCallback(). This CL only converts *Decoder::WaitingForDecryptionKeyCB() to use base::NullCallback() as an example. More callbacks will be converted later. Bug: 842277 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I03bdf9d3ff6be30161b9e24118827377f5350d40 Reviewed-on: https://chromium-review.googlesource.com/1055854Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558494}
-
Min Chen authored
Focus on power button menu instead of "Power off" item when menu is opened. This is used to make sure PowerButtonMenuView can still handle the key events when menu is opened. Since we still need ESCAPE to dismiss the menu and TAB or direction keys to navigate between menu items. Bug: 842336 Change-Id: I4d951e6d520dd28e88362c85e25ef156a1252f30 Reviewed-on: https://chromium-review.googlesource.com/1056294 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Qiang Xu <warx@google.com> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#558493}
-
Amirhossein Simjour authored
Before this patch, setFocusable was ignoring its input params. There is no place that we call setFocusable(false), so this doesn't affect anything at the moment. Bug: None Change-Id: Id3cc348e1d5dba144ee44e08976785dd903c840d Reviewed-on: https://chromium-review.googlesource.com/1055655 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#558492}
-
Sadrul Chowdhury authored
This reverts commit 603b405c. Reason for revert: We have collected the dumps. So not needed anymore. Original change's description: > latency-info: Add a couple of investigative dumps. > > Add a couple of investigative dumps to understand better where and how > a large number of LatencyInfo objects are accumulating. > > BUG=834421 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ieea6e47c4a1acf5c89384048e19b742e3e21e5a8 > Reviewed-on: https://chromium-review.googlesource.com/1054153 > Reviewed-by: Fady Samuel <fsamuel@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557994} TBR=sadrul@chromium.org,fsamuel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 834421, 842505 Change-Id: I1acbb8d522cb12606071af82d40b96b2b4626d27 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1057362 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#558491}
-
Chris Harrelson authored
Bug: 831762 Change-Id: I0656bebfd64014fe52853029003833dc195537f7 Reviewed-on: https://chromium-review.googlesource.com/1056159 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
This patch adds the basic frame color change, protected by the Refresh flag. When the user has a single tab and no theme frame image, the frame will paint the same color as the active tab (effectively hiding it). Otherwise the behavior is the same as before. This patch does not hide the tab close button or do any animation. Bug: 841643 Change-Id: I62a797ffeee39b9f2646151d0ba224f21e7f0e04 Reviewed-on: https://chromium-review.googlesource.com/1054580Reviewed-by:
-
Adrienne Walker authored
This source set also needs to have the workaround built in Chrome for this to work. This should fix the compile error that caused https://skia-review.googlesource.com/c/skia/+/126581 to be reverted. Bug: 829614 Change-Id: I5226c74ea0b458a9ddb12fba560ad05a3077c09a Reviewed-on: https://chromium-review.googlesource.com/1058145Reviewed-by:
Brian Salomon <bsalomon@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#558488}
-
Lei Zhang authored
BUG=714018 Change-Id: Ia17a1dc5f1d06ea6d0af1301489526c9030d1d53 Reviewed-on: https://chromium-review.googlesource.com/1054779 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#558487}
-
Aldo Culquicondor authored
Bug: 842654 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I31f9326575d8f78e86fde26475099a417c244bb6 Reviewed-on: https://chromium-review.googlesource.com/1058187Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#558486}
-
Devlin authored
This reverts commit ea78046d. Reason for revert: Breaks windows compile. https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FWin_x64%2F22451%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Flogs%2Fraw_io.output_failure_summary_%2F0 [41184/59208] CXX obj/net/cert_verify_tool/cert_verify_tool.obj FAILED: obj/net/cert_verify_tool/cert_verify_tool.obj C:\b\c\goma_client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes "-imsvcC:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\Include\10.0.15063.0\um" "-imsvcC:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\Include\10.0.15063.0\shared" "-imsvcC:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\Include\10.0.15063.0\winrt" "-imsvcC:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\win_sdk\Include\10.0.15063.0\ucrt" "-imsvcC:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\VC\Tools\MSVC\14.11.25503\include" "-imsvcC:\b\c\win_toolchain\vs_files\1180cb75833ea365097e279efb2d5d7a42dee4b0\win_sdk\bin\..\..\VC\Tools\MSVC\14.11.25503\atlmfc\include" -DV8_DEPRECATION_WARNINGS -DUSE_AURA=1 -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D"CR_CLANG_REVISION=\"331747-1\"" -D_HAS_EXCEPTIONS=0 -D__STD_C -D_CRT_RAND_S -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -DDEPRECATEDENUMERATOR(x)=[[deprecated(x)]] -D_ATL_NO_OPENGL -D_WINDOWS -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DPSAPI_VERSION=1 -DWIN32 -D_SECURE_ATL -D_USING_V110_SDK71_ -DWINAPI_FAMILY=WINAPI_FAMILY_DESKTOP_APP -DWIN32_LEAN_AND_MEAN -DNOMINMAX -D_UNICODE -DUNICODE -DNTDDI_VERSION=0x0A000002 -D_WIN32_WINNT=0x0A00 -DWINVER=0x0A00 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGTEST_API_= -DGTEST_HAS_POSIX_RE=0 -DGTEST_LANG_CXX11=1 -DGTEST_HAS_TR1_TUPLE=0 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=wchar_t -DUNIT_TEST -I../.. -Igen -I../../third_party/googletest/custom -I../../third_party/googletest/src/googletest/include -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -I../../third_party/boringssl/src/include -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/googletest/custom -I../../third_party/googletest/src/googlemock/include /utf-8 /X -Wno-builtin-macro-redefined -D__DATE__= -D__TIME__= -D__TIMESTAMP__= -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 /Gy /FS /bigobj /d2FastFail /Zc:sizedDealloc- -fmsc-version=1911 -m64 /Brepro /W4 -Wimplicit-fallthrough -Wthread-safety /WX /wd4091 /wd4127 /wd4251 /wd4275 /wd4312 /wd4324 /wd4351 /wd4355 /wd4503 /wd4589 /wd4611 /wd4100 /wd4121 /wd4244 /wd4505 /wd4510 /wd4512 /wd4610 /wd4838 /wd4995 /wd4996 /wd4456 /wd4457 /wd4458 /wd4459 -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-null-pointer-arithmetic -Wno-ignored-pragma-optimize /O1 /Ob2 /Oy- /Zc:inline /Gw /Oi /MT -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare /wd4800 /wd4267 -Wno-inconsistent-missing-override /TP /wd4577 /GR- /c ../../net/tools/cert_verify_tool/cert_verify_tool.cc /Foobj/net/cert_verify_tool/cert_verify_tool.obj /Fd"obj/net/cert_verify_tool_cc.pdb" ../../net/tools/cert_verify_tool/cert_verify_tool.cc(121,49): error: no viable conversion from 'basic_string<char, std::char_traits<char>, std::allocator<char> >' to 'base::FilePath::StringPieceType' (aka 'BasicStringPiece<basic_string<wchar_t, char_traits<wchar_t>, allocator<wchar_t> > >') dump_path = dump_prefix_path.AddExtension("." + GetName() + ".pem"); ^~~~~~~~~~~~~~~~~~~~~~~~ ../..\base/strings/string_piece.h(161,39): note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'basic_string<char, std::char_traits<char>, std::allocator<char> >' to 'const base::BasicStringPiece<std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > > &' for 1st argument template <typename STRING_TYPE> class BasicStringPiece { ^ ../..\base/strings/string_piece.h(161,39): note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'basic_string<char, std::char_traits<char>, std::allocator<char> >' to 'base::BasicStringPiece<std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > > &&' for 1st argument ../..\base/strings/string_piece.h(184,13): note: candidate constructor not viable: no known conversion from 'basic_string<char, std::char_traits<char>, std::allocator<char> >' to 'const base::BasicStringPiece<std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > >::value_type *' (aka 'const wchar_t *') for 1st argument constexpr BasicStringPiece(const value_type* str) ^ ../..\base/strings/string_piece.h(186,3): note: candidate constructor not viable: no known conversion from 'basic_string<char, std::char_traits<char>, std::allocator<char> >' to 'const std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > &' for 1st argument BasicStringPiece(const STRING_TYPE& str) ^ ../..\base/files/file_path.h(295,41): note: passing argument to parameter 'extension' here FilePath AddExtension(StringPieceType extension) const WARN_UNUSED_RESULT; ^ 1 error generated. Original change's description: > Fix cert_verify_tool dump filename conflict between CertVerifyProc impls. > > Change-Id: Ia496ac5f5311871ebb234f8d725d3d902ae3f597 > Reviewed-on: https://chromium-review.googlesource.com/1058045 > Reviewed-by: Eric Roman <eroman@chromium.org> > Commit-Queue: Matt Mueller <mattm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558475} TBR=eroman@chromium.org,mattm@chromium.org Change-Id: Ib22e17d5a6f800fccbc69335c21fdc65c0df0ac6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1058389Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558485}
-
Rohit Rao authored
Makes BookmarkHomeViewController subclass UITableViewController instead of UIViewController. Moves the loading spinner and empty background view into BookmarkHomeViewController. BUG=840381,839439 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I935a99313eb3aa7f8701d46d803bea575e5bc89a Reviewed-on: https://chromium-review.googlesource.com/1056328Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#558484}
-
Fernando Serboncini authored
Bug: 833902 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifc1a9716a293e4e1f9020bb45e2a36336718364f Reviewed-on: https://chromium-review.googlesource.com/1055650 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#558483}
-
Varun Khaneja authored
Bug: 796332 Change-Id: Ia1ddddc9397531e60f6dd524bbec994154316ffb Reviewed-on: https://chromium-review.googlesource.com/1056163 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#558482}
-
Devlin Cronin authored
Update the UI for extensions that have had actions blocked on a page. Instead of the old 'x' placeholder, use the new assets. These include a "bubble" shown behind the extension icon with different colors for steady, hover, and pressed states. This won't work well with the ink drop that these buttons also use, but it's undecided exactly what we want the behavior there to be. For now, leave it as is. On mac, this only uses the steady state (never hovered or pressed). This is because there is a decent likelihood that MacViews will ship before this project, so it is perhaps not worth the complexity of adding hooks to be able to specify a hovered/pressed image. Bug: 834494 Change-Id: I5d02ee12df141d7d9c1d3ea79ded115af711caf2 Reviewed-on: https://chromium-review.googlesource.com/1037608 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Jennifer Apacible authored
Currently, video resolution changes will send the Picture-in-Picture window back to the original location (bottom right) with the original size of 20% of the display. This change will allow updating video resolution, but keep the window in the same location and only resize to adhere to the aspect ratio. BUG: 839988 Change-Id: I58a21edeb11c1aa6b0338d381c245d75939e5a31 Reviewed-on: https://chromium-review.googlesource.com/1045268 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#558480}
-
Kim Paulhamus authored
In GmsCore v19, the Fido2 APIs will provide the unified functionality of the U2F and Fido2 APIs so it will no longer be necessary to call both of them. Since the rename spans upstream and downstream, will initially add all Fido2* classes and then later remove the U2f* classes once downstream changes have landed. Bug: 842006 Change-Id: I4775682b428c0ffdc4aa6f699136a2c7d15ee40c Reviewed-on: https://chromium-review.googlesource.com/1054778Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#558479}
-
Matt Mueller authored
Change-Id: I5480084ee5818a3ad813b75427262a266a699d23 Reviewed-on: https://chromium-review.googlesource.com/1058042Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#558478}
-
Sunny Sachanandani authored
Command line flags override checks for hardware support so they shouldn't be counted in UMA. However, we should log the hardware support, and initialize globals even if overlays are disabled via command line flags. Also guard against globals not being initialized. R=zmo BUG=837378 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idfcab896a7e1671ebe0446e657f093a4cd1f5169 Reviewed-on: https://chromium-review.googlesource.com/1034021 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#558477}
-
Chris Nardi authored
Some assert_throws statements did not include expected exceptions, which broke their respective tests following a testharness.js update. Add expected exceptions for all assert_throws statements. The only functional change was to fast/serviceworker/serviceworker-interface.html as per the spec ServiceWorker extends EventTarget and not Worker. Bug: 754365 Change-Id: I733605d721085788d43e179ca6f9a7c7b25da995 Reviewed-on: https://chromium-review.googlesource.com/1056253Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558476}
-
Matt Mueller authored
Change-Id: Ia496ac5f5311871ebb234f8d725d3d902ae3f597 Reviewed-on: https://chromium-review.googlesource.com/1058045Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/77c223be193b..a7ff4dc7c27c $ git log 77c223be1..a7ff4dc7c --date=short --no-merges --format='%ad %ae %s' 2018-05-14 dsinclair Cleanup CPDF_Form parsing code Created with: roll-dep src/third_party/pdfium BUG=chromium:813349 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic2e83914ab3a7df850858f8af5570c0bbeb67ec7 Reviewed-on: https://chromium-review.googlesource.com/1058139 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558474}
-
Chris Harrelson authored
An earlier patch (commit e931d2ae) changed code in MapToVisualRectInAncestorSpace to omit fixed-position scroll in cases where the containing block was the LayoutView and a counter-scroll would have been applied in the LayoutView anyway. This fixed a bug in which a clip was applied in-between in the wrong space. The CL introduced a bug, however, in the case when the LayoutView was the desired ancestor passed to MapToVisualRectInAncestorSpace. In this case we should apply the counter scroll in LayoutView, because the results of MapToVisualRectInAncestorSpace are in the unscrolled space of the LayoutView. Note that LayoutBox::MapToVisualRectInAncestorSpace already has code to skip fixed-position scroll and clip if container == ancestor, independent of the above commit. Bug:841194 Change-Id: Ia05894dd94bdb3b0503cbb155728b0ef074b0227 Reviewed-on: https://chromium-review.googlesource.com/1058039Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#558473}
-
Kevin Bailey authored
When comparing 2 URLs for equality in StrippedURLsAreEqual() - one a suggestion and one an open tab - we were passing the user input to only one of the reductions - the suggestion, since the suggestion was based on it, and because the open tab was assumed to be already cleaned up. Instead, the input causes rules to be applied to the suggestion URL which must also be applied to the open tab URL, so that, if equal, they compare equal. This CL changes the comparison to pass the input to both reductions so that we're comparing apples to apples. Bug: 842170 Change-Id: Ib88d7306b25ceaf9b1441366e66199620e107492 Reviewed-on: https://chromium-review.googlesource.com/1055670 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
-
