- 13 Jan, 2015 40 commits
-
-
Ryan Hamilton authored
TBR=miu@chromium.org BUG=448511 Review URL: https://codereview.chromium.org/841873005 Cr-Commit-Position: refs/heads/master@{#311338}
-
dnicoara authored
GBM surface mode requires synchronous page flips at the moment. We need to set DriWrapper to synchronously page flip. BUG=none NOTRY=true Review URL: https://codereview.chromium.org/847213002 Cr-Commit-Position: refs/heads/master@{#311337}
-
Sadrul Habib Chowdhury authored
Instead of storing information in TouchFactory (which is X11 specific), store the maximum number of touch-points supported by a device in platform agnostic TouchscreenDevice. Use this TouchscreenDevice to compute the maximum number of simultaneous touch-points supported at runtime. BUG=none R=dnicoara@chromium.org, oshima@chromium.org, spang@chromium.org Review URL: https://codereview.chromium.org/845413002 Cr-Commit-Position: refs/heads/master@{#311336}
-
kpschoedel authored
Refactor code converting located (e.g. VKEY_LSHIFT) and non-located (e.g. VKEY_SHIFT) versions of ui::KeyboardCode. BUG=444048 Review URL: https://codereview.chromium.org/796003005 Cr-Commit-Position: refs/heads/master@{#311335}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/9877b72..2a7b861 TBR=hayato@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/852613002 Cr-Commit-Position: refs/heads/master@{#311334}
-
derat authored
Make the Chrome OS implementation of CheckIdleStateIsLocked() (used by the chrome.idle API) get the lock state from chromeos::SessionManagerClient instead of depending on ash::SessionStateDelegate (which reaches into chrome/browser/chromeos/login/). This makes it possible for the idle code to be later moved under ui/base/ instead of living in chrome/browser/, permitting the chrome.idle API to be moved from chrome/ to extensions/. As part of this, make SessionManagerClient cache the most-recently-received-from-session_manager screen-lock state. Previously it just passed state updates to its observers, but the idle functions lack a class that can register itself as an observer. BUG=446320 Review URL: https://codereview.chromium.org/852453005 Cr-Commit-Position: refs/heads/master@{#311333}
-
oshima authored
BUG=None Review URL: https://codereview.chromium.org/835683004 Cr-Commit-Position: refs/heads/master@{#311332}
-
rtenneti authored
R=rch@chromium.org Review URL: https://codereview.chromium.org/852513002 Cr-Commit-Position: refs/heads/master@{#311331}
-
xunjieli authored
This CL is to fix crash in cronet builder, http://build.chromium.org/p/chromium.fyi/builders/Android%20Cronet%20Builder/builds/6248 Review URL: https://codereview.chromium.org/848933002 Cr-Commit-Position: refs/heads/master@{#311330}
-
sbc authored
The newlib version of getcwd in libnacl now supports passing NULL of buffer, and recent version of gtest will gracefully handle getcwd failure in static constructors so we no longer need our own getcwd implementation. This is the second attempt and landing this change. The first was reverted: https://codereview.chromium.org/756333005 R=bradnelson Review URL: https://codereview.chromium.org/851723004 Cr-Commit-Position: refs/heads/master@{#311329}
-
mariakhomenko authored
Upstreams parts of AutocompleteController dealing with voice suggestions. Upstreams VoiceSuggestionProvider and VoiceSuggestionProviderTest. BUG=428863 Review URL: https://codereview.chromium.org/789103011 Cr-Commit-Position: refs/heads/master@{#311328}
-
holte authored
Testing for this fix to be added by https://codereview.chromium.org/845863002/ BUG=448269 Review URL: https://codereview.chromium.org/848823002 Cr-Commit-Position: refs/heads/master@{#311327}
-
johnme authored
Previously, if CHROMIUM_OUT_DIR was set but blank, it could (and did!) delete your entire source directory, including .git folder. BUG=446921 Review URL: https://codereview.chromium.org/832933004 Cr-Commit-Position: refs/heads/master@{#311326}
-
davidben authored
The OpenSSL and BoringSSL ports support one additional CHACHA20_POLY1305 variant. Add it to the list so it gets categorized correctly. (diff is large because presubmit wanted a git cl format.) BUG=none Review URL: https://codereview.chromium.org/809743005 Cr-Commit-Position: refs/heads/master@{#311325}
-
rouslan authored
BUG=447299 Review URL: https://codereview.chromium.org/851783002 Cr-Commit-Position: refs/heads/master@{#311324}
-
rtenneti authored
options. Deprecates quic_prober.cc in the process as all (used) functionality now also in quic_client_bin.cc. Uses std::cout/cerr instead of LOG() statements, and is has hopefully more easily parseable output (especially for those off-team) than the previous tool. Removed the "print_response" argument to QuicClient, instead QuicClient has accessor's to the latest response code/headers/body if a user wants to print details (the only user of this feature is quic_client_bin). Examples of output: $ quic_client http://www.google.com/ipz --quiet --host=74.125.137.103 Connected to 74.125.137.103:80 Request succeeded (200). $ quic_client http://www.google.com/invalid --quiet --host=74.125.137.103 Connected to 74.125.196.105:80 Request failed (404). $ quic_client http://www.example.com --host=93.184.216.34 Failed to connect to 93.184.216.34:80. Error: QUIC_CONNECTION_TIMED_OUT $ quic_client http://www.google.com/ipz --host=74.125.137.103 Connected to 173.194.37.84:80 Request: headers: :authority: http://www.google.com :method: GET :path: /ipz :scheme: http body: Response:headers: HTTP/1.1 200 OK Content-Length: 13 content-type: text/html; charset=UTF-8 date: Tue, 30 Dec 2014 20:34:50 GMT server: GFE/2.0 x-google-backends: acdd12:80 x-google-gfe-request-trace: acdd12:80 x-google-gfe-response-code-details-trace: handling_ipz x-google-gfe-service-trace: x-google-service: _internal body: 172.26.18.85 Request succeeded (200). TODO: make --host optional by getting IP Address of URL's host. Merge internal change: 83518478 R=rch@chromium.org Review URL: https://codereview.chromium.org/847813005 Cr-Commit-Position: refs/heads/master@{#311323}
-
jmedley authored
* Style changes to make the content look more like said site. * Change the path to the css file to match said site so that pages may be duplicated with changing them. BUG= Review URL: https://codereview.chromium.org/844073002 Cr-Commit-Position: refs/heads/master@{#311322}
-
ajuma authored
TBR=nduca Review URL: https://codereview.chromium.org/853523002 Cr-Commit-Position: refs/heads/master@{#311321}
-
dtseng authored
Observe OnExtensionLoaded to trigger update of chrome.commands keybindings for component extensions. ExtensionRegistryObserver::OnExtensionWillBeInstalled only triggers when a component extension loads for the first time on a new profile. As a result, component extensions using the commands api never get their commands manifest block re-parsed on an update. The fix is to observe load to trigger update of keybindings which differs from what happens in ExtensionKyebindingRegistry's OnExtensionLoaded; namely, the kExtensionBindings pref gets set in the former only. BUG=440459 TEST=manually edit a component extension's manifest command keybinding. Load the component extension and observe the keybinding changes and triggers on the new keybinding. Review URL: https://codereview.chromium.org/788973002 Cr-Commit-Position: refs/heads/master@{#311320}
-
Ken Rockot authored
BUG=448482 TBR=jamescook@chromium.org Review URL: https://codereview.chromium.org/848083002 Cr-Commit-Position: refs/heads/master@{#311319}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/f361b71..199ba8e CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=djsollen@google.com Review URL: https://codereview.chromium.org/851673004 Cr-Commit-Position: refs/heads/master@{#311318}
-
newt authored
Previously, GoogleLocationSettingsHelper could be "overridden" only by compiling in a different implementation of the static method GoogleLocationSettingsHelper::Create(). This complicates the build targets (since the default implementation of Create() can't be defined in shared code, since test code needs a different implementation), and complicates the process of upstreaming the internal implementation of GoogleLocationSettingsHelper. This CL keeps the static method, but adds a new method for overriding the GoogleLocationSettingsHelper: GeolocationPermissionContextAndroid::SetGoogleLocationSettingsHelperForTests(). In a later CL, the static method will be removed. BUG=448400 Review URL: https://codereview.chromium.org/852593002 Cr-Commit-Position: refs/heads/master@{#311317}
-
rtenneti authored
Refactoring of some QUIC code for readability. Merge internal change: 83493327 https://codereview.chromium.org/848513002/ Squelch a variety of "GMOCK WARNING" messages in quic_session_test by using a StrictMock, and adding the necessary EXPECT_CALL()s. Merge internal change: 83469149 https://codereview.chromium.org/842223006/ Attach QuicAckNotifiers to the serialized packet, instead of individual stream frames. Protected behind FLAGS_quic_attach_ack_notifiers_to_packets. A call to QuicPacketGenerator::ConsumeData may result in multiple stream frames, in multiple packets, being created to hold the data. Previously the QuicAckNotifier was attached to each *frame*, but really it should be attached to the serialized *packet* as the notifier is interested in knowing when the *packet* gets ACKed. No behavior change intended. Added an end to end test demonstrating that the AckNotifier works in the face of 30% packet loss. Earlier rch and I were sceptical this refactor would work with retransmissions, but the QuicAckNotifierManager still recieves calls to UpdateSequenceNumber and does the right thing. Merge internal change: 83452063 https://codereview.chromium.org/819653006/ Removing deprecated flag FLAGS_allow_truncated_connection_ids_for_quic Merge internal change: 83439062 https://codereview.chromium.org/843213002/ R=rch@chromium.org Review URL: https://codereview.chromium.org/789103013 Cr-Commit-Position: refs/heads/master@{#311316}
-
chrishenry authored
TracingController now directly communicates with DevToolsClientBackend instead. This allows us to use TracingController on Android app as well. BUG=443897 Review URL: https://codereview.chromium.org/842303002 Cr-Commit-Position: refs/heads/master@{#311315}
-
dpolukhin authored
Works partially because GAIA cannot send password from webview. BUG=426316 TEST=manual Review URL: https://codereview.chromium.org/789353004 Cr-Commit-Position: refs/heads/master@{#311314}
-
tedchoc authored
BUG=344589 Review URL: https://codereview.chromium.org/846123002 Cr-Commit-Position: refs/heads/master@{#311313}
-
lizeb authored
In the vast majority of cases (no update and no locale change), there is actually nothing to extract at startup. This commit fixes the logic that allows for a quick exit in this case. Instrumentation shows that the cost of the useless checks that are currently done is very large (400+ms on hammerhead with Lollipop for a cold start). Add instrumentation to the Android resource extraction. The instrumentation uses android.os.Trace instead of the more common org.chromium.base.TraceEvent as the resource extraction is typically done before the native library initialization, so TraceEvent calls are dropped (per TraceEvent documentation). BUG=445718 Review URL: https://codereview.chromium.org/808053005 Cr-Commit-Position: refs/heads/master@{#311312}
-
sdefresne authored
Remove obsolete notification NOTIFICATION_TOP_SITES_LOADED as no code was registering to receive it. Port all clients of notification NOTIFICATION_TOP_SITES_CHANGED to instead be history::TopSitesObserver and remove the notification that is no longer useful. ChromeHistoryClient is no longer a history::TopSitesObserver as it does not have to convert the events into notification. Remove the functionality and references to Profile and TopSites. BUG=373329 Review URL: https://codereview.chromium.org/845013002 Cr-Commit-Position: refs/heads/master@{#311311}
-
newt authored
This upstreams code to support partner customizations, i.e. partner bookmarks, disabling incognito mode, and setting a homepage. BUG=444675 NOTRY=true Review URL: https://codereview.chromium.org/839663003 Cr-Commit-Position: refs/heads/master@{#311310}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/fa64cdb..9877b72 TBR=hayato@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/807653004 Cr-Commit-Position: refs/heads/master@{#311309}
-
michaeln authored
BUG=448082 Review URL: https://codereview.chromium.org/798883005 Cr-Commit-Position: refs/heads/master@{#311308}
-
rsadam authored
BUG=447642, 444669 Review URL: https://codereview.chromium.org/850573004 Cr-Commit-Position: refs/heads/master@{#311307}
-
darin authored
Review URL: https://codereview.chromium.org/834153003 Cr-Commit-Position: refs/heads/master@{#311306}
-
paulmeyer authored
This patch disables the flaky test "WebViewAPITest.TestAutosizeAfterNavigation" while I investigate the problem. TBR=fsamuel@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/847433004 Cr-Commit-Position: refs/heads/master@{#311305}
-
johnme authored
Since FutureData didn't properly clear its state after a get(), it was possible a piece of data provided via set() to be sent back twice to the test code! Replaced it with a queue data structure that doesn't have these problems (and also won't lose data in the event that test code causes two or more results to be asynchronously generated before getting the results, though so far I think we've been lucky on that front). BUG=437277 Review URL: https://codereview.chromium.org/822203006 Cr-Commit-Position: refs/heads/master@{#311304}
-
estade authored
These aren't editable locally. There will eventually be a UI for "forgetting" the unmasked ones and a button to take you to the wallet web interface or app to make edits. BUG=none Review URL: https://codereview.chromium.org/845173003 Cr-Commit-Position: refs/heads/master@{#311303}
-
kalman authored
APIs with it. Devtools APIs are written by hand and don't need to be compiled (moreover, it crashes when you try). BUG=356133 R=mek@chromium.org Review URL: https://codereview.chromium.org/850603003 Cr-Commit-Position: refs/heads/master@{#311302}
-
alph authored
- \n between events - move category field past ones having a fixed width. Review URL: https://codereview.chromium.org/821033002 Cr-Commit-Position: refs/heads/master@{#311301}
-
derekjchow authored
Removes TagAppStart as its functionality is redundant. Also separates out updating SDK info into UpdateSDKInfo. R=byungchul@chromium.org BUG= Review URL: https://codereview.chromium.org/836923003 Cr-Commit-Position: refs/heads/master@{#311300}
-
jonross authored
This change renames ScreenOrientationDelegate to ScreenOrientationController to reflect on the new responsibilities that it is assuming. The tracking of the accelerometer screen rotation, as well as the rotation lock, has been moved from MaximizeModeController to ScreenOrientationController. ScreenOrientationController is now responsible for all rotation lock requests, from both TouchView user interface controls, as well as the Screen Orientation JavaScript API. ScreenOrientationController is Chrome OS only. Classes using the rotation lock API have been updated to only do so on Chrome OS. Screen rotation tests have been moved from MaximizeModeControllerTest to ScreenOrientationControllerTest. Other unittests have been updated to reflect the Chrome OS change. All pre-existing tests for rotation behaviour have been ran. Manual testing of both TouchView and Screen Orientation API have been done. TEST=ScreenOrientationControllerTest, TrayRotationLockTest, MaximizeModeControllerTest, DisplayPreferencesTest BUG=396760 Review URL: https://codereview.chromium.org/759063002 Cr-Commit-Position: refs/heads/master@{#311299}
-