GitLab

This isn't as ugly as the crazy null check, and it seems to be compiled correctly.

BUG=

Review URL: https://codereview.chromium.org/427003008

Cr-Commit-Position: refs/heads/master@{#288481}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288481 0039d316-1c4b-4281-b951-d872f2087c98

Calling connect() would not fail if there was an error connecting. Instead it
would return 0 (success) and fail on the first read/write.

The fix is to check SocketNode::last_errno_ after the wait succeeds.

BUG=none
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/458563002

Cr-Commit-Position: refs/heads/master@{#288480}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288480 0039d316-1c4b-4281-b951-d872f2087c98

NSFont returns fractional values for font metrics. We were truncating the
values, causing text to appear too high vertically. The fix is to apply the
ceiling function instead.

BUG=401345

Review URL: https://codereview.chromium.org/445363006

Cr-Commit-Position: refs/heads/master@{#288479}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288479 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288478}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288478 0039d316-1c4b-4281-b951-d872f2087c98

Hash copied at https://codereview.chromium.org/449673003/.

R=iannucci@chromium.org
BUG=400830

Review URL: https://codereview.chromium.org/447183005

Cr-Commit-Position: refs/heads/master@{#288477}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288477 0039d316-1c4b-4281-b951-d872f2087c98

No functional change, only making the behavior of the functions more obvious.

Retail mode is obsolete in R38 and later according to crbug.com/372703 and not supported anymore after this change.

BUG=NONE
(for chrome/browser/metrics/perf_provider_chromeos.cc, API usage)
TBR=isherman@chromium.org

Review URL: https://codereview.chromium.org/450363002

Cr-Commit-Position: refs/heads/master@{#288476}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288476 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401286

Review URL: https://codereview.chromium.org/447903003

Cr-Commit-Position: refs/heads/master@{#288475}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288475 0039d316-1c4b-4281-b951-d872f2087c98

Added a dependency on "mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom" to validation_unittests.js, just to prove that the bindings can be parsed.

BUG=401977

Review URL: https://codereview.chromium.org/452963002

Cr-Commit-Position: refs/heads/master@{#288474}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288474 0039d316-1c4b-4281-b951-d872f2087c98

- add benchmark option
- add multi-thread support
- convert from c to cpp (inc. ppapi)
BUG=NONE
TEST=this is a demo

R=binji@chromium.org

Review URL: https://codereview.chromium.org/451883002

Cr-Commit-Position: refs/heads/master@{#288473}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288473 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396275

Review URL: https://codereview.chromium.org/445493002

Cr-Commit-Position: refs/heads/master@{#288472}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288472 0039d316-1c4b-4281-b951-d872f2087c98

- wrap the title text
- removes the extra single pixel white border at the top.

BUG=401817

Review URL: https://codereview.chromium.org/457723002

Cr-Commit-Position: refs/heads/master@{#288471}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288471 0039d316-1c4b-4281-b951-d872f2087c98

R=luken@chromium.org

Review URL: https://codereview.chromium.org/459563002

Cr-Commit-Position: refs/heads/master@{#288470}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288470 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401881, 287883

Review URL: https://codereview.chromium.org/449993004

Cr-Commit-Position: refs/heads/master@{#288469}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288469 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/459433002

Cr-Commit-Position: refs/heads/master@{#288468}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288468 0039d316-1c4b-4281-b951-d872f2087c98

I saw it flake even with reruns: http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/881

BUG=396414
TBR=janx@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/451173002

Cr-Commit-Position: refs/heads/master@{#288467}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288467 0039d316-1c4b-4281-b951-d872f2087c98

This CL enables the user to launch the chrome remote desktop app directly into an immersive it2me helper session.
In the immersive session, the app will
1. hide the home screen
2. create an hrd_helper_session object to communicate with the it2me_background service.

Review URL: https://codereview.chromium.org/439923002

Cr-Commit-Position: refs/heads/master@{#288466}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288466 0039d316-1c4b-4281-b951-d872f2087c98

The FailedDataTypeHandler is now informed immediately of failures, including
datatype errors, and is therefore authoritative source for all errors. As such,
partial success is no longer tracked and the various ModelTypeSets for error
types in configure results are removed.

BUG=368834

Review URL: https://codereview.chromium.org/420633002

Cr-Commit-Position: refs/heads/master@{#288464}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288464 0039d316-1c4b-4281-b951-d872f2087c98

I saw it flake even with reruns: http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/977

BUG=282116
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/451183002

Cr-Commit-Position: refs/heads/master@{#288463}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288463 0039d316-1c4b-4281-b951-d872f2087c98

On right click in editable node context menu was always having 'paste'
option as enabled. Added check that if clipboard is not empty
then only show 'paste' option.

BUG=396616

Review URL: https://codereview.chromium.org/443073002

Cr-Commit-Position: refs/heads/master@{#288461}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288461 0039d316-1c4b-4281-b951-d872f2087c98

BUG=254804
TBR=hirono@chromium.org
TEST=manually tested.

Review URL: https://codereview.chromium.org/451123002

Cr-Commit-Position: refs/heads/master@{#288460}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288460 0039d316-1c4b-4281-b951-d872f2087c98

Rename ValidatePage/MeasurePage -> ValidateAndMeasurePage for all files outside tools/telemetry and tools/perf.

BUG=383635

Review URL: https://codereview.chromium.org/452123002

Cr-Commit-Position: refs/heads/master@{#288459}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288459 0039d316-1c4b-4281-b951-d872f2087c98

Surface loss is only detected via the callback.

We can tolerate multiple calls to InitializeRenderer without
needing the lost-surface callback in between.

Remove Renderer::IsContextLost, but keep GLRenderer::IsContextLost.

Remove ThreadProxy::CheckOutputSurfaceStatusOnImplThread

BUG=392891

Review URL: https://codereview.chromium.org/446973002

Cr-Commit-Position: refs/heads/master@{#288457}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288457 0039d316-1c4b-4281-b951-d872f2087c98

Right now, SSLBlockingPage has both overridable_ and strict_enforcement_. 
This CL collapses both into overridable_, so that we only need to check one. 
However, strict_enforcement_ also remains on its own because it is checked 
separately in one place.

BUG=
R=palmer@chromium.org

Review URL: https://codereview.chromium.org/448163002

Cr-Commit-Position: refs/heads/master@{#288456}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288456 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288455}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288455 0039d316-1c4b-4281-b951-d872f2087c98

BUG=109173
TEST=none
R=jam@chromium.org
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/457823002

Cr-Commit-Position: refs/heads/master@{#288454}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288454 0039d316-1c4b-4281-b951-d872f2087c98

We still need to expose these to apps, and transition things
appropriately.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/454603002

Cr-Commit-Position: refs/heads/master@{#288453}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288453 0039d316-1c4b-4281-b951-d872f2087c98

[DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManager.

Previously, client used methods on DevToolsManager passing |this| to most of them.
Instead, it should hold a scoped_refptr to inspected DevToolsAgentHost and talk
to it directly. This creates a single clean entry point for the client, and allows
in the future to handle browser-wide protocol messages and debug multiple hosts at once.

BUG=401073
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/449043002

Cr-Commit-Position: refs/heads/master@{#288452}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288452 0039d316-1c4b-4281-b951-d872f2087c98

Also added the code to store owner info into boot lockbox during enrollment.

BUG=chromium:353050
TEST=unit_tests

Review URL: https://codereview.chromium.org/438493002

Cr-Commit-Position: refs/heads/master@{#288451}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288451 0039d316-1c4b-4281-b951-d872f2087c98

Cleanup: Remove unneeded #includes for grit/, ui/base/l10n/l10n_util.h and ui/base/resource/resource_bundle.h.

For files that have #include from the list above, the heuristics for determining if the #includes are needed are as follows:

grit -> with a few exceptions, grep for ID[RS]
l10n_util.h -> grep l10n_util::
resource_bundle.h -> egrep
'(GetImageNamed|GetNativeImageNamed|GetRawDataResource|GetLocalizedString|GetImageSkiaNamed|ResourceBundle)'

Review URL: https://codereview.chromium.org/454583002

Cr-Commit-Position: refs/heads/master@{#288450}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288450 0039d316-1c4b-4281-b951-d872f2087c98

Re-submit of https://codereview.chromium.org/425363002/

TBR=sky, oshima
BUG=NONE

Review URL: https://codereview.chromium.org/445173002

Cr-Commit-Position: refs/heads/master@{#288449}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288449 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402164
TBR=avi@chromium.org

Review URL: https://codereview.chromium.org/453153002

Cr-Commit-Position: refs/heads/master@{#288448}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/452313003

Cr-Commit-Position: refs/heads/master@{#288447}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288447 0039d316-1c4b-4281-b951-d872f2087c98

BUG=401571

Review URL: https://codereview.chromium.org/455533002

Cr-Commit-Position: refs/heads/master@{#288446}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288446 0039d316-1c4b-4281-b951-d872f2087c98

Instead of using AudioRendererAlgorithm's timestamp as the ending
timestamp and counting "backwards", count "forwards" from a starting
timestamp to compute the current media time. Doing so produces more
accurate time calculations during periods where the playback rate
is changing.

last_endpoint_timestamp() is replaced by a new method that computes
the amount of contiguous media data buffered by audio hardware. Using
this value gives a more accurate maximum time value to use when doing
linear interpolation.

BUG=367343,370634

Review URL: https://codereview.chromium.org/436053002

Cr-Commit-Position: refs/heads/master@{#288445}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288445 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
BUG=402135

Original issue's description:
> Keep a copy of page id in RenderViewHost.
> 
> Also, ensure that it stays in sync with the renderer's copy.
> 
> BUG=99379,369661
> TEST=no CHECKs hit in the wild, all tests stay green
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288196

TBR=creis@chromium.org,tsepez@chromium.org,nick@chromium.org,avi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=99379,369661

Review URL: https://codereview.chromium.org/452303003

Cr-Commit-Position: refs/heads/master@{#288444}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288444 0039d316-1c4b-4281-b951-d872f2087c98

Since the hosts are stored in DNS wire format (with length-prefixed labels),
any labels that start with a digit cause an escape like "\0071..." (that's
length=7, first byte of the label = "1"). But this causes a warning in Visual
Studio and breaks the build.

This change splits the length bytes from the labels so that this warning
doesn't happen.

BUG=none
R=palmer@chromium.org

Review URL: https://codereview.chromium.org/456853002

Cr-Commit-Position: refs/heads/master@{#288443}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288443 0039d316-1c4b-4281-b951-d872f2087c98

The error should be reported to IPC::Listener as it is a
signal of the dead peer. Without this, the browser cannot
detect renderer crashes.

TEST=browser_tests (with ChannelMojo enabled)
R=viettrungluu@chromium.org,darin@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/453643003

Cr-Commit-Position: refs/heads/master@{#288442}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=390267

Review URL: https://codereview.chromium.org/453053002

Cr-Commit-Position: refs/heads/master@{#288441}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288441 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TBR=maruel

Review URL: https://codereview.chromium.org/458503002

Cr-Commit-Position: refs/heads/master@{#288440}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288440 0039d316-1c4b-4281-b951-d872f2087c98

Current implementation assumes that current UI language is the first language
on the list. It works now but might break in the future.
To avoid that we should select current UI language on left pane
before making any checks.

R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/399353006

Cr-Commit-Position: refs/heads/master@{#288439}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288439 0039d316-1c4b-4281-b951-d872f2087c98