GitLab

BUG=304341
R=jam@chromium.org

Review URL: https://codereview.chromium.org/129813006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244265 0039d316-1c4b-4281-b951-d872f2087c98

TBR=torne@chromium.org

Review URL: https://codereview.chromium.org/134483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244264 0039d316-1c4b-4281-b951-d872f2087c98

deterministic.

An uninitialized member variable was at fault.

R=thakis@chromium.org

Review URL: https://codereview.chromium.org/131933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244260 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284553
TEST=none due to that this is a tool
R=fgorski@chromium.org, zea@chromium.org

Review URL: https://codereview.chromium.org/132193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244259 0039d316-1c4b-4281-b951-d872f2087c98

Lint has been running on FYI bots for a while,
time to enable them by default on bots and for developers.

BUG=None
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/127383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/134203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244255 0039d316-1c4b-4281-b951-d872f2087c98

Replace content::InputEvent usage with blink::WebInputEvent usage in synthetic
gesture dispatch.  This affords the SyntheticGestureTarget a chance to generate
the necessary ui::LatencyInfo components prior to event dispatch, simplifying
the hooks necessary for telemetry and easing the burden on the gesture dispatch
caller.

BUG=246034

Review URL: https://codereview.chromium.org/134123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=328742
R=skuhne@chromium.org

Review URL: https://codereview.chromium.org/134653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244253 0039d316-1c4b-4281-b951-d872f2087c98

Release builds of Android use specialized code for loading shared libraries.
The code queries |isLowEndDevice()| before about:flags has propagated to the
process command-line, yielding inconsistent low-end device configurations
between processes.  This can potentially lead to a state where all tabs are
blank, forcing the user to re-install Chrome. Remove the about:flags entry
until the query can be either deferred or removed entirely.

BUG=331931
NOTRY=true

Review URL: https://codereview.chromium.org/133133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244252 0039d316-1c4b-4281-b951-d872f2087c98

Merges the settings for use_alsa and use_pulseaudio for selection
based on use_cras.  As a consequence, removes linking of ALSA when
use_cras=1, which should result in a small binary size savings.

BUG=none
TEST=Pulse is available along with ALSA when chromeos=1.
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244098

Review URL: https://codereview.chromium.org/132773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244251 0039d316-1c4b-4281-b951-d872f2087c98

First time broke the build with a non-ASCII character in a comment.

BUG=320090
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/131833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244250 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333092

Review URL: https://codereview.chromium.org/132533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244249 0039d316-1c4b-4281-b951-d872f2087c98

The behavior is equivalent to taking the screenshot via VKEY_PRINT keyboard shortcut.

BUG=196658

Review URL: https://codereview.chromium.org/132233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244248 0039d316-1c4b-4281-b951-d872f2087c98

Addresses a flaky ASAN failure where I believe callbacks from ImpulseCallbackCounter with an unretained reference were being held too long by ProcessManager.

This clears the callbacks immediately when the impulse count is reached, and does not call the quit closure repeatedly.

BUG=332440

Review URL: https://codereview.chromium.org/129243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244247 0039d316-1c4b-4281-b951-d872f2087c98

Removes individual instances of Details structure in WindowResizer subclasses and adds DragDetails to WindowState. It is possible to access the current WindowResizer during the drag via window_state->drag_details()->window_resizer.
Simplifies construction of WindowResizer chain by creating DragDetails once at a point where creation of the resizer chain is imminent (after all checks that would return empty WindowResizer object are made).

Keeps track of whether currently dragged window is a panel attached to the shelf and if so prevents it from indicating that it can be docked (and from getting docked).

BUG=310931

Review URL: https://codereview.chromium.org/121153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244246 0039d316-1c4b-4281-b951-d872f2087c98

In http://src.chromium.org/viewvc/chrome?view=revision&revision=243849
I accidently caused the startup tests to run the default navigate
step. This reverts this, while still making the start with URL tests
run their navigate steps (which they need to do).

BUG=333052
R=dtu@chromium.org

Review URL: https://codereview.chromium.org/134793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244245 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
http://crbug.com/308846

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244005

Review URL: https://codereview.chromium.org/128753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=241277, 333263
R=rdsmith@chromium.org
TBR=rdsmith@chromium.org

Review URL: https://codereview.chromium.org/134803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244243 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244242 0039d316-1c4b-4281-b951-d872f2087c98

Finally! GetDefaultProfile goes away for good!

With that I also cleaned up that class and ripped out ancient unneeded functions / type-defs. Re-ordered the function declarations and so on. I am sure that more could be done here, but please first get rid of this function before it gets more children...

BUG=322682
TEXT=covered by existing unit tests

Review URL: https://codereview.chromium.org/132713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244241 0039d316-1c4b-4281-b951-d872f2087c98

Also, IndexedDBContextImpl used to maintain a map of open
connections. This change also deletes this map, and instead
relies on one which already exists in IndexedDBFactory.

BUG=259564

Review URL: https://codereview.chromium.org/93873017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244240 0039d316-1c4b-4281-b951-d872f2087c98

After refactoring there is no need for a separate DeviceData class
anymore, so removing it.

BUG=261165

Review URL: https://codereview.chromium.org/59403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244239 0039d316-1c4b-4281-b951-d872f2087c98

r1263: Run svn propdel svn:executable on source code files.
r1264: Fix warnings from the Windows build.
r1265: Switch scoped_ptr.h to a compatible google3 implementation.
r1266: Use a proper ignore_result() to fix a warn_unused_result warning.
r1267: Windows: Fix remaining level 4 warnings.
r1268: Fix build with Mac OS X 10.9 SDK.
r1269: Fix #include order from r1268.
r1270: Don't do work inside assert(). Ever.

BUG=331268
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/131833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244238 0039d316-1c4b-4281-b951-d872f2087c98

> Add support for using expressions as enum values.
> 
> BUG=320090
> R=darin@chromium.org
> 
> Review URL: https://codereview.chromium.org/130443003

Broke the android build: http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Builder%20%28dbg%29&number=50248

TBR=mpcomplete@google.com

Review URL: https://codereview.chromium.org/133843004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244237 0039d316-1c4b-4281-b951-d872f2087c98

The default preference values are fine for app_shell's pages (as they are
for content_shell, which doesn't use PrefsTabHelper).  Delegate out the
creation of PrefsTabHelper so we only create them in Chrome.

With this patch app_shell can launch a renderer before crashing.

BUG=332435
TEST=browser_tests, manual testing that extensions still work

Review URL: https://codereview.chromium.org/132993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244236 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244235 0039d316-1c4b-4281-b951-d872f2087c98

(platform_channel_posix.cc gets moved to platform_channel_pair_posix.cc
entirely.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/133533007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244234 0039d316-1c4b-4281-b951-d872f2087c98

BUG=320090
R=darin@chromium.org

Review URL: https://codereview.chromium.org/130443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244233 0039d316-1c4b-4281-b951-d872f2087c98

Reported in "[chromium-dev] the problem i met when buliding chromium on the windows 7 without cygwin"

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/134763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244232 0039d316-1c4b-4281-b951-d872f2087c98

https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux-64&tests=sizes%2Fchrome&checked=core&start_rev=243989&end_rev=24421

BUG=333373
R=dtu@chromium.org, mek@chromium.org

Review URL: https://codereview.chromium.org/134693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244231 0039d316-1c4b-4281-b951-d872f2087c98

Memory pressure listeners need to be created on a thread with a message
loop current. Discardable memory is often used on worker threads that
don't have a message loop and with the current system where listeners
are registered on first use, the result is that we're most likely never
notified of memory pressure.

This adds a function to the discardable memory interface that allows us
to register memory pressure listeners on a thread, and at a time, when
we know a message loop is current.

BUG=332570
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/129963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244229 0039d316-1c4b-4281-b951-d872f2087c98

Prevent error bubbles from being recreated every single time a
validation operation on the current field succeeds. Only destroy
bubble if the anchor field changes.

BUG=331147
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/123703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244228 0039d316-1c4b-4281-b951-d872f2087c98

R=enne@chromium.org,vmpstr@chromium.org
BUG=332593

Review URL: https://codereview.chromium.org/132083007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244227 0039d316-1c4b-4281-b951-d872f2087c98

Note: This reverts the changes to .h and .c files done in http://crrev.com/95873002. However, this should still work for non-NEON builds as NEON specific functions are built as empty functions in that case.

BUG=331619

Review URL: https://codereview.chromium.org/116213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244226 0039d316-1c4b-4281-b951-d872f2087c98

BUG=326170

Review URL: https://codereview.chromium.org/98073012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244225 0039d316-1c4b-4281-b951-d872f2087c98

Avoid unneccessary copy of structures gfx::Rect & gfx::RectF 
by passing them by const ref rather than value. 

Any struct of size > 4 bytes should be passed by const ref. 
Passing by ref for these structs is faster than passing 
by value, especially when invoking function has multiple parameters. 

Pass by value creates unneccessary overhead which should be avoided.

BUG=159273

Review URL: https://codereview.chromium.org/93663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244224 0039d316-1c4b-4281-b951-d872f2087c98

- Remove PlatformServerChannel/PlatformClientChannel.
- Add PlatformChannelPair (move stuff formerly in PlatformServerChannel
  into this).

It became apparent that my previous plan to make this work on Windows
wasn't work nicely. On the one hand, on Vista+, we can basically make
things work like POSIX (created the channels in the parent and connect
them, and send a channel to a child). On the other, on XP, to be secure
you need to do more work (the channels aren't connected or authenticated
initially), so you'd need much more machinery (to wait for connection,
to authenticate, etc.).

So I'll go for a different mechanism to make things work on XP. The
assumption from the Mojo embedder API will be that it's given a channel
handle that's already been connected, authenticated, etc. (which will be
taken care of by other means). This will add flexibility in other ways
as well (e.g., make Mojo IPC more happily coexist with Chrome IPC -- you
should be able to pass a handle over Chrome IPC to set up Mojo IPC).

Still to do: Move PlatformChannelPair into its own files.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/134373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244223 0039d316-1c4b-4281-b951-d872f2087c98

Hardware video decode depends on GLX but we may be using OSMesa. In
this case fallback to non-hardware video decode gracefully instead
of static casting to an incorrect type.

This allows us to remove flags forcing non-OSMesa for some tests,
and they will test hardware decode on the ChromeOS VMs still.

These flags must go in order to support browser tests running
with a compositor instead of using legacy software mode, since
GLX inside the bot Xvfb environment can not run the compositor.
(This is a small piece of enabling us to test real code paths
in browser tests https://codereview.chromium.org/120313002/ .)

R=fischman@chromium.org, piman@chromium.org, piman
BUG=270918

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244111

Review URL: https://codereview.chromium.org/132503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244222 0039d316-1c4b-4281-b951-d872f2087c98

I did it/fixed it.

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/134663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244221 0039d316-1c4b-4281-b951-d872f2087c98

ui::TouchEvents now know the id of their source device.
The target of a touch can't be effected by a touch on another display.

Relanding https://codereview.chromium.org/103173004/, after it was
reverted https://codereview.chromium.org/103173004. When ensuring that
the GR wasn't reused between tests, I had neglected to delete the old
GR.

BUG=315651
TEST=GestureRecognizerTest.GestureEventTouchLockIgnoresOtherScreens

Review URL: https://codereview.chromium.org/132123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244220 0039d316-1c4b-4281-b951-d872f2087c98