GitLab

BUG=
TBR=thakis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/1492053005

Cr-Commit-Position: refs/heads/master@{#362955}

For example if a JS redirect would fail while the original navigation is
still in progress we would call didStopLoading before the original
navigation calls didFinishLoading (breaking the assumption that
didFinishLoading is always called before didStopLoading).

BUG=557100, 298193

Review URL: https://codereview.chromium.org/1440933004

Cr-Commit-Position: refs/heads/master@{#362954}

BUG=562431

Review URL: https://codereview.chromium.org/1494883003

Cr-Commit-Position: refs/heads/master@{#362953}

Adding common_constants.gyp:version_header dependency to setup_lib because
installer_crash_reporter_client.cc includes chrome/common/chrome_version.h.
This fails to compile flakily on Windows.

BUG=558552
TBR=joenotcharles@chromium.org,grt@chromium.org

Review URL: https://codereview.chromium.org/1494933002

Cr-Commit-Position: refs/heads/master@{#362952}

Revert of CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines (patchset #2 id:20001 of https://codereview.chromium.org/1481343002/ )

Reason for revert:
Revert because WebViewTest.CanGoBackAndForward and WebViewTest.NavigationClearsForward started failing.

Original issue's description:
> CC Animations: Make sure that HtmlViewer uses compositor-animation-timelines
>
> In general, we want to enable external animation system for blink here: https://codereview.chromium.org/1308053006/
>
> Make sure that HtmlViewer always uses the new animation system for CC and Blink (cc::AnimationHost).
>
> Eventually, we will delete LayerSettings everywhere.
>
> BUG=394777
>
> Committed: https://crrev.com/7f32365dc607c8db0d211e67ef71d2f0fa3dbd3b
> Cr-Commit-Position: refs/heads/master@{#362911}

TBR=sky@chromium.org,loyso@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=394777

Review URL: https://codereview.chromium.org/1500513003

Cr-Commit-Position: refs/heads/master@{#362951}

BUG=562431

Review URL: https://codereview.chromium.org/1497683002

Cr-Commit-Position: refs/heads/master@{#362950}

BUG=562431

Review URL: https://codereview.chromium.org/1493633004

Cr-Commit-Position: refs/heads/master@{#362949}

When computing the logical height of grid items for the default
min-height:auto case we were constraning the min-content size using
constrainLogicalHeightByMinMax() instead of
constrainContentLogicalHeightByMinMax(). The problem of using the former is
that we were adding the borders twice.

BUG=560771

Review URL: https://codereview.chromium.org/1496513002

Cr-Commit-Position: refs/heads/master@{#362948}

This CL modifies a name to mention only "bookmarks".

BUG=378104
R=noyau@chromium.org

Review URL: https://codereview.chromium.org/1497433003

Cr-Commit-Position: refs/heads/master@{#362947}

This test was already partially disabled on iOS (using the
|supports_non_dotted_domains| parameter).
This CL disables a larger part of the test, to unblock the commit queue.

TBR=ellyjones
BUG=564543

Review URL: https://codereview.chromium.org/1498793002

Cr-Commit-Position: refs/heads/master@{#362946}

This patch removes some Failure expectations for imported tests in
web-platform-tests/html that were fixed in crbug.com/391260.

TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org
BUG=490511, 542660, 391260

Review URL: https://codereview.chromium.org/1499433003

Cr-Commit-Position: refs/heads/master@{#362945}

Cancelled animations are removed before the update is applied. Regressed
in https://codereview.chromium.org/1402143004

BUG=564354

Review URL: https://codereview.chromium.org/1500443002

Cr-Commit-Position: refs/heads/master@{#362944}

The "deps" and "public_deps" are sorted using the following order:
  1. litteral strings
    a. local targets, e.g. ":a",
    b. relative targets, e.g. "a" or "../a",
    c. absolute targets, e.g. "//a",
  2. other values, e.g. variable reference.

In each group, values are sorted alphabetically.

BUG=554928

Review URL: https://codereview.chromium.org/1496653002

Cr-Commit-Position: refs/heads/master@{#362943}

Review URL: https://codereview.chromium.org/1486603002

Cr-Commit-Position: refs/heads/master@{#362942}

The SVGAnimatedLength constructor takes an additional argument (compared to the
arguments passed to other SVGAnimatedProperty classes) which represents whether
the length may be negative. Although this is stored as a property of
SVGAnimatedLength, the value is determined by the particular SVG attribute that
the SVGAnimatedLength is representing, and does not change.

In order to facilitate the implementation of additive animations for
AnimatedLength, this patch removes this additional argument, and instead
implements a helper function in SVGLength.h to look up the value for a given SVG
attribute.

BUG=530436

Review URL: https://codereview.chromium.org/1491023003

Cr-Commit-Position: refs/heads/master@{#362941}

This allows a number of the authentication policies to be updated
dynamically after the IO thread has been created.

BUG=545534

Review URL: https://codereview.chromium.org/1414313002

Cr-Commit-Position: refs/heads/master@{#362940}

Reland of Fix downloading LLVM Gold plugin in the case, when Clang is up to date. (patchset #1 id:1 of https://codereview.chromium.org/1494883004/ )

Reason for revert:
Reverting didn't help.

Original issue's description:
> Revert of Fix downloading LLVM Gold plugin in the case, when Clang is up to date. (patchset #1 id:1 of https://codereview.chromium.org/1491203003/ )
>
> Reason for revert:
> This breaks Codesearch bots.
>
> Original issue's description:
> > Fix downloading LLVM Gold plugin in the case, when Clang is up to date.
> >
> > The script should download LLVM Gold plugin, if it's missing, even if the
> > main Clang toolchain is up to date. This change is to match update.py
> > functionality with the gone update.sh.
> >
> > BUG=464797,494442
> >
> > Committed: https://crrev.com/7ff79f9569429444dabdb6d5024918bc548916b3
> > Cr-Commit-Position: refs/heads/master@{#362803}
>
> TBR=thakis@chromium.org,krasin@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=464797,494442
>
> Committed: https://crrev.com/9e37ffbe43c0b100bcc02f9faf648f11d86316c1
> Cr-Commit-Position: refs/heads/master@{#362938}

TBR=thakis@chromium.org,krasin@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464797,494442

Review URL: https://codereview.chromium.org/1493283002

Cr-Commit-Position: refs/heads/master@{#362939}

Revert of Fix downloading LLVM Gold plugin in the case, when Clang is up to date. (patchset #1 id:1 of https://codereview.chromium.org/1491203003/ )

Reason for revert:
This breaks Codesearch bots.

Original issue's description:
> Fix downloading LLVM Gold plugin in the case, when Clang is up to date.
>
> The script should download LLVM Gold plugin, if it's missing, even if the
> main Clang toolchain is up to date. This change is to match update.py
> functionality with the gone update.sh.
>
> BUG=464797,494442
>
> Committed: https://crrev.com/7ff79f9569429444dabdb6d5024918bc548916b3
> Cr-Commit-Position: refs/heads/master@{#362803}

TBR=thakis@chromium.org,krasin@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=464797,494442

Review URL: https://codereview.chromium.org/1494883004

Cr-Commit-Position: refs/heads/master@{#362938}

Introduces a hack to recover the speed performance of
EventTarget.dispatchEvent.  The code looks like close to the one before
http://crrev.com/1417023006 .

BUG=564407, 509936

Review URL: https://codereview.chromium.org/1494803003

Cr-Commit-Position: refs/heads/master@{#362937}

BUG=560769

Review URL: https://codereview.chromium.org/1477133002

Cr-Commit-Position: refs/heads/master@{#362936}

The xdg_shell allows clients to turn a wl_surface into a "real window"
which can be dragged, resized, stacked, and moved around by the
user. This interface is suited towards traditional desktop
environments and is what most wayland clients use today.

This patch adds minimal support for this interface. Requests such
as move and resize will be added by follow up patches.

BUG=549781

Review URL: https://codereview.chromium.org/1411403007

Cr-Commit-Position: refs/heads/master@{#362935}

It's unclear what the purpose of this test is, but it's creating busy
work for folks working on blink features, so I'll disable this while
someone figures this out.

BUG=564765
TBR=timvolodine@chromium.org

Review URL: https://codereview.chromium.org/1495793003

Cr-Commit-Position: refs/heads/master@{#362934}

BUG=555325

Review URL: https://codereview.chromium.org/1444493002

Cr-Commit-Position: refs/heads/master@{#362933}

Reland of Ship promise rejection events (patchset #1 id:1 of https://codereview.chromium.org/1498703002/ )

Reason for revert:
i'll disable the test instead

Original issue's description:
> Revert of Ship promise rejection events (patchset #2 id:20001 of https://codereview.chromium.org/1496453002/ )
>
> Reason for revert:
> This is breaking SystemWebViewShellLayoutTests on Android Webview L. See crbug/564765.
>
> Original issue's description:
> > Ship promise rejection events
> >
> > I2S: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/AmChp_uVpXU
> >
> > BUG=495801
> > R=philipj@opera.com
> >
> > Committed: https://crrev.com/98bd85306f3a170fa465c3f5a754ac2519a36be1
> > Cr-Commit-Position: refs/heads/master@{#362695}
>
> TBR=philipj@opera.com,jochen@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=495801
>
> Committed: https://crrev.com/f3e241833fad43bec928922e949fa8cd2f4d84ff
> Cr-Commit-Position: refs/heads/master@{#362891}

TBR=philipj@opera.com,ianwen@chromium.org,khushalsagar@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=495801

Review URL: https://codereview.chromium.org/1495723003

Cr-Commit-Position: refs/heads/master@{#362932}

Any unregistration is (already) taken care of by Oilpan.

R=haraken
BUG=

Review URL: https://codereview.chromium.org/1485353006

Cr-Commit-Position: refs/heads/master@{#362931}

The application ID identifies the general class of applications to which
the surface belongs. Chromium can use this to group multiple surfaces
together, or to determine how to launch a new application.

BUG=549781
TEST=exo_unittest --gtest_filter=ShellSurfaceTest.SetApplicationId

Review URL: https://codereview.chromium.org/1491843002

Cr-Commit-Position: refs/heads/master@{#362930}

Use FetchFormDataConsumerHandle in Response::create to simplify the code.

This CL also includes some minor refactoring.
 - Rename "responseInit" with "init" for the simplicity
 - Replace 0 with nullptr
 - Wrap comments in 80 cols

BUG=564479

Review URL: https://codereview.chromium.org/1490243002

Cr-Commit-Position: refs/heads/master@{#362929}

This restriction was lifted in
https://codereview.chromium.org/1257823006. But ES3 still has this
restriction. Move this check after format validation before data
validation due to format is used for data validation.

BUG=295792
TEST=deqp/functional/gles3/negativetextureapi.html

Review URL: https://codereview.chromium.org/1489253003

Cr-Commit-Position: refs/heads/master@{#362928}

Use the chain tool to compute how a given color profile transforms white
input to XYZ PCS (profile connection space).

No change in behavior, no new tests. Tested with an iMac P3 profile: the
returned XYZ result is exactly D50 white: [0.9642, 1.0000, 0.8249].

BUG=564355

Review URL: https://codereview.chromium.org/1494473003

Cr-Commit-Position: refs/heads/master@{#362927}

These methods are not actually used. Methods of identical names/types
exist in ExclusiveAccessContext. BrowserView inherits both BrowserWindow
and ExclusiveAccessContext and double-overrides this method. It is only
virtual-dispatched through ExclusiveAccessContext, so the BrowserWindow
virtual methods do not need to exist.

Updated tests that were depending on this old interface.

BUG=352425

Review URL: https://codereview.chromium.org/1480183002

Cr-Commit-Position: refs/heads/master@{#362926}

This is necessary to pass 'gn check' on Windows because
components/nacl/loader/nacl_main_platform_delegate_win.cc uses
the sandbox/win/src/sandbox.h header.  The direct dependency is
not strictly necessary on Mac because its implementation of
NaClMainPlatformDelegate::EnableSandbox uses the wrapper
interface content::InitializeSandbox, nor on Linux because the
zygote handles it.  But it doesn't hurt.

BUG= 512869
R=bradnelson@chromium.org, mseaborn@chromium.org

Review URL: https://codereview.chromium.org/1498673002

Cr-Commit-Position: refs/heads/master@{#362925}

Much of the functionality in CompositorWorkerManager
was related to shared compositor thread state. This
patch moves that to CompositorWorkerSharedState, an
implementation detail of CompositorWorkerThread.

The shared state also now uses the real compositor
thread.

The existing compositor worker layout tests needed
to be moved to a virtual test suite since they now
depend on having a compositor thread.

BUG=430155

Committed: https://crrev.com/d710cbc079b51b819349203ee408f36dc056055e
Cr-Commit-Position: refs/heads/master@{#362590}

Review URL: https://codereview.chromium.org/1449953002

Cr-Commit-Position: refs/heads/master@{#362924}

Makes shell_util more modular and breaks it up a bit. RegistryEntry is a
generally useful API.

BUG=419972

Review URL: https://codereview.chromium.org/623903002

Cr-Commit-Position: refs/heads/master@{#362923}

I'm hopeful this will work because then it can simplify the scoring code.

The experiment for the HUP-like-mode in HQP seemed promising
https://code.google.com/p/chromium/issues/detail?id=490812
(i.e., neutral).  Let's see if we can disable HUP if that mode is enabled.

We do lose some features.  For instance, HUP culls
redirects.  HQP does not.  This means that if HUP
manages to find three good sites post-redirect-culling,
HQP may not be able to because it may have some
equivalent (redirect) URLs laying around.

Note that HUP still uses its database implicitly.
This experiment will not test whether we can remove
the database entirely.  The HUP still uses its database
for identify typed hosts or shorter matches for instance.

BUG=

Review URL: https://codereview.chromium.org/1498473003

Cr-Commit-Position: refs/heads/master@{#362922}

aura::Windows are needed for proper event-handling.

BUG=549781
TEST=exo_unittest --gtest_filter=*SurfaceTest.*

Review URL: https://codereview.chromium.org/1490223002

Cr-Commit-Position: refs/heads/master@{#362921}

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1496843002

Cr-Commit-Position: refs/heads/master@{#362920}

This layout test tests createPattern operates synchronously with an
animated image. The test was removed because it was using SVG animation
which was flacky. This CL changes the SVG animation to CSS animation.

BUG=316730

Review URL: https://codereview.chromium.org/1493883002

Cr-Commit-Position: refs/heads/master@{#362919}

BUG=NONE
NOTRY=true

Review URL: https://codereview.chromium.org/1495613003

Cr-Commit-Position: refs/heads/master@{#362918}

Cleanup <image> type handling in two ways:
- to handle list-style-image, border-image-source and
webkit-mask-box-image-source simply reuse parseFillImage.
- to make isGeneratedImageValue more reusable use a CSSValueID parameter.

BUG=499780

Review URL: https://codereview.chromium.org/1498553002

Cr-Commit-Position: refs/heads/master@{#362917}

This is a modified version of bzanotti@'s CL:
https://codereview.chromium.org/1496573002/

We now clear the access token anytime the sync engine shuts down.

BUG=563416

Review URL: https://codereview.chromium.org/1498663002

Cr-Commit-Position: refs/heads/master@{#362916}