- 21 Aug, 2020 40 commits
-
-
Clemens Arbesser authored
With this CL, the controller will remember the last successful user data options, such that subsequent actions can refer to it. This allows the ShowDetails action to only surface the information that was requested in the preceeding CollectUserData action. Screenshots of the resulting UI are in the linked bug. Bug: b/160214328 Change-Id: I31cd5fa13257ff6f1f10cfaef75ebb7de5099df2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367036Reviewed-by:
Luca Hunkeler <hluca@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#800520}
-
Jeremie Boulic authored
When trying to open an encrypted archive with a wrong password, display an 'Invalid password' message, and prefill the password input field with this previous password. BUG=chromium:912236 TEST=browser_tests --gtest_filter="FileManagerJsTest.FilesPasswordDialog" Change-Id: I11ceb75bc824c550fbb0c96ec516f2b6d391d615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366515 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#800519}
-
Alexey Baskakov authored
The WebAppProvider system couldn't download it given the url from the manifest: chrome://media-app/system_assets/app_icon_48.png It would be nice to have some offline integrity checks for SWAs metadata. Fixed: 1110768 Change-Id: Ie8fb1b2bc06bb9f64fdc2d0c22bafc3cb43da4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367589Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Auto-Submit: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#800518}
-
Reda Tawfik authored
This Cl adds |AllPasswordsBottomSheetView| which implements |BottomSheetContent| and chnge its visibility state from the controller. Adds a junit test. This Cl skips adding screenshots for string resources. The UI is in early stages and taking a screenshot for it does not help for translation. Will be added when the UI gives helpful context. Bug: 1104132 Skip-Translation-Screenshots-Check: True Change-Id: If6be6f9dbea93489b69b367d4d997cec595fb7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320171Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@noogler.google.com> Cr-Commit-Position: refs/heads/master@{#800517}
-
Aya ElAttar authored
- Changed Web-originated clipboard access to set the destination trying to access the clipboard data if possible. - Renamed EndpointType::kVm to kGuestOs Bug: 1103614 Change-Id: I895ea000e985611896f842274ea6849a822753d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346288Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Cr-Commit-Position: refs/heads/master@{#800516}
-
Karel Král authored
Create a tool to enable developers to annotate large amount of code with tracing. This is an MVP which just adds tracing of the method name. Bug: 1111787 Change-Id: I7a6fd7f51b9a3887074b1f53f005f1c0c8671a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332401 Commit-Queue: Karel Král <karelkral@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#800515}
-
Jana Grill authored
Replace the word "device" with the actual device name in ADB sideloading notifications texts by adding a placeholder to the affected strings and replacing it with the corresponding device type when displaying the notifications. Bug: 1115444 Change-Id: I6aadf09594bbf19a31dc62a2aab81d855f81fcab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367041Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#800514}
-
Maggie Cai authored
This CL extends the app-service-intent-handling flag to 87 because it was just turned on by default for one milestone. BUG=853604 Change-Id: I6838130f223d1487610d193f9257635bcdaf009e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367426Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#800513}
-
dizg authored
This is the client side implementation of go/gaiafe-dice-fallback. The Gaia server will send parameter no_authorization_code in the Dice header, when there is a OAuth outage. When this happens and the feature kSupportOAuthOutageInDice is enabled, Chrome disable the reconcilor temporarily, so that the user can stay signed in on the web. After some time, the reconcilor is restarted, and at this point the user is signed out, and will need to sign in again. Also added unit tests. Bug: 1115247 Change-Id: Ib71f55f26f50c185175a1abeec58edd4d7d72605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362757Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Diana Zagidullina <dizg@google.com> Cr-Commit-Position: refs/heads/master@{#800512}
-
Maggie Cai authored
This reverts commit 2576e02f. Reason for revert: This CL is likely the cause of the build failure for test external/wpt/webdriver/tests/release_actions/sequence.py>>test_no_release_mouse_sequence_keeps_dblclick_state, in buildes first occurs in: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/91045 and https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/14964 Original change's description: > [ChromeDriver] Support triple click in Chromedriver PerformActions > > When we are using PerformActions from ChromeDriver to simulate three > mouse click, it only set the click count to 2, not 3, so this test fails > third_party/blink/web_tests/external/wpt/webdriver/tests/perform_actions > /pointer_tripleclick.py. > > PerformActions should keep the mouse click count and decide if we should > increase the count or set to 1 when we have a mouse press based on the > interval of two mouse presses and difference between the current mouse > positions and the last one. > > Bug: 1119679 > Change-Id: I2b941c5d295cdd457109c8866c55e02bb2360555 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366655 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800201} TBR=lanwei@chromium.org,johnchen@chromium.org Change-Id: Ie57866e4aef6ac88eca708a05459032c1fee2128 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1119679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368620Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#800511}
-
Frédéric Wang authored
Bug: None Change-Id: I4162ef32a633124905a9ee8e1713d42c044c3654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366798Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#800510}
-
Olga Sharonova authored
Change-Id: I00bb410f08027040b1adc7a7d7f5ebe33314fe97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228536Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#800509}
-
Tsuyoshi Horo authored
Bug: 1120246 Change-Id: Ib7b2f8d6196e64d7f7a740c8382686d9e7dc59ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367260 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#800508}
-
Maggie Cai authored
This reverts commit 81e8107c. Reason for revert: This CL is likely the cause for the build failure with test PrintBackendCupsHelperTest.TestPpdParsingResolutionNoResolution since https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/25158 Original change's description: > Add Linux support for printer resolutions > > Add Linux support for PPD resolution options. > > Test: ./printing_unittests > Change-Id: I15d2245567e37938633c72daa2edc66cfa6f4b22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360472 > Commit-Queue: Pranav Batra <batrapranav@chromium.org> > Reviewed-by: Daniel Hosseinian <dhoss@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800424} TBR=thestig@chromium.org,dhoss@chromium.org,batrapranav@chromium.org Change-Id: I77598a213e4af7ff5a47ba815350ba907ea4631a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368656Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/87a7605160fd..bfb423d26610 2020-08-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I1de169ff791d933e41d3be82b031c825cc569e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368110Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#800506}
-
Aleks Totic authored
Legacy tables code does two style adjustments that need to be modified for TablesNG. 1) Legacy cannot handle position:relative/fixed on Section/Rows, but TablesNG can. In Legacy, style used to be modified in style_adjuster.cc:AdjustStyleForDisplay AdjustStyleForDisplay does not know if style is layout object is legacy, or ng. Therefore, style adjustment cannot be done here. The adjustment code was moved to LayoutObjectFactory, which knows type of object being created. 2) Legacy cells cannot handle orthogonal writing modes. Cell writing mode is reset to parent's writing mode. This one was tricky, because neither AdjustStyleForDisplay, nor LayoutObject factory have data needed to modify the style. AdjustStyleForDisplay does not know if layout object is legacy or ng. LayoutObjectFactory does not have parent's writing mode. One option is to plumb parent's style to LayoutObjectFactory. There is a lot of layers here, and feels like an unnecessary complexity just to support temporary table weirdness. My solution was to modify cell's style in LayoutTableRow::AddChild. It is hacky, but I believe it is safe. Bug: 958381 Change-Id: I77dd9c7a253282d0f8647c9add0b5c1fc908d8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356849 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#800505}
-
Martin Robinson authored
I no longer need this particular watchlist and I am the only participant. Change-Id: Ic34c9d7dc234cbdfd488dc72b86a770094ce1df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2328969Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#800504}
-
Will Cassella authored
This is a reland of cb9cdc66 Original change's description: > Give blink::CueTimeline a timer for precisely handling cue events > > Cue-related events (enter, exit, cuechange) are fired up to 250ms late, > and there is a similar latency in their display which is quite > noticeable. > > The underlying problem is that we only update cues alongside the > `timeupdate` event, which is fixed at 4 Hz. > > My solution is to add a separate timer to CueTimeline > (`CueTimeline::cue_event_timer_`) which is given a timeout for the > next cue event based on the current playback position and rate. This > allows for significantly more precise cue timing accuracy without a > significant performance penalty. > > Additionally, several web tests were written with the expectation that > the 'time marches on' algorithm is run before video playback begins > (ie, upon loading text track cues). This behavior is not in accordance > with the spec (as outlined in crbug/1050767), so this CL fixes those > expectations and adds a new test to prevent regressing. > > Bug: 576310, 1050767 > Change-Id: I675f5f030a68ba9cee10e12b3e79a9b174048193 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2008079 > Commit-Queue: Will Cassella <cassew@google.com> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#800148} Bug: 576310 Bug: 1050767 Change-Id: I735f5344005798b8d1543e020ba3920c9d2134dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368079 Auto-Submit: Will Cassella <cassew@google.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#800503}
-
Jacobo Aragunde Pérez authored
AT-SPI sets up a number of ATK event listeners. If Chromium emits events too early, they won't be detected by AT-SPI. The initialization of AT-SPI listeners happens at spi_atk_register_event_listeners in the at-spi2-atk library. It also sets up a key event listener, which is registered by Chromium at AtkUtilAuraLinuxAddKeyEventListener. We use the registration of the key event listener as an indication of AT-SPI being ready, due to our internal knowledge of the internals of the AT-SPI/ATK bridge. If there are no key event listeners, we consider AT-SPI is not ready, so window activated events are queued. As soon as a key event listener is registered, events will be run and never queued again. A window deactivated event would cancel the queued activated event. Bug: 1062755 Change-Id: I2d1a1516bed2b8437df664d69399b72af02eb4a8 AX-Relnotes: Linux: send Chromium's first window activation event. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312818Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#800502}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/27bbbaa9714f..97ff660720cd 2020-08-21 paulirish@chromium.org update .npmignore for "third_party" 2020-08-21 alexrudenko@chromium.org Fix suggest color for certain color combinations If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Idf1a2591fc535ada8d43c6d9e07d4c54592b3367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368108Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
- Fix spelling typo - Add missing final - Complete type in generic classes - Remove redundant type info There should be no functional changes. Bug: None Change-Id: Ia07950f3858e1f4b0f4e1c7d17c35187edc1940b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363877 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#800500}
-
Yoshifumi Inoue authored
This patch changes |NGLineBreaker| not to clear |LayoutObject:: NeedsLayout()| when it is called from |ComputeMinMaxSizes()|. Background: The issue was caused by finding |NGInlineItem| from previous |NGFragmentItem| because of |NGFragmenItems:: TryReuseFragmentsFromCache()| failed to make dirty for |LayoutText| because of |ComputeMinMaxSizes()| clears |NeedsLayout()| flag before actual layout. Bug: 1116713 Change-Id: Ia3b08ae7295ccf62bbe38a1ed8d3cd6f6209faa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367259 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#800499}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5e8b16af30f4ca8d13f9a17a7522c0c7be53c14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368814Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7f343135480a..7a2e3f83964f 2020-08-21 jleconte@google.com WebRtcTest quest needs a longer execution timeout. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1024246 Tbr: eseckler@google.com Change-Id: I890eabaf50920f623819d8536b0ce31923dc2e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368812Reviewed-by:
-
Maggie Cai authored
This reverts commit 7d2d8cc1. Reason for revert: This is likely the cause of build breakage for Linux ChromiumOS MSan Tests since https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20301 The failed test is MediaNotificationViewImplTest.UnfreezingWaitsForArtwork_Timeout Original change's description: > GMC: Redesign audio picker UI > > Implement the new UI for the audio device picker in global media > controls. As part of this change, the MediaNotificationBackground will > draw a gradient between the device picker and notification artwork if > the picker is availabile. > > Screenshots of this updated UI will be posted on the crbug. > > Change-Id: Ic7186c770102663b08e85b56eeddfbfa13833c3c > Bug: 1117160 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358512 > Commit-Queue: Noah Rose Ledesma <noahrose@google.com> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800243} TBR=steimel@chromium.org,noahrose@google.com Change-Id: I2b9d9d6df1afc9ca8fdb967fad0a35c3273db879 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1117160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367427Reviewed-by:
-
Jose Dapena Paz authored
GCC: default move constructor of ServiceWorkerRunningInfo noexcept requires StrongAlias noexcept too. Fix for this GCC compilation error: ../../content/public/browser/service_worker_running_info.cc:26:1: error: function ‘content::ServiceWorkerRunningInfo::ServiceWorkerRunningInfo(content::ServiceWorkerRunningInfo&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’ 26 | ServiceWorkerRunningInfo::ServiceWorkerRunningInfo( | ^~~~~~~~~~~~~~~~~~~~~~~~ Problem comes from blink::ServiceWorkerToken move constructor being declared noexcept, but its parent StrongAlias not having noexcept. Fix making StrongAlias move constructor noexcept too. Bug: 819294 Change-Id: I127a435b3d1f52f01a40700457ce6e67d5d67af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359077Reviewed-by: -
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.59-1597657121-benchmark-86.0.4237.0-r1 to 86-4183.59-1597657121-benchmark-86.0.4239.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I7277c5f06a7d3b68a99ec3aad0c7dd07d5f79aef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368915Reviewed-by:
-
Maksim Sisov authored
Even though, this config is not in the upstream yet, there are many patches that allow to build with use_x11 && use_ozone. The https://crrev.com/c/2361502 broke the build and my cq dry run. Thus, fixing the problem with this patch. Bug: 1085700 Change-Id: Id64052453811c6928b55a1ed62340ace667fe0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366797 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Maggie Cai authored
This reverts commit d35f5dac. Reason for revert: This CL is the possible cause of the breakage of build Linux ChromiumOS MSan Tests since https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20302 Original change's description: > Modify Privacy Budget UKM Entry Filter to measure identifiable surfaces. > > Add a "SurfaceTracker" to IdentifiabilityStudyState to keep track of > surfaces that have been previously reported for each source. This is > used for deduplication and to limit the number of metrics sent in each > UKM report. > > Bug: 1112787 > Change-Id: I00eb2360849ea6772fbfdcc9b1cf91680f8c6173 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363398 > Reviewed-by: Asanka Herath <asanka@chromium.org> > Commit-Queue: Russ Hamilton <behamilton@google.com> > Cr-Commit-Position: refs/heads/master@{#800332} TBR=asanka@chromium.org,behamilton@google.com Change-Id: I0a349740361db768696be0703020b229d8e274be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1112787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367590Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.59-1597659923-benchmark-86.0.4237.0-r1 to 86-4183.59-1597659923-benchmark-86.0.4239.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic23f990e8cb243e7b91bd1de185b2d319088aa7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368914Reviewed-by:
-
Ramin Halavati authored
Incognito Dynamic Quota experiment is changed to enabled by default and its arguments are modified to the value that was set by latest active finch trials. The following three ranges where experimented: 0.1 - 0.2, 0.1 - 0.15, and 0.15 - 0.2. Since there was no significant stability difference between the three, kept the highest one which gives more quota and adds maximum uncertainty to detection. Bug: 1017120 Change-Id: I4039f37c3badad5b00552dd3c92bd734e5b245fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363751 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#800490}
-
Zhuoyu Qian authored
This CL renames Web IDL |TreatNonObjectAsNull| to |LegacyTreatNonObjectAsNull| to make its usage more clear. Bug: 1072773 Change-Id: I2081296552ea0862a84f763243254af020f43fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364312Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#800489}
-
Maksim Sisov authored
Remove dependency on ui/views and ui/aura. This is required to be able to move them down to ui/platform_window/x11/tests Bug: 789065 Change-Id: Ie4c0bd3056f9627b13b4bdfc9511010aaf249515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367072 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#800488}
-
Viviane Yang authored
This CL will check for and remove expired subscriptions after the profile is initialized. By enabling the feature flag for push subscriptions with expiration time, a expiration time of kPushSubscriptionExpirationPeriodTimeDelta specified in chrome/browser/push_messaging/push_messaging_constants.h is added to push subscriptions. These subscriptions become invalid after they expired and need to be removed from the browser. Bug: 1119690 Test: unit_tests --gtest_filter=Push*Remove* Change-Id: I1d899daa0e79ff7fd4b08b0bc70ef273f9a54872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365953Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#800487}
-
Alan Cutter authored
This is a reland of c4de5e43 Fixed test flake due to not waiting for the first OnBackgroundColorChanged() event during page load. https://chromium-review.googlesource.com/c/chromium/src/+/2367584/2..3/chrome/browser/ui/views/web_apps/web_app_tab_strip_browsertest.cc Original change's description: > Use document background color as active tab color for tabbed web apps > > This CL hooks up the document's background color as the active tab > background color for experimental tabbed web app. > Tabbed web apps are hidden behind the DesktopPWAsTabStrip feature flag. > > This CL plumbs background color through from the renderer process along > the same route as document theme color. > > Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=460591&signed_aid=NcgKQaq5Y47QkcbQbbgNiw==&inline=1 > After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=460590&signed_aid=RlnBzb7mQq1SIW1fGBY-oA==&inline=1 > > Bug: 1104083 > Change-Id: If1c3e2172f80375a1a4619c17ee52594ef813005 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342426 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800051} Bug: 1104083 Change-Id: If4a1b525af77ccd4697f6931b59a759a8bf3e3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367584 Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#800486}
-
chromium-autoroll authored
Roll ChromeOS Broadwell AFDO profile from 86-4183.59-1597658380-benchmark-86.0.4237.0-r1 to 86-4183.59-1597658380-benchmark-86.0.4239.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Idf4e780d0c2895043dd76fe65b8a11eaf06edf30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368111Reviewed-by:
-
Alice Wang authored
This CL adds an espresso test to check that the clicking on |Try again| button shown on sign-in general error screen leads to the sign-in in progress screen. Bug: 1117471 Change-Id: I2ad1aef270e36b1a09628b077e59a4c71ba77b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366932 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#800484}
-
Alan Ding authored
Provide chrome switch to ignore arcvm_dev.conf file directives during ARCVM start while in dev mode. Setting this switch provides default arcvm configuration parameters. BUG=b:159953121 BUG=b:164956421 TEST=tast run DUT arc.PerfBoot.vm and compared logs with flag. Change-Id: I9f8dd5b21dd62f8312ce0a88c1e4a38cbc76ecd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360946 Commit-Queue: Alan Ding <alanding@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#800483}
-
Findit authored
This reverts commit feab4f74. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 800423 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZlYWI0Zjc0YzQ5ZmQ2MDBlMTJkNWE1M2IyYjA5M2IyNjdjMWE3MzYM Sample Failed Build: https://ci.chromium.org/b/8871393632014939696 Sample Failed Step: compile Original change's description: > cros: Add alternate keys for interacting with window cycler (alt+tab). > > Currently a user can only cycle the window cycle list using alt+tab or > alt+shift+tab. Also, the user can only confirm their selection by > releasing the alt key. > > This CL improves the interactivity of window cycler by introducing the > following changes. Pressing the left and right arrows now move the > selection while the window cycler is open. Pressing enter or space > now confirms the selection. > > WindowCycleControllerTest.KeysConfirmSelection > > Test: WindowCycleControllerTest.LeftRightCycle, > Bug: 1067327 > Change-Id: I03682c5545bf82415b9e71a4814bf5c1b0c196bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358586 > Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#800423} Change-Id: I026a93cb1506ff6e0dc8d9f0e0d49e7236c0aee5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1067327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368813 Cr-Commit-Position: refs/heads/master@{#800482}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e689d3164f34..4909d08c1410 2020-08-21 cclao@google.com Vulkan: Rename mStagingBufferStorage to mStagingBuffer 2020-08-21 jmadill@chromium.org Vulkan: Restart RenderPasses in DS read-only mode. 2020-08-21 cclao@google.com Vulkan: Use context staging buffer for immutable texture update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I4b9181ca884733500d3fa0533ce6ce8b69b8ffce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368545Reviewed-by:
-
