- 11 Dec, 2018 40 commits
-
-
Jakob Gruber authored
A spec change to simplify IsRegExp has been proposed: https://github.com/tc39/ecma262/pull/1318 This CL adds use counters for cases in which the spec change would alter behavior: 1. o[@@match] is trueish but o is not a JSRegExp 2. o[@@match] is falseish (but not undefined) and o is a JSRegExp This is the Chromium side of required changes. The V8-side CL: https://crrev.com/c/1360630 Bug: v8:8522 Change-Id: I2ec9b1a5f54f8e70a02e48f280a548871990aabd Reviewed-on: https://chromium-review.googlesource.com/c/1360730Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#615507}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fed2cb39c320..52411ecf1fa5 git log fed2cb39c320..52411ecf1fa5 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 sortie@google.com Add windows .bat file for gsutil.py. Created with: gclient setdep -r src/third_party/depot_tools@52411ecf1fa5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I5716ec83309d0687fc4897212381997e2374bac2 Reviewed-on: https://chromium-review.googlesource.com/c/1371706Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615506}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/58b1f41bf2fc..757effd70e5f Created with: gclient setdep -r src-internal@757effd70e5f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I72059db2c1ae9f356311302948e043da14b5e44d Reviewed-on: https://chromium-review.googlesource.com/c/1371705Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615505}
-
Mikel Astiz authored
Unless something is done about it, there is a race between signin code trying to fetch "real" cookiejar information using GaiaAuthFetcher, and the test faking equivalent information and injecting it via ProfileSyncService::OnGaiaAccountsInCookieUpdatedWithCallback(). Usually, signin logic is fast enough to avoid test failures, but occasionally the fetching takes long and an empty list of accounts is injected at a last stage (after navigations to kURL2), interfering with test expectations. Bug: 789129 Change-Id: I95b0f691bd047216309888d345c68e1eb26ab869 Reviewed-on: https://chromium-review.googlesource.com/c/1371386Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615504}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bfb8c97cb567..3c2ff12d419d git log bfb8c97cb567..3c2ff12d419d --date=short --no-merges --format='%ad %ae %s' 2018-12-11 fmayer@google.com fuzzing: Do no copy unneeded data files. Created with: gclient setdep -r src/third_party/perfetto@3c2ff12d419d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:69150303 TBR=perfetto-bugs@google.com Change-Id: I7b09f0d39d545600624c2a319a0b853425bd030a Reviewed-on: https://chromium-review.googlesource.com/c/1371704Reviewed-by:
-
Sylvain Defresne authored
Add methods to find AccountInfo using either account id, email address or gaia id to IdentityManager. They are wrapper around the corresponding method of AccountTrackerService (with a call to GetAccountInfoForAccountWithValidRefreshToken to get the logic to deal with kSupervisedUserPseudoEmail). Add unit tests for the new methods. Bug: 912170 Change-Id: Ic7da17b0f22c85349b89cb44d272a3a6b4f6d573 Reviewed-on: https://chromium-review.googlesource.com/c/1365245 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#615502}
-
Sylvain Defresne authored
The fixture made code more convoluted as the default test environment had to be created in the constructor (as the tests expected it) and then recreated afterwards for the ClearPrimaryAccount tests. Instead not using the fixture make the tests more straight-forward as the objects used by each individual tests are explicitly created. This adds some boilerplate, but logic of RunClearPrimaryAccountTest is now clear (previously you had to check in the test what the value of the account consistency method was, while now it is expliclty passed to the method). This follow the recommendation from the following tips of the week https://abseil.io/tips/122 that recommends avoiding fixtures. Bug: none Change-Id: Ia8af245f7b1a3bdeddb7a09fb9baa54a371b8512 Reviewed-on: https://chromium-review.googlesource.com/c/1363199 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#615501}
-
Moe Ahmadi authored
Instead of passing the id<LanguageSelectionHandler> to the ChromeIOSTranslateClient during construction which is prone to error due to dependency on the order in which ChromeIOSTranslateClient and the InfobarCoordinator are initialized, this CL modifies the LanguageSelectionCoordinator to observe the WebStateList and set/unset the id<LanguageSelectionHandler> on instances of ChromeIOSTranslateClient when appropriate. This fixes a DCHECK during ChromeIOSTranslateClient construction and helps make the feature more self-contained as the InfobarCoordinator/Mediator no longer needs to know about the languageSelectionHandler. TBR=rohitrao@ Bug: 912502 Change-Id: Id3769f10a0ed638821afdd9578bd263700768299 Reviewed-on: https://chromium-review.googlesource.com/c/1366467 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615500}
-
Rakina Zata Amni authored
The draft spec for Constructable Stylesheets has moved on from factory functions to normal constructors for CSSStyleSheets, with methods to replace the contents of a constructed stylesheet synchronously or asynchronously. This CL replaces the old factory functions to normal constructors, and implements replace and replaceSync method, the constructed flag, and the disallow modification flag. Not implemented in this CL: allow usage of constructed stylesheets in multiple Documents, FrozenArray instead of StyleSheetList for adoptedStyleSheets. Draft spec: https://wicg.github.io/construct-stylesheets/index.html Bug: 807560 Change-Id: I3c4ea296338d03585ede6332bf29d6732b71c816 Reviewed-on: https://chromium-review.googlesource.com/c/1347647 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#615499}
-
Tim Volodine authored
This patch implements the initial bits for the custom URLLoader that reads from an android InputStream and returns the results (instead of fetching response from an actual network). The general idea is to have this custom AndroidStreamReaderURLLoader take care of a number of things: 1. provide response in the context of shouldInterceptRequest callback 2. allow to read special url like file://android_asset/ to obtain app resources and assets. This patch aims to provide support for the shouldInterceptRequest callback. In particular it makes sure the stream is opened, correctly positioned (range seek), response headers are initialized, etc... Going forward some bits will be implemented further: i.e. returning and writing the actual body response via mojo pipes. Approximately speaking the AndroidStreamReaderURLLoader is the network service counterpart of AndroidStreamReaderURLRequestJob (which is used by the current net/ code path). The patch also adds some relevant corresponding unit tests for the loader. BUG=893566,841556 Change-Id: I15247813f2b359445a2e9d45a18c8e595dfebdb2 Reviewed-on: https://chromium-review.googlesource.com/c/1363184Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#615498}
-
Kent Tamura authored
Form-associated custom elements: customElements.define() should check existence of 'value' property setter on a prototype chain This is a follow-up of crrev.com/613499. Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/187 Change-Id: I0c364d1f3031dde063d40867b5b93cde8a4bdc0e Reviewed-on: https://chromium-review.googlesource.com/c/1370240 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#615497}
-
Alex Clarke authored
A reland of https://crrev.com/c/1324391 This is necessary because we want content::TestBrowserThreadBundle to own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment and you can't have two SequenceManagers on the same thread. This patch allows ScopedTaskEnvironment to optionally work with an externally owned SequenceManager solving the problem. This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk, We now have the ability to mock time on the UI and IO threads. RE HttpServiceTest change HttpServiceTest.MultipleRequests was failing mysteriously on fuschia on the bots only (not locally). IO_MOCK_TIME seems to have fixed this. TBR=gab@chromium.org,fdoray@chromium.org,wez@chromium.org Bug: 863341, 891670, 708584 Change-Id: I95444a0a50f8b577c5fae62c12c8423c7e8f21d6 Reviewed-on: https://chromium-review.googlesource.com/c/1361863 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#615496}
-
Friedrich Horschig authored
This CL disabled these flaky tests: TextFocusFeedback DoubleFocusAlertDialogFeedback ToggleOnKeyUp They have caused failures recently and show a history of flakiness: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ChromeVoxEventWatcherUnitTest TBR=dmazzoni@chromium.org Bug: 912390, 622387 Change-Id: If7647be13420ff98df3a51d0fa156635f181c074 Reviewed-on: https://chromium-review.googlesource.com/c/1371476Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615495}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fabd12d5c959..58b1f41bf2fc Created with: gclient setdep -r src-internal@58b1f41bf2fc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I46ffec1a5aec51a8d01717f847a1156fe3baac33 Reviewed-on: https://chromium-review.googlesource.com/c/1371504Reviewed-by:
-
Max Morin authored
The current code has two bugs. 1. PowerMonitor::RemoveObserver isn't called at destruction. Oops. 2. PowerMonitor::AddObserver is called from a task scheduler thread, which can race with the power monitor being destructed on the main thread. 1 is straightforward to fix but 2 isn't really. The power monitor isn't adding much value, so let's just remove it. Bug: 912922, 912997 Change-Id: I11cbc028d6ef4a9767096f2553d1cc340aa86e57 Reviewed-on: https://chromium-review.googlesource.com/c/1371390Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615493}
-
Friedrich Horschig [CET] authored
This reverts commit 3b3db143. Reason for revert: Strongest suspect for the last 40 failures of telemetry_perf_unittests and telemetry_unittests which failed being unable to find some shared libraries. Bug:913070 Original change's description: > Add RPATH to shared libraries > > Fixes libfontconfig.so not being able to find libfreetype_harfbuzz.so: > > $ ldd libfontconfig.so | grep freetype_harfbuzz > libfreetype_harfbuzz.so => not found > $ ls libfreetype_harfbuzz.so > libfreetype_harfbuzz.so > > R=thakis > > Bug: 911836,912366 > Change-Id: Ia0aaed8fc2c745b02cecf9ee3ce9888c1d8ccf77 > Reviewed-on: https://chromium-review.googlesource.com/c/1362457 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614255} TBR=thakis@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 911836, 912366 Change-Id: Ief4c7258208a2903bb06685d4edc76f482f7a0bf Reviewed-on: https://chromium-review.googlesource.com/c/1371385Reviewed-by:
-
Friedrich Horschig [CET] authored
In addition to timeouts, the mentioned test shows gpu crashes. No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913865, 900641 TBR=gogerald@chromium.org Change-Id: Id1d59744cbd3fb50df822789e1332d77d778756e Reviewed-on: https://chromium-review.googlesource.com/c/1371444 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
-
Thomas Tangl authored
All sync data type toggles are moved into one polymer element. Note: There is no structural change in this CL. In a follow-up CL the toggles are moved to a subpage which is accessible from the sync page. Bug: 912598 Change-Id: I7d07a7051d34840d94a1229c7dae92fa2c1e680c Reviewed-on: https://chromium-review.googlesource.com/c/1367648 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615490}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/53a0082b847f..bfb8c97cb567 git log 53a0082b847f..bfb8c97cb567 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 primiano@google.com Merge "Fix build using system clang." Created with: gclient setdep -r src/third_party/perfetto@bfb8c97cb567 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idece3bb67663352d473355928df1eb1f50745ac5 Reviewed-on: https://chromium-review.googlesource.com/c/1371040Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5ca85e30..ff281cc4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I934f41f3d3db43dcf98058ca1e971b20a2a20505 Reviewed-on: https://chromium-review.googlesource.com/c/1370900Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615488}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a49242766a10..d86edb310a70 git log a49242766a10..d86edb310a70 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 brandon1.jones@intel.com Implement BufferCopyView.imageHeight Parameter Created with: gclient setdep -r src/third_party/dawn@d86edb310a70 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ib46668179950f949baeb3af01a530df6669f9139 Reviewed-on: https://chromium-review.googlesource.com/c/1371042Reviewed-by:
-
Roberto Carrillo authored
This change adds a single fuzzer target to the continuous code coverage bot and the matching trybot. R=stgao,liaoyuke,jbudorick,mmoroz Change-Id: Iab4af3dbfcfbce608b42a3089913f30d6753382d Reviewed-on: https://chromium-review.googlesource.com/c/1364690 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615486}
-
Friedrich Horschig [CET] authored
This reverts commit 464fae69. Reason for revert: Causes heavy flakiness (14/17 on Mac 10.11) and attempted fix showed no effect: https://crrev.com/c/1369136 TBR=ccameron@chromium.org Bug: 902583 Original change's description: > RemoteMacViews: Fix hang at command-Q > > When we call -[NSApp terminate] in the app shim process, this does > not immediately terminate. Rather, it > 0. Sends the message appShimController_->host()->QuitApp() and waits > for a reply before actually terminating. > 1. In the browser, this call hits ExtensionAppShimHandler:: > CloseBrowsersForApp > 2. Which will end up calling NativeWidgetMac::Close > 3. Which will then politely request that the app shim process close > the corresponding window via > views_bridge_mac::mojom::BridgedNativeWidget::CloseWindow > 4. Which will send an ack back to the browser via > views_bridge_mac::mojom::BridgedNativeWidgetHost::OnWindowHasClosed > 5. Whereupon the browser window will be registered as closed, and a > close message will be sent to the app shim, and the wait for > termination will break > > This ends up not working at step 3. Our suspended terminate ends up > running a nested message loop inside a mojo message handler, and so > it will never execute the CloseWindow message, and therefore never > close. > > Change the logic at [0] to send the QuitApp message, and then > immediately terminate the application. > > Bug: 902583 > Change-Id: I60fd7b5fdf9f145369d06219e8ebef36cdcd0f44 > Reviewed-on: https://chromium-review.googlesource.com/c/1364220 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614922} TBR=ccameron@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 902583 Change-Id: I34a3300dc188cdd0de58692042ce131a8639117f Reviewed-on: https://chromium-review.googlesource.com/c/1371475Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 154ccf48. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I33fe622c06b23e31831704dae9817fb2a54120ce Reviewed-on: https://chromium-review.googlesource.com/c/1370899Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615484}
-
Eric Seckler authored
Adds a new DataSource for the ARC++ system tracing agent. Each ArcTracingBridge registers with the data source and keeps track of its state, so that the data source can coordinate tracing between all the bridges. TBR=oysteine@google.com Test: Manually capture a trace with and without perfetto backend. Bug: 900603 Change-Id: Ieb29bcb65de9f4802965a30844e9f76af55db1f3 Reviewed-on: https://chromium-review.googlesource.com/c/1360736Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#615483}
-
Elad Alon authored
Bug: 775415 Change-Id: I44d028c36558df47c0dd33cc853d4e50938c49bc Reviewed-on: https://chromium-review.googlesource.com/c/1370945Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#615482}
-
Edward Jung authored
Bug: 900536 Change-Id: Ia48b90e99c52cdb3ab35b952f8647007698048d8 Reviewed-on: https://chromium-review.googlesource.com/c/1370366Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#615481}
-
Yuki Shiino authored
Make IDL callback interface not hold a ScriptState of its creation context when it's cross origin from the incumbent realm. This is the same fix as https://crrev.com/c/1314023 for IDL callback interface. Bug: 886588, 883643 Change-Id: I38887c8d460d2b6879818bb31427f04a15dcf815 Reviewed-on: https://chromium-review.googlesource.com/c/1343816 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#615480}
-
Matt Falkenhagen authored
This adds a test that a stylesheet that failed to load is considered cross-origin. That is, accessing |styleSheet.rules| throws a SecurityError. This aligns with the specifications: - cssRules checks the `origin-clean` flag: https://drafts.csswg.org/cssom/#dom-cssstylesheet-cssrules - This is set to true iff CORS-same-origin: https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet - CORS-same-origin is false for "error" responses: https://html.spec.whatwg.org/multipage/urls-and-fetching.html#cors-same-origin Bug: 911974 Change-Id: I558e6d3dfa564b15284c393ffc35b80f54a9bc4e Reviewed-on: https://chromium-review.googlesource.com/c/1371307 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b04ad33a6ff2..fabd12d5c959 Created with: gclient setdep -r src-internal@fabd12d5c959 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie3b83e657bf7f7fce7655cd2a4450b7a80e754cb Reviewed-on: https://chromium-review.googlesource.com/c/1371041Reviewed-by:
-
Yi Su authored
This CL fixes a logic defect of a while-loop in the "isElementVisible_" function of find_in_page.js. This defect may cause a Js exception of trying to get "ownerDocument" property on "null". Bug: 912717 Change-Id: I32b39315983004b28fd6a2000b9ff7317225f8bf Reviewed-on: https://chromium-review.googlesource.com/c/1370173Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615477}
-
Yi Su authored
This CL removes the remaining comments about scrolling in find_in_page.js. Bug: 911780 Change-Id: Ie2ce2c4c45e2f829dba2338446943da63da13946 Reviewed-on: https://chromium-review.googlesource.com/c/1365896Reviewed-by:
-
Matt Falkenhagen authored
This adds tests that stylesheets that result from requests that were redirected cross-origin are considered cross-origin. Note that A->B->A redirects, which redirect from cross-origin to same-origin, are considered cross-origin. See https://github.com/whatwg/fetch/issues/737 and https://github.com/whatwg/fetch/pull/834. In Blink, we have redirect tests at http/tests/security/cannot-read-cssrules-redirect.html. This WPT addition will supersede that test, but I won't yet remove it since it asserts the opposite for the A->B->A case. I can remove the test when Blink changes to pass this WPT test. Bug: 911974 Change-Id: Ie015c0390829299de7c29cff6685ddfcd774c66f Reviewed-on: https://chromium-review.googlesource.com/c/1370162Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/264843e30745..9cabb4f98e99 git log 264843e30745..9cabb4f98e99 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@9cabb4f98e99 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I2de3c5dc1c1a5b17947f8be476eac57818ee2d24 Reviewed-on: https://chromium-review.googlesource.com/c/1371256Reviewed-by:
-
Koji Ishii authored
This patch removes a comment in a test that is not needed. It was a left over in r615053 (CL:1366472). Bug: 904291 Change-Id: I785080fd401426261d6259c22f5f20059fdcba1f Reviewed-on: https://chromium-review.googlesource.com/c/1370148Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#615473}
-
Boris Sazonov authored
This CL addsSigninTestUtil.resetSigninState call to OAuth2TokenServiceIntegrationTest.tearDown, so all signin-related prefs are wiped and the state doesn't leak from the test. Bug: 908542 Change-Id: I43b37d76bd24e14687a4e9d0ab35d2e88d283f6f Reviewed-on: https://chromium-review.googlesource.com/c/1369940Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#615472}
-
Gauthier Ambard authored
This CL increases the switch compression resistance priority to make sure that it doesn't get too compressed by the label. Bug: 912698 Change-Id: Ib8926b6fbcc60394506a9b348e9f79e4a11fae5d Reviewed-on: https://chromium-review.googlesource.com/c/1370274Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#615471}
-
Tsuyoshi Horo authored
Currently if the default favicon request is caught by the testing service worker the test fails. This is causing the test flakiness. To fix this flakiness, this CL change the fetch event handler of the service worker to ignore the default favicon request. Bug: 912543 Change-Id: Icdddd902a4547361320f43db5b9090270ba74509 Reviewed-on: https://chromium-review.googlesource.com/c/1370160 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615470}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a7be9d55a9c..b04ad33a6ff2 Created with: gclient setdep -r src-internal@b04ad33a6ff2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I07ce2495c2f1f849b57cbc435a5a865bbd1522f6 Reviewed-on: https://chromium-review.googlesource.com/c/1371255Reviewed-by:
-
Leszek Swirski authored
There are some edge cases where IsLoaded is true but IsFinishedInternal is not (yet) true, so remove that check and expand the comment. Bug: 865098 Bug: 899217 Bug: 909858 Change-Id: I886df54c9a373e7431938aadd4a6a1a4d256d7dc Reviewed-on: https://chromium-review.googlesource.com/c/1369789Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#615468}
-
