GitLab

On Android, we can expose EXTRA_DATA_TEXT_CHARACTER_LOCATION_KEY
on accessible nodes in order to allow services like Select To Speak
to get the bounding box of individual characters or character
ranges.

When we implemented support for this, we exposed it on almost any
element, but this leads to Select To Speak not being able to
distinguish between real text, and things like images with no
visible text that it might be able to OCR.

Fix this by exposing this character location key only on nodes
that are static text or have a static text descendant.

Add a test that covers some common cases.

BUG=812772

Change-Id: I48941edfaa7522fdd36a5bd7fc88a0a4054713f3
Reviewed-on: https://chromium-review.googlesource.com/922688
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537465}

Merge internal change: 186016017

Change-Id: I0b1aa566e794c6360877eb9f3c05dcdcf3247c9a
Reviewed-on: https://chromium-review.googlesource.com/924443Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537464}

When we remove a page from download home, we also should tell the
Android Download manager that the offline page is no longer
available so it can get properly cleaned up.

Bug: 758690
Change-Id: Ifd492c4c505e3b0eab36fabf044612e23fb128da
Reviewed-on: https://chromium-review.googlesource.com/912766Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537463}

A BlobDataHandle could not have a content_type set, but that should be
treated no different from an empty string, so serialize it as such.
Otherwise this will trigger validation failures causing weird behavior
when for example a blob without a content type is posted on a
MessagePort.

Bug: 813146
Change-Id: I0a20a6b91391e9aa490a337b93c74f9ab4316e31
Reviewed-on: https://chromium-review.googlesource.com/924338
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537462}

Spellcheck was mojofied in crrev.com/c/846370, but relevant files
are left without being renamed, so that we don't break git revision
log. This patch finishes the renaming.

Bug: 714480
Change-Id: If6df9357871a4a2e353f3ab336878d3be891c596
Reviewed-on: https://chromium-review.googlesource.com/898529Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537461}

https://boringssl.googlesource.com/boringssl/+log/67968895b3b8cace34ea6dbdf65ac922667959ac..085955c56744a9cc82f98ed850deca2165252d2c

BUG=none

Change-Id: I0f487c4379cc2afe960f958ba137373c89eb1011
Reviewed-on: https://chromium-review.googlesource.com/924344
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537460}

- Define GetCdmProxyContext() interface and the default implementation.
- Define CdmProxyContext interface.
- The interface will be used to get data from CdmProxy implementation
  required for decrypting/decoding.

Bug: 799310
Change-Id: I1f1bdd7036ebbd2598371b249a7e85e1fe90e7f2
Reviewed-on: https://chromium-review.googlesource.com/915215
Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537459}

The bug was the VrShellGl::OnVSync is called every frame (by the Android
Choreographer), and we would restart the timer from the beginning. As a result
it would never actually fire.

In this CL, we only schedule the timeout if there's a state change from when
we start sending VSyncs to the WebVR page again. Note that we only ever stop
sending VSync for DLAs so that we can show the splash screen for a minimum
duration, so what this effectively means is not scheduling timers in OnVSync
for non-DLA WebVR presentations.

Bug: 812292
Change-Id: I06c58b8902704f5d3033ded4ad7839f077e71052
Reviewed-on: https://chromium-review.googlesource.com/923547Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537458}

This cl handles the ui::VKEY_BACK. If it is already empty search box and
typing ui::VKEY_BACK will exit search mode in Keyboard Shortcut
Viewer (KSV).

Bug: 768932
Test: Tested on device.
Change-Id: I5cee02a97959784163e65e300b5113f2a3409513
Reviewed-on: https://chromium-review.googlesource.com/923090
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537457}

Kochi Mincho is old and is not available on newer linux distros.  IPA Mincho is
a suitable replacement.  However, the IPA font metrics are slightly different
than Kochi.  There were some test expectations that certain font metrics (like
baseline) be different from Arial, but they're conincidentally not for IPA.  I
also swapped out Arial for Verdana so that the metrics would still be different.

BUG=812911
R=derat
TBR=asvitkine

Change-Id: Ida904c06ad8aa962ac850ff47cda1170103638fa
Reviewed-on: https://chromium-review.googlesource.com/923551Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537456}

This reverts commit b5d6f42d.

Reason for reland: The revert didn't fix the failing tests

Original change's description:
> Revert "[jumbo] avoid helper function collisions in VisibleUnits*Test.cpp"
> 
> This reverts commit 53413b13.
> 
> Reason for revert: (sheriff) Attempt at addressing failure at:
> https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/66387
> 
> Original change's description:
> > [jumbo] avoid helper function collisions in VisibleUnits*Test.cpp
> > 
> > This fixes jumbo builds after https://chromium-review.googlesource.com/923604
> > 
> > Change-Id: Ib7030da7e0a6acfdad8200564f9375ba218e8ca6
> > Reviewed-on: https://chromium-review.googlesource.com/923723
> > Reviewed-by: Fredrik Söderquist <fs@opera.com>
> > Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
> > Cr-Commit-Position: refs/heads/master@{#537278}
> 
> TBR=yosin@chromium.org,fs@opera.com,mostynb@vewd.com
> 
> Change-Id: I5b31694096f982e50954ee959b7e5c58d04a77f9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/923374
> Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
> Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537400}

TBR=yosin@chromium.org,fs@opera.com,dschuyler@chromium.org,mostynb@vewd.com

Change-Id: I922f59a9b1cd3fe66e277a05118685ed008ad88b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/924591Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537455}

SlimmingPaintV175 enables raster invalidation and paint chunks based
on paint properties. See crbug.com/771643.

Bug: 771643
Change-Id: I5fdbcabc7ca0f2fa8e69ae0fbf5a0077bba46cfe
Reviewed-on: https://chromium-review.googlesource.com/923572Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537454}

The UseCounter being on the partial interface wasn't actually counting
anything. Move to the attribute instead.

Confirmed in V8CSSPartial generated code that this is now doing the
right thing.

Change-Id: Iab0f50535f7a06e4c2ff1172b7c80133554f9ae7
Reviewed-on: https://chromium-review.googlesource.com/923542Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537453}

Since 8a14e909 we dispatch device change notifications when palm suppression
state changes. This is causing context menus to be dismissed erroneously on stylus
lift. It's unclear why this is happening and should be fixed, but for now just
revert to the old behavior.

This is a partial revert of 8a14e909.

Bug: 810599

Change-Id: Ida6b01f225e35cc7e04b603055a69a25c3f0163d
Reviewed-on: https://chromium-review.googlesource.com/923214
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537452}

It looks like we have plenty of capacity.

R=jbudorick@chromium.org
BUG=694033

Change-Id: I36c232b1a3fd3a91a501144630bf6ff7ec73a9dc
Reviewed-on: https://chromium-review.googlesource.com/920657Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537451}

Additionally, this CL updates CRWGenericContentView's contentSize
adjustment logic to ensure that scrolling doesn't get disabled.

Bug: 807957
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idf48f9b79966520f31477b0a58415eb286f037ae
Reviewed-on: https://chromium-review.googlesource.com/917642Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537450}

This reverts commit 4de65ba0.

Reason for revert: Causing 'gn gen' on Mac builder to fail:
https://ci.chromium.org/buildbot/chromium/Mac/38303

Original change's description:
> Mac SelectFileDialog TLC
> 
> - Resurrects shell_dialogs_unittests on Mac
> - Fixes 2 tests that had regressed since the gn transition.
> - Tweaks the code to be more robust around complex object lifetimes.
> - Adds test SelectFileDialogMacTest.Lifetime
> 
> Bug: 788271
> Change-Id: Ice43179a1da3b7bbcd44fb9b0efdf6d84e4d2f5b
> Reviewed-on: https://chromium-review.googlesource.com/920961
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Trent Apted <tapted@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537419}

TBR=avi@chromium.org,tapted@chromium.org,rsesek@chromium.org

Change-Id: I24a41bcb566a2bff3e58b5babce7ec77b43d0b63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 788271
Reviewed-on: https://chromium-review.googlesource.com/924483Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537449}

https://chromium.googlesource.com/angle/angle.git/+log/17448956b720..0cbfa5866f43

$ git log 17448956b..0cbfa5866 --date=short --no-merges --format='%ad %ae %s'
2018-02-15 jmadill Vulkan: Implement basic Renderbuffer attachments.
2018-02-16 oetuaho Simplify built-in function node initialization

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=lucferron@chromium.org

Change-Id: I2fe98dedbab2dbb2bf2071f970de3257c8a99165
Reviewed-on: https://chromium-review.googlesource.com/924467
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537448}

Bug: 804499
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I066fc6b53f8f2775f559f8dd75ab63d629b74e9d
Reviewed-on: https://chromium-review.googlesource.com/924381
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537447}

Touching VERSION elicits a regeneration of all mojom message IDs on
platforms where message ID scrambling is enabled.

Before this CL, that regeneration step induces a rebuild of over
13000 targets when building chrome, as all mojom headers are
regenerated, and dependencies on mojom headers abound.

After this CL, the regeneration step only forces a rebuild of
a new per-mojom header dedicated exclusively to message ID
definitions, affecting only the corresponding mojom.cc files
and reducing the rebuild cost to about 2700 targets.

This also introduces a new GN arg |enable_mojom_message_id_scrambling|
which defaults to |true|, enabling the current scrambling behavior on
all supported platforms. If set to |false|, message IDs will never
be scrambled and changes to VERSION won't affect mojom in any way.

Bug: 808162
Change-Id: I8c4e4fa1dcc8d1d4349febee7dea6cce824ca0a6
Reviewed-on: https://chromium-review.googlesource.com/900528Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537446}

This logic happens behind the flag --cc-check-damage-early.

If any of the last 3 frames had no damage, we enable the damage check in
WillBeginImplFrame from crrev.com/c/767851. This is described further here:
https://docs.google.com/document/d/1Onv9teMJMyT63-8NywNQfaYY2PRTujvqI9Xa9jGcXvY

Bug: 687695
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ie77abd0f587dc9815012bde87d5d0354a2f9cbbf
Reviewed-on: https://chromium-review.googlesource.com/854991Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537445}

These patches are taken out of googletest update
https://crrev.com/c/900544. That CL has been reverted, and fixing the
revert cause may take a while. Landing these patches now, separately,
will reduce the size of the next googletest update CL, and might reduce
code churn, if the googletest update CL needs to be reverted.

Bug: 813219
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I19022e107f459e1dce91921336346c610ec51409
Reviewed-on: https://chromium-review.googlesource.com/924444
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537444}

This CL addresses sources of frontend errors:
- Right click blank space in console can throw an error when building
  context menu if no console message is targeted.

- StylesSidebarPane calls setTimeout to highlight a node, but in
  between refreshes it is possible for the model's node to change to
  `null`. Hard to reproduce.

Bug: none
Change-Id: I24bfc4c8b2f514aad140e6c46a15f0d344b954ec
Reviewed-on: https://chromium-review.googlesource.com/920769Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537443}

Bug:71939

PinnedTabService is observing two events:
NOTIFICATION_CLOSE_ALL_BROWSERS_REQUEST and BrowserList::OnBrowserClosing.

The first is when users want to shut down entire app and
the latter is when users close a browser at once even if it has multiple tabs.

But the bug is edge case which doesn't belong to any case above for now.
When tab strip is empty, BrowserListObserver::OnBrowserClosing is not called even
this will end up with closing the browser.

So try saving pinned tabs again on BrowserListObserver::OnBrowserRemoved.

Change-Id: Id73891b9509918bca3b1dcaf0b34cc32a7a687a7
Test: PinnedTabServiceBrowserTest.*
Reviewed-on: https://chromium-review.googlesource.com/892539Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537442}

When prefetching is enabled, the collection view can get configured cells
in advance of them becoming visible. If the item updates after a cell was
prefetched, but before it is visible, the cell cannot be reconfigured.

For SavePasswords, the Export button may need to be enabled/disabled after
being prefetched, so prefetching needs to be disabled.

Bug: 812171
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ieef7b9cc3b91e237638277654e5d373c3906fb47
Reviewed-on: https://chromium-review.googlesource.com/924307Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537441}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Ia1a3dd17217361e48789bfc92d0a71ea43e5dd1d
Reviewed-on: https://chromium-review.googlesource.com/924588
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537440}

Bug: 812672
Change-Id: Idc1724a5358ea5814b14e8b9fb85ca25bf3a6c21
Reviewed-on: https://chromium-review.googlesource.com/922262Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537439}

Between when the root view controller is created and the new (or active)
tab is displayed, there is a brief interval when the root view controller
is displayed. This is usually less than one display refresh cycle, but
if (for example) a crash is being uploaded on a slow device, it may
be longer than that. If so, a white screen will appear (this is the root
view controller's view when it doesn't contain a tab switcher).

To mitigate this effect, this CL has the main view controller add a copy
of the launch screen view to its view hierarchy. It is removed as soon as
another view controller is added as a child of the main view controller.

This is the same approach that's used to solve a similar issue when showing
the FRE on some devices. It's terrible and we will find something better
soon, but this will resolve the issue for M65.

Bug: 803758
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ife105aa253019b41eac5002a33e69da71eb51944
Reviewed-on: https://chromium-review.googlesource.com/920521
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537438}

This fixes a few edge cases in the status tray network list:
* Crash when an existing guid moves to the end of the list.
* Incorrect filtering out of EthernetEAP in system tray
  (and other code). Mostly harmless but generates extra work.
* More readable/searchable filtering of default cellular network.

Bug: None
Change-Id: I66b075ed90d3332178f0c1caebcf457c2db15da5
Reviewed-on: https://chromium-review.googlesource.com/920790Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537437}

This prepares removing the option to make landmines target-platform
dependent, as this depends on gyp environment variables.

Instead we'll be able to only depend on host_os.

This will cause clobber on all Android builds, as Android-specific
landmines will no longer be supported.

In follow-ups, we'll remove use of landmine_utils.platform() in other
client projects and then remove the definition here.

Bug: 756691
Change-Id: I08c1f4ecd05f5f4331bf1ab9eedda22419af2942
Reviewed-on: https://chromium-review.googlesource.com/924114Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537436}

Previously, active sessions and recent users were reported separately,
that is confusing on the server side.
This change adds 'user_email' field to ActiveTimePeriod proto message
and populates it for affiliated users that are eligible for reporting.
Also, user email is reported only if user reporting is turned on.

BUG=810093
TEST=Browser tests added.

Change-Id: I92fec6725349972895ec0a439f78efa59853670e
Reviewed-on: https://chromium-review.googlesource.com/904527Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537435}

Currently, spellchecker uses mojo only on Linux and Window, and still
uses IPC on Mac and Android. This patch finishes the mojofication on
Mac and Android.

Details:

1. For each spellcheck message, a new API in SpellCheckHost mojom
   is defined. Their original senders are changed to call the new
   mojo APIs.

2. To allow spellchecking on WebView, a new impl of SpellCheckHost
   named SpellCheckHostImpl is created in components/spellcheck. The
   existing impl SpellCheckHostChromeImpl is changed to inherit
   SpellCheckHostImpl for code sharing.

3. The existing chrome/browser/spellcheck_message_filter_platform_mac.cc
   is changed to Mac-only implementation of SpellCheckHostChromeImpl.

4. The existing message filter implementation on Android, which is
   basically a wrapper class of SpellCheckerSessionBrige, is replaced
   by new wrapping of SpellCheckerSessionBridge in the Android-only
   implementation of SpellCheckHostImpl.

5. Remaining changes are test changes.

To reduce patch size, there are some leftovers that will be done
by follow-up patches:
- Remove the spellcheck message files
- Rename certain files according to TODOs left in this patch

Bug: 714480
Change-Id: I1a25307284b8973f0b39cae58dfa46b27232349a
Reviewed-on: https://chromium-review.googlesource.com/846370Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537434}

This reverts commit 697d4f8f.

Reason for revert: Breaks ios_chrome_smoke_egtest
https://logs.chromium.org/v/?s=chrome%2Fbb%2Finternal.bling.main%2Fchromium-autoroller%2F7360%2F%2B%2Frecipes%2Fsteps%2Fios_chrome_smoke_egtests__iPad_Air_iOS_11.2_%2F0%2Fstdout

Original change's description:
> Enables Mailto Handling with Google UI by default.
> 
> Bug: 808113
> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
> Change-Id: I2b475e6fd474c900ed1984010d15a3e1e31c2af0
> Reviewed-on: https://chromium-review.googlesource.com/922930
> Commit-Queue: Daniel Blakemore <danblakemore@google.com>
> Reviewed-by: Peter Lee <pkl@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537373}

TBR=pkl@chromium.org,danblakemore@google.com

Change-Id: I794a8b314c2927ef90636e52e0f42d17512d97dd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 808113
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/924482Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537433}

We have the data we need now

Bug: 731434, 813170
Change-Id: I3bd8f4bc5460e214af0041c309cf1ea939290adf
Reviewed-on: https://chromium-review.googlesource.com/923428Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537432}

https://skia.googlesource.com/skia.git/+log/48b56688e8f5..1701ecea23b0

$ git log 48b56688e..1701ecea2 --date=short --no-merges --format='%ad %ae %s'
2018-02-16 borenet [recipes] Expand depot_tools DEPS hack for flutter and PDFium builds
2018-02-16 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ 0fb1530a0..c9b7366e8 (2 commits)
2018-02-15 csmartdalton Forward internal_private_accessTopLayerRenderTargetContext from SkPaintFilterCanvas
2018-02-16 fmalita Guard ignored SVG attribute logging with SK_VERBOSE_SVG_PARSING

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: I2ddf847b56362fa48277a3a0ba056cc4fa2597e9
Reviewed-on: https://chromium-review.googlesource.com/924454Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537431}

If an image can be used for raster directly, it doesn't need to hit
the decode cache or be unlocked. Avoid unnecessary tracking for them
in CanvasImageProvider.

R=ericrk@chromium.org, junov@chromium.org

Bug: 809130
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib899f79c8a208f3bcb2395595162561e12757987
Reviewed-on: https://chromium-review.googlesource.com/919966Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537430}

The Generic Sensor implementation on Windows depends on certain COM
objects being registered on the system. To assist in debugging issues
with these being missing on (it is believed) Windows 10 N editions this
change adds one-time logging when CoCreateInstance fails.

Bug: 756986
Change-Id: I159b7b379a94caa6980d17b9e02a61209154eade
Reviewed-on: https://chromium-review.googlesource.com/923383
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537429}

This applies a workaround for one of Samsung's OEM mail apps which was
negatively affected by PlzNavigate. This is meant as a minimal temporary
workaround until we finish investigation on the issue.

The app is loading 2 URLs (a file:// URL followed by
loadDataWithBaseUrl) in quick succession. This workaround posts the
second load by 200ms. In my testing, I've found that 40ms is more than
enough, so 200ms should be very safe (but still fast enough to not
adversely impact user experience).

Bug: 781535
Test: manual - with the actual Samsung mail app
Change-Id: I1fdb002c377af083158a5dc4e0e7ce067a176d30
Reviewed-on: https://chromium-review.googlesource.com/924115Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537428}

This cl defocus search box after exiting search mode in Keyboard
Shortcut Viewer (KSV).

Bug: 768932
Test: Tested on device.
Change-Id: I71bdfb3c923ec6ab73ae3125fd0a40e542ecdc0e
Reviewed-on: https://chromium-review.googlesource.com/923113Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537427}

Both from this run:
https://build.chromium.org/p/chromium.fyi/builders/Fuchsia%20%28dbg%29/builds/16374

Bug: 764015, 811881
Change-Id: If6954f1ded3ad61961dd60c994ef7d1d905351c9
Reviewed-on: https://chromium-review.googlesource.com/923431Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537426}