- 13 Dec, 2017 40 commits
-
-
Alexey Kozyatinskiy authored
TBR=dgozman@chromium.org Bug: chromium:697334 Change-Id: Ic3007ca377343820beff72631480f3e49c7ffe0f Reviewed-on: https://chromium-review.googlesource.com/824943Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#523817}
-
Emily Stark authored
The content::InterstitialPage hierarchy makes sure that blocking page's Show() method is called when the interstitial is shown, and OnProceed/OnDontProceed (from InterstitialPageDelegate) when the interstitial is hidden. However, with committed interstitials, the content::InterstitialPage hierachy is no longer used, so we can no longer rely on Show(), OnProceed(), and OnDontProceed() to be called to trigger metrics set up, recording, and cert reporting. This CL makes the following changes to account for this: - Introduce a new SSLBlockingPageBase superclass that handles cert reporting and metrics collection when an interstitial is closing. In the old code path, this is all triggered from OnProceed/OnDontProceed. In the new code path, it's triggered when SSLErrorTabHelper cleans up a blocking page, which happens when we navigate away or (newly in this CL) when the tab is closed. We can later move more shared code from the various SSL-related blocking pages into SSLBlockingPageBase. - Adjust how a blocking page's HTML is generated in the committed interstitials code path: instead of calling GetHTMLContents() directly, we now call a wrapper method that does the Show() metrics setup. - Deprecates an old metric that isn't actively used and was going to be a pain to adapt to the new code path. I've also enabled certificate-reporting-related browser tests for committed interstitials. Bug: 792319,792324,792324 Change-Id: I1fcbdc18085434e6c65139350f159fc8c06419c9 Reviewed-on: https://chromium-review.googlesource.com/811604 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#523816}
-
Tommy C. Li authored
Bug: 781644 Change-Id: I450b4b3472fa024b753a512058ddf0668b280307 Reviewed-on: https://chromium-review.googlesource.com/821051 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#523815}
-
Maks Orlovich authored
This is 99.9% work by Gavin Peters, at https://codereview.chromium.org/2501353002, with me just tweaking some parameters and applying the tiny things I suggested on that review. Bug: 611464, 722885 Change-Id: I5bdc7d60ec4bc54e1099f408ea09e0573c176fca Reviewed-on: https://chromium-review.googlesource.com/800972 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#523814}
-
Danyao Wang authored
TabUsageRecorder::ShouldIgnoreWebState() is meant to filter out tabs that are currently loading a chrome:// URL and not record page load stats for them. However, it treats pending item and last committed item inconsistently and looks at the URL for one and virtual URL for the other. This causes a problem when switching to WKBasedNavigationManager because switching to an evicted tab will load restore_session.html in the web state. This results in a pending item with a file:/// URL and a virtual URL that is whatever the page that is being restored, which may be a chrome:// URL. Not using virtual URL for pending item seems to be a bug introduced in https://codereview.chromium.org/2820763002. It replaces [tab url] with pending_item->GetURL. At the time, [tab url] was implemented using virtual URL (see https://codereview.chromium.org/2919983002). Added a unit test to cover this case. Bug: 789993 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0861ee94ca0d3c5612d3e1ad7680f18bfd7368f0 Reviewed-on: https://chromium-review.googlesource.com/817356Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#523813}
-
Michael Lippautz authored
Tbr: haraken@chromium.org Bug: chromium:757440, chromium:790691 Change-Id: I1a660cc40c1f79713dd98948c0efd4477eff958b Reviewed-on: https://chromium-review.googlesource.com/823844Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#523812}
-
Tom Sepez authored
Next step forward towards sandboxing network service. Ensures that all FS access goes through the proxy, even if it is not being subject to any whitelist restrictions yet. All other syscalls are still allowed. Bug: 715679 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ibe8dd5a09bbf498bc10c9ae289222b8e46b8e4b7 Reviewed-on: https://chromium-review.googlesource.com/817697 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#523811}
-
Hugo Holgersson authored
This patch does not change any web facing logic. Only private methods are changed, the public API is untouched. Renamed methods: DispatchCPPEvent -> DispatchClipboardEvent TryDHTMLCopy -> DispatchCopyEvent TryDHTMLCut -> DispatchCutEvent TryDHTMLPaste -> DispatchPasteEvent These methods now return false upon preventDefault() from JavaScript. Before this change, only the first method followed this convention. Bug: 755459 Change-Id: I2b9dd77b0c0cd6a2ad29136e1ec2f9dec7d37622 Reviewed-on: https://chromium-review.googlesource.com/810806Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Hugo Holgersson <hugoh@vewd.com> Cr-Commit-Position: refs/heads/master@{#523810}
-
Sahel Sharify authored
With this cl scroll latching timeout is increased to 500ms and the phase handler ends a timer-based scroll sequence once the difference between coordinates of the initial wheel event in the sequence and the current wheel event exceeds some threshold. TimerBasedLatchingBreaksWithMouseMove Bug: 526463 Test: RenderWidgetHostViewAuraWheelScrollLatchingEnabledTest. Change-Id: Ie6afbf205c42dfce4f3a3f56937c9cb32b2feebf Reviewed-on: https://chromium-review.googlesource.com/820334 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#523809}
-
Daniel Bratell authored
using namespace includes a full other namespace into the global scope and that doesn't work well with jumbo builds for two reasons: Too many symbols, and "using namespace" isn't allowed in something that is included. It is also not allowed by the style guide. This patch removes the using namespace and uses explicit namespaces instead. It also changes some repetitive code to use macros to make it less repetitive and easier to read. Bug: 773275 Change-Id: If45f81b435920bd9048567ec65f9b142046e86ea Reviewed-on: https://chromium-review.googlesource.com/824843Reviewed-by:
-
Ahmed Fakhry authored
- There was a bug when the start and end times are inverted (i.e. start time is greater than end time as a time of day today). - The schedule should refresh when device resumes from sleep since time will have changed while the device was suspended. BUG=768902 TEST=Added new tests Change-Id: I105085e36e9a68db97506e69286b471b8a738731 Reviewed-on: https://chromium-review.googlesource.com/821413Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#523807}
-
Harald Alvestrand authored
Also fixes a misspelling of "timestamp" as "timeStamp". Bug: webrtc:8616 Change-Id: I76304d9235bbb1e4fca1e821a2e10dff0777bb2d Reviewed-on: https://chromium-review.googlesource.com/824269 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#523806}
-
sebsg authored
Bug: 776308 Change-Id: Ief862b6566f4534468b9ef2228911fff6c0efc10 Tbr: dmazzoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/824962Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523805}
-
Eugene But authored
On iPad PKAddPassesViewController alloc/init returns nil. This CL fixes a crash, which caused by presenting nil view controller. The functional behavior remains the same as for old pass kit implementaiton (the error is silentry ignored). This issues is tracked in a separate bug (crbug.com/794301). Bug: 787943 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id3826fa13d5c327795d411b3ec7b9c5d343031c1 Reviewed-on: https://chromium-review.googlesource.com/823239Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#523804}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/f85c43bc7374..14768f3264a4 $ git log f85c43bc7..14768f326 --date=short --no-merges --format='%ad %ae %s' 2017-12-13 thestig Get rid of CXML_AttrMap. 2017-12-13 thestig Fix some nits in CXML_Element. 2017-12-13 thestig Use size_t in CXML_Element and callers. 2017-12-13 thestig Simplify CXML_Element::GetTagName(). 2017-12-13 thestig Inline CXML_Element private methods. 2017-12-13 thestig Remove dead CXML_Element code. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3cb26439c453ee16b04ffad2d5ec2b9562f07d55 Reviewed-on: https://chromium-review.googlesource.com/824427 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523803}
-
Julia Tuttle authored
(since he's no longer doing reviews) Bug: Change-Id: I0ff731864705a88006b159f26781856402cd737e Reviewed-on: https://chromium-review.googlesource.com/825002Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Cr-Commit-Position: refs/heads/master@{#523802}
-
Eugene But authored
This was deprecated method from CRWWebDelegate which is not used anymore. Bug: 674991 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie06ae35173b03681a49625272aa0ec8c2a38265f Reviewed-on: https://chromium-review.googlesource.com/820934Reviewed-by:
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/87cc90dfaaf7..e30edd6fcb96 $ git log 87cc90dfa..e30edd6fc --date=short --no-merges --format='%ad %ae %s' 2017-12-13 jiajia.qin Update deqp31 test expectations Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I71693941eae5c70e6249998869504a195100d6ca Reviewed-on: https://chromium-review.googlesource.com/824428Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523800}
-
Boris Sazonov authored
Last usage of this constructor was removed by https://crrev.com/i/459854. Bug: 746519 Change-Id: Id798024deec1915c9c101b46d84287c530469629 Reviewed-on: https://chromium-review.googlesource.com/824762Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523799}
-
Tarun Bansal authored
blink-dev i2s thread with 3 LGTMs: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/AgonJunvfIE Bug: 772566 Change-Id: I09178ae913a513de7dc646b1dd43cdffafe1b3c5 Reviewed-on: https://chromium-review.googlesource.com/823252Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#523798}
-
Theresa Wellington authored
When the toolbar is translated for the search provider logo on the NTP, the background needs to be transparent to prevent it from covering part of the RecyclerView's scroll bar. BUG=791766 Change-Id: I9651c16dccc153d1bdad15925a51fae9acbeb591 Reviewed-on: https://chromium-review.googlesource.com/823575Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Denis Kuznetsov authored
Bug: 771918 Change-Id: I97aa23f789d70dcc611fae05cb10b4e9b18009ed Reviewed-on: https://chromium-review.googlesource.com/820310Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#523796}
-
edchin authored
The use of -rootViewController is fine here because it is used for safe area sizing rather than presentation. This is necessary because the view is not in the hierarchy at the time the sizing is done. We should find a way to completely remove rootViewController, which may involve moving when the sizing is done in this case. Bug: 791784 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id69b668a9b08c85b0e0ff66a3dd90ac56f580ecd Reviewed-on: https://chromium-review.googlesource.com/824432 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#523795}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/6c8e6666cebe..1aa285974b6b $ git log 6c8e6666c..1aa285974 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtcBUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I019bc2d27e51e2d48adde5eae9637b9aea48d163 Reviewed-on: https://chromium-review.googlesource.com/824642Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#523794}
-
Dominik Röttsches authored
Animating or using an ever increasing number of instances of variable fonts can make the font_data_table_ in CSSFontFaceSource grow without bounds. Set a limit, and remove least recently used entries from the table. In my experiments this reduces the tab memory leakage for the URL from issue 778352 to a third and should help keep the tab running a lot longer. Bug: 778352 Change-Id: I9a812afdffb318be977def0b2c0301321603ab15 Reviewed-on: https://chromium-review.googlesource.com/824172 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#523793}
-
Koji Ishii authored
Following bot results are included. 2470 2471 2472 2473 2476 2477 2478 2481 2482 Deflake is not included until bots become more stable. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I09c19bf6da0c1b905a828af50c379d3a3d523c37 Reviewed-on: https://chromium-review.googlesource.com/824007 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#523792}
-
Theresa Wellington authored
When the flag is enabled, the pull-to-refresh in-product help bubble is shown at the top of the screen rather than anchored to the bottom toolbar. ArrowBubbleDrawable was modified to support not drawing an arrow. BUG=793403 Change-Id: I86d753a1eb7a193576f4523de6dd5f01a1a4c145 Reviewed-on: https://chromium-review.googlesource.com/817882 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Vincent Palatin authored
Define the bridge interface to connect the machine USB devices to the Android USB host API. Implement the API using /device/usb. The permission request for the USB devices is currently stubbed and fails closed. So until the Permission UI and settings are submitted, the API basically rejects all the requests. Bug: 24572867 Test: Manual, run with ARC++ app using android.hardware.usb to use USB devices. Change-Id: Ibce0a45e4359a97ee06d8d49981169bd5f18176f Reviewed-on: https://chromium-review.googlesource.com/731284Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Vincent Palatin <vpalatin@chromium.org> Cr-Commit-Position: refs/heads/master@{#523790}
-
sczs authored
Since loading pages hides ToolbarButtons, this CL makes sure hidden buttons are updated correctly after the expanding/contracting animations. Bug: 794246 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I633e18bd0899fd6d9586e4136719ea39279c35bc Reviewed-on: https://chromium-review.googlesource.com/823228Reviewed-by:
-
Fady Samuel authored
Input throttling with surface synchronization didn't always work well. Occasionally a huge number of input events from Ash would be processed between the time a resize request is first initiated and the time the surface synchronization event began. This caused a lot of unnecessary jank. Traces showed that the browser UI process was busy doing a lot of input processing work but the resize in the renderer consumed very little time so there was definitely an opportunity to improve input throttling. This CL takes a different (simpler/better) approach. As soon as a synchronization event is detected in DelegatedFrameHost (we know we will produce a UI CompositorFrame that will synchronize with the renderer), we throttle input events until a browser UI commit (OnChildResizing guarantees an upcoming commit). Bug: 672962 Change-Id: I75c8328bb846eff2817a805e63a6367ebb0714a2 Reviewed-on: https://chromium-review.googlesource.com/822658 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#523788}
-
Fredrik Söderquist authored
With 'textLength' and 'lengthAdjust' with the value 'spacingAndGlyphs', each SVGTextFragment is subject to an additional scale factor that stretches the glyphs along the x- or y-axis. This scale factor was not (any longer) taken into account by SVGInlineTextBox::OffsetForPositionInFragment, which resulted in the incorrect offset being calculcated. Apply the (inverse) length_adjust_scale from SVGTextFragment before querying the font for an offset. Remove the |include_partial_glyphs| argument from SVGInlineTextBox::OffsetForPositionInFragment since it's always true, and also use 'float' rather LayoutUnit for the position. Remove the dead |horizontal_glyph_stretch_| member variable from TextRun since it's no longer used (since the simple shaper path was removed.) Bug: 793075 Change-Id: Ia7d369d914f5afd87d198b7b21077e180fc8bc59 Reviewed-on: https://chromium-review.googlesource.com/824162 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#523787}
-
Mike Pinkerton authored
iossim no longer automatically launches the Simulator, that must be done manually. Also, macOS 10.12 is required for Xcode 9. TBR=rohitrao Bug: none. Change-Id: Icab37c48a6b79fbbe3e5a99b89a67058e215ca98 Reviewed-on: https://chromium-review.googlesource.com/824562 Commit-Queue: Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#523786}
-
Michael Wasserman authored
This reverts commit fe22ec61. Reason for revert: Revert didn't fix the issue; original CL was innocent. Original change's description: > Revert "mus: Support display mirroring for mus without viz" > > This reverts commit e5c68a86. > > Reason for revert: Suspected for breaking several tests in ash_unittests-mus on Linux Chromium OS ASan LSan > E.g. https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/25187/steps/ash_unittests-mus > > Original change's description: > > mus: Support display mirroring for mus without viz > > > > Append mirrors to the list of displays in DisplaySynchronizer. > > (creates normal ws::Displays for ash to handle mirror content) > > > > Add & call aura::WindowTreeHostObserver::OnAcceleratedWidgetOverridden. > > (lets MirrorWindowController handle mus's async initialization) > > > > Support WindowTree::ProcessSetDisplayRoot use with existing displays. > > Remove WindowManagerState::DeleteWindowManagerDisplayRoot NOTREACHED. > > (now hit when re-using a display and switching mirror->extended) > > > > Allow ash/window_manager.cc to include ash/host/ash_window_tree_host.h > > > > Bug: 770243 > > Change-Id: I21ada68097cff001bb98b9a8a22482d59d0ac1c8 > > Reviewed-on: https://chromium-review.googlesource.com/806238 > > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: kylechar <kylechar@chromium.org> > > Commit-Queue: Michael Wasserman <msw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#523618} > > TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org,kylechar@chromium.org > > Change-Id: I87b3b57193b38c955f3089f039a5c479c869c50c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 770243 > Reviewed-on: https://chromium-review.googlesource.com/824042 > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523730} TBR=sadrul@chromium.org,sky@chromium.org,msw@chromium.org,kylechar@chromium.org,cfroussios@chromium.org Change-Id: I66c2dbea1a2c5294f5210ad227cab87bf45f30ef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 770243 Reviewed-on: https://chromium-review.googlesource.com/824782Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#523785}
-
Daniel Bratell authored
Both gesture_detector.cc and scale_gesture_detector.cc have a local constant kSlopEpison with the same value. Since I could find no suitable shared place for it, I moved them into a tighter scope. That way they will not clash in jumbo builds where several cc files share the same translation unit. Bug: 773275 Change-Id: I22c6a452532fbe0b2be3fddb29388a2d65aa901a Reviewed-on: https://chromium-review.googlesource.com/824241Reviewed-by:
-
Chris Nardi authored
In CSS Color 4, HSL and HSLA were synonymized, along with allowing whitespace to separate the values instead of commas, introducing a backslash as a new way to separate the alpha parameter, allowing percent values for the alpha parameter, and allowing the hue to be specified as an angle. This updates our parsing behavior to reflect these changes, and enables now-passing WPT tests. This also updates our implementation of converting HSLA to RGBA, fixing a few bugs in the process. The new spec is at https://drafts.csswg.org/css-color/#the-hsl-notation. Bug: 786139 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I634b5323365cc19f64a4b1732bbaf33268cb3389 Reviewed-on: https://chromium-review.googlesource.com/812125Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Chris Nardi <hichris123@gmail.com> Cr-Commit-Position: refs/heads/master@{#523783}
-
Robert Sesek authored
Bug: 598854 Change-Id: I4a8aef73b405d4e4f1c557a9eaad2c3fb02c8f24 Reviewed-on: https://chromium-review.googlesource.com/823943Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523782}
-
Robert Ma authored
DirectoryOwnersExtractor.find_owners_file is made more generic to accommodate the new usage in ImportNotifier: * It does not skip "empty" OWNERS (those without emails) any more, which allows "# WPT-NOTIFY" to be added to OWNERS files with comments only (e.g. "# TEAM", "# COMPONENT" lines; there are a bunch in wpt). * It may now return LayoutTests/external/OWNERS. This is to make sure owners can always be found for WPT files so that ImportNotifier can generate and log bugs for all failures (but we will never turn on WPT-NOTIFY there). * It can now take four variants of paths: (absolute, relative) X (file, directory), to make it easier to use. Previous heuristics like skipping empty OWNERS are moved to list_owners instead, which is only used for generating a list of owners in commit messages and may eventually be removed. Also improve the setup of the unit test of this module. Bug: 765334 Change-Id: I01bd1fa85d2602299eaf1e0d8e0872b04b93a008 Reviewed-on: https://chromium-review.googlesource.com/822834 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#523781}
-
Wei-Yin Chen (陳威尹) authored
Diff since last roll: https://github.com/chromium/dom-distiller/compare/0bde3157d7...9596033e36 Picked up changes: 9596033 Skip elements with zero area when finding article element 38037b3 Update docs after GoB/gerrit migration Bug: 749769,791975 Change-Id: Id545cf658982204297fcbbcd0c8716fd4f272c28 Reviewed-on: https://chromium-review.googlesource.com/823287Reviewed-by:
-
Rob Percival authored
CHECK should not be used in tests. This test uses a net::MockCachingHostResolver, so the HostCache argument that was being checked should never be null. Change-Id: Ibaa7051c404037089fb010a0ed11ee8775c70277 Reviewed-on: https://chromium-review.googlesource.com/823962Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Rob Percival <robpercival@chromium.org> Cr-Commit-Position: refs/heads/master@{#523779}
-
rhalavati@google.com authored
Not required codes and comments related to sockets annotations are removed from several classes. The changes include: - Default network traffic annotation values are removed and test tags are added instead if required. - Code to store annotations in sockets is removed. - Comments regarding annotations storage is removed. Bug: 656607 Change-Id: I716dd482a6e868ba3b634437c434950db6073332 Reviewed-on: https://chromium-review.googlesource.com/823965 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523778}
-
