- 15 Dec, 2017 40 commits
-
-
Ryan Ki Sing Chung authored
ECDHE ciphers would be required since decrypt is not available. Bug: 794762 Change-Id: Ie855f1026460d1f2ffa62dcdec6870c5525cdd86 Reviewed-on: https://chromium-review.googlesource.com/826324 Commit-Queue: Ryan Chung <ryanchung@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#524480}
-
Matt Reynolds authored
BUG=760104 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I09ef256cc8fd72827800b68925c8d95dc8586324 Reviewed-on: https://chromium-review.googlesource.com/795359 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#524479}
-
Chris Hamilton authored
BUG=727353 Change-Id: I8402fcf4a28753ed75a9edabd7ee1478985312df Reviewed-on: https://chromium-review.googlesource.com/791570 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#524478}
-
Reilly Grant authored
These two session cookies-related tests are flaky when the Network Service is enabled. Bug: 795417 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Idf1195bf51f15851ada6349426af8939a720056a No-Presubmit: true No-Try: true Tbr: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/830969Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524477}
-
Dmitry Gozman authored
Blink can now do it directly, which unblocks moving DevToolsAgent to blink. Bug: 776009 Change-Id: I4b1466005b10dd9969040803a9517e6dff18dc38 Reviewed-on: https://chromium-review.googlesource.com/827551Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524476}
-
Robert Ma authored
This reverts commit 83f34380. Reason for revert: WOOHOO! It worked as intended :) Original change's description: > TEST: file a bug to staging right after wpt-import starts > > This is a live end-to-end test to ensure Monorail integration and > credential deployment work correctly on bots. This CL will be reverted > once a bug is successfully filed to monorail-staging.appspot.com. > > Bug: 765334, 794715 > Change-Id: I3b9d94116286e8d5c1daf24961af1de5d8b5e63e > Reviewed-on: https://chromium-review.googlesource.com/830193 > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Commit-Queue: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524470} TBR=qyearsley@chromium.org,robertma@chromium.org Change-Id: I19ffc37c8d71f31ec4e8ed56066b0d896b0bb301 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 765334, 794715 Reviewed-on: https://chromium-review.googlesource.com/831006Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#524475}
-
Tim Brown authored
Bug: 768027 Change-Id: Idf3e65c743e79b27e189a3ce4cb7f7e675a9fd03 Reviewed-on: https://chromium-review.googlesource.com/830812Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#524474}
-
rbpotter authored
Listen for destination events and update UI when destination changes. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1c9aff4f5e6fd1d856727064ab76058c30b12125 Reviewed-on: https://chromium-review.googlesource.com/823579 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#524473}
-
danakj authored
The SoftwareRenderer doesn't need to share those bitmaps out of process so it can just make regular SkBitmaps and use those, without depending on ResourceProvider, ResourceIds, SharedBitmapManager, etc to get that done. R=kylechar@chromium.org Bug: 730660, 738190 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie49389776441efe3faddb7ecf364126e5cc44170 Reviewed-on: https://chromium-review.googlesource.com/828081 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524472}
-
Jonathan authored
We want to make sure that --enable-viz does not break telemetry, so that we can properly collect metrics. This change adds both to the Linux Viz FYI bot. A few known failures are being skipped while we investigate them. TEST=telemetry_perf_unittests telemetry_unittests Bug: 778749 Change-Id: I4862bfd12ca255265d0e67406278cbd41202ac85 Reviewed-on: https://chromium-review.googlesource.com/827031Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#524471}
-
Robert Ma authored
This is a live end-to-end test to ensure Monorail integration and credential deployment work correctly on bots. This CL will be reverted once a bug is successfully filed to monorail-staging.appspot.com. Bug: 765334, 794715 Change-Id: I3b9d94116286e8d5c1daf24961af1de5d8b5e63e Reviewed-on: https://chromium-review.googlesource.com/830193Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#524470}
-
Eero Häkkinen authored
This CL is part of VectorMath code clean up series: [1/4] this CL [2/4] https://chromium-review.googlesource.com/c/824047 [3/4] https://chromium-review.googlesource.com/c/824048 [4/4] https://chromium-review.googlesource.com/c/824049 Bug: 778262 Change-Id: I8d1d5db93b20e2ba14781151efb0ba174c97687d Reviewed-on: https://chromium-review.googlesource.com/824046Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#524469}
-
Xiyuan Xia authored
- Remove code that shows connected Drive apps in launcher; - Update AppListSyncableService to remove sync data for those apps; Bug: 794724 Change-Id: I4e16df1d1e7dc216114174eae21cfac1b0eec189 Reviewed-on: https://chromium-review.googlesource.com/828026Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#524468}
-
David Benjamin authored
A recent BoringSSL change broke this. Add a regression test for it before I try to make the change again. Bug: 789802 Change-Id: Ibe021424fc6b36b2ef71d91b30f523a2cfae1482 Reviewed-on: https://chromium-review.googlesource.com/828381 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#524467}
-
Devlin Cronin authored
An event listener could destroy the context when it's notified (e.g., if it does window.close()). We need to account for this case. Check after each listener is executed whether the context is still valid. Add native bindings-specific unittests and a JS/Native bindings browsertest. Bug: 653596 Change-Id: I47e789800ca90935457781695d3e8c3de7aae317 Reviewed-on: https://chromium-review.googlesource.com/818528Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524466}
-
Kenneth Russell authored
Raymond is the primary OWNER of platform/audio and needs to be able to approve CLs which change the top-level BUILD.gn. BUG=778262 Change-Id: I9f3b7478e95b34187669371d894c863ff86936f2 Reviewed-on: https://chromium-review.googlesource.com/827609Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#524465}
-
Tim Brown authored
This is after having removed dconf and gconf. Bug: 768027 Change-Id: I8963b75da9b20688b698b658d7d5039fa59ac959 Reviewed-on: https://chromium-review.googlesource.com/827616Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#524464}
-
Victor Costan authored
This reduces the cognitive load of reasoning about IDBValue ownership, which makes it easier to add complexity to the IndexedDB value wrapping logic. Bug: 719007 Change-Id: I3afe209a4d1d58440fce424bd263e4888ebde503 Reviewed-on: https://chromium-review.googlesource.com/828531Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#524463}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/846f7660e7d5..f2d71764a1ec $ git log 846f7660e..f2d71764a --date=short --no-merges --format='%ad %ae %s' 2017-12-15 simonhatch Dashboard - Increase timeout to 15s for all requests to monorail. 2017-12-15 rnephew [Telemetry] Make it so story expectations do not require a reason. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5cc762556c6a00af530512a3133520bbbd9b905c Reviewed-on: https://chromium-review.googlesource.com/830175 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524462}
-
Jonathan Metzman authored
Bug: Change-Id: Ica0408b417f3ac56c1e90989a28d998735e7fc04 Reviewed-on: https://chromium-review.googlesource.com/830806Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#524461}
-
Dmitry Gozman authored
This is to test grounds with UI.Fragment and custom elements v1. Bug: none Change-Id: I62c3867ee8da84c867d432e49bd049757ea502fa Reviewed-on: https://chromium-review.googlesource.com/826306 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#524460}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/d92073b75627..667fa571db51 $ git log d92073b75..667fa571d --date=short --no-merges --format='%ad %ae %s' 2017-12-15 hnakashima Validate base color space of Indexed color spaces. 2017-12-15 hnakashima Validate shading pattern's ColorSpace. It cannot be a Pattern CS. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I85043b9fd2a697d9e39521560c165cdd1e510b2f Reviewed-on: https://chromium-review.googlesource.com/829987 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524459}
-
Xianzhu Wang authored
Extend PaintLayerPainter::AdjustForPaintOffsetTranslation() which adjusted paint_dirty_rect based on PaintOffsetTranslation to AdjustForPaintProperties() which (if needed) maps paint_dirty_rect from the root layer to the current layer dealing with more cases: - The existing PaintOffsetTranslation handling; - Fixed layer whose transform state may escape the root layer's transform state; - Scroll offsets. This fixes most of the failures of spv175+rls. Bug: 793675 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I400c9da7d215132247c1b4e631be692070fdb655 Reviewed-on: https://chromium-review.googlesource.com/827671 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524458}
-
Deepti Gandluri authored
When SetProtection is used for wasm memory, it can fail if not enough memory is available when growing. Fix to return the result of system calls. As coordination in needed between V8/Gin - this change adds a new SetProtection method with a boolean return, subsequent changes in V8/Chromium will swap this out to be the default SetProtection method. Bug: 775047 Change-Id: I9f55d156c8317be8c012de60940d1698db439c86 Reviewed-on: https://chromium-review.googlesource.com/753429Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#524457}
-
Brett Wilson authored
Transitions another set of callers to use the new unique_ptr version of SetLayoutManager. The only nontrivial changes are in tri_view.cc where the existing initialization did not with well with the new pattern. The constants in PasswordGenerationPopupController were given storage because not having storage was causing errors passing through std::make_unique which passes by &&. Change-Id: Id51f1a888b7148169629aabae523530fb03b3890 Reviewed-on: https://chromium-review.googlesource.com/827668 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#524456}
-
Aleks Totic authored
NGOutOfFlowLayoutPart used to have a single containing block, and it was defined by a NGOOFLP member variables. With inline containing blocks, we have multiple containing blocks, defined by ContainingBlockInfo. This CL moves definition of default containing block out of multiple member variables into single ContainingBlockInfo. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I69dd499cb69c7e6fc56971e85882cd7e6241f99c Reviewed-on: https://chromium-review.googlesource.com/829888Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#524455}
-
rnephew authored
Bug: 781409 Change-Id: I70d28e9f43a4747f19666fbfa9f3bb18ac1d22d7 Reviewed-on: https://chromium-review.googlesource.com/830256Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#524454}
-
Jonathan Metzman authored
https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/a00e8070bea6..ba2c1cd6f87a $ git log a00e8070b..ba2c1cd6f --date=short --no-merges --format='%ad %ae %s' 2017-12-13 morehouse [libFuzzer] Add dummy call of LLVMFuzzerTestOneInput to afl_driver. 2017-12-12 kcc [libFuzzer] change the strategy for -experimental_len_control to grow max_len slower 2017-12-09 kcc [libFuzzer] even less aggressive step function for stack depth. Also don't use asan in one test to speed it up 2017-12-09 kcc [libFuzzer] make the stack depth signal less agressive, otherwise we are sometimes exploding the corpus size. This still needs more analysis and tuning 2017-12-08 morehouse [libFuzzer] Add support for Fuchsia OS. 2017-12-08 kcc [libFuzzer] honor -use_counters, sligntly change the meaning of -experimental_len_control, call UpdateFeatureFrequency only if instructed by the flag 2017-12-06 kcc [libFuzzer] Decrease stack usage in unit tests 2017-12-06 kcc [libFuzzer] fix a minor regression in printing 2017-12-05 morehouse [libFuzzer] Make redirects happen in proper sequence. 2017-12-04 morehouse [libFuzzer] Remove const from ignoreRemainingArgs return value. 2017-12-04 morehouse [libFuzzer] Remove FuzzerCommand.cpp from build sources. 2017-12-04 morehouse [libFuzzer] Encapsulate commands in a class. 2017-12-01 kcc [libFuzzer] add a flag -malloc_limit_mb 2017-12-01 kcc [libFuzzer] remove stale flags; NFC 2017-12-01 kcc [libFuzzer] add an experimental search heuristic flag -reduce_depth 2017-11-28 delcypher [LibFuzzer] Improve comments on `CounterToFeature()` function. 2017-11-17 vitalybuka [fuzzer] Initialize PcDescr buffer before calling __sanitizer_symbolize_pc 2017-11-15 kcc libfuzzer: Fix file listing on some filesystems 2017-11-15 kcc [libFuzzer] respect max_len during merge Created with: roll-dep src/third_party/libFuzzer/src Bug: 539572 Change-Id: I8dd43d49dea0441595e9e04f1ddb61950333f896 Reviewed-on: https://chromium-review.googlesource.com/828408 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#524453}
-
Donn Denman authored
Fixes a problem with ML not being applied correctly on a "retap", a tap near the previous selection. The problem is that the Search is still in progress and the Bar still active when the retap is processed. Adds a new Internal State TAP_GESTURE_COMMIT that allows code to run during the initial stage of tap gesture processing. This new state is used to handle the retap by detecting if the panel is still open. Loading the Ranker predictor is now moved to an earlier stage of tap processing (using the new internal state) to allow it to be fully loaded and ready to predict by the time all the prediction features have been gathered. Refactored writing the outcomes to Ranker in ContextualSearchPanelMetrics so it can be called when appropriate. Now logging outcomes and resetting the CSRankerLogger is done whenever the UI is hidden or a retap is detected. BUG=783995 Change-Id: I3122a20200696682205379fdd619e655262520f9 Reviewed-on: https://chromium-review.googlesource.com/802540 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#524452}
-
Kenneth Russell authored
It's seen to time out on the linux-chromeos-rel tryserver which is affecting the CQ. Until someone is found to investigate the timeouts, turn off the test. BUG=794490 TBR=lazyboy@chromium.org Change-Id: Idbf5f975df1e9b9e49f10c68bef0112e7545b541 Reviewed-on: https://chromium-review.googlesource.com/829892Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524451}
-
proberge authored
The sw_reporter_installer was getting too large and confusing. SwReporterInstallerPolicy is not an appropriate class to hold information about user-initiated cleanups. This CL is preliminary work for a redesigned version of https://chromium-review.googlesource.com/c/chromium/src/+/810086 Bug: 776538 Change-Id: I3833a06aec23fc83eba05ed2a36e014875730d3b Reviewed-on: https://chromium-review.googlesource.com/817620Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#524450}
-
Frank Henigman authored
Add 'target_defaults' to the list of top level keys ignored by gypi_to_gn.py so it can process files that contain that. BUG=795329 Change-Id: I3733a7efb97366827febf87ec1be95ad8723be23 Reviewed-on: https://chromium-review.googlesource.com/830114Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524449}
-
Matt Menke authored
When a Read() call finished asynchronously, it was clearing its buf_ pointer after calling into its consumer. If its consumer called Read() again, that could have resulted in populating buf_ again, which would then incorrectly be cleared by the higher level call. Also, if Init() interrupted a previous call to Init(), the callback to the first Init() call was not being cancelled. Bug: 794330 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I71faee5bcde302acd1962e55b4f2bb75d8c31c8d Reviewed-on: https://chromium-review.googlesource.com/825843 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#524448}
-
Scott Violet authored
It's used for poking at InputDeviceClient. As Chrome/Ash use DeviceDataManager in classic mode InputDeviceClientTestApi handles both. That is, if DeviceDataManager exists it pokes at it, otherwise InputDeviceClient. BUG=776514 TEST=test only changes Change-Id: I4e46dbe74dbce4a37d2b4e054b8fec88d4b5a048 Reviewed-on: https://chromium-review.googlesource.com/829713Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#524447}
-
Steven Holte authored
Change-Id: Ida79579f16af6c2d0dcd97a7d972b2444f2280c3 Reviewed-on: https://chromium-review.googlesource.com/827541Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#524446}
-
Wei-Yin Chen (陳威尹) authored
Record partner bookmark count as zero when skipped, so that the distribution is not skewed. Bug: 787132 Change-Id: Ie5c0c49120ff47a0fce984de823928997a1652f8 Reviewed-on: https://chromium-review.googlesource.com/826465Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#524445}
-
Kurt Horimoto authored
This previously existed, but was mistakenly removed in crrev.com/c/648076. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I09759933d8717d55de1343852827ab3289a4bee0 Reviewed-on: https://chromium-review.googlesource.com/830136 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#524444}
-
Reilly Grant authored
Because Blink depends on the WebUSB interfaces directly they shouldn't be part of chrome_content_browser_manifest_overlay.json and should instead be part of content_browser_manifest.json. Since these are still implemented by Chrome and not //content the factory methods are moved into ContentBrowserClient. Change-Id: Ic34008eccca45dd24bace5afee8fff478bb9ba6d Reviewed-on: https://chromium-review.googlesource.com/828025Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524443}
-
Devlin Cronin authored
Remove an unused (and deprecated) overload of ExtensionTabUtil::GetBrowserFromWindowID. Bug: None Change-Id: Ia5580dc63e39d0b9c01784abf69ef31383ff79ce Reviewed-on: https://chromium-review.googlesource.com/829693Reviewed-by:
catmullings <catmullings@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524442}
-
Ryan Sturm authored
(a) device info should be in the batch summary of the request for PLM (b) I'd like separate Device Info messages in case they diverge, which seems like a distinct possibility. Patchset 1 is what landed yesterday. This is a reland of 1e920b32 Original change's description: > Adding device memory in kb to the client config request > > pingback will also have this information > > Bug: 793373 > Change-Id: I0c999c35b5e968f6b2e19696a08a722b3399d0d9 > Reviewed-on: https://chromium-review.googlesource.com/823176 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524203} Bug: 793373 Change-Id: I4d3f6854b3b28c5c412388e27b0851e767e5f8b4 Reviewed-on: https://chromium-review.googlesource.com/830133Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#524441}
-