- 24 Jun, 2020 40 commits
-
-
Koji Ishii authored
This patch changes the status of |LayoutNGFragmentItem| to |test|. Bug: 982194 Change-Id: Ie98a1c454a0a6e423a6ff19c17a783434f9c55f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782019Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#781975}
-
Wez authored
Bug: 1095791, b/152620196 Change-Id: I2f8fc8151d20c1962d311806fb48a87e7dbd144c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252047 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#781974}
-
Chris Cunningham authored
Failure already expected, but timeouts are still causing bot failures. See bug for logs. TBR=pdr@chromium.org Bug: 898394 Change-Id: If32382ef010ecc46be6539a03a082d18e0a4d61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264873Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#781973}
-
Abhijeet Singh authored
Allow the Quick-Answers UserConsentView to obtain keyboard-focus to pass on to the settings, acknowledgement and dogfood buttons, using arrow-keys. Bug: b:152057976 Test: Tested on Chrome OS VM. Change-Id: I01a4f6bd3da09e811398fe224b82e0c01f5add0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247156 Commit-Queue: Abhijeet Singh <siabhijeet@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#781972}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dc3f366469ed..f9898ac95a9b 2020-06-24 skyostil@chromium.org telemetry: Disable flaky test: ActionRunnerMeasureMemoryTest.testDeterministicMode If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1098669 Tbr: oysteine@google.com Change-Id: I6af13afd5a87ec74cffb7253828a3556019bc364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264833Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781971}
-
Hans Wennborg authored
The CHECK, CHECK_EQ etc., and NOTREACHED macros have moved out of logging.h into separate, much cheaper to include, headers. Now that the code has been updated to use the new headers, and to not rergess on that, stop including them in logging.h. Bug: 1031540 Change-Id: Idfa891b991cbca1dfef93630c0f37b1b022f99df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264413Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#781970}
-
Jason Chase authored
Add support for third-party origin trials, by recording the origin of external scripts that are injecting tokens by adding a meta tag. The origin of the external script, is extracted from the current V8 context, if available. This external origin is then used to validate a provided third-party token. The logic for "is external origin secure" is also moved to the central location where the decision is applied, to ensure it would be applied consistently in all code paths. Support for dedicated workers will be addressed later in crbug.com/1083407. See the design doc for details: https://docs.google.com/document/d/1xALH9W7rWmX0FpjudhDeS2TNTEOXuPn4Tlc9VmuPdHA/edit#heading=h.uat230y0rscf Bug: 1073920 Change-Id: I724f740f3e077dca28f870e069415ed6aa3a33b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173473Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#781969}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e16b0f211117..b67fc374022a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ellyjones@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ellyjones@google.com Change-Id: I2ea1eaaf94d5c67e9c76a9a306cb8277ffcada57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264386Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#781968}
-
Ben Pastene authored
This tests it out on a single test suite. If it looks good, it'll be rolled out more broadly. This will let us tear-down all the out-of-band flashing logic for these devices, and replace it with on-demand pre-test flashing. The latter being much simpler to maintain, having less moving parts, and generally being more visible. Bug: 1057152 Change-Id: Ic2fba3725b01bec2d3dedc4898e8acfe3ad5b22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261702Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#781967}
-
Dominic Farolino authored
This CL adds both image and iframe (tentative) WPTs that assert going from loading=lazy => {loading=eager, unset loading} eagerly loads the resource. R=sclittle@chromium.org Bug: 1098062 Change-Id: I782bd4b85a6ac098a49b16bfe203735bcc5b4d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258639Reviewed-by:Scott Little <sclittle@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#781966}
-
David Bertoni authored
These tests were disabled on MSAN bots do to infrastructure problems. The underlying issue was fixed and these tests passed on the bots. Bug: 508949 Change-Id: Ib135aa3d82b5d4d4170d8022d4efaba94cb6ab62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258417Reviewed-by:
Archana Simha <archanasimha@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#781965}
-
Miguel Casas authored
VideoDecoderPipeline holds together a (Vaapi|V4L2)VideoDecoder, a frame pool and a converter. It gets a series of VideoDecoder create functions from ChromeosVideoDecoderFactory, and needs to go through each decoder, trying to create and then Initialize() each -- the first one that works is good to go. VideoDecoderPipeline retrieves such create functions and holds on to the last |used_create_vd_func_| along such Create+Initialize cycles (to avoid repeating a potentially broken one) and relies on the factory's GetCreateDecoderFunctions() to return all such functions /except/ the one passed as argument. This logic, aside from convoluted, is broken if there were more than 2 such create functions. This CL simplifies all that by keeping a list of |remaining_create_decoder_functions_| that are tried and, if failed, discarded. During the moves along the different initialization methods (see [1]), a given Status is constructed and filled to indicate a potential failure. Status [2] works in a non-intuitive way because it must be constructed with a given StatusCode, which becomes its code(), but can AddCause() to it -more StatusCodes- that are sadly, opaque. ToT uses a kChromeOSVideoDecoderNoDecoders as start StatusCode, so any subsequent errors e.g. kDecoderFailedCreation or kDecoderFailedInitialization are thrown into the opaque causes. This CL changes this to start with a kOk, and then collect the first meaningful error StatusCode. Unittests added to hopefully clarify and identify the use cases. [1] https://i.imgur.com/qH17CTJ.jpg (or https://imgur.com/a/anCJ2Ig) [2] https://source.chromium.org/chromium/chromium/src/+/master:media/base/status.h;l=41 Bug: 1040291 Change-Id: I35889605850eb51e0dfe9308688c092d2b755edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259472 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#781964}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/92cf2828f7e4..2f852116281b 2020-06-24 aerotwist@chromium.org [Perfmon] Improve contrast of labels in dark theme 2020-06-24 sigurds@chromium.org Fix stylelint-config-standard issues in elements/elementsPanel.css 2020-06-24 petermarshall@chromium.org Fix stylelint-config-standard issues in profiler/profilesSidebarTree.css 2020-06-24 sigurds@chromium.org Fix stylelint-config-standard issues in coverage/coverageListView.css 2020-06-24 sigurds@chromium.org Fix stylelint-config-standard issues in issues/issuesTree.css If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142,chromium:1098637 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie102b5c7198900d619ec977ed5421d348f711cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264387Reviewed-by:
-
Luke Zielinski authored
TBR=robertma@chromium.org Bug: 1098844 Change-Id: I5563f96d8b1f116063f16fcc41df48be180da5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264575Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#781962}
-
Chris Cunningham authored
TBR=yiyix@chromium.org Bug: 1098369 Change-Id: Ia470e911dacc58af8e5d0fbfcba8754d1b3228f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264809Reviewed-by:
-
Patrick Noland authored
The size of mMenuImageButton isn't guaranteed to be set when we first call updateImageResources, e.g. when changing the theme on Android P. This change updates the drawables and their bounds after MenuButton is laid out. This also fixes an issue where the tab switcher animation Drawable shares ConstantState with the corresponding ImageView. Bug: 1096375,1096991 Change-Id: Ib366d30b12732b5a86d850fa19514b294c23d9d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252029 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#781960}
-
Titouan Rigoudy authored
This feature is superseded by network::features::kBlockNonSecureExternalRequests. Bug: 986744 Change-Id: I38c5cb79835d4e677cf5fe8abf442a7c071340cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264712 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#781959}
-
Elly Fong-Jones authored
This test flakily times out on Mac debug - even successful runs regularly take 30-40 seconds. Bug: 900447 Change-Id: I9d8710c5329ad4de30ff1d9913288b2b034acd7d Tbr: kelvinjiang@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264912Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#781958}
-
Bo Liu authored
Fixed: 1095167 Change-Id: Iecf5169325baf9d4cff9bc990a0a005f07c066da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261265 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#781957}
-
zhaoyangli authored
Added the fyi builder with configs and tests as requested in bug. Bug: 1097339 Change-Id: I0fb25cccf2bc1dd1d746563836293fc1190a1c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262273Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#781956}
-
Leonard Grey authored
Previously, we were using chrome::CanEmailPageLocation to check if share should be enabled, which checked against the current URL, but user the last committed URL to actually perform the share. I'm honestly not sure if the non-Mac email behavior is correct and would like to side-step that for a moment. On the Mac, we really want the committed URL since we pass along a screenshot to the share service. This changes adapts the logic of CanEmailPageLocation to the committed URL and inlines it in the share menu controller. Bug: 1095807 Change-Id: Icad4f3766335d0156edf6d1078ea06b328cfed06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261613Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#781955}
-
Bo Liu authored
Bug: 1076473 Change-Id: I2c5de6c967dca2b2efe536c04d383e1d51c05ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264256 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#781954}
-
Sky Malice authored
This allows multiple different conditions to be 'or'ed together. This will allow tests to be disabled when one of several conditions are met. Change-Id: I3018d28a7700f94651b74af7dd8de6febbc7aa39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255380 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#781953}
-
Alexander Surkov authored
Bug: 1095619 Change-Id: Iff442fa0efdb30288648349c6bcfccb33dee3a7f AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260393Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#781952}
-
Scott Violet authored
As part of making GestureStateListener.onScrollOffsetOrExtentChange work again ( https://chromium-review.googlesource.com/c/chromium/src/+/2222623 ) I made it so that the browser gets any change in RenderFrameMetaData when an infobar is present and the root-scroll-offset changes. Unfortunately this regressed some perf tests. The test are triggering an infobar to show, and then scrolling through the whole page without dismissing. Uma stats indicate this isn't that uncommon, so it seems worth fixing. This patch creates a one off message (OnRootScrollOffsetChanged) that is sent if root scrolls have been requested and the frame would not normally be sent to the client. https://pinpoint-dot-chromeperf.appspot.com/job/139b3471120000 is a pinpoint run that shows this gives back some portion of the loss. In order to get back all the performance, a more complex patch is likely needed. Given branch is Thursday, I'm landing this patch now to give back some of the performance. BUG=1091451 Change-Id: I54cc55a6dab1dc716978eb7d25cb932bfb662ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257407Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
-
Reilly Grant authored
This change cleans up instances where the original browser context, returned by Profile::GetOriginalProfile(), was referred to instead as the "master" context. This term is uninclusive and doesn't match the name used elsewhere. Bug: 1097189 Change-Id: Ie051677987f7d6decf6c7d25a2a5d191ee270e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261700 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#781950}
-
Sadrul Habib Chowdhury authored
In the FrameSequenceTracker trace events, include stats only from the 'effective thread' (i.e. the thread driving the effect), instead of including both main and compositor-threads. BUG=1095186 Change-Id: I60666ce16a288a9d4a7fcd9cc27418fd4807b6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261398 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#781949}
-
Meilin Wang authored
Bug: b/158630837 Test: manually. Change-Id: I1a5158d54c8c4bd941c37d036c5be535175e9aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261370Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#781948}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592999982-7acc1dacb3c35b59c797d873c3b61ca4b0010cd2.profdata to chrome-win64-master-1593007185-9f44ccb8893f05162537134149388feea4a6ce51.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I73cbc2c98d6b5cdb23e92205c21473becb8626e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264388Reviewed-by:
-
Xiaohui Chen authored
Bug: 1098387 Change-Id: I7bf459692cf7746bea954264cd749ffb5f32d047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261095Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#781946}
-
Evan Stade authored
Bug: 1066263 Change-Id: I4548f13ad9e34b0b64c8d09e006c2cfa0dca365e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260877 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Gabriel Charette authored
This is equivalent to the ThreadPoolInstance configuration that the GPU process was implicitly getting from ChildProcess::ChildProcess (constructed from GPUProcess::GPUProcess). Modulo the added ability to explicitly name this ThreadPool and have independent metrics :). The ThreadPoolInstance is still started at virtually the same order as before so semantics should be equivalent for the GPU process. This is necessary otherwise etienneb's fix for crbug.com/1091259 is a no-op in production due to the early-bail if there's no ThreadPoolInstance on init (added for tests, breaks prod). R=chromium-metrics-reviews@google.com, sunnyps@chromium.org Bug: 1091259 Change-Id: I3ce25ac70bb4d1980e3d38ae6f90851041632bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255655 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#781944}
-
Ken Rockot authored
This is a reland of 6eda333b The test-only bug which elicited the revert has been fixed, so this is relanding the original CL unmodified. Original change's description: > Add MojoDedicatedThread field trial testing config > > Bug: 1082761 > Change-Id: Ief2b018876f8cb2ad77495c7158db5c53fd8c206 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240407 > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#777367} Bug: 1082761 Tbr: asvitkine@chromium.org Change-Id: Icefe444d49199e402a772775f687374b7c14b1c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264732 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#781943}
-
Hitoshi Yoshida authored
This CL changes to use forward declarations of other IDL dictionary types in header files of IDL dictionaries. This change is to clear circular inclusions between dictionaries. Bug: 839389, 1060478 Change-Id: Idcc18de01999aae18f5204669b6950cbdf825fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248390 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#781942}
-
Patrick Noland authored
Bug:1098806 Tbr: dominickn@chromium.org Change-Id: I85a5d9fe282450d466c8942adfbee70d03347f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264617Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#781941}
-
Martin Kreichgauer authored
This reverts commit a361d30d. Reason for revert: Fixed test failure from crbug.com/1097635 Original change's description: > Revert "bluetooth/winrt: Observe discovery failures" > > This reverts commit e44abb7d. > > Reason for revert: Fails on Win DBG builder. > > Original change's description: > > bluetooth/winrt: Observe discovery failures > > > > Change BluetoothAdapterWinrt to subscribe to > > BluetoothLEAdvertisementWatcher::Stopped events. The event fires if > > scanning for LE advertisements has been cancelled by the application or > > due to an error. Once the event is received, mark all active > > BluetoothDiscoverySession instances inactive, which will cause > > BluetoothAdapter::IsDiscovering() to return false. > > > > Also make BluetoothAdapterWinrt call Observer::DiscoveringChanged(). > > > > Change-Id: If4abf65f09b4d20b89b53adb63dad89939ddcceb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255549 > > Commit-Queue: Martin Kreichgauer <martinkr@google.com> > > Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#780539} > > TBR=reillyg@chromium.org,martinkr@chromium.org > BUG: 1097635 > # Not skipping CQ checks because original CL landed > 1 day ago. > > Change-Id: I5b2e012bee60c94d735f95aa49cf90db2adff016 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255946 > Reviewed-by: Fergal Daly <fergal@chromium.org> > Commit-Queue: Fergal Daly <fergal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780660} TBR=reillyg@chromium.org,martinkr@google.com,fergal@chromium.org,martinkr@chromium.org # Not skipping CQ checks because this is a reland. Change-Id: Ia924fe22558e323d4b56813ec8018de228e5a36d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257564Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#781940}
-
Chris Cunningham authored
Test is flaky. TBR=oshima@chromium.org Bug: 1098810 Change-Id: I6cc56badc887f0f7743492b92d0ec705e52fa3b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264796Reviewed-by:
-
Anupam Snigdha authored
This patch fixes an issue where VK show/hide APIs were not able to execute when an EditContext was active as the manual policy was only evaluated for editable elements and not for EditContext. Bug: 856269 Change-Id: Id5d6614252675e360baaeb9c76e7c6ed68795aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261953 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#781938}
-
Samuel Huang authored
|container| should be |self.container|. This causes Diff() to fail in SuperSize-console. TBR=agrieve@chromium.org Bug: 1040645 Change-Id: Ie82e63f6449b905e628ebf884fd157c603dc6bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264753Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#781937}
-
Li Lin authored
Bug: 1098472 Test: manual test Change-Id: Iffdfc41e4b408fc2c99112e3b27f20e196ade911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261879Reviewed-by:
-
