GitLab

BUG=410082

Review URL: https://codereview.chromium.org/535343003

Cr-Commit-Position: refs/heads/master@{#295624}

And also add error validation to the tabs.query method (while we're at it).

BUG=128924
TEST=ExtensionApiTest.TabQuery

Review URL: https://codereview.chromium.org/569803004

Cr-Commit-Position: refs/heads/master@{#295623}

The following supressions are no longer needed:
bug_101125a
bug_101125b
bug_101125c
bug_101145b
bug_101145c
bug_101145d
bug_101146d

BUG=101125,101145,101146
R=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/578773002

Cr-Commit-Position: refs/heads/master@{#295622}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2dc4bc6..34469ea

TBR=dpranke@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/584703002

Cr-Commit-Position: refs/heads/master@{#295621}

BUG=414880
R=brettw

Review URL: https://codereview.chromium.org/576293003

Cr-Commit-Position: refs/heads/master@{#295620}

The following supressions are no longer needed:
bug_102257
bug_102327b
bug_102327c
bug_102614
bug_104578
bug_105715

BUG=102257,102327,102614,104578,105715
R=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/552343004

Cr-Commit-Position: refs/heads/master@{#295619}

This is done in a comparable way to NativeViewHostAura, but using a
ReparentNSView helper function which reparents an NSView to a
NativeWidgetMac's BridgedContentView (or to `nil`).

Earlier attempts tried to use NativeWidgetPrivate::ReparentNativeView()
which turns out to be a bad idea, since it's really designed to reparent
windows (aura::Windows or HWNDs). Mac's child window support is
insufficient for what toolkit-views expects, and WebContents on Mac are
managed by an NSView in any case, not an NSWindow.

Along with logic currently in render_widget_host_view_mac.mm and
web_contents_view_mac.mm, reparenting renderer views needs to be done in
the native view hierarchy, not the window hierarchy.

This CL no longer tries to enable the current
native_view_host_unittest.cc (tests there assume ReparentNativeView is
used), but adds native_view_host_mac_unittest.mm to give test coverage,
and to inspect properties at the Cocoa layer. Common parts of the 3
_unittest.* files are refactored into a NativeViewHostTestBase class.

Some other views_unittests are also made passing by implementing a
NativeViewHost::CreateWrapper that doesn't just return NULL:
4xFocusTraverslTest and NativeWidgetTest.GetTopLevelNativeWidget2

Before: 455 tests run 22 tests failed 21 tests crashed. After: 458 tests
run 22 tests failed 16 tests crashed.

BUG=378134, 415024

Review URL: https://codereview.chromium.org/530933002

Cr-Commit-Position: refs/heads/master@{#295618}

BUG=415745
R=oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/583503003

Cr-Commit-Position: refs/heads/master@{#295617}

- record the original state when the gesture starts
- changes the height condition for the closest state based on the
  original state
- limit the fling handling only when the closest state ends up with
  the original state. This will save the most of the case, however
  it may cause unexpected results if the user makes complicated
  gestures (like moves up from minimized, up to the full-screen,
  then fling-down). I think this is a rare case and we don't
  have to care about.

BUG=415211
R=pkotwicz@chromium.org
TEST=athena_unittests && manually

Review URL: https://codereview.chromium.org/581933004

Cr-Commit-Position: refs/heads/master@{#295616}

R=agable@chromium.org
BUG=414994

Review URL: https://codereview.chromium.org/582003003

Cr-Commit-Position: refs/heads/master@{#295615}

BUG=415241

Review URL: https://codereview.chromium.org/579863004

Cr-Commit-Position: refs/heads/master@{#295614}

BUG=413294

Review URL: https://codereview.chromium.org/574283002

Cr-Commit-Position: refs/heads/master@{#295613}

BUG=406410
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/585633002

Cr-Commit-Position: refs/heads/master@{#295612}

This reverts commit f1624ddc.

Broke Google Chrome ChromeOS compile:

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/72048/steps/compile/logs/stdio

In file included from gen/extensions/browser/api/generated_api_registration.cc:20:
In file included from ../../extensions/browser/api/cast_channel/cast_channel_api.h:16:
../../extensions/browser/api/cast_channel/cast_socket.h:19:10: fatal error: 'extensions/browser/api/cast_channel/logging.pb.h' file not found
         ^

(Manually reverted because of file add.)

TBR=kmarshall@chromium.org
BUG=

Review URL: https://codereview.chromium.org/588433002

Cr-Commit-Position: refs/heads/master@{#295611}

- Fetch crypthome keys when EasyUnlockServiceSignIn is assocated with a user;
- Translate and provide remote devices and challenge from key data;

BUG=401636

Review URL: https://codereview.chromium.org/576383002

Cr-Commit-Position: refs/heads/master@{#295610}

Trying to use ar to put a static lib inside a complete static lib doesn't
work. GN should enforce and document this restriction.

BUG=None
TEST=gn_unittests, including new test for this case.
R=brettw

Review URL: https://codereview.chromium.org/582863002

Cr-Commit-Position: refs/heads/master@{#295609}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/23e280d..b14e4a0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/586453004

Cr-Commit-Position: refs/heads/master@{#295608}

The two directories depend on each other, so there isn't much point in
having separate BUILD.gn files.

BUG=408651
TEST=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/577383002

Cr-Commit-Position: refs/heads/master@{#295607}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l

Review URL: https://codereview.chromium.org/570503002

Cr-Commit-Position: refs/heads/master@{#295606}

They don't need to run in Chrome's unit_tests suite any more.

* Move ExtensionL10UtilTest
* Move FileUtilTest
* Keep browser action and page action tests in Chrome, since those are
  Chrome-specific concepts

This CL depends on https://codereview.chromium.org/565423003/ for cleanup
of _manifest_features.json

BUG=397165
TEST=extensions_unittests, unit_tests

Review URL: https://codereview.chromium.org/562273006

Cr-Commit-Position: refs/heads/master@{#295605}

View invalidations outside of animation can stall the Chrome message
loop. Avoid such stalls during page load by synchronizing all
ChromeShell progress drawable updates with View animation.

BUG=414674

Review URL: https://codereview.chromium.org/583673002

Cr-Commit-Position: refs/heads/master@{#295604}

BUG=415433

Review URL: https://codereview.chromium.org/583573004

Cr-Commit-Position: refs/heads/master@{#295603}

Delete redundant non-proto ReadState/WriteState/ConnectState enums.
Add cast protogen rule to extension registration deps.

BUG=

Review URL: https://codereview.chromium.org/576483003

Cr-Commit-Position: refs/heads/master@{#295602}

InitializeSession. This seems to be able to happen if too much time
elapses between the call to the constructor and the call to InitializeSession.

This fixes the fix from https://codereview.chromium.org/560913002

BUG=399147

Review URL: https://codereview.chromium.org/579533003

Cr-Commit-Position: refs/heads/master@{#295601}

These files were being removed twice from the sources.

TBR=viettrungluu

Review URL: https://codereview.chromium.org/568153006

Cr-Commit-Position: refs/heads/master@{#295600}

Currently, when distillation fails, the TaskTracker signals that a
source has finished. It then checks if all sources are done (and if not,
it will wait to call the callback). The check for sources done though
assumes that if distiller_ is non-null, then distillation is still in
progress. So, we should be deleting/releasing distiller_ when it
finished (and before signalling that the source is finished).

This also updates the standalone content extractor to fail if extraction
of some url fails.

Review URL: https://codereview.chromium.org/575883002

Cr-Commit-Position: refs/heads/master@{#295599}

This CL was reverted due to test failures. Under inspection, the test proved to
already be flaky. The test has been disabled. See http://crbug.com/415422 for
more details.

--------------Original CL Description-----------------

The menu item "Enter Presentation Mode" has different effects in 10.6 and
10.7+. In 10.6, the menu item invokes Immersive Fullscreen. In 10.7+, the menu
item invokes AppKit Fullscreen. Similar logic applies to fullscreen invoked by
an extension.

I accidentally changed this logic during the fullscreen refactor by removing
the 10.6 vs 10.7+ conditional. This CL adds back the conditional. I also
updated the code to explicitly indicate the mechanism that is invoking
fullscreen to prevent similar future mistakes.

Original CL: https://codereview.chromium.org/575653003/

BUG=NONE
TBR=rsesek@chromium.org

Review URL: https://codereview.chromium.org/576393002

Cr-Commit-Position: refs/heads/master@{#295598}

This patch moves OcclusionTracker::UnoccludedContentRect to Occlusion.
This reduces OcclusionTracker API and makes it consistent with
IsOccluded call.

Follow-up work here will remove occlusion_tracker from these functions
where possible and replace it with const Occlusion& occlusion.

R=danakj
BUG=410932

Review URL: https://codereview.chromium.org/576173003

Cr-Commit-Position: refs/heads/master@{#295597}

Layout test do not use compositor thread, so WebMediaPlayerAndroid ends
up using a null message loop.

BUG=412578

Review URL: https://codereview.chromium.org/586493002

Cr-Commit-Position: refs/heads/master@{#295596}

java_cpp_enum.gypi was creating all enums in the same root folder and
then adding that folder to its dependents generated_src_dirs. This has
two issues: first, incremental builds will include stale files when
things are moved/renamed/etc. second, all libraries that depend on such
an enum target will actually compile and include all the enum targets
(and in fact may even include different versions of one enum in
 different libraries).

This change just makes each such target use its own unique directory
(this will still have the stale enum issue when renaming an enum if the
 target name doesn't change, but that is very rare).

The GN version already used unique directories.

TBR=mkosiba

Review URL: https://codereview.chromium.org/578363002

Cr-Commit-Position: refs/heads/master@{#295595}

Apparently (?) unnecessary, and it sometimes hangs in that call.

This doesn't seem to help the 16s timeout (per tryjobs here), but
doesn't seem to hurt either, and I can run on a local VM this way
at least.

BUG=411147

Review URL: https://codereview.chromium.org/583443005

Cr-Commit-Position: refs/heads/master@{#295594}

StartupTimeBomb in 10 minutes.

Give more time for startup tasks to finish.

R=sky@chromium.org
BUG=396356

Review URL: https://codereview.chromium.org/581163003

Cr-Commit-Position: refs/heads/master@{#295593}

Revert of GCM: D-Bus methods for wake-on-packet (patchset #15 id:280001 of https://codereview.chromium.org/409883006/)

Reason for revert:
See issue https://code.google.com/p/chromium/issues/detail?id=415281

I bissected chrome to this patch and figured that this is causing chrome to crash.

Sorry.

Original issue's description:
> GCM: D-Bus methods for wake-on-packet
>
> Program the NIC to wake-on-packet for packets arriving from
> the GCM server.  Chrome notifies the connection manager (shill)
> by calling D-Bus methods.  The return status indicates if the
> operation succeeded or not (depending on hardware support and
> the type of connection).
>
> Keywords: wowlan, wake-on-lan, wake-on-wlan
>
> BUG=360295
> TEST=verified dbus methods are called, and packets are sent on the
> TEST=connection passed to the methods.  Also verified that shill
> TEST=programs the NIC correctly, and packets wake up the device.
>
> Committed: https://crrev.com/88a95a70fa94bb578b371490d0f9868584b7096e
> Cr-Commit-Position: refs/heads/master@{#294936}

TBR=derat@chromium.org,fgorski@chromium.org,stevenjb@chromium.org,zea@chromium.org,scheib@chromium.org,yoz@chromium.org,semenzato@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=360295

Review URL: https://codereview.chromium.org/584753002

Cr-Commit-Position: refs/heads/master@{#295592}

BUG=412126

Review URL: https://codereview.chromium.org/565803002

Cr-Commit-Position: refs/heads/master@{#295591}

BUG=

Review URL: https://codereview.chromium.org/584643002

Cr-Commit-Position: refs/heads/master@{#295590}

This is breaking after r295514 which enforces that every file listed in an isolate file exists.

BUG=414808
R=erg@chromium.org

Review URL: https://codereview.chromium.org/585673002

Cr-Commit-Position: refs/heads/master@{#295589}

Logical OR was used instead of bitwise OR.

BUG=415437

Review URL: https://codereview.chromium.org/585653003

Cr-Commit-Position: refs/heads/master@{#295588}

Cleanup: Remove unneeded extension_messages.h usage and ifdef out some extensions code usage when extensions are disabled.

Review URL: https://codereview.chromium.org/559523004

Cr-Commit-Position: refs/heads/master@{#295587}

BUG=388987

Review URL: https://codereview.chromium.org/577123003

Cr-Commit-Position: refs/heads/master@{#295586}

During loop, player should not be in a paused state
This change fix that behavior

Layout test:https://codereview.chromium.org/585563003/

BUG=415651

Review URL: https://codereview.chromium.org/580093005

Cr-Commit-Position: refs/heads/master@{#295585}