- 07 Jun, 2019 40 commits
-
-
James Cook authored
Ash runs in the browser process and directly uses pref objects. Since it doesn't use the mojo preferences service, remove the capability references. Bug: none Change-Id: If15c14020c33dcbb5c01b463b842df7a885c3c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648537Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#667152}
-
Tommy Steimel authored
This CL extracts the shared media notification code from ash/media into components/media_message_center. This will allow chrome/browser to use the media notification without depending on ash. Bug: 959478 Change-Id: Ic5623441308691ec0842a50ac4355cde1a9d274a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648707Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#667151}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c63be46c5020..55879e5b68b0 git log c63be46c5020..55879e5b68b0 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 rsavitski@google.com Merge "userdebug: support perfetto traces as a section in incident reports" 2019-06-07 fmayer@google.com Merge "Revert "Revert "Add docs for idle page tracking.""" 2019-06-07 fmayer@google.com Merge "Explain /dev/socket/heapprofd SELinux domain issue." 2019-06-07 fmayer@google.com Merge "Refactor listening socket out of heapprofd producer." Created with: gclient setdep -r src/third_party/perfetto@55879e5b68b0 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9b0ba39ec50923130f4ab8ad285152782c724ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649518Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667150}
-
Evan Stade authored
Bug: 958223 Change-Id: I9cf5a8fa22f28fce5f6c04e21e124e350930c208 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649376 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
-
Erik Chen authored
This allows build scripts to directly specify the required binaries, rather than implicitly relying on xcrun to find the binaries. Bug: 971452 Change-Id: I02862dc39fba7ec1c7534283b0b5a5bfd5f4bbd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648780Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#667148}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b793b75db948..13f3e6190c83 Created with: gclient setdep -r src-internal@13f3e6190c83 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com Change-Id: I0f4046164c8456b6068fb278ff91e1bcee36e627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649517Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#667147}
-
Anastasiia Nikolaienko authored
sync_ui_util displays a sync error even for Secondary Accounts, which are not being used as the Sync Account. This can happen if SigninErrorController is running in |AccountMode::ANY_ACCOUNT|, e.g. on Chrome OS. Fix this by specifically checking the error state of the Sync Account instead of using errors from any account. Bug: 971475 Test: unit_tests --gtest_filter="*SyncUIUtilTest*" Change-Id: I871257cef082c4cee7fd1be5f84d1c2f50441422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648217Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#667146}
-
Nektarios Paisios authored
According to the Microsoft documentation, the third argument to EnumVariant::Next could be nullptr. In that case, the caller is not interested in the number of items received. This patch: 1. Ensures that passing a nullptr as the third argument to the Next method will be treated according to the documentation. 2. Ensures that enum variant properly handles the allocation and deallocation of VARIANTS by switching to ScopedVariants. 3. Switches to using an std::vector instead of a C-style array for storing the ScopedVariants for better readability. 4. Introduces a test for IAccessible2::get_accSelection which was the accessibility API through which the bug was detected and subsequently reported to us. 5. Makes sure to cast the selected nodes in get_accSelection to the proper interface (i.e. IDispatch) before storing them in the EnumVariant. R=aleventhal@chromium.org, kbabbit@microsoft.com, wfh@chromium.org Bug: 947898 Change-Id: I83a1d5f634a3e95ce74602371987947d55c65fb7 Tested: Browser test, manual test case found in bug Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636462 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#667145}
-
Ramya Nagarajan authored
Add field trial config for feature to insert a default shortcut to Google on the NTP. Disabled feature on browser tests that asserted on a specific number of shortcuts. Bug: 962558 Change-Id: I8d14d0b1e92db1e87a12610f72c04a715343ccf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642376Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#667144}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/abea78f985f4..7301d427d5df git log abea78f985f4..7301d427d5df --date=short --no-merges --format='%ad %ae %s' 2019-06-07 perezju@chromium.org [Telemetry] Drop 'story' argument from results.[Add/Create]Artfifact Created with: gclient setdep -r src/third_party/catapult@7301d427d5df The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:966835 TBR=oysteine@google.com Change-Id: I53d36b9e23137174289e1d9e131cc1fef61657c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648648Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ea49f6f5d4e3..b407e1a0b5bf git log ea49f6f5d4e3..b407e1a0b5bf --date=short --no-merges --format='%ad %ae %s' 2019-06-07 syoussefi@chromium.org Vulkan: implement ES3 blit Created with: gclient setdep -r src/third_party/angle@b407e1a0b5bf The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Change-Id: I47ed430fa192e71fa59c39c8298b44a36e8feae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649717Reviewed-by:
-
Andreea Costinas authored
A new storage partition is generated every time the enrollment screen is shown but the webview is bound to the storage partition set before the first navigation. This generates errors when navigating the enrollment screen more than once (using the 'Back' button). This CL adopts the same solution used by the Gaia sing-in screen by recreating the webview and assigning it the new partition if the screen was already navigated. Bug: 964945,956973 Change-Id: I8500631f81442b62105dfb3b00cc1532ab7af2ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647834Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#667141}
-
dpapad authored
Bug: 522168 Change-Id: I33c7fcf4b91198f50ecc253f315d0ce3da366bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648437Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
-
danakj authored
The browser can not delete a speculative main frame that has committed since the renderer takes ownership of it. This is a race since the renderer makes this decision, and the browser may try delete it before hearing it has been committed. In this case the renderer ignores the delete to avoid losing state. However as part of cancelling speculative navigation during shutdown, the browser will also replace the RenderFrameProxyHost which makes a RenderFrameProxy and RemoteFrame as the main frame in the renderer. This is a problem because it replaces Page's main_frame_ pointer to the main LocalFrame that was committed and not deleted by the browser's request. The LocalFrame becomes an orphan that lives indefinitely, with the LocalFrame and associated RenderFrame and WebViewFrameWidget holding raw pointers back to the WebViewImpl, the RenderWidget, and the RenderViewImpl. When these are closed and destroyed, if the process is not killed entirely, the frame will crash if it tries to access these. Since WebContentsImpl drops all RenderFrameProxyHosts before destroying the FrameTreeNode, we can not go through RenderFrameHostManager's CleanUpNavigation() or DiscardUnusedFrame() as this path will recreate the already deleted RenderFrameProxyHost, leading to the leaked frame. So instead we can simply delete the speculative RenderFrameHostImpl with UnsetSpeculativeRenderFrameHost(). This skips past recreating the RenderFrameProxyHost, setting the speculative RenderViewHost as being swapped out, and notifying in IPC that the nav was cancelled, none of which should matter to do at shutdown. R=avi@chromium.org, dcheng@chromium.org Bug: 964668, 838348, 915179 Change-Id: Icb7f2dfe6752ae745b0ea299fe4ca974b34516a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648463Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#667139}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=pbond@chromium.org Change-Id: If50583db78bf057eb73dd9ecedf6892ee3f9ef54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649679 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Polina Bondarenko <pbond@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#667138}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=rouslan@chromium.org Change-Id: I0d16e66a8b67117567d04884ebe7584fd7ea5926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649369 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#667137}
-
Nikita Zetilov authored
Change-Id: Ib715fb23b3fcb21997215e2c5d973f10e3cee92b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631589Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Nikita Zetilov <zetilovn@google.com> Cr-Commit-Position: refs/heads/master@{#667136}
-
Maksim Moskvitin authored
ModelTypeRegistry expects OnEncryptedTypesChanged() to be called before initialization of PASSWORDS ModelTypeWorker. This CL satisfies the expectation by notifying observers during bridge's Init(). Bug: 922900 Change-Id: I0fc50e40d8d0bccfa023c0cbe0c5ef409e96e6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638519 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#667135}
-
Moe Ahmadi authored
Bug: 910994 Change-Id: If87f745b55b3a044d1f92c8c61f6cb419d469798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638922Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#667134}
-
rnasri authored
Bug: 961846 Change-Id: I3cc0ebbe04f07c4b05c6d6d87e3b3110160e2d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632870Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Rasha Nasri <rnasri@google.com> Cr-Commit-Position: refs/heads/master@{#667133}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=mef@chromium.org Change-Id: Icd3adfdfc99f8d1cc3a6b09022c829bd33706949 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649734 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#667132}
-
Nick Diego Yamane authored
Replace old *_EXPORT macros in //ui/base/x by the new style COMPONENT_EXPORT. Bug: 891175, 789065 Change-Id: I0d47b9d5b1ca5c2880ddf597daafaa5c416f81b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647007Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#667131}
-
Moe Ahmadi authored
This CL changes the Compact Translate Infobar implementation so that the infobar can be created in the error state. The infobar presents a Snackbar notification in this state. This is needed when the Translate infobar is manually force-triggered in a situation where translation cannot be done (English to English translation) Bug: 971832 Change-Id: I9d2a58da42a783a23a8a0c958823bd27293fec77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648709 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#667130}
-
Christopher Grant authored
This is a reland of 2f208730 Original change's description: > Android: Align libchrome and libmonochrome GN target names > > The GN target to build libchrome.so is historically called "libchrome", > whereas libmonochrome.so's target is "monochrome". The missing lib > prefix on Monochrome necessitated special cases when referring to the > library. > > Further, when we start generating partitioned libraries, the > subdirectory they get dumped into is based on the target name, and it'd > be nice not to have to special-case that too, for the sake of release > scripts. > > Change-Id: I3d743ffdcab1fad47b7e9b4d15cfd31591428980 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646414 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666762} Change-Id: Ieb1e82cc9f044b5c31c26cc5a40784cc0190c041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647965Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#667129}
-
Pauline Leitao authored
TBR=parastoog@google.com,msramek@chromium.org,noyau@chromium.org,sebsg@chromium.org Bug: 969620 Change-Id: I37036ea4130d7d5491a3160cfccc2d5cab35a8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648168 Commit-Queue: Pauline Leitao <psivieroleitao@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Manu Cornet authored
As a first step, the corresponding shelf items are still created and added to the model, but they are ignored at the view level, where the buttons are created separately. The two corresponding item types are marked as deprecated. Bug: 971426 Change-Id: Ia6af9a982f29831d578d3e3b02976647d9681610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646972Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#667127}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=jlebel@chromium.org Change-Id: I3c46b26bbfd0a17c28f88b1853bb49378daf8eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648207 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#667126}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=fmalita@chromium.org Change-Id: I19a8495c4050395219665057dd6013ec0112b643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649327 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#667125}
-
Samuel Huang authored
This reverts commit fee1e3c8. Reason for revert: Suspected of causing memory leak in various tests (http://crbug.com/972005) e.g., crbgug. * fast/forms/file/file-input-click.html * fast/forms/file/file-input-key-enter.html ... Original change's description: > Use a Persistent FileChooserClient to avoid GC > > Previous to this change, the FileChooserClient was only held by > a WeakPersistent pointer, and as a result, the client could get > garbage collected. This led to user-visible bugs, such as > crbug.com/844119. This is now corrected. > > Bug: 844119 > Change-Id: I7ab788e85dba4d6343a3abceafb092ef1cfe64f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639046 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#666970} TBR=tkent@chromium.org,masonfreed@chromium.org Change-Id: Ief378adea1a4e19cf3fe0fe0a4b2517edeb8529f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650020Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#667124}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6faf8d662af8..fe18de506097 git log 6faf8d662af8..fe18de506097 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 robertphillips@google.com Experimental: Add R_16 and RG_1616 to Ganesh (take 2) Created with: gclient setdep -r src/third_party/skia@fe18de506097 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Change-Id: Ib5e7f5d28bd582ce57b2f9f348f114a1466a05b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649716Reviewed-by:
-
Maks Orlovich authored
... by reporting a failure rather than DCHECK'ing. This seems to hit on unit_tests on Mac a lot; those tests usually have the object managing the temporary profile directory (usually TestingProfile) destroyed before they shut down all the worker threads, so it may end up deleting the cache directory in between when SimpleCache opens it and when it tries to grab modification timestamp. Bug: 937998 Change-Id: Id1d962cf8f8f96a6bb1f713c917db3f7eb0bbe3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645635Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#667122}
-
James Cook authored
This allows some OpenUiDelegate classes to be eliminated from ash system tray code. AshTestBase now provides a shared SystemTrayClient implementation for tests. Long ago we had a similar class "TestSystemTrayDelegate" that did something similar. Bug: 970889 Test: ash_unittests Change-Id: I0035dccfe343df4ef8504cb0113684539eae2ef1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649056Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#667121}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7f47e1a27c39..c63be46c5020 git log 7f47e1a27c39..c63be46c5020 --date=short --no-merges --format='%ad %ae %s' 2019-06-07 fmayer@google.com Merge "Revert "Revert "Add Mapping / Frame / Callstack to InternedData.""" 2019-06-07 sidaths@google.com Process GPU frequency info from ftrace if available Created with: gclient setdep -r src/third_party/perfetto@c63be46c5020 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I028ffff5e3aeb2f20c367a8da666d0bacfca433b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648649Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=kenrb@chromium.org Change-Id: I121cbc069435b3dbbfbe0fc58d930333d07c1d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649736 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#667119}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/81513b8eb5f0..b793b75db948 Created with: gclient setdep -r src-internal@b793b75db948 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=thomasanderson@google.com,huangs@google.com,harrisjay@google.com,armax@google.com Change-Id: I7f2efc63170ff7b5b8bc4766af66e5e49e1e71ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648652Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=haraken@chromium.org Change-Id: I01b6d2264953daa3d6ac9a7612d25147f6237c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649370 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#667117}
-
Carlos Caballero authored
MessageLoop will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you belive your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=sadrul@chromium.org Change-Id: Ie9d8c8846d5f4f3a9d413ab08ee1cb1d814bb52b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648201 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#667116}
-
Martin Robinson authored
It makes more sense for this code to live with the rest of the formatting code and moving it reduces the size of a very large code unit. Bug: 971966 Change-Id: I816569428d9e21b5ccd84b687d1e604fd97956fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649166Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#667115}
-
Maksim Moskvitin authored
If the experimental feature for Nigori USS is enabled, the new codepath now uses a controller (ModelTypeController) to start and stop Nigori, and to connect it to the ModelTypeWorker. Because of lifetime issues with Nigori, and the special treatment for the initial sync cycle during engine initialization (which predates the instantiation of DataTypeManager), the interactions with the controller are done manually, and on the sync thread. This is not ideal, but we don't have better alternatives as of today, without intrusive changes that would be barely feasible during the coexistence of both codepaths. To avoid engine_impl's dependence on driver the registration of Nigori datatype was moved back to SyncEngineBackend (partially revert https://chromium-review.googlesource.com/c/chromium/src/+/1619813). Bug: 922900 Change-Id: I22b20d3a0e2f396a0eddbef54cf2e429f02cc410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648178 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Finnur Thorarinsson authored
These metrics have taken on a renewed importance with the plans to add video support. Bug: 966641, 656015 Change-Id: I359387a35bdce6566d965e920072ac74f2d29be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648223Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#667113}
-
