- 03 Oct, 2018 40 commits
-
-
Carlos Knippschild authored
The group name used in the variations' field trial test configuration didn't match the one set in the flags configuration, causing DCHECK crashes when the feature flag is used. This change makes those names match. Bug: 852872 Change-Id: Ie817d84bdf3801d344497543b21a12428dc66fbf Reviewed-on: https://chromium-review.googlesource.com/c/1257653Reviewed-by:
Dan H <harringtond@google.com> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#596370}
-
Philip Rogers authored
A webview's preferred content height is typically the minimum height required to display the main document without scrollbars. This is not true for quirksmode documents (documents without <!doctype html>) where the height will always fill the viewport at a minimum. This is not obvious so a comment and test have been added. Change-Id: Id39755a81f2d258d4b078501f37c425f8dc2d8ba Reviewed-on: https://chromium-review.googlesource.com/c/1259041 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#596369}
-
Weilun Shi authored
The logoImg.complete event was not working as intended on Mac's chromium chrome://apps. Directly using onload event to adjust the width for the footer menu and the logo instead. Screencast: https://screencast.googleplex.com/cast/NTY2NzA1MTk2ODM5NzMxMnw1ZDVjMjU5NS1jYQ Bug: 864267 Change-Id: I614d44c9377e276f6d3084c299ab9ced98ed831d Reviewed-on: https://chromium-review.googlesource.com/c/1257676Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#596368}
-
Becca Hughes authored
Move AudioFocusManager and its unit tests to //services. This CL does not remove the existing AudioFocusManager in //content as this will be done in a follow up CL with some mojo work. BUG=875004 Change-Id: Ife982e671d21ca7be29a6bed38097e842937b35f Reviewed-on: https://chromium-review.googlesource.com/c/1197351 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#596367}
-
Collin Baker authored
This adds the feature and event definitions to the IPH backend for our desktop IPH pilot feature: recommending users reopen accidentally closed tabs. See associated issue for design doc, PRD, and mocks. Bug: 887991 Change-Id: I939b0b8de95d7340d902ad2273c8bae0a751f12e Reviewed-on: https://chromium-review.googlesource.com/c/1259476Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#596366}
-
Sophie Chang authored
Bug: 883528 Change-Id: I9b909ece49229149efa75cf0cb70ced808f22835 Reviewed-on: https://chromium-review.googlesource.com/c/1252782Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#596365}
-
David Bertoni authored
Bug: 891788 Change-Id: I2bbef101cf0d95114836391a508b366982da5d4d Reviewed-on: https://chromium-review.googlesource.com/c/1257552 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Brian Salomon authored
If quads are antialiased this can trigger shader blending. Also Skia has optimized code paths for textures drawn src-over. Bug: 811523 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9f0405d7651464aeb761c02f5d16f4de29dbbd75 Reviewed-on: https://chromium-review.googlesource.com/c/1259543Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#596363}
-
Xiaohan Wang authored
This can be used to control whether to fall back to another decoder after audio/video decode error. This is useful in debugging and testing to avoid surprises, e.g. playback works after falling back to another decoder while the test doesn't expect a fallback. Bug: 877673 Test: Disable fallback on encrypted media (content) browser tests. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I66787a84ce369e003f6b15187b0d31653cb6df68 Reviewed-on: https://chromium-review.googlesource.com/c/1257364 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#596362}
-
Eugene But authored
Error presentation code does not work if navigation is failed without a pending item. It is easier and more correct to actually create navigation item for state restoration than workaround the bug in error presentation code. This fixes the bug when placeholder URL is displayed in the omnibox. Bug: 887385, 888021 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I94a124d3477d074fcea2d94128f5bbffe4091f2f Reviewed-on: https://chromium-review.googlesource.com/c/1258611 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#596361}
-
Jimmy Gong authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/536735c00911..f63dc2e08f0c $ git log 536735c00..f63dc2e08 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 jimmyxgong smbprovider: Add MountConfigProto to directory_entry 2018-09-21 semenzato system_api: add anomaly event service interface Created with: roll-dep src/third_party/cros_system_api Change-Id: Ibb5fbd044ae7c52ec321c6331935a0d8840b034e Reviewed-on: https://chromium-review.googlesource.com/c/1259493Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#596360}
-
Philip Rogers authored
The md extension options dialog has an inner frame with the options page contents. The dialog is sized based on the preferred size of the options page contents using preferred size change events. The options page contents's size is also dependent on the dialog size, so resizing the dialog can result in a preferred size change event which then resizes the dialog size again. Because the options dialog and the options page contents are on different threads, this size update logic can infinitely oscillate between two sizes. This bug became more prominent with two recent changes: https://crrev.com/581383 - made preferred size changes synchronous https://crrev.com/582708 - moved preferred size change events from the middle of a frame to the end of a frame. This patch adds a delay between getting the preferred size update and changing the dialog size, fixing the options dialog size oscillation. This mimics the asynchronous preferred size updates that were done before https://crrev.com/581383. Test: manually tested using 4 custom extension options pages (short quirksmode, tall quirksmode, short html5, and tall html5). Bug: 882835 Change-Id: I97bd61c3137ae851d855637aed75029bce1e5404 Reviewed-on: https://chromium-review.googlesource.com/c/1259040 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
When overridding SetUpCommandLine(), subclasses of MediaBrowserTest should always call MediaBrowserTest::SetUpCommandLine(). This also helps remove duplicate code in setting autoplay policy in these tests. Bug: 707128 Test: Clean up only. No functionality change. Change-Id: Ic06ba4b48e20cf342db7f60a32565766f5d1a1d5 Reviewed-on: https://chromium-review.googlesource.com/c/1257599Reviewed-by:
-
Evan Stade authored
- remove some window properties that had been used for theming - remove dead member variable - update comments - use remove_standard_frame / kRemoveStandardFrame_InitProperty instead of kDisableImmersive_InitProperty for Mash browser windows Bug: 887051 Change-Id: Ia7d64acebca600354162be9560bc64761bd3570e Reviewed-on: https://chromium-review.googlesource.com/c/1255924Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#596357}
-
Evan Stade authored
Interface was added for browser frame theme images, but it's no longer needed. Bug: 887051 Change-Id: Ic015e41da421b81b5174f55b49c0f2b025dd10c6 Reviewed-on: https://chromium-review.googlesource.com/c/1257808Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cd9050823b91..723e82b649de git log cd9050823b91..723e82b649de --date=short --no-merges --format='%ad %ae %s' 2018-10-03 treehugger-gerrit@google.com Merge "Fix missing mode_t on Windows." 2018-10-03 fmayer@google.com Consistently use base::OpenFile. 2018-10-03 fmayer@google.com profiling: Use sampler in client. 2018-10-03 fmayer@google.com Fix GCC and clang debug builds. Created with: gclient setdep -r src/third_party/perfetto@723e82b649de The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iff099d1c78d34f7be677490467155f6fb2f1726c Reviewed-on: https://chromium-review.googlesource.com/c/1259495Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596355}
-
Evan Stade authored
Bug: 891579 Change-Id: I0151617076021d7ed0923853302faa733782b662 Reviewed-on: https://chromium-review.googlesource.com/c/1258610Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#596354}
-
Robert Liao authored
No code checks for this feature or experiment anymore. BUG=876090 Change-Id: I3b190857043ea067e28842458d2343a08c9d3920 Reviewed-on: https://chromium-review.googlesource.com/c/1255893Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#596353}
-
Adam Klein authored
WebAssembly has been enabled by default for a long while now. Bug: 642912, v8:8015 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I50fdf1a15f5183e91fdafa5cf921aa33493a9a7c Reviewed-on: https://chromium-review.googlesource.com/c/1239212 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#596352}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /chrome/browser/devtools. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=caseq@chromium.org, nasko@chromium.org Bug: 890902 Change-Id: I20c6bbcc7bab10107f7557d1e5f6cffe0c0d0d94 Reviewed-on: https://chromium-review.googlesource.com/c/1257887Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#596351}
-
Tom Anderson authored
BUG=737995,881371 R=pkasting Change-Id: Icc068573b4b10e618ee9bce39cc6970b8b077152 Reviewed-on: https://chromium-review.googlesource.com/c/1258252 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#596350}
-
Olivier Robin authored
Bug: 881364 Change-Id: I6cef5aa5a8acc32bc797c3abbef0869a2f094e66 Reviewed-on: https://chromium-review.googlesource.com/c/1259782 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596349}
-
Tommy Martino authored
When initially adding the footer functionality to the dropdown, the possibility that the footer would have a greater width than the rest of the dropdown was not considered. This CL updates the width calculation in the base level dropdown class. Screenshots: https://docs.google.com/presentation/d/168Uk8_itrZTvf5RfsmCmpkFUebMJo2h61bBZBYQ70i8/edit?usp=sharing Bug: 874077 Change-Id: I08051ac7302f476ee82ac5e077e49c4cdd00ef88 Reviewed-on: https://chromium-review.googlesource.com/c/1258051Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#596348}
-
Nasko Oskov authored
This CL borrows code and layout from chrome://inspect to allow us to have multiple ways to view internals of the process model. Subsequent CLs will fill in the actual data on those extra panes. Bug: 850087 Change-Id: Ia2891804dd61346e86c44c4aca32daf57302aed4 Reviewed-on: https://chromium-review.googlesource.com/c/1255599 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#596347}
-
Alexey Kozyatinskiy authored
On browser side we suspend message dispatching during provisional load, so it is not possible to resume if pause happens. R=dgozman@chromium.org Bug: chromium:812091 Change-Id: Id9f7015febfb5ec868af2266aa8e3ca76eb7dd3d Reviewed-on: https://chromium-review.googlesource.com/c/1252802Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#596346}
-
Theresa authored
Once the simplified NTP is enabled for everyone, the ContentSuggestionsScrollToLoad flag will be the only thing controlling whether users have scroll-to-load behavior. We're not ready to roll out scroll-to-load, so default disabling it for now. BUG=865216 Change-Id: I55bb1fe63ee34adee2d40513c0c1c5296b3b83a7 Reviewed-on: https://chromium-review.googlesource.com/c/1259474Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#596345}
-
Xiyuan Xia authored
User adding screen does not wait for user switching animation with Window Service (crbug.com/875111). But we are still observing the animation and the screen is dismissed when the animation ends. This could cause the user adding screen being dismissed unexpectedly as shown in the single process mash browser tests. The CL fixes the issue by not observing the animation in such case. Bug: 891383 Change-Id: I21d8735d517f7cbd8a17c2902dd73d9f05e282cc Reviewed-on: https://chromium-review.googlesource.com/c/1259296 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Quan Nguyen authored
Full handling of authentication response as well as enrollment will arrive in later CLs. Bug: 890912 Change-Id: I9c55403462494d3c188b8ba07fc2d210b2a97a9e Reviewed-on: https://chromium-review.googlesource.com/c/1255023 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#596343}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6af3aa854956..684313d6a319 git log 6af3aa854956..684313d6a319 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 oprypin@webrtc.org gclient setdep doesn't need to update_depot_tools 2018-10-03 abenner@google.com Add non --full support to python git cl format Created with: gclient setdep -r src/third_party/depot_tools@684313d6a319 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:836566,chromium:846432 TBR=agable@chromium.org Change-Id: I7686bb5d7f4d16aa8badf940b3b9f6bc104f4ee6 Reviewed-on: https://chromium-review.googlesource.com/c/1259489Reviewed-by:
-
Etienne Pierre-doray authored
Main issue: TaskTraits constructor is not robust; any signature is part of the overload set, even if it may not compile. Because of that, it may not possible to hold TaskTrait in a tuple (depending on implementation). Fix: Expose a single constructor that checks if all traits are valid, or if an extension can accept all traits. Caveat: An extension has to redefine base TaskTrait::ValidTraits as valid (through inheritance). This CL also simplifies querying traits thanks to C++14 relaxed constant expressions. This reduces compile time complexity of TaskTraits constructor from O(n^3) to O(n^2). Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I73f993f6be837f1ac665b4b09c78d9d7272435a8 Reviewed-on: https://chromium-review.googlesource.com/c/1194687Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#596341}
-
Zach Helfinstein authored
Bug: 864796 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ie299534b069a83dc38012468f547810f7b83b0b0 Reviewed-on: https://chromium-review.googlesource.com/c/1227501Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#596340}
-
yusukes authored
BUG=b:116761000 TEST=None Change-Id: I183b22eaa8c1bebad3f2797604bf7a98712c958d Reviewed-on: https://chromium-review.googlesource.com/c/1252385Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#596339}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1709049243e..bfa76f20bfcf git log f1709049243e..bfa76f20bfcf --date=short --no-merges --format='%ad %ae %s' 2018-10-03 robertphillips@google.com Add GM for less common YUV formats (take 2) Created with: gclient setdep -r src/third_party/skia@bfa76f20bfcf The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: I107c872f19588728980df853ca7e5d470d6a9e33 Reviewed-on: https://chromium-review.googlesource.com/c/1259402Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5cc52fbcc765..18c0a2b44777 Created with: gclient setdep -r src-internal@18c0a2b44777 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icdd628529a8ce0c45c9d2697f187464ad6eda22b Reviewed-on: https://chromium-review.googlesource.com/c/1259482Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596337}
-
Timothy Loh authored
While the other classes in chrome/browser/chromeos/crostini are in the crostini namespace, the crostini_util functions are currently in the global namespace. For consistency, this CL moves these to the crostini namespace. Change-Id: Idf46afb76f1196a6a0ab961ea53195e536623bc4 Reviewed-on: https://chromium-review.googlesource.com/c/1250263Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7988589e4858..59021ba4e1dc git log 7988589e4858..59021ba4e1dc --date=short --no-merges --format='%ad %ae %s' 2018-10-03 sprang@webrtc.org Refactoring of VP8 TemporalLayers interface. Created with: gclient setdep -r src/third_party/webrtc@59021ba4e1dc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I711ec23882236e0eaeacb79d40d2d93d036d6da9 Reviewed-on: https://chromium-review.googlesource.com/c/1259106Reviewed-by:
-
Benjamin Ackerman authored
Removing everything associated with inline installation as it is deprecated per the announcement in https://blog.chromium.org/2018/06/improving-extension-transparency-for.html Bug: 882045 Change-Id: Ia24cb4076a841d9b37febe68cad89db7ea1ce1c8 Reviewed-on: https://chromium-review.googlesource.com/c/1220299Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Jun Mukai authored
This is phase-1 of tab-dragging with touch on Mash. This CL adds GestureRecognizerObserver class, which will be used in upcoming CLs. BUG=867074 TEST=events_unittests Change-Id: I7a8c50ac16b58e1c3e31c7f0d8df097489ee49c3 Reviewed-on: https://chromium-review.googlesource.com/c/1247101 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
rbpotter authored
(1) Increase line height for destinations items (2) Remove "Advanced" label for printer options button (3) Remove margin on paper-icon-button so Print with system dialog... does not wrap (for English + normal font size) (4) Change pages per sheet label to sentence case (5) Fix alignment of "Destinations" label with printer names, particularly for printers that do not have a status/location displayed. Bug: 891375, 891378, 891379, 891395, 891577 Change-Id: I13fbcd167e2e9ee513ef056ce5c9e471248dd3d8 Reviewed-on: https://chromium-review.googlesource.com/c/1257370 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: -
Ryan Sturm authored
This CL moves the state of whether DRP can skip the long term blacklist checks for Previews from DRPConfig to PreviewsDecider. This happens through some thread Posts, and will eventually move to one thread PostTask instead of 2 when Previews is on the UI thread. Bug: 842233 Change-Id: Id8129338eeb1b2401f8f70ab2d02aebcbbd5c0e1 Reviewed-on: https://chromium-review.googlesource.com/c/1252783 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#596331}
-
