- 18 Jun, 2019 40 commits
-
-
Eugene But authored
UI>Browser>Sessions is the most appropriate component Bug: None Change-Id: I356fca2650c6339e299801b60b9479d729dce46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665475 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#670231}
-
Robert Sesek authored
- The Renderer helper gets com.apple.security.cs.allow-jit, which is used with MAP_JIT when allocating pages for V8. - The Plugin helper gets com.apple.security.cs.disable-library-validation, allowing it to load non-Team ID-signed libraries (e.g. Flash), and com.apple.security.cs.allow-unsigned-executable-memory required to run Flash content and NaCl modules. Bug: 850193 Change-Id: Iefaac47d85683b7a5e155b169cd4eb5d5f94bd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664834Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#670230}
-
Darwin Huang authored
- fast/events/before-unload-return-value-from-listener.html - https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/24083 - https://chromium-swarm.appspot.com/task?id=4584885a49ea6b10 TBR=eae@chromium.org NOTRY=true Bug: 976355, 974725 Change-Id: I889c24db648667f26c47c421352001b39d13b709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665558 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#670229}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c39cb7918f0b..88825299a7d4 Created with: gclient setdep -r src-internal@88825299a7d4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: I7a60d7a975b513a2a6d8715cbf737abfab135aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665489Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#670228}
-
Robert Ma authored
Namely, `doc_root` and `domains` (the latter was added in https://github.com/web-platform-tests/wpt/pull/17141) Also a drive-by fix to improve test discovery (only run .py files). Bug: 974877 Change-Id: Idb917ee0dcab9691709e3d99e3f29ceec82edeb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664042Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#670227}
-
Michael Crouse authored
Add a commandline flag, kHintsFetchOverrideTimer to force a hints fetch without specifying a list of hosts. This allows testing of the TopHostProvider and HintsFetcherTopHostBlacklist without the timer delay for fetching hints. A future change will implement browsertests that utilize this flag to test the TopHostProvider, blacklist, and blacklist state. Bug: 932707 Change-Id: I309daedec53be4e250adf2abcc2215dccf8dac51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657392Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#670226}
-
Aleks Totic authored
While stepping throught the code, I've noticed that AddOutOfFlowDescendant was doing a memcpy. Change-Id: I97fd39e91656dc31a26ae744780ded3ca4ee9be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663184 Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#670225}
-
Yining Wang authored
This metric records time spent on focus mode browser. Bug: 971690 Change-Id: Ida9aa8aa05fd090a44fc179650f1cc0d6682de84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652367Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yining Wang <yiningwang@google.com> Cr-Commit-Position: refs/heads/master@{#670224}
-
Daniel Libby authored
Note: based on crrev.com/c/1648953 In order to get swap timing in the renderer process, we'll need to send down additional information via BeginFrame. crrev.com/c/1639559 adds a new FrameTimingDetails struct that will be sent down, instead of just the PresentationFeedback. We'll be adding to that struct in a future CL that plumbs out swap information. This struct add the first bit of plumbing from OutputSurface to Display. OutputSurfaceClient::DidReceiveSwapBuffersAck now takes a SwapTimings parameter, which will then be plubmed out to Surface then SurfaceClient (CompositorFrameSinkSupport) once dependent changes all land. Bug: 971712 Change-Id: Ibdd49356ce94261aec4a695b22f96dec1ed5e0ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650224 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#670223}
-
Peng Huang authored
Bug: none Change-Id: Iee7c2d97a61f665ec82c5e0ab579b69a26debf60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665206 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
Archana Simha authored
Elements with the tag-name "a" or "img" with "onclick" attributes will be included in the RIND report. The inline JS is stored in the inner_html field of HTMLElement. This string is not modified or inspected before the report is generated. The capturing of inline JS and onclick content is disabled. http://gpaste/5722548836761600 Bug: 959964 Change-Id: I8c59cfb83fdb211dd5bc8486d4d21eb0378037df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594034Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Archana Simha <archanasimha@google.com> Cr-Commit-Position: refs/heads/master@{#670221}
-
Lucas Tenório authored
Bug: 973985 Change-Id: I06377f374f3c2e5985b7c80914fb184be94a5a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658854 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#670220}
-
Jun Cai authored
This CL adds some unit tests for Bluetooth Scanning prompt when user grants permission or cancels the permission prompt. Bug: 953075 Change-Id: Ibb3a085a9ceffe304e5a4c49af79127cae8b75de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660811Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#670219}
-
Vadim Bendebury authored
Let's keep them for another year to be able to detect ubnormalities of Board ID management processes. BUG=chromium:975873 Change-Id: I32117c6ecae11f5596afa91c86128d5700ea5e27 Signed-off-by:
Vadim Bendebury <vbendeb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663040Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#670218}
-
Xida Chen authored
Currently the layout test parse-input-arguments-018.https.html is crashing with virtual/threaded which runs off-thread paint worklet. The problem is that CSSPaintImageGeneratorImpl::HasDocumentDefinition does not check whether the definition is valid or not. In particular, PaintWorkletProxyClient::RegisterCSSPaintDefinition can register two different CSSPaintDefinition which would throw an exception. But the |document_definition_map_| will still have an entry for this CSSPaintDefinition and the value of the entry is nullptr. In this case, the CSSPaintImageGeneratorImpl::HasDocumentDefinition should return false. Bug: 957459 Change-Id: Ic192676e537ce6b09bf56f244db61dac68598bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662592 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#670217}
-
Morten Stenshorne authored
If a line (RootInlineBox) is marked dirty, also treat adjacent following lines with floats on them as dirty. We cannot safely skip laying them out, because of bugs in the legacy line layout engine. We ended up in a scenario where just one line got marked dirty, because we removed some text there. A float that was associated with the second line got associated with the first (dirty) line during re-layout. We'd skip layout of the next line because it wasn't dirty, and we found it safe to stop laying out after the first line and re-use the remaining lines from the previous layout pass. Suddenly the float was associated with two lines. In addition to definitely fixing the fuzzer crash in bug 724830, it is also speculative fix for bug 969325 (which I've been unable to reproduce, but both the test and the crash seem very similar). Bug: 724830, 969325 Change-Id: I0bbceeac1e19588c58206ed075c21ea19347109f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664910Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Eugene But authored
iOS 12.2 has a bug where WKWebView can call didFailProvisionalNavigation: without calling didStartProvisionalNavigation:. With this bug, Chrome can't lookup corresponding NavigationContext object and crashes on null pointer dereferencing. This CL suppresses the crash by not calling WebStateImpl::OnNavigationFinished and logs UMA historgam when the bug happens. UMA historgam will allow us to remove the workaround in the future. Bug: 957923 Change-Id: Ia961b2597952d19732c55464d72b8a2bf55c2364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656788 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#670215}
-
Jacob DeWitt authored
- Changed the style of the header to make it look more distinct from the WG samples. - Removed redundant links. - Added text clarifying that these samples are specifically for Chrome 76-77. Bug: 966565 Change-Id: Ia99f36a546d8ecada79864797e8c4b3d9dd412e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664972 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#670214}
-
Josh Nohle authored
This allows us to build the CryptAuthDevice incrementally which is more natural given the DeviceSync v2 flow. Bug: 951969 Change-Id: I2863047f95da0ddd46d913fcb06175dd4f441386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652681Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#670213}
-
Jeremy Klein authored
correct. Bug: 894600 Change-Id: I8357061d91a0f2c63ec4c60c2d0bb97688849c88 Tested: Manually flipped switch on and off and verified that it looks Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664516 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#670212}
-
Caitlin Fischer authored
Bug: 976325 Change-Id: Ib9a1db6f006663be3b97b127a8a2615dccf4ec08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663253 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#670211}
-
Robert Ogden authored
Manages background preresolving for lite page redirect previews. When a set of conditions are met, this class causes the litepage version of the current committed page URL to be preresolved in a loop so that the DNS entry for the litepage is always cached. This helps to mitigate the delay of loading a preview of the same origin. Covered in a follow up CL: * Tab visibility * ECT * Bloom filter blacklisting Bug: 971918 Change-Id: I5c036acab0801ec7229cd80fa1bd5722b04f090c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660956Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
chrome://notifications-internalsXing Liu authored
This CL adds chrome://notifications-internals, which can be served as a place to debug notification related features. Bug: 963289 Change-Id: Ib13d99c5acd9e6b5025c74d230ade98e1e2b6c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659690 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#670209}
-
Sky Malice authored
* Replaces dialog menu's text/icon focus coloring code logic with styles and resources. * Adds text/icon focus coloring to more button. * Adds text focus coloring to last tab button. In the process, also adjusted fonts slightly: * Replaced gray 700 + black coloring of dialog menu button text with gray 900. * Replaced gray 700 coloring of more button text with gray 900. * Removed bold font from last tab button text. Bug: 962507 TBR: hannahs@chromium.org Change-Id: I4ef82003380a2d272cb9f01add5cd5b681cfa4b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627782 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#670208}
-
Theresa authored
When rebinding a view, ModelListAdapter will bind properties that were set on the old model even if they aren't set on the new model. This is causing NPEs in SuggestionViewViewBinder when re-using a view that previously displayed an answer with two lines of text for an answer that only displays one line of text. Also updates the documentation for ModelListAdapter to more clearly define the class behavior and usage expectations. BUG=974756 Change-Id: Ib6642d5ff7752bd08582a7fae2e5d75da44a95ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664654Reviewed-by:
-
Yi Gu authored
Viz hit testing V2 is supposed to land in M77. Extend this metrix to M79 for now to help with understanding the improvements. Bug: 975418 Change-Id: I2bf0a651d5fbc6cbc8b24851c5f5cd79cbd34b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663885Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#670206}
-
Matthew Webb authored
Bug: 974046 Change-Id: Id651875e837a8f5b375c1e6e0e76b45e848a595d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660955Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Matthew Webb <noviv@google.com> Auto-Submit: Matthew Webb <noviv@google.com> Cr-Commit-Position: refs/heads/master@{#670205}
-
Robert Ogden authored
Bug: 975339 Change-Id: I9a0e4977d455b6ddf60425f798c8d6f78a80c2a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663365 Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
A Olsen authored
The class InSessionPasswordChangeHandler manages a dialog where the user can change their password in-session. If cryptohome password migration fails, then the handler is notified via a callback. This callback is where we would help the user to solve the problem. However, the Handler object will not outlive the dialog, so if the user closes the dialog, then the callback will not be called, and the password change will never be fully completed. To fix this problem, this CL moves the callbacks to a PrimaryProfileService - the InSessionPasswordChangeManager. No actual functionality is changed - it just means that these callbacks (which don't yet do a lot) will still be called even if the dialog is closed. Bug: 930109 Change-Id: I520744406251645c6a98b4ea20acd5a19088d1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655649 Commit-Queue: A Olsen <olsen@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#670203}
-
Raymond Toy authored
At initialization detector_average_ is initialized to 0. When computing compression_diff_db, we basically divide by 0. Avoid this by checking for zero, and setting compression_diff_db appropriately. (Later code checked if compression_diff_db is infinity and sets it to something else.) Bug: 973905 Change-Id: Ib65909f078c42ecebcc665c80b8e3c0208ff1f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659203 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#670202}
-
Ryan Hansberry authored
This will be used for experimention to determine user impact of the more aggressive Bluetooth filter. Bug: 976334 Change-Id: I7e061a6fb6728d11d1ed025968d7fb356dd7aca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663182 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#670201}
-
Manu Cornet authored
Bug: 973476, 973483, 973481 Change-Id: I4c94bf8113cad669cd5312bdff6685b1e9f15cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663402Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#670200}
-
Tomasz Wiszkowski authored
Calculation suggestion is not like the others - it is not strictly an answer and does not have a SuggestionAnswer attached. It is, however, processed by the AnswerSuggestionProcessor. This change ensures no access to Answer structure is made by AnswerSuggestionProcessor if any (currently only Calculator) of the managed Suggestion entries does not have an associated SuggestionAnswer structure. Bug: 976239 Change-Id: Iddfd0e90b901847a47628038e96851f3741d4ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664039Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#670199}
-
Evan Stade authored
Replace with a new observer interface and by extending BackgroundService::Delegate. Bug: 268984 Change-Id: I3952ae91064a171f88574987a0cef7bacccd663c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659595Reviewed-by:
-
Shimi Zhang authored
Tests testSmartSelectionNormalFlow() and testSmartSelectionRest() are flaky due to the bots are not always provisioned. This CL fixed the flakiness by moving the blocking logic into SmartSelectionClient. It simplifies the logic of SelectionPopupController#showSelectionMenu(), makes the logic explicitly related to Smart Selection. In order to make it work, two tests in SelectionPopupControllerTest are updated. Bug: 967811 Change-Id: Ic758c46c3f51eab05d5619f295ccd8270567d8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661292 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
-
Allison Pastewka authored
Removed the UseCounters kScrollbarUseVerticalScrollbarThumb and kScrollbarUseHorizontalScrollbarThumb to avoid redundancy in metrics with the 4 UseCounters that were added here: https://chromium-review.googlesource.com/c/chromium/src/+/1575822/7 Bug: 954359 Change-Id: I1f9552b38bb86fb97c617e55bbfd9e72fe03a248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663039Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Allison Pastewka <alpastew@microsoft.com> Cr-Commit-Position: refs/heads/master@{#670196}
-
Nina Satragno authored
This patch adds the `setUserVerified` command to the WebAuthn DevTools Domain. This allows clients of the API to determine whether virtual authenticators simulate success or failure when performing User Verification. This is one in a series of patches intended to create a Testing API for WebAuthn, for use in Web Platform Tests and by external webauthn tests. For an overview of overall design, please see https://docs.google.com/document/d/1bp2cMgjm2HSpvL9-WsJoIQMsBi1oKGQY6CvWD-9WmIQ/edit?usp=sharing Bug: 922572 Change-Id: I666f07b21000d86c32db121a30f5a824c7371106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662024 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
-
Morten Stenshorne authored
It was broken because it didn't handle kFragmentRenderedLegend. Furthermore, the downcast would only be safe if it was constructed as an NGBoxFragment. There's no way to tell if it was actually constructed directly as an NGFragment, and NGBoxFragment has a data member that wouldn't be initialized in that case. Bug: 962972 Change-Id: I3994b8afa148a9c4fe293f26265c5201d65dadb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664851 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Caitlin Fischer authored
The index of the selected suggestion is hard-coded as 0, so the histogram Autofill.SuggestionAcceptedIndex mistakenly shows that 100% of users select the first suggestion. Bug: 966411 Change-Id: I0b0632747f3b0a34c0a3b97ad179f524755f01cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660970Reviewed-by:
-
Antoine Labour authored
The expectations for the initialization of ContextState are duplicated between GLES2DecoderTestBase and RasterDecoderTestBase. Extract them into a separate helper class. Bug: None Change-Id: Ib7d9b1e08a759af7a2bd199c33ce61f971ea7b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663323 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#670192}
-
