- 03 Jan, 2019 40 commits
-
-
Parastoo Geranmayeh authored
The secondary members should not be considered while comparing profiles. Change-Id: I56c7b19f5da27b2f7c147b0d005b0686c40a39a9 Reviewed-on: https://chromium-review.googlesource.com/c/1394930 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#619785}
-
Austin Eng authored
Add MultiDrawManager with MultiDrawBeginCHROMIUM and MultiDrawEndCHROMIUM commands to batch chunks of MultiDraw calls MultiDraw commands that are larger than the transfer buffer are chunked into multiple commands. This was incorrect because gl_DrawID would get reset to 0 for each chunk. This change adds Begin and End commands which allow MultiDraw chunks to be batched and submitted all together when MultiDrawEndCHROMIUM is received. This change includes tests which check the expected commands and that the gl_DrawIDs for commands larger than the transfer buffer are correct. Bug: chromium:890539 Change-Id: Ida64685be9779b6f6419d247126378a057cb627c Reviewed-on: https://chromium-review.googlesource.com/c/1372636 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619784}
-
Raul Tambre authored
Bug: 167187 Change-Id: Ia2e184751c33c5894d7e20271b97d693a2062cae Reviewed-on: https://chromium-review.googlesource.com/c/1392330Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#619783}
-
agrieve authored
* Summary needs to use <br> rather than \n. * Show actual value before max value in explanations. * Put the two SuperSize result links together. Change-Id: Iafc6b0c53fd804f6f162acae33cbd2d864354fce Reviewed-on: https://chromium-review.googlesource.com/c/1394911Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#619782}
-
Lucas Furukawa Gadani authored
Bug: 865565 Change-Id: I99af8effad00a802a9d122c3190bbbd841220f53 Reviewed-on: https://chromium-review.googlesource.com/c/1318400Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#619781}
-
bsheedy authored
Fixes potential NANs from gfx::AngleBetweenVectorsInDegrees and gfx::ClockwiseAngleBetweenVectorsInDegrees when the given vectors are very close together by clamping the value passed to acos. When unclamped, the value passed to acos could be slightly outside [-1, 1] due to floating point precision. Bug: 918734 Change-Id: I55b75b21581d25134fdc3e8e6db80892607a807c Reviewed-on: https://chromium-review.googlesource.com/c/1394086Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619780}
-
Devlin Cronin authored
Do the following clean-ups in ObjectBackedNativeHandler::RouteHandlerFunction() and its callers: - Convert base::Callback to base::RepeatingCallback/base::OnceCallback - Convert base::Bind to base::BindRepeating/base::BindOnce - Pass callbacks by value when an instance is retained In practice, these are all base::RepeatingCallbacks. Bug: 714018 Change-Id: I5c7c58bcad7d033ca576ff7bde173bc6f9482303 Reviewed-on: https://chromium-review.googlesource.com/c/1391853Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619779}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/1e2123822ca7..202ccbd707de git log 1e2123822ca7..202ccbd707de --date=short --no-merges --format='%ad %ae %s' 2019-01-03 thakis@chromium.org Make sure nacl_helper_bootstrap is rebuilt after clang rolls. Created with: gclient setdep -r src/native_client@202ccbd707de The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:918882 TBR=mseaborn@chromium.org Change-Id: I4953c0a06f1fb13eaef95687ebf9e7bbf32a254b Reviewed-on: https://chromium-review.googlesource.com/c/1394690Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619778}
-
Leonard Grey authored
Bug: 918194 Change-Id: I6572c33b8e1a607b612b6dbf5c7a5a9f369862d6 Reviewed-on: https://chromium-review.googlesource.com/c/1394739Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619777}
-
Avi Drissman authored
cc60f9329e54 Refactor PEImageAnnotationsReader test 760da9b96abf Delete snapshot/api/module_annotations_win* 60ff01287255 Change ProcessMemory to accept VMSizes bcce07414385 Make crashpad support either PSAPI_VERSION 1 or 2 8f5d83b9e3cd Change ProcessMemoryRange to use VMSize c8a016b99d97 Remove base's arraysize from Crashpad Bug: chromium:837308, crashpad:270, chromium:584969 Change-Id: Idcf144be1fa83eabc4579cc7d58e55efe421f475 Reviewed-on: https://chromium-review.googlesource.com/c/1394012 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#619776}
-
Theresa authored
On older versions of Android (M-), the hint text isn't announced for accessibility. The content description, however, is announced. Behavior is unchanged on newer versions of Android (N+). BUG=911762 Change-Id: I8c5a2e90c14d08c925875f4b76af03de9a3f1178 Reviewed-on: https://chromium-review.googlesource.com/c/1392172Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#619775}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b4e2270d..686bde10 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I76c05107c69f0f85c933f757700225f9fac35ada Reviewed-on: https://chromium-review.googlesource.com/c/1394878Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619774}
-
Parastoo Geranmayeh authored
Variable/Function name updated to avoid confusion between server/client validation. Change-Id: Id503baae2f466a5999ab961bc59008bb202979d5 Reviewed-on: https://chromium-review.googlesource.com/c/1394909Reviewed-by:
-
Maxim Kolosovskiy authored
Whether an uploaded form is a <form> tag or a list of unowned <input>s may be useful for server side analysis. In particular, the list of unowned <input>s can contain several semantic forms (e.g. a search field, sign-in form, sign-up form). The server side classifiers may apply special heuristics for the <form>less forms. Bug: 552420, 910546 Change-Id: If4a5ec04eb1c0d87ec3a8cd399d84e3f5c31a692 Reviewed-on: https://chromium-review.googlesource.com/c/1394583 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#619772}
-
Antonio Gomes authored
This is a follow up CL to [1], that addresses post-land feedback from blundell@. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1387393/6#message-5b6d62524d8612f8d9b11bd7500af41f4f10cc76 BUG=890811,890812 Change-Id: Ie01be10511872dca5b053d20386559d2975e4bff Reviewed-on: https://chromium-review.googlesource.com/c/1391688Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#619771}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9fa54eab2590..f83a28a6880a git log 9fa54eab2590..f83a28a6880a --date=short --no-merges --format='%ad %ae %s' 2019-01-03 syoussefi@chromium.org Vulkan: Shader path for framebuffer-to-texture copy 2019-01-03 syoussefi@chromium.org Vulkan: optimize image layout transitions 2019-01-03 jmadill@chromium.org Free OSWindow and EGLWindow through helpers. Created with: gclient setdep -r src/third_party/angle@f83a28a6880a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I5e6a64832751aef446706f12e5cc2761eab617d0 Reviewed-on: https://chromium-review.googlesource.com/c/1394691Reviewed-by:
-
Michael Warres authored
Merge internal change: 222419106 R=zhongyi@chromium.org Change-Id: I78b6a3cc500b4e9b72a135f1c346373d89faf33d Reviewed-on: https://chromium-review.googlesource.com/c/1394007Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#619769}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/943e9fdb7885..5823360bf2c2 Created with: gclient setdep -r src-internal@5823360bf2c2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I190993a33d3aab1abc300efabf6469786415368c Reviewed-on: https://chromium-review.googlesource.com/c/1394688Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619768}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/31c4bcb210bd..8b0f9d18ddf8 git log 31c4bcb210bd..8b0f9d18ddf8 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 mtklein@google.com tear down one-big-switch SkRasterPipeline backend 2019-01-03 reed@google.com rm legacy FontMetrics from docs 2019-01-03 reed@google.com remove legacy fontmetrics flag Created with: gclient setdep -r src/third_party/skia@8b0f9d18ddf8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ib9eae17be5535959faa2403b60ecf2efb9eeac8f Reviewed-on: https://chromium-review.googlesource.com/c/1394687Reviewed-by:
-
Nate Fischer authored
This publicly documents WebView's long-standing support for commandline flags, detailing any caveats. R=ctzsm@chromium.org, tobiasjs@chromium.org Bug: 918221 Test: None Change-Id: I43f50ea7d481bd7b578b08f03dcb5737cc786469 Reviewed-on: https://chromium-review.googlesource.com/c/1392364 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#619766}
-
rbpotter authored
This code was only used by the old UI, which has now been deleted. Bug: None Change-Id: I5843714287a8b7461195d7be893ece4d1b0ad6b2 Reviewed-on: https://chromium-review.googlesource.com/c/1394738Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#619765}
-
Khushal Sagar authored
The GrShaderCache::ScopedCacheUse needs to be acquired when using the GrContext to scope the cache's use to a single client. Add it for the overdraw_ddl draw in SkiaOutputSurface. R=ericrk@chromium.org Change-Id: I6849deed684fa486b0a44bb227ce04217b62cafc Reviewed-on: https://chromium-review.googlesource.com/c/1394348 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619764}
-
Daniel Murphy authored
This reverts commit 97ba6ddb. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable WebViewTest.Shim_testFindInMultipleWebViews on Windows > > Due to flakiness. > > TBR=ekaramad@chromium.org > > Bug: 892085 > Change-Id: I96d8a3b14583c340abba18a725941b8ae0c1cf06 > Reviewed-on: https://chromium-review.googlesource.com/c/1261700 > Commit-Queue: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596682} TBR=msramek@chromium.org,ekaramad@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 892085 Change-Id: I8b417d49cef605a3dd734886332ac70b1f53d8d7 Reviewed-on: https://chromium-review.googlesource.com/c/1394869Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#619763}
-
Ramya Nagarajan authored
The emoji context menu has been enabled by default on Win, Mac and CrOS since M70. This cleans up existing feature flags and test that rely on them. Bug: 827404 Change-Id: I40321c4e2ea91affeed017d875df6a870de4d494 Reviewed-on: https://chromium-review.googlesource.com/c/1393823Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#619762}
-
Kenneth Russell authored
The Vulkan driver doesn't seem properly installed on these machines. Will re-enable once it is. Bug: 918942 Change-Id: I0f3ceeead53d10ce0ffbbb1ed017dcc521172cba No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/1394917Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619761}
-
John Delaney authored
This is a reland of 7c6d18ba Original change's description: > Migrate AdsPageLoadMetricsObserver to ResourceDataUse over OnLoadedResource > > This CL is strictly a refactor that switches the Ads PLMO to count frame > data using ResourceDataUseUpdate instead of OnLoadedResource. This will > allow us to include incomplete resources and header bytes in future > per-frame metrics. This will not change behavior of existing histograms > at all. > > Bug: 878393 > Change-Id: Ibb235c11bbaa168a40be51bc99c03a0ba999c251 > Reviewed-on: https://chromium-review.googlesource.com/c/1372428 > Commit-Queue: John Delaney <johnidel@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619436} TBR=rsesek@chromium.org Bug: 878393 Change-Id: I9c8760497d2a5110f4bae31d633d82a405ed812a Reviewed-on: https://chromium-review.googlesource.com/c/1393530 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619760}
-
Andrew R. Whalley authored
Change-Id: Id6fed6762afce61a9860eb930fb2dc4a4349b001 Reviewed-on: https://chromium-review.googlesource.com/c/1394787Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Andrew Whalley <awhalley@google.com> Cr-Commit-Position: refs/heads/master@{#619759}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/241644a5a398..a900bacb58c3 git log 241644a5a398..a900bacb58c3 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 33432579+alan-baker@users.noreply.github.com Broader check for ids that require a type (#2259) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@a900bacb58c3 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7100e6bb7e09f4fed3254512eaca7c15a982309b Reviewed-on: https://chromium-review.googlesource.com/c/1394866Reviewed-by:
-
Adithya Srinivasan authored
Adds IDL files for PortalHost and window.portalHost, and has a simple layout test for window.portalHost. Bug: 914117 Change-Id: Iccaae8992e7cf2794a26e171cebffc94deca8e1d Reviewed-on: https://chromium-review.googlesource.com/c/1393438Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#619757}
-
Bailey Berro authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/44b6331b895d..825055dd8383 $ git log 44b6331b8..825055dd8 --date=short --no-merges --format='%ad %ae %s' 2018-12-26 cmtm system_api: remove support for creating arcbridge socket in session_manager 2018-12-14 jimmyxgong smbprovider: Add UpdateMountCredentialsOptionsProto 2018-12-27 itspeter system_api: add more fields for generic_storage in runtime_probe Created with: roll-dep src/third_party/cros_system_api Change-Id: I6ef9f2e47665adf5c69329d3807a8345b0fe71a6 Reviewed-on: https://chromium-review.googlesource.com/c/1394785 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#619756}
-
Max Moroz authored
Bug: 790747 Change-Id: I4bbae28a27174ce1d2e53ad356aba7726d16c228 Reviewed-on: https://chromium-review.googlesource.com/c/1394597Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#619755}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/35caab8b839f..2667a52a4bde git log 35caab8b839f..2667a52a4bde --date=short --no-merges --format='%ad %ae %s' 2019-01-03 dtu@chromium.org [dashboard] Remove deprecated bots from bot list. Created with: gclient setdep -r src/third_party/catapult@2667a52a4bde The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:865016 TBR=sullivan@chromium.org Change-Id: I6f0bb6113242fe3f1351244a805f056a12469518 Reviewed-on: https://chromium-review.googlesource.com/c/1394872Reviewed-by:
-
edchin authored
A previous CL changed the snapshot API contract to return nil instead of a default white image. Due to the change, all snapshot containers should have an opaque default white background color. The previous CL missed this one snapshot container. Change-Id: I659a6511dd0b83a0e0d20e1e49e0bb752522c289 Reviewed-on: https://chromium-review.googlesource.com/c/1394708Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#619753}
-
Rohit Rao authored
BUG=911350 Change-Id: Iec791dc2bf41b10705686bf01bbadc39ccee9e9d Reviewed-on: https://chromium-review.googlesource.com/c/1394013Reviewed-by:
-
Peter Kotwicz authored
This CL removes the useless intent parameter in ExternalNavigationDelegateImpl#matchResolveInfoExceptWildCardHost(). The parameter became useless as a result of https://chromium-review.googlesource.com/c/chromium/src/+/1096554/ BUG=None Change-Id: Iaf493fa288a16a22a52d30ead5884ab2e8164f73 Reviewed-on: https://chromium-review.googlesource.com/c/1390321 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619751}
-
Jamie Madill authored
This should help prevent flaky tests from landing in the tree. Also includes a minor cleanup where the test suite keys in the entries for ANGLE tests are sorted alphabetically. Bug: angleproject:3029 Change-Id: I19420d3f716d44ded44db39b185aa947c06110f4 Reviewed-on: https://chromium-review.googlesource.com/c/1394795Reviewed-by:
-
Philip Rogers authored
When deciding whether an overflow clip paint property node is needed, we previously checked if the visual overflow extended beyond the overflow clip rect. This would miss cases when the visual overflow was empty (e.g., descendants with width: 0) but the content was still scrollable. This patch adds a check for layout overflow. While in the area, the condition for visual overflow has been refactored to make the self-painting PaintLayer case a little clearer. The early-out for PaintLayer descendants is required for correctness. Bug: 918675 Change-Id: I41fe5fd71a957f196b5b8095965d4e361e535196 Reviewed-on: https://chromium-review.googlesource.com/c/1393885Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619749}
-
Leonard Grey authored
One might ask: why do even have this lever? I agree, so I filed https://crbug.com/918911 Bug: 918194 Change-Id: I0ea816a50d840e71bc6f8c5684877c8353cb0c11 Reviewed-on: https://chromium-review.googlesource.com/c/1394734Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619748}
-
Becca Hughes authored
This is a reland of 858e896d Original change's description: > [Audio Focus] Restrict browser group to CrOS > > Restrict browser audio focus grouping to Chrome OS. > > BUG=915501 > > Change-Id: I702952cca7a388e78c201531866307797d25b277 > Reviewed-on: https://chromium-review.googlesource.com/c/1379918 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#617800} Bug: 915501 Change-Id: Ideb9814a6d4ff7e9faedc66efa6d2073adec818d Reviewed-on: https://chromium-review.googlesource.com/c/1386107Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#619747}
-
Tommy Steimel authored
The test is also failing on Retina builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Mac10.13%20(retina)/8631 Bug: 917970 Change-Id: I3de376948ec19cfc4a83c58dd28b5bde04fd3f95 Reviewed-on: https://chromium-review.googlesource.com/c/1394868 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#619746}
-
