- 18 Oct, 2018 40 commits
-
-
Daniel Bratell authored
Not all sources lists have been kept up to date with code movement/removal and it seems to make some isolate steps in cq sad for some CLs (mine). Change-Id: I5bfe35139a41ab5d88aca564b1f7a2ded5ebab06 Reviewed-on: https://chromium-review.googlesource.com/c/1288971 Commit-Queue: Daniel Bratell <bratell@opera.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#600818}
-
Daniel Bratell authored
Not all sources lists have been kept up to date with code movement/removal and it seems to make some isolate steps in cq sad for some CLs (mine). R=haraken@chromium.org Change-Id: I2657e05f5df6079f4b493ea9a7df8ee6bbdbf544 Reviewed-on: https://chromium-review.googlesource.com/c/1288970Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#600817}
-
Dave Tapuska authored
Use wtf_size_t where appropriate. BUG=879657 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5c7cfc6692919d552cdee6deb681ff046177ccf7 Reviewed-on: https://chromium-review.googlesource.com/c/1287189 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Steven Bennetts authored
Bug: 843332 Change-Id: I490987e866fef3aa86151a990bc623e4e2ed6429 Reviewed-on: https://chromium-review.googlesource.com/c/1285322 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#600815}
-
Vladimir Levin authored
This patch adds a callback queue to display locking context in order to process scheduled tasks in the correct order. Currently the behavior is: - Put callbacks in a queue, and post a task to run them. - While running the task, process all callbacks in the existing queue - If any of the callbacks schedule a _new_ callback, then they go into a new queue, and a new task is scheduled to run them. R=chrishtr@chromium.org Bug: 882663 Change-Id: I41dfc756bb5585d33da85746054a42cc7f5072ef Reviewed-on: https://chromium-review.googlesource.com/c/1277696 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600814}
-
Adrienne Walker authored
This was flaky, but should be fixed. Bug: 878258 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3e037e41339ddff9d46ec0a7ca7679064a3322e0 Reviewed-on: https://chromium-review.googlesource.com/c/1285526Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#600813}
-
Ben Pastene authored
It's got the same bot pool size as the linux version of it, so jumping from 0 to 50% should be safe. The bot should be good to go once https://chromium-review.googlesource.com/c/chromium/tools/build/+/1287370 lands. Bug: 893614 Change-Id: Ib6abc77bec199866dacadc0078afd50df387d0c8 Reviewed-on: https://chromium-review.googlesource.com/c/1287432Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#600812}
-
Xianzhu Wang authored
The content box rect was improperly snapped in the local space. We should snap in the layout space instead, including subpixel accumulation. This is a duplicate of trchen@'s old CL https://codereview.chromium.org/2172503002/ rebased on the current trunk. Bug: 627683 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I737871c4bafead28f1040d486a59f3203c0b0ead Reviewed-on: https://chromium-review.googlesource.com/c/1271582 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd254486280d..0c583af06d50 git log dd254486280d..0c583af06d50 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 jvanverth@google.com Widen internal API to support more complex YUV formats 2018-10-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b83d4911baae..e70c3514e5a0 (1 commits) 2018-10-18 kjlubick@google.com Add forgotton comma 2018-10-18 mtklein@google.com trim off more bgra stages 2018-10-18 kjlubick@google.com [canvaskit] Increase timeout thresholds for perf 2018-10-18 brianosman@google.com Reland "Remove SK_LEGACY_XFORM_CANVAS_IN_PICTURE_IMAGES" 2018-10-18 kjlubick@google.com [canvaskit] Slice out SkPicture 2018-10-18 mtklein@google.com eliminate srcover_bgra_8888 2018-10-18 mtklein@google.com make gray8 support uniformly weird 2018-10-18 caryclark@skia.org allow bookmaker methods to auto-populate Created with: gclient setdep -r src/third_party/skia@0c583af06d50 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I9f6b2649f1483b48572fbf4be7bcd0d3dfcf77e0 Reviewed-on: https://chromium-review.googlesource.com/c/1287897Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600810}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9aa14a38f434..0e68bb36327c git log 9aa14a38f434..0e68bb36327c --date=short --no-merges --format='%ad %ae %s' 2018-10-18 stevenperron@google.com Only run merge-returnon reachable functions. (#1983) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@0e68bb36327c The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie1f3d46701dcd62c7c60a3700298dcaaf83d250e Reviewed-on: https://chromium-review.googlesource.com/c/1288679Reviewed-by:
-
Xiaohan Wang authored
- Use AomVideoDecoder in ClearKeyCdm to support AV1 decoding. - Add encrypted AV1 test files in media/test/data. - Add browser tests to test playback of encrypted AV1 in WebM and MP4 using Clear Key key system and External Clear Key key system. Bug: 884898 Test: New test cases added. Change-Id: I201b47d8261ddc2d68bbcd90c0fd265612133c3e Reviewed-on: https://chromium-review.googlesource.com/c/1286201 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#600808}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/09beff2cfd84..78416b6e1851 git log 09beff2cfd84..78416b6e1851 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 srte@webrtc.org Adds time to initial config in analyzer code. 2018-10-18 ilnik@webrtc.org Correctly slice MediaBitrateRecieved on content type in ReceiveStatisticsProxy 2018-10-18 srte@webrtc.org Adds field trial to AudioPriorityBitrateAllocationStrategy. 2018-10-18 peah@webrtc.org AEC3: Introduce partial adaptive filter resets at echo path changes 2018-10-18 peah@webrtc.org AEC3: Remove ERLE uncertainty code that has no effect 2018-10-18 kwiberg@webrtc.org Relieve perkj@ of some OWNER duties 2018-10-18 mbonadei@webrtc.org Remove expat from generate_licenses.py. 2018-10-18 tzik@chromium.org Add missing #include to absl/memory/memory.h 2018-10-18 mbonadei@webrtc.org Export symbols needed by the Chromium component build (part 4). 2018-10-18 kwiberg@webrtc.org rtc::ZeroOnFreeBuffer: Don't forget to zero memory we free in operator= 2018-10-18 titovartem@webrtc.org Fix: Argv may be corrupted after InitGoogleMock found any related flags 2018-10-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c926d3bb..fc405b49 (600547:600654) 2018-10-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8bef2e26..c926d3bb (600433:600547) 2018-10-17 shampson@webrtc.org Adds support for "-" to a=ssrc msid lines. 2018-10-17 sukhanov@webrtc.org Reland "Reland "Propagate media transport to media channel."" 2018-10-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c5242283..8bef2e26 (600305:600433) 2018-10-17 benwright@webrtc.org Adds new CryptoOption crypto_options.frame.require_frame_encryption. 2018-10-17 terelius@webrtc.org Track padding and header size in log event. 2018-10-17 srte@webrtc.org Adds AudioNetworkAdaptation support to Scenario tests. Created with: gclient setdep -r src/third_party/webrtc@78416b6e1851 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:895838,chromium:none,chromium:896154,chromium:752720,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Id10b9aa1d178aca162bff37878204e3bf770c15a Reviewed-on: https://chromium-review.googlesource.com/c/1287895Reviewed-by:
-
Wez authored
The fdio/socket.h header is unused, and an upcoming SDK roll will remove it, so remove it from our hand-rolled build-rules. Change-Id: I84260f09778daac364fd217198292b3272cf38a4 Reviewed-on: https://chromium-review.googlesource.com/c/1287294 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#600806}
-
Becky Zhou authored
Bug: 887697 Change-Id: I447d1691ae765a3fbad6a9ddae7bc583f287610a Reviewed-on: https://chromium-review.googlesource.com/c/1287048 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#600805}
-
Jacob Dufault authored
This reverts commit 92eb6fcb. Reason for revert: Policy change got approval which makes this CL unnecessary Original change's description: > cros: Temporarily allow fingerprint on nocturne. > > Bug: 896458 > Change-Id: I774285cd49260e227a57cd8d786ba2b31efd08ad > Reviewed-on: https://chromium-review.googlesource.com/c/1286666 > Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600594} TBR=jdufault@chromium.org,wzang@chromium.org Change-Id: I39013e6fc3a62f96a792865b43a9270b9fd61069 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896458 Reviewed-on: https://chromium-review.googlesource.com/c/1289074Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#600804}
-
Andrey Kosyakov authored
We want to maintain a deterministic order of agent enumeration. Change-Id: Iac18573342cfb3cc6dbff305b0d64cfd00a13b78 Reviewed-on: https://chromium-review.googlesource.com/c/1287096Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#600803}
-
Becca Hughes authored
Adds resume to the Media Controller mojo interface. Also adds a ToggleSuspendResume method to make it easier to toggle play/pause. BUG=893296 Change-Id: Ib9615d3c93909ca24e0eec0b4d6e690c186703dc Reviewed-on: https://chromium-review.googlesource.com/c/1272081 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#600802}
-
Kyle Milka authored
The histogram was lost during refactoring to support WebView variations. Bug: 896699 Change-Id: I011f137205213c773b4f9d84fe18e083cd864812 Reviewed-on: https://chromium-review.googlesource.com/c/1288969 Commit-Queue: Kyle Milka <kmilka@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#600801}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 894598 Test: none Change-Id: I85bfe11dda29295d45c609851222bd40fff98ef7 Reviewed-on: https://chromium-review.googlesource.com/c/1283486 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#600800}
-
Becca Hughes authored
Add a MediaController that can be used to proxy commands to a MediaSession. Also adds a MediaControllerFactory for creating them over mojo. BUG=893296 Change-Id: I82a7cb5798094486a28517dc5a18112ec8d14871 Reviewed-on: https://chromium-review.googlesource.com/c/1269623Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#600799}
-
Steven Bennetts authored
The CL: * Introduces keyboard.mojom.KeyboardEnableState, an enum used to track the various states that control whether the virtual keyboard should be enabled. Some states enable the keyboard, others disable it. * Moves ownership of the states and the state machine to determine when the keyboard should be enabled to KeyboardController. * Adds mojo interfaces to set and clear states, get the current enabled state, and explicitly reload the keyboard. Note: All mojo API calls to change an enable state will also enable or disable the keyboard accordingly. This is consistent with existing logic where these calls are made so should not change any behavior. Note: Not all calls to keyboard_util.cc helpers have been replaced, including a few in src/chrome, only places where no additional re-factoring is required were changed. Bug: 843332 Change-Id: I64aad28f0c630ce5d37cab0e5ccfe40013078356 Reviewed-on: https://chromium-review.googlesource.com/c/1275132 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch simplifies DirtyLinesFromChangedChild in that: 1. Clearing FirstInlineFragment for all descendants do not seem necessary any longer. It turned out that this makes reusing line boxes harder, and not doing so doesn't fail any tests. 2. MarkLineBoxesDirtyFor checks PaintFragment, so checking here does not seem necessary. Not checking can avoid traversing to its containing block. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4d485f47731355c88a554d18843c3722f822e89a Reviewed-on: https://chromium-review.googlesource.com/c/1288174 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600797}
-
Rune Lillesveen authored
This simplifies invalidation of attribute changes affecting attr() content from always invalidating for attributes used in attr() on all elements, to always invalidating with kLocalStyleChange for attr changes on elements which have ::before/::after content generated from attr(). This means we don't need to block lazy parsing for ::before/::after and we will respond correctly to attr() used indirectly via var(). Bug: 791525 Change-Id: I13878a56ecf11eb3bd9da356128ac0f32dd5b62d Reviewed-on: https://chromium-review.googlesource.com/c/1288274 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#600796}
-
Adam Langley authored
hmac-secret[1] allows a token to provide a random oracle. However, it must be asserted during registration to be used with a credential. This changes adds registration-time-only support for this extension. [1] https://fidoalliance.org/specs/fido-v2.0-rd-20180702/fido-client-to-authenticator-protocol-v2.0-rd-20180702.html#sctn-hmac-secret-extension Change-Id: Icac9b221f77c0bd0941563440321facd530d4aa0 Reviewed-on: https://chromium-review.googlesource.com/c/1266835Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#600795}
-
Tanja Gornak authored
Bug: 895080 Change-Id: I131b9dd086f4a935552ac288cc4f690fd9f7ba16 Reviewed-on: https://chromium-review.googlesource.com/c/1278762 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#600794}
-
Etienne Pierre-doray authored
Usage of AssertBlockingAllowed outside of base:: is being replaced by ScopedBlockingCall. This CL puts AssertBlockingAllowed() into base::internal and adds AssertBlockingAllowedDeprecated for compatibility with current usage. This is a purely mechanical change with no side-effects. TBR=fdoray@chromium.org Bug: 874080 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2b482a5ca217a563052dcae4afc45553626aa3d3 Reviewed-on: https://chromium-review.googlesource.com/c/1278540 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#600793}
-
Ryan Hansberry authored
Bug: 895937 Change-Id: I7eec1edce0fe9dd2c8e444b51dcd81fe34bcc1ed Reviewed-on: https://chromium-review.googlesource.com/c/1287433Reviewed-by:
-
Joe Downing authored
This reverts commit 43116fdd. Reason for revert: Causing multiple failures on the linux-chromeos-dbg builders: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8932319379574593136/+/steps/browser_tests/0/logs/CrSettingsInternetDetailPageTest.InternetDetailPage/0 Original change's description: > Disable editing managed network config fields. > > * Disable network configuration field if the field is enforced by policy. > * Add policy network indicator if the field is controlled by policy. > > Bug: 877424 > Change-Id: Icfdb6d7fb3deb09696b6d2edce27d3c9851043a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1251447 > Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600735} TBR=stevenjb@chromium.org,hendrich@chromium.org,nikitapodguzov@google.com Change-Id: Ib787c57ca39873750807076e09b5a2b50ed7230b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877424 Reviewed-on: https://chromium-review.googlesource.com/c/1288898Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#600791}
-
Yuri Wiitala authored
Filters mute toggling from being counted in the "device change UMAs," to provide an apples-to-apples comparison with the counts in in the legacy media::AudioOutputController code paths. It filters on the "reason" for stream re-creation to ensure measurements are taken iff they would be taken in the legacy code paths. Side note: This is not exactly what we *should* be measuring (i.e., it is filtering out too much in some cases, and double-counting others). However, it should be sufficient to prove that stream creation counts/ timing in the new Audio Service is on-par with the legacy code paths. This is discussed further in fix-it bug 8964843. Bug: 896431, 896484, 866455 Change-Id: I677aaf5b485ffa8e605668a87b9bdc06cd3c1ae3 Reviewed-on: https://chromium-review.googlesource.com/c/1287256Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600790}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bad9daf2..fc50b795 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I48cca61759ee0a79b921edd7a8151eedd037df96 Reviewed-on: https://chromium-review.googlesource.com/c/1288711Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600789}
-
Christian Biesinger authored
ComputeOverflow already calls these functions Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I1af510148708078689fb421a750ae8d2eb82087a Reviewed-on: https://chromium-review.googlesource.com/c/1287249Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#600788}
-
Bo Liu authored
This CL only moves onPageStarted of *renderer initiated* navigation to navigation commit. Browser initiated navigations are not changed. WebContentsObserver.didFinishNavigation is navigation commit, which is where onPageStarted of successful navigation is called. On error, onPageStarted is called from AwContentsClientBridge.onReceivedError. In order to distinguish between browser-initiated and renderer-initiated navigations, need to plumb the bool to all of these call sites. * Add new parameter to java WebContentsObserver.didFinishNavigation which requires updating a bunch of overrides. * Add isRendererInitiated to java NavigationParams. * Use ui::PageTransitionIsWebTriggerable to approximate renderer-initiated. New bool in AwWebResourceRequest is optional because there are code paths that do not have this information, and do not need it. Other changes: * Update WebContentsObserverProxy::DidFinishNavigation to return the base url if it is not empty. This ensures the new onPageStarted uses the same url as before. * Change LoadUrl calls to PageTransition.TYPED. This matches expectation better and make ui::PageTransitionIsWebTriggerable work. * Do not call didFailLoad, which calls onPageFinished, if navigation did not commit. This can happen for downloads. * Also add isDownload to WebContentsObserver.didFinishNavigation. This is important for suppressing onPageStarted and onPageFinished for downloads due to content-disposition: attachment * Add tests for all of the cases discussed here Bug: 896022 Change-Id: Ia30f733a9f4b0684683fe5594305a72b611f0442 Reviewed-on: https://chromium-review.googlesource.com/c/1270096Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600787}
-
Clark DuVall authored
This implements the DRP logic for only using CORE proxies when proxying RESOURCE_TYPE_MEDIA requests. A similar approach is used to DataReductionProxyDelegate, which uses an MRUCache to associate URLs to resource type during proxy resolution, since the ProxyDelegate only has access to the URL. Bug: 721403 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ib1c50dbc1344535e46c80b2d3a900dbb6b215141 Reviewed-on: https://chromium-review.googlesource.com/c/1274526 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#600786}
-
Daniel Rubery authored
There are two problems with the CheckClientDownloadRequest that this CL takes steps towards resolving. First, the control flow of the CheckClientDownloadRequest is very difficult to follow due to a large number of private helper methods. Secondly, it uses several techniques to prevent use-after-free (ref-counting, weak pointers, and cancellable tasks). This CL encapsulates the logic that was in CheckClientDownloadRequest that was related to analyzing the content of the file into a singly-owned class, so that those two concerns can be more easily addressed. TODO: The FileAnalyzer still needs to be tested for RAR files. Bug: 889986 Change-Id: I81c02bd3491c116a949dc959f2f02208511209bd Reviewed-on: https://chromium-review.googlesource.com/c/1272275 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#600785}
-
danakj authored
Currently it is part of WebWidgetClient, but it is a global value for the ChromeClient-Page-WebView rather than a value per widget/frame. In the future we can move this to a separate IPC routed to the RenderView instead of the RenderWidget. R=avi@chromium.org, dcheng@chromium.org Change-Id: I7d10fc56e31d163fb8476b85c987f0122a7b1eb6 Bug: 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1279243 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#600784}
-
Steven Bennetts authored
ChromeKeyboardControllerClient is going to need to keep track of when the KeyboardController is (actually) enabled and disabled. This CL: * Replaces the KeyboardControllerObserver::OnKeyboardDisabled with a more generalized OnKeyboardEnabledChanged. * Replaces the (poorly named) mojom::KeyboardControllerObserver:: OnKeyboardWindowDestroyed with OnKeyboardEnabledChanged. * Eliminates the now redundant VirtualKeyboardControllerObserver with KeyboardControllerObservers, reducing overall complexity. * Modifies exo/keyboard.cc to directly observe keyboard::KeyboardController instead of ash::VirtualKeyboardController and ash::AccessibilityController. For minor change to test_suites.pyl: TBR=bpastene@chromium.org Bug: 843332 Change-Id: I808c1f4ca3e732aa9b606810caa12533b9da8158 Reviewed-on: https://chromium-review.googlesource.com/c/1285329Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Kevin McNee authored
I previously made the DCHECK in WebGestureEvent::NeedsWheelEvent more strict, but overlooked these callers. Here we update these remaining callers so that they won't hit the DCHECK. Bug: 787924, 802369 Change-Id: I65ae2dc873b25d0a3d770f2581a278b06ce7e7d8 Reviewed-on: https://chromium-review.googlesource.com/c/1286767Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#600782}
-
Colin Blundell authored
Forgot to do this (again) in the CL converting away from these utils. TBR=droger@chromium.org Bug: 896180 Change-Id: I3845417f5884d5adfb048d919931a6e021221e6f Reviewed-on: https://chromium-review.googlesource.com/c/1288869Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#600781}
-
Allen Webb authored
This needs to be enabled by Finch instead of disabled by finch. This in principle reverts but revision exceptions were blocking the merge: https://chromium-review.googlesource.com/1176475 BUG=chromium:889118 Change-Id: I401312d32188ff6a0fd97b7fe8838b4371521b95 Reviewed-on: https://chromium-review.googlesource.com/c/1288709 Commit-Queue: Allen Webb <allenwebb@google.com> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#600780}
-
Robert Ogden authored
There's a few bug fixes in this CL but it seems ok to lump them together since each bug is in a separate file. CustomTabActivity.java - don't show AMP UI on a Preview ToolbarManager.java - also update Previews UI on commit ToolbarModel.java - explicity remove the scheme from Previews Bug: 896478 Change-Id: Id8353a8787481bf4fcbfa322994d8b0ec998d6df Reviewed-on: https://chromium-review.googlesource.com/c/1287289 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
