GitLab

This CL removes the use of the ConditionVariables inside VaVDA and
uses instead PostTask()ing. This removes blocking the worker
thread, which allows for moving other tasks there, e.g. the
Surface Blit (as done in the follow up WIP CL crrev.com/c/947341)

For all that goodness, this CL:

- Refactors the waiting logic that on ToT is spread between
 GetCurrInputBuffer_Locked() and WaitForSurfaces_Locked() and
 simplifies it in DecodeTask() itself.

- Moves the |curr_input_buffer_| filling logic in
 GetCurrInputBuffer_Locked() into DecodeTask() proper.

- Reduces the scoped of the |lock_| in DecodeTask() (note that
 |curr_input_buffer_| and |decode_| are only used on the decoder
 thread -- added a .h comment).

Minor stuff: This CL also moves together the declaration of the
related member vars |input_buffers_|, |curr_input_buffer_| and
|available_va_surfaces_|

TEST=simplechrome+crosvideo (including seeks) on soraka, and
v_d_a_unittest with h264, vp8, vp9 (with dcheck_always_on=true).

Bug: 717265
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib167115dd2a4ebaeaea3ba3b5a205779d659f479
Reviewed-on: https://chromium-review.googlesource.com/949283
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542955}

Bug: 796300
Change-Id: Ib76be47f5a9727ec5d7f5995a83e1f671811b9f1
Reviewed-on: https://chromium-review.googlesource.com/954608
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542954}

This is a reland of f70764f0

Original change's description:
> Adds a class that encapsulates a range in Blink's accessibility tree.
> 
> This is just a basic class that can convert from a DOM selection to an AX range and vice versa. It can also perform a selection on the AX range.
> This class doesn't still handle any of the many corner cases that I will be looking at next, cases that will be covered by tests.
> R=dmazzoni@chromium.org
> 
> Bug: 
> Change-Id: I7c98617e8ef3b8bcca8cfc0d2e5518f2da771063
> Reviewed-on: https://chromium-review.googlesource.com/678016
> Commit-Queue: Nektarios Paisios <nektar@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542619}

Change-Id: I8c6badcc06ad4b012ac73d69ca9e64c921353601
Reviewed-on: https://chromium-review.googlesource.com/959431Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542953}

This change adds a SmbFileSystem::GetWeakSmbProviderClient() method for
getting a weak_ptr to the SmbProviderClient singleton. This weak_ptr will
be used for posting tasks in the form of base::OnceClosure to the SmbTaskQueue.

Bug: chromium:757625
Change-Id: I4e10bfd3b10a243cc65303a15e8f2e1249d1560b
Reviewed-on: https://chromium-review.googlesource.com/957307
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542952}

This change switches SmbProviderClient to using base::SupportsWeakPtr
and SmbProviderClientImpl to using a helper class that wraps it
instead of a manually implemented WeakPtrFactory.

Bug: chromium:757625
Change-Id: I18f3b04c18ba28bdf8bf9c356b3ebeb98d546cd3
Reviewed-on: https://chromium-review.googlesource.com/956417
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542951}

This CL adds calls to track when WebMediaPlayerMS is hidden or shown, so
that in the time period we can skip creating GMB backed frames. For that
time period, frames aren't going to be displayed, so copying them to GMBs
is extra work which should be avoided.

Bug: 653200
Change-Id: I67e55c7f1150b434d82321ac90a08c7c3e3e6336
Reviewed-on: https://chromium-review.googlesource.com/954339Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542950}

Bug: 818198
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I436c573c55149b9becfc4b83b3904e2973e0480b
Reviewed-on: https://chromium-review.googlesource.com/961123Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542949}

The aura::Window LocalSurfaceId is updated after device scale factor
change via
- aura::Window::OnDeviceScaleFactorChanged, which is called by
- ui::Layer::OnDeviceScaleFactorChanged, which is called by
- ui::Compositor::SetScaleAndSize

But ui::Compositor::SetScaleAndSize takes the aura::Window's
LocalSurfaceId as a parameter.

This means that ui::Compositor::SetScaleAndSize's LocalSurfaceId
argument will be incorrect any time that the DeviceScaleFactor
changes.

Note that the way that aura::Window updates its LocalSurfaceId for
bounds' changes is different. It does not implicitly update the
bounds of its root layer, rather, it requires that the root layer's
bounds be updated before calling ui::Compositor::SetScaleAndSize.

Add a function aura::Window::SetDeviceScaleFactor, to match
aura::Window::SetBounds, which will update the layer's properties
and cause the generation of a new LocalSurfaceId. Make this call in
WindowTreeHost::UpdateRootWindowSizeInPixels (next to the corresponding
call to aura::Window::SetBounds).

Bug: 818085
Change-Id: I929a6e641aa3aa1253e99647ce3bfe05ca7c482a
Reviewed-on: https://chromium-review.googlesource.com/961450
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542948}

https://chromium.googlesource.com/catapult.git/+log/4d4ed66a74c4..565a74556b27

$ git log 4d4ed66a7..565a74556 --date=short --no-merges --format='%ad %ae %s'
2018-03-12 dtu [pinpoint] Make "benchmark" argument required on try dialog.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I3a6a233a3c815134c4bd6dff4281357e5c17419d
Reviewed-on: https://chromium-review.googlesource.com/961458
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542947}

Button and LabelButton have prescribed behaviors which one does not
need to re-implement when using them. One can instead use the
end-result event reporting, done through the method, StateChanged().
This CL leverages that method, and removes all its OnMouse methods.

This CL includes other minor clean-up, such as adding a SetHovered()
method, removal of unused methods and making methods private which
can be.

Bug: 780835
Change-Id: I1fa46ba22a4e02096bcacd79edf1c685fcee7ba5
Reviewed-on: https://chromium-review.googlesource.com/943599
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542946}

PowerEventObserver delays display suspend until lock screen UI is shown
and compositors submit enough frames to know the UI changes have reached
displays.
This does not account for wallpaper changes due to screen lock:
  * On screen lock, the active wallpaper will be changed with its blurred
    version.
  * If screen lock changes the active user (e.g. if the screen is locked
    from the secondary user), the wallpaper will change to the new
    active user's blurred wallpaper.
Given that PowerEventObserver does not ensure wallpaper switch is done
before it stops drawing to the display, the first frame shown on the
device resume might still contain the UI from before wallpaper change.

This changes PowerEventObserver to additionally wait for any active
wallpaper changes (which can be detected by checking
WallpaperWidgetController::IsAnimating - set while wallpaper widget is
being changed) to finish before it starts waiting for compositor frames
to get composited, thus ensuring the correct wallpaper is set when the
display/compositing is suspended.

Adds the following methods to WallpaperWidgetController:
  * AddPendingAnimationEndCallback - to provide a way for
    PowerEventObserver to get notified when the pending wallpaper change
    completes
  * EndPendingAnimation which can be used to force immediate wallpaper
    change when device starts suspending (and prevents suspend flow from
    being blocked on unnecessarily waiting for new wallpaper animation)

BUG=820436,803762

Change-Id: Iad2074280ebba740b95c50b9d60a028bf5a0d45c
Reviewed-on: https://chromium-review.googlesource.com/956757Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542945}

These tests click on the Views browser window's location bar
icon to display the Page Info Bubble. Unfortunately, that
does not exists on polychrome so this CL will just directly
show the page info bubble.

Bug: 817408
Change-Id: I40c526ef95021dd8b656277a9bc9f360567e8788
Reviewed-on: https://chromium-review.googlesource.com/959434
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542944}

Using wpt-import in Chromium 7660af56.
With Chromium commits locally applied on WPT:
ad9cc156 "Add WPT tests for feature policy frame policy"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13834

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=leon.han@intel.com

No-Export: true
Change-Id: I31d22ffcf637f7198615cf93a64e7ed75f119ca1
Reviewed-on: https://chromium-review.googlesource.com/961447
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542943}

This is needed to land a Beta channel finch config for this study.

Bug: 776847
Change-Id: Ied77a7ad58e6d1f7d75ea1502eac982bdec834fd
Reviewed-on: https://chromium-review.googlesource.com/959611Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542942}

https://chromium.googlesource.com/angle/angle.git/+log/4ea3b4505abb..aac6df40a2b5

$ git log 4ea3b4505..aac6df40a --date=short --no-merges --format='%ad %ae %s'
2018-03-12 geofflang Update documentation to mention ANGLE committer status and bug editing permissions.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I1c4003a0b2ec1c627d94794601f75c41cdb38431
Reviewed-on: https://chromium-review.googlesource.com/961422
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542941}

This cl adds UMA for Launcher folder show/hide animations.

Bug: 821160
Test: Tested on eve and minnie with added UMA.
Change-Id: I8771df817445caa92900f66750ce4675c0150492
Reviewed-on: https://chromium-review.googlesource.com/959559Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542940}

Upstream cfi-icall fixes to sqlite have landed such that it is now type
generalization cfi-icall safe.

Bug: 785442
Change-Id: I162aa0e13eba9f11b06d8edeb452c6015f1f4e99
Reviewed-on: https://chromium-review.googlesource.com/938494Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542939}

Most of the tests in external/wpt/css/css-lists were contributed by
Chrome, but we skip the directory on import. There is one new reftest
that passes, and two visual tests that should not be run. Remove the
line skipping this directory from W3CImportExpectations.

Change-Id: Icfe1d7e7cca98a79c1eb8c532ca169367ba460b4
Reviewed-on: https://chromium-review.googlesource.com/959781Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542938}

This adds events CLOUDDPS_REQUEST/CLOUDDPS_RESPONSE to app install log.

Bug: b/73277923
Test: manual
Change-Id: I7ec87a7bbfa1bc358feb8a44481c34599012b32e
Reviewed-on: https://chromium-review.googlesource.com/952538Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#542937}

When user picks a menu item without key window, show UserManager if
the |lastProfile| is a guest profile and guest mode is disabled.

Bug: 820649
Change-Id: I6e20446de0b89a25e37c4d8aaa48a943878fd0c8
Reviewed-on: https://chromium-review.googlesource.com/959627Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542936}

Revert "Reland "Adds WindowService-ChromeOS fieldtrial""

This reverts commit 299e1847.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Reland "Adds WindowService-ChromeOS fieldtrial"
> 
> This reverts commit 6c097bb5.
> 
> Reason for revert: I'm reverting the revert as the dependent change has cycled through the bots https://chromium.googlesource.com/chromium/src/+/a5ea6086a54429ad2770cf28a3898413866e1bdd
> 
> Original change's description:
> > Revert "Adds WindowService-ChromeOS fieldtrial"
> > 
> > This reverts commit b4603176.
> > 
> > Reason for revert: Reverting as one of the fixs for an interactive_ui_test failure got reverted.
> > 
> > Original change's description:
> > > Adds WindowService-ChromeOS fieldtrial
> > > 
> > > I'm not sure on the name here. I went with WindowService-ChromeOS as
> > > at some point we will launch the WindowService on other platforms, but
> > > that won't be anytime soon and is likely to be very different. So, I'm
> > > thinking later on we have the field trial WindowService-Desktop.
> > > 
> > > BUG=814898
> > > TEST=none
> > > 
> > > Change-Id: I5bf45c2a463de0fefaeb06939429977e36c3681e
> > > Reviewed-on: https://chromium-review.googlesource.com/932821
> > > Commit-Queue: Scott Violet <sky@chromium.org>
> > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#542680}
> > 
> > TBR=sky@chromium.org,rkaplow@chromium.org
> > 
> > Change-Id: Id63c00a90c6fd05ff74f0ffaa6ed738a98bd74e3
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 814898
> > Reviewed-on: https://chromium-review.googlesource.com/959763
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: Scott Violet <sky@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#542713}
> 
> TBR=sky@chromium.org,rkaplow@chromium.org
> 
> Change-Id: I5a7259e6d6ce0ddafb516c22f847e6f662ad57b5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 814898
> Reviewed-on: https://chromium-review.googlesource.com/960937
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#542844}

TBR=sky@chromium.org,rkaplow@chromium.org

Change-Id: If4b14ec456142c815d6caec76551672e99729348
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 814898
Reviewed-on: https://chromium-review.googlesource.com/961323Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542935}

With surface sync on, the active tree is always expected to have a valid LocalSurfaceId, otherwise
surface invariants violations might be caused.

Bug: 672962
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I71dea254f4208c76189dacfb4c4682aa6a5d72cb
Reviewed-on: https://chromium-review.googlesource.com/960585Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542934}

The URL field is not optional in README.chromium, so //tools/licenses.py is
currently failing with

    licenses.LicenseError: couldn't find 'URL' line in README.chromium or licences.py SPECIAL_CASES

in //third_party/metrics_proto.

The actual development repository is not public, and the code in the
Chromium tree acts as the canonical public repository. Add an explanation
instead of a URL in a similar fashion to what is already done in:
* //third_party/bazel/desugar
* //third_party/gvr-android-keyboard
* //third_party/instrumented_libraries
* //third_party/s2cellid

While here, also set a Short Name; even though licenses.py does not
complain, README.chromium.template does not say it is an optional field.

Bug: 805849
Change-Id: I1810e8523a2d3bd210855b2a7c1f997fdb0c7dda
Reviewed-on: https://chromium-review.googlesource.com/960028Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#542933}

https://skia.googlesource.com/skia.git/+log/296de50b4c2e..e027e19477f8

$ git log 296de50b4..e027e1947 --date=short --no-merges --format='%ad %ae %s'
2018-03-13 benjaminwagner Temporarily remove Win10 QuadroP400 from CQ.
2018-03-13 caryclark consolidate SaveLayerFlag internal references
2018-03-13 rmistry Increase Android framework bot deadline since we are now building more
2018-03-13 bungeman Include correct trace.h.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=stephana@chromium.org

Change-Id: Ia9ed064a7e3601d6bac67719c2630cd82010c7a9
Reviewed-on: https://chromium-review.googlesource.com/961266Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542932}

The flag --enable-viz-devtools will be used to initialize Viz DevTools server and
observe Viz Display Compositor objects from the GPU process. Now on creating of the
DevTools server from the browser process we pass the flag we need to search for in
the command line to determine whether to enable devtools or not and a default port
number to run the server on. When we start chrome along with the devtools flag we
can specify the port number we want the server to run on, but it is optional, so
if nothing's specified we pass the default port number to run the server on.
Later the GPU process will also pass its corresponding parameters.

Bug: 816802
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I8f5e461758cf7aa0e575680e659c45232a9fd8e2
Reviewed-on: https://chromium-review.googlesource.com/943247Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Illia Martyniuk <illiam@google.com>
Cr-Commit-Position: refs/heads/master@{#542931}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a5910bdfbceb..d6d54e48b2b8

$ git log a5910bdfb..d6d54e48b --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I30c8244d8c05b6b6c4424c9b0d93b5f68a60ec9a
Reviewed-on: https://chromium-review.googlesource.com/961271
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542930}

This CL stops toggling "sync everything" from overriding all individual
prefs' on-disk value with "true" (see reasoning in bug report).

Bug: 815018
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If6287376009b200355426113618933af9ad78243
Reviewed-on: https://chromium-review.googlesource.com/935836Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542929}

This is split out from the CL to test all widgets and views for nameless
focusable objects. See crrev.com/c/951933.

Bug: 819350
Change-Id: I4435ed2c1c6fcb7148abc2a15570d07c2dca292a
Reviewed-on: https://chromium-review.googlesource.com/961090Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542928}

This patch concerns so called external window mode,
which is being developed downstream now [1].

The problem this CL fixes is the following:
Even though events are passed to the right X11WindowOzone
based on an XID target now, there can be cases when the
events must be rerouted to another X11WindowOzone, for
example, a context menu or a nested 3-dot menu. In case of a
nested 3-dot menu, events must always be passed to the parent
menu, so that the menu controller would handle events properly.
Another case is handling events when a user clicks outside the
menu's area: even though the events can be targeted for another
window, there can be an explicit grab that must reroute them
to the menu window, which will be closed as soon as a user
clicks outside the menu's area.

The patch fixes the above mentioned problem the following way:

1) Once an explicit grab is set, the events are passed to an
X11WindowOzone have their locations converted and are rerouted
to a grabbed window.

2) Whenever a grabbed window looses an explicit capture,
X11WindowManager tells X11WindowOzone the capture is lost
and the |delegate_| is notified about that.

[1] https://github.com/Igalia/chromium

Bug: 707406
Change-Id: I1b00e79c8ddc17b000c2f55b7f39c9ea16c0c71a
Reviewed-on: https://chromium-review.googlesource.com/790773
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542927}

For some reason, InputConnection#beginBatchEdit() is called on UI thread,
only after
https://chromium-review.googlesource.com/c/chromium/src/+/894499
has landed. One theory is that HTC mail has been doing this the entire
time, but beginBatchEdit() and some other methods were being ignored at
the beginning while delayed onCreateInputConnection was running.

Since this is observed only on HTC mail, let me land a temporary fix
for HTC mail for now, and investigate this further as necessary.

TBR: tedchoc@chromium.org
Bug: 820756
Change-Id: Ib33dfa57372b0d914ccc294d91a9e00899366c1b
Reviewed-on: https://chromium-review.googlesource.com/961276Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542926}

As above. Removes all relevant code, and layout-tests for this feature.

See intent to deprecate and remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/-e92az54B4I/SZdhGR19DgAJ

Bug: 818691
Change-Id: I67fded35309d6cfa52ff462f977d5ebef1f4e1e9
Reviewed-on: https://chromium-review.googlesource.com/957264Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542925}

Bug: 807836
Change-Id: I39670c95488885d94da2f96968b686213f31eb2b
Reviewed-on: https://chromium-review.googlesource.com/953660
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542924}

Feature was launched in M64.

Bug: 820975
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie8deeda24708509caafde53a3a908bbe1ee84376
Reviewed-on: https://chromium-review.googlesource.com/959041Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542923}

R=jbudorick@chromium.org

Bug: 811974
Change-Id: I4430e7324c1e091e6e137147e24f9c869f2efd77
Reviewed-on: https://chromium-review.googlesource.com/961481Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542922}

Now that ChromeVoxPanel speaks mojo we can enable the following tests:
 AccessibilityManagerTest.AccessibilityMenuVisibility
 AccessibilityManagerTest.ChangingTypePrefInvokesNotification
 AccessibilityManagerTest.ChangingTypeInvokesNotification
 AccessibilityManagerTest.TypePref
 AccessibilityManagerLoginTest.BrailleOnLoginScreen
 AccessibilityManagerLoginTest.Login
 UserTypeInstantiation/AccessibilityManagerUserTypeTest.BrailleWhenLoggedIn/0
 UserTypeInstantiation/AccessibilityManagerUserTypeTest.BrailleWhenLoggedIn/1
 UserTypeInstantiation/AccessibilityManagerUserTypeTest.BrailleWhenLoggedIn/2
 UserTypeInstantiation/AccessibilityManagerUserTypeLoginTest.EnableOnLoginScreenAndLogin/0
 UserTypeInstantiation/AccessibilityManagerUserTypeLoginTest.EnableOnLoginScreenAndLogin/1
 UserTypeInstantiation/AccessibilityManagerUserTypeLoginTest.EnableOnLoginScreenAndLogin/2

Update the filter to put the remaining failures in the right sections.

Bug: 628655
Change-Id: Ifd7f9dab36b98c6c9f29beb511a8ddd3b33906af
Reviewed-on: https://chromium-review.googlesource.com/959610Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542921}

Imports the newest version of the Feed.
Udpates BUILD.gn to include all the files.
Removes the basicstream_java target.

No changes new to dex/binary size.

Change-Id: If016e84416a2ced4f5e1321bf533f0c4582efed9
Reviewed-on: https://chromium-review.googlesource.com/961441Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542920}

The number of CreateEquivalenceMap() iterations used be constant
kNumIteraitons = 2. This CL makes the value depend on architecture.
Current assignment:
- DisassemblerNoOp: 1, since no pointers are identified (though in this
  case, CreateEquivalenceMap() should not be called).
- DisassemblerWin32: 2.
Upcoming DisassemblerDex will use 4.

Also applying generic cleanups on headers and comments.

Bug: 729154
Change-Id: Ia12d98fcba500e4c81c8a5d356ce4cadf424ffde
Reviewed-on: https://chromium-review.googlesource.com/961273Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542919}

Make controls appear on preview area when custom margins is selected.
Controls do not yet work.

Bug: 773928, 812095
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia0319b743736717f94af65c3ef364b65f2193571
Reviewed-on: https://chromium-review.googlesource.com/935681
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542918}

This change updates SmbFileSystem to using SupportsWeakPtr instead of
manually implementing a WeakPtrFactory.

Bug: chromium:757625
Change-Id: I00cf23d863a5f094185217bc5d18bda49d4405db
Reviewed-on: https://chromium-review.googlesource.com/957205
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542917}

The new name is shorter and better reflects what the class does:
providing the MediaCrypto object.

Bug: 821114
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5226a8280a1342fb47a0847755b82a8be8ed52e4
Reviewed-on: https://chromium-review.googlesource.com/959698Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542916}