GitLab

Previously, selection and content changes were sent as separate callbacks.
This caused consistency errors in observers, as the two must be processed
simultaneously.

TabStripModelObserver::OnTabStripChanged() carries selection and contents
data at the same time. And it'll be called after tab strip model finishes
it's work. So we don't have to care about model's state that much.

Thus, we can replace following with OnTabStripChanged():
  void TabInsertedAt(...);
  void TabReplacedAt(...);
  void TabMoved(...);
  void TabClosingAt(...);
  void TabDetachedAt(...);
  void TabDeactivated(...);
  void ActiveTabChanged(...);
  void TabSelectionChanged(...);

Also this callback allows us to handle multiple changes in a single
callback. e.g. multiple tab closing, insertion, etc.

Change-Id: Iae824f8be536dbe699ba0108bf242114e0906ec7
Bug: 842194
Reviewed-on: https://chromium-review.googlesource.com/1140105
Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579707}

This makes focus traversal of UnifiedSystemTray to start from the
SystemTray part. We have notifications above the SystemTray part.
Previously, similar functionality was implemented by TopShortcutsView::
RequestInitFocus(), but it had two downsides:
* It did not make use of ShouldEnableExtraKeyboardAccessibility(), so
  usability with ChromeVox was degraded.
* It did not edit focus traversal order, so the SystemTray part caught
  focus on open only when the tray was opened by Alt-Shift-S. When a
  user opened the tray by mouse and the pressed Tab, notifications
  caught the focus.

TEST=manual
BUG=862506

Change-Id: I4fede4f015980c735eedd28f1d05fc19fbded616
Reviewed-on: https://chromium-review.googlesource.com/1156193Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579706}

This struct allows easy plumbing of fields that are representative of
why a datatype is running. This avoids the need to inject SyncClient
in multiple places, which is undesirable because it carries over a long
list of dependencies, including a subtle dependency cycle in some cases
(DeviceInfo) that needs a workaround (the controller's delegate must be
obtained lazily).

We plan to extend this struct with new state information in follow-up
patches.

Bug: 866814,867801
Change-Id: I35142c3a04f2f5abba22a5ec23d475c8da8bd292
Reviewed-on: https://chromium-review.googlesource.com/1154532Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579705}

Since there's no longer any DRM-master specifics in GbmBuffer, move it
to //ui/ozone/common/linux and remove GbmBoWrapper.

Bug: 869206

Change-Id: I079f157e2f8ad46ea1f68670421d6d700abba25d
Reviewed-on: https://chromium-review.googlesource.com/1155919
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579704}

This message is also supposed to link to
/run/imageloader/cros-termina/<version>/about_os_credits.html on the
CrOS machine, but that is not present unless Termina is running. I
think that part will be more involved, so I want to do it in a second
CL.

Bug: 858832
Change-Id: I1ab11af69de6434ddcfacd4987951a05e50b3889
Reviewed-on: https://chromium-review.googlesource.com/1143169
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579703}

Previously, WorkerThreadDebugger::ContextCreated() sets
V8ContextInfo using global scope's Url().
However, After [1] Url() can be null when the global scope is
created and thus ContextCreated() can't use Url().

This CL uses |GlobalScopeCreationParams::script_url| instead.
This CL shouldn't change the behavior, because currently
global scope's Url() is equal to
|GlobalScopeCreationParams::script_url|.

[1] https://chromium-review.googlesource.com/1139074

Bug: 866666, 861564
Change-Id: Ic19a87d77c4b01d3f850e51ce734dae11e1b4e44
Reviewed-on: https://chromium-review.googlesource.com/1139052Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579702}

AsyncDelegateLogger is a ref counted class, and its instance is
destroyed when all of its reference is released. So, an unexpected
first reference creation may cause an unexpected early destruction.

AsyncDelegateLogger::Start() used to run before the first reference is
made, and the first reference used to be made by base::Bind in Start()
implicitly. The reference is released when the callback instance is
destroyed, so the instance may be destroyed in Start().

Though this case is safe, as no one touch the instance after Start(),
an upcoming change to base::Bind() disables this pattern of implicit
first reference creation as it's error prone.

After this CL, AsyncDelegateLogger::Run() holds the reference to
avoid implicit first reference creation, and to avoid the check
failure.

Bug: 866456
Change-Id: I719dd6f398f2d3ce4f5d3243a326b4f2d792381e
Reviewed-on: https://chromium-review.googlesource.com/1156705
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579701}

https://chromium.googlesource.com/catapult.git/+log/5c2d9e757a6f..68afb50705f8


git log 5c2d9e757a6f..68afb50705f8 --date=short --no-merges --format='%ad %ae %s'
2018-08-01 nednguyen@google.com Update AndroidBrowserBackend.IsBrowserRunning for consistency
2018-08-01 skau@chromium.org Update link to Benchmark Policy.


Created with:
  gclient setdep -r src/third_party/catapult@68afb50705f8

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:869548,chromium:869698
TBR=sullivan@chromium.org

Change-Id: Ia7268312cf54098e1a868f0d07bc4b6fdaee22d0
Reviewed-on: https://chromium-review.googlesource.com/1157884Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579700}

Bug: 807724
Change-Id: Ie6d9df68023730dc927984ef326223169f243c15
Reviewed-on: https://chromium-review.googlesource.com/1155087Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579699}

This CL fixes an issue introduced by a previous change which allowed clients
to pass an empty resolution to indicate that the host should restore the
original desktop size.

This change worked for Linux and MacOS as they only have a single process which
contains the HostResizeObserver that handles this condition.

On Windows, we have a multi-process architecture where the empty resolution
was forwarded to both the desktop process (which has the HostResize Logic)
and the Daemon process (which treats an empty resolution as a critical
error).

Enabling the host resize logic for RDP is not very useful so I have just added
a check to make sure we don't forward empty resolution values to the Daemon
process.

BUG=869509

Change-Id: I87be6beb3137641ad728c4725f587a7e7f15a48f
Reviewed-on: https://chromium-review.googlesource.com/1157540
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579698}

Preferences related to Safe Browsing are removed from the persistent
storage list for incognito mode.
After this CL, if these preferences are changed from incognito mode,
they are only stored in memory and won't affect user profile.

Bug: 861722
Change-Id: I4e19fd53d5fd6c1e59991be70f443c94696d0b7f
Reviewed-on: https://chromium-review.googlesource.com/1155599Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579697}

https://pdfium.googlesource.com/pdfium.git/+log/cede561c5ae6..53d4f0a4526e


git log cede561c5ae6..53d4f0a4526e --date=short --no-merges --format='%ad %ae %s'
2018-08-01 vmiklos@collabora.co.uk Add FPDFText_GetFontName() API


Created with:
  gclient setdep -r src/third_party/pdfium@53d4f0a4526e

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I0ada161caf43b26f8fb58bd18255e18419bb1048
Reviewed-on: https://chromium-review.googlesource.com/1157489Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579696}

The directory names in chromium-browser-snapshots bucket have
changed recently, breaking all ChromeDriver builds. Changing
ChromeDriver waterfall script to compensate. In particular,
the following directory names have changed:

    Win -> win32_rel
    Mac -> mac_rel
    Linux_x64 -> linux_rel

Also removing obsolete code for 32-bit Linux.

TBR=crouleau@chromium.org

Change-Id: I2927152abc91a097fbb3c50693a578eaecc44752
Reviewed-on: https://chromium-review.googlesource.com/1157908Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579695}

This patch rewrites test expectation on each Node
with |std::string DumpSelectionInfo()| so that we can check
a SelectionStatus tree with text diff.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I337d02e126b6b53efb30c8fd3f16787f4f3c739a
Reviewed-on: https://chromium-review.googlesource.com/1157735Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579694}

https://chromium.googlesource.com/angle/angle.git/+log/ac43aaa2c2e1..ad63728be30d


git log ac43aaa2c2e1..ad63728be30d --date=short --no-merges --format='%ad %ae %s'
2018-07-31 jmadill@chromium.org VertexArray: Store bound attributes mask in binding.


Created with:
  gclient setdep -r src/third_party/angle@ad63728be30d

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I1105d1916374b62748ba53108f323192bd46c0de
Reviewed-on: https://chromium-review.googlesource.com/1157825Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579693}

This CL changes DCHECK for fixups_ to Fixups().
They are guaranteed that AddCompactingPage() and RegisterMovingObjectCallback() are called before these method.
But we collect also HeapCollections that have no buffer so it is not guaranteed.

Bug: 864425
Change-Id: Id28cc98f060f4125bca04664a9e8416f9cf97fcc
Reviewed-on: https://chromium-review.googlesource.com/1156527Reviewed-by: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Haruka Matsumura <harukamt@google.com>
Cr-Commit-Position: refs/heads/master@{#579692}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/2c3d9c837512..2d1c2ecd2d8c


git log 2c3d9c837512..2d1c2ecd2d8c --date=short --no-merges --format='%ad %ae %s'
2018-07-31 tbrindus@chromium.org cros_oobe_autoconfig: Add chromite script for OOBE autoconfig population


Created with:
  gclient setdep -r src/third_party/chromite@2d1c2ecd2d8c

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I9b294375631cbe19eb8cd6b1ded98039fddbe8fe
Reviewed-on: https://chromium-review.googlesource.com/1157488Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579691}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa1425d9d877..af27deaf0199


Created with:
  gclient setdep -r src-internal@af27deaf0199

The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:869510,chromium:b/111007449
TBR=mmoss@chromium.org

Change-Id: I2cb6f2dfd9197582fdec190af5a8dfa69e1faf17
Reviewed-on: https://chromium-review.googlesource.com/1157744Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579690}

Missed the reference in local_ntp.js

Bug: 869230
Change-Id: I50d9a991df8660592263abb79115bea5c484d756
Reviewed-on: https://chromium-review.googlesource.com/1157538Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579689}

long-press-back-new-design.


Bug: 800033
Change-Id: Iaddb0816ea911669d2cc8c7ef6eb49d5c49d8d13
Reviewed-on: https://chromium-review.googlesource.com/1155976
Commit-Queue: Charlie Ma <charliema@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579688}

https://skia.googlesource.com/skia.git/+log/c1de8bd2ba3b..f4bf7fc35d83


git log c1de8bd2ba3b..f4bf7fc35d83 --date=short --no-merges --format='%ad %ae %s'
2018-08-01 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 2eb65034db71..ad63728be30d (6 commits)


Created with:
  gclient setdep -r src/third_party/skia@f4bf7fc35d83

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: Iecc506e52a0dc5e3aa0cfb88f9c0f6dd107e0dc6
Reviewed-on: https://chromium-review.googlesource.com/1157824Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579687}

A patch to CL 1140204 that's areadly merged in

Bug: 863889
Change-Id: If16395f2becabbc49c372d88c98d3021f2c36868
Reviewed-on: https://chromium-review.googlesource.com/1157608Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579686}

We would like to understand what happens to CompositorFrames in the wild.
This UMA tracks whether Viz accepts the surface, or drops it due to some
violation. This UMA records what violation has occurred if any.

Bug: 865179
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I23cb97f64ac9905d35921fbded90de9577f32357
Reviewed-on: https://chromium-review.googlesource.com/1155471
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579685}

Bug: 807724
Change-Id: I2c8ec3cabdd0f3b502d9dfccd8f72a0973330fa4
Reviewed-on: https://chromium-review.googlesource.com/1156852Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579684}

We no longer have mash vs. classic configs in ash, and there's only one
implementation of ShellPort. As a step towards eliminating ShellPort,
remove the object factory methods from it.

Keep CreatePointerWatcherAdapter for now because that will require
more general PointerWatcher cleanup.

Bug: 866523
Test: ash_unittests
Change-Id: Iff2c3898932389ebc7eeb253ca4eb046da35e641
Reviewed-on: https://chromium-review.googlesource.com/1157688
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579683}

Further optimize ShapeResult::ComputeGlyphBounds by moving population of
source glyphs vector to ComputeGlyphPositions thereby avoiding the extra
iteration over all glyphs in ComputeGlyphBounds. Furthermore by changing
SimpleFontData::BoundsForGlyphs to take a SkRect vector avoids one extra
copy and one extra iteration.

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ib155ce1e069d5329c5fbc6a8850fc40736ee520b
Reviewed-on: https://chromium-review.googlesource.com/1157271Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579682}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3895ea2a..c5287309

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I362b28a682974fda6ec2c7cb64e49e0ccb5f5984
Reviewed-on: https://chromium-review.googlesource.com/1157689Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579681}

Currently, compilation of simple chrome build is done like below.
gomacc -> chromeos's compiler wrapper -> actual compiler binary

But chromeos's compiler wrapper modifies some flags inside it before invoking actual compiler binary.
This prevents goma from knowing some information for build cache sharing.

To know all the flags passed to compiler binary, this change supports the way not using gomacc prefix.
If we set has_gomacc_path = true, we don't prepend gomacc and lets compiler wrapper find gomacc from GOMACC_PATH env and invoke gomacc inside wrapper.
By doing this, gomacc can know all the flags passed to compiler binary.

This is a part of effort to share build cache between goma users for simple chrome build.

chromite side change is
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1140099

BUG=chromium:846610

Change-Id: I84174b12a7f286d1b911f4d0a4e167883a4891c7
Reviewed-on: https://chromium-review.googlesource.com/1151040Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579680}

https://chromium.googlesource.com/catapult.git/+log/44d40fafd233..5c2d9e757a6f


git log 44d40fafd233..5c2d9e757a6f --date=short --no-merges --format='%ad %ae %s'
2018-08-01 sadrul@chromium.org renderer: Add breakdown metrics for compositor pipeline.


Created with:
  gclient setdep -r src/third_party/catapult@5c2d9e757a6f

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:855328
TBR=sullivan@chromium.org

Change-Id: Ida622416b7b558f8dc6c5da778f6236a058259a3
Reviewed-on: https://chromium-review.googlesource.com/1157626Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579679}

Update the logic used to partition permissions between granted and
withheld with click-to-script. This patch addresses a few issues:
- Previously, permissions granted with runtime host permissions were
  added to the active permissions entry in the ExtensionPrefs. This
  meant there was a chance that extensions would continue to be
  affected after the feature was disabled.
- Previously, we would try to grant an entire origin to an extension,
  even if only a certain path was requested. This could result in a
  crash, since we later CHECK'd that all granted permissions were
  strictly contained within the withheld permissions of an extension.
- The user should not need to specify an exact URLPattern at the
  chrome://extensions page in order to grant permission to an extension.
  That is, the user should be able to allow the extension on
  "google.com", rather than
  "google.com/some-specific-path-the-extension-specified".
  (This is dependent on the changes here, but will be fully resolved in
  a followup.)

To fix this, we change runtime granted host permissions to only affect
the runtime granted permissions preference (and not change active
permissions in the preferences). When calculating permissions, we
determine the set of permissions requested by the extension and
intersect it with the permissions in the runtime granted permissions.

This patch also allows extensions to be granted more permissions than
they explicitly request. This means that if an extension requests only
https://google.com/maps, it can be granted https://google.com/*. This is
necessary for runtime host permissions, where permissions granted may be
broader than explicitly requested. For security purposes, even though
the granted permissions may exceed the requested permissions, the
permissions active on the extension object (and in the extension
process) will always be strictly bound by the requested permissions. To
achieve this, we leverage the new intersection logic in URLPatterns
introduced in https://crbug.com/867549.

These two changes are interdependent (and cannot be submitted as two
CLs) because by no longer adding runtime-granted permissions to the
active permissions set, we introduce a need to find the semantic
intersection of the runtime-granted permissions and the requested
permissions. Otherwise, because of the way we partitioned permissions,
we would not grant any permissions if an extension requested *://*/*
and the user granted https://google.com/*.

Bug: 867547

Change-Id: I161cc699c95989f86be5b1743aee422ac5b41221
Reviewed-on: https://chromium-review.googlesource.com/1153986
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579678}

This patch changes |SetSelectionToDragCaret()| to utilize early-return style
to reduce indentation for improving readability.

This is 3/3 of series of patches:
 1. http://crrev.com/c/This patch
 2. http://crrev.com/c/1153070
 3. This patch

Change-Id: Ib8c95fc4d027ce7633c9d69ef7bef0554503744c
Reviewed-on: https://chromium-review.googlesource.com/1153071
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579677}

Bug: 869240
Change-Id: Ie5350b73b21bf94912fea292261b4dea7382c511
Reviewed-on: https://chromium-review.googlesource.com/1157728
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579676}

Fix links to *.{h,cc} files.

TBR=rakina

Bug: 742715
Change-Id: I13df9ba392405dfdba37d12279b98dccc35be1a2
Reviewed-on: https://chromium-review.googlesource.com/1157736Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579675}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1aefad2a5982..6f812e132d25


git log 1aefad2a5982..6f812e132d25 --date=short --no-merges --format='%ad %ae %s'
2018-07-31 ehmaldonado@chromium.org metrics: Separate metrics collection and print notice logic.


Created with:
  gclient setdep -r src/third_party/depot_tools@6f812e132d25

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:868280
TBR=agable@chromium.org

Change-Id: I2372686119cd531c28d4aa1c947f20242b5493ba
Reviewed-on: https://chromium-review.googlesource.com/1157485Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#579674}

This reverts commit 2dbd1cd1.

Reason for revert: The crash still exists with or without the workaround on M70. Re-adding the workaround brings M69 and M70 to the same code, so that the future fix in M70 will be easy to merge to M69.

Original change's description:
> service worker: Remove workaround for ServiceWorkerObjectHost crash.
> 
> Since issue 864731 was fixed in r576288, this workaround is no longer
> needed.
> 
> Bug: 854993
> Change-Id: I789dfb18cdb82ec51aa0ce5185586163c92269ec
> Reviewed-on: https://chromium-review.googlesource.com/1147889
> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> Commit-Queue: Matt Falkenhagen <falken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577435}

TBR=falken@chromium.org,bashi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 854993
Change-Id: Idb68e5d11c8b14da4dfee6d2fb484cc13be72501
Reviewed-on: https://chromium-review.googlesource.com/1157665Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579673}

This is for more than 30 mins compile steps like below builds.

3098s https://ci.chromium.org/b/8939533321978115792
2795s https://ci.chromium.org/b/8939589875030577488
2665s https://ci.chromium.org/b/8939589087341023936
2577s https://ci.chromium.org/b/8939542011766010016

Bug: 804251
Change-Id: I54121207009b07e65686c9415c0bc7f31e929e6c
Reviewed-on: https://chromium-review.googlesource.com/1155277Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579672}

Add "Slots and node assignments" section.

TBR=rakina

Bug: 742715
Change-Id: I4e5ad0da310c186643ce42695459a17d1a853654
Reviewed-on: https://chromium-review.googlesource.com/1157732Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579671}

This reverts commit 1edc413f.

Reason for revert: the test added by this (CustomFrameViewAshTest.ActiveStateOfButtonMatchesWidget)
has been super flaky on linux-chromeos-rel right after this was added.

Some builds:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11360
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11361
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11363

Original change's description:
> OopAsh: port/enable some more browser tests.
> 
> Bug: 854704
> Change-Id: Ic3dcef42f108beb02a398302f3ecd70dd72c0f2d
> Reviewed-on: https://chromium-review.googlesource.com/1153777
> Commit-Queue: Evan Stade <estade@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579476}

TBR=sky@chromium.org,estade@chromium.org

Change-Id: I33d224561923905ceaabe67a57cec6c78c0b104c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 854704
Reviewed-on: https://chromium-review.googlesource.com/1157844Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579670}

Looks like they're flaky (in viz_content_browsertests).

TBR=niklase

Bug: 869723
Change-Id: I8c2ea517fddfddb3f664107d0dc237fc3579c704
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1157733
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579669}

This is to generate reproducible binary between commits for Linux by giving use_dummy_lastchange=true in args.gn.

This CL makes binaries independent from commit hash at least for below (time consuming) targets on Linux.
* content_unittests
* interactive_ui_tests
* content_shell (for webkit_layout_tests)
* content_browsertests
* browser_tests

If we can generate deterministic binary, test execution on build bot can be cached. And it will improve CQ cycle time.
But we don't know how often we make changes not introducing functional change in binaries.
So this CL is mainly for getting some stats from test on Linux buildbot and evaluate whether it is better to go forward or not for other platforms.

See more backgrounds here.
https://docs.google.com/document/d/16dalG0ssugZlwc7BBzUoBQUmuqM0S_gwtG2uxL0htdw/edit#

TBR: pfeldman@chromium.org
Bug: 869348
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1b351b2135fd5e749ed575484b2182e847a420c9
Reviewed-on: https://chromium-review.googlesource.com/1151169
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579668}