- 31 Mar, 2020 40 commits
-
-
Jeffrey Cohen authored
For the experimental share button in the toolbar: Add a requirement for devices to have a min width, and use finch param. Fix Issue with orientation, where button was not being updated on orientation change. Update Tests to respect device width. Bug: 1036023 Change-Id: If99bb41b5ae9d5b35e416c338d5a8355ba91949e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112753Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#755012}
-
Peng Huang authored
Bug: 1065499 Change-Id: I9bbf1af0d72045be40fab67f2454a6420ef8db69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127511Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755011}
-
Clark DuVall authored
This is a reland of 6966bd53 I wasn't able to repro the flake locally, but added an extra assertion to the test to possibly get more info if this flakes again. Original change's description: > [WebLayer] Switch geolocation tests to use permission prompt > > These tests were previously using the fake permission manager which > always grants permissions. Now we can use the real permission manager, > and the fake permission manager can be removed. > > Fixes a strict mode violation in permission dialogs (similar to fixes > from https://crrev.com/c/2108603). > > Bug: 1025625, 1025609 > Change-Id: I8b756c61ee213151e53d68a375ffa4d3f8fd7643 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111061 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#752494} TBR=jam@chromium.org Bug: 1025625, 1025609, 1064500 Change-Id: Idb4ff08bca8ec60321b1524a9b51ec47a07b8910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129888Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#755010}
-
Akihiro Ota authored
Before this patch, moving by word or character would not trigger a locale switch, even if the node was labeled with a language. This is because movement by word and character goes through Output.subNode_, which was not hooked up to locale switching logic. This patch fixes that issue. This patch also removes the experimental sub-node language detection and switching logic, since it is still unreliable and not crucial for launch. Finally, this change removes the chromevox sub-node language switching flag, since the logic is being removed. Bug: 1020439 Relnotes: N/A Change-Id: I5abfa9d5e493f82682fe18e19e87992d693f993c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091721Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#755009}
-
Mehran Mahmoudi authored
This adds a C++ example to the JNI doc as well as some changes to the instructions for creating native functions. Bug: 1066173 Change-Id: Ia84f038e009e5b0f7420f3c27a38a176bb34f537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128226Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#755008}
-
Junyi Xiao authored
Similar to Bug: 783199, when user have two monitors that set to different scales, PWA may relaunch off the screen. This change does a similar fix for PWA as the original change did for devtools. Bug: 1046481 Change-Id: I63230b01c59c5f277298c5bc5e51c8703cc6f54a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074799 Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#755007}
-
Andrew Grieve authored
This is an initial implementation of desugaring with D8/R8 rather than Desugar.jar. The flag is default false, so this change should have no affect without it. Known issues: * Does not work with incremental dexing * Produces larger apks * Generated classes not mapped to source files by supersize Tested that chrome_public_apk and monochrome_public_bundle start without crashing. TBR=agrieve # Trivial BUILD.gn updates Bug: 1015559 Change-Id: I3030f6f489c23f208461f4400c1849569bdbd5fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127506 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#755006}
-
danakj authored
Code that can see test_runner::WebTestRunner can also see test_runner::TestRunner, so we don't need this abstraction. R=avi@chromium.org Bug: 866140 Change-Id: Iae3aadaa0bedbc24c5ca5bcba2889633df8af1f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129989 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#755005}
-
Matthew Mourgos authored
This change edits the description on the home page of the gesture navigation screen. The word "Homescreen" has been changed to "Home screen". Bug: 1065483 Change-Id: I4813b046e050c19119c3349ba5c70762f9298760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129207Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#755004}
-
Allen Bauer authored
Bug: 1056944 Change-Id: Ia5d93433f1901156c5585c9a712e340c39bb173c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112578 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#755003}
-
Robert Sesek authored
Bug: 1066264 Change-Id: I8e0949be2a74e39cddab6887d077af2b90bfb484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128980 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#755002}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 3 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-09-27. TBR=bcwhite@chromium.org Change-Id: Iebb799d7afc0342aed7ae540aa8165da6c4e50bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129827Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#755001}
-
Adam Langley authored
r754176 was incomplete: it should have trimmed the MTU for writes from the phone was well as the advertised MTU. BUG=1002262 Change-Id: I688f86c90fe160014cbcf9cef7ea0d119da7725e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129886 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#755000}
-
Jesse Schettler authored
Add FanInfo to cros_healthd_probe.mojom to keep the Chrome and Chrome OS copies in sync. Bug: 1035579 Test: CrosHealthdServiceConnectionTest.ProbeTelemetryInfo Test: DeviceStatusCollectorTest.TestCrosHealthdInfo Change-Id: Iccfba47babfb800c81b4f88e2685138fea013777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115853Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#754999}
-
Dave Tapuska authored
1000336 was a duplicate of 1000512. BUG=1000768,1000336,1000512 Change-Id: If61ab9546257eee2eaa34db381faa11cfc12b660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129988Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#754998}
-
Adam Rice authored
network::WebSocket should return immediately if the return value of net::WebSocket::SendFrame is CHANNEL_DELETED. It was not doing so. Add the necessary return statements. Also add WARN_UNUSED_RESULT to SendFrame() to make sure it is checked in future. Tested manually. No unit tests for this change because network::WebSocket has no unit tests. BUG=1065704 Change-Id: I0c7e0cf57f3a98fc80461ec50df59513146eff89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123961Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#754997}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/aface10e934e..1db568ebb1f0 git log aface10e934e..1db568ebb1f0 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 dgkoch@users.noreply.github.com update glslang to SDK-Candidate-2 tag (#1027) Created with: gclient setdep -r src/third_party/shaderc/src@1db568ebb1f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I05ccc4cf0325e5733febc00ad3a46d47143d79f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129856Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754996}
-
Mohamed Amir Yosef authored
This is a mechanical change that only renames a method in the MultiStorePasswordSaveManager for clarity. Bug: 1012203 Change-Id: Ic46aa9ad60b753385f23769f26f2d589135fc762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129539 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#754995}
-
Michael Thiessen authored
Bug: 1066521 Change-Id: Ib591b5ee471f4bc55a8fbbec2a1cd0b4762e1b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129990Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#754994}
-
Jeroen Dhollander authored
When an Assistant query has been submitted, you should not be able to interact with the suggestion chips anymore. Mouse clicks had always been disabled, but a bug still allowed the user to submit queries using |TAB| and |ENTER|. This CL also introduces some extra unittests that were missing. Bug: b/151800188 Change-Id: Iaa132b836716c119656d39243895571af760f291 Tests: new ash_unittests with filter "AssistantPageViewTest.*" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129047Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Cr-Commit-Position: refs/heads/master@{#754993}
-
Sergey Poromov authored
Chrome OS notification was previously displaying the in progress UX for downloads that were in the middle of scanning. This could be confusing given that we may remain in this state for several minutes. Instead, we should indicate to the user that the file is being scanned. It also includes support for additional scan result states - safe, warning and block. Screenshots: https://docs.google.com/presentation/d/1V6etHX1rp3W5uiqR7WS8fdTGjPa_KeMSf5ZPtZp8tVU/edit#slide=id.p Bug: 1062788 Change-Id: I1957b422bac2d56ed9ce86454c4884d7ebe0a799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127707Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#754992}
-
danakj authored
The force flag was used to ignore the gpu process capabilities and use gpu raster anyways. The --enable-gpu-rasterization flag makes the gpu process always report that it can use gpu rasterization, so this has the same effect (outside of tests that were setting force only). R=kylechar@chromium.org Bug: 866140 Change-Id: I06d86ff8d74f0ecbbb59555e570822921196b765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127523 Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#754991}
-
Alex Ilin authored
SigninViewController is owned by a Browser object. The clients often access it via `browser->signin_view_controller()`. However, all SigninViewController methods also accept Browser* parameter that must point to the same browser that owns this SigninViewController. Browser and SigninViewController have 1:1 relationship, so it sounds logical for SigninViewController to hold a pointer to Browser. Adding a Browser* field to SigninViewController brings the following - Eliminates risk of passing an incorrect Browser* to SigninViewController method. - Reduces number of parameters in all SigninViewController methods. benefits: Change-Id: Icda291a5a9baf9e6ea06c9afdc2eb6051f5434f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127030Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754990}
-
ckitagawa authored
Deflake the use of onHidden in PaintPreviewTabService by treating the WebContents as being in capture mode. This prevents the renderer from going away until after the capture is completed. Follow up work may be required to ensure the TabImpl#hide hiding the WebContents prior to calling the observers doesn't cause rare races. I've run 40 times locally without issue, but it could be an issue. Bug: 1061190 Change-Id: I51b84e66b0b9e02d137f3780824c337c6384d642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118392Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#754989}
-
Kevin Ellis authored
The ready promise depends on the pending state, which in turn can be impacted by a pending style change. Checking the pending state prior to checking the ready promise fixes the problem. The affected test still produces an unhandled rejection error presumably due to missing the step of marking the promise as handled when resetting pending promises. Bug: 1064640 Change-Id: I25191dd26206368e497638ce9f73984b2e61cad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118183 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#754988}
-
Mohamed Amir Yosef authored
The functionality is already implemented and even tested :-) This CL is only add a comment to make the design decision more explicit! Bug: 1012203 Change-Id: Ib62c51ab924e3172deffde7b8bc036f2ee824c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127106 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#754987}
-
Xiaoqian Dai authored
Bug: 1066286 Change-Id: I5b747457251cd3dbef3ced3a3868ef8acbe316bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128767Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#754986}
-
Sam Sebree authored
This change uses the native_theme_base controls properties to set correct dark mode styling for progress bar controls. Bug: 929098 Change-Id: I14afd7414cffba818b24a8e42d46f7d4a677a09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126472Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sam Sebree <sasebree@microsoft.com> Cr-Commit-Position: refs/heads/master@{#754985}
-
Nina Satragno authored
Remove adjusted_timeout from the renderer - browser pipe and use the raw timeout on android instead, adjusting it on java. Add unit tests for the adjustment. This aligns the android and browser implementation and cleans up leftover implementation from crrev.com/c/2084725 Fixed: 976428 Change-Id: I974dc8ec8852ba2216a3cb615c53b25c802f7b42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128529 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754984}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e0bc6f033ff5..ba238d8eed6d Created with: gclient setdep -r src-internal@ba238d8eed6d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie132c0baa1dea6d25f800fd3ab3354a5c3c5f042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129854Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754983}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9a8735962f3e..3459bf5bf9c9 git log 9a8735962f3e..3459bf5bf9c9 --date=short --first-parent --format='%ad %ae %s' 2020-03-31 vapier@chromium.org remote_access: finish RunCommand->run rename 2020-03-31 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-31 linxinan@chromium.org api: compile latest api for test_platform 2020-03-31 cjmcdonald@chromium.org pytest: Run in parallel by default 2020-03-31 cjmcdonald@chromium.org service/test: Use pytest wrapper instead of system pytest 2020-03-31 cjmcdonald@chromium.org toolchain_util_unittest: Use AbstractGSContextTest class 2020-03-31 oka@google.com fix file path for Tast secret variables 2020-03-30 vapier@chromium.org commandline: rename --log_format to --log-format 2020-03-30 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-30 chrome-bot@chromium.org Update config settings by config-updater. 2020-03-30 cjmcdonald@chromium.org Add virtualenv_wrapper target for running pytest 2020-03-30 cjmcdonald@chromium.org Remove broken mock assertions 2020-03-30 cjmcdonald@chromium.org mock: Backport 'assert_called' and 'assert_not_called' 2020-03-30 cjmcdonald@chromium.org mock: Backport 'assert_called_once' to vendored copy 2020-03-30 mmortensen@google.com Refactor to use service/artifacts for BuildAutotestTarballsForHWTest. Created with: gclient setdep -r src/third_party/chromite@3459bf5bf9c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I14620a1d5db29210c0f98f21d830333b49e5f103 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129852Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754982}
-
Sylvain Defresne authored
With Xcode 11.4, the arm64e slice of XCTRunner is removed from the binary when creating the XCUITest runner application. Not doing it may prevents running the application on a device, so replicate this. Bug: none Change-Id: I25925ac7ed20150bb2ef4cffa01e64f8ad9d4e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127111 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#754981}
-
Sadrul Habib Chowdhury authored
. Add a 'NeedsBeginFrames' async-event to show the duration of a client's request for begin-frames. . Add a flow-event for 'did not produce' frames. . Add a trace-event for when a client is throttled (and include the reason for throttling). BUG=none Change-Id: I65e601b54a683bef54142b98f6faf037cc22308e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125618 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#754980}
-
Qijiang Fan authored
microseconds - kMicrosecondsPerMillisecond could cause an overflow if microseconds is too small (close to INT64_MIN) Bug: 1065504 Change-Id: I827dc3479eabbf1be5fdf964dbcb34bc48d7f401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129788Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Qijiang Fan <fqj@chromium.org> Cr-Commit-Position: refs/heads/master@{#754979}
-
henrika authored
Minor fix to ensure that we don't log error messages when client adds a video-only stream on an HTML tag. Bug: 1017219 Change-Id: Id388e1ef67c5a71272557ccd62cb24a0d19cac1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128113Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#754978}
-
Eugene But authored
Update compile_webkit_mac_minibrowser target to build release build. WebKit folks recommended fuzzing release build to avoid hitting assertions, which mostly indicate minor problems, which are not high priority to fix. Bug: 1064181 Change-Id: Ifdb22e20dc67b353b9ec237d63a40347dd7d7ecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129086Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#754977}
-
Navid Zolghadr authored
Refactor the current frame sink id hit test API and reuse it to scroller target finding to be used in compositor. This will be used in the scroll targeting in scroll unification project in the follow up CLs. For more information look at: https://docs.google.com/document/d/1smLAXs-DSLLmkEt4FIPP7PVglJXOcwRc7A5G0SEwxaY/edit#heading=h.hykhktoizkjj Bug: 1047179 Change-Id: Ie7001e5342a99eff85dc078c65a958a4c65f1120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070383Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#754976}
-
Dan Harrington authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2123249 - Added LoadStreamFromStoreTask to read model data from the store. - Update LoadStoreTask to try loading from the store first, via the new task. - Save operations executed to persistent storage. My primary goal when making this change was to save operations to persistent storage as they are executed. Pulling this thread led to several changes. We were saving a bit too much data in the single 'stream_data' record, which meant we would have to re-serialize the whole model to save a single piece of information. I went ahead and split 'stream structures' out into another record. All stream structures for the stream now need to be read in at load time, and they need to be sequenced appropriately. In making that change, I wanted to verify we could actually load the data back in. So I implemented loading a stream from storage as well. Bug: 1044139 Tbr: iwells@chromium.org Change-Id: Icf01f301488bc977f6f4ee2bf0f1c3332037176b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129775Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#754975}
-
Elly Fong-Jones authored
This change: 1) Introduces a new class, views::NamedWidgetShownWaiter, which wraps the common pattern of waiting for a widget of a specific name to be shown; 2) Moves AnyWidgetObserver::Passkey to its own top-level class, AnyWidgetPasskey, so that NamedWidgetShownWaiter can take an instance as well; 3) Adds tests for NamedWidgetShownWaiter; 4) Removes a bespoke RunLoop wait in ExtensionsMenuViewBrowserTest, replacing it with NamedWidgetShownWaiter. Bug: None Change-Id: I730ffc740649fcee8de077fbe78aa3d6fe0f9024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122474 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#754974}
-
Roman Sorokin authored
Also OobeSpokenFeedbackTest TBR=aleventhal@chromium.org Bug: 987587 Change-Id: Ib66052b1c52351edb6ba304cc1c6a1b82c8d9245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129707 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#754973}
-