- 19 Aug, 2020 40 commits
-
-
Ben Pastene authored
This reverts commit ac7726b8. Reason for revert: reverting to shed load on CQ, crbug.com/1119483 Original change's description: > [lacros] Enable linux-lacros-rel by default > > This CL enables linux-lacros-rel on CQ by default. > > Bug: 1116180 > Change-Id: I67bf89a5eefd7382bbd2886f416bc38c411213bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360496 > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799123} TBR=estaab@chromium.org,liaoyuke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1116180, 1119483 Change-Id: I2be0017d3af1e863ec15efaa3c3cdf1ff1764911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364140Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#799798}
-
Kartik Hegde authored
This change ensures that a problem isn't returned for a routine that isn't run. BUG=chromium:956783 TEST=unit_tests --gtest_filter=SignalStrengthRoutineTest.* Change-Id: I226b632aa65aeb1a9873ce4ac6ae0380f6c3b5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364033Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kartik Hegde <khegde@chromium.org> Cr-Commit-Position: refs/heads/master@{#799797}
-
Andrew Grieve authored
Bug: 1029357 Change-Id: I39cd0de5922bfd583edf203ec6086cbe57d7a99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363806 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#799796}
-
armenk authored
When tooltiptext is changed, view controls should call NotifyAccessibilityEvent(). Combobox, Button, TextField, and ImageView controls are affected by this change. BUG=chromium:1113063 TEST=views_unittests Change-Id: Id372136e5bd49057a87e02d5382a0912773b20fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355406 Commit-Queue: Armen Keshishian <armenk@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#799795}
-
Curt Clemens authored
Implement GetValidPrivateCertificate, DecryptPublicCertificate, and DownloadPublicCertificates in NearbyShareCertificateManager. Bug: b/154865267, b/154863644, b/154866542 Change-Id: Iedc9bee98956ba7585fa5ad7079d6daf9ce6612e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329992 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#799794}
-
wutao authored
This is a reland of c8d093ac Original change's description: > ambient: Use different backend servers > > This patch configs the dev channel to use testing server. But users can > overwrite it with a flag. > > Bug: b/148692733 > Test: manual > Change-Id: I967281bc1421c37d9c1ff74a0815d6a6da570da3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342134 > Commit-Queue: Tao Wu <wutao@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799318} Bug: b/148692733 Change-Id: Id8140c368da44089e15ac9ded3b4faaf8f19efef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364267Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#799793}
-
Nick Harper authored
URLRequestStatus contained two members, an URLRequestStatus::Status and an Error. The Status field isn't used, so the whole class is now replaced with the Error enum. Change-Id: If3ea098aec3765a0f094fc576209b776c63b4c07 Bug: 651119, 490311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342281Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#799792}
-
Ryan Hansberry authored
Use the new bluetooth::mojom::Adapter::SetName() to implement Nearby Connections' BluetoothAdapter::SetName(). See go/nearby-chrome-bt for more information. Bug: b:154848416, b:154845584, b:154847207 Change-Id: I3caf4b8ea5c1724bf1085b18bd4056acad21d774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340877Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#799791}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: none Test: NetworkComponents* Change-Id: I54f3ab4403acf1f758eadbf0ecba6ed52db777bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363874Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#799790}
-
Sven Zheng authored
When these tests are stable, we will move them to CI/CQ. Bug: 1102894 Change-Id: I80b7c8a64e6a176b24c87fe186b4f0b0e5ab01a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363479 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#799789}
-
Abigail Klein authored
it automatically on page load. This CL is the first of two to fix a bug in which focus shifts to the webpage and automatically reads it on page load. Voiceover shifts focus to the webpage on the new tab page. We need to ensure that focus shifts to the webpage when a new page loads, and stays in the omnibox when a user opens a new tab. The fix: Do not fire AXLoadComplete when on Chrome's new tab page. An earlier fix to this bug replaced the AXLoadComplete events with AXNewDocumentLoadComplete events. Voiceover does not listen for the latter, so we remove them here. The urls for the Chrome new tab page were taken from chrome/common/url_constants.h. The browser_accessibility_manager_mac lives in content/ and does not depend on anything from chrome. For a longer explanation of this change, see this document: https://docs.google.com/document/d/19s6E0hjTyzB9XU44bdCpXNOaQ8c6nbLRnJbR1EsltL4/edit# Bug: 1049320 Change-Id: I7f1ef175b9db9c5978a5c3308291d1ba4e2b0531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356187Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#799788}
-
chrome://process-internalsAlex Moshchuk authored
After https://crrev.com/c/2304537, the site URL will no longer contain the process lock URL in the hash, so the lock URL won't be visible on chrome://process-internals. This CL adds the plumbing to show the lock URL independently from site URL, but only if the two URLs are different. This way, we'll be able to view the lock URL in cases where it matters (e.g., for hosted apps), and it won't pollute the UI in the common case where it matches the site URL. For completeness, this CL also plumbs the is-origin-keyed bit, so that all current parts of SiteInfo (foundation of a future SecurityPrincipal abstraction) are shown. The origin-keyed bit is currently only shown when opt-in origin isolation is in effect. Bug: 1105994, 1067389 Change-Id: Ife20bcefc57aecee96e24a436ae89902e0837d20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364816 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#799787}
-
Zentaro Kavanagh authored
Bug: 1089594 Test: manual Change-Id: I835f096589e9eb95f9cf469b43eaf36059df1f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363695Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#799786}
-
Xiaohui Chen authored
Bug: b:161846700 Change-Id: If334c314e2f281dafea7b451863195179aadd12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358036Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#799785}
-
Titouan Rigoudy authored
Content settings have integer enum values, whereas the policy is boolean. We introduce a new handler that performs the translation. We check the fix through policy_test_cases.json. Bug: chromium:986744 Change-Id: Id1c7e8368405d64b1a879250c33678281d66c8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359996 Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#799784}
-
Hua, Chunbo authored
Bug: 982799 Change-Id: Ibe20d74bfe6182b8464855106ca2d09f5dca087c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363462 Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799783}
-
edchin authored
It is time to remove the use of the term "session" in //ios/chrome/browser/snapshots. The identifier used to store and retrieve images from SnapshotCache is called |snapshotID|. The SnapshotCache has no concept of a Tab or WebState. It is merely a collection of images with identifiers. However, SnapshotTabHelper and SnapshotGenerator are tied to a WebState. Within those classes, the unique identifier for a WebState is called |tabID|. When those classes call SnapshotCache, they use the WebState's |tabID| as the identifier to be used in SnapshotCache. Change-Id: Ic08cd0d70b66e4d699bf06c8b5d8afc093e90255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354807 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#799782}
-
Monica Basta authored
Bug: 1119412 Change-Id: Iacb441f18cda7975d2e797fe783caee181c7f98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362804Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#799781}
-
Xi Han authored
The content container which the LayoutManager is attached to has been inflated before the LayoutManager is created. Thus, passing it to the LayoutManager in its constructor, instead of init() method. This is required to support stack tab switcher in instant start. Bug: 1116449 Change-Id: I2761f51d72fdc86248934a7805c8cd27fec85bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356165 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799780}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9c907b44dac7..d1a00aacb9ad 2020-08-19 tvanderlippe@chromium.org [globals] self.UI.context 2020-08-19 sigurds@chromium.org Update protocol defintions 2020-08-19 petermueller@chromium.org Add source panel icon 2020-08-19 tvanderlippe@chromium.org [globals] UI.ActionRegistry 2020-08-19 szuend@chromium.org [ts] Type-check ui/View.js with TypeScript 2020-08-19 petermarshall@chromium.org css: Align service worker status dot vertically 2020-08-19 szuend@chromium.org [ts] Type-check ui/Icon.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1051466,chromium:1058320,chromium:1119311 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib9c1fddccd5c609de0698a71c963cc1ff756e5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364673Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799779}
-
adoneria authored
The tests are getting scheduled in win7 bots currently. (https://ci.chromium.org/p/chromium/builders/ci/win10-omaha-tester-rel/437) Bug: 1109373 Change-Id: I34b37c9dac4bbb301ac591523fd3b48441cf741e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363563Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#799778}
-
Mike Dougherty authored
Changes being made in crrev.com/c/2353092 are breaking these tests when using web::HttpServer. So this CL converts them to the now recommended EmbeddedTestServer. Bug: 891834 Change-Id: Ifa5b28483d8d35038c677fca6cb82608d25cfcfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362976Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#799777}
-
Orin Jaworski authored
This CL adds `sk, sl, sr, sv, sw, ta, te, th, tr, uk, vi, zh-TW` to the set of languages supported by Pedals. Bug: 893183 Change-Id: I5c3d5278018f4de24640357b3190681baa9cbfb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364215 Commit-Queue: Orin Jaworski <orinj@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#799776}
-
Sahel Sharify authored
This cl adds two bits related to the "secure-payment-confirmation" payment method to events_ bitfield. It also adds this payment method to PaymentRequest.TimeToCheckout.Completed.* metric. Bug: 1113937 Change-Id: I92427cd1371ee6bac8dbeb36f81895b0a64c4234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355051Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#799775}
-
Justin Cohen authored
This reverts commit ed3fbbd4. Reason for revert: Still seeing red on both 13.4 and 13.6: https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/25898 https://ci.chromium.org/p/chromium/builders/ci/ios14-sdk-simulator/2399 Original change's description: > [iOS] Use a simpler grey matcher for web view > > For some reason chrome_test_util::WebViewMatcher is flaky in these ones. > Could be related to the keyboard being in screen. > > The flakiness appears to be related to iOS 13.4. Maybe a recent update > to the bots or a version upgrade of earl grey. > > Using a simpler matcher seems to fix the issue. > > Fixed: 1116043, 1116734, 1114899, 1111076, 1115321, 1111258, 1115282 > Change-Id: I9172417a20d5b8e09dc47cd986256fc0a8cb46ba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362892 > Reviewed-by: David Jean <djean@chromium.org> > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799544} TBR=javierrobles@chromium.org,djean@chromium.org Change-Id: If5fe6e3906ed0b0b3a4d5ccce251e34b5829d26d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364226Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799774}
-
Dan Sanders authored
This initial version supports only I420. We'll want to implement explicit conversion and probably color space metadata before adding many more formats. Bug: 1096722 Change-Id: I42949e2a7e9e2135fab260e73da2f2aa420eb424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355390 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#799773}
-
Lei Zhang authored
In the current implementation, sometimes the scope of a page's "pause" is too wide compared to the definition in the spec [1], and sometimes it does not pause at all. So narrow the scope to conform to the spec, and apply it consistently to all possible ways users can print. This is based on an earlier CL [2] which only did this for printing with the system dialog, but not for Print Preview. The first attempt at landing this CL [3] got reverted [4] because it caused bf_cache_browser_tests failures. These tests did not run by default as part of the CQ, which is how [3] passed the CQ. To fix this issue, CL [5] landed to make the test less flaky. Another bug [6] uncovered by the original CL [3] is a bit harder to solve. The issue here is the case where PrintRenderFrameHelper tries to unpause during blink::WebLocalFrameImpl teardown, and it is happening too late. To address this, introduce blink::WebPrintClient, so the WebLocalFrameImpl can tell the WebPrintClient (PrintRenderFrameHelper, really) that it will be destroyed. Then PrintRenderFrameHelper can unpause at the correct time. [1] https://html.spec.whatwg.org/C/#printing-steps [2] https://crrev.com/c/1669250 [3] https://crrev.com/797120 [4] https://crrev.com/797234 [5] https://crrev.com/799501 [6] https://crbug.com/1115475 CQ_INCLUDE_TRYBOTS=luci.chromium.try:android-bfcache-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-bfcache-rel Bug: 956832 Change-Id: Ie328d90094f1b282126d51425200f8810819c3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353886Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799772}
-
Sophie Chang authored
This should hopefully help reduce the number of requests when there is no persistent store available so we don't keep fetching for the host if we know that there was no hint available for it from the server during the session. Bug: 1112500 Change-Id: I6b7514bba0a96fa13866b55287f091ef4201a3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364081Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#799771}
-
Joey Arhar authored
UKM collection review: https://docs.google.com/document/d/1-J9xNy7KQ9AYpFRaGBZu3ZlzPgh8NHxDt1VNAfjvIN0/edit# Bug: 1114171 Change-Id: Ie2391610603ea91ac7d7b9d229efb3b6af0b8610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354658 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799770}
-
Kevin McNee authored
This reverts commit 6d3e7bf2. Reason for revert: Tests fail under msan. https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20286 e.g. [ RUN ] ManagementUIHandlerTests.ProxyServerDisclosureDeviceOffline [14456:14456:0819/094542.091708:576654156:WARNING:server_backed_state_keys_broker.cc(72)] Failed to obtain server-backed state keys. ==14456==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x5640b0ca7d20 in ManagementUIHandlerTests::SetUpProfileAndHandler() ./../../chrome/browser/ui/webui/management_ui_handler_unittest.cc:437:9 #1 0x5640b0cb6cc1 in ManagementUIHandlerTests_ProxyServerDisclosureDeviceOffline_Test::TestBody() ./../../chrome/browser/ui/webui/management_ui_handler_unittest.cc:972:3 ... Original change's description: > Change proxy disclosure at chrome://management > > Change the wording and location of the proxy server disclosure in the > transparency panel. > > Bug: 1116961 > Test: unittests > Change-Id: Id394511a6357329e629a37f19a4f83a4d49ea0db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360073 > Reviewed-by: Andreea-Elena Costinas <acostinas@google.com> > Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org> > Reviewed-by: Greg Levin <glevin@chromium.org> > Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> > Cr-Commit-Position: refs/heads/master@{#799604} TBR=antrim@chromium.org,glevin@chromium.org,mgalonsky@chromium.org,acostinas@google.com Change-Id: I9c1489950f8c2bf71d5ae78ca97f63fce806174e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364481Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799769}
-
Kartik Hegde authored
Add a README containing helpful information for clients and users of network diagnostics. BUG=chromium:956783 TEST=none Change-Id: I44a5c499feda8a870363518f2f46e6b3072615b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360801 Commit-Queue: Kartik Hegde <khegde@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#799768}
-
Sean McAllister authored
Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: Ibf45218c1ba6a609714ba80ee2d7bae28e929f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352689Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#799767}
-
Andrew Comminos authored
This was disabled in the past due to build failures, which are no longer reproducible on the latest checkout. Bug: 600399 Change-Id: I10bbc35d49edf2458d4262fb9201a0997a5e745e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362974Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#799766}
-
Alice Wang authored
This CL adjusts the UI for the sign-in general error screen in the web sign-in flow and add strings needed for the screen. The order of the view elements in account_picker_bottom_sheet_view.xml are rearranged to make sure that the height of sign-in general error screen is the same as the sign-in in progress screen. Screenshot: https://crbug.com/1114589#c5 Bug: 1114589 Change-Id: I281c59eb7a64f7121cf1a8dcd989a32c37f6a1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362588Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#799765}
-
Henrique Nakashima authored
This is a step to modularize ChromeTabCreator. Bug: 1112920 Change-Id: I45d896c1427446d4484947121ae147f6e59c3c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357349Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#799764}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e0a44a28c5be..08a42d0acc75 2020-08-19 mmortensen@google.com query_build_logs: Enable date range searches with --before, --after. 2020-08-19 vapier@chromium.org toolchain: fix capturing of output 2020-08-18 iby@google.com Fix unclear message when deploying SELinux changes 2020-08-18 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-18 bpastene@chromium.org Replace various uses of deploy_chrome's '--to' with '--device'. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I7c7db72ea9449ae3aa672c6aa7e4684e5b0d4b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364279Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799763}
-
Corentin Wallez authored
Following the PSA for API deprecations, the following are removed: - GPUDevice.createBufferMapped - GPUBuffer.mapReadAsync - GPUBuffer.mapWriteAsync Also a small check in ValidateRange is fixed. Bug: dawn:22 Change-Id: I390b9992683e660fece3a17e0671149a40efcd1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351971 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#799762}
-
zhaoyangli authored
Roll all iOS builder and tester machines in infra/config to use Xcode 12 beta 4.Exceptions: - Branched builders. - Goma, WebRTC, cronet builders. - ios-webkit-tot (builder uses a customized Xcode) Changed iOS 13 simulator runtime from 13.4 -> 13.6 for tests in the rolled builders. infra/config change won't be effective for CQ jobs. Thus, iOS builders won't pass CQ due to incompatibility of builder and tester Xcode version. Adding NOTRY label to this change. No-try: true Bug: 1116656 Change-Id: I276e2c6f74d353ad4b07c194c8925331acedb1dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357424 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#799761}
-
Primiano Tucci authored
This is a manual roll to catch up with the changes in http://r.android.com/1393348 https://android.googlesource.com/platform/external/perfetto.git/+log/72e31331da03..ef0fb4c2707e 2020-08-19 lalitm@google.com Merge "tp: use sched blocked reason in thread state table" 2020-08-19 fmayer@google.com Fix non-explicit single-argument ctors. 2020-08-19 lalitm@google.com Merge "tp: parse sched blocked reason from proto and systrace" 2020-08-19 primiano@google.com Merge "Protozero: fall back on the heap when nesting too deep" 2020-08-19 taylori@google.com Update trace_processor Bug: 960303 Change-Id: I62ba6535aa56c1b90cbe9b3a3e6597e9a59e949f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362805 Commit-Queue: Primiano Tucci <primiano@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#799760}
-
Adam Langley authored
|FidoTunnelDevice| performs a caBLEv2 handshake, and passes CTAP2 messages, across a WebSocket. BUG=1002262 Change-Id: I0d6e89019aca292a1795b380a9b87b59971733b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340388 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#799759}
-