- 10 Jan, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bd2510d9..7a4290c4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibe7a8937caae58df49acc513fbeaba6a89ae62c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993717Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730032}
-
Maggie Chen authored
Bug: 775983 Change-Id: I552424ab846568863dfc76f6f0e12e2b4e92d474 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993846Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#730031}
-
Hazem Ashmawy authored
This gradle file was introduced for an effort to compile boundry_interfaces independently from androidx.webkit source code in AndroidX repo. However, we are not proceeding with this approach so this file isn't needed anymore. Bug: b/140178227 Change-Id: Ie579cd7fac0498b27b6653ad56647756fea17476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994281 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#730030}
-
Fabrice de Gans-Riberi authored
TBR=fdegans@chromium.org Bug: 838348 Change-Id: I1ee84587b252a66e63758bdfcea5e0d084cdd665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994562Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#730029}
-
Robert Sesek authored
System colors are read directly out of a read-only shared memory array, so this cache does not contribute any performance benefit. Bug: 641509 Change-Id: I1be0f02dd7ac15d0901ecfc4778ae35baf988a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992169 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#730028}
-
John Williams authored
The CL include a number of related cleanups: - Changed CastActivityRecord and MirroringActivityRecord to eliminate dependencies on MediaSinkServiceBase and CastActivityManagerBase. - Moved some logic from CastActivityManager::FindActivityForAutoJoin into CastActivityRecord::HasJoinableClient. - Moved CastActivityManager::CanJoinSession into CastActivityRecord. - Removed ActivityRecord::connected_clients() and moved the related member variable, connected_clients_, into CastActivityRecord. This variable is now referred to directly in unit tests, and no longer referred to by CastActivityManager. - Renamed SendStopSessionMessageToReceiver to SendStopSessionMessageToClients, and changed implementation to only do what the name suggests. Moved some functionality to the call site in CastActivityManager::TerminateSession, and added unit test for the remaining functionality. - Changed pure virtual methods in ActivityRecord to have no-op implementions, and removed overrides in MirroringActivityRecord: SendStopSessionMessageToClients, SendMessageToClient, SendMediaStatusToClients, ClosePresentationConnections, TerminatePresentationConnections. - Removed pure virtual methods in ActivityRecord that are only relevant to CastActivityRecord: SendAppMessageToReceiver, SendMediaRequestToReceiver, SendSetVolumeRequestToReceiver, HandleLeaveSession, AddClient, RemoveClient. Changed pointers to ActivityRecord to CastActivityRecord in numerous places (mostly in CastActivityManager) so the methods can still be called. Bug: 809249 Change-Id: I4d80cb7356b896781ba157e6e86a8070fc8104b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929085 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#730027}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9346b7c0ed1a..77141ccf844b git log 9346b7c0ed1a..77141ccf844b --date=short --first-parent --format='%ad %ae %s' 2020-01-09 tsepez@chromium.org Remove unused CXFA_FFWidgetHandler::CreateWidget(). 2020-01-09 tsepez@chromium.org Remove two impossible null-argument checks in CPDFSDK_PageView. 2020-01-09 tsepez@chromium.org Remove XFA_TRAVERSEWAY_* definitions Created with: gclient setdep -r src/third_party/pdfium@77141ccf844b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia78d6ec3e61856bb54c295626d2c27d9e40c7a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994405Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730026}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1dbb52862979..e6441b604f58 git log 1dbb52862979..e6441b604f58 --date=short --first-parent --format='%ad %ae %s' 2020-01-10 jiawei.shao@intel.com dawn_wire: Make GetProcs() a static member function of WireClient Created with: gclient setdep -r src/third_party/dawn@e6441b604f58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:996713 Tbr: cwallez@google.com Change-Id: I0296353007a38cfb5cf680c4c24956e32abdccc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994408Reviewed-by:
-
Ahmed Mehfooz authored
This change ensures that the message center and quick settings bubble can not be simultaneously collapsed. Also, the message center will be initially expanded and quick settings collapsed if there are notifications and restricted vertical space. Bug: 1026077, 1026271 Change-Id: If5cf58c3afd1940e69bd30f7ba28d0df93da3719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992214Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#730024}
-
Pete Williamson authored
We've added a SendFeedback menu item for the feed cards which requires syncing a protobuf format with the server. The changes have already been checked in on the server side, this changelist adds them to the client side. TGHis covers the following changes in the feed repo: https://chromium.googlesource.com/feed/+/370d27850dbcb479bf0a3f98b6761dec40ef3ff1 https://chromium.googlesource.com/feed/+/8415ae95f9d6c4b1e8f118937743c6eec95bdf20 https://chromium.googlesource.com/feed/+/38557ae96b06ffa8ca52e56540e90ad4fb9b79c1 https://chromium.googlesource.com/feed/+/ce2ad93db4d120adac692c8b53cc9e574f51dfdd https://chromium.googlesource.com/feed/+/b5279d539debbb6573592b8f28b80b292928a172 https://chromium.googlesource.com/feed/+/ebe07f69fec6980ee571771edd0d7ddf0c721880 Bug: 1040281 Change-Id: I58554c06980de3dfe500276cbc7bff2bf0bce211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993112Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#730023}
-
Manas Verma authored
If the user is opted-in, but the card they have selected is not authorized for FIDO, then we should directly show the CVC prompt without flashing the Verifying Pending Dialog. Bug: 949269 Change-Id: I5bada2553a86303d28956f29308f642cc9025ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994266 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#730022}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9ef631c223a..aed6b2e7fbd5 Created with: gclient setdep -r src-internal@aed6b2e7fbd5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1015953,chromium:1023525 Tbr: jbudorick@google.com Change-Id: If9d3c24f9396fde1501282ef05a34965c191d5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994407Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#730021}
-
Fabrice de Gans-Riberi authored
This reverts commit a1342aa6. Reason for revert: Broke MSAN bots: https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/21649 https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17229 Stack trace from crash: ==29357==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x56541d07524c in views::Label::SetBackgroundColor(unsigned int) ./../../ui/views/controls/label.cc:141:7 #1 0x5654292ce540 in IconLabelBubbleView::OnThemeChanged() ./../../chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc:308:12 #2 0x565429331693 in LocationIconView::UpdateTextVisibility(bool) ./../../chrome/browser/ui/views/location_bar/location_icon_view.cc:195:3 #3 0x56542932f4ff in LocationIconView::Update(bool) ./../../chrome/browser/ui/views/location_bar/location_icon_view.cc:214:3 #4 0x56541d29bb17 in views::View::PropagateAddNotifications(views::ViewHierarchyChangedDetails const&, bool) ./../../ui/views/view.cc:2326:5 #5 0x56541d29ba53 in views::View::PropagateAddNotifications(views::ViewHierarchyChangedDetails const&, bool) ./../../ui/views/view.cc:2322:14 #6 0x56541d2972cf in views::View::AddChildViewAtImpl(views::View*, int) ./../../ui/views/view.cc:2218:9 [...] Original change's description: > Fixed color bugs in CustomTabBarView > > Fixed CustomTabBarView to set and update its colors only once > attached to a widget, preventing the fallback to the default > NativeTheme. > > Updated CustomTabBarView to respond to theme changes. > > Removed the dependency on GetThemeProviderForProfile from > CustomTabBarView and from LocationBarView. > > Bug: None > Change-Id: If505b0bede8f112329dcef5f2a7aab9e67dcfd2e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989085 > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729904} TBR=pkasting@chromium.org,tluk@chromium.org Change-Id: I768a90892980c5522075ed7cda38e2678b797552 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994661Reviewed-by:
-
Olivier Li authored
This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 546640 Change-Id: I0743e2c24e68d42e962cc671139a0c17ffb127c6 Fixed: 1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991753 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#730019}
-
Olivier Li authored
This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 546640 Change-Id: I4d5d350ef28adaf572af0b94024ca4f6549a4548 Fixed: 1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993141 Commit-Queue: Oliver Li <olivierli@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#730018}
-
Andrew Luo authored
Change-Id: Ibf0112584da9a0fec80498d89a4e6c11a3711e3d Bug: 1040667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986062 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#730017}
-
Olivier Li authored
This cl is generated with 'git cl split' This CL was uploaded by git cl split. R=sczs@chromium.org Bug: 546640 Change-Id: I52ab81484aa799323192e0535f91dfb52a453082 Fixed: 1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992546 Commit-Queue: Oliver Li <olivierli@chromium.org> Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
-
Avery Musbach authored
The present CL removes some code in OverviewItem::PrepareForOverview because the same code is in OverviewItem::CreateItemWidget and is not needed twice. Bug: None Change-Id: I3d9acec30eb96a645faece519f47352fb3302a01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993708Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#730015}
-
Joe Mason authored
The nested "Priority Increased" event must end before the parent event so that it doesn't appear to outlive the parent. R=fdoray Change-Id: I673d7c9b364e5ac3321fabcb0a3fc6ddd5cdad88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993802 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#730014}
-
John Budorick authored
They don't run on any of the other android bots. Bug: 1022533 Change-Id: If398941a4f0037e1a05677f5e86e137c927b38c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994273 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#730013}
-
Vi Nguyen authored
Issue backtrace: - video_device_->CreateVideoProcessorOutputView(...) in DXVAVideoDecodeAccelerator::CopyTextureOnDecoderThread() fails because DXGI_FORMAT_R16G16B16A16_FLOAT is not supported by client's hardware. - in DXVAVideoDecodeAccelerator::Initialize, use_fp16_ = true due to "Issue 592074: Add support for different VP9 profiles". - DXGI_FORMAT_R16G16B16A16_FLOAT is in fact not supported, and CheckOutputFormatSupport(DXGI_FORMAT_R16G16B16A16_FLOAT) DXVAVideoDecodeAccelerator::CreateDX11DevManager() reflects that, and use_fp16_ = false. Proposed fix: - Make use_fp16_ an enum to reflect the fact that its non-binary states. - Because intent to use fp16 is expressed in DXVAVideoDecodeAccelerator::Initialize, which can be called before or after support for fp16 is determined, let use_fp16_ be set to kUsing for all states except kUnsupported. kUsing can be reversed later when hardware support is queried. Bug: 1032438 Change-Id: I113f26b126fdc1e0131a2362cbf19629f268f3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974761Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Vi Nguyen <ving@microsoft.com> Cr-Commit-Position: refs/heads/master@{#730012}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7b57298b940d89a72f56b67437d11a2b9420b1c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994404Reviewed-by:
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/core/streams/. Bug: 1001114 Change-Id: I58a9e8d6a65c6c7f33bc61ec39c121202d141cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989321Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#730010}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8d3c0c7a1a60..1386c58de710 git log 8d3c0c7a1a60..1386c58de710 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-09 reed@google.com remove cruft bools from canvas 2020-01-09 jvanverth@google.com Revert "Remove GrPaint::addColorTextureProcessor" 2020-01-09 robertphillips@google.com Move GrVkFormatColorTypePairIsValid assert back into GrVkGpu::check_image_info 2020-01-09 rmistry@google.com Add retries to Android compile bot for when GS returns 502s 2020-01-09 csmartdalton@google.com Speed up get_contour_count in GrTessellator.cpp 2020-01-09 herb@google.com Make SubRun accessible for GrAtlasTextOp 2020-01-09 jvanverth@google.com Hide MakeFromMTKView behind an availability flag 2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-09 herb@google.com Combine result calculation from both legs of if statement 2020-01-09 bsalomon@google.com Remove GrPaint::addColorTextureProcessor 2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-09 brianosman@google.com Fix ByteCodeGenerator's handling of specialized programs Created with: gclient setdep -r src/third_party/skia@1386c58de710 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1037949 Tbr: jvanverth@google.com Change-Id: Iccea3b0d28bc3dae204220ed07e42fd3f20c1bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994402Reviewed-by:
-
nancy authored
BUG=1038487 Change-Id: I05674939efdcc2678eaa0900680ccc7036526eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993000 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#730008}
-
Reilly Grant authored
Bug: 1019783 Change-Id: I9d6e43fb52fde5f35aabae8c71663816dff15e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988812 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#730007}
-
Julie Jeongeun Kim authored
This CL fixes the crash on media_capabilities_fuzzer. NonThrowableExceptionState was used for media_capabilities_fuzzer from crrev.com/c/1962168 but it caused DCHECK crash since NonThrowableExceptionState should not throw ThrowTypeError. It replaces NonThrowableExceptionState with IGNORE_EXCEPTION_FOR_TESTING. Bug: 1001114,1037641 Change-Id: Icb6e76e2d6d5230d264ac2838c1cb57e2cc5d8b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985620Reviewed-by:
-
Jimmy Gong authored
- This is the final CL to remove all code that is deprecated by the new printer settings UI. - Adjusts browser tests to reflect this change. Bug: 1005905 Test: Browser tests Change-Id: Ic2cf98968ca2e4ed4c19462ba8d5da75adc13376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938043 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#730005}
-
Evan Stade authored
This is the only place it's used, and it's view-specific logic so it belongs closer to the view. Bug: 1038415 Change-Id: I10bedda65753cff0b883efdff072afc683a7bc7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989884 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#730004}
-
Kalon Hinds authored
Temporarily disable the DevTools Animation Timeline test in order to land: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1920984 Bug: 963183 Change-Id: Ia1db914f4e9acccf300788084f132c5d8e53a9eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993757Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Kalon Hinds <kahinds@microsoft.com> Cr-Commit-Position: refs/heads/master@{#730003}
-
Glen Robertson authored
Change-Id: I055135607864517abb3a46c8976ccf025344444c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992959 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#730002}
-
Eric Orth authored
This is done in lieu of spreading the new interface work (which allows multiple concurrent probe runs with different contexts) from DnsTransactionFactory to DnsClient. HostResolverManager now directly interacts with DnsTransactionFactory to start/cancel probes as well as restart probes on config or connection change. Still a single probe runner instance (now owned in HostResolverManager instead of DnsClient). The next CL will complete the chain to fully allow multiple runners by inserting them into the HostResolverManager::ProbeRequestImpl objects. Slight logic change in that triggering DoH probes is now disallowed when no DoH servers are configured. This allows reusing DnsClient::CanUseSecureDnsTransactions() for checking if DoH probes are enabled. This was only ever a noop scenario before, so no practical change other than that tests that check for running probes now need to set DoH servers in the test config. Bug: 1022059 Change-Id: I9ce65739abb8fc956973c6e184dd61c52b7e4eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985125 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#730001}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I99023619889a37d62ef45b74bb3267642aab0a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993480 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#730000}
-
Ayu Ishii authored
This changes allows a page to have multiple input forms with autocomplete='one-time-code'. If subscribe has already been called for an SmsClient, it will silently ignore. Without this change, the page will crash upon trying to Subscribe again because each SmsClient is only allowed to be subscribed once in the SmsQueue[1]. This crash is also reproducible by reloading the page with the autocomplete input. [1] https://cs.chromium.org/chromium/src/content/browser/sms/sms_queue.cc?sq=package:chromium&g=0&l=16 Bug: 1037914 Change-Id: I130aeda2b8c9df2328393ec6b42a7cae608ef07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981266Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#729999}
-
Marijn Kruisselbrink authored
Bug: 1027737 Change-Id: Ifcce67116fc50a604b57dc7e73233eefd4729092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993645 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#729998}
-
Avery Musbach authored
See the videos linked in https://crbug.com/1027179. Fixed: 1027179 Change-Id: Ia4f4e112b02297f3d43da81935ee1e97215c3d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979146Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#729997}
-
Liquan (Max) Gu authored
Triggering condition: * Serve a payment app in HTTP * Enable --ignore-certificate-errors: this allow the payment app to be served via HTTP. Description: JourneyLogger has the Java side and the native side. The native side categorizes the payment-methods into these categories exclusively: GCard, basic-card, other. However, the Java side exclude those served via non-HTTPS scheme from being "other", and thus some payment-methods are excluded from being one of the categories. The native side has a DCHECK for the exclusivity that triggering the bug this CL is to fix. Before change: closing the payment app would cause a DCHECK failure in JourneyLogger. After change: no DCHECK failure. Code change: the Java side to include the Payment Apps served via "http" in the "other" category. Bug: 1039408 Change-Id: Ic52f27af88198874791df5d8461318c1e9ee9a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988751Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729996}
-
Thomas Lukaszewicz authored
Removed unnecessary color initialization in the KeywordHintView constructor, eliminating the need to make calls to GetThemeProviderForProfile(). Performed basic cleanup and removal of unnecessary code duplication. Bug: None Change-Id: Ie8948e78cd38446f4248579626fa59a16290a8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993485 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#729995}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I502bfd234506aa7977d34b04e5b6ac123edc59a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993566Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#729994}
-
Peter Kasting authored
This implements suggestions from https://chromium-review.googlesource.com/c/chromium/src/+/1983539 . Bug: none Change-Id: Id621d2bfa806c48d7efaa74b34f17a959dec898e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989703 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#729993}
-
