- 08 Aug, 2014 40 commits
-
-
fgorski@chromium.org authored
* Android Checkin server started handling OAuth2 tokens for checkin very recently and is using the added scope to do it. BUG=374969 R=zea@chromium.org Review URL: https://codereview.chromium.org/452603002 Cr-Commit-Position: refs/heads/master@{#288262} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288262 0039d316-1c4b-4281-b951-d872f2087c98
-
rockot@chromium.org authored
This patch does three related things: 1. Plumbs an optional IdentityProvider through ExtensionUpdater / ExtensionDownloader. 2. Adds support in ExtensionDownloader for OAuth2 token- based authentication to protected Webstore download URLs, using the optional IdentityProvider as its account ID and token source. Bonus points for general cleanup of the credential iteration code in ExtensionDownloader. 3. Wires up Chrome's ExtensionDownloader (via ExtensionService) with a ProfileIdentityProvider so that it may authenticate as the Chrome-signed-in user via OAuth2. BUG=376553,122763 Review URL: https://codereview.chromium.org/434493002 Cr-Commit-Position: refs/heads/master@{#288261} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288261 0039d316-1c4b-4281-b951-d872f2087c98
-
mathp@chromium.org authored
For future use with favicons, remove reference to "thumbnail". There is no functionality change in this CL, just a rename. BUG=388747 TEST=ImageManager* Review URL: https://codereview.chromium.org/445753004 Cr-Commit-Position: refs/heads/master@{#288260} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288260 0039d316-1c4b-4281-b951-d872f2087c98
-
giji.g@samsung.com authored
Moved recvmsg log to VPLOG BUG=377403 Review URL: https://codereview.chromium.org/414243002 Cr-Commit-Position: refs/heads/master@{#288259} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288259 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
The gfx_unittests CanvasTestMac.* passes on Mac Views. (can also run the tests with --enable-harfbuzz-rendertext) BUG=391843 TEST=CanvasTestMac.* passes, no Mac text rendering changes. R=asvitkine@chromium.org,ckocagil@chromium.org Review URL: https://codereview.chromium.org/440213004 Cr-Commit-Position: refs/heads/master@{#288255} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288255 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=399922 Review URL: https://codereview.chromium.org/425713003 Cr-Commit-Position: refs/heads/master@{#288254} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288254 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
I can't actually reproduce the bug as described by the reporter; this is a blind change that expands the minimum width which should theoretically fix the problem though. BUG=400144 Review URL: https://codereview.chromium.org/453573003 Cr-Commit-Position: refs/heads/master@{#288253} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288253 0039d316-1c4b-4281-b951-d872f2087c98
-
nedeljko.babic@imgtec.com authored
In file mips_linux_syscalls.h are definitions of syscall numbers for O32 ABI, so this check is needed in order for Mips architectures with other ABIs to work properly. BUG=400684 TEST=compile sandbox_linux_unittest for MIPS32 and MIPS64 Review URL: https://codereview.chromium.org/446213003 Cr-Commit-Position: refs/heads/master@{#288252} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288252 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
Any leak of boringssl.gyp (which included unittests) ends up pulling in base/ and breaks the WebRTC build. However, switching targets to boringssl_lib.gypi:boringssl breaks GYP because then there are two targets with the same name (boringssl.gyp:boringssl and boringssl_lib.gypi:boringssl). This change gives up and splits the unittests into a different .gyp file. BUG=none Review URL: https://codereview.chromium.org/447213004 Cr-Commit-Position: refs/heads/master@{#288251} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288251 0039d316-1c4b-4281-b951-d872f2087c98
-
msw@chromium.org authored
Add mojo/example/apptest with a service and client. Add example_apptest.cc with a GTest Mojo application. These tests can be run from out/<Debug|Release>/ via: ./mojo_shell --origin=file://`pwd` --disable-cache mojo:mojo_example_apptests BUG=392646 TEST=The new mojo_example_apptests passes. R=ben@chromium.org Review URL: https://codereview.chromium.org/399653004 Cr-Commit-Position: refs/heads/master@{#288250} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288250 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#288249} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288249 0039d316-1c4b-4281-b951-d872f2087c98
-
blink-deps-roller@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=179717:179742&mode=html TBR=jbroman@chromium.org BUG= Review URL: https://codereview.chromium.org/443133004 Cr-Commit-Position: refs/heads/master@{#288248} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288248 0039d316-1c4b-4281-b951-d872f2087c98
-
rtenneti@chromium.org authored
QUIC: don't keep around state for streams created by a request w/no body. Waiting for a stream frame w/ FIN that will never arrive, and the closed stream map grows without bound. Not flag protected. Merge internal change: 72338396 https://codereview.chromium.org/447093002/ Default socket receive buffer to 256K bytes and remove unnecessary CongestionFeedbackFrames from tests. Merge internal change: 72338299 https://codereview.chromium.org/447083002/ Include the socket receive buffer in the connection handshake. PRESENCE_OPTIONAL The goal is to eventually remove the TcpCongestionFeedbackFrame. Currently this sends the same value for every packet. All it contains is the tcp_receive_window (now called socket_receive_buffer) which is fixed at 256000. So it can be sent in the connection establishment and then never retransmitted. Because only one type of CongestionFeedbackFrame can be sent with an ack, this frees up space for a TimestampFrame which is the motivation for removing the TcpCongestionFeedbackFrame. Merge internal change: 72334240 https://codereview.chromium.org/446283002/ Improve QUIC's SendAlgorithmSimulator to allow setting the delayed ack timer and add a new test of a second BBR flow starting after a first flow has stabilized. Merge internal change: 72332690 https://codereview.chromium.org/449713002/ QUIC congestion option that forces ICWND to 10. Not flag protected. Merge internal change: 72323017 https://codereview.chromium.org/446253002/ Allow receiving a QUIC CongestionFeedbackFrame that is not kTCP. Currently the only congestion feedback frames that are sent are TCP, but I want to send timestamp packets in the next version, so the send algorithms should not assume that the incoming congestion feedback frame is kTCP. Merge internal change: 72322097 https://codereview.chromium.org/443313002/ QUIC - minor cleanup to match internal source tree. * Formatting cleanup and .get() != NULL changes. Merge internal change: 72204223 https://codereview.chromium.org/447973004/ Bring back InterArrivalReceiver and rename it to TimestampeReceiver. This is not in production. Merge internal change: 72170964 https://codereview.chromium.org/449693002/ Move Quic AppendTimestampFrame method out of AppendCongestionFrame. Also, remove obsolete TODO's and rename InterArrival to Timestamp. Not used in production. Merge internal change: 72148809 https://codereview.chromium.org/446063005/ R=rch@chromium.org Review URL: https://codereview.chromium.org/447093004 Cr-Commit-Position: refs/heads/master@{#288247} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288247 0039d316-1c4b-4281-b951-d872f2087c98
-
rsorokin@chromium.org authored
BUG=385623 Review URL: https://codereview.chromium.org/357323002 Cr-Commit-Position: refs/heads/master@{#288245} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288245 0039d316-1c4b-4281-b951-d872f2087c98
-
danakj@chromium.org authored
These tests use ContentLayer, so change them to use PictureLayer instead and stop explicitly disabling impl-side painting. R=enne BUG=401492 Review URL: https://codereview.chromium.org/443353003 Cr-Commit-Position: refs/heads/master@{#288244} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288244 0039d316-1c4b-4281-b951-d872f2087c98
-
mlamouri@chromium.org authored
In this context, when needed means when Screen Orientation API is being used. BUG=400158 Review URL: https://codereview.chromium.org/398013002 Cr-Commit-Position: refs/heads/master@{#288243} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288243 0039d316-1c4b-4281-b951-d872f2087c98
-
qinmin@chromium.org authored
We landed a hack earlier to treat all video urls as cross-origin for an security issue. That fix, however, breaks all webgl tests that has video in it. This CL brings a proper fix to the original issue. It uses a new API available in the android L preview System image. For systems below K, the security impact is much less serious than the issue it caused. As a result, we are reenabling video for webgl for systems <=K. And the security issues on these systems should be resolved when devices upgrade. BUG=358198 Review URL: https://codereview.chromium.org/408873004 Cr-Commit-Position: refs/heads/master@{#288242} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288242 0039d316-1c4b-4281-b951-d872f2087c98
-
chromeos-lkgm@google.com authored
Cr-Commit-Position: refs/heads/master@{#288241} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288241 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#288240} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288240 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
Suspected to have broken the Chrome Win build: c:\b\build\slave\google-chrome-rel-win\build\src\base\numerics\safe_numerics_unittest.cc(577) : error C2220: warning treated as error - no 'object' file generated c:\b\build\slave\google-chrome-rel-win\build\src\base\numerics\safe_numerics_unittest.cc(577) : warning C4756: overflow in constant arithmetic > Roll gtest and gmock DEPS. > > These DEPS have not been updated for ~2 years, so there is a good chance > something will blow up. Due to interdependancy between the repos, > rolling gtest required gmock also be rolled. > > BUG=none > > Review URL: https://codereview.chromium.org/425333002 TBR=ncbray@chromium.org Review URL: https://codereview.chromium.org/454823002 Cr-Commit-Position: refs/heads/master@{#288239} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288239 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
TBR=vadimsh@chromium.org BUG= Review URL: https://codereview.chromium.org/450053004 Cr-Commit-Position: refs/heads/master@{#288237} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288237 0039d316-1c4b-4281-b951-d872f2087c98
-
tdresser@chromium.org authored
This enables eager gesture recognition on Aura for the unified gesture detector. BUG=332418 TEST=GestureRecognizer/GestureRecognizerTest Review URL: https://codereview.chromium.org/393953012 Cr-Commit-Position: refs/heads/master@{#288236} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288236 0039d316-1c4b-4281-b951-d872f2087c98
-
treib@chromium.org authored
BUG=372381 Review URL: https://codereview.chromium.org/449543002 Cr-Commit-Position: refs/heads/master@{#288235} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288235 0039d316-1c4b-4281-b951-d872f2087c98
-
mathp@chromium.org authored
To support the redesign, support two new parameters: ta and tf, which stand for text-align and text fade. For text fade, a linear gradient is created to gently fade the text overflow. BUG=400332,400341 TBR=jered TEST=manual Review URL: https://codereview.chromium.org/448793003 Cr-Commit-Position: refs/heads/master@{#288234} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288234 0039d316-1c4b-4281-b951-d872f2087c98
-
mtklein@chromium.org authored
This makes SkPicture::clone() a cheap ref, meaning impl-side painting will render tiles concurrently from the same source SkPicture rather than from clones. After testing for a few months in Skia, we believe SkPicture is thread safe enough to try this out on the Chrome bots. Please revert this at the slightest sign of crash, flaky drawing, etc. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288096 Review URL: https://codereview.chromium.org/445373003 Cr-Commit-Position: refs/heads/master@{#288233} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288233 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
Cr-Commit-Position: refs/heads/master@{#288232} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288232 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@chromium.org authored
BUG= TEST=tree R=kbr@chromium.org Review URL: https://codereview.chromium.org/444083005 Cr-Commit-Position: refs/heads/master@{#288231} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288231 0039d316-1c4b-4281-b951-d872f2087c98
-
rkc@chromium.org authored
This CL adds the main Copresence API. This CL is tracking, https://codereview.chromium.org/438513002. This CL also requires https://codereview.chromium.org/419073002 and https://codereview.chromium.org/433283002 to land to be fully functional. API tests for this API are being worked on by ckehoe@ and we'll be sending a follow on CL tracking this one very soon. Reviews requested, xiyuan@ - General review. kalman@ - API review. isherman@ - histograms.xml OWNERs review. R=derat@chromium.org, isherman@chromium.org, kalman@chromium.org, xiyuan@chromium.org BUG=365493 Review URL: https://codereview.chromium.org/444513005 Cr-Commit-Position: refs/heads/master@{#288230} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288230 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
The tests were flaking because the preview was unexpectedly being shown at the same time as the suggestions. This happened when the mouse happened to be over the preview. BUG=364685 R=isherman@chromium.org Review URL: https://codereview.chromium.org/447423002 Cr-Commit-Position: refs/heads/master@{#288229} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288229 0039d316-1c4b-4281-b951-d872f2087c98
-
oysteine@chromium.org authored
The outgoing renderer sends one or more sets of serialized markup of transition elements, the CSS selectors used to select each of these and its associated allowed destination origin, up to the TransitionRequestManager in Chrome. Once we have a navigation response we then pick up this data again (selecting one of these sets), send it up to the Android embedder, and from there it's used to 1) send a message down to the outgoing renderer to hide the transition elements we selected to use using the CSS selector, and 2) send the serialized markup down to the incoming renderer to inject into its document. R=creis,jam,nasko BUG=370696 Review URL: https://codereview.chromium.org/435833002 Cr-Commit-Position: refs/heads/master@{#288228} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288228 0039d316-1c4b-4281-b951-d872f2087c98
-
gunsch@chromium.org authored
Triggered by https://codereview.chromium.org/369703002. R=lcwu@chromium.org BUG=None Review URL: https://codereview.chromium.org/442213002 Cr-Commit-Position: refs/heads/master@{#288227} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288227 0039d316-1c4b-4281-b951-d872f2087c98
-
dcaiafa@chromium.org authored
Use webrtc::MouseCursorMonitor for cursor shapes instead of webrtc::VideoFrameCapturer, in preparation for deprecating cursor shape functionality in the latter. Fix memory corruption in VideoSchedulerTests_StartAndStop, where a lingering capture task could trigger a expectation action declared on the stack during tear down. My changes to the test somehow made the race condition more likely. BUG=324033 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247689 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248045 Review URL: https://codereview.chromium.org/92473002 Cr-Commit-Position: refs/heads/master@{#288226} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288226 0039d316-1c4b-4281-b951-d872f2087c98
-
kinaba@chromium.org authored
It broke Drive sync completely. > Parse Drive API responses all at once in the blocking pool. > > Previous implementation did the parsing of string to base::Value > on blocking pool, and that of base::Value to specific data types > either on UI thread or on yet another post to blocking pool. > > The previous implementation is slightly inefficient and moreover > involves a subtle bug 284244. > > BUG=284244 > > Review URL: https://codereview.chromium.org/442193002 TBR=kinaba@chromium.org BUG=401843 Review URL: https://codereview.chromium.org/449323002 Cr-Commit-Position: refs/heads/master@{#288216} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288216 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
Cr-Commit-Position: refs/heads/master@{#288210} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288210 0039d316-1c4b-4281-b951-d872f2087c98
-
vadimsh@chromium.org authored
Through CQ this time. R=iannucci@chromium.org BUG=366924 NOTRY=true NOTREECHECKS=true Review URL: https://codereview.chromium.org/452703002 Cr-Commit-Position: refs/heads/master@{#288207} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288207 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
R=vadimsh@chromium.org BUG=366924 Review URL: https://codereview.chromium.org/453753002 Cr-Commit-Position: refs/heads/master@{#288204} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288204 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Jankometer is the last instance of a MessagePumpObserver. Since it has been removed, MessagePumpObserver can also be removed. BUG=none R=darin@chromium.org Review URL: https://codereview.chromium.org/421173003 Cr-Commit-Position: refs/heads/master@{#288203} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288203 0039d316-1c4b-4281-b951-d872f2087c98
-
yojan@google.com authored
Test Runner changes to allow integration tests as well as the ability to point the device's google_base_url (or any android shell flag) to a specified value in stored in a .flags file. BUG=None Review URL: https://codereview.chromium.org/444243002 Cr-Commit-Position: refs/heads/master@{#288202} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288202 0039d316-1c4b-4281-b951-d872f2087c98
-
ericzeng@chromium.org authored
This CL adds an event to the <extensionoptions> tag that fires if the guest view is attempted to be created with an invalid extension id. BUG=386838 Review URL: https://codereview.chromium.org/429763002 Cr-Commit-Position: refs/heads/master@{#288201} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288201 0039d316-1c4b-4281-b951-d872f2087c98
-
dnicoara@chromium.org authored
BUG=398888 Review URL: https://codereview.chromium.org/450753002 Cr-Commit-Position: refs/heads/master@{#288200} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288200 0039d316-1c4b-4281-b951-d872f2087c98
-