- 19 Oct, 2018 40 commits
-
-
Mikel Astiz authored
This patch extends SyncableServiceBasedBridge (core to pseudo-USS) with support for encryption, via a newly introduced interface (ModelCryptographer), which needs to be usable in the model thread (where the bridge lives). This should unblock the migration of PASSWORDS to pseudo-USS, because password data must be encrypted at all times. This is a first step of a proposal described in a dedicated section in the Design Doc: https://docs.google.com/document/d/14ScYZ0sop921gjBwXuReIEuQJlwftqkuSM1jMK_A_x4/edit#heading=h.ev0xr4j8pkot Actual usage of this functionality will be introduced in follow-up patches. Bug: 870624 Change-Id: I227d429dc952bfe1a3a4fb05cd1ab71cac9ba1c6 Reviewed-on: https://chromium-review.googlesource.com/c/1288594 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#601254}
-
Steven Bennetts authored
The CL: * Introduces keyboard.mojom.KeyboardEnableState, an enum used to track the various states that control whether the virtual keyboard should be enabled. Some states enable the keyboard, others disable it. * Moves ownership of the states and the state machine to determine when the keyboard should be enabled to KeyboardController. * Adds mojo interfaces to set and clear states, get the current enabled state, and explicitly reload the keyboard. Note: All mojo API calls to change an enable state will also enable or disable the keyboard accordingly. This is consistent with existing logic where these calls are made so should not change any behavior. Note: Not all calls to keyboard_util.cc helpers have been replaced, including a few in src/chrome, only places where no additional re-factoring is required were changed. Bug: 843332 Change-Id: Ic1741188e2e1ccafda4ad95a71063462ac7f52ff From original CL: TBR=tsepez@chromium.org,shend@chromium.org Change-Id: Ic1741188e2e1ccafda4ad95a71063462ac7f52ff Reviewed-on: https://chromium-review.googlesource.com/c/1291350Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#601253}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/9ead811969b6..cdebbeb8cca2 git log 9ead811969b6..cdebbeb8cca2 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 thestig@chromium.org Roll v8/ c623fabe5..604c50c84 (9 commits) Created with: gclient setdep -r src/third_party/pdfium@cdebbeb8cca2 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I28cd2b9b4aab3c5db4f3da8c7dba5d33ba7bb805 Reviewed-on: https://chromium-review.googlesource.com/c/1291910Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601252}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab631ca2c962..0f44307feaae Created with: gclient setdep -r src-internal@0f44307feaae The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If8e5e068f2904c12f52b6f2436ccdc77fc9ccc6a Reviewed-on: https://chromium-review.googlesource.com/c/1291753Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601251}
-
Ben Pastene authored
Bug: 896410 Change-Id: I1b2825dfe67c7895b1152c854303d79b9d4a20fb Reviewed-on: https://chromium-review.googlesource.com/c/1292049Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#601250}
-
Jialiu Lin authored
Clean up my TODOs. Most of them are no longer needed. Change-Id: I1b9f84ebb40da23ec39c711f9ffef3428319b414 Reviewed-on: https://chromium-review.googlesource.com/c/1289777Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#601249}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/429fb7c2bca7..0537b6aba1bd git log 429fb7c2bca7..0537b6aba1bd --date=short --no-merges --format='%ad %ae %s' 2018-10-19 dproy@google.com Merge "Make chrome trace overview timeline very fast" 2018-10-19 dproy@google.com Merge "Add process grouping for chrome traces" Created with: gclient setdep -r src/third_party/perfetto@0537b6aba1bd The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I482e0cd133ca550c00d9b7b64f7c556734f9d7de Reviewed-on: https://chromium-review.googlesource.com/c/1291755Reviewed-by:
-
Navid Zolghadr authored
We added a sampling scheme when ukm was introduced back in the day to control the amount of data we report to the server. Now that there is a general mechanism for controling the data we can remove our own version of resampling and rely only on the dashboard team to take care of that. Bug: 895463 Change-Id: If23332437205aa027b77a1140f28b9492692791a Reviewed-on: https://chromium-review.googlesource.com/c/1283941Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601247}
-
Chris Palmer authored
Make function names the same kinds of phrases (predicates: "IsFoo" and "HasFoo"); consistent use of curly braces to avoid visual confusion; use positive conditions (`DCHECK(success, ...)`). Bug: 879237 Change-Id: I0157f5676bddd7f8a806b5ece9e95792fbbe3ed0 Reviewed-on: https://chromium-review.googlesource.com/c/1289957 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#601246}
-
Leonard Grey authored
Change-Id: I0f1296099e03ea5c7e585bec8a9d8c57850b0d15 Reviewed-on: https://chromium-review.googlesource.com/c/1291233Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#601245}
-
Greg Kerr authored
The nacl loader process, used only on macOS, currently tries to load an invalid profile type under the V2 sandbox. This loads the correct type. This also adds necessary IOKit resource access to the nacl sandbox profile. Bug: 892554 Change-Id: I3118c00a17502efdd88545ef35e81e3a480d2f15 Reviewed-on: https://chromium-review.googlesource.com/c/1289070Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601244}
-
Xianzhu Wang authored
This is a reland of dcf5246f The fix is to ensure the logger has proper log level. Original change's description: > [run_web_tests] Initialize printer earlier > > This allows logging before creating the port. > > Bug: 896799 > Change-Id: I3198fcaeb8d64d748a12d9882cddc273a9e3efe6 > Reviewed-on: https://chromium-review.googlesource.com/c/1289305 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#601049} Bug: 896799 Change-Id: I7145e2aebf122c6fecf0732d56a81a808cffbe4d Reviewed-on: https://chromium-review.googlesource.com/c/1291358Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601243}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b4d999866772..a31f315c7410 git log b4d999866772..a31f315c7410 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 dgarrett@google.com chromeos_config: Migrate master-paladin to swarming. Created with: gclient setdep -r src/third_party/chromite@a31f315c7410 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6d90a6f1db9520ba2d16a0ecd8fb1de6c41921b1 Reviewed-on: https://chromium-review.googlesource.com/c/1291750Reviewed-by:
-
Robert Liao authored
This provides more API coverage to the MaterialDesignController. BUG= TBR=sky@chromium.org base/test MaterialDesignController test changes. Change-Id: I3898ceb03e3aa7a4096d22aa059720b3ae368858 Reviewed-on: https://chromium-review.googlesource.com/c/1289991Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#601241}
-
Xiaocheng Hu authored
This patch refactors the function to reduce code duplicacy by reusing NGCaretPosition::ToPositionInDOMTreeWithAffinity(). The refactoring also helps implementation of bidi caret affinity. Bug: 894651 Change-Id: I114b65cfbf85966c3daf959da93e0a48a4fe170f Reviewed-on: https://chromium-review.googlesource.com/c/1291780 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#601240}
-
Scott Violet authored
on linux/chromeos with asan tests. This test occasionally triggers leaks, which leads to noise. BUG=897209 TEST=test only change TBR=hbos@chromium.org Change-Id: I62aa05f5213e85edcc4dfab138b0ec316eaf06d4 Reviewed-on: https://chromium-review.googlesource.com/c/1291990Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601239}
-
Ehsan Karamad authored
The static map from process ID to filter (introduced in CL 1240635) is created on UI thread where the (first) ExtensionsGuestViewMessageFilter is added and the subsequent insertions into the map is also done on UI thread. Due to some dependencies on GuestViewMessageFilter, ExtensionGuestViewMessageFilter is destroyed on the IO thread. This opens up a way to thread race bugs between IO and UI thread when inserting and deleting entries; possibly one instance of such bugs is a recent crash spiked after this CL. This CL fixes the issue by 1- Only setting the value of the map to nullptr when the filter is destroyed 2- Post task to UI thread to remove the actual key (with null nullptr) from the static map. Bug: 896791 Change-Id: I7b707f638fb37c8038ce78ca435f92ca3d2263bc Reviewed-on: https://chromium-review.googlesource.com/c/1291213Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#601238}
-
Weidong Guo authored
Background: Two times of continuous swipe up from bezel breaks scroll event in app list because second scroll begin event will be consumed by shelf layout manager, which makes subsequent scroll events go into shelf layout manager instead of app list. Changes: Avoid consuming the scroll event when launcher is visible. Bug: 896934 Change-Id: I46c9ad8f43a15160b890e5a6d4485dbb3e6bed3d Reviewed-on: https://chromium-review.googlesource.com/c/1291788Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601237}
-
Wez authored
Crash can locate particular entries in a stack by scanning for start & end markers with unusual values. We add start & end markers around the |str_stack| copy of the LogMessage string, created when we're about to crash the process due to a FATAL level log message. Bug: 802393 Change-Id: I8fd462cc515ddbefb8c7b34363eea848171aa776 Reviewed-on: https://chromium-review.googlesource.com/c/1201344Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#601236}
-
Peter Boström authored
Removes a significant amount of duplicated and more complicated SetProperty(views::kHighlightPathKey... calls. Bug: chromium:888204 Change-Id: I60761bc66e0340be783ca7bd7a31216874231b6c Reviewed-on: https://chromium-review.googlesource.com/c/1281908Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601235}
-
P Raviraj Sitaram authored
crrev.com/c/1181464 added platform check for platforms kabylake and above. For Geminilake cpuid starts from 0x7A rather than first kabylake platform id programmed. BUG: b:117256558 TEST: compile video_decode_accelerator_unittest on Geminilake platform run ./video_decode_accelerator_unittest \ --test_video_data=test-25fps.vp9:320:240:250:250:35:150:12 Change-Id: Ib0da3391e6cf62c2d6bcd23cd5b125da646f0039 Signed-off-by:P Raviraj Sitaram <raviraj.p.sitaram@intel.com> Reviewed-on: https://chromium-review.googlesource.com/c/1273396Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Justin TerAvest <teravest@chromium.org> Commit-Queue: Justin TerAvest <teravest@chromium.org> Cr-Commit-Position: refs/heads/master@{#601234}
-
Brad Hall authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/486c9b53c4d5..f78187ab7712 $ git log 486c9b53c..f78187ab7 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 bradhall Add optional-dimension argument to swarming 2018-10-08 robertocn [run_isolated] Replace parameters in environment variables. 2018-09-28 borenet Fix symlink bug in file_path.set_read_only() 2018-09-24 maruel [client] improve NamedCache logging 2018-09-24 maruel [client] fix unit test on macOS 2018-09-10 maruel [client] Enforce missing named cache hints 2018-09-04 brucedawson Print precise instructions on collecting swarming results 2018-09-04 maruel [client] fix condition for object 2018-08-31 brucedawson Update README.md with contribution instructions 2018-08-31 brucedawson Print details when kill(9) fails 2018-08-29 maruel [client] Implement the bot side of named cache size hint 2018-08-10 maruel [client] round time in LRU at the second 2018-08-08 maruel [client] uninstall in reverse order 2018-08-03 maruel [client] stop trimming cache in run_isolated 2018-08-01 maruel client: Add Cache.save() 2018-07-25 maruel [client] Overhaul temporary directory override in run_isolated Created with: roll-dep src/tools/swarming_client Bug: 871453 Change-Id: I6ab8a24b99a1424e4ed30835cb75ac14b116507f Reviewed-on: https://chromium-review.googlesource.com/c/1291779Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Brad Hall <bradhall@google.com> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601233}
-
Toni Barzic authored
The app was used as a wrapper around Web Store Widget UI. The widget provides way of displaying filtered list of extensions in Chrome Web Store and is able to request an extension installation. The widget itself is still used in Files app, but the Web Store Widget component app, which was used to list printer provider extensions for a printer when the printer gets plugged in is not used anymore (https://crbug.com/734161), and can be removed. This removes APIs specific to the Web Store Widget app, and stops loading the app in component loader. A CL that removes the app implementation itself will follow. BUG=839992 Change-Id: I06a71ed1527ea41ac6b464c1cad1a7a7279e753f Reviewed-on: https://chromium-review.googlesource.com/c/1289439 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601232}
-
Evan Stade authored
The suppression is obsolete and the tests already work. Bug: 791148 Change-Id: Ifc90e869376cc2833062ab54d32dd93c87f4ad3f Reviewed-on: https://chromium-review.googlesource.com/c/1291786Reviewed-by:
-
Ben Pastene authored
With four retries, that's a total of up to 30s of sleeping. Bug: 892670 Change-Id: I59a870316bbd98e707907dfcb53c82a53a7beab9 Reviewed-on: https://chromium-review.googlesource.com/c/1291711Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#601230}
-
rajendrant authored
This is a reland of adb22130 Original change's description: > NetworkService: Report data use of URLLoader to browser process > > When the requests complete, the total received and sent bytes are sent > to browser process. ChromeDataUseMeasurement records metrics on Chrome-services > data usage and updates metrics service. > > Subsequent CLs will record more metrics and also report this to data > reduction proxy settings page. > > When NetworkService is disabled, DataUseMeasurement will get network > delegate callbacks and record metrics. > > Bug: 808498 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I113e480e4e1c67a65ff7461eb5ae2166a6b038d2 > Reviewed-on: https://chromium-review.googlesource.com/c/1274202 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600928} TBR=kinuko@chromium.org Bug: 808498 Change-Id: I341012581527fefeb6fd23ff16af4ed3a8373aa7 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1290522 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#601229}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/c5a6d259c2fb..715afb0cea5a git log c5a6d259c2fb..715afb0cea5a --date=short --no-merges --format='%ad %ae %s' 2018-10-19 stevenperron@google.com Add a nullptr check to array copy propagation. (#1987) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@715afb0cea5a The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I56ccfc5cf73ffe353a87a55f73084b4bd038d03b Reviewed-on: https://chromium-review.googlesource.com/c/1291754Reviewed-by:
-
Xi Cheng authored
This CL makes the following changes: 1) Change to run image folder cleanup after Chrome startup using a background task, rather than running it at Chrome shutdown using a high priority task. 2) Retain the image folder to avoid deleting and creating it repeatedly. 3) Remove <subdir> from the full path for the temp file, which is unnecessary. 4) Delete the temp files in batch. These changes have the following benefits: 1) Fix the issue of Chrome shutdown being blocked by image file IO for some users as in the current implementation. 2) Save some disk IO related to the sub-directories in the image folder and the image folder itself. 3) Avoid creating a deletion task for each file, otherwise the overhead can be large when there is a steady stream of notifications coming rapidly. Bug: 888276 Change-Id: I214680aa00bd7f19e84e207e82ada553583a094b Reviewed-on: https://chromium-review.googlesource.com/c/1260498 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#601227}
-
Xi Cheng authored
Change-Id: I6a41db414e7e5e834e4d90e4debe55fc9cf2269c Reviewed-on: https://chromium-review.googlesource.com/c/1290514Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#601226}
-
Findit authored
This reverts commit 02cb80e6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 601194 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzAyY2I4MGU2NzA1MmU1OWQzMjRhZTFmNzhkMmM5NGM2M2RhNTI5MzkM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/23519 Sample Failed Step: content_browsertests Original change's description: > Implement fallback content for RemoteFrameOwner > > RemoteFrameOwner does not implement the logic for fallback content. This > means if a cross-origin navigation fails with some error, the owner > element (in this context, <object>) in the parent process does not get > notified and will not use its fallback content (instead the frame might > show an error page). > > When the <object> has fallback content, it should always use that over > the frame's error message. To support this matter, this CL implements > fallback methods in RemoteFrameOwner. Essentially, > > * When <object> creates a local frame, the corresponding frame tree > node will be marked as the type that "can" render fallback content. This > will propagte everywhere using FrameReplicationState. > > * When the provisional loading of a frame fails, RemoteFrameOwner will > notify the browser through the current proxy for navigation. The browser > then uses the parent frame to notify the renderer process that the owner > element should render its own fallback content. > > * If the <object> does not specify fallback, the navigation to error > page commits and the error page is shown. > > * When the <object> renders its own content, the remote frame stays > alive. This is a bug but not a new one; It will be fixed in future CLs. > > Bug: 853140 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: Icad3934ccfc1823c0cdecd8e1223e6370ea4b3bb > Reviewed-on: https://chromium-review.googlesource.com/c/1105635 > Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> > Reviewed-by: Wei Li <weili@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601194} Change-Id: I82ae325ed780fb44d8a8a0205b70f9be8bedc60b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853140 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1291997 Cr-Commit-Position: refs/heads/master@{#601225}
-
Peter Boström authored
This keeps bookmarks-bar entries more aligned with Windows style. Bug: chromium:870158 Change-Id: I7a9e5a147cd9c12a1a5c5de58b40dfdd4c8eb0c9 Reviewed-on: https://chromium-review.googlesource.com/c/1284052Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601224}
-
Ben Pastene authored
Hopefully after crrev.com/i/701289 there's enough capacity this time. TBR=jbudorick, achuith Bug: 876494 Change-Id: I10e8fa31851c8ebd5f38bb233d66c5b0b47bbf29 Reviewed-on: https://chromium-review.googlesource.com/c/1291709Reviewed-by:
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=miu@chromium.org Bug: 681136 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If7d9e65dd131693198a2df86716ba85b0b60ab91 Reviewed-on: https://chromium-review.googlesource.com/c/1288344 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#601222}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/1f120c74ea2e..9ead811969b6 git log 1f120c74ea2e..9ead811969b6 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 tsepez@chromium.org Add static asserts for FPDFDOC_AACTION_* constants. Created with: gclient setdep -r src/third_party/pdfium@9ead811969b6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1be92fc79a1c523ddb1b50f81a8b7decb86af814 Reviewed-on: https://chromium-review.googlesource.com/c/1291752Reviewed-by:
-
Malay Keshav authored
This patch introduces a new PaintOp for Skottie objects. This PaintOp currently does not support serialization/deserialization. This is needed to move the rasterization of skottie onto the worker threads. This patch also introduces a new API in PaintCanvas to accept the new PaintOp. SkiaPaintCanvas Bug: 890224 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I989cafc066f1b43ee4d497a3fa204fc2a7fa90e0 Component: PaintOp, PaintCanvas, RecordPaintCanvas, Reviewed-on: https://chromium-review.googlesource.com/c/1278350 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:Khushal <khushalsagar@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#601220}
-
Vladimir Levin authored
This patch adds the ability to suspend and resume the context, which when suspended prevents future tasks from running. As of right now, the work isn't prevented from finishing since we don't have co-operative work implemented and nothing is preventing the rest of the system from processing the changes. Added tests, a few of which fail due to above reason. R=chrishtr@chromium.org Bug: 882633 Change-Id: I256be53b3cd0071405c9ac783fe78fcd36dacb9c Reviewed-on: https://chromium-review.googlesource.com/c/1289432Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601219}
-
Daniel Bratell authored
Until recently ios didn't use //ipc but //services/network needs some small parts of them. Some of the rest of the ipc code won't even link in ios since ios has no discarding some unused object files before noticing they referenced non-existing symbols. base: :WaitableEventWatcher. It's built so far thanks to the linker Change-Id: Ieaf3749e1b4f0d8f46f652248b839ae9e8650282 Reviewed-on: https://chromium-review.googlesource.com/c/1273498Reviewed-by:
-
Victor Vasiliev authored
Merge internal change: 217702541 R=rch@chromium.org Change-Id: I7f79cc85a57bce8e5c0f819ee83296b30c917320 Reviewed-on: https://chromium-review.googlesource.com/c/1287072 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#601217}
-
Hirokazu Honda authored
Decoded pictures (i.e. yuv format) on h264, vp8 and vp9 must be identical on any platforms, except its pixel format and device alignment. VideoFrameValidator checks soundness of each decoded picture comparing its md5sum value with golden md5sum. VideoFrameMapper used by VideoFrameValidator map decoded pictures and converts them, by libyuv, to I420 picture to resolve pixel format and device alignment differences. This change is the first step for it. VideoFrameValidator would support non tiled buffers. BUG=chromium:856562 TEST=VDA unittest on h264, vp8 and vp9 with --frame_validator at veyron_minnie and kevin, $ ./video_decode_accelerator_unittest --test_video_data=test-25fps.vp8:320:240:250:250:35:150:11 --ozone-platform=gbm --gtest_filter=Thumbnail/VideoDecodeAcceleratorParamTest.TestSimpleDecode/0 --test_import --frame_validator Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iddd284bd47b2a5bb9921dc8d54f9d77ed694f5ad Reviewed-on: https://chromium-review.googlesource.com/c/1172266 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#601216}
-
Tim Volodine authored
Make sure to execute the WebViewClient.OnReceivedError callback in the Network Service case. Also update the test filter with the tests fixed by this patch. Tests fixed: - org.chromium.android_webview.test.ClientOnReceivedErrorTest.testNonExistentAssetUrl - org.chromium.android_webview.test.ClientOnReceivedErrorTest.testNonExistentResourceUrl - org.chromium.android_webview.test.ClientOnReceivedErrorTest.testOnReceivedErrorOnInvalidUrl - org.chromium.android_webview.test.ClientOnReceivedError2Test.testNotCalledOnStopLoading - org.chromium.android_webview.test.ClientOnReceivedError2Test.testOnNonExistentAssetUrl - org.chromium.android_webview.test.ClientOnReceivedError2Test.testOnNonExistentResourceUrl - org.chromium.android_webview.test.ClientOnPageStartedTest.testOnPageStartedCalledOnceOnError In more detail in this patch: - add wiring for executing the onReceivedError callback - separate GetAwContentsClientBridgeFromID into a separate function BUG=893574,893573,893572,841556 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic674c13ba0aad9a7eedc32194bb6f3fa27ea3ad5 Reviewed-on: https://chromium-review.googlesource.com/c/1279171 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#601215}
-
