- 14 Nov, 2018 40 commits
-
-
Findit authored
This reverts commit 9f695d72. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 607896 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOWY2OTVkNzI0OWM5MjZkZGRlODUxNWNlNWU3YmY4NTA1YWRkZWNjMww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/54191 Sample Failed Step: browser_tests Sample Flaky Test: PrintPreviewDestinationSettingsTest.ChangeButtonState Original change's description: > Print Preview Refresh: Enable change button while destination loads > > In some cases (e.g. kiosk apps with no default printer configured), the > print destination may never load. Enable the "Change" button while > destination capabilities are loading so that the user can switch > destinations in this case. > > Bug: 901115 > Change-Id: I53eec9332e0d7f075e461226290d408ae6d6ef49 > Reviewed-on: https://chromium-review.googlesource.com/c/1332703 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607896} Change-Id: I67b37b31938b6af5c19edc09a1e66b9019d0e198 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 901115, 905205 Reviewed-on: https://chromium-review.googlesource.com/c/1335278 Cr-Commit-Position: refs/heads/master@{#607919}
-
Joel Hockey authored
Bug: 878324 Change-Id: I7f14a0734ea2371215d41a2df7e4b3d0255afde6 Reviewed-on: https://chromium-review.googlesource.com/c/1334670 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#607918}
-
Findit authored
This reverts commit 656c20b3. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 607881 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjU2YzIwYjNhYWE0OGRiOTM4ZDYxNmMxZjQ2YjQ1ZGQ1NGMyMDZjMAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/15973 Sample Failed Step: single_process_mash_browser_tests Sample Flaky Test: LocalCardMigrationBrowserTest.ClickingSaveClosesDialog Original change's description: > [Autofill] Added browser tests for local card migration dialog. > > Relanding browser tests for local migration flow. Commented out flaky tests that were causing issues earlier. > > Bug: 897998 > Change-Id: I7dd0fdb5f71587bddc236732c6d3725dc6411818 > Reviewed-on: https://chromium-review.googlesource.com/c/1332704 > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Manas Verma <manasverma@google.com> > Cr-Commit-Position: refs/heads/master@{#607881} Change-Id: I128c446c52bd22b7c1957b69307d4768b5b39166 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897998 Reviewed-on: https://chromium-review.googlesource.com/c/1335277 Cr-Commit-Position: refs/heads/master@{#607917}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1e00aebd9a45..ccc31e9e3220 git log 1e00aebd9a45..ccc31e9e3220 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2778029563f2..d1a55e393e65 (2 commits) Created with: gclient setdep -r src/third_party/skia@ccc31e9e3220 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: I5f15840c8434fffc207fe7cef48148e6a97e3968 Reviewed-on: https://chromium-review.googlesource.com/c/1335094Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607916}
-
Sadrul Habib Chowdhury authored
After the fix in crrev.com/c/1322364, a bunch of tests that use the testRunner.capturePixelsAsyncThen() API can be turned back on. BUG=891427 Change-Id: Ice7d7b5f4dd0e0096363820cd4433ce0404ec83e Reviewed-on: https://chromium-review.googlesource.com/c/1330993 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#607915}
-
Sheng-hao Tsao authored
This reverts commit 1de878d8. Reason for revert: Causes many crashes like https://bugs.chromium.org/p/chromium/issues/detail?id=903443 https://buganizer.corp.google.com/issues/119116273 Original change's description: > Show consolidated camera icon on shelf > > This CL fixes 2 bugs: > > 1. Users might pin the internal app to the shelf. Clicking on it would > launch a real camera app, causing 2 camera icons shown on the shelf. > 2. Users might pin the currently running camera app on the shelf. If the > users click on it afterward, it will bypass the internal app deciding > logic and always launch that specific app. > > pinned the internal camera app icon, and launching camera app from it > does not show 2 camera icons on shelf. > > Bug: b:117909556 > Test: Tested on eve that pinning camera app on launcher or on shelf both > Change-Id: I0300456595e6c4c00c1a47f7a3bc7309d1230553 > Reviewed-on: https://chromium-review.googlesource.com/c/1303327 > Commit-Queue: Sheng-hao Tsao <shenghao@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603793} TBR=stevenjb@chromium.org,shenghao@google.com,wutao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:117909556 Change-Id: I20f4ea5762b29dbdbba0ad08592ff3755f06c023 Reviewed-on: https://chromium-review.googlesource.com/c/1328632Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#607914}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d20b521f5864..a89ef2b38df0 git log d20b521f5864..a89ef2b38df0 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 thestig@chromium.org Revert "Remove some checks that are never true in patterns code." Created with: gclient setdep -r src/third_party/pdfium@a89ef2b38df0 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:904726 TBR=dsinclair@chromium.org Change-Id: I39606d138b366282511ab755607a1a9e9c127a18 Reviewed-on: https://chromium-review.googlesource.com/c/1335093Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6ce627d2b73d..b0c06d4b490c git log 6ce627d2b73d..b0c06d4b490c --date=short --no-merges --format='%ad %ae %s' 2018-11-13 sadrul@chromium.org rendering: Fix tasks_per_frame_ unit. 2018-11-13 benjhayden@chromium.org Add Range as es6 module for v2spa. 2018-11-13 benjhayden@chromium.org Add triage-new for v2spa 2018-11-13 chiniforooshan@chromium.org Telemetry: Fix a bug in sorting latency events 2018-11-13 benjhayden@chromium.org Add MemoryComponents for v2spa Created with: gclient setdep -r src/third_party/catapult@b0c06d4b490c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:760553,chromium:903312 TBR=sullivan@chromium.org Change-Id: Ic3288203c26cd02bea6122a76a63f3db22647362 Reviewed-on: https://chromium-review.googlesource.com/c/1335089Reviewed-by:
-
Jamie Madill authored
These bots will be used to trigger tests on the ANGLE CQ. Mirrors the design used in the existing files and in http://crrev.com/c/1326157 . Only tackles Windows for now. Will be extended to other platforms. Also adds a few NVIDIA dEQP tests and cleans up some ANGLE test naming. Bug: 822310 Change-Id: I5638bdc8588bdf3a4716fd45380ad25cc35ee121 Reviewed-on: https://chromium-review.googlesource.com/c/1333995Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#607911}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/357df2f5f824..890400d12a0a Created with: gclient setdep -r src-internal@890400d12a0a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib4bf25554f57a769ee8351475619b229e98b7394 Reviewed-on: https://chromium-review.googlesource.com/c/1335092Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#607910}
-
Zinovy Nis authored
Bug: <none> Change-Id: Ic73229f3d4c4137f84194fe3db7287308f37fa2d Reviewed-on: https://chromium-review.googlesource.com/c/1329675Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#607909}
-
Joel Hockey authored
Bug: 878324 Change-Id: I2d738bb3f980d200b946f0b6cf7522b830f4d5ac Reviewed-on: https://chromium-review.googlesource.com/c/1334669Reviewed-by:
-
Xiaocheng Hu authored
This patch hoists the creation of VisiblePosition from StartOfWord to its caller ComputeStartRespectingGranularityAlgorithm to reduce the usage of VisiblePosition. Bug: 657237 Change-Id: If1489b363717d751f6e0d8ebc323f6e80045c8af Reviewed-on: https://chromium-review.googlesource.com/c/1330760Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#607907}
-
Sadrul Habib Chowdhury authored
A number of layout tests requests a testRunner.capturePixelsAsyncThen(). When not using the display-compositor for pixel-dumps, this triggers a complete composition (i.e. this triggers a commit, raster, frame submission, and processing in the display compositor). The tests that use the testRunner.capturePixelsAsyncThen(callback) API expects these steps to be completed before the callback is run. However, when using the display-compositor for pixel-dumps, it immediately triggers the callback without doing any of these steps. This caused a bunch of tests to fail, or become flaky, when --enable-display-compositor-pixel-dump became the default. This patch fixes the flakiness, by making sure the callback is run only after all the required steps have been performed. This is done by forcing a redraw, and requesting a presentation-timestamp from viz. This does not actually fix the readback itself, i.e. the pixels returned to the callback is still invalid. However, this does fix the timing of running the callback. That is sufficient to fix a number of the existing flaky tests. Bug: 891427 Change-Id: Ic09db1c3a0a410b2d5687999d7144260df7ea272 Reviewed-on: https://chromium-review.googlesource.com/c/1322364Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#607906}
-
John Chen authored
Disable test case ChromeDriverSiteIsolation.testCanClickOOPIF on Mac. It appears to occasionally put the test HTTP server into a bad state, causing large number of failures in subsequent test cases. TBR=crouleau@chromium.org Bug: 904061 Change-Id: I230b445dd701a1c894fb65a51a60933ab586bc23 Reviewed-on: https://chromium-review.googlesource.com/c/1335271Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#607905}
-
Lei Zhang authored
Keep the enable_foo conditionals in alphabetical order. Change-Id: I63712cae90f46901602d480311c3ef565e8e6ca1 Reviewed-on: https://chromium-review.googlesource.com/c/1330904 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#607904}
-
Joel Hockey authored
Change-Id: I42a6b49cc52dfc2a085c1b6ffad6b72ab6e34a11 Reviewed-on: https://chromium-review.googlesource.com/c/1335053Reviewed-by:
-
Dmitry Gozman authored
Bug: 805557 Change-Id: Ib6f37ec6e1d091ee54621cc0c5c44f1a6beab10f Reviewed-on: https://chromium-review.googlesource.com/c/1334847Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#607902}
-
Stephen Chenney authored
The background image fast path painting rounds the image src rect to integer sizes assuming sprite maps and/or reasonably large images. When a very small image is used scaled up to a large size (such as constant color images scaled up to form progress bars by animating background size) the src rect may be 1 x [small number] which gets rounded to zero size. This patch changes the code to detect this situation and not round in such cases. It's worth recording that an alternate approach is to detect when the rounding results in a significant change in src rect and always switch to unrounded in that case. But it would be more expensive for a relatively uncommon case. R=fmalita BUG=904042 Change-Id: I24657a5d087c0dda0fd8a5e3c3d08e1e4eb02473 Reviewed-on: https://chromium-review.googlesource.com/c/1334291Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#607901}
-
Esmael El-Moslimany authored
Bug: 903212 Change-Id: I2963b22bb55a0a3459331303887c6697e973489d Reviewed-on: https://chromium-review.googlesource.com/c/1334830 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#607900}
-
Aaron Leventhal authored
Bug: 904428 Change-Id: I944fe959a6eb8ac00a4226e879a22a09a22a40c2 Reviewed-on: https://chromium-review.googlesource.com/c/1331144 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#607899}
-
Yuri Wiitala authored
Fixes were made to restore the functioning of the tests in commit c9cee7e5. Bug: 789192 Change-Id: I3ec2b8a2dd3a04f24dbcc3998ca3f7f138cc281f Reviewed-on: https://chromium-review.googlesource.com/c/1334852Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#607898}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I39ef32ef3bbd394f306b2a1408ecb5eb9fb4bc67 Reviewed-on: https://chromium-review.googlesource.com/c/1335347Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#607897}
-
rbpotter authored
In some cases (e.g. kiosk apps with no default printer configured), the print destination may never load. Enable the "Change" button while destination capabilities are loading so that the user can switch destinations in this case. Bug: 901115 Change-Id: I53eec9332e0d7f075e461226290d408ae6d6ef49 Reviewed-on: https://chromium-review.googlesource.com/c/1332703 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#607896}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c242459120d..1e00aebd9a45 git log 6c242459120d..1e00aebd9a45 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 caryclark@skia.org fix pathops fuzz 2018-11-13 reed@google.com cubicmap should pin its input -- I guess 2018-11-13 reed@google.com change SkTextEncoding to enum class 2018-11-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b3c4d88a647a..02ce5830e7db (1 commits) 2018-11-13 brianosman@google.com Move new WriteVertexData utility to a GrVertexWriter helper struct 2018-11-13 mtklein@google.com refactor SkBitmapProcState_opts_SSSE3 2018-11-13 csmartdalton@google.com sksl: Support fwidth() Created with: gclient setdep -r src/third_party/skia@1e00aebd9a45 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Ie7495c6edc214e5237d0c7f8fc72ed4f587039e8 Reviewed-on: https://chromium-review.googlesource.com/c/1335088Reviewed-by:
-
Ken Rockot authored
With the exception of Service Manager internals, which will be migrated in a follow-up CL, this makes the following changes across the tree: - Any valid use of Identity is updated to use complete Identity values with no fields absent. This is for stuff like manual service instance registration, or using concrete Identity values from the Service Manager. - All other uses of Identity are switched to ServiceFilter. Bug: 902590 Change-Id: I112d501e04ec22461635654ebd3f597bb2bbf396 Reviewed-on: https://chromium-review.googlesource.com/c/1331869Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f28410e9eb26..d20b521f5864 git log f28410e9eb26..d20b521f5864 --date=short --no-merges --format='%ad %ae %s' 2018-11-14 thestig@chromium.org Roll v8/ a4f6a37da..d5f263024 (409 commits) Created with: gclient setdep -r src/third_party/pdfium@d20b521f5864 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I954f1dba59ca3d766cedead3309cd6a672d7b8e8 Reviewed-on: https://chromium-review.googlesource.com/c/1335091Reviewed-by:
-
Hiroki Nakagawa authored
This is just a cleanup CL, and there're no functional changes. Bug: n/a Change-Id: I60820045469eed4a0903b37af9e4f8927bcc884d Reviewed-on: https://chromium-review.googlesource.com/c/1335047Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#607892}
-
Lin Sun authored
Remove following suppressions for Intel: deqp/functional/gles3/framebufferblit/conversion_07.html BUG=598902 Change-Id: Ia1be2d893438d43a571838eff571427093bef145 Reviewed-on: https://chromium-review.googlesource.com/c/1317349Reviewed-by:
-
Chih-Yu Huang authored
The autotest video_ChromeHWDecodeUsed verifies Chrome used the HW decoding when playing a video stream by checking the histogram value, which is reported from GpuVideoDecoder. In order to keep the test pass during switching from GpuVideoDecoder to MojoVideoDecoder, we have to report the same histogram value temporarily from MojoVideoDecoder. With this CL, we can enable MojoVideoDecoder at ChromeOS platform. BUG=chromium:902968 TEST=Pass video_ChromeHWDecodeUsed autotest on Eve TEST=Play video at Youtube on Eve and confirm the successfull option of Media.GpuVideoDecoderInitializeStatus are increased. Change-Id: I26fc53704843e9b153bbee304e8f60ab3a7b0417 Reviewed-on: https://chromium-review.googlesource.com/c/1328634 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#607890}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I2a01274b3caf78d0d714aab391783b554bc4a16e Reviewed-on: https://chromium-review.googlesource.com/c/1335090Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/def2885f901d..357df2f5f824 Created with: gclient setdep -r src-internal@357df2f5f824 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8ce36da709dc52d9193694e75671578cffb1ea1e Reviewed-on: https://chromium-review.googlesource.com/c/1335087Reviewed-by:
-
Vlad Tsyrklevich authored
Currently, base::bits::Count{Leading,Trailing}ZeroBits fail to link when used with 64-bit inputs on 32-bit MSVC builds because MSVC only implements the _BitScan{Forward,Reverse}64 intrinsics for 64-bit builds. Fix this by implementing equivalent support using 32-bit intrinsics. Change-Id: I9b9095abd03587c29dd642df65cf9783bd9b202d Reviewed-on: https://chromium-review.googlesource.com/c/1321253Reviewed-by:Albert J. Wong <ajwong@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#607887}
-
Aidan Wolter authored
Creates a mapping between the audio group ids and the application session id. When the CAOS is created, it uses the group id in the audio params to look up the session id and uses that to retrieve the proper MultiroomInfo. Bug: b/111669896 Test: Cast to a MZ group, cast_media_unittests, cast_base_unittests, cast_shell_unittests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6979bbb2bfc118e4d135bfd354ce1ad956503182 Reviewed-on: https://chromium-review.googlesource.com/c/1221067 Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#607886}
-
Lin Sun authored
Remove following suppressions for Intel on Linux: conformance/renderbuffers/depth-renderbuffer-initialization.html conformance/renderbuffers/stencil-renderbuffer-initialization.html BUG=794339 Change-Id: Ibf3cd5a96a22b7318730fb981dbbe7ce063f4f2e Reviewed-on: https://chromium-review.googlesource.com/c/1309429Reviewed-by:
-
John Budorick authored
Tbr: crouleau@chromium.org,nednguyen@google.com,perezju@chromium.org Bug: 903849 Change-Id: I2821fc28f5c63a036d563a6350db4659c4fb5440 Reviewed-on: https://chromium-review.googlesource.com/c/1334831Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#607884}
-
Weidong Guo authored
Background: When dragging home launcher down to show a window, the window will be shown on drag start and will slide down on drag update. However, this does not work for window with modal dialog because the dialog's visibility change cancels the touches for all other windows. Changes: Avoid cancel touches on windows that are not in the same transient window tree of the modal dialog. Bug: 900321 Change-Id: I2047224de2f6fac9e892376477b7bf9c938cc2c0 Reviewed-on: https://chromium-review.googlesource.com/c/1316434 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#607883}
-
Carlos IL authored
This reverts commit 91d24688. Reason for revert: This CL made ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange flaky (crbug.com/904108) reverting while investigating why. Original change's description: > Variations service now checks explicitely if previous attempt was HTTP. > > Variations service now sets a flag if the last request was an HTTP > retry, and uses it to decide whether to retry again, instead of > relying on the scheme of the final URL. Also, retries are now disabled > if the fallback url is HTTPS. > > Bug: 902727 > Change-Id: Ibd6df4a22bc6302b231aff0ae32f8e1c8a1f277c > Reviewed-on: https://chromium-review.googlesource.com/c/1325035 > Commit-Queue: Carlos IL <carlosil@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607022} TBR=asvitkine@chromium.org,carlosil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 902727 Change-Id: I67036ea20097f889e71de5179a2e4510a201388d Reviewed-on: https://chromium-review.googlesource.com/c/1334421Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#607882}
-
Manas Verma authored
Relanding browser tests for local migration flow. Commented out flaky tests that were causing issues earlier. Bug: 897998 Change-Id: I7dd0fdb5f71587bddc236732c6d3725dc6411818 Reviewed-on: https://chromium-review.googlesource.com/c/1332704Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#607881}
-
Jia authored
If experiment param is valid, a global curve will be constructed from it. Otherwise a default value will be used. Bug: 881215 Change-Id: I0986a145bc943d190fbc9609630e9d21ef5d57e7 Reviewed-on: https://chromium-review.googlesource.com/c/1333097 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#607880}
-
