- 29 Nov, 2018 40 commits
-
-
Sam McNally authored
Bug: 909056 Change-Id: Ifd3eeffdc9bca6befdb21c7db84514717516cd21 Reviewed-on: https://chromium-review.googlesource.com/c/1354744Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#612105}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I3bad6b7e2cb925f559f10fc9d7510763e98e3b19 Reviewed-on: https://chromium-review.googlesource.com/c/1354635Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612104}
-
Keishi Hattori authored
Convert P*, R* class allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: I9df78f5d474752188412e07c880074b7f722207e Reviewed-on: https://chromium-review.googlesource.com/c/1350428 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#612103}
-
Yuta Kitamura authored
This CL rewrites #include lines of web_task_runner.h, which is now deprecated. Instead of web_task_runner.h, new include lines of post_cancellable_task.h and/or post_cross_thread_task.h are inserted, depending on what's used in each file. This CL only touches #include lines and nothing else. Bug: 826203 Change-Id: I3b4ae2d9e62966acac0400bd0c802fef3b3aecf9 Reviewed-on: https://chromium-review.googlesource.com/c/1351206 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
CreateContext() doesn't acquire lock if it is called by VaapiWrapper's caller. Lock should be acquired always in CreateContext(). This change also removes DestroySurfaces_Locked() and instead DestroySurfaces() is called everywhere. CreateSurfaces() and DestroySurfaces() are renamed to CreateContextAndSurfaces() and DestroyContextAndSurfaces() to specify what they are doing. Bug: 909547, 909561 Test: VDA, VEA, JDA, JEA unittest on eve Change-Id: Ib04386307c2e83d83e0afe079a1868ac02eff086 Reviewed-on: https://chromium-review.googlesource.com/c/1353056 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#612101}
-
Kent Tamura authored
For "Web Test". This CL has no behavior changes. Bug: 843412 Change-Id: Ic3cf211efc420f07528df5fcfd9193f08f99dcf0 Reviewed-on: https://chromium-review.googlesource.com/c/1353068Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#612100}
-
Sam McNally authored
Bug: 909056 Change-Id: Iaf5d3909b8a63f4beca7feda97e20695e5537a2b Reviewed-on: https://chromium-review.googlesource.com/c/1354747 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612099}
-
Hayato Ito authored
This CL is separated out from the wip CL, https://crrev.com/c/1350441, where recursive recalc slot assignment causes the tricky bug which is hard to debug. It would be better to detect recursive recalc slot assignment, which shouldn't happen. Change-Id: I07d2d22ea8e083ef1de5134d6879cb1a141ce183 BUG=906494 Change-Id: I07d2d22ea8e083ef1de5134d6879cb1a141ce183 Reviewed-on: https://chromium-review.googlesource.com/c/1354727Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#612098}
-
Xiaohui Chen authored
Fix shutdown crash in default_url_request_context_getter. Base class url_request_context_getter::OnDestruct() already posted the destruction to network_task_runner. This makes the thread join in default_url_request_context_getter crash because it is joining on the same thread. This cl removes the posting and joining logic in default_url_reqeust_context_getter since it is duplicate with the base class. We cannot create and hold the thread object either because that will implicitly join when destrcted, causing the same error. We use the global IO task runner instead. Bug: b:120096335 Test: locally build and run. Does not crash during shutdown. Change-Id: I80672c99eeab52198158bbb0e6471ccca1dcc21f Reviewed-on: https://chromium-review.googlesource.com/c/1354034Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#612097}
-
Dan Beam authored
TBR=scottchen@chromium.org Bug: None Change-Id: I122dacc4367c85074cc21c8f9882df973fd010be Reviewed-on: https://chromium-review.googlesource.com/c/1354330 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#612096}
-
Amos Lim authored
According to the spec, the createImageBitmap should be moved to WindowOrWorkerGlobalScope mix-in. They were moved from the ImageBitmapFactories mix-in to the WindowOrWorkerGlobalScope mix-in[1]. [1]: https://github.com/whatwg/html/commit/cdd48e1f570c817402bf62108847c4a9f4b00b1e [2]: https://html.spec.whatwg.org/multipage/webappapis.html#windoworworkerglobalscope-mixin This CL has no behavior changes. Bug: 701457 Change-Id: Idbf0cf3e22019cc24384ab3c409e202343eb1d5a Reviewed-on: https://chromium-review.googlesource.com/c/1349160 Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#612095}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/22619c2e1a6d..0113b4085f5a git log 22619c2e1a6d..0113b4085f5a --date=short --no-merges --format='%ad %ae %s' 2018-11-29 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 79d0e565b001..a972758d6e10 (1 commits) 2018-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c4e0a1e511fc..2c0d6a9404cd (4 commits) Created with: gclient setdep -r src/third_party/skia@0113b4085f5a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I536845019d34306d4d95f85ee095e6b89aa905c6 Reviewed-on: https://chromium-review.googlesource.com/c/1354632Reviewed-by:
-
Maksim Sisov authored
This patch makes it possible to compile ozone/wayland on systems without gbm available. on a system without gbm available. TEST: compile ozone/wayland with use_wayland_gbm = false Change-Id: Ibda6632dcafe5ba0a46a819045b7f366d5c76a46 Reviewed-on: https://chromium-review.googlesource.com/c/1350983 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612093}
-
Guido Urdaneta authored
This metric find cases of Web sites that use complex SDP. Complex SDP can lead to errors if the application assumes the wrong default SDP format. Tracking this is important during the transition of the default SDP format from Plan B to Unified Plan. Review: https://docs.google.com/document/d/1kiUze0n2yJGK2_TVhyKoGbER-xFlwZZaLLrjy0w4dek/edit Bug: 900951 Change-Id: Ic0eb065e73f2e7578f883b75477193e0019fcc62 Reviewed-on: https://chromium-review.googlesource.com/c/1347364 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#612092}
-
Marc Treib authored
It has been replaced by SyncUserSettings::IsFirstSetupComplete. Note that *Profile*SyncService::IsFirstSetupComplete still exists for now (it's used by SyncUserSettings). This will be changed in a later CL. There were 3 remaining places that still used the SyncService version of IsFirstSetupComplete; those are trivially migrated to SyncUserSettings. Bug: 884159 Change-Id: I90b29436986a7220803c61e2f2767c620e291e71 Reviewed-on: https://chromium-review.googlesource.com/c/1352785Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#612091}
-
Ken Rockot authored
Migrates prefs service away from the deprecated ServiceContext API to ServiceBinding, and migrates its tests from the deprecated ServiceTest framework to regular unit tests. Bug: 891780,906239 Change-Id: Id5d73b2aa6c87d40d3e9814946c91494a18afd66 Reviewed-on: https://chromium-review.googlesource.com/c/1351875 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#612090}
-
Sam McNally authored
Bug: 909056 Change-Id: I59ba6c3b5bbaa22551a3b31229f394ce24ed0470 Reviewed-on: https://chromium-review.googlesource.com/c/1354750Reviewed-by:
-
Sam McNally authored
Bug: 909056 Change-Id: Ifd26dc5037d52bf98973b9e500695cbc27ecc6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1354735Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2c0d6a9404cd..7310da33bc7a git log 2c0d6a9404cd..7310da33bc7a --date=short --no-merges --format='%ad %ae %s' 2018-11-29 yizhou.jiang@intel.com Implement GetMultismaplefvANGLE and SampleMaskiANGLE of texture multisample extension Created with: gclient setdep -r src/third_party/angle@7310da33bc7a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I42909a3dddf5f6cf337c65db1c954954f7cf73cd Reviewed-on: https://chromium-review.googlesource.com/c/1354630Reviewed-by:
-
Sam McNally authored
Bug: 909056 Change-Id: Idafd58064585c900805629044cd192b2cfe2461a Reviewed-on: https://chromium-review.googlesource.com/c/1354731Reviewed-by:
-
Sam McNally authored
Bug: 909056 Change-Id: Ic5a91cccb89c55d65217e6e55444878e4ab623cd Reviewed-on: https://chromium-review.googlesource.com/c/1354733Reviewed-by:
-
Hirokazu Honda authored
Formerly, V4L2JEA calls S_FMT one time for YUV420M and checks if the pixel format filled by driver is either YUV420 or YUV420M. Then, a driver can fill NV12 even if it supports YUV420. V4L2JEA would rather execute S_FMT for YUV420M and YUV420 separately and check if the returned format is exactly same as the specified one. Bug: 908357 Test: VEA unittest on kevin Change-Id: I15b5bae4f8d1c728f0db0bb961a1f5d39fed3c53 Reviewed-on: https://chromium-review.googlesource.com/c/1352074 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#612084}
-
David Staessens authored
This change moves all test-related setup and teardown to a separate test environment. It also fixes a small bug that causes a crash when destroying the video player without playing a video. TEST=ran new VD tests on nocturne BUG=879065 Change-Id: I0f746ff3aff1598130d563aa8241e87f3d739c8a Reviewed-on: https://chromium-review.googlesource.com/c/1350413Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#612083}
-
Hitoshi Yoshida authored
Templates and scripts to generate v8_context_snapshot_external_references have some dead code because of historical reasons. This CL clean up them to reduce the generate process and the generated code. As a result, the number of entries in the table becomes 1741 from 1766, and 3 includes are removed. In detail, this CL does following changes. - Avoids checking interfaces that are not exposed to Window - Removes unused white list - Removes unnecessary check - Removes unused template parameter - Renames internal const variable from snake_case to kCamelCase. Bug: None Change-Id: If7c439d7b1085ef8c03cfb72b37343e3989feaeb Reviewed-on: https://chromium-review.googlesource.com/c/1354724 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Fix metadataDownloads, MigratePinnedFiles and DriveFS RecoverDirtyFiles. Change |EnsureDownloadsFolderExists| to make sure that /Downloads folder has been added to internal map, this fixes tests running with PRE_ which creates the folder in the file system, but when the test run the entry doesn't exist in the internal map. Bug: 873539 Change-Id: I429ab76179f0e386df1d94842d2bfb9994d2100b Reviewed-on: https://chromium-review.googlesource.com/c/1354800Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#612081}
-
Tetsui Ohkubo authored
UnifiedSystemTray can be expanded or collapsed by touch gestures, but it's confusing that it's also possible when a detailed view is shown. TEST=manual BUG=none Change-Id: Iac81bbb645036560aa01c43bd86de735e3e904dc Reviewed-on: https://chromium-review.googlesource.com/c/1352088 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#612080}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe3edef96c84..e6732bb38dc8 Created with: gclient setdep -r src-internal@e6732bb38dc8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I69fee12ff28c9d659cdbc5295adb0ce72592667a Reviewed-on: https://chromium-review.googlesource.com/c/1354631Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612079}
-
Hayato Ito authored
No behavior change. Change-Id: I2f4f1500608c7537e15ac4e2f28374e992b1a3ad Reviewed-on: https://chromium-review.googlesource.com/c/1354718Reviewed-by:
-
Mikel Astiz authored
SessionSyncService's API is sufficient to achieve the desired behavior, i.e. distinguish the exact state for tab sync: off, initial download in progress and done. It also issues a notification every time that state changes, so there's no need to monitor updates from ProfileSyncService directly. Bug: 895455 Change-Id: Icf66328fdde97f833e178f0571dedb248c91beca Reviewed-on: https://chromium-review.googlesource.com/c/1344029Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#612077}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7c8f33a1f59c..c3daaa87ec17 git log 7c8f33a1f59c..c3daaa87ec17 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 tsepez@chromium.org Remove CFWL_Widget::GetRootOuter() and Repaint() 2018-11-29 thestig@chromium.org Clean up CBC_ErrorCorrection and remove many fxbarcode/utils.h includes. Created with: gclient setdep -r src/third_party/pdfium@c3daaa87ec17 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I11da9f3ed1cf5f9cc2665dcc27c2a4bb835e20e2 Reviewed-on: https://chromium-review.googlesource.com/c/1354625Reviewed-by:
-
Aleksei Koziatinskii authored
Node 8.x does not support breakOnAsyncCall param of Debugger.stepInto method. R=dgozman@chromium.org Bug: none Change-Id: I0e59e0a3742b85a2fd466ac1bac5f7b75aa7f841 Reviewed-on: https://chromium-review.googlesource.com/c/1352533Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612075}
-
Cathy Li authored
Remove the header in error and loading views and change the error view to look more like a typical error page. Bug: 907638 Change-Id: I6aca95c1bd6e1334b86416879283b0a26471719e Reviewed-on: https://chromium-review.googlesource.com/c/1347215Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#612074}
-
Esmael El-Moslimany authored
Bug: 908388 Change-Id: I0a93f9c648610331db2de63596f3349dd3d07333 Reviewed-on: https://chromium-review.googlesource.com/c/1351535Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#612073}
-
Ken Rockot authored
Migrates resource_coordinator away from the deprecated ServiceContext API to ServiceBinding, and migrates its tests from the deprecated ServiceTest framework to regular unit tests. Bug: 891780,906239 Change-Id: I308746a7fc02402ec78d59f03c2c06395bc79b5c Reviewed-on: https://chromium-review.googlesource.com/c/1351775 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#612072}
-
Hirokazu Honda authored
In the definition, S_FMT doesn't have to fail even if the queried pixel format is not supported on the device. The correct way of judging pixel format support is to compare the pixel format value returned on S_FMT with the queried pixel format. Bug: 908357 Test: VDA, VEA, JDA unittest on elm Test: JEA unittest on kevin Change-Id: Ie57eaa37aec954997e743ebea05beed130faf604 Reviewed-on: https://chromium-review.googlesource.com/c/1351049 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#612071}
-
Charles Zhao authored
When chrome browser is under memory pressure, TabManager::GetSortedLifecycleUnits is called to return list of tabs sorted by its reactivation score. We want to log this event by: (1) generates (and logs) a query_id for this query. (2) for each tab, when its reactivation score is calculated, we log its tab_features (with a random label_id) for this query. (3) when the tab is later on reactivated or closed, we log the label with the label_id generated before so that feature-label can be paired. Please see more details in the bug. Changes made in this CL: (1) Extending TabMetricsLogger chrome/browser/resource_coordinator/tab_metrics_logger.h chrome/browser/resource_coordinator/tab_metrics_logger.cc chrome/browser/resource_coordinator/tab_metrics_logger_unittest.cc Minor change of these functions to also take label_id and query_id as input. (label_id is passed in as input since it's different per tab, query_id is saved and set inside TabMetricsLogger since it's the same of all tabs per discard-query) (2) Populating the label_id and query_id chrome/browser/resource_coordinator/tab_activity_watcher.h chrome/browser/resource_coordinator/tab_activity_watcher.cc chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc TabActivityWatcher::CalculateReactivationScore and TabActivityWatcher::WebContentsData::CalculateReactivationScore are extended to also take also_log_to_ukm as input. A tab_feature with a random label_id_ is logged whenever CalculateReactivationScore(true) is called. The same label_id_ is also logged in LogForegroundedOrClosedMetrics. We also add logic to block background time feature logging for now. (3) TabManager changes. chrome/browser/resource_coordinator/tab_lifecycle_unit.cc chrome/browser/resource_coordinator/tab_manager.h chrome/browser/resource_coordinator/tab_manager.cc These changes are necessary only because TabManager::GetSortedLifecycleUnits and TabActivityWatcher::CalculateReactivationScore are called at multiple places. And we only want to log some of them. a) TabLifecycleUnitSource::TabLifecycleUnit::GetSortKey is changed back to only sort by last_activity_time for now. b) is added as private function and called inside TabManager::DiscardTabImpl if TabRanker is enabled. c) CalculateReactivationScore(also_log_to_ukm=true) is called inside GetSortedLifecycleUnitsFromTabRanker, which is the only case we log query time features. Bug: 900454 Change-Id: Idc77b0ff6aa3488e10a449dfec6a96d4c61f8da0 Reviewed-on: https://chromium-review.googlesource.com/c/1350445Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#612070}
-
Matt Falkenhagen authored
Started failing recently but I haven't found the culprit CL yet. Bug: 910011 Change-Id: Iaa86f960f86f8ed69df94627eee63275403bf469 TBR: kinuko No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1354737Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#612069}
-
Min Qin authored
Currently we remove cancelled and completed download from in-progress DB. However, for non-resumable downloads, they should also be populated back to history DB. Once that is done, it can be removed from in-progress DB. BUG=893651 Change-Id: I95013b27c41953d503df4ee49da21acb9de07eb5 Reviewed-on: https://chromium-review.googlesource.com/c/1352711 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612068}
-
Ken Rockot authored
Migrates identity, network, and tracing services and their tests away from the deprecated ServiceContext API to ServiceBinding, and from the deprecated ServiceTest framework to regular unit tests. Bug: 891780,906239 Change-Id: I0abd81aa8096735e51d3a21b1a4e4b0fa51d6d66 Reviewed-on: https://chromium-review.googlesource.com/c/1351770 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#612067}
-
Giovanni Ortuño Urquidi authored
TBR=huayinz@chromium.org Bug: 909978 Change-Id: I9347d3f4c344ab19cffa3f3148dc26b557f1a724 Reviewed-on: https://chromium-review.googlesource.com/c/1354729Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#612066}
-
