GitLab

Try a different, simpler approach to detect bookmark drag&drop across profiles.

BUG=101543
TEST=drag bookmark from folder, wait for folder to close, drop on bar -> no crash


Review URL: http://codereview.chromium.org/8404022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107572 0039d316-1c4b-4281-b951-d872f2087c98

This fix doesn't display selection popups properly, though (because RenderWidgetHostViewAura::InitAsPopup is not implemented).

BUG=101899,99757
TEST=Manual: click on any SELECT element

Review URL: http://codereview.chromium.org/8363047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107571 0039d316-1c4b-4281-b951-d872f2087c98

This removes the --keep-mouse-cursor flag, and moves the --touch-devices flag
from touchui-only to linux-views (i.e. chromeos, aura on linux, touchui).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/8371022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107570 0039d316-1c4b-4281-b951-d872f2087c98

The way a WebTouchEvent is prepared in RWHVAura is the same as it is in
RWHVViews: the RWHVA maintains a WebTouchEvent, and each aura::TouchEvent
adds/removes/updates a WebTouchPoint in the WTE.

BUG=99757
TEST=manually, with the --touch-devices flag on linux.

Review URL: http://codereview.chromium.org/8377001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107569 0039d316-1c4b-4281-b951-d872f2087c98

The StringOrdinal class is intended to allow sorted lists of strings to be treated as floating point numbers, and can be used to create a value to be sorted into any index location, allowing an element to change it's index without any other elements having to change their index value.

BUG=94662
TEST=Unit tests created in chrome/common/string_ordinal_unittest.cc


Review URL: http://codereview.chromium.org/8236002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107566 0039d316-1c4b-4281-b951-d872f2087c98

Two changes:
a) detangle the mock compositor from compositor_test_support
a) pull in compositor when using a mock compositor

Rationale:

a) this target was meant to support using use_webkit_compositor=1 when WK isn't initialized; sometimes we will want to use the mock compositor when WK is initialized

b) we can imagine scenarios where we want to switch between mock and real compositors in the same executable, and it's one less target to update

BUG=101477
TEST=bots stay green

Review URL: http://codereview.chromium.org/8395043

TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/8404041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107564 0039d316-1c4b-4281-b951-d872f2087c98

Two changes:
a) detangle the mock compositor from compositor_test_support
a) pull in compositor when using a mock compositor

Rationale:

a) this target was meant to support using use_webkit_compositor=1 when WK isn't initialized; sometimes we will want to use the mock compositor when WK is initialized

b) we can imagine scenarios where we want to switch between mock and real compositors in the same executable, and it's one less target to update

BUG=101477
TEST=bots stay green

Review URL: http://codereview.chromium.org/8395043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107563 0039d316-1c4b-4281-b951-d872f2087c98

This enables making the decision based on both image url and the page url. E.g., blocking third-party images.

BUG=81179
TEST=RenderViewTest.ImagesBlockedByDefault, RenderViewTest.ImagesAllowedByDefault


Review URL: http://codereview.chromium.org/7831075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107562 0039d316-1c4b-4281-b951-d872f2087c98

Photo Editor used to save JPEG files with no metadata as PNG.
This is now fixed. Also added simple metadata parsers for PNG/BMP/GIF
to make thumbnail display logic in the File Manager work better. 

BUG=
TEST=


Review URL: http://codereview.chromium.org/8394046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107561 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100898
R=pkasting@chromium.org

Review URL: http://codereview.chromium.org/8363036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107559 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:16101
TEST=None

Review URL: http://codereview.chromium.org/8363045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107558 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107556 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8404035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107555 0039d316-1c4b-4281-b951-d872f2087c98

Also add support for "?" in Valgrind suppressions to our local suppression matcher
TBR=glider
TEST=./tools/valgrind/waterfall.sh
Review URL: http://codereview.chromium.org/8404034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107554 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107550 0039d316-1c4b-4281-b951-d872f2087c98

This includes the new gc

TBR=foo

Review URL: http://codereview.chromium.org/8399030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107549 0039d316-1c4b-4281-b951-d872f2087c98

This eliminates the need to explicitly initialize it with "= {}"
everywhere.

BUG=chromium:101867
TEST=Valgrind error should not happen (see bug)
Signed-off-by: Simon Que <sque@chromium.org>

R=satorux@chromium.org


Review URL: http://codereview.chromium.org/8402020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107548 0039d316-1c4b-4281-b951-d872f2087c98

The BackingStoreType and maximumSize parameters have been removed.

Remove the --indexeddb-use-sqlite command-line flag.

BUG=none
TEST=all current tests pass (layout tests, browser tests, pyautotests)

Review URL: http://codereview.chromium.org/8202003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107547 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107546 0039d316-1c4b-4281-b951-d872f2087c98

This will make it allocate less shared memory blocks resulting
in less file descriptors.

BUG=none
TEST=unit tests


Review URL: http://codereview.chromium.org/8340003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107544 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 6b3b4806.
http://src.chromium.org/viewvc/chrome?view=rev&revision=107530

BUG=chromium:101867
TEST=none
Signed-off-by: Simon Que <sque@chromium.org>

R=oshima@chromium.org,satorux@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8400019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107543 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/8403030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107542 0039d316-1c4b-4281-b951-d872f2087c98

BUG=100944
TEST=

Review URL: http://codereview.chromium.org/8396044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107541 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Manual: build with use_aura=1
TBR=pkasting@chromium.org

Review URL: http://codereview.chromium.org/8402022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107540 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8395025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107539 0039d316-1c4b-4281-b951-d872f2087c98

This hooks up the DownloadProtectionService to run after a download finishes.  For now, this does not send a download pingback since the flag defaults to off.


TEST=DownloadProtectionServiceTest
BUG=none

Review URL: http://codereview.chromium.org/8345033

TBR=bryner@chromium.org
Review URL: http://codereview.chromium.org/8400020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107538 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107537 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=johnnyg

Review URL: http://codereview.chromium.org/8403028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107536 0039d316-1c4b-4281-b951-d872f2087c98

This is the first patch in a series of patches. This patch introduces the unrecoverable error info class which is plumbed up all ModelSafeWorker subclasses. 

The subclasses of ModelChangingSyncer command would be converted to return an unrecoverable error info in another CL.


BUG=100374
TEST=


Review URL: http://codereview.chromium.org/8366030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107535 0039d316-1c4b-4281-b951-d872f2087c98

This change just adds a 'const' to RenderWidgetHostViewViews::HasFocus() to match it with views::View::HasFocus().

BUG=none
TEST=fix the "Linux Clang (ChromeOS dbg)" build.

Review URL: http://codereview.chromium.org/8402018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107534 0039d316-1c4b-4281-b951-d872f2087c98

This avoids some crashes when we try to traverse the list to find the
first child and encounter a dangling Id.

Remove some spurious virtual keywords.

BUG=100907
TEST=


Review URL: http://codereview.chromium.org/8396022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107533 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rvargas@chromium.org
BUT=101853
TEST=none

Review URL: http://codereview.chromium.org/8401028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107532 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
Review URL: http://codereview.chromium.org/8403017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107531 0039d316-1c4b-4281-b951-d872f2087c98

TBR=satorux@chromium.org
BUG=101867
TEST=none

Review URL: http://codereview.chromium.org/8400018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107530 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97845
TEST=ui_unittests


Review URL: http://codereview.chromium.org/8364037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107529 0039d316-1c4b-4281-b951-d872f2087c98

This hooks up the DownloadProtectionService to run after a download finishes.  For now, this does not send a download pingback since the flag defaults to off.


TEST=DownloadProtectionServiceTest
BUG=none

Review URL: http://codereview.chromium.org/8345033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107528 0039d316-1c4b-4281-b951-d872f2087c98

As of July, the mini-gallery simply redirects to the web store (b/4990237).

BUG=101405
TEST=no user-visible changes

Review URL: http://codereview.chromium.org/8404007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107527 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107526 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yurys,johnnyg

Review URL: http://codereview.chromium.org/8404023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107525 0039d316-1c4b-4281-b951-d872f2087c98

setting that was already in sync (from MergeDataAndStartSyncing) is changed.


BUG=101635
TEST=ExtensionSettingsSyncTest


Review URL: http://codereview.chromium.org/8341043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107524 0039d316-1c4b-4281-b951-d872f2087c98