GitLab

Review URL: http://codereview.chromium.org/100260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15061 0039d316-1c4b-4281-b951-d872f2087c98

To be merged with 2.0 (172) branch.

BUG=http://crbug.com/11208
TBR=mal


Review URL: http://codereview.chromium.org/99260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15060 0039d316-1c4b-4281-b951-d872f2087c98

Specifically:
1) In webkit.gyp and test_shell.gyp, convert the rules to actions because of different grd outputs (localized grd files have locale in the .pak filename).
2) In chrome, make two targets each with a custom rule.  One target is for localized resources, the other for non-localized resources.  This is like the current windows build.

Review URL: http://codereview.chromium.org/100174


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15059 0039d316-1c4b-4281-b951-d872f2087c98

synchronous and robust.

Adding automation APIs with corresponding
IPC messages to count and find normal browser
windows.


Review URL: http://codereview.chromium.org/99268

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15058 0039d316-1c4b-4281-b951-d872f2087c98

a bug where you would cycle through a background tab's links even after
selecting a different tab.

TEST=Open Chromium.  Open a new tab.  Press tab and verify that we are correctly
cycling through the links in the new tab.

Review URL: http://codereview.chromium.org/100233

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15057 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/10957
TEST=Verify that the AddSearchProvider logic still works.  This dates back to an old bug http://b/1069781

Review URL: http://codereview.chromium.org/99168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15056 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99262

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11263
TEST=Go to any page and then click on a link to navigate to a new page.


Review URL: http://codereview.chromium.org/99263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15052 0039d316-1c4b-4281-b951-d872f2087c98

Only send events to renderers that are listening to an event.Notify browser when a renderer is listening to an event.
Review URL: http://codereview.chromium.org/100214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15050 0039d316-1c4b-4281-b951-d872f2087c98

* remove chrome\browser\views\find_bar_win_unittest.cc
* add Windows-only test targets:
  ** interactive_ui_tests
  ** plugin_tests
  ** selenium_tests
* Move from unit_tests to test_support_common:
  ** test/in_process_browser_test.{cc,h}
  ** test/ui_test_utils.{cc,h}


Review URL: http://codereview.chromium.org/100168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15045 0039d316-1c4b-4281-b951-d872f2087c98

Calculate from the actual text width, not the allocated text width.

Review URL: http://codereview.chromium.org/99222


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15042 0039d316-1c4b-4281-b951-d872f2087c98

Glue part for the provisional WebKit merge (https://bugs.webkit.org/show_bug.cgi?id=25347).TBR=yurys
Review URL: http://codereview.chromium.org/99274

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15041 0039d316-1c4b-4281-b951-d872f2087c98

happening, so it seems unlikely that this is a reference counting
problem.

BUG=9746
Review URL: http://codereview.chromium.org/100247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15038 0039d316-1c4b-4281-b951-d872f2087c98

issue by adding the style declaration wrappers to the object groups of
the elements they belong to.
Review URL: http://codereview.chromium.org/100204

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15037 0039d316-1c4b-4281-b951-d872f2087c98

R=thestig
BUG=10681
TEST=Start a long download.  Try to quit the browser.  Notice the spiffy title on the dialog box.


Review URL: http://codereview.chromium.org/100241

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15035 0039d316-1c4b-4281-b951-d872f2087c98

TBR=eseidel
BUG=10898
TEST=0

Review URL: http://codereview.chromium.org/100244

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15033 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15032 0039d316-1c4b-4281-b951-d872f2087c98

http://code.google.com/p/chromium/issues/detail?id=11264

Integer 0 and -1 have special meaning in HashMap<int, ...>, both cannot be used as key.
Specially filter out these two keys.

Review URL: http://codereview.chromium.org/100242

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15031 0039d316-1c4b-4281-b951-d872f2087c98

A NPObject can be called as a construct if it implements NPN_Construct, and NOT implements
NPN_InvokeDefault. Otherwise, NPN_InvokeDefault is called even when the object is called
as a constructor.

Review URL: http://codereview.chromium.org/56167

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15029 0039d316-1c4b-4281-b951-d872f2087c98

After discussing with various people, I think we're going to do this
in the short term at least. Currently we're calling into GTK from the
IO thread and Bad Things Happen when one does that.

We would like to write an Xlib, fully asynchronous system for dealing
with the clipboard (and to get the clipboard stuff out of base!). That
would let us avoid sending the selection over the IPC channel each
time it updates too.

However, that's going to be a lot of work and we have crashing
browsers happening /right now/. Also, Evan thinks that maybe we don't
have the deadlock situation on Linux that we do on Windows with
terminating sync requests from the renderer on the UI thread.

http://codereview.chromium.org/100238

BUG=9865


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15028 0039d316-1c4b-4281-b951-d872f2087c98

Undisable the temporarily disabled test, by fixing the URL expectation to have %22 instead of \" (to match change in GURL canonicalization).

BUG=11142
TBR=evan

Review URL: http://codereview.chromium.org/100148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15027 0039d316-1c4b-4281-b951-d872f2087c98

I accidentally marked mac/linux as crash when I really wanted to mark win

BUG=11264

TBR=dglazkov

Review URL: http://codereview.chromium.org/100239

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15026 0039d316-1c4b-4281-b951-d872f2087c98

On POSIX one can install an unload handler which loops forever and
leave behind a renderer process which eats 100% CPU forever.

This is because the terminate signals (ViewMsg_ShouldClose and the
error from the IPC channel) are routed to the main message loop but
never processes (because that message loop is stuck in V8).

One could make the browser SIGKILL the renderers, but that leaves open
a large window where a browser failure (or a user, manually
terminating the browser because "it's stuck") will leave behind a
process eating all the CPU.

On Windows we don't have this issue because all the processes are in a
job so when the parent dies, all the children are killed too.

http://codereview.chromium.org/100222


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15025 0039d316-1c4b-4281-b951-d872f2087c98

to succeed. Disabling the MediaPlayerNew test as an ASSERT in Webkit is firing causing the
renderer to crash. Will debug this more and log a bug.

TBR=nsylvain

Review URL: http://codereview.chromium.org/100236

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15024 0039d316-1c4b-4281-b951-d872f2087c98

resource only changes to rebuild lots of stuff on Mac and Linux,
but since most of this is happening on Windows anyway, only
optimize for Windows.

This should make second builds faster since all the dependencies
are up to date.

Review URL: http://codereview.chromium.org/99265


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15023 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/102020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15022 0039d316-1c4b-4281-b951-d872f2087c98

BUG=11264

TBR=dglazkov

Review URL: http://codereview.chromium.org/100235

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15021 0039d316-1c4b-4281-b951-d872f2087c98

Stop the location bar from flashing white when navigating from one HTTPS site to another.  To do this, we have to make sure the SSLManager sees the DidCommitProvisionalLoad event before the location bar draws itself to the screen.

BUG=11157
TEST=Navigate from one HTTPS site to another and watch the location bar carefully.  It shouln't flash anymore.

Review URL: http://codereview.chromium.org/99247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15020 0039d316-1c4b-4281-b951-d872f2087c98

R=jar

Review URL: http://codereview.chromium.org/99020


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15018 0039d316-1c4b-4281-b951-d872f2087c98

- Finally audio playback wired
- Takes into account initial buffer fill change of last week
- Two 'can you hear this?' unit tests added


Review URL: http://codereview.chromium.org/92131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15017 0039d316-1c4b-4281-b951-d872f2087c98

Code coverage now works for Linux.  Unit tests to run passed from
project to coverage_posix.py so deps are correct.


Review URL: http://codereview.chromium.org/100189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15016 0039d316-1c4b-4281-b951-d872f2087c98

1) Add a dependency to the rule that copies the files.
2) Change the directories to have lower case names.  This doesn't matter
on windows which is case insensitive and where some directories are already lower case (e.g., themes and locales).  Mac will probably have to add
some gyp code to move the files to the right place in the bundle.

Review URL: http://codereview.chromium.org/100223


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15015 0039d316-1c4b-4281-b951-d872f2087c98

Most of the new code concerns shaping the widget to be non-rectangular.

Also, sprinkle some "const" qualifiers on NineBox functions.

Review URL: http://codereview.chromium.org/100224

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15014 0039d316-1c4b-4281-b951-d872f2087c98

- Bookmark codec now takes in a ctor argument persist_ids
- If it's true, it will serialize IDs of bookmarks when encoding, and
  deserialize already serialized IDs (if present) when decoding.
- During decoding, unique-ify the IDs if they are not unique.
- Add unit tests for all new code.


Coming up in a separate changelist:
- Move ID generation logic to bookmark model, and make it non-static.

Review URL: http://codereview.chromium.org/99217

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15013 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99257

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15011 0039d316-1c4b-4281-b951-d872f2087c98

After we're sure we can do SDCH compression to a given URL, toss
a 50-50 coin each time we have a chance to advertise SDCH, and
either completely avoid advertisement, or advertise (including
the dictionary).  Histogram both compression download times, as
well as the download times for the "completely avoid" case.

http://crbug.com/11236
bug=11236
r=wtc,openvcdiff
Review URL: http://codereview.chromium.org/100004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15010 0039d316-1c4b-4281-b951-d872f2087c98

Added audio/mpeg and video/mpeg to the list of mime types supported by the Activex shim for media player along with their associated extensions. 

This fixes http://code.google.com/p/chromium/issues/detail?id=11054, which occurs with embed tags with a source
URL and no mime type. In this case the URL extension is mp3, which is not claimed by any plugin although Quicktime
and media player do handle it. It works in Firefox because the plugin instantiation code in FF correctly gets the
mime type from the http stream and instantiates the plugin accordingly. Webkit attempts to instantiate the plugin
from the embed tag with the source URL. This fails silently in Chrome and Safari displays an error message.

With this fix the only user visible difference would be quicktime handling the mp3 in FF and IE, and media player
handling it in Chrome.

I also moved the media player shim to the end of the plugin list to ensure it does not take over the audio/mpeg and video/mpeg mime types if there is a a plugin which can handle it.

Added plugin tests for the mp3 and mpe extensions.

Bug=11054


Review URL: http://codereview.chromium.org/100180

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15008 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/99251

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15001 0039d316-1c4b-4281-b951-d872f2087c98

Add empty createHTMLParserQuirks implementation in anticipation of http://trac.webkit.org/changeset/43092.

R=levin
BUG=10898
TEST=0

Review URL: http://codereview.chromium.org/100227

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15000 0039d316-1c4b-4281-b951-d872f2087c98

HttpNetworkTransaction (to the Socket class).

This is the first step to remove the blocking call on the
destructor of the network transaction, from IO thread.

BUG=9258
R=wtc

Review URL: http://codereview.chromium.org/87073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14998 0039d316-1c4b-4281-b951-d872f2087c98