GitLab

Reland of https://codereview.chromium.org/965633002/

TBR=dpranke

Review URL: https://codereview.chromium.org/961323004

Cr-Commit-Position: refs/heads/master@{#318756}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c791d841..155278d6

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/969053002

Cr-Commit-Position: refs/heads/master@{#318755}

Make the chrome://extensions page use chrome.developerPrivate API to
select a file path for a crx and to perform the pack job itself.
Also add tests for the api function, and convert it to a
UIThreadExtensionFunction.

BUG=461039

Review URL: https://codereview.chromium.org/958803004

Cr-Commit-Position: refs/heads/master@{#318754}

Update chrome://settings for "automatic timezone detection" option after UI
review.

BUG=461953
TEST=manual

Review URL: https://codereview.chromium.org/944593002

Cr-Commit-Position: refs/heads/master@{#318753}

The AFTER_WAKEUP autopump policy should only pump a task queue if the task
which was executed is newer (i.e., posted after) the oldest task in the
task queue's incoming queue. Otherwise the queue will be woken by the task
which actually posts the task.

This will be required for implemention of long idle task - design doc:
https://docs.google.com/a/chromium.org/document/d/1yBlUdYW8VTIfB-DqhvQqUeP0kf-Ap1W4cao2yQq58Do/edit

BUG=455713

Review URL: https://codereview.chromium.org/966813003

Cr-Commit-Position: refs/heads/master@{#318752}

Annotate several classes with @TargetApi so lint knows that those
classes can safely use methods introduced in various versions of
Android.

BUG=266140

Review URL: https://codereview.chromium.org/963383002

Cr-Commit-Position: refs/heads/master@{#318751}

This patch changes CallFunctionForSubtree from using base::Bind to
using lambdas, which makes it slightly more readable at the call site.

R=enne, danakj

Review URL: https://codereview.chromium.org/937883002

Cr-Commit-Position: refs/heads/master@{#318750}

The problem was that the preference layout is quite different between L
and pre-L devices, so adjusting the padding of the icon's parent view
had very different effects in those two cases. Now, we simply set the
padding of the icon view itself to get the favicon where we want it.

BUG=454850

Review URL: https://codereview.chromium.org/956303003

Cr-Commit-Position: refs/heads/master@{#318749}

BUG=434064

Review URL: https://codereview.chromium.org/969513002

Cr-Commit-Position: refs/heads/master@{#318748}

For <input type=time step=3600>, the minutes field should be disabled, and the
value should be the minutes of the minimum value, not the current time.
(Actually, it should be the minutes of the step-base value.  This CL adds TODO()
for it.)

Also, this CL fixes a bug for step>3600.  <input type=time step=5400> should
not disable the minutes field.

BUG=409791

Review URL: https://codereview.chromium.org/954363003

Cr-Commit-Position: refs/heads/master@{#318747}

BUG=461039
BUG=463082

Review URL: https://codereview.chromium.org/967393002

Cr-Commit-Position: refs/heads/master@{#318746}

This elevates it from 4 or 5 depending if it is a normal file or unit
test file to 1 for everything.

Used the following command line to lint the files:

$ for in $(g ls-files ui/app_list/ | grep -E '.*\.(cc|h)$' | grep -v
cocoa); do cpplint.py --verbose=1 $f; done

BUG=None
TEST=see above
R=tapted@chromium.org

Review URL: https://codereview.chromium.org/972463002

Cr-Commit-Position: refs/heads/master@{#318745}

BUG=b/19550404

Review URL: https://codereview.chromium.org/968263003

Cr-Commit-Position: refs/heads/master@{#318744}

Issue was addressed by http://crbug.com/445481.

R=jyasskin
BUG=364014

Review URL: https://codereview.chromium.org/962233002

Cr-Commit-Position: refs/heads/master@{#318743}

Revert of Roll src/third_party/WebKit f48b013:696617b (svn 191112:191118) (patchset #1 id:1 of https://codereview.chromium.org/965793004/)

Reason for revert:
broke official builds win,linux,mac
see
http://build.chromium.org/p/chromium/builders/Win/builds/29606/steps/compile/logs/stdio

Original issue's description:
> Roll src/third_party/WebKit f48b013:696617b (svn 191112:191118)
>
> Summary of changes available at:
> https://chromium.googlesource.com/chromium/blink/+log/f48b013..696617b
>
> TBR=alancutter@chromium.org,enne@chromium.org
>
> Committed: https://crrev.com/2f52d5e10d93c872020247c824e01e376999815e
> Cr-Commit-Position: refs/heads/master@{#318726}

TBR=alancutter@chromium.org,enne@chromium.org,blink-deps-roller@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/974463003

Cr-Commit-Position: refs/heads/master@{#318742}

BUG=398061
R=perkj@chromium.org

Review URL: https://codereview.chromium.org/966663002

Cr-Commit-Position: refs/heads/master@{#318741}

TestWebContentsFactory is a class that can create WebContents for unittests,
but can be created on the stack. This gives it the advantage of being able to
be used in tests that are already inheriting from something other than
RenderViewTestHarness.

Review URL: https://codereview.chromium.org/962393002

Cr-Commit-Position: refs/heads/master@{#318740}

Cancel() has an overly paranoid NOTREACHED, which makes it unsafe to cancel a
ProxyScriptDecider in between quickcheck and proxy script fetching. This CL
removes that NOTREACHED altogether, and adds a test to cover it.

BUG=409698

Review URL: https://codereview.chromium.org/962373002

Cr-Commit-Position: refs/heads/master@{#318739}

BUG=461610

Executed run_webapp_unittest.py with these changes and all tests passed.

Review URL: https://codereview.chromium.org/953223002

Cr-Commit-Position: refs/heads/master@{#318738}

[Telemetry] Rename PageRun to UserStoryRun part of switching from PageTestResults to UserStoryTestResults

This is the first step, next will rename PageTestResult to UserStoryTestResult.

BUG=442036

Review URL: https://codereview.chromium.org/964913005

Cr-Commit-Position: refs/heads/master@{#318737}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b3310c2..8f9e816

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/969033002

Cr-Commit-Position: refs/heads/master@{#318736}

BUG=266140
R=aurimas@chromium.org

Review URL: https://codereview.chromium.org/965933002

Cr-Commit-Position: refs/heads/master@{#318735}

BUG=461865
TEST:
1. enable physical keyboard autocorrect feature from IME settings from chrome-extension://jkghodnilhceideoidjikpgommlajknk/hmm_options.html?code=xkb:us::eng
2. type "waht" and wait for a grey triangle appear underneath "waht"
At this point, an IME window is created.
3. verify no default app icon appear in launcher for the IME window

Review URL: https://codereview.chromium.org/955983004

Cr-Commit-Position: refs/heads/master@{#318734}

BUG=461785

Review URL: https://codereview.chromium.org/946423004

Cr-Commit-Position: refs/heads/master@{#318733}

BUG=462323

Review URL: https://codereview.chromium.org/962783002

Cr-Commit-Position: refs/heads/master@{#318732}

We were using several APIs introduced after API level 14. Fix that.

BUG=462802
R=estade@chromium.org

Review URL: https://codereview.chromium.org/963993002

Cr-Commit-Position: refs/heads/master@{#318731}

BUG=462779

Review URL: https://codereview.chromium.org/968493003

Cr-Commit-Position: refs/heads/master@{#318730}

Chromium side of the implementation of tracking profile stats (number of profiles, number of signed in profiles) through the Omaha channel for Mac. Design doc: https://docs.google.com/a/google.com/document/d/15Ou8VCYNCZvke8Bw9bF3vYqD67voJBPyx_GBR8ONcCw/edit?disco=AAAAAKU7Zzg (Googler Only)

BUG=409895

Review URL: https://codereview.chromium.org/593243002

Cr-Commit-Position: refs/heads/master@{#318729}

Software rendering isn't supported on the GBM platform. Rather than
allow callers to crash due to nullptr accesses, crash explicitly so we
get more meaningfull crash reports.

BUG=461396

Review URL: https://codereview.chromium.org/958403004

Cr-Commit-Position: refs/heads/master@{#318728}

This CL introduces a new TRACE_EVENT_PHASE for memory dump
and enables the MemoryDumpManager to generate actual trace
events when CreateLocalDumpPoint is invoked.

BUG=458295

Review URL: https://codereview.chromium.org/956413002

Cr-Commit-Position: refs/heads/master@{#318727}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f48b013..696617b

TBR=alancutter@chromium.org,enne@chromium.org

Review URL: https://codereview.chromium.org/965793004

Cr-Commit-Position: refs/heads/master@{#318726}

This adds a target to run jscompile over the unittest files.

The save/restore functions of chromeMocks are removed since they are not
necessary. chromeMocks.reset() is called automatically before each test.

It also fixes most of the errors that jscompile produces. For the unittests
where all the errors have not been fixed, jscompile is disabled for those
files. Cases where errors were not fixed include those that require
refactoring base classes to expose an interface that the corresponding
mock can use -- these are best done is a separate, targetted cl.

Also, the it2me tests are not checked because they will be removed soon.

BUG=

Review URL: https://codereview.chromium.org/959963002

Cr-Commit-Position: refs/heads/master@{#318725}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9345eef..b3310c2

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/970943002

Cr-Commit-Position: refs/heads/master@{#318724}

BUG=437508

Review URL: https://codereview.chromium.org/964443002

Cr-Commit-Position: refs/heads/master@{#318723}

BUG=none

Review URL: https://codereview.chromium.org/967213003

Cr-Commit-Position: refs/heads/master@{#318722}

BUG=460998

Committed: https://crrev.com/51c1620185396384cfe6e2f4e3359e57c6431600
Cr-Commit-Position: refs/heads/master@{#318591}

Review URL: https://codereview.chromium.org/964753002

Cr-Commit-Position: refs/heads/master@{#318721}

Current implementation use ContentSettingsPattern::Wildcard()
to reset a setting for the current visiting page, but it does not
work. This should be the embedder URL as geolocation does.

BUG=460733
TEST=manual

Review URL: https://codereview.chromium.org/972733003

Cr-Commit-Position: refs/heads/master@{#318720}

The header include guards should match the file path from root.

These entries were found using a modified version of Eric's
fix-include-guards.py script found attached in
https://code.google.com/p/chromium/issues/detail?id=435361#c7.

BUG=435361
TEST=gn_unittests
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/968193002

Cr-Commit-Position: refs/heads/master@{#318719}

Enhanced bookmark model is the data abstraction layer of enhanced bookmark.

This CL also fixes the bug that add folder returns a wrong bookmarkid.

BUG=458632, 458703

Review URL: https://codereview.chromium.org/929523002

Cr-Commit-Position: refs/heads/master@{#318718}

This will allow the caller to specify an argument to adb public keys to be
written to the device (along with any existing keys already on the device)
during wiping.

BUG=

Review URL: https://codereview.chromium.org/970573002

Cr-Commit-Position: refs/heads/master@{#318717}