- 09 Apr, 2020 40 commits
-
-
Greg Thompson authored
This reverts commit 0c6bc2e3. Reason for revert: reverting to avoid perf analysis surprises -- to be relanded with a trace event. Original change's description: > Take user data snapshots on canary builds for each minor upgrade. > > Bug: 958893 > Change-Id: I987a99d3db2b659babe46d2f15cfac6627bc573c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134396 > Commit-Queue: Yann Dago <ydago@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757835} TBR=grt@chromium.org,ydago@chromium.org Change-Id: Ie5bc93a13e952ae13ab90249adb93623eb3261c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144173Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#758018}
-
Kai Ninomiya authored
Deprecates GPUBindGroupLayoutEntry.textureDimension. Bug: 1069302 Change-Id: Idbf0928116bf01f702808f95ecc6d0a63a2caea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143378Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#758017}
-
Nicolás Peña Moreno authored
This CL removes flakiness in the FCP-only tests by: * Adding a 50ms wait when FCP is not expected. This way, tests that would surface FCP would have enough time to do so. * Rely on PerformanceObserver to verify that FCP is surfaced in the cases where it should be. * Use a 300 ms timeout to declare that FCP was not surfaced when it is expected. This is larger than the non-FCP wait time since it sometimes requires waiting on CSS images to load. Bug: 1062984 Change-Id: I876b5bcdba3c795dc63326839899f3d5bb7a7dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139362Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#758016}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/aad6472eff7b..99ccc1759668 git log aad6472eff7b..99ccc1759668 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 treehugger-gerrit@google.com Merge "Rename smaps table to profiler_smaps." Created with: gclient setdep -r src/third_party/perfetto@99ccc1759668 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7b9ded6e0ed5342f3f9291c9d6ae532adcf2ed66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144645Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758015}
-
Sean Harrison authored
Add a dialog to confrim a user want to disable safebrowsing Bug: 1067288, 1032584 Change-Id: Iddd781a3f369f5ee6359afb94ac18230b231a388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137404 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#758014}
-
Danyao Wang authored
This reverts commit b666bbd0. Reason for revert: broke tests: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=org.chromium.chrome.browser.payments.ExpandablePaymentHandlerChangePaymentMethodTest%23testThrowBasicCard Original change's description: > [Web Payments] Use PaymentAppServiceBridge JNI in PaymentAppService. > > This CL contains the final steps to make the Java PaymentAppService > invoke the C++ PaymentAppService: > - Moved remaining PaymentHandlerFinder functionality, namely, > onInstalledPaymentHandlerFounder() and onInstallablePaymentHandler() > from ServiceWorkerPaymentAppBridge to PaymentAppServiceBridge. > - Exposed the native method fireCanMakePaymentEvent() via a static > method on ServiceWorkerPaymentAppBridge so it can be used by > PaymentAppServiceBridge. > - Proxied ServiceWorkerPaymentAppBridge.setCanMakePaymentForTesting > to PaymentAppServiceBridge. This will be cleaned up in a subsequent > CL. > - Fixed a bug from a previous CL to pass payment apps to callbacks by > value instead of by reference. > > Bug: 1063118 > Change-Id: I87e254d6dc11e12f890353c9a0a6dde6cca73c9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141436 > Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> > Commit-Queue: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#757827} TBR=rouslan@chromium.org,danyao@chromium.org,maxlg@chromium.org Change-Id: I73fda6a9cf222a684d05e1b24229cfc26ae3630c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1063118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144682Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#758013}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5d1c16380705..73e334469e89 git log 5d1c16380705..73e334469e89 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 reed@google.com fix computation for localToWorld 2020-04-09 bungeman@google.com Take MorphologyImageFilter radii as SkScalar. 2020-04-09 kjlubick@google.com [infra] Update dimensions for Golo Windows machines 2020-04-09 mtklein@google.com example of overdraw CF that we can JIT 2020-04-09 egdaniel@google.com Fix PinnedImageTest to make current original context at end. 2020-04-09 robertphillips@google.com Clean up GrText-related headers a bit 2020-04-09 reed@google.com Add markCTM(id) api, to replace functionality of saveCamera. 2020-04-09 tdenniston@google.com Sort viewer slides by filename when traversing a directory. Created with: gclient setdep -r src/third_party/skia@73e334469e89 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1068726 Tbr: csmartdalton@google.com Change-Id: I5dcaca1ad872b265fe4a99ce6a09df640870237c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144644Reviewed-by:
-
Ryan Sleevi authored
The smart card password dialog is invoked by NSS when it needs to access a smart card, and must not return control back to NSS until it has the password. The dialog itself is configured as a global, but any NSS operations that may interact with smart cards (such as signing messages or verifying certificates) are invoked on worker task runners and with the base::MayBlock() trait. Bug: 1058070 Change-Id: Ib18c26e3d4c0b5063fe5337c6bf0da514ed4db73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142715 Auto-Submit: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#758011}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8ab783931f9..bb2c6c025366 Created with: gclient setdep -r src-internal@bb2c6c025366 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:790886 Tbr: nhiroki@google.com,reillyg@google.com Change-Id: I226572383d4e02ab57063d4ce5a2eac53aaffce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144640Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758010}
-
Raymond Toy authored
As with other fixes, use HasSampleAccurateValuesTimeline() to determine if there are sample-accurate values which is either caused by timeline events or connected inputs to the AudioParam. Tests added to handle possible different combinations of a-rate and k-rate frequency and detune AudioParams. Bug: 1015760 Test: k-rate-oscillator-connections.html Change-Id: I0d90d19b3cafbe353bc9495aa7e493bd20eb9e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111412 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#758009}
-
Lukasz Anforowicz authored
Bug: 1066070 Change-Id: I34ed854437671242426918e0461e5baa71c519b1 Tbr: olivierrobin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141112 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#758008}
-
Aaron Leventhal authored
- Expose value, but not name, based on descendant text - Expose correct role on Mac (popup button) Bug: 1069150 Change-Id: I16119966a1e6c8a1eee88ef61c7268c5d3384341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142611 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#758007}
-
Ana Salazar authored
This animation happens during transition between hotseat states. Bug: 1058609 Change-Id: I817b5af80703b8b2fcc1737d62668d77195cfd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101230 Commit-Queue: Ana Salazar <anasalazar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#758006}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I9463d5bd0c777715411dc694968322ce8150188b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144400Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#758005}
-
Maggie Chen authored
This reverts commit 15ab8559. Reason for revert: <The data has been collected from the crash dumps. Debugging code is no longer needed. > Original change's description: > Record the GPU watchdog arm_disarm_counter in the main thread > > It is for the debugging purpose only and it wil have a performance impact. > The code will be removed immediately once valid crash dumps are collected. > > Bug: 885066,885066 > Change-Id: Ie8761ed4e6050a07e76af0a030b67dab5bb011e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129028 > Commit-Queue: Maggie Chen <magchen@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756461} TBR=zmo@chromium.org,magchen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 885066 Change-Id: If5d439c97c3bf4732297b9a756423c18f024b865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144812Reviewed-by:
Maggie Chen <magchen@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758004}
-
Kai Ninomiya authored
Non-breaking. Bug: 1069302 Change-Id: I4cc7bfe3f75f9f79f8c8592b517181fbec1dbfc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143377Reviewed-by:
-
Robbie McElrath authored
This CL renames RoundedIconGenerator to FaviconFallbackGenerator and moves it from //chrome/browser/ui/android/favicon to //components/favicon/android so it can be reused by WebLayer. We'll move FaviconHelper there as well once we sort out its dependencies. Bug: 1058597 Change-Id: I8c47c046db36da17646c6db7ad78f50b90590a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136278 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#758002}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3999e2615f58..e9a5bd129758 git log 3999e2615f58..e9a5bd129758 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 sadrul@chromium.org rendering: Add a metric for total cpu/wall time ratio. 2020-04-09 sadrul@chromium.org rendering: Add a missing param. Created with: gclient setdep -r src/third_party/catapult@e9a5bd129758 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058155 Tbr: oysteine@google.com Change-Id: Ic2367f0ff31906ce01ee606caadb8ff8927c9ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144642Reviewed-by:
-
Sujie Zhu authored
Update the suggestion second line label for all platforms when user focuses on cardholder name/expiration date field, using new NicknameOrNetworkLastFourDigitsAndDescriptiveExpiration (replace bankname since bankname is already deprecated). Here is the display text changes for suggestion label (subtitle) on non-credit-card-number field: Desktop: Before: "Network ****2345, expires on MM/YY" After: "Nickname ****2345, expires on MM/YY" Clank Keyboard accessary: No change. "****2345" Clank Drop down: Before: "Network ****2345" After: "Nickname ****2345" iOS: No change. "****2345" When nickname feature is not enabled or nickname is not valid, fall back to display network. Note that we don't enforce that the card has to be Masked server card when we display suggestions. We will display nickname as long as nickname is available (However, as of now, nickname is only available for server card). Later we don't need to update this logic if local nicknames share the same UI. UI deck(googler only): https://docs.google.com/presentation/d/1i-C4SeAHgpvn5Q-DXlHIM-In2ORURXN6nDlY05BtBsE/edit?usp=sharing Bug: 1059087 Change-Id: I57802b8fa8da372e96c09b4245c054af4146ae76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141791 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#758000}
-
Adithya Srinivasan authored
This CL adds a change similar to https://crrev.com/c/2024110, but for the automation API. Bug: 1057598, 1045608 Change-Id: Ib27c661a6fda9c1ac0c952abf727367d9f0a79b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112512 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#757999}
-
Renato Silva authored
- Hide the option to opt-in for emails if the user is managed. - Determine the default toggle state for the email opt-in based on geolocation. Bug: 1056672 Change-Id: Idc137975e6187c3e4aec02941fedac7e00c98c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132327Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#757998}
-
wutao authored
This patch wraps the ambient mode subpage path in Chrome OS settings behind the ambient mode feature. Bug: 1068816 Test: manual Change-Id: I7e1cdf2dabdc7da15d818304ee6d18c231b99a59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142140Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#757997}
-
Kai Ninomiya authored
Deprecates GPUBufferCopyView.{rowPitch,imageHeight}. Bug: 1069302 Change-Id: Ib756ac5402c4da53e2ba02dc7f298290e5b4e8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143376Reviewed-by: -
Abigail Klein authored
subpage. The captions settings subpage must be outside of the main content div. This fixes a regression in which the caption settings subpage was not linked to the a11y settings subpage. It also fixes a regression discovered: "Regression: The spinner keep on spinning in 'chrome://settings' page." Bug: 1069422, 1055150 Change-Id: Id40f612c09e97983be7b30dd26bbc0c09201a9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144315Reviewed-by:
Katie Dektar <katie@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Abigail Klein <abigailbklein@google.com> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#757995}
-
Reilly Grant authored
This test crashes flakily on Chrome OS. Bug: 1069608 Change-Id: I6639574666195b7e3ceb3b7ec17e532b5235df80 Tbr: mcasas@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144899Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#757994}
-
Garrett Beaty authored
Bug: 1067057 Change-Id: I4bab32dc91dad5b3b75d6e6792512b7e0b46a8a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140308 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#757993}
-
Xiaocheng Hu authored
This patch adds a feature that, after 2000ms since navigation start, all pending 'font-display: auto' web fonts will immediately enter the failure display period. This prevents web fonts to become a source of bad LCP or CLS. Note: The value "2000ms" might need to be adjusted later for the best results. See https://crbug.com/1065508 for more details. Bug: 1065508 Change-Id: Ic04de331221057b019d37f421ed61050929caa0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133113 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#757992}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6480643d669a..e6f65d9265e7 git log 6480643d669a..e6f65d9265e7 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 capn@google.com Rename GenericValue to Operand 2020-04-09 bclayton@google.com CMake: Fix linux build with SWIFTSHADER_BUILD_PVR Created with: gclient setdep -r src/third_party/swiftshader@e6f65d9265e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6e3806cd40a866ea398a11ed78d5046a02f6008a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144641Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I6077d9583e639f5e89fc39272a279be591ef71d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144647Reviewed-by:
-
Dominic Mazzoni authored
First, extends TreeGenerator so that it can not only generate every "shape" of tree, but it can then populate that tree with every permutation of ignored nodes. Then, write a new test that tries every possible tree up to a certain size and tries every possible source and destination permutation of ignored nodes. We call this the "fat" tree. Update the source tree into the destination tree and capture the events fired. Next, build the equivalent "skinny" trees - the same trees but with the ignored nodes removed. Now convert the source skinny tree into the destination skinny tree. Assert that the generated events fired are the same in the fat tree as the skinny tree. In other words, ignored nodes really are ignored and don't affect things. (The only exception is the ignored_changed attribute.) Finally, check every unignored node in the fat tree and make sure that its unignored parent, children, siblings, and index in parent are all consistent with the equivalent values in the skinny tree. This test uncovered bugs, which were fixed in http://crrev.com/c/2125235 before this patch was uploaded for review. Bug: 1065144 Change-Id: I82f9b3487485f1024ee066b82c23ab0cd7b60e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139082Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#757989}
-
Gabriel Charette authored
Without this event, BrowserThread::IO can appear idle in traces while it's actually processing native events. IOCompletion being Windows-only, other platforms will need to be implemented separately in their own way once this has proven useful. Example trace with this CL : https://snipboard.io/93MeYg.jpg (green toplevel bars are the new event) Also took advantage of this to drive-by cleanup some old style construction paradigms in old code. R=fdoray@chromium.org Bug: 899897 Change-Id: I0688556413687896b880c172a00d2c4eb8c1b07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134772Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#757988}
-
Elly Fong-Jones authored
Bug: 1064663 Change-Id: I1cdaf324f5107d77dfd7dc82f02f88a04814a83b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144815 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#757987}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d9c2e89ef1ea..6574f92747a2 git log d9c2e89ef1ea..6574f92747a2 --date=short --first-parent --format='%ad %ae %s' 2020-04-09 cwallez@chromium.org Fix the @rpath of dawn_components 2020-04-09 cwallez@chromium.org Remove temporary GN groups after Chromium fix 2020-04-09 cwallez@chromium.org Fix UBO/SSBO OOB in ComputeStorageBufferBarrierTests Created with: gclient setdep -r src/third_party/dawn@6574f92747a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1064305 Tbr: cwallez@google.com Change-Id: Ic5228cf3f6ecc71d10946cc20034063e4b213242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144646Reviewed-by:
-
Reilly Grant authored
This test is flaky on Windows. Bug: 1069558 Change-Id: I99e933202d483b5084cd5c9e471571b41e6a65de Tbr: emaxx@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144811Reviewed-by:
-
Reilly Grant authored
This test was already disabled on TSan but appears flaky in other configurations as well. Bug: 1069355 Change-Id: Idd9ec3359bff023b536824a5928c3915789d465a Tbr: japhet@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144818Reviewed-by:
-
John Lee authored
This CLs changes the <settings-toggle-button> element to not use the --cr-section mixin and remove the border on itself from within its own CSS. It seems less brittle for a user of the custom element to add a border than to have the custom element have to know whether it comes first in a list or within another row. This is also more consistent with other custom elements, such as <cr-link-row>. Bug: 973674 Change-Id: Ia141423653ef9d843e30e53b02915c90b8d8d4e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137862 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
-
Lei Zhang authored
Make sure color models are color, and B&W models are not. Since PrintBackendCupsHelperTest has to deal with enum ColorModel anyway, it is a convenient spot to also exercise IsColorModelSelected(). Bug: 1069315 Change-Id: Ie3f665d5245e5aee04010f7c61d7b193936a0655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143372 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#757982}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d23973d2..0571c7d7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I867a1e7122c37624ccd005693274ad5e742be0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144711Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#757981}
-
Reilly Grant authored
This test is flaky. Dashboard: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyYgsSBUZsYWtlIldjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BEdW1wQWNjZXNzaWJpbGl0eVRyZWVUZXN0LkFjY2Vzc2liaWxpdHlJZnJhbWVDcm9zc1Byb2Nlc3MM Bug: 622387 Change-Id: I7390a0250b4005c0361788a592f4fbecf1ff4ee1 Tbr: dmazzoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144402Reviewed-by:
-
Sadrul Habib Chowdhury authored
If a 'begin main frame' is aborted (e.g. because of no visual damage), then use the time of the abort as the termination time for the trace-event, rather than when the reporter gets replaced by a new reporter for the next frame, or when the scheduler drops the reporter after the frame's deadline. BUG=none Change-Id: I4fdb32f8793eb7228439937759bdf12f0f3c0798 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138963 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#757979}
-
