- 30 May, 2019 24 commits
-
-
Shimi Zhang authored
This CL disabled the test only on Android K where it's flaky. TBR: mvanouwerkerk@chromium.org Bug: 931198 Change-Id: I66a1b2b785773c97afd806f064b9519315039a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636714Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#664571}
-
Michael Thiessen authored
Whatever issues caused us to initially disable the fullscreen API from fullscreen PWAs, they no longer seem to be present. In testing the sample in issue 720304 I couldn't find any issues. Bug: 963929 Change-Id: I6fab2f4a558c2b7fdbd61b8ed92714f671bce7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627563Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#664570}
-
Yaron Friedman authored
I was trying to look at some CustomTabs user action sequences and these were obscuring the view. Change-Id: I6b173f3964bd22692be78743d271d15043f4189a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634562 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#664569}
-
Gabriel Marin authored
Sanitizers replace the default memory allocator with a custom one. Unit tests that depend on tcmalloc functionality should not execute in such cases. These cases are identified by compile macro MEMORY_TOOL_REPLACES_ALLOCATOR being defined. While we are at it, don't instantiate the heap profiler when tcmalloc is not used, as the collector depends on tcmalloc too and it may result in flakiness. We can enable it for sanitizers once we remove dependency on tcmalloc. BUG=chromium:724399,b:70905156 Change-Id: I4ded0301e6ef190b6b45c7f01405005765f3c5e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636611Reviewed-by:
Gabriel Marin <gmx@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#664568}
-
Alexander Hendrich authored
This CL adds a flag that can be used to load an extension as login screen extension during API tests. Bug: 957573 Change-Id: Iba6299721df654d66856c7a24a4292f82938063b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599177 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664567}
-
Mohamed Heikal authored
Currently the globally accessible PowerMonitor is created and owned by BrowserMainLoop which is not created/run in reduced. In order to allow PowerMonitor to be used in reduced mode, it is created in ContentMainRunner and passed to BrowserMainLoop once full browser starts. Bug: 968247 Change-Id: If307dcbfb7f8ff0c7d34c2f4740f4a19ec77bf20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635861Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#664566}
-
Pavel Yatsuk authored
Identity disc should only be displayed on NTP for signed-in users with enabled sync. IdentityDiscController should monitor sign-in state and sync settings and show/hide identity disc accordingly. Typical scenario involves user signing out or disabling sync while on NTP. In this case identity disc should be hidden immediately. BUG=958982 R=mastiz@chromium.org,bsazonov@chromium.org,twellington@chromium.org Change-Id: Idf3fc6b8bc714634799e62a415ac51be91ff2621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633590Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#664565}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/7f4277e21b52..7ac42f80c0e8 git log 7f4277e21b52..7ac42f80c0e8 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 johnkslang@users.noreply.github.com Merge pull request #112 from mkinsner/master Created with: gclient setdep -r src/third_party/spirv-headers/src@7ac42f80c0e8 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Iadec064671e208398776988ca8b43f6fbf784dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636495Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664564}
-
Nico Weber authored
Has the effect of slightly tweaking clang-cl's behavior (noexcept mangling and md5 mangled names change slightly), and _MSC_VER goes from 1911 to 1916. Since the toolchain package that we build with comes with the 19.16 compiler (and has done so for a while), clang-cl should match. Bug: none Change-Id: I4c539cfae81364a5efdb36c192aa00bd8e0c8267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635932Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#664563}
-
Mike Dougherty authored
TBR=eugenebut@chromium.org Bug: 968296 Change-Id: I54cead2d459a678c6e865ace2ecc42559ebbb7b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635293Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664562}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/96104d42dad1..688dd321c9df git log 96104d42dad1..688dd321c9df --date=short --no-merges --format='%ad %ae %s' 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-05-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@688dd321c9df The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I3865eb86abca0460e826b3f1f49176d8661469ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636494Reviewed-by:
-
Jia authored
Bug: 967934 Change-Id: Ie99ab58537dbdc6473a9fe5f76bf59cb2db5886e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633689Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#664560}
-
Chris Palmer authored
The test allocates a random but potentially very large amount of memory, and in some cases that can cause flaking (OOM, timeouts). This CL reduces the number of random-size allocations, putting a lower ceiling on the memory use. Let's see if that's enough to de-flake the test while still keeping it sufficiently stressful. If necessary, we could possibly reduce the ceiling further, but let's start here. Bug: 966169 Change-Id: If5e632271f0c4b7117a666e96bf1873c233f5958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635355Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#664559}
-
Zentaro Kavanagh authored
- Changes which modifier maps to a right-click based on the feature kUseSearchClickForRightClick - Update tests to test both variants BUG=chromium:248762 TEST=unit_tests --gtest_filter=EventRewriterTest.* Change-Id: I22d94a5cfff2b600c6debc1d2ce2fdd1061d5623 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617066 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#664558}
-
Andrew Lee authored
Currently, some View subclasses do not override GetClassName(), so their class names will be "View" instead of something more specific like "AppListFolderView". This CL overrides GetClassName() for all View subclasses in ash/shelf and ash/system/unified Also made sure that Button subclasses have specific names Bug: 962561 Change-Id: I08fb4cea8a4d9b02eb26e4b4c7fd329cd3140bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614621 Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This patch does the renaming mojo and around functions to avoid mixing up/down flow controls. Bug: 967524 Change-Id: I4bb840186807879568a8c3f43374a7089ae1562b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631231Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#664556}
-
Tina Wang authored
Added ellipsis. Bug: 968273 Change-Id: I48016a3207f84cdef979478182df694c85218f35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635971Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#664555}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/66e46037d74f..625eb25d6e80 git log 66e46037d74f..625eb25d6e80 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 johnkslang@users.noreply.github.com Merge pull request #1776 from dgkoch/dgkoch_20190525_fixes Created with: gclient setdep -r src/third_party/glslang/src@625eb25d6e80 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Id6e18ac8349891b0c6b0054488696d89ade62d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636492Reviewed-by:
-
Xiaocheng Hu authored
|Element.innerText| is a hot code path called on every page by by TranslateHelper. However, there are some cases where we fail to layout certain blocks, and hence their NGOffsetMapping can't be computed. As the root cause is hard to fix, this patch works around it by making |innerText| emit empty strings on the failed blocks so that we don't crash in this hot code path. Bug: 967995, 955678 Change-Id: Idd8f5dbaea71d49fc70fc4a6202755d90b17b676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636669 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#664553}
-
Kenneth Russell authored
Two of the current owners have left the Chrome Devtools team, and a backup for caseq@ is needed. Bug: none Change-Id: I978a716681513b4f6ec9ae498cdbdf2da021f809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618458 Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#664552}
-
sczs authored
This test was causing a failure later on, dismissing the Banner thus nilling the animatedFullscreenDisabler_ before the test finishes fixes the issue. Bug: 966057 Change-Id: I3e6a5eba2748db7dda86836fe93f4a2b7d716b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636473Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#664551}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/903755a1f84b..7760fd2dff7d git log 903755a1f84b..7760fd2dff7d --date=short --no-merges --format='%ad %ae %s' 2019-05-29 rmhasan@google.com Add fileno implementation to _LoggingOutputStream class in run_chromeos_tests.py Created with: gclient setdep -r src/third_party/catapult@7760fd2dff7d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:967922 TBR=zhanliang@google.com Change-Id: Iadbf87d73b588390f908cf7f161aec1fe75f8b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636170Reviewed-by:
-
Justin DeWitt authored
This integrates the new tiletype inside of most likely similarly to the homepage tile - it inserts itself at the end of the new suggestions. Bug: 966024 Change-Id: Ifd24a60415aa2eb35ed49bd2ffa760814dfdc191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629032 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#664549}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2008c8ffefdd..172e5d373fad git log 2008c8ffefdd..172e5d373fad --date=short --no-merges --format='%ad %ae %s' 2019-05-29 syoussefi@chromium.org Vulkan: Implement universal stencil resolve 2019-05-29 spang@chromium.org Vulkan: Submit semaphores from glWaitSemaphoreEXT & glSignalSemaphoreEXT 2019-05-29 syoussefi@chromium.org Vulkan: fix buffer copy barriers 2019-05-29 jonahr@google.com Add EGL_ANGLE_workaround_control extension. 2019-05-29 jmadill@chromium.org Update Windows AMD suppression. 2019-05-29 spang@chromium.org Vulkan: Support submitting multiple semaphores Created with: gclient setdep -r src/third_party/angle@172e5d373fad The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:967796 TBR=cwallez@google.com Change-Id: I76826383bb68ad89da0783f33a035cceb5a0d42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636489Reviewed-by:
-
- 29 May, 2019 16 commits
-
-
Harald Alvestrand authored
This led to confusing error messages. Bug: chromium:966798 Change-Id: Ie47a56e4014fa8ae055bd1bdb405d9dc2c0cab69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635612 Commit-Queue: Harald Alvestrand <hta@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Auto-Submit: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664547}
-
Stephen Chenney authored
Add the First Contentful Paint time as a trigger for the initial commit. The rationale being that once we have painted something meaningful, we should commit it. Also add an UMA Enum Histogram to count the number of times we decide to commit for each potential reason. Bug: 805798 Change-Id: I64ff915d3b525a5c81f60381013426a005262b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627814Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#664546}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4e2aa897a424..ca41bc48d6f6 git log 4e2aa897a424..ca41bc48d6f6 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 thestig@chromium.org Get rid of CCodec_ModuleMgr::GetIccModule(). 2019-05-29 thestig@chromium.org Get rid of CCodec_ModuleMgr::GetJpxModule(). 2019-05-29 tsepez@chromium.org Add cheapo module visualization tool to repository. 2019-05-29 thestig@chromium.org Get rid of CCodec_ModuleMgr::GetFaxModule(). 2019-05-29 thestig@chromium.org Get rid of CCodec_ModuleMgr::GetBasicModule(). 2019-05-29 tsepez@chromium.org Remove circular includes from core/fpdfapi/cmaps. 2019-05-29 thestig@chromium.org Get rid of CCodec_ModuleMgr::GetFlateModule(). 2019-05-29 thestig@chromium.org Add component build bots to the default try job set. Created with: gclient setdep -r src/third_party/pdfium@ca41bc48d6f6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Ic81c24e9e2eb550df1c602f22fb5bb5fe7353f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636490Reviewed-by:
-
Eugene But authored
crrev.com/c/1632591 changed test behavior to wait until reload is finished for slim nav, which broke the test. This CL restores the original behavior, so the test does not wait until reload is finished. Added -[ChromeEarlGreyImpl reloadAndWaitForCompletion:] to compliment existing -[ChromeEarlGreyImpl loadURL:waitForCompletion:] Bug: 968296 Change-Id: I86d1d982424ee4f56c64ac4cae522f1070d116ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636570 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#664544}
-
Wei-Yin Chen (陳威尹) authored
Frame rate and dirty time span in the Tab-to-Grid animation are measured for the following use cases: - From NTP - From live tab, with total number of tabs = {1, 10, 100} Bug: 964406 Change-Id: I2e181596c9f3145557257b7b060ffee4db6f8cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634395 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664543}
-
Marijn Kruisselbrink authored
Existing files are all fine because of a presubmit enforcing this, but setting gitattributes makes it easier to not trigger the presubmit in the first place. Bug: 832129 Change-Id: I3e82d89196d28d23c609e5e1ded56817505da0e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635868 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#664542}
-
Vladislav Kaznacheev authored
This CHECK should help determine the exact reason why GetProfileForNotifiers returns nullptr and causes a high frequency crash. Bug: 957121 Test: none Change-Id: I5a62a83eea0e768ad162fbec755411e32186ff16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635077 Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#664541}
-
Kenneth Russell authored
The following two tests are observed to flake in webgl2_conformance_gl_passthrough_tests : conformance/extensions/webgl-compressed-texture-s3tc.html conformance/extensions/webgl-compressed-texture-s3tc-srgb.html Bug: 963205 Change-Id: Ic9c8ae5b7099f5fc02d7ccab802edbcb912c0939 Tbr: jonross@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636229Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#664540}
-
Antoine Labour authored
Use an explicit shared image allocation for the intermediate texture that is used in both the source and destination GL contexts. Bug: 882547 Change-Id: Ibd37bb16a1a43860976c9b35feadd576e099df4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633530 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#664539}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/740cc35145c0..72055b11beb9 git log 740cc35145c0..72055b11beb9 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8891f34d..2d1120f0 (664289:664417) Created with: gclient setdep -r src/third_party/webrtc@72055b11beb9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I757872174f1d5946e4f47f09e4121350dee52667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636210Reviewed-by:
-
Daniel McArdle authored
The problem this CL addresses is that several semantically-different messages are currently jammed into the response from OnCertificateRequested. For example, using nullptr for certificate and private key to signify that no certificate was selected. This CL eliminates the response from OnCertificateRequested and moves it into several different messages within the new ClientCertificateResponder interface. Bug: 946742 Change-Id: I49c63bdc0732a438336a02e558d4cca4d1202ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589995Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#664537}
-
Jinsuk Kim authored
Replaces Tab.notifyRendererPreferenceUpdate with a new API on WebContents. This CL addressed a TODO in Tab. Rather than exposing Java RenderViewHost which requires modification in already-deprecated native content::RenderViewHostImpl, the changes follows the direction recommended in the comment by updating WebContents for this page-specific function. Bug: 960746 Change-Id: I7bfe3c1d04a7a7ec2906e829912e7906ff30d937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630378 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
-
Justin DeWitt authored
The ExploreSites tile is a special one that can't be removed or used inside an incognito tab. Bug: 966024 Change-Id: Idf2340ee879575ffe1c0f3402a4d7725326df248 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635853 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#664535}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3d62cb814853..e7866de4b1dc git log 3d62cb814853..e7866de4b1dc --date=short --no-merges --format='%ad %ae %s' 2019-05-29 pierremoreau@users.noreply.github.com Linker: Better type comparison for OpTypeArray and OpTypeForwardPointer (#2580) 2019-05-29 zoddicus@users.noreply.github.com Add compact ids to WebGPU <-> Vulkan transformations (#2639) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e7866de4b1dc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel;luci.chromium.try:win_angle_deqp_rel_ng TBR=radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I2cfa33eec1a62b01992ee8c2400f458726887e43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636209Reviewed-by:
-
rbpotter authored
Rename print-preview-user-info to print-preview-user-manager and move management of user account state to print-preview-user-manager, instead of sharing this responsibility between user-info and print-preview-destination-settings. Remove cloudPrintState in favor of checking the activeUser and a single cloudPrintDisabled boolean. Finally, send user account updates from PrintPreviewHandler, instead of just sending reload-print-destinations event. This should not change any user visible behavior. Bug: 958767 Change-Id: I4ff2545f78b35537a8cc54a8a11bf0c5aed9ae07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628330 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#664533}
-
Peter K. Lee authored
Bug: 965958 Change-Id: I1658084e1542a646f2c40fd9a46e60a8773aede3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631752 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Auto-Submit: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#664532}
-
