- 10 Jul, 2019 40 commits
-
-
Liquan(Max) Gu authored
Largest Image Paint used to have a cap on the map & set, containers for the recorded nodes/objects/images. The cap was placed in order to prevent the containers from growing uncontrollably. But actually, if it grows in proportion to the size of the DOM tree, its size should be deemed under controlled. Based on this idea, we should remove the cap of containers in LIP. This CL also fixes the issue that the |invisible_node_ids_| set didn't remove node_id. Otherwise, its size would be grow uncontrollably. Related CL: crrev.com/c/1685325: the text counterpart Bug: 966476,967837 Change-Id: I29462450311b337bf635bc3cfd68379286422e6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692199 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#676154}
-
Weiliang Chen authored
When we set up OutputSurface as overlay, it will always have z-order of 0, since z-order 0 is defined as primary plane. R=dcastagna@chromium.org Bug: 963597 Change-Id: I6b399b13ba4d447686b8d957dd50d3ca6011c912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695988Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#676153}
-
Toby H authored
Bug: 943208 Change-Id: I879cccddd6b307bef415727b2e2ca8e837ce4f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682727Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#676152}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/be75ef60754c..198be0a8bff1 git log be75ef60754c..198be0a8bff1 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 treehugger-gerrit@google.com Merge "Add missing include" 2019-07-10 treehugger-gerrit@google.com Merge "processor: Add storage for thread_slices + TrackEvent tts support." 2019-07-10 treehugger-gerrit@google.com Merge "UI: Improved vid-trace sync & features" 2019-07-10 treehugger-gerrit@google.com Merge "Add a simple fuzzer for the traced_producer socket." 2019-07-10 lalitm@google.com Merge "metrics: add unaggregated memory metrics" 2019-07-10 eseckler@google.com Merge "processor: Add storage for virtual tracks" Created with: gclient setdep -r src/third_party/perfetto@198be0a8bff1 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I14dedd9e228f657196a889cc2268667311da8104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#676151}
-
Asanka Herath authored
The quarantine component attaches metadata to files downloaded on Windows and macOS indicating their source. This is done so that the OS and AV products can factor the source of the file into evaluating whether the file is safe. Previously the source URL was presisted in its entirety. This change introduces a sanitization step that removes unnecessary information from the URLs being persisted. See bug for details on what's being removed and why. R: wfh@chromium.org Bug: 917842 Change-Id: I7831d1486b73a7e2858004e719c9680ea7a43d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1407439Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#676150}
-
Ian Vollick authored
With this change, I've disabled SiteSettingsCounterTest. CountWithTimePeriod (logged crbug.com/981972 for this), and I've updated a few other tests to account for the fact that CONTENT_SETTINGS_TYPE_NOTIFICATION does not expect CONTENT_SETTING_ASK on Android. See SetWebsiteSetting in notification_channels_provider_android.cc Bug: 974405,981972 Change-Id: I28264fe120a4051014c29c4bdf052010d8c842c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691219Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#676149}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/abb5a315af45..cc3264288255 git log abb5a315af45..cc3264288255 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 robertphillips@google.com Fix SkPixmap and SkBitmap dox for computeByteSize 2019-07-10 bsalomon@google.com Reland "Revert "Restore GL_UNPACK_ROW_LENGTH to 0 between MIP levles"" 2019-07-10 fmalita@chromium.org [skottie] Caching motion tile 2019-07-10 nigeltao@google.com Update Wuffs version 2019-07-10 borenet@google.com Revert "[infra] No relative path for infra_tests.isolate" 2019-07-10 robertphillips@google.com Add protected status to SkSurfaceCharacterization 2019-07-10 bsalomon@google.com Revert "Revert "Restore GL_UNPACK_ROW_LENGTH to 0 between MIP levles"" 2019-07-10 borenet@google.com [infra] No relative path for infra_tests.isolate 2019-07-10 brianosman@google.com Interpreter: Disallow recursion Created with: gclient setdep -r src/third_party/skia@cc3264288255 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:981254,chromium:981254 TBR=fmalita@google.com Change-Id: I38318288e330a6afbe96e2587f4c09aaba135c73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695625Reviewed-by:
-
Ted Meyer authored
Splitting up the CL for D3D11 reporting max resolutions Change-Id: I087b3b422ac93a17d1fd581236bfc416a40070e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696083Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#676147}
-
Christopher Thompson authored
The final UI for showing the certificate org details in Page Info landed in crrev.com/c/1686172. This updates the string description to better match the final string and location, and adds a translation screenshot for the final UI. Screenshot for reference: https://screenshot.googleplex.com/ynwcgisiXgO Bug: 969734 Change-Id: I589a28b03f228d96f52e760c5b29fb7eeeeb5e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696123Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#676146}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/69e46a186bb7..fba3e64e8086 git log 69e46a186bb7..fba3e64e8086 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 jonahr@google.com Update trigger.py to take extra arguments 2019-07-10 timvp@google.com Vulkan: Fix khr-gles3.shaders.uniform_block.common.name_matching test failure Created with: gclient setdep -r src/third_party/angle@fba3e64e8086 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Id5f554fb49606449d92efd0aeb38ac428e6da220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696202Reviewed-by:
-
Alex Newcomer authored
Some cleanup code is saved until after the AppListView animations are complete. This makes animations smoother. Because there are no animations in side shelf mode, this cleanup is skipped. Do it in SetChildViewsForStateTransition. Also removed some redundant code (L1007 - L1011). This is done in the call at L1001. Bug: 981292 Change-Id: I406cde5bdfb152ab4829e275757c71c3b6f877dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693503 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#676144}
-
Ayu Ishii authored
This changes turns on the experimental SMSReceiver API for the Android platform excluding WebView and for tests on Non-Android platforms. Implementations for desktop are still in discussion and will be detached completely from the implementation and release of the SmsReceiver API release for Android. Bug: 963653 Change-Id: Iefe3b9b135e6a9ae4ed30f00370bb32747481e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1620107Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#676143}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/8aa9a7bb8f74..f970253a5d41 git log 8aa9a7bb8f74..f970253a5d41 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 johnkslang@users.noreply.github.com Merge pull request #1827 from alan-baker/update-spirv-tools Created with: gclient setdep -r src/third_party/glslang/src@f970253a5d41 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,cwallez@chromium.org Change-Id: I72f1cc9d93ce4715da1c5d7d93c4b766fa445c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695898Reviewed-by:
-
Tarun Bansal authored
Change-Id: I3ecf89469653e98afed23f4d6cf8185bde032be8 Bug: 978490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687483 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#676141}
-
Nektarios Paisios authored
AccessibilityNotificationWaiter is part of the accessibility browser tests infrastructure. Focus events are fired via a different mechanism in BrowserAccessibilityManager than all other Blink-based or generated events. In order to write effective tests that check if a focus event has been fired, we need to modify AccessibilityNotificationWaiter to watch for focus events too. R=aboxhall@chromium.org Change-Id: I1e8730442cd733f51b7510592e0f9f0bc6f3c2a3 Bug: 982776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692104 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#676140}
-
Eric Roman authored
Historically the capture mode had aspirations for more complex parameterization, but in practice it just an enum. Refactored the code to reflect this, and also simplified the symbolic names. This is strictly a code refactor, except for one user-visible change: The command line switch --net-log-capture-mode now accepts both the old and new names. TBR: peter@chromium.org,seantopping@chromium.org,garykac@chromium.org,torne@chromium.org,scottmg@chromium.org Change-Id: I9bce3f7425bf47e8b24063dc922c534c2aa1f21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685684Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#676139}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/2801e6969bfd..a53be27c2404 git log 2801e6969bfd..a53be27c2404 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 rsmoore@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@a53be27c2404 The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Change-Id: Iaffd3119f93219a724b908180bcd274a26c4f2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696164Reviewed-by:
-
Erik Luo authored
DevTools agents rely on getting specific computed styles via getComputedCSSValueInternal(). After a refactoring [1], this method stopped accepting platform property names as strings, and started using IDs. This CL migrates those callsites to use IDs, which fixes the broken style tooltips on hover during 'inspect mode'. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1676647 Bug: 982396 Change-Id: Iebe59024659a8ee90db1396cfb9b83796a9689b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694404Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#676137}
-
Findit authored
This reverts commit 5e7eacc6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 676033 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWU3ZWFjYzZlYTU1ZjJhNTA2OTNkMzJhMGZhYzNiMjM3MGRmMWQwNAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/81695 Sample Failed Step: webkit_layout_tests Sample Flaky Test: fast/events/layout_change_after_update_hover.html Original change's description: > Reset hover dirty flag before RecomputeMouseHoverState function > > MouseEventManager::RecomputeMouseHoverState may change the hover dirty > flag because it sends mouse boundary events such as mouseover, > mouseout, mouseenter and mouseleave, which may change the layout. We > need to reset |hover_state_dirty_| before we call > RecomputeMouseHoverState, so that we make sure that the hover is > updated for all the layout change. > > Bug: 877132 > Change-Id: Id6ec90e8f6ced06a68dffa1a31cd34b92294af37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689959 > Commit-Queue: Lan Wei <lanwei@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676033} Change-Id: I875b1ebda88b4a802b18bb5e8dabef5f139e83df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 877132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696524 Cr-Commit-Position: refs/heads/master@{#676136}
-
David Bokan authored
This CL fixes Blink unit tests when the FractionalScrollOffsets flag is turned on. This flag enables storing floating point scroll offsets inside Blink's ScrollableArea objects. This means that fractional offsets are now visible to JS and test code; some tests need to be adjusted to the new expectations. The typical test here performed something like a ScrollIntoView which should land on a fractional offset when trying to center an element. Prior to FractionalScrollOffsets, this would be floored. I've adjusted these tests to either change the page slightly so that we naturally land on an integral offset or provided a new expectation behind the runtime enabled feature. This is ok since these tests are just checking that an element is scrolled into view, we don't care about exact pixel offsets. For the smooth scrolling tests, I allowed a 1px difference in the expectation since these are checking a scroll offset mid-animation. After this CL, all Blink unit tests pass with FractionalScrollOffsets enabled. Bug: 414283 Change-Id: Ief639a780d0780ab74ca11718c05921ed8a4670d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690221 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#676135}
-
Andrew Grieve authored
This checks in a .txt copy of the broken license. Also enables a --debug flag to debug issues like this in the future. Bug: 982846 Change-Id: I015e7d0a1155d3d5cc55b9a1556b2ce5ec706d98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695817 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#676134}
-
Adam Raine authored
Added extra test statements to detect if a CSSPaintImageGenerator is notified before all the registrations and cross thread checks are finished. Follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1688641 Bug: 948761 Change-Id: Ia82fd1390465a96fbd97e4c0c7016f894fe0dd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689784Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Adam Raine <asraine@google.com> Cr-Commit-Position: refs/heads/master@{#676133}
-
Marijn Kruisselbrink authored
Actually hooking this up to a blocklist etc will be done in future CLs. See https://storage.cloud.google.com/chromium-translation-screenshots/8f6df1b3e036b7d1ff3f02ffb177ce99865ad7cb for what this dialog looks like. Bug: 968851 Change-Id: I20930d63e1e799da92dd9784678bb12f6b8e2f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680950 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#676132}
-
Jun Mukai authored
When the app list is expanded by drag, it should update the opacity of the items at the bottom of the screen. This logic has been lost as a side effect of r672145. It's a bit complicated that since the layer should be created only when it's necessary. Also UpdateControlVisibility() does not have to control the visibility of individual items, since those items are the only children of AppsGridView. Instead it updates its own visibility. This CL seems not changing LauncherDragTest performance numbers, as far as I tested in nocturne. Bug: 982404 Test: manually / ash_unittests Change-Id: I28780cdeb403724a5fefa35134261b656ce81edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693739 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#676131}
-
Elly Fong-Jones authored
The design intent of MenuClosureAnimationMac is that it should cancel automatically on destruction. This does happen on the normal path, since callbacks are posted either via base::OneShotTimer or gfx::Animation, both of which cancel on destruction. However, on the test path, a vanilla PostTask() is used, with an unretained receiver. This means that this code is not safe: animation->Start(); animation.reset(); when views::test::DisableMenuClosureAnimations() has been called. This change makes MenuClosureAnimationMac use a WeakPtr to itself as the receiver for the test animation completion callback, which gives the desired cancellation behavior. This change also makes views::test::WaitForMenuClosureAnimation() more robust: now it uses Run+QuitClosure to exit its RunLoop rather than RunUntilIdle. Bug: 965601 Change-Id: Idb8a75449f79c44cfdb55a168e7c1bc9537785c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687347 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#676130}
-
Koji Ishii authored
This patch changes |NGInlineLayoutAlgorithm::Layout()| so that it consumes the last opportunity even if it seems the line does not fit to it. This normally does not happen as the last opportunity is designed to fit any lines, but arithmetic overflow can still pretend the line does not fit to any opportunities. This patch changes so that the last opportunity never fail. Bug: 982126 Change-Id: If0c460f20d48b01b125e2f10bc50182fa5654eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695304 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#676129}
-
Andrii Sagaidak authored
flag drop down or flag edit field on chrome://flags page Bug: 982439 Change-Id: Ieb95cd57fdabcd70ec12a8d8685e7e42292afaaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693702Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Andrii Sagaidak <ansagaid@microsoft.com> Cr-Commit-Position: refs/heads/master@{#676128}
-
yilkal authored
Bug: 977019 Change-Id: Ia3d06b9e43b969540435269ea047816f7bf1521a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684592 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#676127}
-
Hector Carmona authored
This reverts commit 304bb952. Reason for revert: This was not the cause of the test failure, reverting this revert and creating a new CL to disable the test in linux. See pre-existing issue: https://crbug.com/972822 Original change's description: > Revert "Replace use of std containers with WTF's equivalents in html_slot_element.h" > > This reverts commit c2d3f186. > > Reason for revert: Suspecting this CL for test failures in Linux CFI > https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI > > See first test failure of AdsPageLoadMetricsObserverResourceBrowserTest.AdFrameSizeInterventionMediaStatusPlayed here: > https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/14253 > > Suspecting this CL since it was the only one that touched code in t/p/b/r/c/html for that blamelist and crash shows blink::HTMLParserScheduler::ScheduleForUnpause within stack trace. > > Original change's description: > > Replace use of std containers with WTF's equivalents in html_slot_element.h > > > > This CL replaces the use of std::array of std containers with WTF::Vector > > and introduces LCSArray struct in html_slot_element.h. > > > > Bug: 952716 > > Change-Id: I45d0dcbb63aed5198440bd7b94c5c693a05bd6fd > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694801 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#675985} > > TBR=haraken@chromium.org,myid.shin@igalia.com > > Change-Id: Ibf0a3bb5b4d4f579085986b941a5d6e710d0e6fc > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 952716 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696007 > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Commit-Queue: Hector Carmona <hcarmona@chromium.org> > Cr-Commit-Position: refs/heads/master@{#676073} TBR=haraken@chromium.org,hcarmona@chromium.org,myid.shin@igalia.com Change-Id: I3c1efe12f7fd40512bc5a32f41945512916585df No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 952716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696179Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#676126}
-
Luum Habtemariam authored
Seems that some fuzzers are running on linux with 'target_os="chromeos"' in their gn args; this should actually turn it off. Bug: chromium:831914 Test: confirmed fuzzing target is hidden Change-Id: I68e06123c8a3b5e75a83d63640f7339b8ccdae25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696209Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#676125}
-
Esmael El-Moslimany authored
Bug: 967793 Change-Id: Ibea3efc3fc74be3b9a485345f87c8942be8b5b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1686215Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#676124}
-
Luum Habtemariam authored
Currently calling ResolveUsbManufacturer for ALL printers that fail ppd matching; now correctly filtering for usb printers. Bug: none Test: manually confirmed removed log spam Change-Id: I71b601d496001fc2c1ea14ca1281046f245d1c58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696187Reviewed-by:
-
Ricardo Quesada authored
This CL adds more debugging info while printing the window hierarnchy (ctrl+shift+alt+w) when the ash-debug-shortcuts are enabled. The new debug info is: - app type - package name (ARC only) - title It also adds missing header files reported by 'git cl lint' BUG=None TEST=Enable 'ash-debug-shortcuts' and press Ctrl+Alt+Shift+w On /var/log/chrome/chorme you can see the newly added data. Change-Id: I62b52adb2db15ca8cc4c30b8d4b83c388198fb48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695981Reviewed-by:Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Auto-Submit: Ricardo Quesada <ricardoq@chromium.org> Cr-Commit-Position: refs/heads/master@{#676122}
-
Min Qin authored
The content setting is confusing as it is "allow multiple downloads". So in case an origin is blocked, we should still allow one download. This CL also fixes an issue that on user gesture, download status from other origins are reset although it should only reset the status on the current page. BUG=981966 Change-Id: I0519aa091446f2a2d81f4dcf074abf34849b9fe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693552Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#676121}
-
Vladislav Kaznacheev authored
The two tests (SelectionInsideScreen, HighlighterGesturesScaled) were disabled because they stopped working in Mash). SelectionInsideScreen is now passing reliably after Mash removal. HighlighterGesturesScaled required some changes to accommodate the new contract of highlighter selection callback (it is now passing a rectangle in dip instead of px). Bug: 917113 Test: automated Change-Id: I43a2dd9a28ce0efc2748cf208e9c04c470d89026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695657Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#676120}
-
Tommy Steimel authored
This CL updates the global media controls UI to show all media sessions instead of just the most recently active media session. Bug: 973492 Change-Id: Ib0943d4044ee3c036a1b783785695ebba09eb0f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695989Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#676119}
-
David Bokan authored
This CL fixes Blink web tests so that they pass when the Fractional Scroll Offsets flag is enabled. This flag enables fractional offsets on the Blink main thread which breaks some tests because they assume that offsets will be floored. I've modernized two tests: fast/events/platform-wheelevent-paging-y-in-non-scrolling-div.html fast/events/scale-and-scroll-div.html The first appears to have been an issue with js-test modifying the page while the second was passing but the PASS string in the -exected.txt had changed to include the factional. Both tests now pass with and without the feature enabled. I removed fast/events/touch/gesture/touch-gesture-scroll-div-scaled.html since it was testing the same thing as scale-and-scroll-div.html. The rest of the tests required changing the layout such that it doesn't cause us to land on fractional offsets (and thus the behavior will be unchanged with and without the flag). Where this was difficult I just allowed for approximate equality. Bug: 414283 Change-Id: Ie03fa06b100fb9946675e921357c1eaebfe6a37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690293 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
Luum Habtemariam authored
Originally rolled my own value mojom representation, but have since started maintaining the libCUPS ValueType separately, ergo rewrite. Bug: chromium:945409 Test: unittests still pass Change-Id: Ie8c2009f57b06930aa4d40e50b023aa71fa04e10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672488 Commit-Queue: Luum Habtemariam <luum@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
David Grogan authored
If a table is added dynamically as a child of a table cell, the cell might call innerTable->HasSections() before the inner table has calculated its sections. The cell was checking HasSections() because cells change sizing behavior when they have a table with sections as an immediate descendant. This only happened in a very narrow scenario -- when an abspos table with a %height that does not resolve as auto is dynamically added. Bug: 977507 Change-Id: I7856291dc6508624a81e9b65af909fa8a0d8e749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696003Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#676116}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/808e9b88cf2e..5fcd7aab39b8 git log 808e9b88cf2e..5fcd7aab39b8 --date=short --no-merges --format='%ad %ae %s' 2019-07-10 tsepez@chromium.org Zero-fill PatternValue::m_Comps 2019-07-10 nigi@chromium.org Add a pixel test for rendering overlapping thin lines. 2019-07-10 thestig@chromium.org Roll build/ 4cebfa34c..5a8b627ed (15 commits) 2019-07-10 thestig@chromium.org Make CLZWDecoder decode in a single pass. 2019-07-09 tsepez@chromium.org Rename GetNativeFont() to GetNaiveFontName() in several places. Created with: gclient setdep -r src/third_party/pdfium@5fcd7aab39b8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:982768 TBR=pdfium-deps-rolls@chromium.org Change-Id: I55d97846276e1c9aaebc903af67fccb64c201273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696201Reviewed-by:
-
