- 08 Jun, 2018 40 commits
-
-
gogerald authored
Use case of this change is for payment request + payment handler (service worker): Users could enter into incognito mode and install a payment handler (service worker) there. Then go to a merchant website to buy with that payment handler, which will open a web page in custom tab to ask inputs. After that the opened web page should be able to find out the service worker to send back the result. So the registered payment handler (service worker) and opened web page must in the same browser context. Below is the test video record, https://drive.google.com/file/d/1CTFw9_-jCOvmV1fEMg8TZHd0inNKdPS2/view?usp=sharing Bug: 848245 Change-Id: Ice00df0b53c40a34108d84c8fa55d8160a03d6e2 Reviewed-on: https://chromium-review.googlesource.com/1080688 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#565700}
-
Robert Ogden authored
This CL adds a content description to the "Details" TextView header over the Data Usage Breakdown table. This content description describes what the current sorting scheme to users using TalkBack. Bug: 849395 Change-Id: I8328a5a41a37a55a532c5955777200df73a44f53 Reviewed-on: https://chromium-review.googlesource.com/1090072Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#565699}
-
sczs authored
- Adds a BlurEffect to the styler. - Makes NavigationBar translucent. Screenshot: https://drive.google.com/open?id=1wW2bL4AP3TusA64yPVgAyGMg4_hncVQT (The blue squares were added so the Visual effect is easier to see) Bug: 838580 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4e03b2dde5633716fbe131893433e6142abfa653 Reviewed-on: https://chromium-review.googlesource.com/1084321 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565698}
-
edchin authored
A history coordinator that is started from main_controller won't work properly from the tab grid. Using a local coordinator works better when hooked up with a specialized URL loader and tab presentation delegate. This CL introduces a specialized URL loader that behaves differently from the one in BVC. Essentially, BVC's loader navigates the current WebState to the new URL. In tab grid, we need to append a new WebState to the end of the list, because there is no context of a current visible BVC. Also in this CL is a change to how tab presentation is handled. In the stand-alone recent tabs, the BVC is already presented so there is no need to actively present it. However, in tab grid, there is no visible BVC. To show the tab that was tapped in recent tabs, we needed a mechanism that could present BVC when in the tab grid, but NO-OP in the stand-alone case. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id3b8a88e548de14356f997a8154fed9d613b18d0 Reviewed-on: https://chromium-review.googlesource.com/1092510 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#565697}
-
Dmitry Gozman authored
This splits LoadInternal and removes it. Bug: 789577 Change-Id: I4931659a1f50890fcda489e74591d12a2d2c4419 Reviewed-on: https://chromium-review.googlesource.com/1083823Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#565696}
-
Max Rebuschatis authored
Bug: 848959 Change-Id: I99c958ba7ae1de5c233e77d085dbd20880baf6ca Reviewed-on: https://chromium-review.googlesource.com/1089812 Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#565695}
-
Troy Hildebrandt authored
Certain search providers have a search URL that differs on mobile from what we have in prepopulated_engines.json. Using alternate_urls and the google:pathWildcard marker this CL adds/fixes several search URLs. Additionally, all of the Yahoo! are broken across the board, which this fixes. Query in Omnibox is fixed for all currently known broken cases. Bug: 834876 Change-Id: I78955ccbd2079945eeb4542c962fe0673ae4c65c Reviewed-on: https://chromium-review.googlesource.com/1060413 Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#565694}
-
Jeremy Klein authored
kEnableUnifiedMultiDeviceSettings should be used here instead of the old flag that was added for SMS sync. This new flag is part of the unified better together effort. R=dpapad@chromium.org, khorimoto@chromium.org Bug: 824568 Change-Id: Id1c21c0905213bcbcf3a18e17d7a51ffc2e57194 Reviewed-on: https://chromium-review.googlesource.com/1092238Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#565693}
-
Sky Malice authored
Bug: 831642 Change-Id: Idd4b8aeb1470482ac2bbd8fdab8ae066ead4d300 Reviewed-on: https://chromium-review.googlesource.com/1087592Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#565692}
-
John Z Wu authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I79b509fc63a011a8dcdfcf040ef694fc4a2170f8 Reviewed-on: https://chromium-review.googlesource.com/1092074Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#565691}
-
Ryan Sturm authored
When the DRP config service sends a bool to ignore the previews blacklist for server previews, the long term (host and user) rules will be ignored for server previews. Client previews will still respect those rules. Bug: 849328 Change-Id: I4ef5f6b3e71592cba1eaa9c6e0006780191de6b5 Reviewed-on: https://chromium-review.googlesource.com/1086364Reviewed-by:
Peter Williamson <petewil@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#565690}
-
Allen Bauer authored
UX requested this minor change in advance of a user-study focused on getting direct usability feedback for the new UI changes. Bug: 850981 Change-Id: I1a673fd16bcc1ed736eb35399839ec653a5fb51d Reviewed-on: https://chromium-review.googlesource.com/1092793 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#565689}
-
John Z Wu authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id3ceb16cc07aec0ad376494315db77959806570a Reviewed-on: https://chromium-review.googlesource.com/1091973Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#565688}
-
Sidney San Martín authored
Part 1: https://chromium-review.googlesource.com/c/chromium/src/+/1066304 This change picks up from the above CL and adds hooks into the GPU process to coordinate its CATransaction with the browser's on request (e.g. for resize). New GPU IPCs let the browser process, via CATransactionObserver, begin a transaction and then end it while in the post commit phase of its CATransaction. This makes compositor changes display atomically with changes in the browser process. It also fixes the window frame jank described in the above CL when the GPU process assigns new IOSurfaces as CALayer contents. I think this is because the two CATransactions happen as one from the window server's point of view: in a test app, committing the two transactions like this significantly reduced the time to commit. Bug: 837660 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ib5b2a3a3cae76640cc9872b7f265cb3bd13143a4 Reviewed-on: https://chromium-review.googlesource.com/1077047Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#565687}
-
Amy Qiu authored
Move pathological_mobile_sites into the rendering folder and refactor to inherit from the RenderingStory class Bug: 849392 Change-Id: Ie34cda5845f73b133e9d1df34430eede20f2d670 Reviewed-on: https://chromium-review.googlesource.com/1089383 Commit-Queue: Amy Qiu <amyqiu@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#565686}
-
Ryan Tseng authored
Bug: 790277, 790274, 790292, 790281, 790269 Change-Id: I48e7869ce0974c36149a18653c39c0c7c2ff5502 Reviewed-on: https://chromium-review.googlesource.com/1092041 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#565685}
-
Sidney San Martín authored
Bug: 849538 Change-Id: Ib04c020dbc50aae398255654f5404fd8904a5326 Reviewed-on: https://chromium-review.googlesource.com/1092232Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#565684}
-
Andrew Luo authored
Bug: 838650 Change-Id: Ibda5c05eafda372ecd56e35f3814efeedac86f56 Reviewed-on: https://chromium-review.googlesource.com/1083940 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#565683}
-
Fabrice de Gans-Riberi authored
Bug: 753851 Change-Id: Id457ec00228fe6a5592719c47491087e979bd5b2 Reviewed-on: https://chromium-review.googlesource.com/1077600 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#565682}
-
Xi Cheng authored
Change-Id: If62a55a7c407096cc89af6df245acc4d9dec32d3 Reviewed-on: https://chromium-review.googlesource.com/1091932Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#565681}
-
Ulan Degenbaev authored
The renderer sends a RendererIsBloated event to the GRC service. The GRC turns the event into a PageIsBloated signal and sends the signal to the tab manager in the browser process. The tab manager then reloads the bloated tab. Subsequent CL will add a notification from the tab manager to the web contents, so that it can show an inforbar after the reload. Bug: 835806 Change-Id: I23d0987094f1c6864534abeb57f8cce3273172ff Reviewed-on: https://chromium-review.googlesource.com/1073419 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#565680}
-
Adolfo Victoria authored
Added the icons for the native SMB client to the theme, this changes the icon under the "Add New Services" menu in the Files app to the correct one. Updated the URLs in smb_provider.cc accordingly. BUG=chromium:842753 TEST=verified on test device (cave board) Change-Id: Id4f835f0ea167707c34f35b9022c6f685ce2f958 Reviewed-on: https://chromium-review.googlesource.com/1077548Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Adolfo Higueros <adokar@google.com> Cr-Commit-Position: refs/heads/master@{#565679}
-
Tao Bai authored
Bug: 849870 Change-Id: Ib51b8fbb51c107e4cd31910b4c342e8c2186402b Reviewed-on: https://chromium-review.googlesource.com/1091462 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#565678}
-
Greg Kraynov authored
Bug: 783309 Change-Id: I4572bf52fb31840cdb6006d8821bc29c2fd071f3 Reviewed-on: https://chromium-review.googlesource.com/1079567 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#565677}
-
Rayan Kanso authored
The switch will be deleted in a follow-up CL. Bug: 826257 Change-Id: I288e4bc5050714357c10b2d04e95586e23df44f4 Reviewed-on: https://chromium-review.googlesource.com/1089057 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#565676}
-
Darren Shen authored
Currently Undo/Redo are not added when there are menu items before it. This was to deal with autocorrect/selected text items. However, when we add Emoji as a menu item, we still want Undo/Redo to show. This patch makes an exception for this. Test: Is tested in crrev/1090408 Bug: See crrev/1090408 Change-Id: I960e064e2829e97b61e6fa8be31091dd6f671f24 Reviewed-on: https://chromium-review.googlesource.com/1092214 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565675}
-
Hans Wennborg authored
After upstream change r334036, LSan started printing a warning to stdout, breaking the test expectations. Bug: 850867 Change-Id: I9a5857a3175f7520ffe448f41fb260d5722c62d4 Reviewed-on: https://chromium-review.googlesource.com/1092740 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#565674}
-
Elly Fong-Jones authored
This change: 1) Adds focus rings to the tab-close button 2) Moves the new tab button to last in the TabStrip's focus order if it is not in LEADING position so that the keyboard focus order within the TabStrip is correct Positioning the ring for the tab-close button requires some finesse: the tab close button has its margins adjusted, but the focus ring only needs to draw around the visible part of the button. Bug: 848299 Change-Id: I226683d3a8829f5a88e9bf102b4c8ba4ecfae459 Reviewed-on: https://chromium-review.googlesource.com/1091131Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#565673}
-
Ben Pastene authored
TBR=jbudorick@chromium.org Change-Id: Ie11ee477222ea041c0f5d558306d52b3b83c2c32 Reviewed-on: https://chromium-review.googlesource.com/1093267Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#565672}
-
Xiaohan Wang authored
Fix a copy/paste error in the previous CL. Bug: 849846 Change-Id: I32440d9c8a8e8879f262d6e3b8b51547301fcec2 Reviewed-on: https://chromium-review.googlesource.com/1093271 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#565671}
-
Samuel Huang authored
This reverts commit b1d35c01. Reason for revert: Speculative revert did not fix problem. Original change's description: > Revert "Fix browser menu button flood fill effect always originating from center" > > This reverts commit 25016613. > > Reason for revert: Speculative revert for > virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-click-hyperlink.html > failure under WebKit Linux Trusty (dbg) . > > Original change's description: > > Fix browser menu button flood fill effect always originating from center > > > > The MenuButton::PressedLock used to be always created with a null > > event from MenuController::Run() causing it to eventually call > > AnimateInkDrop() with a null event, which then used to clear > > the inkdrop host's `last_ripple_triggering_event_` which is > > used as the point from which the flood fill is generated. > > > > This CL passes the current located event (if any) to > > MenuButton::PressedLock. > > > > BUG=819878 > > > > Change-Id: I4fb18ab73f60c75af3bce948f44ac41a8c6683b8 > > Reviewed-on: https://chromium-review.googlesource.com/1089495 > > Reviewed-by: Trent Apted <tapted@chromium.org> > > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#565538} > > TBR=tapted@chromium.org,afakhry@chromium.org > > Change-Id: Ib3c0639e217e4e62d6c8a1aa004eda721e318c4f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 819878 > Reviewed-on: https://chromium-review.googlesource.com/1092249 > Reviewed-by: Samuel Huang <huangs@chromium.org> > Commit-Queue: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#565654} TBR=huangs@chromium.org,tapted@chromium.org,afakhry@chromium.org Change-Id: I6a7b6243c363699a3d7620190409022ba8d58a03 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819878 Reviewed-on: https://chromium-review.googlesource.com/1093354Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#565670}
-
Vasilii Sukhanov authored
The automatic password generation is still not launched. I checked that the Views prompt works all right on Mac. We are gonna invest time only into the Views UI. Let's make it simpler. Bug: 832676 Change-Id: Ic8bff3d267579df976072cfde762f73054747190 Reviewed-on: https://chromium-review.googlesource.com/1088607Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#565669}
-
Rune Lillesveen authored
- Base layout parent computed style on traversing the DOM instead of the layout tree. - Moved top layer check for ::backdrop to CanGeneratePseudoElement(). - Moved CanHaveGeneratedChildren() to layout tree building. This means we may generate pseudo elements which may not generate boxes for their pseudo elements, but the boxes will still not be created. First-letter is still relying on layout objects. Will address that later. Bug: 836126 Change-Id: I4f283a09db597bc44d1b32d1007b4aa65e83f2e0 Reviewed-on: https://chromium-review.googlesource.com/1092692Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#565668}
-
Ted Choc authored
The BookmarkModelObserverTask added a bookmark model observer on a background thread, which is not allowed. In both cases of Remove and Update, there is no need for listening to the observer as we can just track whether we are updating the bookmark node internally. This is consistent with how AddBookmarkTask already worked. BUG=838988 Change-Id: I43bf054b70e78907a99ba2a11fac62df0af6bc67 Reviewed-on: https://chromium-review.googlesource.com/1089497Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#565667}
-
Nico Weber authored
This ensures that the memory and clang tot bots run the same tests as the main waterfall bots. Everything running on the main waterfall must be tested with clang/tot too to make sure compiler updates don't break anything. This change makes it impossible for things to get out of sync (on linux). No behavior change, the chromium_linux_gtests and chromium_linux_clang_gtests were identical already. Also rename chromium_linux_clang_and_gl_gtests to chromium_linux_and_gl_gtests and add a comment for it. Bug: 843511 Change-Id: Idf95d837cdae5247d2011c85f2c19961d29bd195 Reviewed-on: https://chromium-review.googlesource.com/1093062Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#565666}
-
sczs authored
This fixes an issue where the section header was being duplicated on collapse/expand. Whenever we collapse and expand a section on iOS10, a sectionHeaderFooterView is added on top of the existing one. This causes the sectionHeaderViews to stack on top of each other leading to bad UI and test failure. More info on the bug link. BUG = 850814 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I743d4dff1c81d389f3313fda4d0c92a202fb4b5e Reviewed-on: https://chromium-review.googlesource.com/1092233 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565665}
-
stkhapugin@chromium.org authored
Fixes the tests broken by enabling the refresh location bar, introducing helpers as necessary. Bug: 834345, 821821 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ifb767a192c3f4d3f35bf4714768352a83d4a1d99 Reviewed-on: https://chromium-review.googlesource.com/1070147 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#565664}
-
Nico Weber authored
Bug: 850464 Change-Id: I06e41f5f1d06d4397182b57883543d8a9e0680bf Reviewed-on: https://chromium-review.googlesource.com/1093063Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#565663}
-
Xiaoqian Dai authored
The reason for this crash is when a window is destroying, it's still regarded as an "activatable" window in MRU window list and is then put in overview by SplitViewController::OnWindowDestroying(), which will then cause crash when trying to adjust its bounds in overview. (Currently the crash is only observed on Chrome built on linux workstation, not reproducable on real devices) To fix this, we observe OnWindowDestroyed() instead of OnWindowDestroying() in SplitViewController. Bug: 835925 Change-Id: Ieda91eb3f8ab12e2120365b0804a30aeef8d8f2f Reviewed-on: https://chromium-review.googlesource.com/1091534 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#565662}
-
Nektarios Paisios authored
R=dmazzoni@chromium.org Change-Id: I8598961fa8007bac98164dfe4ce96cf52e655a5e Reviewed-on: https://chromium-review.googlesource.com/1091148Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#565661}
-