- 03 Feb, 2020 40 commits
-
-
Luciano Pacheco authored
Implements layout/sizing, colors (background, font and borders) for rows in the file list. Hide image which was displayed when the folder is empty, as per discussion with our PM. Disable the animation for thumbnail, because during the transition to show the "check select" icon it was showing both check-select icon and the thumbnail, which is visually unpleasant/junky. Reset the font-size for the whole body to 13px as verbally agreed with our designer. Bug: 992821 Change-Id: I02870761dd7a844d6a07a70d2aee792df061acc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026533Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#737690}
-
Simon Zünd authored
The NodeURL web test got ported to Karma in https://crrev.com/c/2030776. This makes the web test obsolete and this CL removes it. R=tvanderlippe@chromium.org Bug: chromium:1032561 Change-Id: Ic9554075599a1ab56b3e50f4a8304dd35ea10148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033148Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#737689}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/49a53d684aff..fed0dda178e6 git log 49a53d684aff..fed0dda178e6 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 cclao@google.com Remove getIndexRange call from ValidateDrawRangeElements Created with: gclient setdep -r src/third_party/angle@fed0dda178e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I2dfcee9a884811435aba126e24374537e0da6e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035152Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737688}
-
Jinsuk Kim authored
This CL gives animation (alpha) effect to the 'Open in a New Tab' button on preview tab header when sliding up/down the panel. Bug: 1047889 Change-Id: I28504f8fd89d8cfe67d5523bdd5e2f186000cbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032458 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#737687}
-
Jason Lin authored
This CL imposes restrictions on the username in crostini installer to ensure the username conforms with linux convention and does not conflict with other default users. If the username is invalid, an error message will be shown and the install button will be disabled. The CL also adds new browser tests for this feature. Since the flag crostini-username is turned on for all installer browser tests now, existing browser tests are modified to click the "next" button to go into the configuration page before clicking the "install" button. Bug: 1016195 Test: browsertest; manual test with flag crostini-username flag on Change-Id: I546e0c56a3a41defb2de3e224992cebf5824dabc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032485 Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#737686}
-
Kenichi Ishibashi authored
This CL moves ScheduleDeleteAndStartOver() call from ServiceWorkerStorage::DidPurgeUncommittedResourceIds() to ServiceWorkerRegistry so that we can reduce ServiceWorkerContextCore dependency from ServiceWorkerStorage. As side-effects, this CL moves DoomUncommittedResource() and adds PurgeResources(set<resource_id>). Bug: 1039200 Change-Id: I711978412b2b4260055e11831d343e14b1288dcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032444Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737685}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/250c550f9220..64e691680849 Created with: gclient setdep -r src-internal@64e691680849 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I2e857005e762271f1dd4e1ad76954e670465e565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035089Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737684}
-
Rachel Sugrono authored
Enclose |cr-dialog-container| in a <dialog> (delete-confirm-dialog) to ensure that tab index always remains within the <cr-dialog>. Also stop keydown event propagation to stop them passing out of the <dialog> for the same reasons. Implement the functions |showModalElement| and |doneCallback| to show and close the <dialog>, respectively. Minor: Change parameter type from HTMLElement to Element on the FilesConfirmDialog interface. Bug: 803259 Change-Id: Iea2482c017804e873e0ab0f23b8d7bfe2ba3ca1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033012 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Patrick Monette authored
The WorkerTaskProvider's responsibility is now to track existing profiles and let the PerProfileWorkerTaskTracker track the running workers and create the tasks. This avoids keeping track of the ServiceWorkerContext that each service worker is associated with. Bug: 1041093 Change-Id: Ie0cd4c7f46c84c2f9a8c96d10afef8440abc63a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994178Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#737682}
-
Nico Weber authored
No behavior change. Bug: 1031169 Change-Id: I1e7f4afcd4fb779d0d0aab5de5a9f2827cb6766e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033365 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#737681}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f1e316ff39e7..9e8d8c4830c1 git log f1e316ff39e7..9e8d8c4830c1 --date=short --first-parent --format='%ad %ae %s' 2020-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e196bc85ac2d..49a53d684aff (18 commits) 2020-02-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 79b36b640692..41a7302e9c62 (3 commits) Created with: gclient setdep -r src/third_party/skia@9e8d8c4830c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: Ibbe87c717b01c4f827ed07283d69a703ac74b92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035085Reviewed-by:
-
Yuki Shiino authored
This is a reland of c1f6f104 The build failure of release branches (canary, etc.) should be fixed with https://crrev.com/c/2029405 . This is a reland of the original patch with no change. Original change's description: > bind-gen: Build generated IDL enumeration in prod > > Builds the bindings of IDL enumeration generated with the new > bindings generator in prod, despite that the bindings is not > yet used. This patch makes it available for real use. > > Bug: 839389 > Change-Id: Id5cafd53ab043f75c5244f8fb6a0e134c5ce861d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022124 > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#736356} Bug: 839389 Change-Id: I577dc9e7f2a488585f0c10785fd8fb216df33ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030351Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#737679}
-
Hirokazu Honda authored
This introduces VideoDecoder using libgav1 decoder. The VideoDecoder is neither enabled nor compiled by default. Adding enable_libgav1_video_decoder to gn args is needed to compile, and adding --enable-features=Gav1VideoDecoder to chrome option is needed to enable the VideoDecoder on chrome. The performance differences between Dav1dVideoDecoder and Gav1VideoDecoder on kevin are below. 1080p@30 | CPU usage(%) | Drop frame rate(%) Dav1d | 64.0 | 33.7 Gav1 | 60.4 | 39.0 720p@30 | CPU usage(%) | Drop frame rate(%) Dav1d | 40.52 | 0.0 Gav1 | 35.85 | 0.0 720p@60 | CPU usage(%) | Drop frame rate(%) Dav1d | 55.50 | 24.8 Gav1 | 43.7 | 48.45 Bug: 1026522 Test: Play av1 videos on kevin (ChromeOS ARM) and confirmed Libgav1VD was used. Change-Id: I24a83932936f775c364761c88b14c42a29537417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936445 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737678}
-
Takashi Toyoshima authored
The current logic has an exception not to throttle the kHigh priority requests even if the request is marked as kThrottleable. However, this exception makes the per-frame maximum limit useless, and make requests result in failure for hitting the network service resource limit. This patch enforces the normal limit even for the kHigh requests for both throttling policies. But still kHigh requests can escape from the tight throttling. Bug: 1046882 Change-Id: I4e167fdb667f9adc90604fa1d65fc4cd6e650c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028886Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#737677}
-
Rachel Sugrono authored
Bug: 803259 Change-Id: Icf222cbcc0712532a58809b2cd327ee20955ee74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033062Reviewed-by:
-
Jason Lin authored
A recent CL [1] added a second button with the class "action-button" to the crostini installer. The existing logic assumed there is only one "action-button" which, being no longer always true, sometimes results in the wrong button being focussed/clicked. This CL updates the logic to select the appropriate button, either next or install, depending on the current state of the installation ui. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2004185 Bug: 1016195 Change-Id: I94cbba0f7610d9f444ee539ddcc910959ee817c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024232Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Jason Lin <lxj@google.com> Auto-Submit: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#737675}
-
Keishi Hattori authored
TraceIfNeeded with a template T is already handled properly, but TraceIfNeeded with a resolved T, like TraceIfNeeded<Member<Node>> was not treated as a traced field. Bug: 1044898 Change-Id: I9f394290d7cc3ec8ad8d7b1c0489b7044b757513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032751Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737674}
-
Alan Cutter authored
This CL updates BrowserFrame::GetThemeProvider() to return a specialised ui::ThemeProvider for PWA windows. This ThemeProvider uses the page's theme color to determine the window's overall color scheme. This is used to set the color of the experimental PWA window tab strip UI hidden behind the DesktopPWAsTabStrip flag. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=429152&signed_aid=5d6jrXZ-uGdoduRqVJzTQg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=429151&signed_aid=SrR46BZ1Nyn2NtVEoJn2Sg==&inline=1 Bug: 1020050 Change-Id: I45bae7046d62c015dd517468d738d561ce10d742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003156 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#737673}
-
Noel Gordon authored
Some users of FilesConfirmDialog want to know when the dialog is done (closed or cancelled). Add an optional this.doneCallback for that. Some need a call prior to opening the FilesConfirmDialog, so they can open a modal HTML <dialog> parent of the FilesConfirmDialog to reveal it. Add an optional this.showModalElement for that. No change in behavior, no new tests. Bug: 803259 Change-Id: I36bdf382c3e97bf4c1eaae42c1bb35131271012c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034386Reviewed-by:
Austin Tankiang <austinct@chromium.org> Reviewed-by:
-
Kenichi Ishibashi authored
In production code, this is called only from ServiceWorkerRegistry now. ServiceWorkerResourceStorageTest used the method but we can replace it with a combination of CreateNewRegistration() and CreateNewVersion(). This replacement also removes NewRegistrationId() and NewVersionId() calls. This is a positive side effect as these calls are going to be async (see issue 1046335). Bug: 1039200, 1046335 Change-Id: Icef9951785b86b5321659ec4569da94ad593c2b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032456 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Anand K. Mistry authored
The extra level of indirection doesn't do anything. Bug: 939235 Change-Id: Iad72c21a3a61e3277b8a033d3bc3d3f899b1310b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032384 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#737670}
-
Joshua Bell authored
The external/wpt/IndexedDB/parallel-cursors-upgrade.html test exercises 10k cursors in parallel, which an implementation should support. The test was historically flaky, although it hasn't timed out on the bots lately. But it is still slow - requiring multiple seconds on many platforms, and 20-40 seconds on debug builds. Drop the maximum number of parallel cursors to stop being such a drain on the commons. Local tests: the time for --iterations=40 dropped from 23s to 5s. Bug: 869364 Change-Id: I5a0b9de3b37650917e40cc0c34e7473a3870b21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033814 Auto-Submit: Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#737669}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9c4f7c3fc916..250c550f9220 Created with: gclient setdep -r src-internal@250c550f9220 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib8ffa66e73e1d9c480b3d2a218704eb0b22c4e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035081Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7b296d06. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I87946b074f272535440b3f6327b8c3d60dbf1bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033728Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737667}
-
Hirokazu Honda authored
Bug: 1044452 Test: compile image_processor_test Change-Id: I474c94707f16ef44a495868a8ef8e380fbbb0a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024391 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#737666}
-
Anqing Zhao authored
Following methods are extracted to remove duplicated code. - ShowNotificationsIfNeeded - MaybeLaunchSettings Bug: 977489 Change-Id: I072d8bf31d2eddf808657f07b2eabc302072cece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033248 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737665}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ib30f6c346e840f1d2d8aee244fe482b2a1659f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034050Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737664}
-
Jay Harris authored
Note: There seems to be a problem with how origin trials interact with the content security policy in system web apps (the origin trial API is not visible to {Exec,Eval}Js), so the file handling tests were updated to use ExecuteScript instead of EvalJs. Bug: 1028448 Change-Id: I6444b309d19c4a2fbde7537c5587acdda9ec8d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016985Reviewed-by:Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ie4597e5bbaf5b4bb9042ae6bf091b6069a78e33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033727Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737662}
-
Hirokazu Honda authored
This add libgav1 [1] in chromium third_party. The plan is to use OBU parser for AV1 HW decoder in chromium. That said, the sw decoder is not used in chromium immediately after this CL. [1] https://chromium.googlesource.com/codecs/libgav1/ Bug: 1000988, b:142835450 Test: compile chrome Change-Id: I14e42ca0108f96f5931adb7bcad93a1df735f437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880887 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Hirokazu Honda authored
EncodedDataHelper should return scoped_refptr<DecoderBuffer> rather than std::string as this is the input format required by VideoDecoder::Decode(). Bug: 1044816 Test: video.DecodeAccel.* on eve Change-Id: Iac47f4e710954efa1dbb7f8d48cdd56bc0f9c963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032543 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Kent Tamura authored
Rename |internals| to |i| to avoid lint errors. This is a preparation to ship the feature. Bug: 1012098 Change-Id: I789f44c072b57f05e1ec8ddfbf0855872e144996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032632Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#737659}
-
Joe DeBlasio authored
This CL enables printing of a console message on all mixed content downloads. Previously, the message was only printed when the flag was enabled. Now that this plan is approved for launch, M-81 needs this message full time. Part of go/mixed-content-downloads Bug: 960819 Change-Id: I2fddee3c26c77a7a8eb4f680a0f16e13d5f9abdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033438 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#737658}
-
Anqing Zhao authored
Following methods are extracted to remove duplicated code. - InitializePrimaryProfileServices - NotifyUserProfileLoaded - StartTetherServiceIfPossible Bug: 977489 Change-Id: Iad19b0e23f3d9e11273468890a5d21a2168ff2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030959 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 47c98e94. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4f025fdfdc88911465e8d161c15c99594a899d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033726Reviewed-by:
-
jessing authored
Currently chrome:// URLs are not allowed to embed chrome-untrusted:// URLs because we never grant request access to chrome-untrusted:// URLs. To allow for this, this CL makes a couple of changes (Note that this is only fixes the issue on the browser side. The renderer still has some checks that stop us from loading chrome-untrusted:// iframes.): 1. Make the set of requestable schemes part of content::WebUI. This way clients of WebUI can control which additional schemes they want their WebUI to be able to request. The function to add a scheme is added as a webUI API because it is expected to be used by chrome/ WebUIControllers that use chrome-untrusted://. 2. When creating a WebUI in RenderFrameHostImpl::CreateWebUI(), grant request access to the schemes the WebUI specified. 3. Decouple granting access to chrome:// and file:// from ChildProcessSecurityPolicy::GrantWebUIBindings(). Instead add this to the list of schemes in content::WebUIImpl. Long term, we should be able to remove these schemes from content::WebUIImpl and instead have each client specify the schemes they want access to, similarly to how clients will call EnableMojoJsBindings()[1]. [1] https://cs.chromium.org/chromium/src/content/browser/process_internals/process_internals_ui.cc?l=53&rcl=0ab24b983b19f971f40b2f1e3f5a5b95c7a1ad9a Bug: 1043548 Change-Id: I71d31f86e7c21da253df4f32634d945b45d071cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009589 Commit-Queue: Jessica Huang <jessing@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737655}
-
Rachel Sugrono authored
The delete key or the alt+backspace key (which maps to delete) should delete the currently selected entry. Bug: 803259 Change-Id: Ia3943893d256150a2b1bff7a4f6c4a718039bdcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026555 Commit-Queue: Rachel Sugrono <rsugrono@google.com> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
David Black authored
Assistant UI modes kMainUi, kMiniUi, and kWebUi were used exclusively for standalone Assistant UI and can now be removed. Bug: b:148080975 Change-Id: Ia9592f208684e7f527463db30fda44eed0bcc95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033701 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#737653}
-
Kent Tamura authored
When UpdateFromElement() is called, textContent of the shadow element should be updated as well as the text in the anonymous block. Exceptions: * In DidStyleRecalc() and AttachLayoutTree(), we must not update DOM at all. * Instead, we should update the textContent - when the UA shadow tree is created, or - even if the SELECT has no LayoutObject This CL has no user-visible behavior changes because the shadow element has display:none. Bug: 1040828 Change-Id: I55f0bfd0399ca50a8aa99c64a8fdf89ef5c42e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032656Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#737652}
-
Anand K. Mistry authored
This allows TempFileManager to be removed from SmbService and simplifies setup. Bug: 939235 Change-Id: I5baed5d85318b67acc0d0c7e1e6600f2a039e582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030926 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
-
