- 19 Sep, 2018 40 commits
-
-
Asanka Herath authored
This reverts commit c9b5d530. Reason for revert: Compile failure: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20ChromeOS/56793 Original change's description: > Refresh access token only for auth error. > > Bug: b:114756954 > Test: Manual > Change-Id: I1d58906771ad789232d8c01f6de06ea44ad8e3f8 > Reviewed-on: https://chromium-review.googlesource.com/1226527 > Commit-Queue: Yilei Li <yileili@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592467} TBR=xiaohuic@chromium.org,dmblack@google.com,yileili@google.com Change-Id: I47b836b3b8d1d49e3dde93a8133d80c27a411a5a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:114756954 Reviewed-on: https://chromium-review.googlesource.com/1234895Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#592512}
-
David Tseng authored
Follow up to incomplete change https://chromium-review.googlesource.com/c/chromium/src/+/1228790 Change-Id: I552c0896ae903223f659eb647bf3b3bf5f75e3dc Reviewed-on: https://chromium-review.googlesource.com/1232954Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592511}
-
dpapad authored
In Polymer 2 the following syntax for registering event listeners is no longer supported. listeners: { 'id.eventName': 'onEventName_', }, Bug: 885294 Change-Id: I143aea45aab7ccb237f9034b04be5882ef7b8de0 Reviewed-on: https://chromium-review.googlesource.com/1231926Reviewed-by:Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592510}
-
liberato@chromium.org authored
This CL addresses a few issues with MCVD unittests: - Some tests were marked 'VP8' when they were supposed to be 'not VP8'. This changes them to H264. Not exactly the same thing, but better than it was. - Some tests were marked 'H264' since they didn't work for VPx for no clear reason. These have been fixed. - VP8 codec could leak, since the drain during destruction wasn't complete. It now completes the drain when needed. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id9dab9b93425581fa3f7892ef734fbd3e5c54eaf Reviewed-on: https://chromium-review.googlesource.com/1234360 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592509}
-
Mike Reed authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id97f574f12deffbfe28e943a7735823be1533db9 Reviewed-on: https://chromium-review.googlesource.com/1233941Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#592508}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c2d0fb17deef..8a0014403563 git log c2d0fb17deef..8a0014403563 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 halcanary@google.com test,tools: whitespace changes for clang-format 2018-09-19 mtklein@google.com update clang_linux to Clang 7 Created with: gclient setdep -r src/third_party/skia@8a0014403563 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I2cbc67728a544de1248e2434d1334fb5e09f7e03 Reviewed-on: https://chromium-review.googlesource.com/1234366Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592507}
-
David Tseng authored
TBR=dmazzoni@chromium.org Bug: 795840 Change-Id: I66868a0b735f660e5f0190e7bcc6e4c158393138 Reviewed-on: https://chromium-review.googlesource.com/1234317Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#592506}
-
Sergey Poromov authored
Finalizing LoginDisplayHost before AttemptUserExit caused double deletion of LoginDisplayHost and a crash that leaded to not remembering error KioskAppLaunchError in a pref. Bug: 879652 Test: Manual Change-Id: I291872af300d99940cb9199cbdf62b01918ffbdc Reviewed-on: https://chromium-review.googlesource.com/1234476Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#592505}
-
Mathieu Perreault authored
The feature was overriding values in |upload_request_.profiles|, which turns out was being reused for a subsequent request. We now use a temporary structure to send country-only addresses to Payments for GetUploadDetails call. This change also disables by default the SendOnlyCountryInGetUploadDetails and PaymentsCustomerData features. Bug: 878416 Test: components_unittests Change-Id: If78098e8b494cf4bba2e5049c368d87b2913a84d Reviewed-on: https://chromium-review.googlesource.com/1233815 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#592504}
-
Mikel Astiz authored
This speculates with the idea of the proxy dropping some events, e.g. OnSyncStopping(), and later successfully posting other ones, e.g. OnSyncStarting(). To make investigation easier, we also split a previously existing CHECK into separate ones per datatype, to narrow down which ones are affected. Bug: 885019 Change-Id: I1e569eb0868cff4b66d841420f37f15c71f70567 Reviewed-on: https://chromium-review.googlesource.com/1233707 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#592503}
-
Clark DuVall authored
This is a reland of 888677bc Unit tests were failing on Linux CFI bot, needed a couple extra lines to set up the test WebContents. Original change's description: > Switch UserScriptListener ResourceThrottle to NavigationThrottle > > ResourceThrottles do not work with network service enabled, a > NavigationThrottle will work both with NS enabled and disabled. > > Bug: 884006 > Change-Id: Ifea0e59bd67d70b593b46c2a2a2bd4be0e3f98f0 > Reviewed-on: https://chromium-review.googlesource.com/1227358 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592182} TBR=jam@chromium.org,rdevlin.cronin@chromium.org Bug: 884006 Change-Id: I146dced8038dff7dfed262748602a87dc1993af8 Reviewed-on: https://chromium-review.googlesource.com/1234353Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#592502}
-
Justin DeWitt authored
This patch: * Adds APIs to ExploreSitesService that can request either a site image or a category image (which is a composite of multiple site images) as an SkBitmap (which is the format required for Java Bitmaps). * Adds a task to fetch one or more images from the ExploreSitesStore, based on the site ID or category ID. * The task filters based on the existence of an entry in the site_blacklist table (which is not populated yet but will be as a result of user long-press. This DOES NOT implement conversion from byte vectors to SkBitmap (left as a TODO.) Bug: 867488 Change-Id: Id2e6a6abe2781b790f9ce3f597a9e747eddd4715 Reviewed-on: https://chromium-review.googlesource.com/1233176Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#592501}
-
Oystein Eftevaag authored
This fixes a data race where ~TraceWriter tries finalizing the same message as ~TraceEventDataSource, on a different sequence (TraceWriter is owned by TraceEventDataSource, but needs to be destructed on a different sequence due to ~TraceEventDataSource being called on thread shutdown and could be calling PostTask). BUG=886528 R=ssid@chromium.org Change-Id: I61b498b8b4bcf3b40e43e9db49711e593766df26 Reviewed-on: https://chromium-review.googlesource.com/1232414Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#592500}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c968ea0b6538..92ef0386b8b6 git log c968ea0b6538..92ef0386b8b6 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 dtu@chromium.org [pinpoint] Data migration basic error handling. 2018-09-19 dtu@chromium.org [pinpoint] Basic stats page. 2018-09-19 dtu@chromium.org [pinpoint] Update fields in Jobs table. 2018-09-19 cbruni@chromium.org results2.html debounce search 2018-09-19 simonhatch@chromium.org Dashboard - Fix alert and comparison_magnitude. 2018-09-19 simonhatch@chromium.org Dashboard - Replace last_alerted_revision with query 2018-09-19 slobodan@google.com Fixing frames in animations following response. 2018-09-19 pasko@chromium.org androidStartupMetric: remove the FCP 2018-09-18 dtu@chromium.org [pinpoint] Remove unused <job-chart-icon> import. 2018-09-18 achuith@chromium.org oobe: Catch WebSocketException instead. 2018-09-18 dtu@chromium.org [pinpoint] Remove list of differences and reformat arguments list. 2018-09-18 sadrul@chromium.org rendering: Remove some redundant mean_ metrics. 2018-09-18 sadrul@chromium.org rendering: Remove discrepancy metrics. 2018-09-18 chiniforooshan@chromium.org Telemetry: Fix SF events 2018-09-18 mattm@chromium.org netlog_viewer/README.md: Re-order with user-focused sections at top. Created with: gclient setdep -r src/third_party/catapult@92ef0386b8b6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:878390,chromium:868073,chromium:883079,chromium:883715,chromium:886621,chromium:879353,chromium:884950,chromium:884950,chromium:863926 TBR=sullivan@chromium.org Change-Id: I9fa8e95d9aad524c032b0bf637dfc07926ce7795 Reviewed-on: https://chromium-review.googlesource.com/1234576Reviewed-by:
-
Lucas Gadani authored
This CL adds a notification via WebContentsDelegate that notifies the embedder that a new portal WebContents was created. The chrome/ embedder then uses this notification in order to attach TabHelpers to the newly created WebContents. Bug: 865565 Change-Id: I3e39883a5869832e6e59be9db7ea9e88ab18cd64 Reviewed-on: https://chromium-review.googlesource.com/1197143Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592498}
-
Fady Samuel authored
BrowserPlugin is only on on Chrome desktop and and surface sync is always on on desktop. This CL deletes the old code path. Bug: 672962 Change-Id: If0394bd7b8eed4b04d23fede8e31aff1ee3417b4 Reviewed-on: https://chromium-review.googlesource.com/1234323Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592497}
-
Bence Béky authored
Bug: 886629 Change-Id: Ie0f096552bec89f57041caebcf248da76f3a468d Reviewed-on: https://chromium-review.googlesource.com/1233936 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#592496}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c3099d1c6942..174de19776de git log c3099d1c6942..174de19776de --date=short --no-merges --format='%ad %ae %s' 2018-09-19 thestig@chromium.org Encapsulate CPDF_ImageLoader. 2018-09-19 thestig@chromium.org Validate decoder pipelines. Created with: gclient setdep -r src/third_party/pdfium@174de19776de The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:880675 TBR=dsinclair@chromium.org Change-Id: I1af59ee6d0a3d3c21cce116d96083947b365ee31 Reviewed-on: https://chromium-review.googlesource.com/1234295Reviewed-by:
-
Stefan Teodorescu authored
The chrome://management page should only be available on desktop Chrome Bug: 879146 Change-Id: I6ea0d54f1993bbf4875c7479f008eebed5bc3a32 Reviewed-on: https://chromium-review.googlesource.com/1233553Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Stefan Teodorescu <fane@google.com> Cr-Commit-Position: refs/heads/master@{#592494}
-
Wenzhao Zang authored
The screensaver in demo mode should be full-screen and keep staying on top, otherwise user experience would be really bad. If these two things can't be achieved together, I think we should give up using Chrome App for screensaver. The demo mode screensaver app implements its own mechanism to close the window when there's user interaction. If some security issues arise, it'll be the demo mode team's responsibility to fix it. TBR=rdevlin.cronin@chromium.org Bug: 870851 Change-Id: I9773ec9dc99dd6b01c5202bcb5678cd0a59a544b Reviewed-on: https://chromium-review.googlesource.com/1214602 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#592493}
-
Doug Arnett authored
Bug: 864640 Change-Id: I28f5ac776473882973ab5faad2d4426a1f91b959 Reviewed-on: https://chromium-review.googlesource.com/1228974Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#592492}
-
Antonio Gomes authored
Follow up of [1], that introduces TestURLLoaderFactory::GetPendingRequest. [1] https://crrev.com/c/1234133 TBR=isherman@chromium.org BUG=844938 Change-Id: I59b19774462957fa71e09759f0154471f2a6c8f3 Reviewed-on: https://chromium-review.googlesource.com/1234634Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#592491}
-
Swapnil Raj authored
sync with its server counter part. The auto-fill crowd-sourcing server tries to predicts password length requirements for a form in the classifications pipeline. The server predicts password lengths only for forms which have lengths smaller than the default password length used by Chrome hence the password requirements classifier needs to keep track of the default length of the passwords generated by Chrome, which needs to be kept in sync with the constant on the client to avoid conflicts. Change-Id: I7d8ab63294010989d2996928aa10d25a0d383f7c Reviewed-on: https://chromium-review.googlesource.com/1230064 Commit-Queue: Swapnil Raj <swapnilraj@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592490}
-
Matthew Jones authored
This is a reland of 27d290e8 Original change's description: > Fix startup grey status bar on < M devices > > This patch moves the white status bar theme to a version specific > v23 directory to prevent L and below devices from using the flashing > between colors. Logic has also been added to ChromeActivity to prevent > these devices from using the grey (darkened version of white) color on > startup. > > Bug: 881239 > Change-Id: I41e5d959fab96623d254f4ff2dd0ea15cb6f9abc > Reviewed-on: https://chromium-review.googlesource.com/1228496 > Commit-Queue: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591857} Bug: 881239 Change-Id: I96efe736dd6080ba01de2e5c87dca20deac99bf7 Reviewed-on: https://chromium-review.googlesource.com/1230699Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#592489}
-
Michael Spang authored
Bug: 861853 Test: compile Change-Id: Ia9eacbe863736235c64ccbdadaf3f8feaffdd3ee Reviewed-on: https://chromium-review.googlesource.com/1234374Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592488}
-
Xi Cheng authored
This is a reland of 3d28a29b. In the original change, NotificationPlatformBridgeWinTest.Suppress and NotificationPlatformBridgeWinUITest.GetDisplayed failed in win-asan bot. This CL fixed it. The fix also required MockIToastNotification to derive from RuntimeClass, which significantly simplified its implementation. Original change's description: > Fix a few memory leaks in NotificationPlatformBridgeWin > > We should 1) wrap the bare pointers in ComPtr; and 2) attach > QueryInterfaces to ComPtr directly. > > Bug: 884224 > Change-Id: I91cb5c7312d8e24f59962ffb33faadaba36bd7ef > Reviewed-on: https://chromium-review.googlesource.com/1227493 > Commit-Queue: Xi Cheng <chengx@chromium.org> > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591737} Bug: 884224, 886957 Change-Id: If2674299437f04f637f6b2b8278b40a4dbf7b9d0 Reviewed-on: https://chromium-review.googlesource.com/1228991 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#592487}
-
Roman Sorokin authored
Now uses '$.' instead of '/deep/' to find elements BUG=chromium:875480 Change-Id: I1c7282cce123047987f436fd90018409545069f7 Reviewed-on: https://chromium-review.googlesource.com/1233839Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Jan Krcal authored
This is a speculative patch for a bug causing a crash in AutofillWalletSyncableService. This CL stops the generic change processor from talking to the syncable service when the service gets stopped. GenericChangeProcessor only talks to the service because it gets pinged by SyncBackendRegistrar. The registrar should not talk to the GenericChangeProcessor after a data type gets deactivated. Normally, a data type should get deactivated before it gets stopped. However, we see crashes in Canary that seem to contradict this expected behavior. Bug: 880029 Change-Id: I64b9ea1c3521a347983a530bc16c1f8e266769b6 Reviewed-on: https://chromium-review.googlesource.com/1230714 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592485}
-
Brian White authored
Check if the original ranges creation is causing the bad bucket values or if its some kind of corruption since the last time. Bug: 836238 Change-Id: I5b2b72504b6ac6437a9cec3ee42ae7e688be451b Reviewed-on: https://chromium-review.googlesource.com/1234215Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#592484}
-
Steven Bennetts authored
This CL: * Moves KeyboardConfig and the global instance and setter/getter to KeyboardController * Moves KeyboardControlEvent and LogKeyboardControlEvent to KeyboardController (which is the only consumer) * Moves KeyboardOverscrolOverride and SetKeyboardOverscrolOverride to KeyboardController * Removes keyboard::IsKeyboardVisible (only one non test call which already checks enabled() separately) * Moves InsertText to KeyboardController * Makes some changes to KeyboardController to improve alignment of header definitions and implementations. * Removes keyboard_util.h from keyboard_controller.h and removes unnecessary keyboard_util.h includes. For trivial code removal from component_loader.cc: TBR=benwells@chromium.org Bug: 843332 Change-Id: I5226380a80bba1286b36d5d68c5e30c74f4cd9ad Reviewed-on: https://chromium-review.googlesource.com/1225853 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#592483}
-
Xiaoqian Dai authored
This cL does 3 things: - Adjust the functions orders to match the header definitions - Rename AllowEnterExitTabletMode() to AllowUiModeChange() - Make CanEnterTabletMode() private More refactoring is still WIP. Bug: None Change-Id: Ie003023ee40a99907d1030f14f9e7d0c460b6709 Reviewed-on: https://chromium-review.googlesource.com/1234354Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#592482}
-
Antonio Gomes authored
Follow up of [1], that introduces TestURLLoaderFactory::GetPendingRequest. TBR=rogerm@chromium.org [1] https://crrev.com/c/1234133 BUG=844929 Change-Id: I055fb12f77ec3b1511595d7ad111a8cc2091242d Reviewed-on: https://chromium-review.googlesource.com/1234653Reviewed-by:
-
Adrienne Walker authored
These DCHECKs are sometimes being hit in practice, which says that they should not be DCHECKs. Because these are low priority mysteries, remove the DCHECKs and just add an early out to avoid performance cliffs. Bug: 778440, 740113 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I36d1af371127d4d29be608e1351d53a2b547b25c Reviewed-on: https://chromium-review.googlesource.com/1228981Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#592480}
-
Raphael Kubo da Costa authored
This restores part of --no-rebuild's behavior: we only build GN but do not run it afterwards when the option is specified. It's particularly useful when GN is built in a different machine or sysroot than the one where Chromium itself will be built (often with different dependencies installed on the system). Bug: 885139 Change-Id: If9f3386db8324b47b52864bccc685578fd40a689 Reviewed-on: https://chromium-review.googlesource.com/1233708Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#592479}
-
Xiyuan Xia authored
This allows content_browsertests run test_ws in process with single process mash and run it out of process for mash. Changes: - Make test_ws a packaged service in content_browsertests so that it could used in process for single process mash as well as out of process for mash; - Remove the code that launches standalone test_ws for mash; - Update TestWindowService so that it could be createe with content's ContextFactory/Private and CpuInterfaceProvider for single process mash and also works for mash; - Update WmTestHelper to support running in the same process of window service; Bug: 874089 Change-Id: Iece79fb9b96b48b8affb450cb44486c0b7ed00f0 Reviewed-on: https://chromium-review.googlesource.com/1228792Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592478}
-
Antonio Gomes authored
Follow up of [1], that introduces TestURLLoaderFactory::GetPendingRequest. TBR=droger@chromium.org [1] https://crrev.com/c/1234133 BUG=879774 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I234df7faf00625986e741a5bd3e1b52f34b7191e Reviewed-on: https://chromium-review.googlesource.com/1234554 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bbc63df5b82..2d4aa9279134 git log 1bbc63df5b82..2d4aa9279134 --date=short --no-merges --format='%ad %ae %s' 2018-09-19 primiano@google.com Merge "trace_processor: Make randomness deterministic" 2018-09-19 lalitm@google.com Merge "trace_processor: Parse systrace counter events" Created with: gclient setdep -r src/third_party/perfetto@2d4aa9279134 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idc7ad658ccaeebc56f17866a49b9c9e586dfddb3 Reviewed-on: https://chromium-review.googlesource.com/1234573Reviewed-by:
-
liberato@chromium.org authored
While MCVD requests bitstream conversion, AVDA still provided the CSD in the codec config. This CL makes MCVD do that also. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Id27e8833a8d266d5b401bf5c14003ca025bce7b4 Reviewed-on: https://chromium-review.googlesource.com/1228958 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
-
dpapad authored
Basically eliminating usage of /deep/ selectors. Bug: 875449,860069 Change-Id: I7e53055b712ee6701f240ba6f50c9eb1918d88b1 Reviewed-on: https://chromium-review.googlesource.com/1233113Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#592474}
-
Greg Thompson authored
To prevent users from accidentally restarting or dismissing the dialog if they happen to be typing when it appears. BUG=884831 R=bsep@chromium.org Change-Id: I91c31bd5b122632a3a2ceb13214aac266dfc6020 Reviewed-on: https://chromium-review.googlesource.com/1233576Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#592473}
-
