- 24 Sep, 2018 40 commits
-
-
Sam Maier authored
TBR=smaier@chromium.org (mechanical refactor) Bug: 825947 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng;master.tryserver.chromium.android:android_cronet_tester Change-Id: I378c64c40f3c7ce9522f3d8f534eaee88225880b Reviewed-on: https://chromium-review.googlesource.com/1231989 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#593565}
-
Nico Weber authored
Bug: 832676 Change-Id: I844589ee9726882c5a19b4d7e0ffd2543118d6a4 Reviewed-on: https://chromium-review.googlesource.com/1240167Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593564}
-
Nico Weber authored
Bug: 832676 Change-Id: If8b70eefc57a17b734c33a953b3c06a1a0dc2bd2 Reviewed-on: https://chromium-review.googlesource.com/1240165 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#593563}
-
Aaron Leventhal authored
NOTRY:true Bug: 887512 Change-Id: Ie4aab44d8eb186b9aff35036aa5317c6f79fc643 Reviewed-on: https://chromium-review.googlesource.com/1236714 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#593562}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/de54d7c5e325..a9adb6f03525 git log de54d7c5e325..a9adb6f03525 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 halcanary@google.com SkPDF: cleanup GraphicStackState Created with: gclient setdep -r src/third_party/skia@a9adb6f03525 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I17c88ede0c0c6d0b36c62759fa5b826231b41725 Reviewed-on: https://chromium-review.googlesource.com/1239116Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593561}
-
Jinho Bang authored
The hasError() method is already calling IsNull() internally. Also, the error field in mojom has a default value as empty string. Bug: none Change-Id: I98edd7c11a32379cc477b3f0520b3293b83a9009 Reviewed-on: https://chromium-review.googlesource.com/1239294Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#593560}
-
David Trainor authored
The CircularProgressView button was built using View#setForeground(), which is unavailable on early versions of Android. This patch addresses that by adding a helper class that can give a View setForeground-like support. This patch also adds an AutoAminatorDrawable, which will start and stop Drawable animations when the Drawable is visible or not. BUG=868554 Change-Id: I4a11921962aeac9dcee701f7e3584ba70ac96def Reviewed-on: https://chromium-review.googlesource.com/1231295Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#593559}
-
Andrew Grieve authored
Bug: 880671 Change-Id: I5ed6803daf97609fe2814618f51d8199f8c44390 Reviewed-on: https://chromium-review.googlesource.com/1240185 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#593558}
-
Kevin McNee authored
We update/remove comments that claim that double-tap to zoom is specific to Android. We also enable double-tap to zoom on Mac via WebPreferences rather than hardcoding it as always enabled. Bug: 802369 Change-Id: Ib78a0a85f295166bff3363ed65dceca9e5e3468e Reviewed-on: https://chromium-review.googlesource.com/1235129Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#593557}
-
Bo Liu authored
Setting opacity on a layer with children that draws leads to using a render pass, which is super expensive. Use the usual trick of setting opacity on the leaf layers directly instead. Change-Id: If394f0bba0953b9c6b951d2f320b358fe16c8acb Reviewed-on: https://chromium-review.googlesource.com/1238566Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593556}
-
Xi Cheng authored
Bug: 886957 Change-Id: I36adf26e497b0dee187ed151a09f16b966e277a8 Reviewed-on: https://chromium-review.googlesource.com/1240175Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#593555}
-
Sergei Istomin authored
This CL adds test cases to "cast_audio_backend_unittests" for checking external audio pipeline library. Tests check "StreamMixer" interaction with the library when library returns IsSupported() true. "Cast_audio_backend_unittests" unittest now is built with "fake_external_audio_pipeline" that has library implementation. For test reason the library supports additional functions (returns interface) that are used only from unittests. Additional functions are defined in "fake_external_audio_pipeline_support.h" "testing" namespace. There are the following test cases: - "SetMediaVolume"/"SetMediaMuted" for testing media volume/mute notification when the volume/mute is changed. - "SetVolumeChangeRequest"/"SetMuteChangeRequest" for testing a change request for volume/mute from the library. - "ExternalAudioPipelineLoopbackData" for testing loopback data. Bug: internal b/113337099 Depends-On: I755aaa94470dc8ba33a458d6139ef9254655d3e4 Change-Id: Ie8ebaf878e0d1c0d1f8485e645a2e05142745928 Reviewed-on: https://chromium-review.googlesource.com/1218045 Commit-Queue: Sergei Istomin <sistomin@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#593554}
-
Arthur Sonzogni authored
history.back() called twice causes the browser to navigate back twice. This is wrong. It should navigate back only once. This CL adds regression tests. The specification says the following: --- If there is an ongoing attempt to navigate specified browsing context that has not yet matured (i.e. it has not passed the point of making its Document the active document), then cancel that attempt to navigate the browsing context. --- Specification: https://html.spec.whatwg.org/multipage/history.html#traverse-the-history-by-a-delta Bug: 869710 Change-Id: I1534c7a04dbd220920970576baad02cedfaf6a12 Reviewed-on: https://chromium-review.googlesource.com/1215803 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593553}
-
Javier Fernandez authored
Since we integrated the baseline alignment logic in the grid tracks sizing algorithm, its impact on performance has grown considerably. The analysis of the new logic added and its overhead, due to different operations, shows that evaluating the item's participation in the baseline alignment context is the most expensive one. It's specially demanding the evaluation of the grid item's alignment properties. Considering that currently we are doing this for every grid item, this CL propose to reuse the loop we already have to clear the grid item's override size to cache the items with a baseline value in their alignment CSS properties. Thanks to this cache we can determine the item's participation in a baseline alignment context in the different phases of the track sizing algorithm, with almost no cost (compared to the current logic). It may be possible to share the cache with the algorithm run for computing the grid's intrinsic size; however, if the intrinsic size logic is run before the grid's layout, we'll end up duplicating the cache. Additionally, this cache is also used in the alignment phase of the grid layout logic; this change helps to avoid the various issues we have been suffering related to the different evaluations of the item's participation in baseline during the different phases of the grid layout algorithm. BUG = 873452 Change-Id: Ida27be11ae0f5c455e6077367a277981ab35cec1 Reviewed-on: https://chromium-review.googlesource.com/1179897 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#593552}
-
Michael Lippautz authored
Replace direct GC calls that expect objects to die with asyncGC calls that are guaranteed to run without stack. Bug: chromium:843903 Change-Id: Ie708567fae153d0f1a20109fe170025afdc1715b Reviewed-on: https://chromium-review.googlesource.com/1238451Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#593551}
-
Michael Lippautz authored
Update asyncGC function to the latest version to guarantee that GCs are indeed run without stack. Bug: chromium:843903 Change-Id: Iaa61f27cacd99854665358720d2354522b756302 Reviewed-on: https://chromium-review.googlesource.com/1238623Reviewed-by:
-
Dominic Battre authored
In the past 2 weeks I had one case where I, as a sheriff, tried to disable a test with a "DISABLE_" prefix (should be "DISABLED_") and one case, where I was TBRs on someone elses' typo. This presubmit script warns the committer in these cases (C++ only for now). Bug: 888425 Change-Id: Iff555a90db674ecd4df77819f1fa82270fbd715d Reviewed-on: https://chromium-review.googlesource.com/1240279 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593549}
-
Mohamed Amir Yosef authored
uss_migrator is responsible for migration (meta)data from the directory to the USS architecture upon first time switching to USS. USS assumes that all bookmarks have valid unique_position. This CL adds a DCHECK that this is actually the case. Directory is responsible for assigning valid unique positions for legacy bookmarks that are missing the field. Bug: 516866 Change-Id: Ib963016a56c4c9275649a1ff78f440d7fbe23023 Reviewed-on: https://chromium-review.googlesource.com/1240296 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#593548}
-
Jan Krcal authored
Bug: 853688 Change-Id: Idfd02f83693ad4861015d9edd3a9b23c7c6e174c Reviewed-on: https://chromium-review.googlesource.com/1238175Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593547}
-
Colin Blundell authored
OAuth2TokenService.java has methods that trigger the firing of various refresh token-related notifications by ProfileOAuth2TokenService [the C++ class]. These methods are not used (thanks to bsazonov@ for detecting that!), and their tests are problematic, as they cause the notifications to be fired without the accounts actually being available in PO2TS; this fact violates an invariant that we would like to put in place wherein PO2TS only fires refresh token available notifications for accounts for which it has a refresh token. This CL simply eliminates these unused methods and their tests. TBR=msarda@chromium.org Bug: 883722 Change-Id: Ib44be7db2fbe5341588a9e7ff786f5d166d1ae6c Reviewed-on: https://chromium-review.googlesource.com/1240275 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#593546}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0a3864651457..de54d7c5e325 git log 0a3864651457..de54d7c5e325 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 kjlubick@google.com Update autodetects for newer fuzzers Created with: gclient setdep -r src/third_party/skia@de54d7c5e325 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: I13a4eca0762d075f7f3dab5b8e4fa2958889e39a Reviewed-on: https://chromium-review.googlesource.com/1239489Reviewed-by:
-
Yao Xiao authored
1. Currently there is a bug: when subframe navigation is blocked, the console message is like: |<URL> on this site ...|; while the expected message should be |Chrome blocked resource <URL> on this site ...|. The reason is that in the code the prefix is put in the constructor of ostringstream but that call doesn't advance the write pointer. There was a test for it but the test also did it in the wrong way. 2. Fixed another potential issue: Test SubresourceFilterBrowserTest.SubFrameActivation is referring to kDisallowSubframeConsoleMessagePrefix/Suffix but the generated string actually comes from GetErrorStringForDisallowedLoad() in blink/renderer/core/loader/subresource_filter.cc. Right now the two strings are the same thus the test is passing now, but this should be fixed. Bug: N/A Change-Id: I28548d809ecaae019321bf97551d2493f2af7703 Reviewed-on: https://chromium-review.googlesource.com/1237173Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#593544}
-
Nico Weber authored
Bug: 832676 Change-Id: I38359d01373d4bd237c6a0f7fe5ffc051a3318c5 Reviewed-on: https://chromium-review.googlesource.com/1240164Reviewed-by:
-
Finnur Thorarinsson authored
When they were disabled for flakiness, an open bug was linked. This bug has long since been fixed, so I have reason to believe that they will run. And if not, this will give me data to sort through to figure out why they were flaky. Change-Id: Ib5735788d3d4d32772017d3c3161c9ecc5793c75 Reviewed-on: https://chromium-review.googlesource.com/1238558Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#593542}
-
Armando Miraglia authored
Considering that audio paramters are passed but not used by the AudioCaptureSettings, it is better remove them for now. Later, we will change the implementation so that AudioCaptureSettings directly stores the parameters that are not related to audio processing. BUG=731170 TESTED=ran content_unittests & ran the browser + called getUserMedia. Change-Id: I530d1dbe50e9d2438df189d28c9f4ade42dd271d Reviewed-on: https://chromium-review.googlesource.com/1238723Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#593541}
-
Philip Rogers authored
This reverts commit 45013dfc. Reason for revert: Performance regressions on touch_handler_scrolling.html This patch turned up a few performance regressions, primarily: tough_scheduling_cases/touch_handler_scrolling.html (see: https://crbug.com/888269). Other performance regressions: https://chromeperf.appspot.com/group_report?rev=593255 Original change's description: > Promote PaintTouchActionRects to stable > > This change enables PaintTouchActionRects by default. This is a > new implementation of how the blink->cc logic works for the css > touch-action feature. The big idea behind PaintTouchActionRects is to > compute touch-action rects during paint, in paint order, as part of the > background paint phase. > > With this change we expect better performance (primarily a drop in > ScrollingCoordinator time: Blink.ScrollingCoordinator.UpdateTime) as > well as observable bug fixes (e.g., https://crbug.com/826746). > > Bug: 836905, 881894 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I47a26250bad4c9e208b4f9b11e8eea3cf4d182aa > Reviewed-on: https://chromium-review.googlesource.com/1233114 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593255} TBR=pdr@chromium.org,xidachen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836905, 881894 Change-Id: I775e60074f4d5bca5a907a1da104f5441212769a Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1240184 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593540}
-
Nico Weber authored
Removes ContentSettingDecoration, KeywordHintDecoration, SaveCreditCardDecoration, StarDecoration, TranslateDecoration. Also removes c/b/ui/cocoa/translate/. Bug: 832676 Change-Id: I82f5873091502c847e77efb2671d8cc5583f8ba4 Reviewed-on: https://chromium-review.googlesource.com/1240161Reviewed-by:
-
Peter E Conn authored
I'm adding myself as OWNER of the recently created dependency_injection folder and to the top level OWNERS files for all Java tests. Change-Id: I40d83db663d4d33bc19d9d9aae557c8eb7be0259 Reviewed-on: https://chromium-review.googlesource.com/1238455Reviewed-by:
-
Joanmarie Diggs authored
The whitespace characters surrounding the text to be displayed for a label element should not be treated as part of the accessible name of the element being labeled. Stripping out this whitespace makes us consistent with what other user agents do. Bug: 887624 Change-Id: I1ff691ee7d970435b2b912a2d2b565089b1fc7a3 Reviewed-on: https://chromium-review.googlesource.com/1238774Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593537}
-
David Bokan authored
This reverts commit 432553b5. Reason for revert: width == height isn't enough since the system bar affects only height. Broke 887064, 887330, 887899 Original change's description: > Improve rotation check on viewport resize > > Since rotation used to be supported only on Android, where windows can't > be resized, we made the assumption that if the width changes it must be > a rotation. > > This changes in ChromeOS where entering tablet mode enables rotation but > also resizes the window (when entering tablet mode). This caused > inappropriate rotation anchoring. > > The underlying issue has been fixed in other patches linked to this bug, > the rotation trigger should be improved to check that the width and > height are swapped. > > Bug: 831473 > Change-Id: I0acd39d16319d8cb7819faac4c4ce54b6f7a2e46 > Reviewed-on: https://chromium-review.googlesource.com/1224711 > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591430} TBR=bokan@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 831473,887899,887064,887330 Change-Id: Ib0f3cad366a80506effc62fcc352e1c75f2fcd55 Reviewed-on: https://chromium-review.googlesource.com/1239726 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26fc9ad8..2c8e12da Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I01511d4d2439dcb48968cd0808e1d4bf6bb39e08 Reviewed-on: https://chromium-review.googlesource.com/1240183Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593535}
-
Pavol Marko authored
Make CertLoader explicitly aware of authority certificates provided by device and user policy. Rationale: Since the refactoring in https://crbug.com/787602, policy-provided certificates are not imported into the user's NSS Database anymore. As a bonus, this also makes device policy proivded CA certificates available to CertLoader (and thus the chromeos network UI). To do this in a clean way, (*) The PolicyCertificateProvider interface has been moved from chrome/browser/chromeos/policy/ to chromeos/ so it is accessible from chromeos/cert_loader.{h,cc}. (*) Implementation of the PolicyCertificateProvider has been pushed from UserNetworkConfigurationUpdater into the base class NetworkConfigurationUpdater, so DeviceNetworkConfigurationUpdater also implements the interface now. (*) CertLoader can now accept a PolicyCertificateProvider for device and user policy. (*) The chromeos-specific code in chrome/browser/chromeos now passes the global DeviceNetworkConfigurationUpdater and the primary profile's UserNetworkConfigurationUpdater to CertLoader. browser_test --gtest_filter=PolicyProvidedTrustAnchorsRegularUserTest.AuthorityAvailableThroughCertLoader Bug: 882641, 787602 Test: chromeos_unittests --gtest_filter=*CertLoader* && Change-Id: Iafb213150f3c9dbfdfe1ecd1a1f9d2a0099a30f2 Reviewed-on: https://chromium-review.googlesource.com/1231937 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#593534}
-
Aaron Leventhal authored
Also add tests for caret events. Bug: 877487 Change-Id: Ib9ac49e60c218169e8108ef83b000fcaaf176570 Reviewed-on: https://chromium-review.googlesource.com/1189184 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Peng Huang authored
Bug: 811661 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4bdcc4edf654c8c46c5015a1b4e6bc42ca79c381 Reviewed-on: https://chromium-review.googlesource.com/1239220Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#593532}
-
Daniel Vogelheim authored
The functionality is behind a flag. The interstitial content is preliminary and will be replaced in a subsequent CL with something more suitable for the public. Bug: 751996 Change-Id: I0a7cf6fec4a9ceaea10adac6ed2fcd1c7ccac799 Reviewed-on: https://chromium-review.googlesource.com/1204170Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#593531}
-
Dan Elphick authored
Replace use of deprecated Value::ToString(Isolate*) with Value::ToString(Local<Context>) in third_party/blink/renderer/bindings/core/v8. Bug: v8:7279, v8:8015 Change-Id: Ia5959d15bd649f00ba5cc45829acabc3bea53e20 Reviewed-on: https://chromium-review.googlesource.com/1238449Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#593530}
-
Mikel Astiz authored
The initial value of ModelTypeController::delegate_ is never read because the delegate is only used once the controller starts running. However, let's make sure it's initially null to detect CHECK failures if there is a violation of the API. Bug: 885019 Change-Id: I4a5623986b2bbd6c96a02f218438367d8e78a7fc Reviewed-on: https://chromium-review.googlesource.com/1238729 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#593529}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/868fbbf41b33..f19e5d119588 git log 868fbbf41b33..f19e5d119588 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 perezju@chromium.org [pinpoint_cli] Add api.Job() method 2018-09-24 perezju@chromium.org [pinpoint_cli] Add verbose -v command line option Created with: gclient setdep -r src/third_party/catapult@f19e5d119588 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526,chromium:879526 TBR=sullivan@chromium.org Change-Id: Ieb1ed481849dba4ce999ba89dadb4d1bbc095367 Reviewed-on: https://chromium-review.googlesource.com/1239488Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c955a1645148..0a3864651457 git log c955a1645148..0a3864651457 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 77db6f4af19f..f668a4b5fb72 (1 commits) Created with: gclient setdep -r src/third_party/skia@0a3864651457 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@chromium.org Change-Id: I4e7c03255c13ad97eb099c5c91d176effa9702f1 Reviewed-on: https://chromium-review.googlesource.com/1239487Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f4a7342c6fc4..e2ea26c8b521 git log f4a7342c6fc4..e2ea26c8b521 --date=short --no-merges --format='%ad %ae %s' 2018-09-24 primiano@google.com Merge "Chrome trace events: bind_id can be 64bit" Created with: gclient setdep -r src/third_party/perfetto@e2ea26c8b521 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I66e8651496ba1c466ffdad6e988441dd90f2d80c Reviewed-on: https://chromium-review.googlesource.com/1239485Reviewed-by:
-
