GitLab

Bug: 790520
Change-Id: I86c5a81b8b5872a2397621cb631a9b820eb28d8d
Reviewed-on: https://chromium-review.googlesource.com/1056228
Commit-Queue: Zhiling Huang <hzl@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558623}

This reverts commit 640eb0c2.

Reason for revert: Broke the build.

https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5678

Original change's description:
> media: implement TakePhoto in Chrome OS camera HAL VideoCaptureDevice
> 
> This CL implements the TakePhoto() API for the Chrome OS camera HAL
> VideoCaptureDevice, including the following features:
> 
>   - Full size still capture
>   - Auto-focus, auto-exposure, and auto-white-balancing stabilization
> 
> BUG=chromium:832772
> TEST=Run capture_unittests on DUT
> TEST=Make sure TakePhoto() API works on
> https://googlechrome.github.io/samples/image-capture/grab-frame-take-photo.html
> 
> Change-Id: I99e44087006cac28eac7e73c6764f522dac57cfa
> Reviewed-on: https://chromium-review.googlesource.com/1018641
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>
> Commit-Queue: Ricky Liang <jcliang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#558603}

TBR=jcliang@chromium.org,wuchengli@chromium.org,emircan@chromium.org,shenghao@google.com,hywu@chromium.org,chfremer@chromium.org

Change-Id: Ibc2b4547f33d4a505b546079dd118e1d4401a9cf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:832772
Reviewed-on: https://chromium-review.googlesource.com/1058568Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558622}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Ifc78d42372052bb8b6261021d2d39bf9588c1a4a
Reviewed-on: https://chromium-review.googlesource.com/1058846Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558621}

This CL creates a new cr-radio-button element with the MD-refresh spec.
This CL also replaces all paper-radio-button within Settings with
cr-radio-button.

Most of the cr-radio-button's functionalities and styles are encapsulated
in separate files in a shared location, so that the controlled-radio-button
element in settings can reuse them.

There will be a follow-up CL to then replace all of paper-radio-button's
usage outside of Settings.

Bug: 840527
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4fc47fa0b8186b5d6ef0a3b678cc68bbc58a8e3d
Reviewed-on: https://chromium-review.googlesource.com/1053299
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558620}

Broadcast is currently implemented as a cast URL with a special
broadcast query parameter. When this URL is received, it is treated as
a request to broadcast a message to all cast devices instead of a
regular sink query.

Bug: 698940
Change-Id: I25cfa6f84c2957f4fb63ec75b7a30007bfe47850
Reviewed-on: https://chromium-review.googlesource.com/944902Reviewed-by: Brandon Tolsch <btolsch@chromium.org>
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558619}

https://chromium.googlesource.com/angle/angle.git/+log/5730c0bf431e..a00ef3144f70

$ git log 5730c0bf4..a00ef3144 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 geofflang Add more dEQP EGL expectations for Linux and Android.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I0387e6d674f7447b2cc164df32ab60cb1ca50f8e
Reviewed-on: https://chromium-review.googlesource.com/1058678Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558618}

When the network service is disabled, we are using the same request ID
for the preflight request and the actual request as we cannot assign
separate IDs. We need to tear down the preflight request first, and
then make the actual request: Otherwise we will see a renderer crash
caused by RDH_INVALID_REQUEST_ID.

Currently we cancel the request by resetting the SimpleURLLoader for
the preflight request: That is not enough because destroying a
SimpleURLLoader asynchronously cancels a request, and we don't know
when it's actually destroyed. This is especially problematic when
a server returns a preflight with a long body.

This CL fixes the problem by adding a function which cancels the
request synchronously. This is a workaround, and we won't need the
logic in the end.


Bug: 838136, 614281, 842593
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ic9d20cfbecc7c5b8749e0dc664d12c6d07e8c673
Reviewed-on: https://chromium-review.googlesource.com/1056941
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558617}

TBR: 
Change-Id: I1b488783f04a3bcc20b82feddb079e3f0519d2cb
Reviewed-on: https://chromium-review.googlesource.com/1058931Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558616}

This patch adds a new attribute to the InputContext object in the IME
API called 'shouldDoLearning'. Textfields in incognito tabs will return
false for shouldDoLearning so that the IME can keep incognito and
non-incognito profiles separate.

To implement this, we add a new TextInputClient::ShouldDoLearning()
method that is implemented by various types of text fields. The most
interesting case is views::Textfield, which doesn't have any notion
of incognito, so it should be up to owner of the textfield to decide
if it's incognito or not. However, there are ~90 places where we
construct a views::Textfield, so to prevent this CL getting too large,
we default to 'false' for ShouldDoLearning and then we'll add support
for learning on all the different textfields as needed.

Bug: 311180
Change-Id: Id33b11505a2eb3154fed8c4747c05205c7bf7c77
Reviewed-on: https://chromium-review.googlesource.com/1049405Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558615}

This patch implements painting selection line break.
Design doc: https://goo.gl/ovMr8x

This patch changes LayoutSelection::SelectionStartEndForNG(
text_fragment) to return LayoutSelectionStatus which has
selection |start|,|end| and new boolean member |has_line_break|,
which means we need expand selection rect of the fragment to
paint line break.

The caller NGTextFragmentPainter paints line break selection by
extending existing selection rect when selection wraps line.

This patch fixes 4 selection painting test.

Bug: 708452
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Idef2d7135a5d7f27a217365cc3e8d55b191fa60b
Reviewed-on: https://chromium-review.googlesource.com/896780Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558614}

Fix some lint errors as well.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3dc89035a5bf2cd6b092512d0aa6eb2022704792
Reviewed-on: https://chromium-review.googlesource.com/1039150Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558613}

When computing caret rect for a caret position before/after an atomic inline
box, whether the caret rect is to the left or right of the box depends on the
resolved direction of the atomic inline, not the CSS 'direction' property.

This patch changes the implementation to check the resolved direction.

Bug: 822575
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ibc09e6679faf94ad7882bfba7560d44fd36fd7d8
Reviewed-on: https://chromium-review.googlesource.com/1056395Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558612}

bindings: Qualify #includes in generated V8GeneratedCoreBindings.cpp, initPartialInterfacesInModules.cpp, and V8ContextSnapshotExternalReferences.cpp.

Bug: 830255
Change-Id: I8c833ac805de7e378e5983f204022f7fdc72794e
Reviewed-on: https://chromium-review.googlesource.com/1058870Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558611}

Certificate Transparency is now required by policy for all new
certificates issued after April 2018 - that is, on or after
2018-05-01 00:00:00 UTC, as measured by the certificate's notBefore.

In order to ensure compliance to this policy, actually enforce it
in code.

This restructures the CTPolicyManager, which originally was a
pimpl'd bridge between the UI and IO threads, into the
ChromeRequireCTDelegate, now that it's solely single threaded and
has a defined interaction. To maintain existing behaviour, one can
enable CT policies without enforcing the April 2018 requirement, or
can enable new cert enforcement as well.

BUG=838680

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I939bc2ee6fde58f877a669278c92678153f61fdc
Reviewed-on: https://chromium-review.googlesource.com/1054947
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Eran Messeri <eranm@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558610}

Adding http_rtt_observation in ReadCachedNetworkQualityEstimate
causes notifying observers.
That can lead to calling ReadCachedNetworkQualityEstimate again.
So some observations can be added between adding
http_rtt_observation and adding transport_rtt_observation.
That ends up to breaking observations timestamp increasing.
To fix this we can use new timestamp each time when add
observation.
Same logic is used in AddDefaultEstimates for example.

R=ryansturm@chromium.org, tbansal@chromium.org

Bug: 841681
Change-Id: Ibed7d5e8e3efca82915d37b1de58df50ae43ff58
Reviewed-on: https://chromium-review.googlesource.com/1052690Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558609}

Remove old platform-specific desktop Java test filters for failusres
that no longer repro.

TBR=kereliuk@chromium.org

Change-Id: Ic0ccb93f6bd03bc200b54452f1fb11d8c5c5d057
Reviewed-on: https://chromium-review.googlesource.com/1058842Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558608}

This is a preparation of launching incremental shadow dom.

After I confirm that this doesn't cause any regression in bots,
I'll ship this, announcing it to blink-dev briefly, in a few days.

Bug: 776656
Change-Id: I2632a42c2cb9acaf6462600ac236dc9b8bff32ed
Reviewed-on: https://chromium-review.googlesource.com/1056896
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558607}

Using wpt-import in Chromium a7f5d9df.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17632

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
bjonesbe@adobe.com:
  external/wpt/css/css-shapes
cvazac@akamai.com, igrigorik@chromium.org:
  external/wpt/server-timing
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
ericwilligers@chromium.org:
  external/wpt/css/motion
rego@igalia.com:
  external/wpt/css/css-ui

TBR=markdittmer

No-Export: true
Change-Id: I5372fbfdd3124f604886ac35afdb802249991239
Reviewed-on: https://chromium-review.googlesource.com/1058907
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558606}

- Interface change has happend at https://crrev.com/c/844052 around the
  end of February. It should be fine to remove backward compat code now.

Bug: 768439
Test: unit_tests:ArcAccessibilityHelperBridgeTest
Change-Id: Ibac321f3889d605393928839b5292e64d27b0094
Reviewed-on: https://chromium-review.googlesource.com/1039405Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558605}

SignedExchangeHandler parses the content-type header to determine the
version of signed exchange (currently it accepts only version b0), and
passes the version enum to other classes that need versioned code.

Bug: 803774
Change-Id: I90fe2c94d4a5dec61000650338ff4cd0461d2c7d
Reviewed-on: https://chromium-review.googlesource.com/1056940Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558604}

This CL implements the TakePhoto() API for the Chrome OS camera HAL
VideoCaptureDevice, including the following features:

  - Full size still capture
  - Auto-focus, auto-exposure, and auto-white-balancing stabilization

BUG=chromium:832772
TEST=Run capture_unittests on DUT
TEST=Make sure TakePhoto() API works on
https://googlechrome.github.io/samples/image-capture/grab-frame-take-photo.html

Change-Id: I99e44087006cac28eac7e73c6764f522dac57cfa
Reviewed-on: https://chromium-review.googlesource.com/1018641Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558603}

Bug: 832374
Change-Id: I13d52c97809ec4da1e2f2987d0b76c9d9be91810
Reviewed-on: https://chromium-review.googlesource.com/1058507Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558602}

R=zmo

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I44688d6daa071b9ab61d5aa79b0e3a75fd726f27
Reviewed-on: https://chromium-review.googlesource.com/1058434Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558601}

https://chromium.googlesource.com/catapult.git/+log/dd13313c34d3..075ca3000abf

$ git log dd13313c3..075ca3000 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 kendaljharland Support fuchsia project revisions in tooltips.
2018-05-14 szager Rename browser_simpleperf_controller to browser_interval_profiling_controller.

Created with:
  roll-dep src/third_party/catapult
BUG=chromium:839645


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: If1d98d42fab9b95555eb658fcda29abf3740a075
Reviewed-on: https://chromium-review.googlesource.com/1058683
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558600}

This CL rounds the corners of Rich images with a roundRect clip path.

Bug: 842399
Change-Id: I057d9cabcc46a71efc64145e6b90041e6d1067be
Reviewed-on: https://chromium-review.googlesource.com/1056397Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558599}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I4cd350ef9028fe015c5509ae579248f01ab67d8a
Reviewed-on: https://chromium-review.googlesource.com/1058689Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558598}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/d527ddce..493cfb68

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ib60a019cbc2ed0942d7d9805b9e08c70aca0876e
Reviewed-on: https://chromium-review.googlesource.com/1058627Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558597}

Some of these will need to live in the side-by-side console until the
related tryservers (win7_chromium_rel_ng and android_n5x_swarming_rel)
are migrated.

Remove a couple of fully-migrated LUCI bots from the chromium.gpu
console.

Bug: 815092
Change-Id: I710cdfc33c23bc2badda3bb4f49dfc76d0bce266
Reviewed-on: https://chromium-review.googlesource.com/1058684Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558596}

https://skia.googlesource.com/skia.git/+log/ab7181daad5d..6bbd386a0e4b

$ git log ab7181daa..6bbd386a0 --date=short --no-merges --format='%ad %ae %s'
2018-05-14 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ 2a0def7f6..e475674ef (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: Ia45d4d49ab95df7ae278a5e9baf55ca2002927ef
Reviewed-on: https://chromium-review.googlesource.com/1058717
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558595}

For ergonomic purpose, UserTimingL3 supports returning the measure/mark
entry they created. It's also useful for feature detection of L3 API
as well.

Bug: 842770
Change-Id: I4dfa1abb87d6f5750be7f9a23123530a1bf45e74
Reviewed-on: https://chromium-review.googlesource.com/1057995Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558594}

There are a couple of services that have hard coded names in English.
Localize them.

Change-Id: Ice25e5d5a70304e0954757c619738dbd9264d1eb
Reviewed-on: https://chromium-review.googlesource.com/1054991
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558593}

This is a re-land of crrev.com/c/1055676, with additional changes to
extension_messages_apitest.cc so that tests pass when both Token Binding
and Channel ID are disabled. (Token Binding is enabled in testing
configurations, but both are disabled in official builds.)

Change-Id: If519b6bbbf1aea111f411c2faf1f2f2678a328e8
Reviewed-on: https://chromium-review.googlesource.com/1058428
Commit-Queue: Nick Harper <nharper@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558592}

BUG=chromium:841824
R=skau@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I35fb1f1366449ac68639d30ce04aeb2105c498cc
Reviewed-on: https://chromium-review.googlesource.com/1054692
Commit-Queue: David Valleau <valleau@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558591}

Bug: 832173
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id3e2fc972d95d213b3ee8ffa8517cdf0edead69c
Reviewed-on: https://chromium-review.googlesource.com/1058588Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558590}

This class has been replaced by MTPManagerClientChromeOS introduced
by MTP mojofication process.

BUG=769630

Change-Id: I27a83181ebbb464ab37308d85fec10832edf06fa
Reviewed-on: https://chromium-review.googlesource.com/1046377Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Donna Wu <donna.wu@intel.com>
Cr-Commit-Position: refs/heads/master@{#558589}

When/where appropriate, the following conversions are made:
- Range-based for loops when iterating
- constexpr base::StringPiece for string constants
- base::span<> for array types
- base::size() as last resort

Bug: 837308
Change-Id: I7cb5ef94220049cfad935e9719657402461ff53d
Reviewed-on: https://chromium-review.googlesource.com/1056111
Commit-Queue: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558588}

This patch reverts [1] because we have a more general solution in [2].
In addition, through manual code inspection, we found [1] has a bug for
OOPIF because mapping to nullptr goes through remote frames whereas we
only intend to map to the local root. The test from [1] has not been
reverted.

[1] https://chromium.googlesource.com/chromium/src/+/cfebac612b10fdf961dca9df2bb28581577a612a
[2] https://chromium.googlesource.com/chromium/src/+/edc066c316b24fb3dea226ae6c1c5c1fdee062c3

Bug: 838111
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I0810c0eacb492ac413d31c041e97fce6ad23932b
Reviewed-on: https://chromium-review.googlesource.com/1058673Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558587}

It was named URLLoaderFactoryImpl which is confusing because there is
already a content::URLLoaderFactoryImpl. Also it is an impl of
(blink::)WebURLLoaderFactory not (network::mojom::)URLLoaderFactory.
Give it a generic name Factory to make more apparent it's an unexposed
inner class.

Also remove unnecessary "content::" when we're already in content::.

Change-Id: I0d0f69cdb21e144ec9606ee5a8f301f7d806a657
Reviewed-on: https://chromium-review.googlesource.com/1031753
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558586}

This class represents an ongoing attempt to connect to a given device
over a given medium. Each ConnectionAttempt is comprised of one or
more PendingConnectionRequests, and the attempt stays active for as long
as at least one of the requests is active.

While a ConnectionAttempt is active, it starts one or more operations to
connect to the device. If an operation succeeds in connecting, the
ConnectionAttempt notifies its delegate of success.

If an operation fails to connect, it alerts each of its
PendingConnectionRequests of the failure to connect. Each request can
decide to give up connecting due to the client canceling the request or
due to handling too many failures of individual operations. A
ConnectionAttempt alerts its delegate of a failure if all of its
associated PendingConnectionRequests have given up trying to connect.

When an operation fails but there still exist active requests,
ConnectionAttempt simply starts up a new operation and retries the
connection.

Bug: 824568, 752273
Change-Id: Ied90c93a33ffcbed1ac92e55265bf83240af2201
Reviewed-on: https://chromium-review.googlesource.com/1054969
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558585}

Instead of converting base::TimeTicks into double, and then converting
it back to a base::TimeTicks, just send the base::TimeTicks directly to
the paint-time reporting callbacks.

BUG=811961

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia10d897acafcf382406ba5e48f2cf46f7669c20a
Reviewed-on: https://chromium-review.googlesource.com/1056469Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558584}