- 26 Sep, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1b71de973c63..44b480c37a8b Created with: gclient setdep -r src-internal@44b480c37a8b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I2a4e7949f03f5ee49cd4f751b6978d506cfb314e Reviewed-on: https://chromium-review.googlesource.com/1247083Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594526}
-
Jonathan Metzman authored
Bug: 888363 Change-Id: Idfb7c644fa3294ad11327609b4b39eacfd3f5dd2 Reviewed-on: https://chromium-review.googlesource.com/1238917Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594525}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/620aaef23380..59d6ace5cb99 git log 620aaef23380..59d6ace5cb99 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 primiano@google.com fuzzers: re-introduce conditional around fuzzers 2018-09-26 primiano@google.com Merge "Roll clang and switch to fsanitize=fuzzer-no-link" Created with: gclient setdep -r src/third_party/perfetto@59d6ace5cb99 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If7ee8be219fc5abb9b55c9af8991118a692afb97 Reviewed-on: https://chromium-review.googlesource.com/1246839Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594524}
-
Tatiana Buldina authored
By default ChromeDriver creates new log file, option '--append-log' allows to append log file. Bug: chromedriver:586 Change-Id: Ibcbcad66a3afbf5bff0fbbf2046a1fc694395290 Reviewed-on: https://chromium-review.googlesource.com/1247027Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#594523}
-
Renjie authored
In QuicStreamFactory::Job, chances are host resolution won't return synchronously. While waiting for the host resolution callback, the stale host resolver will be queried, and a connection from the stale host result will be established but not confirmed. After host resolution returns, the two IP addresses will be compared. If they match, the connection will be confirmed. Otherwise the connection from stale host will be closed and connection from the fresh resolution will be established. Bug: 787942 Change-Id: I7a5f78ec42e97778d7c7d200f4d8ac894611fd19 Reviewed-on: https://chromium-review.googlesource.com/1186112 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#594522}
-
Stephen Chenney authored
Missed this update before committing the original patch. TBR=chrishtr@chromium.org Change-Id: I4fcda12146e7920615e4939785c39b8f220bc005 Reviewed-on: https://chromium-review.googlesource.com/1204671Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594521}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a3197bae3ca..5ea41fc89b26 git log 7a3197bae3ca..5ea41fc89b26 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 brianosman@google.com Remove more SkColorSpaceXform (and friends) Created with: gclient setdep -r src/third_party/skia@5ea41fc89b26 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: Ifd164163359f27950f45811893df257a09402c6b Reviewed-on: https://chromium-review.googlesource.com/1247084Reviewed-by:
-
Ria Jiang authored
Change-Id: Idceb9322ce688d3993c0a1712dd7b70d35aad304 Reviewed-on: https://chromium-review.googlesource.com/1246642Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594519}
-
Kyle Horimoto authored
The previous approach used a behavior, meaning that any Polymer element which needs to access the JS Mojo API needs to create its own InterfacePtr to the Mojo service. In a follow-up CL, I will be adding a new client of this interface, so it would have been wasteful to create two separate connections to the service. This CL converts this behavior to a class-based approach which utilizes a singleton class which stores a single instance of the pointer. Bug: 884058 Change-Id: I0b2c13677309b9949a0f26d2f11dd40ea8f15b1c Reviewed-on: https://chromium-review.googlesource.com/1247035Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#594518}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bfcdc913c418..80564a56ec85 git log bfcdc913c418..80564a56ec85 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 stevenperron@google.com Keep analyses live in unrolling (#1929) 2018-09-26 antiagainst@google.com VK_KHR_shader_atomic_int64 covers OpAtomic{Load|Store} 2018-09-26 dj2@everburning.com Remove use of SetContextMessageConsumer from binary_parse_test (#1925) 2018-09-26 jaebaek@google.com Validator: OpGroupNonUniformBallotBitCount validation (#1486) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@80564a56ec85 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I83fbc3bfd07e2f7713db3c67f7e907693d9044a1 Reviewed-on: https://chromium-review.googlesource.com/1247070Reviewed-by:
-
Bailey Berro authored
- Makes add dialog share fields stretch the full width of the dialog - Adds width styling mix-in to cr-searchable-drop-down - Updates add printer styling to be consistent after removing fixed width styling from cr-searchable-drop-down Bug: chromium:887111 Change-Id: Ibcb9c67b90cff9d0c5bf0c8cc058b6d218cb1f1a Reviewed-on: https://chromium-review.googlesource.com/1244614 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594516}
-
David Bokan authored
When an element is position: fixed and specifies a value for bottom, we want it to stick to the bottom of the viewport as the URL bar hides (and the renderer is moved up). However, we missed the special case where both top and bottom are specified. We can't resize the element in real time but it's more intuitive to have the element stick to the screen top. This also exposed an issue in how we raster the area exposed by the URL bar. Since we don't resize the viewport layers until the finger is lifted, the raster code needs to adjust the visible rect by the amount the URL bar is hidden. This was done by always adding the entire top controls height in the pending tree. This was guarded by an ANDROID ifdef which meant the test added here didn't get its benefit and produced unrastered tiles. I removed the ifdef (URL bar hiding is now also available on ChromeOS) and improved the expansion to make it more exactly match the amount of extra visible area. Bug: 846322 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I02700e08e8254a64405c3adb1a7a123b65468f44 Reviewed-on: https://chromium-review.googlesource.com/1235123 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594515}
-
Morten Stenshorne authored
Extra care is needed when the legend is an orthogonal writing mode root. We need to do what we do in min/max calculation for such children in the regular block layout algorithm. Fieldset padding is also special, since it's included in the fieldset content anonymous child, but we have to take care of it ourselves anyway, in case there is no such child (empty fieldset, or fieldset with just a legend). Bug: 875235 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: If26d8a59ae1514085f40e5a9e1ecee007997e7ad Reviewed-on: https://chromium-review.googlesource.com/1245363 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#594514}
-
Robert Sesek authored
Most of these were referenced by Cocoa code that has now been deleted. Bug: 832676 Change-Id: I96a54b283912b30455de753d2a689db464c35e64 Reviewed-on: https://chromium-review.googlesource.com/1246865 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594513}
-
Xianzhu Wang authored
Now exclude cases of using null output clip for an effect node if the out-of-flow descenant's containing block has the same clip as the current clip. This lets PaintChunksToCcLayers and PropertyTreeManager go through the more optimized path for more cases. Bug: 879173 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5c9e0006dc678c36b752823293f08355a194578b Reviewed-on: https://chromium-review.googlesource.com/1246686Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594512}
-
Robert Sesek authored
Bug: 832676 Change-Id: I1e386194f2925fd6b8d5ce594bb2372c2a6422ff Reviewed-on: https://chromium-review.googlesource.com/1246727 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c4a7356a469b..c8b28b92f6f3 git log c4a7356a469b..c8b28b92f6f3 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@c8b28b92f6f3 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6552c789ef394fa24d2b2352e8a1f8082e04017c Reviewed-on: https://chromium-review.googlesource.com/1247081Reviewed-by:
-
Devlin Cronin authored
Add a test that exercises behavior for a webRequestBlocking listener that never returns, and then the tab is closed. Do this with two flavors: - A listener in the extension's background page, where the RenderProcessHost is shutdown. - A listener in an extension tab, which is then closed. Verify that in both cases, navigation is unblocked when the extension listener goes away. Inspired by, but not in any way a fix for, https://crbug.com/877543. Change-Id: Id918d6d5f7bf5d8235f1386ef48838bffaa1b50c Reviewed-on: https://chromium-review.googlesource.com/1188942 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#594509}
-
Xiaoqian Dai authored
I accidentally delete one line code that should not be deleted. Bring it back. Bug: 887042 Change-Id: I9a6c4131eb2003888e0edd987ae7362ad847c568 Reviewed-on: https://chromium-review.googlesource.com/1247182Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#594508}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/74419b36e4b2..a42c3f899d04 git log 74419b36e4b2..a42c3f899d04 --date=short --no-merges --format='%ad %ae %s' 2018-09-26 dgarrett@google.com chromeos_config: Schedule with hours not days. Created with: gclient setdep -r src/third_party/chromite@a42c3f899d04 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Idf4c8ede4be0606a35a611a0106c6188de2a21bc Reviewed-on: https://chromium-review.googlesource.com/1247082Reviewed-by:
-
Nico Weber authored
Bug: 101600 Change-Id: Ia497c75176cb9d01c40e371f5f8e58ba3f3713a8 Reviewed-on: https://chromium-review.googlesource.com/1246602 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#594506}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2012676a..c6ab99ab Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6145b640628583d6106d5bce7925a00bf5bceaf0 Reviewed-on: https://chromium-review.googlesource.com/1246952Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594505}
-
Wenzhao Zang authored
This CL is more lightweight solution compared with the previous attempts: https://crrev.com/c/1229695 (An overkill. "no wallpaper" is not a valid UI state we'll support.) https://crrev.com/c/1187547 (A risky change. Large number of tests failed.) https://crrev.com/c/1173433 (Doesn't quite handle the "no wallpaper" case.) Bug: 874015 Change-Id: I7656856d1b631b7f6d2555f932116ea08e7d23ec Reviewed-on: https://chromium-review.googlesource.com/1237149Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#594504}
-
Adithya Srinivasan authored
This reverts commit 2eeb21dd. Reason for revert: This CL is causing crashes in canary (https://crbug.com/889422) Original change's description: > [FileSystem] Remove WebFileSystem > > - Adds blink.mojom.FileSystemManager to the frame and worker > registries, allowing it to be accessed directly from > ExecutionContext::GetInterfaceProvider()->GetInterface() > - Changes ownership of blink::FileSystemDispatcher: now owned by > ExecutionContext > - Omits render_frame_id_ from ChooseEntry > - Removes WebFileSystem and content::FileSystemDispatcher > > Bug: 787281, 873661 > Change-Id: Ie41d48c5a206b5d1f387fcee3bd47bc30a708f0f > Reviewed-on: https://chromium-review.googlesource.com/1217506 > Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593983} TBR=kinuko@chromium.org,mek@chromium.org,pwnall@chromium.org,adithyas@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 787281, 873661 Change-Id: Iacfc3c08d838f2258fd35603270d41beab086623 No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/1246863 Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#594503}
-
Suman Nelson Kancherla authored
Tested by checking the default value of "WebXR orientation sensor device" before and after the change, and it switched from disbaled to enabled, as expected. Bug: 695937 Change-Id: Ib5c3e9aee51d855740db1d6cbb9267068b411d19 Reviewed-on: https://chromium-review.googlesource.com/1244878Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#594502}
-
Thomas Tangl authored
The following changes have been made: - Add toggle in the privacy settings to allow Chrome sign-in on next startup - Add preference that propagates the toggle value on next startup - Add snackbar to relaunch Chrome - Disable Dice when sign-in is disallowed - Remove the line "Sign into Chrome is disabled by the administrator of this device" - Record a metric Signin.SigninAllowed on every startup Screenshots: https://drive.google.com/drive/folders/154_2BSPzfM8SQbiiJ8ARyUP7iNmhf8rJ?usp=sharing Bug: 888776 Change-Id: Iaa724f630d578cd4ef4449b7d658e766d7fdbdd5 Reviewed-on: https://chromium-review.googlesource.com/1245794 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#594501}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5767fc042834..7a3197bae3ca git log 5767fc042834..7a3197bae3ca --date=short --no-merges --format='%ad %ae %s' 2018-09-26 robertphillips@google.com Revert "Fix bug in GM's DDL drawing mode" 2018-09-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a602f9064b3e..af8b73c9e632 (3 commits) Created with: gclient setdep -r src/third_party/skia@7a3197bae3ca The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: Ie45457ced6f754f2ec97b38432aa11e169bd570c Reviewed-on: https://chromium-review.googlesource.com/1246986Reviewed-by:
-
Ryan Cui authored
Tests were blacklisted because of flakiness due to crbug.com/884589. Now that it's fixed, renable these tests. Bug: 884589 Change-Id: Idc1b073c7a50636778231177488112f778d649b5 Reviewed-on: https://chromium-review.googlesource.com/1246954Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Ryan Cui <rcui@chromium.org> Cr-Commit-Position: refs/heads/master@{#594499}
-
Xianzhu Wang authored
In order to handle paint offset translation. Bug: 889463 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iee36b15e2b823057af66298d2d13727cce12da06 Reviewed-on: https://chromium-review.googlesource.com/1246957Reviewed-by:
-
Pavel Feldman authored
Revert "Reland "DevTools: allow addScriptToEvaluateOnNewDocument accept optional worldName parameter."" This reverts commit fad0ee09. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "DevTools: allow addScriptToEvaluateOnNewDocument accept optional worldName parameter." > > This is a reland of 3321d814 > > Original change's description: > > DevTools: allow addScriptToEvaluateOnNewDocument accept optional worldName parameter. > > > > Change-Id: Ic22c1bf38aaf8e5d3e7caabf3c686c8c45b985b0 > > Reviewed-on: https://chromium-review.googlesource.com/1244460 > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#594161} > > Change-Id: I8a33e70976a2e52b7f69c5b2d0fa4e5af3594c6a > Reviewed-on: https://chromium-review.googlesource.com/1246901 > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594477} TBR=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org Change-Id: I64854d5d9f698e559619aec46b1f8de9fd56fd99 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1246597Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594497}
-
Mohamed Amir Yosef authored
When migrating bookmarks sync to USS architecture, it assumes that the bookmark model is creating only once. ManagedBookmarkServiceTest.EmptyManagedNode is creating the model twice which doesn't match the expecations of the new architecture. This CL refactor the test to make sure the bookmark model is created only once. In fact, the new scenario being tested resembles reality a lot closer, since keyed services are never destroyed during the lifetime of a profile. Bug: 516866 Change-Id: I4a966270cc6bfcbdb7e1c87a096fea6a81e4b1b4 Reviewed-on: https://chromium-review.googlesource.com/1243075Reviewed-by:
-
Matt Reynolds authored
Vendor and product IDs are 16-bit values used to identify USB and Bluetooth devices. Depending on the platform, they may be reported as integers or strings. This CL modifies all places in Gamepad where device IDs are stored as strings or signed integers to instead store them in a minimum-width integer unsigned type (uint16_t). Similarly, HID usage pages and usage numbers are defined to be 16-bit values. The constants holding these values are changed to uint16_t. In a future CL, Gamepad device ID and HID constants will be pulled out of the platform-specific data fetcher implementations and placed in a common header. BUG=786250 Change-Id: I30a0841db91008802331939a86a7b6c3c5f58586 Reviewed-on: https://chromium-review.googlesource.com/1102099 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#594495}
-
Liquan(Max) Gu authored
According to the spec (https://html.spec.whatwg.org/multipage/browsing-the-web.html#read-media), "Then, the user agent must act as if it had stopped parsing", so we mark DOM-interactive to Media Document when finishes parsing. Bug: 845385 Change-Id: I825409e9cf4c8d11f1f9233844492cc3a0bebe9a Reviewed-on: https://chromium-review.googlesource.com/1239516Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#594494}
-
Manas Verma authored
Before, the promo title would be different depending on whether or not the user is signed in — "...sign in and turn on sync." vs "...turn on sync." Now with the new DICe UI, promo titles will not include "sign in and ". So regardless of whether the user is signed-in, the promo title will now be "To use your cards on all devices, turn on sync." Bug: 872825 Change-Id: I5de9061ac8ad5771f803ba4f66969338746256a1 Reviewed-on: https://chromium-review.googlesource.com/1246363Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#594493}
-
Khushal authored
This trace event was removed in [1] but is needed by telemetry scripts to measure the decode time for images in perf tests. NOTE TO PERF SHERRIFS A regression in blink_perf.image_decoder benchmark is expected from this change since it restores this benchmark. R=chrishtr@chromium.org Bug: 881192 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I100082d30f2ebed4c8d7efa91a22c4670d4c2492 Reviewed-on: https://chromium-review.googlesource.com/1246272Reviewed-by:
-
Paul Miller authored
This reverts commit ef70c85e. Reason for revert: WebView now supports permanent-consistency. BUG=866722 Original change's description: > WebView: Ignore permanent-consistency experiments > > Android WebView currently treats permanent-consistency experiments > (which are intended to retain their group assignments across runs) as > session-consistency (which are intended to be randomly assigned on each > run). It's safer to not apply permanent-consistency experiments to > WebView at all, to avoid mistakes. > > BUG=866722 > > Change-Id: I9d501437718d934c2a59b95335c787302ce758e7 > Reviewed-on: https://chromium-review.googlesource.com/1148991 > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Paul Miller <paulmiller@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578070} TBR=changwan@chromium.org,holte@chromium.org,paulmiller@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 866722 Change-Id: Ifd00450fbba1afc1db619109cf918ef75cbcf84f Reviewed-on: https://chromium-review.googlesource.com/1237244Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#594491}
-
Sarah Hu authored
use password/PIN to unlock. Bug: 879297 Change-Id: Ia4518584977f24af1b7f7f2a849d1dc598e5fc95 Reviewed-on: https://chromium-review.googlesource.com/1211804Reviewed-by:
-
Clark DuVall authored
This is a speculative fix for http://crbug.com/884638. What I believe is happening is the RenderFrame is being destroyed while the WeakWrapperSharedURLLoaderFactory is still alive, and a request attempts to use it. This seems to be happening the most when the AdDelayThrottle is enabled and is delaying ads requests, which may explain why the request is finishing after the RenderFrame is destroyed. Bug: 884638 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I66960e5c5150345e7fd59f5ab5795414ec482a71 Reviewed-on: https://chromium-review.googlesource.com/1241955Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
Kevin Bailey authored
This CL describes an experiment to see if a dark blue keyword mode button will make it more visible and attention-getting. Bug: 883901 Change-Id: Ibef0b56b1a36f6debae0a446123632e173448c48 Reviewed-on: https://chromium-review.googlesource.com/1234035 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#594488}
-
James Cook authored
This makes it easier to find and consistent with ChromeShellDelegate. Also cleanup unnecessary includes in ChromeShellDelegate. I'm doing this because I may need to add a method to the delegate. Bug: none Test: existing browser_tests, manually test magnifier Change-Id: Icf0fdda4f6bea0f9fc3c281902e87fc036764950 Reviewed-on: https://chromium-review.googlesource.com/1246661Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#594487}
-
