GitLab

This happened in an error code path rarely exercised which is why it didn't
show up very often.

BUG=332403
R=bulach@chromium.org

Review URL: https://codereview.chromium.org/132053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244149 0039d316-1c4b-4281-b951-d872f2087c98

Original Review: https://codereview.chromium.org/113363004/

Current PPB_FileRef.MakeDirectory returns PP_OK if a directory exists on
the given path. This makes it difficult to create POSIX compatible API on
top of PPAPI.

This change introduces new PPB_FileRef.MakeDirectory as dev channel API.
That makes a new directory according to the given PP_MakeDirectoryFlags
values. The flags provide exclusive operation option. If exclusive flag
is specified and a directory exists on the given path, the function fails
and returns PP_ERROR_FILEEXISTS.


BUG=314879
TEST=browser_tests
TBR=dmichael@chromium.org,yzshen@chromium.org,tsepez@chromium.org

Review URL: https://codereview.chromium.org/131403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244148 0039d316-1c4b-4281-b951-d872f2087c98

Also print a clear "SUCCESS" message on success.

BUG=236893
R=sky@chromium.org

Review URL: https://codereview.chromium.org/131663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244147 0039d316-1c4b-4281-b951-d872f2087c98

BUG=317523

Review URL: https://codereview.chromium.org/131573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244146 0039d316-1c4b-4281-b951-d872f2087c98

On some bots, the USB restart fails, but some devices come back
online shortly afterwards.
Rather than completely shortcut, wait for at least one device to be alive.

BUG=332356
TBR=navabi@chromium.org

Review URL: https://codereview.chromium.org/128083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244145 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements the mechanism to pass an irt querying function to the plugin
process via AT_SYSINFO. Also, as the first step to implement many irt functions
for non-SFI mode, this CL introduces nacl_irt_basic.

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734
TEST=Tried to call a newly added function from plugin via AT_SYSINFO.

Review URL: https://codereview.chromium.org/125533004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244144 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244143 0039d316-1c4b-4281-b951-d872f2087c98

Chromium base revision: 243961 / bd289817
Old Skia revision: 12947
New Skia revision: 13002
Control CL: https://codereview.chromium.org/131503003

This CL was created by Skia's roll_deps.py script.

R=reed@google.com

Review URL: https://codereview.chromium.org/132523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244142 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244141 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164836:164850&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/133453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244140 0039d316-1c4b-4281-b951-d872f2087c98

This interface is intended for embedders to supply to the Signin component.
It had been created during an earlier aborted effort to componentize Signin.

BUG=332107
TBR=joi

Review URL: https://codereview.chromium.org/132083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244139 0039d316-1c4b-4281-b951-d872f2087c98

We a redirect commits, we should take the referrer policy from the
request we actually send and not from the one we intended to send.

Also, when the renderer tells the browser about a new navigation, always
update the referrer together with the URL

Depends on https://codereview.chromium.org/126753002/ in blink

BUG=331941
R=nasko@chromium.org
TEST=browser_tests:ReferrerPolicyTest.*

Review URL: https://codereview.chromium.org/128173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244138 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/60733028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244137 0039d316-1c4b-4281-b951-d872f2087c98

Previously, the "Close Window" item is copied from Chrome's "File" menu.
However, the key equivalent of this item changes between Cmd+Shift+w and
Cmd+w depending on whether a tabbed window has focus. This happens in
-[AppControllerMac adjustCloseWindowMenuItemKeyEquivalent:].

This causes a bug when the item in the app's menu does not match the one
in Chrome's. OSX will remove the keyboard shortcut for any items that have
a matching title but different key equivalents. 

In this CL, the key equivalent is always set to Cmd+w in the app's menu. The "Close Window" item in Chrome will be changed to Cmd+w when an app
window gains focus. Duplicate items are allowed to share a key equivalent
if their titles match.

BUG=302117

Review URL: https://codereview.chromium.org/130673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244133 0039d316-1c4b-4281-b951-d872f2087c98

In preparation for wider usage in media code, move the H.264 parser and
reader classes to media/filters from GPU-accelerated media locations, and
into the media namespace. These classes have only been, up to now, used
by hardware decode accelerators.

Also, move their unittests along and make them a part of media_unittests,
demoting H264ParserUnittest from being a standalone executable. While it
was designed to be run on a set of streams from commandline, it should make
more sense to run it more regularly (if only on just one stream), together
with media tests, to prevent basic regressions, if it's to be used more
widely than only in CrOS hardware acceleration classes.

BUG=None
TEST=Build VAVDA and vdaunittest for x86,
build EVDA, vdaunittest and veaunittest for ARM.
Also build and run media_unittests for both.

Review URL: https://codereview.chromium.org/119153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244132 0039d316-1c4b-4281-b951-d872f2087c98

 This was asssuming that the visibile area has 0,0 origin.

Move the code to ensure minimum visibility when added, from
WorkspaceLayoutManager to DragWindowResizer.

BUG=none
TEST=WindowUtilTest.AdjustBoundsToEnsureWindowVisibility.
 This also fixes the test that was failing.
TBR=oshima@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243986

Review URL: https://codereview.chromium.org/106303005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244131 0039d316-1c4b-4281-b951-d872f2087c98

Android Media player, by default, uses its own user agent string in the format
of "stagefright/1.2 (Linux; Android x.x)" when sending out requests.
This CL changes it to that of Chrome for Android when the media player instance is hosted by
Chrome for Android (or ChromiumWebView) to make the UA used across the browser
and its media source consistent.

R=qinmin@chromium.org
BUG=332344

Review URL: https://codereview.chromium.org/130363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244130 0039d316-1c4b-4281-b951-d872f2087c98

In one case, the packet was seemingly buffered, and then discarded, but
asynchronously sent (needlessly). We can just return, and not
track the packet since it definately won't have its contents
retransmitted.

In the other case it appears that the packet was sent, containing a
retransmission of previously sent frames.  Unfortunately that resend
was write-blocked, and while waiting, the original packet was acked,
which lead to removing the list of retransmittable frames from that
latter (write-blocked) packet.  An assertion was then failing when
the packet was sent, as it was expected to be retransmittable, but
had no retransmittable frames.

R=ian,rch
BUG=332631

Review URL: https://codereview.chromium.org/133243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244129 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318411

Review URL: https://codereview.chromium.org/93643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244128 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/132063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244127 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes the last instance of fullPath in the mosaic view and replaces it with use of the volume manager to extract the location information.

TEST=Tested manually.
BUG=320967

Review URL: https://codereview.chromium.org/130383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244126 0039d316-1c4b-4281-b951-d872f2087c98

BUG=307308
TEST=browser_tests
R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/119493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244125 0039d316-1c4b-4281-b951-d872f2087c98

Using one system TLS to implement multiple chrome's TLS slots.

BUG=264406

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241144

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241657

Review URL: https://codereview.chromium.org/60743004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244124 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244122 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244120 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=164831:164835&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/133243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244119 0039d316-1c4b-4281-b951-d872f2087c98

This causes some layout tests on Android to crash with a NPE.

TBR=tedchoc@chromium.org,avi@chromium.org

Review URL: https://codereview.chromium.org/130503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244118 0039d316-1c4b-4281-b951-d872f2087c98

TESTED=Good quality AEC using apprtc.

Review URL: https://codereview.chromium.org/129593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244117 0039d316-1c4b-4281-b951-d872f2087c98

This CL plumbs the embedder's zoom into the guest WebContents.

BUG=330818

Review URL: https://codereview.chromium.org/98073015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244116 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/322666 makes enrollment screen to be the first
screen for an interrupted auto start enrollment flow (remora). But
the enrollment screen does not handle flaky network well and often
lands user in a network error page. This CL makes the interrupted
flow resumes from network screen.

BUG=332572

Review URL: https://codereview.chromium.org/131463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244115 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244114 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316496
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/126143005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244113 0039d316-1c4b-4281-b951-d872f2087c98

This CL syncs the launch type pref for apps by adding a property to
app_specifics.proto. The sync data is processed in ExtensionSyncService.

extensions::SetLaunchType has been changed to take an ExtensionService
so that it is able to sync the pref change when a launch type is updated.

A value has been added to the LaunchType enum to represent an invalid
launch type preference.

BUG=181576
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/93883004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244112 0039d316-1c4b-4281-b951-d872f2087c98

Hardware video decode depends on GLX but we may be using OSMesa. In
this case fallback to non-hardware video decode gracefully instead
of static casting to an incorrect type.

This allows us to remove flags forcing non-OSMesa for some tests,
and they will test hardware decode on the ChromeOS VMs still.

These flags must go in order to support browser tests running
with a compositor instead of using legacy software mode, since
GLX inside the bot Xvfb environment can not run the compositor.
(This is a small piece of enabling us to test real code paths
in browser tests https://codereview.chromium.org/120313002/ .)

R=piman
BUG=270918

Review URL: https://codereview.chromium.org/132503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244111 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=estade@chromium.org

Review URL: https://codereview.chromium.org/129753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244110 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244109 0039d316-1c4b-4281-b951-d872f2087c98

R=rch@chromium.org
BUG=none
TEST=none
NOTRY=true

Review URL: https://codereview.chromium.org/133183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244108 0039d316-1c4b-4281-b951-d872f2087c98

This roll adds openssl_nacl target that builds openssl for PNaCl.

BUG=276739
TBR=wtc@chromium.org

Review URL: https://codereview.chromium.org/133063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244106 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/132853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244105 0039d316-1c4b-4281-b951-d872f2087c98

This makes make_global_settings closer to the GYP version. Previously it had relied on GYP concatenating two lists when running with goma, but it doesn't actually behave this way, resulting in unexpected output.

TBR=scottmg

Review URL: https://codereview.chromium.org/132833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244104 0039d316-1c4b-4281-b951-d872f2087c98