GitLab

NavigatorBase is a newly-added base class for Navigator and
WorkerNavigator. Making USB a Supplement of NavigatorBase allows
a single class to handle all of the work of exposing the
navigator.usb getter for both windows and workers, and greatly
reduces boilerplate.

Bug: 1147612
Change-Id: I4d13bf6948301b65663a48fd34d4410c9596b21b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536387
Commit-Queue: Nate Chapin <japhet@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827506}

Revert "Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`."

This reverts commit 114bc6ab.

Reason for revert: CaptureScreenshotTest.CaptureScreenshotBeyondViewport_InnerScrollbarsAreShown is failing consistently on linux-chromeos-rel:

https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42849
https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42850

Original change's description:
> Fix node screenshot. Part 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.
>
> 1. Add `captureBeyondViewport` param to CDP command `captureScreenshot`.
> 2. Use `WebSettingsImpl::SetMainFrameClipsContent(false)` to force the whole page to be rendered.
> 3. Set `hide_scrollbars` to avoid artificial scrollbars.
> 4. Set `record_whole_document` to force the whole page to be rendered.
> 5. Removed DCHECK from `third_party/blink/renderer/core/frame/visual_viewport.cc`, as soon as it didn't expect to have preferences to be changed "on the flight".
>
> Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1003629#c37
>
> Screenshots:
>
> - Before: https://i.imgur.com/yt6WZRx.png
> - Patchset #1: https://i.imgur.com/VsocJ3L.png - artificial scrollbars.
> - Patchset #3:
>   * https://imgur.com/UVqpzUQ - line breaks are not exactly the same as in original view.
>   * https://imgur.com/MXpgHOl
>   * https://imgur.com/haxemcr - not aligned with the node.
>   * https://imgur.com/RbdlYVT
> - Patchset #18:
>   * https://imgur.com/EWUmn0O
>   * https://imgur.com/DUrQ1yF
>   * https://imgur.com/cT5oBSi - perfectly aligned.
>   * https://imgur.com/Jy4UWtf - no artificial scrollbars (because of the view extended).
>
> Bug: 1003629
> Change-Id: I6bbc85cd0995626a8b1fb748ec9048c9d586200e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470876
> Commit-Queue: Maksim Sadym <sadym@chromium.org>
> Auto-Submit: Maksim Sadym <sadym@chromium.org>
> Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827440}

TBR=dgozman@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org,caseq@chromium.org,sigurds@chromium.org,sadym@chromium.org

Change-Id: Iaa9b6ee9f5584adbb4a521808e2d201834a6a6dc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1003629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538543Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827505}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/be466dc7ac2c..d347b31c0e2e

2020-11-13 alexrudenko@chromium.org Enable TypeScript for toolbox_bootstrap.js

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I080013fcfc6c41f2c96aa38924631ef01c68d030
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537121Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827504}

This sandbox flag was removed, so this is dead code.

Fixed: 1145605
Change-Id: Ibb7fb072f57da918f80644ffc80ae15334b02c0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537702
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Yu Han <yuzhehan@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Reviewed-by: Yu Han <yuzhehan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827503}

This is towards deleting StaticBitmapImage::CopyToByteArray and
other helpers.

The function ExtractImageData:
- Allocates a temporary surface with SkSurface::MakeRaster.
- Draws the image into that surface.
- Allocates output ArrayBufferContents.
- Make a copy of the SkSurface's contents using
  SkSurface::makeImageSnapshot.
- Copy the aforementioned copy to the output ArrayBufferContents using
  StaticBitmapImage::CopyToByteArray, which may do some sort of
  color conversion during the copy.

Change the function to:
- Allocate output ArrayBufferContents and point a surface directly
  at those pixels using SkSurface::MakeRasterDirect.
- Draw into the pixels, converting to the desired format on the fly.

Bug: 1115317
Change-Id: I656c1ed701c7bafade694d7dfad38dbb0bc74564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533289Reviewed-by: enne <enne@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827502}

NavigatorBase is a newly-added base class for Navigator and
WorkerNavigator. Making Serial a Supplement of NavigatorBase
allows a single class to handle all of the work of exposing the
navigator.serial getter for both windows and workers, and
greatly reduces boilerplate.

Bug: 1147612
Change-Id: If8bb50bdb9729b106be20f0ee228233560f09511
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537920
Commit-Queue: Nate Chapin <japhet@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827501}

Narrator table with `Ctrl+Alt+(left/right/up/down)` was not supported
in Views. According to UIA API, the `GetItem` was not implemented
in Chromium.
https://docs.microsoft.com/en-us/dotnet/api/system.windows.automation.provider.itableprovider

Looking in the Chromium Accessibility Core, that gets translated
to the cross-plat `GetTableCell` which requires `GetCellId` to be
implemented. In this case the ViewAccessibility's platform node,
wasn't.

The approach taken was to reuse the existing internal method in
`TableView::GetVirtualAccessibilityCell` to get the node id for the
AXNode.

AX-Relnotes: Cells in TableView are navigable in UIA.
Bug: 1148097
Change-Id: I2257862bbe01d15fc7591bfeb9952ca2d8b143c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533837Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Mohamed Mansour <mmansour@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#827500}

Previous cleanup CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2520476

- app_type() and app_type_ is always kExtension.
- Exclude from_bookmark() extensions.

Bug: 1065748
Change-Id: I39301a2537c2e77633ef85067f6bd81f9adacecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522831
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827499}

Roll Chrome Win32 PGO profile from chrome-win32-master-1605214676-c85e88d2c252aa731add321a6482c347ea572e8a.profdata to chrome-win32-master-1605278951-6acf5f1c81bf8e5b853d44ef9575d8aab067a4b3.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I80835c86d3b275e178faea1c9655453f3a6a6b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536991Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827498}

This test is broken and doesn't actually test what it intends to. See
bug for details.

Bug: 1148855
Change-Id: Ife41243c4beaf992543f817c693151f5821bf5ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537136
Auto-Submit: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827497}

To prepare for enabling debug logs by default for Googlers, this shows
the debug toggle by default. This does NOT enable the debug logs, but
this only shows the debug log toggle which only Googlers can see and
toggle the debug log on or off manually.

Bug: b:172273364
Change-Id: I01461177fc75d556a5d0786dcd3eb3a5a7325215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536849Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827496}

CL to add tester to recipe: crrev.com/c/2536808

Bug: 1147595
Change-Id: I4a140af01a025e1455b71b7ac50b834e5f5bf68e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538355Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Anjali Doneria <adoneria@google.com>
Cr-Commit-Position: refs/heads/master@{#827495}

This puts LocationBarCoordinator in charge of constructing and
destroying UrlBarCoordinator, StatusCoordinator, and
AutocompleteCoordinator. This allows us to wire a few more
dependencies into constructors instead of via setters. The
coordinators are still passed to LocationBarLayout for it to use via
a new initialize() method that consolidates a few different setter
methods on LocationBarLayout. initialize() helps avoid bugs that
could arise when calling these setters out of order. There is an
additional change to LocationBarLayoutTest that fixes a DCHECK when
running tests on a debug build.

Bug: 1146057, 1146062

Change-Id: Ie6c7e871d6cb0eb4bbffff0ab3ed275968d84e85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495969
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Tomasz Wiszkowski <ender@google.com>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827494}

Fixes missing offset for non-zero bounds.x() for the icon area in
TabIcon::MaybePaintFavicon.

Bug: 1147408
Change-Id: I309c5074ee82c8a4ecc3cd14243c329088fb06a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538207
Auto-Submit: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827493}

1. Disable component build for mac builders on CI and try.
2. Enable use of goma for mac and win builders on CI.
3. Enable component build for win builders on try.

Bug: 1148920
Change-Id: I690834b4b80812569bff2d8206b775cf05966f8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538161Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Anjali Doneria <adoneria@google.com>
Cr-Commit-Position: refs/heads/master@{#827492}

The IDL file is split in three parts: public, internal, and legacy
definitions.

This is a fairly straightforward change, which consists of suffixing
the path to the typelib in the executable file with a //<index> where
the index matches one of the there source IDLs above.

Further work is needed to properly generate the GUIDs depending on
the which IDL the GUIDs belong to. Some of the GUIDs must depend on
branding, and some of the GUIDs must depend on branding and version.

This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2527822
after the following fixes:

diff --git a/chrome/updater/test/test_app/update_client_win.cc b/chrome/updater/test/test_app/update_client_win.cc
index 13ffa873ce6c..71c8e4c090c6 100644
--- a/chrome/updater/test/test_app/update_client_win.cc
+++ b/chrome/updater/test/test_app/update_client_win.cc
@@ -28,11 +28,12 @@
 #include "chrome/updater/update_service.h"

 namespace updater {
+
 namespace {

 HRESULT CreateUpdaterInterface(Microsoft::WRL::ComPtr<IUpdater>* updater) {
   Microsoft::WRL::ComPtr<IUnknown> server;
-  HRESULT hr = ::CoCreateInstance(__uuidof(UpdaterClass), nullptr,
+  HRESULT hr = ::CoCreateInstance(__uuidof(UpdaterClass)], nullptr,
                                   CLSCTX_LOCAL_SERVER, IID_PPV_ARGS(&server));

   if (FAILED(hr)) {
diff --git a/chrome/updater/test/test_app/update_client_win.h b/chrome/updater/test/test_app/update_client_win.h
index 25e16c53cc09..e5496ec47828 100644
--- a/chrome/updater/test/test_app/update_client_win.h
+++ b/chrome/updater/test/test_app/update_client_win.h
@@ -10,7 +10,7 @@
 #include <windows.h>
 #include <wrl/client.h>

-struct IUpdater;
+class IUpdater;

 namespace base {
 class SingleThreadTaskRunner;

Bug: 1140562

Change-Id: Ibce69536e2816ab089f8851191af052ff7616565
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538267Reviewed-by: S. Ganesh <ganesh@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827491}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e61ccc59a240..fd5c198347e1

2020-11-13 chanli@chromium.org [resultdb] Update rdb version

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1147548
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: Ia7f7a6de01e7448b1c489c0697c9a2d5791d457d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537105Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827490}

We expect that this duration will either be pretty short, in the case
of loadshedding origins, or very long in the case of origins trying to
use a 503 response to opt out of prefetches. Since the loadshedding
case is not interesting from a product prespective, this histogram is
scoped out to a week to catch the latter.

Bug: 1146210
Change-Id: Ibeb1488206edbca7c8999a05def7e22d833772a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538133Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827489}

Few more unit test fixes.

Bug: 958381
Change-Id: I902fe45de917b06322e886b02c2b6fe495d08421
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536254
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827488}

Items in single selection containers that have accessibility focus
should get the selected state. Code to mirror focus to selection
exists, but the selected state must be refreshed.

Replacing AXLayoutObject::SelectionShouldFollowFocus with a helper
method in ax_role_properties, ui::IsSelectRequiredOrImplicit and
including Role::kTreeItem [1] since the ARIA spec lists aria-selected
as a required state.

Adding AXObject::IsSelectedFromFocusSupported (see AXLayoutObject impl)
which provides a mostly conclusive answer for whether an element can
support this behavior.

During this investigation, I found there was a portion of the spec that
was not implemented, so I created a crbug [2] for that. "If any DOM
element in the widget is explicitly marked as selected, the user
agent MUST NOT convey implicit selection for the widget."

Also created a crbug [3] for followup to consider including more
selectable roles for this behavior. Currently only roles that require
or have an implicit value for aria-selected allow this behavior.
It may be desirable to include roles columnheader, rowheader, gridcell
and row, but felt that would be out of scope for this CL.

[1]: https://www.w3.org/TR/wai-aria-1.1/#treeitem
[2]: https://crbug.com/1143451  (Not allowed with explicit selection)
[3]: https://crbug.com/1143483  (Consider allowing more roles)

AX-Relnotes:Notify the aria-selected state changed for items that
have their selected state follow focus, and enable this behavior for
role=treeitem elements inside single-selection containers.

Bug: 1141579
Change-Id: Idce80a91f41df859775eed59a922ac7c923d9f4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493000
Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827487}

https://dawn.googlesource.com/dawn.git/+log/56523dff6983..da1f66c8cee1

2020-11-13 enga@chromium.org Update DepthBiasTests to use WGSL
2020-11-13 enga@chromium.org Update CullingTests to use WGSL
2020-11-13 enga@chromium.org Update ComputeIndirectTests to use WGSL
2020-11-13 enga@chromium.org Update CompressedTextureFormatTests to use WGSL
2020-11-13 enga@chromium.org Update ColorStateTests to use WGSL
2020-11-13 enga@chromium.org Update ClipSpaceTests to use WGSL

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC sarahmashay@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: sarahmashay@google.com
Change-Id: I69a38afae88fc367ea614a7575e07962f9ca7a73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537142Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827486}

Bug: 1148979
Change-Id: I971194186baef5f8a2b82ef8a826f491116a102e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538353
Commit-Queue: Robin Lewis <wrlewis@google.com>
Commit-Queue: Yusuf Sengul <yusufsn@google.com>
Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#827485}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I70d41037f2dfac71976d0156f19d16edb900e0a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537102Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827484}

- -Wfinal-dtor-non-final-class warns on classes with final dtors but
  not final classes.
- Error messages are better when the class is marked final.
- Fix existing issues in code base and a follow up will remove warning
  exemption.

Bug: 999886
Test: no errors building
Change-Id: I37686da165a4ef9d352e39c25f875e80ee2da77c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537934Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827483}

This was missed in the original implementation because on Windows
the pump always processes a native event before DoWork() and
hence always kicks off the "ThreadController active" trace event
prior to DoWork(). On platforms that don't do this, the tasks nested
backwards (and the ends were out of order which messed up the trace
layout).

Also cover DidRunTask() now to cover microtasks and added extra brackets
to make it extra clear what the scope of "things we do to run the task"
are.

R=altimin@chromium.org

Bug: 899897, 1074019
Change-Id: I67a01853365e173ed924513592191d6098a4f621
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536998
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827482}

Removing an unnecessary call to IsDefaultSiteInstance() in
RenderFrameHostManager. The condition the call was in expects
RequiresDedicatedProcess() to return true on the SiteInstance which
won't happen on a default SiteInstance.

- Removed IsDefaultSiteInstance() call from RFHM.
- Added a test that explicitly verifies that a default SiteInstance
  returns fals for RequiresDedicatedProcess() to help prove the
  call was not needed and ensure that we don't accidentally change
  this behavior.
- Converted DCHECK in set_process_reuse_policy() to a check to make
  sure we don't accidentally allow reuse to be set on production builds.

Bug: 1085275
Change-Id: I628df05fe1b2eb27031f8bec087913867717e9a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538251
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827481}

NavigatorBase is a newly-added base class for Navigator and
WorkerNavigator. Making GPU a Supplement of NavigatorBase
allows a single class to handle all of the work of exposing the
navigator.gpu getter for both windows and workers, and
greatly reduces boilerplate.

Bug: 1147612
Change-Id: I8621639935b014eb4905804f432327729619c3d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537775
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827480}

This reverts commit 902c49d1.

Reason for revert: Builders do not allow using a floating references. We need to start pinning tags to chromium/src again in order to run skew tests. The error can be seen here, https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8863706392115604464/+/steps/test_pre_run/0/steps/s__trigger__weblayer_instrumentation_test_versions_apk_M88_Client_Tests/0/stdout?format=raw

Original change's description:
> weblayer, skew tests: Add M88 skew tests
>
> This skew test will updated daily by uploading new CIPD packages
> for each tag created in the M88 branch. The m88 reference will point
> to the most recent package uploaded.
>
> Bug: 1147459, 1147455, 1099017, 1041619
> Change-Id: Ib9ae51d2a7379d478cbab68a334c7d2488bf0e8a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538152
> Auto-Submit: Rakib Hasan <rmhasan@google.com>
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827411}

TBR=sky@chromium.org,rmhasan@google.com

Change-Id: I17d5abc780eeba571c4d92793db46ed88ab61d66
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1147459
Bug: 1147455
Bug: 1099017
Bug: 1041619
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537186Reviewed-by: Rakib Hasan <rmhasan@google.com>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#827479}

This test is no longer flaky on asan or tsan bots, but is very flaky
on Mac and Windows, so this CL re-enables the test on the asan/tsan bots
and disables it on Mac and Windows.

Bug: 377702, 1148894
Change-Id: Ia0065e4636bf813d98bca6cda1ead3edc7ae4684
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535035Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827478}

Currently we've rolled our own helper method "ContainsFeature"; however,
this essentially duplicates base::Contains (which is slightly shorter).
Remove this helper method and use base::Contains instead.

Change-Id: Icc4d92190536bbd7203474305bf891e48e4cb7dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537786
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827477}

The change is mostly mechanical replacing defined(OS_CHROMEOS) with
BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash
with some special cases (For those cases please refer to
http://go/lacros-macros).

The patch is made in preparation to switching lacros build from
target_os=linux to target_os=chromeos. This will prevent lacros from
changing behaviour after the switch.

I added a couple TODOs for lacros work items that need followup and
deleted an unused include.

Bug: 1052397
Change-Id: I726fc10295074dbc9cff4501b0d67ea2b4f7de54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536798Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827476}

This CL implements the stale-frame metrics that measure the undesirably
prolonged presentation time due to frame dropping. The metrics are
reported under the Graphics.Smoothness.Stale.* (staleness of each frame)
and Graphics.Smoothness.MaxStale.* (maximum staleness per interaction).

Bug: 1092949
Change-Id: Id2e3d616bfa4362fd8f4b6db4fedb23290d6cba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490385Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Mingjing Zhang <mjzhang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827475}

This CL changes AwContents.loadUrl(LoadUrlParams), so that URLs passing
through WebView APIs are fixed - partially restoring the behavior prior
to r818969.

Before r818969 (which landed in 88.0.4298.0), the URL passed to
WebView.loadUrl (and postUrl, loadData, loadDataWithBaseURL) would get
fixed via url_formatter::FixupURL when the //content layer was
processing the navigation (e.g. from within WillHandleBrowserAboutURL or
BrowserURLHandlerImpl::FixupURLBeforeRewrite - both of these callsites
have been removed in r818969).  Such rewrite is not happening after
r818969 - this is an accidental breaking change.  In
https://crbug.com/1145717 we have some evidence that some apps have
actually depended on fixing the URLs, although the evidence is not
particularily strong and doesn't include the specific URLs that were
getting fixed.

Unlike before r818969, *all* URLs are fixed, *prior* to starting the
navigation via the //content APIs - this introduces some small
differences in behavior (e.g. javascript:42 would not be rewritten
before this r818969, but would be rewritten to http://javascript:42/
after the current CL), but these differences are small and the risk
seems acceptable (e.g. javascript:42+42 would not be rewritten).

Bug: 1145717
Change-Id: I04f5ee54b3ee841cf54d0256e0eeca2e2f984e6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528804Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827474}

Rename sim-detect-page to setup-loading-page and update UI to be used
for both psim and esim flows.

Bug: 1093185
Change-Id: Iaf8934a3423c1ce21d6115bc9ea28c9d972738b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535231
Commit-Queue: Gordon Seto <gordonseto@google.com>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827473}

This is in preparation of splitting RulesetSource class into a
RulesetSource base class and a FileBackedRulesetSource derived class.
This will be useful for implementing session scoped rules which are not
file backed.

BUG=1043200

Change-Id: Ia099b9f180408d4b3518c4f80d41ec312d5f740f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495875
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827472}

This CL improves the error messages for array parse failures in
generated code.

BUG=1113513

Change-Id: Ic1edfab5e005f363b8670b1f798a241673b856ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520799Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827471}

Replaces remaining CalculatePreferredSize() overrides that are used to
unconditionally set a specific fixed width.

Bug: 1128500
Change-Id: I93abc6b85be7fa956e65608819806aaac23d8d9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538131Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Connie Wan <connily@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827470}

This reverts commit 34bf7349.

Reason for revert: Failing SingleRulesetTest.SessionRules unit_tests on multiple platforms:

https://ci.chromium.org/p/chromium/builders/ci/win-asan/15627
https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/17985
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/110233

Original change's description:
> DNR: Add initial implementation for [get/update]SessionRules.
>
> The session rules are not indexed and evaluated yet. This will be done
> in a follow-up.
>
> Skipping presubmit since this seems to be hitting crbug.com/956368.
>
> BUG=1043200
> Doc=https://docs.google.com/document/d/1_I6jHA_jCa0UbR2QVUZsBApt_GqEuMz7qnpQdt1LEv0/edit?usp=sharing (Internal only)
>
> No-Presubmit: True
> Change-Id: Id15783af14ff1f4a88900680d29d71d07794b4e7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495511
> Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Kelvin Jiang <kelvinjiang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#827418}

TBR=rdevlin.cronin@chromium.org,karandeepb@chromium.org,kelvinjiang@chromium.org

Change-Id: Ibdd5c17fb41abc19809fb9fe7224c1ecdd30c1ab
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1043200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537185Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827469}

Previously, ImageReaderGLOwner created a ScopedJavaSurface that did
not call Surface.release() upon destruction.  Unfortunately, this
meant that nobody called release().

This was never noticed because we also leaked the Surface object,
so it was never finalized => no helpful diagnostics.  After

https://chromium-review.googlesource.com/c/chromium/src/+/2453270

the leak was fixed, but now the lack of release() caused strict-
mode violations.

This change switches ImageReader's ScopedJavaSurface to call release
properly. It's safe because CodecSurfaceBundle makes sure that the
surface outlives the MediaCodec instance that's using it.

This change also reverts

https://chromium-review.googlesource.com/c/chromium/src/+/2527563

which replaced the leak-the-surface behavior intentionally,
as part of the investigation.

Bug: 1146071
Change-Id: Ib8187530299ba7790e30e630250cc2a7fd4eebf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537782Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: vikas soni <vikassoni@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#827468}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33eec64159df..07569638a739

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC sclittle@google.com,adithyas@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1115463,chromium:1119406,chromium:1147179
Tbr: sclittle@google.com,adithyas@google.com
Change-Id: I047fca48aab5d00503ef3edfddfe3872908f9b4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537031Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#827467}