Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 06 Dec, 2017 23 commits
    • v8-autoroll's avatar
      Update V8 to version 6.5.12. · 6727a857
      v8-autoroll authored 
      Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7af7216b..ee13fe4b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I0f22175c61de70e41f207fa63454f373ef78ea4d
Reviewed-on: https://chromium-review.googlesource.com/809911Reviewed-by: default avatarv8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521929}
      6727a857
    • Ojan Vafai's avatar
      Revert "Snap at GestureScrollEnd on main thread." · 38cf2560
      Ojan Vafai authored 
      This reverts commit a9783e12.

Reason for revert: Broke webkit_unit_tests

All/SnapCoordinatorTest.OverflowedSnapPositionCalculation/1
All/SnapCoordinatorTest.OverflowedSnapPositionCalculation/0
All/SnapCoordinatorTest.EndAlignmentCalculation/1
All/SnapCoordinatorTest.CenterAlignmentCalculation/0
All/SnapCoordinatorTest.CenterAlignmentCalculation/1
All/SnapCoordinatorTest.EndAlignmentCalculation/0
All/SnapCoordinatorTest.StartAlignmentCalculation/0
All/SnapCoordinatorTest.StartAlignmentCalculation/1
All/SnapCoordinatorTest.NegativeMarginStartAlignmentCalculation/1
All/SnapCoordinatorTest.NegativeMarginStartAlignmentCalculation/0
All/SnapCoordinatorTest.AsymmetricalCenterAlignmentCalculation/1
All/SnapCoordinatorTest.AsymmetricalCenterAlignmentCalculation/0

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/72004

Original change's description:
> Snap at GestureScrollEnd on main thread.
> 
> As the first step of ScrollSnapPoints, this patch implements it on main
> thread at GestureScrollEnd. It introduces necessary data structures:
> SnapAreaData and SnapContainerData, updates the data after style change
> and layout, implements a naive algorithm to select snap points at
> intended-end-position, adds unit-tests for logic and adds sim-tests for
> behavior.
> 
> Bug: 778257
> Change-Id: I307d51254bd9ab9b7a42b0614d181adac662fa47
> Reviewed-on: https://chromium-review.googlesource.com/756887
> Reviewed-by: Jeremy Roman <jbroman@chromium.org>
> Reviewed-by: Darren Shen <shend@chromium.org>
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Majid Valipour <majidvp@chromium.org>
> Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521840}

TBR=bokan@chromium.org,jbroman@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,shend@chromium.org

Change-Id: I172b350063d66006a3974919f67c7d4f4f0a980d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 778257
Reviewed-on: https://chromium-review.googlesource.com/809313Reviewed-by: default avatarOjan Vafai <ojan@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521928}
      38cf2560
    • Alice Boxhall's avatar
      [Devtools] Fix two style issues caused by rearranging the Color Picker · e7898d1a
      Alice Boxhall authored 
      Bug: 791906,791902
Change-Id: I4a4ccb4afd70b4888a14455f56eea3ba739add77
Reviewed-on: https://chromium-review.googlesource.com/809810Reviewed-by: default avatarPavel Feldman <pfeldman@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521927}
      e7898d1a
    • Hiroshige Hayashizaki's avatar
      Move context document/frame null checks earlier · 22bf150b
      Hiroshige Hayashizaki authored 
      - It is better to do nothing when context document/frame is null.
- Preparation for removing ExecuteScriptResult.
  kShouldFireNone is no longer used, and will be removed in
  https://chromium-review.googlesource.com/791473.

Bug: 788828, 686281
Change-Id: I2327e9065c9a07da0ea3658bb1d31765cbcb537f
Reviewed-on: https://chromium-review.googlesource.com/791450
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: default avatarJeremy Roman <jbroman@chromium.org>
Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521926}
      22bf150b
    • liberato@chromium.org's avatar
      Moved D3D11PictureBuffer into its own source files. · 5a1ce5c8
      liberato@chromium.org authored 
      Bug: 775577
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I99dc244ceb3905fd55c948398a7991a5a019e669
Reviewed-on: https://chromium-review.googlesource.com/806734Reviewed-by: default avatarDan Sanders <sandersd@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521925}
      5a1ce5c8
    • Vincent Scheib's avatar
      bluetooth: internals page: Refactor instantiation of Bluetooth service. · dbe693be
      Vincent Scheib authored 
      Moves ability to create the //device/bluetooth/public/interfaces Adapter
to chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_handler.cc
instead of chrome/browser/chrome_content_browser_client.cc

//chrome/browser/ui/webui/bluetooth_internals target created to allow visibility
of //device/bluetooth/public/interfaces:deprecated_experimental_interfaces
to be restricted precisely to the single allowed client.

Numerous build files adjusted as needed to enforce that visibility restriction
and clearly document that the interfaces are only intended to be used by
bluetooth-internals.

Bug: 746132
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Idcaa51d1ed4fb818bd3d8ae617e41a28eabfcb44
Reviewed-on: https://chromium-review.googlesource.com/775782Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: default avatarGreg Kerr <kerrnel@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521924}
      dbe693be
    • Toni Barzic's avatar
      Introduce BacklightsForcedOffSetter · 9d0c82f4
      Toni Barzic authored 
      Extracts code that deals with calling powerd SetBacklightsForcedOff
method from PowerButtonDisplayController to a separate class that can
handle multiple concurrent requests to set backlights off (by keeping
track of the active set backlights forced off requests).

While currently only PowerButtonDisplayController uses
SetBackligthsForcedOff, it's planned to add similar ability to lock
screen note launching code in a follow-up (the idea is to force
backlights off if the lock screen app is launched while the display is
turned off, until the app launch is done).
Goal of BacklightsForcedOffSetter is to prevent these two classes from
conflicting with each other - it will ensure backlights are forced off
as long as at least one backlights forced off request is active.

Backlights can be forced off using
BacklightsForcedOffSetter::ForceBacklightsOff, which returns
ScopedBacklightsForcedOff unique ptr - to stop backlights forced off
request, callers should just reset the returned unique ptr.

BUG=767711
TEST=Press power button, verify display is turned off. Press power
     button again - display is turned on.

Change-Id: Ie47f546edb51659bb82ba4618b069569a2d188c6
Reviewed-on: https://chromium-review.googlesource.com/758963
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: default avatarDan Erat <derat@chromium.org>
Reviewed-by: default avatarQiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521923}
      9d0c82f4
    • Kyle Horimoto's avatar
      [CrOS Tether] Utilize RemoteDeviceCapability within TetherHostFetcher. · cdfd4cb7
      Kyle Horimoto authored 
      This change makes it possible to return RemoteDevice objects
synchronously instead of requiring an IPC call to create them. This
change is needed to support [1], since that CL requires that a
BluetoothDevice object be used immediately (i.e., synchronously),
requiring that a RemoteDevice object is also available synchronously.

This CL also moves ownership of TetherHostFetcher from TetherComponent
to TetherService, ensuring that RemoteDevice objects necessary for
TetherComponent are generated before the component is started up.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/738467

Bug: 777610, 672263
Change-Id: I3c74af3cb8964d32e3bd30298849af1e2477c77a
Reviewed-on: https://chromium-review.googlesource.com/804395
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: default avatarRyan Hansberry <hansberry@chromium.org>
Reviewed-by: default avatarJeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521922}
      cdfd4cb7
    • Marti Wong's avatar
      Add 2 egtests for the new iOS bookmarks · 5ab0c368
      Marti Wong authored 
      2 egtest2 are added:
1. testWhenCurrentFolderDeletedInBackground: test when the navigating
   folder of Bookmarks is deleted in background, empty background is
   shown with context bar buttons disabled.
2. testBookmarksURLDisabled: test chrome://bookmarks is disabled.

Bug: 782551
Change-Id: I1e0f4cc4960aca3094e673e812d040ec231d497c
Reviewed-on: https://chromium-review.googlesource.com/807410Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Marti Wong <martiw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521921}
      5ab0c368
    • Dave Schuyler's avatar
      [MD extensions] browser test retrying extensions load · bf54b51c
      Dave Schuyler authored 
      This CL adds a test for retrying the load of an extension that had errors.
Both a retry that fails and a retry that succeeds are tested.
This is a follow-up for CL 798123.

Bug: 789751
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I161f35127d5c37769d6c5e577c2e7d6689dbb482
Reviewed-on: https://chromium-review.googlesource.com/807448
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521920}
      bf54b51c
    • Sasha Bermeister's avatar
      Remove subclasses and outstanding_requests_ from QuotaDispatcherHost · 167850c4
      Sasha Bermeister authored 
      Remove outstanding_requests_ from QuotaDispatcherHost and associated
subclasses to address TODO. These subclasses existed to carry the
request_id around. Now that the request_id has been removed from the
QuotaDispatcherHost system, these subclasses are no longer needed.

Also change the design of QuotaDispatcherHost slightly; instead of
creating a separate object to hold all the request parameters, curry
the parameters into the various async callbacks.

Bug: 781643
Change-Id: Ia85ed5a8f6e75a424767faa632e0f1f831a32ddf
Reviewed-on: https://chromium-review.googlesource.com/799573Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
Reviewed-by: default avatarSam McNally <sammc@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521919}
      167850c4
    • skia-deps-roller@chromium.org's avatar
      Roll src/third_party/skia/ a3e9271ec..f9af55641 (2 commits) · e12cfcc1
      skia-deps-roller@chromium.org authored 
      https://skia.googlesource.com/skia.git/+log/a3e9271ec41d..f9af55641a6d

$ git log a3e9271ec..f9af55641 --date=short --no-merges --format='%ad %ae %s'
2017-12-05 angle-deps-roller Roll skia/third_party/externals/angle2/ f5be5bafa..12a18ad35 (10 commits)
2017-12-05 kjlubick Don't set min frequency for Android devices

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=rmistry@chromium.org

Change-Id: I0b682fa7acd4cdb0ba05cd7efad3c393a04e4387
Reviewed-on: https://chromium-review.googlesource.com/809923Reviewed-by: default avatarSkia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521918}
      e12cfcc1
    • Lukasz Anforowicz's avatar
      Improve granularity of window namespaces in Blink. · 1c950906
      Lukasz Anforowicz authored 
      This CL ensures that blink::FrameTree::Find(const AtomicString& name)
only looks for a match in the current set of related browsing contexts
(represented in the browser by content::BrowsingInstance).  This CL
means that window.open's behavior won't change just because a renderer
process happens to host multiple unrelated browsing contexts (possible
for example after reusing a renderer process because of hitting the
process limit).

This CL consists of 3 parts:

- New browser tests.
  - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance
    for verifying browsing instance boundaries when the
    renderer processes get reused.
  - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank
    for verifying that extensions can still lookup unrelated frames
    from the same extension.

- Having blink::Page maintain a set of related pages.
  - Page::next_related_page_ and Page::prev_related_page_ form a
    circular, double-linked list of related pages.
  - Page::CreateOrdinary takes a new |opener| parameter and treats the
    new page and the |opener| as related and puts them on the same list.
  - |opener| is propagated from content::RenderViewImpl, through
    blink::WebViewImpl into blink::Page.

- Falling back to blink embedder when blink::FrameTree::Find finds no frame
  with the given name.
  - The fallback is needed to preserve the old behavior for extensions.
  - The fallback goes through blink::LocalFrameClient,
    blink::WebFrameClient / content::RenderFrameImpl,
    content::ContentRendererClient / ::ChromeContentRendererClient,
    ::ChromeExtensionsRendererClient and finally is implemented
    by extensions::ExtensionFrameHelper.
  - Currently the fallback iterates through all same-origin frames in
    the given process, but requires that the |relative_to_frame| is an
    extension frame.  In the future we might want to restrict piercing
    of browsing instances to specific scenarios where it is needed
    (e.g. restrict it to background pages / contents only?).

I've tested this CL via:
(all tests below pass before and after the CL, except for
ProcessReuseVsBrowsingInstance which is fixed by this CL)

- New tests:
    - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance
      (web -> web shouldn't violate browsing instance)
    - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank
      (extension/about:blank -> extension can violate browsing instance)

- Existing tests:
    - ExtensionApiTest.WindowsCreate_WithOpener and _NoOpener
      (chrome.windows.create stays in the same browsing instance depending
       on the setSelfAsOpener parameter)
    - AppBackgroundPageApiTest.Basic
      (hosted app -> background page can violate browsing instance;
       tests handling of mapping of web urls [full url, not just origin]
       to extensions)

- Manual testing:
  - Hangouts Chrome *extension* continues to work (sufficient to
    validate that sign-in works).  Tested with version 2017.1019.418.1.

Bug: 718489
Test: See above.
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Tbr: tommycli@chromium.org
Change-Id: Icdc9ec7bef0e35b59e04fb12385045f22db80c3a
Reviewed-on: https://chromium-review.googlesource.com/764487
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
Reviewed-by: default avatarMatthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Reviewed-by: default avatarCharlie Reis <creis@chromium.org>
Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521917}
      1c950906
    • liberato@chromium.org's avatar
      Move D3D11 accelerator to windows/ · ad9f8867
      liberato@chromium.org authored 
      Bug: 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5979881b8b9c05ca99f88531fc6e565feeee0c13
Reviewed-on: https://chromium-review.googlesource.com/804687
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: default avatarDan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521916}
      ad9f8867
    • Donn Denman's avatar
      [Smart Selection] Update fieldtrial_testing_config · 62f8e980
      Donn Denman authored 
      Updates the config to match our full launch group for
Smart Selection on Chrome for Android.

BUG=770767

Change-Id: I80a04f3b66342eba17c17c8b66cda9b25d7b278b
Reviewed-on: https://chromium-review.googlesource.com/809850
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521915}
      62f8e980
    • Philip Rogers's avatar
      [root layer scrolls] Rebaseline devtools layer tree and compositing test · 122fa656
      Philip Rogers authored 
      layer-tree-model.js:
This test dumps the layer tree and associated elements. With root
layer scrolling (RLS), the layers are associated with different
elements (e.g., the iframe scrolling contents layer is "#document"
instead of "iframe#frame") and there are a different number of
layers, but the test passes otherwise.

layer-compositing-reasons.js:
This test dumps the compositing reasons for all layers, directly from
the GraphicsLayer object. With RLS, the root layer has two additional
reasons: overflowScrollingTouch and rootScroller.

Bug: 781428
Change-Id: Ibc1e654474c96d2dd8dfdfc01ec52046989c30cb
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/804620
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: default avatarStefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521914}
      122fa656
    • Robert Ma's avatar
      Roll in new version of WPT tools · d5260d7b
      Robert Ma authored 
      Especially in order to get the new lint for 'web-platform.test'
(https://github.com/w3c/web-platform-tests/pull/6868)

Chromium custom patch for lint.py is modified to accompany
upstream changes.

Bug: 749879
Change-Id: Ic2fb4655441f1d0e3bccbb7742565cb55645cf8f
Reviewed-on: https://chromium-review.googlesource.com/809745
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: default avatarQuinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521913}
      d5260d7b
    • kylechar's avatar
      Use CompositorFrameSinkSupport in tests. · 8390d652
      kylechar authored 
      This CL changes FrameSinkManagerTest to use CompositorFrameSinkSupport
instead of FrameSinkManagerClient. This will allow for
FrameSinkManagerClient to be deleted in a follow up CL and
FrameSinkManagerImpls internal data structures to be cleaned up.

Also rename SurfaceManagerOrderingParamTest to
FrameSinkManagerOrderingParamTest. This wasn't updated previously.

Bug: 792192
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I0ad3f1e8f8530dccf001fe81c6c9191176dbaddf
Reviewed-on: https://chromium-review.googlesource.com/809614Reviewed-by: default avatarFady Samuel <fsamuel@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521912}
      8390d652
    • Nate Chapin's avatar
      Fix infinite recursion in css preload scanning · 785c19f3
      Nate Chapin authored 
      A self-referencing css stylesheet can attempt to preload itself reentrantly.
Ensure a HTMLResourcePreloader doesn't scan the same Resource twice.

Bug: 789198, 790940, 790945
Change-Id: I5a5ca56e3c12978c4a8b7fcbba79ae2a772671f8
Reviewed-on: https://chromium-review.googlesource.com/804496Reviewed-by: default avatarCharlie Harrison <csharrison@chromium.org>
Reviewed-by: default avatarHiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: default avatarKouhei Ueno <kouhei@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521911}
      785c19f3
    • Sergei Datsenko's avatar
      Headless render tests. · e9d88424
      Sergei Datsenko authored 
      Test redirects with PUT.
Test redirect URL edgecases.

Bug: chromium:787197
Change-Id: I663516828741282f3a6364d71a4fc822a3814045
Reviewed-on: https://chromium-review.googlesource.com/804713
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Reviewed-by: default avatarAlex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521910}
      e9d88424
    • David Tseng's avatar
      Utilize focus recovery in more code paths · ec018e32
      David Tseng authored 
      1. alt+left/right

Chrome only fires focus events in this case. This change tries to
recover focus whenever a focus event gets fired on a root web area. The
challenge here is the root node gets re-used. Explicit tracking of the
docurl gets introduced as a result.

Forum discussion:
https://groups.google.com/forum/#!topic/axs-chrome-discuss/u9gcqZxDISM

2. toggle on ChromeVox

In this case, ChromeVox tries to always recover focus. Detected by
checking there is no |currentRange|.

3. ctrl+r

In this case, ChromeVox receives a load complete. Only recover if the
|focus| is not already inside of the page (i.e. |focus| is the top level
root).

restores its range appropriately.

Test: exercise each of the above examples; verify that ChromeVox
Bug: 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I6e427105555b2663dca1100a02b8eb6b00cdc08a
Reviewed-on: https://chromium-review.googlesource.com/806759
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521909}
      ec018e32
    • Ryan Landay's avatar
      Refactor TypingCommand.cpp's GetSelectionOffsets() to take SelectionInDOMTree · 174f0b5e
      Ryan Landay authored 
      It came up in review of
be able to call TypingCommand.cpp's GetSelectionOffsets() method on an arbitrary
SelectionInDOMTree (currently the method takes a LocalFrame and returns the
offsets for the frame's current selection), so I am making that change in this
CL.

https: //chromium-review.googlesource.com/c/chromium/src/+/801979 that we want to
Change-Id: I2e0d580a17819ea7136cd973de6a3aa4685dae9c
Reviewed-on: https://chromium-review.googlesource.com/804416Reviewed-by: default avatarYoichi Osato <yoichio@chromium.org>
Reviewed-by: default avataryosin (OOO Dec 11 to Jan 8) <yosin@chromium.org>
Reviewed-by: default avatarXiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521908}
      174f0b5e
    • Charlie Reis's avatar
      Revert "Move site_isolation_policy from content/common to content/browser." · a2e1ab5c
      Charlie Reis authored 
      This reverts commit 1aed2aaf.

Reason for revert: Causing merge conflicts on a CL that needs to be merged.  (See https://crbug.com/786505.)  Can land again afterward.

Original change's description:
> Move site_isolation_policy from content/common to content/browser.
> 
> The move allows returning
> ContentBrowserClient::GetOriginsRequiringDedicatedProcess from
> SiteIsolationPolicy::GetIsolatedOrigins.
> 
> No expected behavior change.
> 
> Bug: 792162
> Change-Id: Idd79fbddf138c2043ff1811a2d3d58165bcb198b
> Reviewed-on: https://chromium-review.googlesource.com/794303
> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521893}

TBR=alexmos@chromium.org,lukasza@chromium.org

Change-Id: I419b78c56adb2126eb93367e29bc569a004308f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 792162
Reviewed-on: https://chromium-review.googlesource.com/810012Reviewed-by: default avatarCharlie Reis <creis@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521907}
      a2e1ab5c
  3. 05 Dec, 2017 17 commits