- 05 Nov, 2020 40 commits
-
-
Friedrich [CET] authored
This reverts commit 5c7c88d7. Reason for revert: Most-likely suspect for CrOS compile failure: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/42591 Log: [5898/61571] ACTION //ui/file_manager/file_manager/test:create_test_main(//build/toolchain/linux:clang_x64) FAILED: gen/ui/file_manager/file_manager/test.html /b/s/w/ir/cipd_bin_packages/cpython/bin/python ../../ui/file_manager/file_manager/test/scripts/create_test_main.py --output=gen/ui/file_manager/file_manager/test.html Traceback (most recent call last): File "../../ui/file_manager/file_manager/test/scripts/create_test_main.py", line 144, in <module> write(GEN + R_GEN + colors, open(GEN + '../../' + colors).read()) IOError: [Errno 2] No such file or directory: '/b/s/w/ir/cache/builder/src/out/Release/gen/ui/file_manager/file_manager/../../chromeos/colors/cros_colors.generated.css' Original change's description: > Nearby Share: Consolidate and autogenerate grd files > > Bug: 1132403 > Change-Id: I809b1a97e43457b92ac67fde208b200bfbf37d58 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507400 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#824322} TBR=avi@chromium.org,dpapad@chromium.org,rbpotter@chromium.org Change-Id: I275146470b9fc70dbff9203ee8f951eda7e624d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1132403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517734Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#824345}
-
Yoshifumi Inoue authored
This patch Introduces |CachedTextInputInfo| class to cache text content and text offsets of selection and IME composition to avoid redundant calculation of them for improving responsiveness. Background: Browser process calls |InputMethodController::TextInputInfo()| for every frame (16ms) and |GetSelectionOffsets()| for every selection changes. Without caching |TextInputInfo|, these functions do text serializing root editable element or document body for every time even if layout tree isn't changed. Note: |testRunner| doesn't call |GetSelectionOffsets()| because it is called in |RenderFrameImpl::SyncSelectionIfRequired()| and |testRunner| doesn't use it. Note: Speed of |TextInputInfo()| doesn't appeared in performance test, because it is called in |WidgetBase::WillBeginMainFrame()|. So repeated call of |selection.modify()| in JavaScript doesn't call it. Bug: 875155, 892513 Change-Id: Ib7de3849fd94af88db743806e6f8b1624cd944bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505348 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824344}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604534391-0b66c67528d135f745546f739dea18f4b7b0777d.profdata to chrome-mac-master-1604555639-6427f288759af11a05c7facb538fa5f1c7c3ab83.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4fd0accfae2715b13c231773ade3f22ecf70ae64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520305Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824343}
-
Kent Tamura authored
This CL converts DEFINE_LAYOUT_OBJECT_TYPE_CASTS() to DowncastTraits<> for: - LayoutCustomScrollbarPart - LayoutEmbeddedContent - LayoutEmbeddedObject - LayoutHTMLCanvas - LayoutImage - LayoutReplaced This CL has no behavior changes. Bug: 891908 Change-Id: I88c9317b2ea55e682b657c32016d0cd89eda8dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519683 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Alessio Bazzica authored
The new histogram is used to keep track of how frequently APM runtime settings cannot be successfully enqueued. Used in https://webrtc-review.googlesource.com/c/src/+/190144 Bug: webrtc:9138 Change-Id: Ib2e67e2287f3e9d642db9712ddd829a14c2bd7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495180Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#824341}
-
Sigurd Schneider authored
DevTools CL: https://crrev.com/c/2123048 Bug: chromium:945786 Change-Id: I16c63ba8ebc23a70ae42cc31c5a33da247a7aa9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518059Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#824340}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2876f93d9628..d631a67cc8c7 2020-11-05 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1b62c6d11ec212a1e5a14dd310119b6ddeb98040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520522Reviewed-by:
-
Alex Rudenko authored
This CL fixes the memory usage regression (crbug/1144454) by creating the instances for unsupported_image_mime_types only when DevTools is enabled and some image types are disabled. Measurement: memory:chrome:all_processes:reported_by_chrome:blink_gc:effective_size Pinpoint job: https://pinpoint-dot-chromeperf.appspot.com/job/13be0a31520000 Fixed: 1144454 Bug: 1130556 Change-Id: Iac9472238ca3e05c393c0b6fbd62596e5148a5b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515403Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#824338}
-
Yuki Shiino authored
As a first step of IDL union implementation, implements mostly- empty code generation of IDL union bindings. Bug: 839389 Change-Id: Ia15933cfa57cd8e2f6cc5e93870ba18316dbbc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512329Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#824337}
-
Anne Lim authored
This will prevent running into the DCHECK for empty accountId in ConvertToJavaCoreAccountId. Bug: 1135847 Change-Id: Ibaca940288f54963bc582deee5b9eb88e2122c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518159Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#824336}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/906501df4f0c..8cdba3e3fae3 2020-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 6372a56f3a15 to 1e494cae8d48 (7 revisions) 2020-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from db8766bb239b to 6564890116fd (6 revisions) 2020-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 1f9589cf to e1d559cf (402 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Test: Test: Test: dEQP-GLES31.functional.copy_image.* Change-Id: Ib7a558ad9f0522a7f15da178222e856818fcecf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520303Reviewed-by:
-
Chris Hall authored
We are aiming for feature launch in M89. Change-Id: I592d5f4fadb095c38870d46dfcf48d3206b8c4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515803Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#824334}
-
Nidhi Jaju authored
In an effort to change the blink implementation of readable streams to better match the Web IDL descriptions in the Streams API Standard, this CL adds the ReadableStreamGerReaderOptions dictionary [1] to the ReadableStream class. This allows us to remove GetReaderValidateOptions() as well, which makes the code simpler. [1] https://streams.spec.whatwg.org/#dictdef-readablestreamgetreaderoptions Bug: 1093862 Change-Id: I6539e6da1434c2258832e3000b2015818849a0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517214 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This reverts commit 94863f6a. Reason for revert: https://crrev.com/c/2518615 fixed the previous issue. Original change's description: > Revert "[DEPS] update luci-go" > > This reverts commit 1585878b. > > Reason for revert: > https://crbug.com/1144638 > https://crbug.com/webrtc/12126 > > Original change's description: > > [DEPS] update luci-go > > > > Bug: 1142713 > > Change-Id: Id330d0c9a0e225e5fbf8ae12abeb6b8d55f46262 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507246 > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > > Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822547} > > TBR=yyanagisawa@google.com,tikuta@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1142713, 1144638, webrtc:12126 > Change-Id: Ie06d7c40065630f28ac44fe6f2dac82f91e64da1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517405 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823859} TBR=yyanagisawa@google.com,tikuta@chromium.org,mbonadei@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142713 Bug: 1144638 Bug: webrtc:12126 Change-Id: I3cdb4d01a5d603b95d03b93b8dd43d81a84f7a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519179 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#824332}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6a60bc208a04bbcf596c6c50d6480e91302dc6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520405Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |NGCaretPosition::ToPositionInDOMTreeWithAffinity()| to avoid crash regarding null |NGOffsetMapping|. Note: This is speculative change because we don't have reproducible test case yet. Bug: 1145514 Change-Id: I8935175d721e6cc678efcb1f8c52d33275197143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519544 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Avi Drissman authored
New macOS capabilities, more utilities in Chromium. Bug: 1145672, 1145792, 1142017 Change-Id: Ibd10501429aba40aacb4db7c751385428115941d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518258 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#824329}
-
Mikel Astiz authored
These new metrics can be derived from existing metrics but simplify the analysis, in line with the general guidance by the metrics team. Change-Id: Ic0f1c59a590dbb9be43b5ee45f37a808b352cca9 Bug: 1068378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517681Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#824328}
-
Alexey Baskakov authored
This CL introduces no behavior changes. WebAppProvider class must not depend on extensions, only forward declarations are visible. All extensions-specific code and includes have been isolated in chrome/browser/web_applications/extensions/bookmark_app_provider.cc file. In long term, the whole chrome/browser/web_applications/extensions/ code directory must be deleted (see README.md in that folder) This is a preparation CL to delete web_applications_on_extensions GN source set. TBR=ccameron@chromium.org Bug: 1065748 Change-Id: I7fa1306694e80dbda8aab7159a075919ec2c42b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517233Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#824327}
-
Alexey Baskakov authored
This CL introduces no behavior changes. chrome/browser/web_applications/web_app_migration_user_display_mode_clean_up.h must not depend on extensions, only forward declarations are visible. This is a preparation CL to remove web_applications_on_extensions GN node. WebAppProvider will be moved from web_applications_on_extensions to general web_applications GN node. Bug: 1065748 Change-Id: I4a67398ad7db8107010d4b7cd165657fe1e64ba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517190Reviewed-by:
-
Shik Chen authored
Bug: b:172346047 Test: Pass Closure Compiler checks. Change-Id: I79ee47ee084149f4168978307af3c75cbade29f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515868 Commit-Queue: Shik Chen <shik@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#824325}
-
Xiaocheng Hu authored
Bug: 1145406 Change-Id: I2bcc50fe3c6799586643750e7c655be0cac979dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519860 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#824324}
-
Darren Shen authored
FinishComposingText saves the old selection in order to reapply it after the composition is finished. However, it needs to also maintain the direction (the order of base vs. extent), or else a backward selection will be restored as a forward selection after calling FinishComposingText. Bug: 1145727, b/172284191 Change-Id: Ie1e8ef69fcabcb11aebbbc5003e044f70e6535d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518309 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824323}
-
rbpotter authored
Bug: 1132403 Change-Id: I809b1a97e43457b92ac67fde208b200bfbf37d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507400 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#824322}
-
Hitoshi Yoshida authored
If we enable same-site backward/forward cache, backward navigation does not trigger onload event. This CL updates a WPT that depends on the onload event to handle pageshow event and makes it work with backward/forward cache. Bug: 1132180 Change-Id: I663f9c78e8b9835f081c5262b446bd56dba07cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520558Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#824321}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/431aae870034..1d09ab6b6ebf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jshikaram@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1142017 Tbr: jshikaram@google.com Change-Id: I5d632786909f83ce3878e6b65cfaa4cbfff8417d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520327Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#824320}
-
My Nguyen authored
Proposal: http://go/cros-input-methods-naming Proposed names: http://go/cros-input-methods column C Screenshot view: http://screen/6WExfJ6Fz87xiWv Bug: 889763 Change-Id: If0831adeae13f8cc47280bfb1fd117f857622db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518521 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#824319}
-
Ramin Halavati authored
A few commands are updated in browser command controller for ephemeral Guest profiles and the tests are updated to cover both old (OTR) Guest profiles and the new ephemeral ones. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: Ifa4890dab8d971aada471fca0a03861ca14c5e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517588Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#824318}
-
Wei Lee authored
Since we changed the url of CCA to: chrome://camera-app/views/main.html instead of chrome://camera-app/src/views/main.html This CL fixes the consistent parts regarding to the app id. Bug: 980846 Test: None Change-Id: I21bd97639bf44383e31147e42c98fd4ac2d3aea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519681Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#824317}
-
Koji Ishii authored
When painting and hit-testing NG fragments, |NGBoxFragmentPainter| falls back to |LayoutObject| at the BFC boundary, because we already have a logic in |LayoutObject| to switch painters for NG and legacy. This patch changes to do so only when |!CanTraverse|, because |LayoutObject| cannot handle block fragmented NG objects. This patch eliminates |CurrentFragment| from |LayoutNGBlockFlowMixin::Paint| by making sure it is not block fragmented. Also changes |HitTestChildBoxFragment| so that it can handle atomically-painted objects in NG code path. Due to the change in |FragmentRequiresLegacyFallback|, such objects go to NG code path without going through |LayoutObject|. Bug: 1061423, 829028 Change-Id: Ife31d6dcd209668a489243b1158112dac44fc273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515429 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#824316}
-
Solomon Kinard authored
In Manifest V3, extensions will have finer grained control over web-accessible resources, with the ability to restrict embedding to specific URL patterns or extension IDs. This CL introduces the parsing for a new format in the manifest.json to support taking a list of objects, rather than a list of strings: "web_accessible_resources": [ { “resources”: [“file.gif”], “matches”: [*://*.chromium.org/*], “extension_ids”: [“abcdefghijklmnopabcdefghijklmnop”] } ] This CL only parses and stores matches and ids alongside resources. Permission checking based on those two fields to be done subsequently. Bug: 1133624 Change-Id: Ice0374d4de433d23700a6c7b03ff3d76cd0bd9fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439795 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#824315}
-
David authored
JS crash reports may occur from a regular tab, app window or SWA window. This is not currently logged. Logging this will help us track down a potential race condition where a SWA url may not be recognised which may be the root cause of b/162791595. A note about tests: It is a little weird getting tests to work for window type as we can't grant a |WebContent| permissions to use |CrashReportPrivate| on the fly. This cl works around that by opening the target window window type, then navigating a url that has access to |CrashReportPrivate|. Bug: b/162791595, b/169635499 Change-Id: I358a380b6742bd44f56a5a46f51182b9df26c693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489123 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
dstockwell <dstockwell@google.com> Auto-Submit: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#824314}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68dcf542b79f..906501df4f0c 2020-11-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 31e28d20f878 to ad54c71632cc (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: bsalomon@google.com Change-Id: I388344849626dbcf7dcd855193dc6d88a7892f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520020Reviewed-by:
-
David Black authored
Currently HoldingSpaceTrayIcon is updating preferred size when shelf alignment changes. This is desired behavior when the content forward entry point is enabled, but this is *not* desired behavior when the content forward entry point is disabled. Bug: 1142572 Change-Id: I6ae728cf9968af87934d694a51b293ae64e7e8ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520380Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#824312}
-
Maksim Sisov authored
All the tests except DesktopWidgetTest.MinimumSizeConstraints pass without any modifications. The DesktopWidgetTest.MinimumSizeConstraints required providing minimum size during the call to WidgetTest::GetNativeWidgetMinimumContentSize. Bug: 1001075, 1109114 Change-Id: I4bc0b76d39f981694441d9d0e78d58d4cc5345d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444312Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8ca189d4e5b8..b503f5ff6b58 2020-11-05 chanli@chromium.org move the cipd pin of infra/tools/rdb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1137513 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I468f8d6f80d9f325f15a085ea890c1063dbd4634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520446Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I09cb40756590ec1facae3af2c10a45c376dd027c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520438 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/33001e2632db..8532ef05056c 2020-11-04 nigi@chromium.org Move the Noto font file for testing to top-level third-party directory. 2020-11-04 tsepez@chromium.org Remove some calls to CFXJSE_Value::ForceSetValue() 2020-11-04 tsepez@chromium.org Remove arg from CFXJSE_Value's constructor. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I18e5f208686300d789d283c854c3bc0964abb491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520442Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/658ede5d8c5c..1e494cae8d48 2020-11-05 b.schade@samsung.com Vulkan: Add support for EXT_copy_image If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Test: Test: dEQP-GLES31.functional.copy_image.* Change-Id: Ic4c267655ff66f279b9aff43924dac3592116afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520326Reviewed-by:
-
Yuzu Saijo authored
This CL creates a new task type kNetworkingUnfreezable that is passed to URLLoaderClientImpl, so that the loading tasks keep running when the context is frozen. This CL also plumbs this unfreezable task runner to URLLoader. At the moment URLLoader uses only freezable task runner, but as we support the network requests handling for frozen pages, we will start using unfreezable task runner, and in the end state we will only have unfreezable task runner for URLLoader. This task type is guarded with loading-tasks-unfreezable flag. Without the flag, this task type is freezable and the loading tasks are freezable as they used to be. Bug: 1137682 Change-Id: I131e8682d1f018ece9c2ab91bdc480be8007d495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465441 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
![Friedrich [CET]'s avatar](https://secure.gravatar.com/avatar/f27b033ce4cd5371e6e413eed6db870f?s=80&d=identicon "Friedrich [CET]")
