- 20 Jun, 2018 40 commits
-
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I36e2f8319ff878d53ede39aace6419eebdf4bd3a Reviewed-on: https://chromium-review.googlesource.com/1107282Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#568709}
-
Esmael El-Moslimany authored
Bug: 854081 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib73d38ea25ca0ea70e3322b1e5066cd6a2b5ded9 Reviewed-on: https://chromium-review.googlesource.com/1106421Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#568708}
-
Victor Costan authored
Bug: 729800 Change-Id: I194f3f4b86794236cc90fbc8614b1da680c8aaa6 Reviewed-on: https://chromium-review.googlesource.com/1107315Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#568707}
-
Martin Kreichgauer authored
This moves the responsibility of generating the CredentialMetadata 'secret' parameter (formely profile_id) into the AuthenticatorRequestDelegate. CredentialMetadata uses the parameter to derive the HMAC and AEAD keys for encrypting/encoding credential metadata before storing it in the macOS keychain. For Chrome, implement profile-specific secrets by storing the value in the browser profile PrefService. This guarantees that credentials will be logically separated by user profile. Bug: 678128 Change-Id: I8c3d12c6db266105eeb63191e9d277d8cdb173ee Reviewed-on: https://chromium-review.googlesource.com/1102179 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#568706}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/208cf41c691b..7c2b573628be Created with: gclient setdep -r src-internal@7c2b573628be The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:835029 TBR=mmoss@chromium.org Change-Id: I6bba577918f109d3f88ca8dfc4315fd17ca0b740 Reviewed-on: https://chromium-review.googlesource.com/1107138Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568705}
-
Ahmed Fakhry authored
When a Chromebook is flipped into tablet mode, scrolling and gesture fling events should follow the same curve used by android in order to have a smoother and more fluid experience. BUG=813911,822455 Change-Id: I39b42bdda08a3c20e1b7fab4d8f7e41c2a69b61a Reviewed-on: https://chromium-review.googlesource.com/1087641Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#568704}
-
Miguel Casas authored
crrev.com/c/1100535 landed a DCHECK that does not verify from ARC++, [1814:1814:0619/160631.868318:FATAL:vaapi_picture_factory.cc(48)] Check failed: picture_buffer.texture_target() == GetGLTextureTarget() (0 vs. 36197) #0 0x59c50521b4dc base::debug::StackTrace::StackTrace() #1 0x59c50518f620 logging::LogMessage::~LogMessage() #2 0x59c5026cc721 media::VaapiPictureFactory::Create() #3 0x59c5026d2a94 media::VaapiVideoDecodeAccelerator::AssignPictureBuffers() #4 0x59c506967623 arc::GpuArcVideoDecodeAccelerator::AssignPictureBuffers() #5 0x59c50269c433 arc::mojom::VideoDecodeAcceleratorStubDispatch::Accept() ... This CL corrects it. Bug: 822346 Test: YT App playing back correctly with dcheck_always_on=true on nautilus. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icff42847518df24dcc38998acdc2903e7928469f Reviewed-on: https://chromium-review.googlesource.com/1106670Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#568703}
-
Nigel Tao authored
See https://bugs.chromium.org/p/chromium/issues/detail?id=613096#c5 for rationale These two files: third_party/closure_compiler/externs/accessibility_private.js third_party/closure_compiler/externs/autofill_private.js were updated in this commit, as an example of the change. A follow-up commit will update other *_private.js files. Bug: 613096 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ica4ab471956052b37c8bb6a9aabe4a7502408cfb Reviewed-on: https://chromium-review.googlesource.com/1090425 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568702}
-
Clark DuVall authored
This should ensure the delete tasks get run. Bug: 854032 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I73304bee8ee59e3e30ecb060cd3288c2630c8191 Reviewed-on: https://chromium-review.googlesource.com/1106479Reviewed-by:
-
Sebastien Marchand authored
Note that the only two production uses of this function are in restoring this value either from (a) a session restored tab or (b) a discarded tab. This formalizes the "set on creation" nature of the property. It also means that it is available immediately when a session restored contents is added to a tab strip, rather than only afterwards, which simplifies some tab manager code. Change-Id: I2ee17ac809a5ad834e7207eee101f167512d9737 Reviewed-on: https://chromium-review.googlesource.com/1103317Reviewed-by:
-
Varun Khaneja authored
R=gayane Change-Id: Ia43fcdad17628e63397ffa735da6d7439fd0baad Reviewed-on: https://chromium-review.googlesource.com/1107133Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#568699}
-
Peter Collingbourne authored
It looks like every client of this code is passing in a delegate, so we can simplify it a little by removing the if checks. Change-Id: Ie32edc629117d9c204482d518f13c7beb5bf1cf7 Reviewed-on: https://chromium-review.googlesource.com/1106801Reviewed-by:
-
bsheedy authored
Adds expectations for Pixel 2 and Pixel 2 XL devices in WebVrDeviceTest#testDeviceCapabilitiesMatchExpectations. Not a big deal since we currently don't run automated tests on Pixel 2 devices, but this should prevent local testing from having a few constantly failing test cases. TBR=bajones@chromium.org Change-Id: I4cc1cfc0a8e74347274db4403e46b27bb0bf95d4 Reviewed-on: https://chromium-review.googlesource.com/1107271Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568697}
-
Kent Tamura authored
heap_page.h is used in 6,000+ compilation units, and this CL reduces its estimated expanded size from 1.72MB to 1.40MB. This CL relands https://chromium-review.googlesource.com/1104080 . With the original code, GetRandomMagic() was folded into GetMagic(), and GetMagic() was not folded into IsValid(). With https://chromium-review.googlesource.com/1104080, ComputeRandomMagic() was not folded into GetMagic(), and GeMagic() and IsValid() were folded into IsValid() callsites. So the binary size increased. With this CL, GetMagic() isn't folded into IsValid() like the original code. So this CL won't increase the binary size, and should not have performance regression. Bug: 242216 Change-Id: I7b6cf78a454abbbf3a3e41d821ac23e208b6dbdb Reviewed-on: https://chromium-review.googlesource.com/1105208Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#568696}
-
Lindsay Pasricha authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5953a6d5c0256bcf37cc8038effb7f7ca65f2a55 Reviewed-on: https://chromium-review.googlesource.com/1107280Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568695}
-
Klaus Weidner authored
This fence is used to measure render time in VR Browsing mode. Replacing the gpu_fence_ member after GVR Submit has a race condition - GVR internally creates a fence when submitting and blocks the next Submit until the previous submitted frame's fence is complete, but the separate render time fence was created after submitting, so we may end up with a situation where this second fence hasn't registered as complete yet. Update the order to create the new fence first in a locally scoped variable before GVR submit, then overwrite the previous fence only after GVR submit completes. BUG=854347 Change-Id: I8359f67859016039b2ddf5d54d5f391c5e212918 Reviewed-on: https://chromium-review.googlesource.com/1107013Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#568694}
-
stkhapugin@chromium.org authored
Updates fonts, spaces, colors in omnibox-related code to match the new specs. Bug: 852787 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibe22b985011ce7ed3da9f83291f293e3942728c4 Reviewed-on: https://chromium-review.googlesource.com/1101026Reviewed-by:
-
Daniel Murphy authored
A namespace could be purged between creation and being bound to, so this removes purging of namespaces to prevent that. When in the FETCHING_METADATA state, RunWhenConnected would run run callbacks in an infinite loop. This removes that state. R=mek@chromium.org Bug: 854102, 848651, 854359 Change-Id: I0fe09caa251ed29bed279c66578cfbaec08da13d Reviewed-on: https://chromium-review.googlesource.com/1106806 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Kinuko Yasuda authored
- Make sure we're on the right thread - Make sure SaveSubresourceFactories() is called only when non-null subresource factories is created (when NetworkService is enabled) Bug: 849929 Change-Id: I53456bd67f10309940e89eab58c163173597611e Reviewed-on: https://chromium-review.googlesource.com/1104083 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#568691}
-
Shimi Zhang authored
In preparing for http://crrev/c/1102157, make it easier for us to handle the behavior change. Bug: 847192 Change-Id: I0f67b894e38737339efa2aafe3093324876f5368 Reviewed-on: https://chromium-review.googlesource.com/1106598 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#568690}
-
Jared Saul authored
Bug was introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1083880 Bug: 854428 Change-Id: Id33c4c21595becfff4664b1bce24aa6e1eb81fa4 Reviewed-on: https://chromium-review.googlesource.com/1107266 Commit-Queue: Jared Saul <jsaul@google.com> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#568689}
-
Mathieu Perreault authored
Bug: 854124 Change-Id: I6ea086eff680f1085f1bbd3125bf994c3c7d3d96 Reviewed-on: https://chromium-review.googlesource.com/1106603Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#568688}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f704817cbbab..f153b902bec3 git log f704817cbbab..f153b902bec3 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 nednguyen@google.com Asserting that all story names are unique within a story set Created with: gclient setdep -r src/third_party/catapult@f153b902bec3 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:849363 TBR=sullivan@chromium.org Change-Id: Ie0d420fb2e9671476f55565d8870da4d413a9379 Reviewed-on: https://chromium-review.googlesource.com/1107177Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568687}
-
Justin Donnelly authored
The search and bookmark icons are the same as was already being used for Touchable. The "page" icon is now a globe, which will be used for MD Refresh (standard and touch) but not non-Refresh touch. The colors will be updated in a future CL that addresses both icon color and row highlight color. Bug: 846407 Change-Id: Ieb9d020bfe27d6610694fd8c773ef1934e9d8c36 Reviewed-on: https://chromium-review.googlesource.com/1104874 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#568686}
-
Scott Violet authored
To make things easier AshWindowTreeHostPlatform also creates an InputMethodMus. This way the right driver/registrar code is used. BUG=837686 TEST=covered by tests Change-Id: I82142be913f5a4a8ae1a368bea6b8579de8b251c Reviewed-on: https://chromium-review.googlesource.com/1107007 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568685}
-
Owen Min authored
Bug: 853364 Change-Id: I319156aaae497b6900781ec20e212aa9c5ee2aa7 Reviewed-on: https://chromium-review.googlesource.com/1106601Reviewed-by:
Marc-André Decoste <mad@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568684}
-
Dave Schuyler authored
This CL fixes some comment typos. Along the way, so other style changes are made. There are no logic changes in this CL. Bug: None Change-Id: Ib23f1e3964b45dddf81f0c14c1136f8a83c4c300 Reviewed-on: https://chromium-review.googlesource.com/1105480 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#568683}
-
Qingsi Wang authored
the remoting client plugin. WebRTC will use the metrics macros in webrtc/system_wrappers/include/metrics.h to log all metrics that are currently recorded by MetricsObserverInterface. Bug: None Change-Id: I3bdddbaf436c461a07bbd91ff763bb9351516253 Reviewed-on: https://chromium-review.googlesource.com/1107255Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Qingsi Wang <qingsi@google.com> Cr-Commit-Position: refs/heads/master@{#568682}
-
Maggie Chen authored
Don't fallback to BGRA swap chain if DWM fails to promote video to hardware overlay to make it easier to debug protected video playback. Reassess perf/ power impact later to see if falling back to BGRA is necessary. BUG=850799,843814 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5222214b0dd11c6c1c922cc1c6904e2ded816086 Reviewed-on: https://chromium-review.googlesource.com/1107099 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#568681}
-
David Black authored
This involved adding a settings button to both the keyboard and voice input modality child layouts of DialogPlate. I used two distinct views, rather than a single view, to represent settings button to keep the layout logic as simple as possible. See bug for demo. Bug: b:110263671 Change-Id: I6caf1cb3c79cd789b0598cdc3771090b187cb634 Reviewed-on: https://chromium-review.googlesource.com/1103153 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/790da37b72f9..66cadcc6b924 git log 790da37b72f9..66cadcc6b924 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 danilchap@webrtc.org Replace rtc::Optional with absl::optional in pc 2018-06-19 buildbot@webrtc.org Roll chromium_revision c27ef6f9..6e14efc1 (568443:568572) 2018-06-19 deadbeef@webrtc.org Return SSRC stats with the old stats API when SSRCs are unsignaled. 2018-06-19 philipel@webrtc.org Clean up in module_common_types.h by removing the unused struct RTPAudioHeader. 2018-06-19 nisse@webrtc.org Add setter method EncodedFrame::SetTimestamp. 2018-06-19 buildbot@webrtc.org Roll chromium_revision 9d565db4..c27ef6f9 (568343:568443) 2018-06-19 phensman@webrtc.org Add separate native library for instrumentationtests 2018-06-19 danilchap@webrtc.org Add Parsing/Building generic frame descriptor extension 2018-06-19 nisse@webrtc.org Add nisse@ as owner of api/video/ 2018-06-19 yvesg@webrtc.org Reformat the WebRTC code base 2018-06-19 danilchap@webrtc.org Replace rtc::Optional with absl::optional in modules/audio_coding 2018-06-19 gustaf@webrtc.org AEC3: Unittests for MovingAverage 2018-06-19 nisse@webrtc.org Drop tools/gyp from dependencies 2018-06-19 aleloi@webrtc.org Cover AecDump calls in APM fuzzer. 2018-06-19 gustaf@webrtc.org AEC3: Average the spectrum of multiple nearend frames in the suppressor. 2018-06-19 nisse@webrtc.org Delete picture id and tl0 index from CodecSpecificInfo. 2018-06-19 danilchap@webrtc.org Replace rtc::Optional with absl::optional in modules/audio processing 2018-06-19 magjed@webrtc.org Android: Simlify createOesTextureBuffer() in VideoFrameBufferTest 2018-06-19 aleloi@webrtc.org Always enable 'delay-agnostic' in APM fuzzer. Created with: gclient setdep -r src/third_party/webrtc@66cadcc6b924 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:none,chromium:None,chromium:None,chromium:853699,chromium:853699,chromium:824638 webrtc:9423 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0aa4269fd97a57bb9c4e5e326670ff92848c8d82 Reviewed-on: https://chromium-review.googlesource.com/1107178 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568679}
-
weiliangc authored
This reverts commit dfd53f11. Reason for revert: GPU FYI Windows bots compile failure crbug.com/854442 Compile error: [40824/45748] LINK task_viewer.service.exe task_viewer.service.exe.pdb FAILED: task_viewer.service.exe task_viewer.service.exe.pdb C:/b/swarming/w/ir/cache/vpython/80ee9f/Scripts/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./task_viewer.service.exe /PDB:./task_viewer.service.exe.pdb @./task_viewer.service.exe.rsp C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??0InitParams@AuraInit@views@@QEAA@XZ >>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ) C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??1InitParams@AuraInit@views@@QEAA@XZ >>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ) Original change's description: > Add InitParams for views::AuraInit > > It's up to 7 parameters and I'm about to add an 8th. > > Bug: 851578 > Test: existing tests > Change-Id: I5dbfb98c90861a334ef9046cec4d69fb756879a1 > Reviewed-on: https://chromium-review.googlesource.com/1106431 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: James Cook <jamescook@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568594} TBR=jamescook@chromium.org,sky@chromium.org Change-Id: Iea7d59178394a95cbc6f419cd7079d00d66a8ac6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851578, 854442 Reviewed-on: https://chromium-review.googlesource.com/1107139Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568678}
-
Nigel Tao authored
This is a reland of 82a1baac Compared to the original: No changes, other than https://chromium-review.googlesource.com/c/chromium/src/+/1100661 "Delete spurious js_type_check BUILD.gn target" landed. Original change's description: > Centralize externs_list BUILD.gn declarations > > The externs_list is used by the Closure compiler, to type check imported > terms like 'chrome.fileManagerPrivate.foo', and to ensure that when > minimizing JS code from 'foo.bar.baz()' to 'a.b.c()', well known names > like 'chrome' aren't minimized. > > However, the files_manager app does not ship Closure-compiled code in > production. It ships uncompiled code - the .js files as written by the > programmer. Instead, the externs_list is used indirectly by the > js_type_check("closure_compile") rules as a lint-style check. > > Prior to this CL, maintaining the externs_list was therefore ad hoc and > indirect. For example, the hand-written and hand-maintained BUILD.gn > files would contain rules like: > > js_library("foo") { > deps = [ > "../../common/js:elephant", > "../../common/js:giraffe", > ] > externs_list = [ > "../../../externs/apple.js", > "../../../externs/banana.js", > ] > } > > where foo.js might not refer to externs/apple.js any longer, and it > might actually depend on externs/pear.js that is only coincidentally > satisfied because common/js/giraffe.js happens to list externs/pear.js > on its externs_list. This might be true at any particular point in time, > but as new code is added, and as existing code is refactored, the > externs_list entries become stale. > > After this CL, each js_type_check("closure_compile") target has an > associated js_library("closure_compile_externs") BUILD.gn target. This > gives exactly one place to list all the external dependencies of every > Closure compilation target. > > Future commits may re-organize the very fine grained (only 1 .js file > per js_library BUILD.gn target) js_library targets into larger units, > and in doing so, push duplicated externs_list entries from the leaves of > the BUILD.gn dependency tree towards the root. This could arguably help > us move towards shipping Closure compiled JS instead of hand-written JS. > But the first step is to get a handle on the dependencies (i.e. > externs_list entries) in the first place. > > Test: "ninja ui/file_manager:closure_compile" runs without error > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I1a3b029b5223db12abd38077d56914ad9d28a396 > Reviewed-on: https://chromium-review.googlesource.com/1092399 > Reviewed-by: calamity <calamity@chromium.org> > Reviewed-by: Sasha Morrissey <sashab@chromium.org> > Commit-Queue: Nigel Tao <nigeltao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567072} Change-Id: I3a89e0c722840535f40c35bfbdfc69236139e0ec Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1100615 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#568677}
-
Ben Smith authored
WebAssembly threads implicitly enables SharedArrayBuffer (--enable-shared-array-buffer) and structured cloning WebAssembly.Module (--enable-webassembly). Bug: 852756 Change-Id: I89d04cf08f1ff8cb777cf67f794d0f88049b6443 Reviewed-on: https://chromium-review.googlesource.com/1105558 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568676}
-
Thomas Anderson authored
This reverts commit 43a48785. Reason for revert: This CL made the assumption that we didn't ship in any configurations that are instrumented or that are component builds. However bug 853266 points out that CrOs ships in an asan configuration, so the rpath removal will still be necessary until the change in [1] is made. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=850682#c14 Original change's description: > Stop removing rpath_for_built_shared_libraries from chrome_sandbox > > For instrumented builds like tsan, this causes chrome_sandbox to reference the > wrong libc++.so due to a missing RPATH. > > Since all configurations we ship don't set RPATH, we don't have to worry about > security vulnerabilities introduced by RPATH=$ORIGIN. There's also a check to > enforce this in chrome/installer/linux/common/installer.include. > > BUG=850682 > > Change-Id: I25307bd9de388009acffdbb8de6717210873655b > Reviewed-on: https://chromium-review.googlesource.com/1092077 > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566099} TBR=jorgelo@chromium.org,palmer@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 850682,853266 Change-Id: I4b094a512b29b76e12659cba905536118a49208c Reviewed-on: https://chromium-review.googlesource.com/1107137 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#568675}
-
Giovanni Ortuño Urquidi authored
This is the first patch to implement a policy to allow admins to remotely install Web Apps. Bug: 844278 Change-Id: Ib8ace57ddfbb004db7b612ec0c8501f162ea56ff Reviewed-on: https://chromium-review.googlesource.com/1075872Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#568674}
-
Aaron Leventhal authored
Bug: 848617 Change-Id: I42b5b23a8497912128462ce83dacfd8009ef8797 Reviewed-on: https://chromium-review.googlesource.com/1105069 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#568673}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/179059f63e9e..1cabdc464313 git log 179059f63e9e..1cabdc464313 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1cabdc464313 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I30ba4bb877d68123bd4265988dfdd78a3f0eb920 Reviewed-on: https://chromium-review.googlesource.com/1107217Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568672}
-
Frank Barchard authored
https://chromium.googlesource.com/libyuv/libyuv.git/+log/780cdfed4eb2..bc383e76d631 $ git log 780cdfed4..bc383e76d --date=short --no-merges --format='%ad %ae %s' 2018-06-15 thomasanderson Update DEPS necessary to green-up CQ bots Created with: roll-dep src/third_party/libyuv Bug: chromium:845700,libyuv:799 Change-Id: I6f5b0d56dd9c057e3a341a069e121e7b7d09b4dc Reviewed-on: https://chromium-review.googlesource.com/1106968Reviewed-by:
-
Jinsuk Kim authored
The reported bug is a corner case where the WebContents at the front when Chrome is put background, is not at the front when Chrome is back to foreground. When coming to foreground in normal flow, |OnAttachedToWindow| callback reestablishes the front WebContents' ActivityStateObserver(ViewEventSinkImpl) first, which then reacts to |onActivityResumed| callback to update the state to 'resumed' as expected. The bug happens because the WebContents, not being in the front anymore, loses the chance to receive |onActivityResumed| when Chrome gets foreground, since it is still in the state where the observer is not registered. The observer is added later when the tab is moved to the front, upon receiving |onAttachedToWindow| callback. The observer will still remain in paused state that causes inconsistency leading the the bug. This CL fixes the bug by checking activity state when registring the activity state observer, which is done when attached to window. If it is already in the 'resumed' state, it invokes |onActivityResumed| to put WebContents in the right state. In a normal flow this will make |onActivityResumed| invoked twice but it is ok - the second one will be no-op. Bug: 852336 Change-Id: I24aae020908b6a537b258c44b26e63fe5b314474 Reviewed-on: https://chromium-review.googlesource.com/1105344 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#568670}
-
