- 09 Apr, 2019 40 commits
-
-
Yue Zhang authored
Add ComponentCallbacks in TabListMediator to listen to orientation changes and change span count of GridLayoutManager accordingly. TODO: * Fix the problem of landscape Thumbnail showing incorrectly in portrait mode. * Dynamically set span count base on screen width, min width of cards and paddings. Bug: 945740 Change-Id: I961274492e35c097e6440caeaff78ae7cd7d83db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559238Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@google.com> Cr-Commit-Position: refs/heads/master@{#649319}
-
Jeffrey Kardatzke authored
This removes the restriction for including bluetooth logs in feedback reports from nocturne/eve only. It is now enabled for all boards. Bug: 872403 Test: BT logs appear in feedback report from kevin Change-Id: Ifeee8e1dc9c86fe2f3a05a34f24da0824ae344de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560254 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#649318}
-
Christian Fremerey authored
This is a reland of ca79d9d8 Reason for revert was a too strict expectation in a test case, which has been fixed here: https://chromium-review.googlesource.com/c/chromium/src/+/1559125 Original change's description: > [Tab Capture] Simplify reuse of already captured content > > Before this CL, class FrameSinkVideoCapturerImpl uses a somewhat > hard-to-follow protocol with InterprocessFramePool for resurrecting > video frames in case that the source content did not change. > > This CL changes this protocol to a simpler-to-follow mechanism, which > also can reduce the cases where content is re-captured even though > it is already available in a previously captured buffer. > > Change-Id: I635e3cf0dce61f704a6b613702791f03ff0c217a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479154 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648688} Change-Id: I07b3899b104eb78b039519791384f024bec30388 Bug: 951069 TBR=miu@chromium.org Change-Id: I07b3899b104eb78b039519791384f024bec30388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559333 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#649317}
-
Kurt Horimoto authored
The previous TestBrowser constructor took a TabModel, which required tests that require a Browser to construct complicated OCMocks to construct the TestBrowser. This CL adds a second constructor that instead takes a WebStateList, and can be used to create TestBrowsers for objects that don't use the deprecated TabModel interface. Bug: none Change-Id: I306e536621f932f8d6b4ed22d3d149de2649fda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559766 Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#649316}
-
Sébastien Séguin-Gagnon authored
Bug: 949612 Change-Id: Ibe0d0781df2398d7358ece7c657b29bbc7553c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555246 Commit-Queue: sebsg <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#649315}
-
Rohit Rao authored
This file is compiled as an EG2 test-side helper and removed from the eg_app_support+eg2 target. BUG=922813 Change-Id: Ia842d0c0feb9f662419a07e6d79761e71184e309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559383Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#649314}
-
Ian Wells authored
Adds fetching and storing of favicons to the prefetching pipeline for Feed only. Also adds snippet and attribution columns to the INSERT query in AddPageTask as this was missed in the schema update CL. NOTRY=true Bug: 841516 Change-Id: I04d0e1468ae55c7739360c040490e934efca9dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534293 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#649313}
-
John Lee authored
and enable spellcheck for all languages when spellcheck is turned on Bug: 848536 Change-Id: I99f814b559fb591f85eda6012cca94d4a1c81635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559232 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#649312}
-
Collin Baker authored
TBR=nyquist@chromium.org Bug: 951141 Change-Id: Ia3352c9de1d8fc418a46076ffa08d41594a3bce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559360Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#649311}
-
Shakti Sahu authored
After native AutoResumptionHandler is set into effect, we should be very careful that downloads long back from history shouldn't be resumed. In this CL, we are addressing that issue by setting the auto-resume count of history downloads to a max value. Change-Id: Iedb037da21c8a93e468f9c64fa1614fd0cf6c7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559454 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#649310}
-
Yann Dago authored
Add a search field to the toolbar that redirects to the settings page on each search. Bug: 948259 Change-Id: I5c81ef285fdb2f9042d5d1d843129589af428937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548137 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#649309}
-
Victor Hugo Vianna Silva authored
We unite histograms that distinguish first-time/subsequent synchronization (Sync.ServiceInitialConfigureTime,Sync.ServiceSubsequentConfigureTime) and histograms that distinguish based on the configuration result status (Sync.ConfigureTime_Long.{OK,ABORTED,UNRECOVERABLE_ERROR}) into a single set of histograms. Bug: 169053 Change-Id: I757a86e50b907edf7ace2137d9a34a34f8495dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552827 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:Brian White <bcwhite@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#649308}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de427f13cef6..6e6256a3131d Created with: gclient setdep -r src-internal@6e6256a3131d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangs@chromium.org,battre@chromium.org,collinbaker@chromium.org,tasak@chromium.org Change-Id: Icad91c8ddfd6db199fbc5680827bc25aa7dbd4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560228Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649307}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d39e2c83b730..2af5dcbe9ec3 git log d39e2c83b730..2af5dcbe9ec3 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 benwright@webrtc.org Reland "Refactor FrameDecryptorInterface::Decrypt to use new API." Created with: gclient setdep -r src/third_party/webrtc@2af5dcbe9ec3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I91d39fbef69b5551602cdbb4c154a110fc1f8917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560392Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649306}
-
Ian Prest authored
1. Added a new generated event (SUBTREE_CREATED) that is fired whenever a new node is added. 2. BrowserAccessibilityManagerWin now fires UIA structure-changed events in response to SUBTREE_CREATED (new) and CHILDREN_CHANGED (existing). 3. BrowserAccessibilityManagerWin overrides OnNode/SubtreeWillBeDeleted in order to fire "node-removed" events. -- We can't just have the event-generator add an event to its queue, because in that case the nodes have been deleted before the events get fired. -- Moved the MSAA implementation here, from UpdateStep3FireEvents; this will make it easier to move to the platform-nodes in the future. 4. UIA event-recorder now records & logs structure-changed events. -- And update existing unit-tests and event-tests were with new expectations. 5. Some events were being fired on IFRAMEs that hadn't yet been added to the tree, which would later result in crashes. -- ShouldFireEventForNode was updated to prevent this scenario. 6. We weren't checking the command-line flag prior to running some UIA specific code in response to the kEndOfTest event; fixed. Bug: 928949 Change-Id: I9f9b1bbeb522451d4c7b8046f21eb91cc8543d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539141 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#649305}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/201b3752e642..ff4fb3335bb7 git log 201b3752e642..ff4fb3335bb7 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 ethannicholas@google.com ComposeShader GPU implementations 2019-04-09 jvanverth@google.com Add RG format to Metal 2019-04-09 mtklein@google.com extract ToolUtils::colortype_depth() Created with: gclient setdep -r src/third_party/skia@ff4fb3335bb7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I8b4085d87dda9ee23a975f301e2aef2387baac23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560391Reviewed-by:
-
Hongchan Choi authored
When AudioWorklet.addModule() activates the worklet thread, it re-starts the destination handler even when the context is suspended. This CL fixes the bug by restarting destination only when the context is in the "running" state. Bug: 950997 Test: external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworklet-suspend.https.html Change-Id: I0b44e3fca23bd069fac21f709fc665e8eacc4dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560140 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#649303}
-
wutao authored
It is possible that assistant service is not available when searching in the Launcher. This patch adds the check before directing the search to Assistant. Bug: 950149 Test: manual Change-Id: I136d0a8852c49b91315724b16a51bcbdb5890047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559352 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#649302}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I40e13e96ba23ccf901d9243cd2cfab29fbe01134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560441Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#649301}
-
Lucas Tenório authored
This second batch of tests cover the LaunchHomeUrl method. One small change was made to the AppControllerService to make the tests simple: We no longer read the URL prefix during initialization, instead we do it on demand when trying to launch home URLs. This makes it easier to override the prefix when testing the same service instance. Bug: 927809 Change-Id: I5460b055f6d423cd196b3c5b4b06d723e6abfd67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558411Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#649300}
-
Corentin Wallez authored
This implements SyncTokens for the WebGPU interface by sharing implementations with the raster and gles2 interfaces. All interfaces now inherit from the abstract InterfaceBase class. BUG=chromium:948613 Change-Id: I54cde299d465bdbd7ed9176761ce1a59d4fb3313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550829Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#649299}
-
Xing Liu authored
NotificationCompatBuilder.build() may throw exception on Android M and L. Possibly when there is no Android user profiles. We don't know the reliable way to reproduce this crash. This issue might be Android bug. This CL adds a try catch block on the crashed function. Also fixed a couple of places where we assume notification object is non-null. We also calls startForeground() with a notification object, currently all Android versions has try catch block inside Service.startForeground() and no Android check to assert notification is not null. Bug: 949794 Change-Id: I9df1aeee3cf0f13168b40bb610042681f9acb657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555053 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#649298}
-
Justin Cohen authored
In some cases, an transientContentView may be displayed when the CRWWebControllerContainerView has no window. When the CRWWebControllerContainerView is put back in a window and the main webViewContentView is restored, it will obscure the transientContentView. Instead, always keep the transientContentView on top. Bug: 949204 Change-Id: Ifa992620958ac3b7cfeb85d4451e2d13beee7810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559894 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Yuwei Huang authored
This CL implements FtlSignalingPlayground for testing JingleSessionManager::AcceptIncoming() and JingleSessionManager::Connect(). The test currently ends once the session is authenticated. This also changes some spammy VLOG(0) logs to VLOG(1) so that signaling messages are easier to read. Bug: 947337 Change-Id: I33c84c6e06a311ecdf58d3aad7ad6111bc52ef13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554480 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#649296}
-
Eugene But authored
The test is not failing if slim-nav is not enabled. Bug: 950263 Change-Id: I71e226e6bc04dff6fa02553aeb69b202d9601007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560370 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2d4c66d2b865..b4b3ea05ebde git log 2d4c66d2b865..b4b3ea05ebde --date=short --no-merges --format='%ad %ae %s' 2019-04-09 enga@chromium.org Reland "Rename texture.createTextureView to createView to match WebGPU" Created with: gclient setdep -r src/third_party/dawn@b4b3ea05ebde The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:877147 TBR=cwallez@chromium.org Change-Id: I227c6a396e1a207f6f541c65efcf6735cc1a164d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560226Reviewed-by:
-
John Budorick authored
Bug: 950789 Change-Id: I7af3cd1abf47022f1d95b1b3b66a13bb9984b706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559461Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3d497385cd77..1424ef650142 git log 3d497385cd77..1424ef650142 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 sugoi@google.com PipelineCache basic operations support 2019-04-09 sugoi@google.com Fix creating Buffer objects in VK_SHARING_MODE_EXCLUSIVE mode Created with: gclient setdep -r src/third_party/swiftshader@1424ef650142 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I1fbab0b4b1cbab42e291037b73872f51b335b7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560227Reviewed-by:
-
Bruno Santos authored
Bug: 927809 Change-Id: I538fd2a67e31fa3184e819ccab195d0c56a5eef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559991 Commit-Queue: Bruno Santos <brunoad@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3702d8c9d300..e4458b7bb63a git log 3702d8c9d300..e4458b7bb63a --date=short --no-merges --format='%ad %ae %s' 2019-04-09 jmadill@chromium.org Fix glCopyTexSubImage3D. 2019-04-09 syoussefi@chromium.org Rename getCurrentDisplay to getDisplay 2019-04-09 syoussefi@chromium.org Vulkan: fix CPU throttling frames to 2 Created with: gclient setdep -r src/third_party/angle@e4458b7bb63a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:947342,chromium:None TBR=ynovikov@chromium.org Change-Id: I21e6846bc8a27c2cf8a714900a4cbaede701cbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560225Reviewed-by:
-
dpapad authored
Before this CL WebUIDataSource::SetRequestFilter() accepted a single callback function as a parameter. That callback was responsible for - communicating via a boolean whether a given URL will be handled. - producing the response (bytes) for this request. This is inflexible, because there are cases where we need to know whether a URL will be handled by the request filter, without triggering the request yet. This is in preparation of simplifying the mechanism that WebUIDataSourceImpl uses to determine when a WebUI resource is gzipped. After this CL: WebUIDataSource::SetRequestFilter() accepts two callback functions. - |should_handle_request_callback| simply returns a boolean, indicating whether the request will be handled by the request filter, without handling the request. - |handle_request_callback| handles the request, without returning any boolean. TBR=jam@chromium.org Bug: 738243 Change-Id: I915b87801908885bcbf05e785bbacf8ad140c481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535164 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#649289}
-
Daniel Rubery authored
Metrics on Stable look good (see bug for details), so set this to enabled by default. Bug: 909778 Change-Id: I8a7cfacfa28a72943be407186bafdd51d5a98137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539014 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#649288}
-
Justin DeWitt authored
Change-Id: I4ef7f45a017f24b59dae7dea24f17664c13b3136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555250Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#649287}
-
Kyle Milka authored
Fix NewTabPage.Promos.RequestLatency to properly capture if a request fails or succeeds and differentiate between succeeding with and without a promo present. Add NewTabPage.Promos.ShownTime to log the time from when an NTP is opened to when the promo is inserted into the page. Add NewTabPage.Promos.LinkClicked to log clicks on links embedded in middle-slot promos. Bug: 937505, 934604 Change-Id: I5f4fdb464929485ba38a7a134de4f4f5112e7670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504221Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d90aae9a5a6c..82ebbbba15c2 git log d90aae9a5a6c..82ebbbba15c2 --date=short --no-merges --format='%ad %ae %s' 2019-04-09 dneto@google.com README: fix formatting of requiring Python 'future' (#2500) 2019-04-09 stevenperron@google.com Accept OpBitCast in fix storage class. (#2505) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@82ebbbba15c2 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I62b775d43a9deb6d424a516465952f0ffeea4341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559459Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b4c008bb..825bcc75 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I502cefa1b0f3dd52c9aa9f97012afc30df95687c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560022Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#649284}
-
Yuwei Huang authored
This CL implements FtlSignalStrategy similar to XmppSignalStrategy that can be hooked into JingleSessionManager. Bug: 947337 Change-Id: I5ab582c9cb880d99b35c077b376dce5006eb5f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552104 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic257eaa06cdd9c7ffd055997fcbe77753d969b04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560222Reviewed-by:
-
Dan Beam authored
Screenshots: https://imgur.com/a/7sab9SR R=dpapad@chromium.org BUG=950814 Change-Id: I48ce37a3b7fd369fea9f6d3852017a0c423a32f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559398 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
This change removes: The enable-spelling-feedback-field-trial flag The enable-spelling-feedback-field-trial switch The spelling-service-feedback-interval-seconds switch The spelling-service-feedback-url switch Bug: None Change-Id: I1afd55697edcb5b2fc35a681d232b47ec5cf7f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560371 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#649280}
-
