- 17 Nov, 2017 40 commits
-
-
Daniel Murphy authored
1. If loading from database fails, then set cache mode to contain values, since we no longer have database. 2. If commit fails for the first time, the wrapper is deleted and recreated by the context. But on subsequent fails, the wrapper is not recreated. So, do not unload the values from map till commit is successful, otherwise change the cache mode. 3. On commit failure and then a purge, the database will load an old version of the data which can cause inconsistency in the values sent by renderer and values stored in browser. So, do not report bad message in these cases. 4. When the cache mode is only keys, there should be no way for browser quota to exceed since there is only one renderer. Report bad message in this case. BUG=744602 Change-Id: I8e60ae0ef6e4c5a9f5ff0c953d6e1b433bc05e1f Reviewed-on: https://chromium-review.googlesource.com/768249 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#517295}
-
Fady Samuel authored
Prior to this CL, RenderWidgetHostViewChildFrame converted the frame rect in DIP to physical pixels for GetPhysicalBackingSize. The frame rect in DIP is computed using ScaleToEnclosingRect which can change the size of the rect depending on its position. This occasionally results in a surface invariants violation when surface synchronization is turned on. The solution is to use the frame rect in physical pixels from the parent and pass that along in RWHVChildFrame::GetPhysicalSize(). Bug: 672962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ic1ec779b8330e77c04fe3a3c0a73b90d57b4beaf Reviewed-on: https://chromium-review.googlesource.com/753832 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517294}
-
chrome-release-bot authored
TBR=anantha@chromium.org Change-Id: I2d6506a78da7d63b5c11f2631aa2fd96e47fc1a0 Reviewed-on: https://chromium-review.googlesource.com/775856Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#517293}
-
Lepton Wu authored
The virtual display when running Chrome OS inside VM was treated as external display. This stop us to test touch view mode on emulator since Chrome OS think it's in dock mode. Just treat the first display as internal display when running Chrome inside VM. BUG=b:62822485 TEST=manual - push Chrome to emulator and make sure touch view mode works R=derat@chromium.org Change-Id: I8e8007931b078c96c57e6958e182edf5f095c8cd Reviewed-on: https://chromium-review.googlesource.com/775893 Commit-Queue: Lepton Wu <lepton@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#517292}
-
Maajid authored
Bug: 741274 Change-Id: I67b5093a83b06fda7b195afb29c361d410757fb8 Reviewed-on: https://chromium-review.googlesource.com/771134Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Maajid <maajid@chromium.org> Cr-Commit-Position: refs/heads/master@{#517291}
-
François Degros authored
In SupportsWeakPtrBase::AsWeakPtrImpl<Derived, Base>, if the Derived class defines a member or a nested type called 'Base', then the expression t->Base::AsWeakPtr() takes a different meaning and doesn't compile. Changed the expression to something equivalent but that doesn't exhibit this strange behavior. Change-Id: I5cdfc7d672f378d9dd9afa4dd8138495de80745f Reviewed-on: https://chromium-review.googlesource.com/773761 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#517290}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/06577269..e57e7b81 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I302039d58d8e5b5e33e25fd55e8e20bbe62e14f9 Reviewed-on: https://chromium-review.googlesource.com/775937Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#517289}
-
Lucas Garron authored
TBR=nparker@chromium.org, estark@chromium.org Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7190e4c4e96b803fa2109c3e7a7c35ca7ee8d999 Reviewed-on: https://chromium-review.googlesource.com/775774 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
Lucas Garron <lgarron@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#517288}
-
Pavel Yatsuk authored
This is a step towards worker not relying on client tag hash to identify entity. It is needed to implement bookmarks migration as bookmarks code doesn't populate client tag hash. In this CL I stop caching CommitRequestData in WorkerEntityTracker, instead I pass CommitRequestDataList to CommitContributor. When commit response arrives, records are matched with corresponding request objects in CommitContributor based on position. All the logic related to populating and adjusting SyncEntity is moved there too. BUG=740757 R=skym@chromium.org Change-Id: I46012c48e506bfdd23f393536dcf2f911d0efad4 Reviewed-on: https://chromium-review.googlesource.com/775773 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#517287}
-
Yuzu Saijo authored
This CL removes unnecessary wpr & sha1 files for leak detection folder. leak_detection_001.wprgo.sha1 leak_detection_002.wprgo.sha1 leak_detection.json will be the ones that will remain. Bug: Change-Id: I8a59c7c5c70462a13255075aeeaa209923f5cd6e Reviewed-on: https://chromium-review.googlesource.com/774352Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Yuzu Saijo <yuzus@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#517286}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4011677aed8b..ec2209da1587 $ git log 4011677ae..ec2209da1 --date=short --no-merges --format='%ad %ae %s' 2017-11-16 dsinclair Convert CFX_DateTime::Now to be static 2017-11-16 dsinclair Convert ByteString::{Format|FormatV} to static methods 2017-11-16 dsinclair Make WideString::{Format|FormatV} static 2017-11-16 npm Refactor CFGAS_FontMgr's Windows implementation 2017-11-16 dsinclair Convert TryNamespace to optional 2017-11-16 dsinclair Convert CJX_Node::TryMeasure to pdfium::Optional 2017-11-16 dsinclair Convert TryBoolean to return a pdfium::Optional 2017-11-16 dsinclair Cleanup CJX_Node::GetAttribute 2017-11-16 dsinclair Convert TryEnum to return an optional 2017-11-16 dsinclair Convert TryInteger to return an optional 2017-11-16 dsinclair Convert TryCData and TryContent to optionals Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I941cabe33518557365b84e4a668b88db33ced378 Reviewed-on: https://chromium-review.googlesource.com/776205 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517285}
-
Dale Curtis authored
Used to run a OffloadableVideoDecoder on a different thread than the media thread. Offload conditions are configurable. OffloadableVideoDecoder implementations are just normal VideoDecoders with a new Detach() method that removes them from the thread they were running on. This replaces the offload task runner that was previously held within VpxVideoDecoder with a new class OffloadingVpxVideoDecoder and a helper variable on the constructor to VpxVideoDecoder. The helper variable ensures tasks are returned to the correct thread without unnecessary hops. BUG=783519, 785760, 786059 TEST=new unittests, all existing tests pass Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib76dd9c2778fef3c39455ca3b4de6ecb12dea953 Reviewed-on: https://chromium-review.googlesource.com/773040 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#517284}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/a6ed3f9aee51..1087227dc4f1 $ git log a6ed3f9ae..1087227dc --date=short --no-merges --format='%ad %ae %s' 2017-11-16 chiniforooshan telemetry: add window manager actions for CrOS 2017-11-16 charliea Don't log BattOr errors from generating the serial map Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Id63dc00bdc650c785299e55c933acca462c4556e Reviewed-on: https://chromium-review.googlesource.com/775882 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517283}
-
Andrey Lushnikov authored
This patch migrates all but one test in http/tests/devtools/resource-tree onto a new framework. The cached-resource-metadata.html test is moved into the startup/ folder. As a drive-by, this also fixes the flakiness of resource-tree-reload.html test. BUG=chromium:678487 R=dgozman, chenwilliam Change-Id: I23752916b98336b1706cf326e2a535321fc56a78 Reviewed-on: https://chromium-review.googlesource.com/773793 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517282}
-
Brandon Jones authored
This adds a drawing buffer very similiar to the one that backs WebGL contexts (and in fact borrows plenty of code from it) to create the framebuffer that the VRWebGLLayer returns. It also introduces the concept of an opaque framebuffer to WebGL. This CL does not provide the code to actually push rendered content to the VRDevice, because it's a huge change as-is, and that logic deserves it's own review. Bug: 670510 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie63053b733b78c22f1f6d2fc4b8b67d95aac9b82 Reviewed-on: https://chromium-review.googlesource.com/757836 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517281}
-
Benjamin C. Wiley Sittler authored
Blink-dev intent to implement and ship discussion: https://groups.google.com/a/chromium.org/d/msg/blink-dev/T11QWD2Jyyo/3oS5gCxYAQAJ Chrome Platform Status entry: https://www.chromestatus.com/features/5634575908732928 https://github.com/whatwg/html/issues/3223 filed against the HTML specification requests that this behavior be standardized. The newly-added layout tests should work fine on Windows with "ANSI" codepage 1252 or with a recent Win32.pm installed, and under UTF-8 locales on Linux, OS X, and similar operating systems. Behavior after this change: A user uploading two files, 'MyEmoji
😂 .svg' and 'MyEmoji☺ .svg' in a multiple file upload to an ASCII form will discover the server sees them as two files with distinct names, 'MyEmoji😂.svg' and 'MyEmoji☺.svg'. Behavior before this change: A user uploading two files, 'MyEmoji😂 .svg' and 'MyEmoji☺ .svg' in a multiple file upload to an ASCII form will discover the server sees them only as two files both named 'MyEmoji?.svg'. Bug: 661819 Change-Id: I8795584d9c5e23c0bcb4c85dc546766d202ad2a3 Reviewed-on: https://chromium-review.googlesource.com/755342 Commit-Queue: Benjamin Wiley Sittler <bsittler@chromium.org> Reviewed-by:Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#517280}
-
Varun Khaneja authored
Bug: 784182 Change-Id: If7935838a2b0bb296f943e8498039de12e6c585f Reviewed-on: https://chromium-review.googlesource.com/775905 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#517279}
-
Tommy Nyquist authored
The feature engagement backend supports having multiple EventConfigs with the same name. There are already tests for parsing such configs, but there were no such tests for verifying that validation works. This CL adds one test for mixing event_trigger and other events, and one test with only extra events to ensure that we do not break this functionality going forward. BUG=None Change-Id: I211134adcd882b33f1116b85d1a6ac2045db4725 Reviewed-on: https://chromium-review.googlesource.com/772901 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#517278}
-
Xiaohan Wang authored
- Let MojoCdmHelper own outstanding MojoCdmFileIO objects, so that even if a CDM forgets to call Close(), the object will not be leaked. - Let CdmAuxiliaryHelper::CreateCdmFileIO() return cdm::FileIO*. - Remove CdmFileIO class which is not needed anymore. - Misc: Also move CdmAuxiliaryHelper::CreationCB into CdmAdapterFactory where it's actually used. BUG=776911 TEST=Add a unittest where Close() is not called. Change-Id: Idbfcdb02ec7795b6fbd712bdcea2541e19b86e9b Reviewed-on: https://chromium-review.googlesource.com/770250Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#517277}
-
James Cook authored
This eliminates some direct calls from browser into ash, which we need to do for go/mustash (out-of-process ash). Introduce TouchHudController to observe multi-user changes and update the per-display configuration. Add unit test coverage in ash and eliminate browser test calls. This is not yet enough to enable PreferencesTest.MultiProfiles with --mash (due to IME issues) but it's a step forward. Bug: 678687 Test: added to ash_unittests, manually use Ctrl-Alt-P to enable touch hud with multiple users and multiple displays Change-Id: Id86679a20af421a9e6532a79658e83d0d21b473c Reviewed-on: https://chromium-review.googlesource.com/772839 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#517276}
-
Tarun Bansal authored
Enforce that the observations are added to the observation buffer in non-decreasing order of timestamps. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Bug: 784933 Change-Id: I24d5a9c5165d841ad32304d35b146012697575a1 TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/772078Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#517275}
-
David Dorwin authored
This addresses a comment in https://crrev.com/c/772211. Change-Id: I7f3fb8436a606850f1d2b7d457fe1e3ece94bbd1 Reviewed-on: https://chromium-review.googlesource.com/775997 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#517274}
-
Koji Ishii authored
R: kojii@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Idd213b5afbdfc7d2ff43b2729e40cca29b2452cf Reviewed-on: https://chromium-review.googlesource.com/769628 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#517273}
-
Evan Stade authored
This one is a little more complicated because "AddOrUpdate" is not sufficient --- in some cases an existing notification should be updated but a new one should not be added. Bug: 783018 Change-Id: I7517b7125dd6e06d7f00fcfd4a678b876c96054a Reviewed-on: https://chromium-review.googlesource.com/772352 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517272}
-
Peter Boström authored
Adds titlecase title strings for window.prompt, alert, on-reload and on-close dialogs. Bug: chromium:652015, chromium:652017, chromium:683346 Change-Id: I197a8ad11d95d0d4f7671bba81f671d8c45206c2 Reviewed-on: https://chromium-review.googlesource.com/773907Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#517271}
-
nednguyen authored
Change-Id: Ic2bb631285ec65ea1643f85aa8690efebf848965 TBR=eyaich@chromium.org Change-Id: Ic2bb631285ec65ea1643f85aa8690efebf848965 Reviewed-on: https://chromium-review.googlesource.com/775021Reviewed-by:
-
Hans Wennborg authored
Bug: 782281 Change-Id: Ia7f42af4cc63771dcb6d83f6a0fa0f98e2602c13 Reviewed-on: https://chromium-review.googlesource.com/774119 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Cr-Commit-Position: refs/heads/master@{#517269}
-
Florian Uunk authored
Lite is the new preferred proto runtime on Android, for two reasons: - It lends itself to better proguard optimizing - There is only one flavor, so there is no risk in including proto libraries with overlapping definitions that use different flavors This CL adds a generate_nano argument to the proto_java_library build rule. This argument is default false, so new proto libraries will use lite by default. However, existing libraries will be migrated in a follow-up CL, so this change sets generate_nano to true for those libraries. It also adds the android_library rule that contains the runtime library for lite protos. For an example conversion CL for a proto target, see: https://chromium-review.googlesource.com/c/chromium/src/+/757103 Bug: 782237 Change-Id: I8100e70c38d41add9068e493ca2a5822f7025213 Reviewed-on: https://chromium-review.googlesource.com/757134 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Doug Steedman <dougsteed@chromium.org> Cr-Commit-Position: refs/heads/master@{#517268}
-
Tim Brown authored
This is in preparation of the removal of the deprecated gconf. Bug: 768027 Change-Id: Id81087ceb304c4124b810544c2244fd3123f0ef6 Reviewed-on: https://chromium-review.googlesource.com/775360Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#517267}
-
Darren Shen authored
This patch adds a test for serializing CSSUrlImageValue. Note that we serialize with quotes surrounding the URL, something which is not explicitly stated in the spec. We've asked clarification about this [1]. Spec: https://drafts.css-houdini.org/css-typed-om-1/#urlimagevalue-serialization [1] https://github.com/w3c/css-houdini-drafts/issues/519 Bug: 782103 Change-Id: I46b5669eb7cbf030eacc6aaa60be0649c9b11e24 Reviewed-on: https://chromium-review.googlesource.com/770601Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#517266}
-
Christopher Lam authored
This CL renames the HeaderPainter because it does much more than painting which has become confusing. This is a precursor CL to https://chromium-review.googlesource.com/c/chromium/src/+/768601. Bug: 762401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng Change-Id: Ie41fa68c8b4559e258eac6eee957cc059794bd96 Reviewed-on: https://chromium-review.googlesource.com/774058Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#517265}
-
nednguyen authored
We now have overlapping data: https://chromeperf.appspot.com/report?sid=9f295d22e6e471ddb12191a1cc59b12e5d8c0e29660595a3c72d3bb31989dd86 So it should be safe to remove all these legacy dromaeo benchmarks Bug: 777664 Change-Id: I2d1d56ac2b59ec701475641f6b5cbd7875cd0246 Reviewed-on: https://chromium-review.googlesource.com/775587Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#517264}
-
Albert J. Wong authored
Do not upload memory traces if there is an active incognito session or if the user has opted out of metrics collections. Bug: 785068 Change-Id: If5f00792a6d1306d77c36cbd88066d39c7dbe146 Reviewed-on: https://chromium-review.googlesource.com/775735Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#517263}
-
Nathan Parker authored
Bug: 731328 Change-Id: I61198120338e162c29dfbc582ea7b25063afb6bc Reviewed-on: https://chromium-review.googlesource.com/775897Reviewed-by:
-
Zijie He authored
CastSoftwareVideoEncoderAdapter implements WebrtcVideoEncoder by using a media::cast::SoftwareVideoEncoder. This implementation is now only buildable, we still need several changes to make it work. E.g. converting the DesktopFrame data from ARGB to I420. I am working on a WebRTC change for it. Currently this kind of conversions have been implemented several times across Chromium. Bug: chromium:781432 Change-Id: Ia259bc0478957d2cef492cbdb418202bfda72a4b Reviewed-on: https://chromium-review.googlesource.com/754060Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#517261}
-
Timothy Loh authored
This patch adds a command-line switch, --deny-permission-prompts, which will suppress all permission prompts. This is intended for testing purposes, where prompts (in particular modal prompts on Android) may be irrelevant to but get in the way of tests. This is necessary for telemetry tests, which currently fallback to infobar prompts on Android. Bug: 762335 Change-Id: I6ad36b81ce6404da2c5e141b5fdca2692f37af35 Reviewed-on: https://chromium-review.googlesource.com/773768 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#517260}
-
Lucas Garron authored
Bug: 752372 Change-Id: I931681551c7c38a42cfef5c941d620c18c4562a3 Reviewed-on: https://chromium-review.googlesource.com/773563 Commit-Queue: Lucas Garron <lgarron@chromium.org> Reviewed-by:
-
Nektarios Paisios authored
R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: Change-Id: I23f586ca63c037fb9a0adab24b090b694529d90c Reviewed-on: https://chromium-review.googlesource.com/775520Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#517258}
-
Xiaochu Liu authored
This reverts commit b8a20799. Reason for revert: it turns out that dbus method call in chrome requires UI thread (a DCHECK is broken). my initial plan to do blocking dbus call in OnCustomInstall is no longer viable. OnCustomInstall still needs to block its calling thread: crbug.com/783495 and i will investigate change in component updater to achieve this. more discussions regarding dbus blocking method call are here: https://chromium-review.googlesource.com/c/chromium/src/+/762080 Original change's description: > Move OnCustomInstall body to SequencedTaskRunner > > Currently, OnCustomInstall is invoked in a background thread but it > invokes imageloader on UI thread which does not bring any known benefits. > > We move imageloader operation from UI thread over a SequnecedTaskRunner. > > BUG=chromium:780201 > TEST=install is successful on DUT > > Change-Id: I8deb2ebae9ff22fcf992f4c34d6198ddbcad0c70 > Reviewed-on: https://chromium-review.googlesource.com/752622 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Reviewed-by: Dan Erat <derat@chromium.org> > Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515291} TBR=derat@chromium.org,waffles@chromium.org,ejcaruso@chromium.org,kerrnel@chromium.org,xiaochu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:780201 Change-Id: Ieb0b29ee30dcbd6208bd1c2fcd176cbb10ad48d4 Reviewed-on: https://chromium-review.googlesource.com/775561 Commit-Queue: Xiaochu Liu <xiaochu@chromium.org> Reviewed-by:
-
Yuwei Huang authored
* Fix the issue of |input_entry_method_| not being reset to NOT_ACTIVE when the popup is hidden. * Use ET_GESTURE_LONG_PRESS instead of ET_GESTURE_LONG_TAP so that animation is triggered before the tap is released. * Add auto timeout to the popup when it is triggered by touch. * Hide the popup when it is triggered by touch and the user touches outside of the popup. Bug: 758456 Change-Id: Id2cb6642a4e9129a096c5025d5695aeacf304717 Reviewed-on: https://chromium-review.googlesource.com/775734Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#517256}
-
