- 12 Jun, 2019 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6dd5f3358713..85035be3e2bb git log 6dd5f3358713..85035be3e2bb --date=short --no-merges --format='%ad %ae %s' 2019-06-12 capn@google.com Use VK_TRUE/VK_FALSE consistently 2019-06-12 srisser@google.com Don't let shaders negate samplers Created with: gclient setdep -r src/third_party/swiftshader@85035be3e2bb The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/134584057 TBR=swiftshader-team+autoroll@google.com Change-Id: I80d0cfa596f9ceb797e4b7a3b9ebb721f9952f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655896Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668519}
-
Xiaohan Wang authored
We still depend on //third_party/skia but we don't really depend on //skia now. Change-Id: Ibac00d3fe370f22009b9ab70ab5ec449eab94a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655346 Commit-Queue: Miguel Casas <mcasas@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#668518}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/53cfcd3219c1..d04981cdea4b git log 53cfcd3219c1..d04981cdea4b --date=short --no-merges --format='%ad %ae %s' 2019-06-12 jackneus@google.com Fix cros branch sync to file fails Created with: gclient setdep -r src/third_party/chromite@d04981cdea4b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I1e62dd211343664ca6e89675e73a045f06b5eb6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656023Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ece78714..92219cfc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5170d28297618fd814b107789df4f9d4959d0eb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656016Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668516}
-
Mitsuru Oshima authored
Bug: 969829 Test: no functional change. all test should passes. Change-Id: I51ae9d1fc03b15f20a004d63c4e4c214d18d2652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656054 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#668515}
-
Kehuang Li authored
It was hard coded to level kHigh. This cl is to add the configure to the json configure string used in MediaStreamAudioProcessor. Bug: internal: 131692686 Test: Passed unit tests that check configuration. Change-Id: I690b65bcf9d0cffafc42b564546f51a3296ffb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650300Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Kehuang Li <kehuangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#668514}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b64faff265e8..86a9e51b7ad8 git log b64faff265e8..86a9e51b7ad8 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 crouleau@chromium.org [telemetry] Update Chrome reference builds. Created with: gclient setdep -r src/third_party/catapult@86a9e51b7ad8 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:973179,chromium:867592 TBR=simonhatch@google.com Change-Id: I8eac729aa1b2a46ff16e29fe642684300d881537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656021Reviewed-by:
-
Tommy Steimel authored
This CL removes the declaration for the web runtime feature for enabling modern media controls. The old controls have been removed and so has the feature flag backing this runtime feature, so it's no longer needed. Bug: 884215 Change-Id: If5de46241e43380919397d4059246e594644b354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656156 Commit-Queue: Tommy Steimel <steimel@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#668512}
-
John Delaney authored
Currently, ad frames are never removed from storage when render frames are destroyed. This is a potential memory leak on pages that create large amounts of frames over the lifetime of the page. Each FrameData is ~328 bytes. This CL changes the behavior of the PageLoad.Clients.Ads.Cpu.AdFrames.PerFrame.PercentUsage histograms. However the new behavior is somewhat warranted. Previously we used the entire page lifetime as the denominator. We shouldn't be calculating PercentUsage using time with which the ad frame was already removed from the document. These metrics are versioned to account for this. For all other metrics this change is purely structural, and should not affect behavior. Bug: 971866 Change-Id: I3d94e769d166b4ba59455ec31d4d25903d60e7cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649077Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#668511}
-
Esmael El-Moslimany authored
Bug: 972489 Change-Id: I3394786fd64493443e270194012f2a9089783544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654228Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#668510}
-
Anders Hartvoll Ruud authored
Bug: 972388 Change-Id: Iab62b344387060eac5b44dcaf8d0c47c3e8a22fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653019 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#668509}
-
Pedro Amaral authored
I'm leaving Chrome so I am reassigning metric and flag ownership to mdjones. Change-Id: I72a7ef7e371bf2415c0a1f0b9fe6f98d7eae3f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647148Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#668508}
-
Clark DuVall authored
Nobody has used this for years, so it should be safe to remove. Change-Id: I59d361640801e2677a16f0b80be21b41296d2c91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655979 Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#668507}
-
Marina Ciocea authored
Change confirm button to Stop instead of Share, because "stop" should be the default action for the infobar. Bug: 927949 Change-Id: I9cbcfe6ab2ccd6e365148c250019259dd72e6762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645299 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#668506}
-
Nate Chapin authored
Bug: 749492 Change-Id: I93c8a22383b4c33a52003c453912e139e34baa81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655895 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#668505}
-
Lucas Furukawa Gadani authored
Bug: 973542 Change-Id: Ib0b4768644c8c2ca2f3c42626a797a1203b6b55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650530 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#668504}
-
Devlin Cronin authored
Enable gn check for all targets under //extensions/renderer. Correct previous failures by properly depending on targets. Bug: None Change-Id: I9a075fdcdd82cba8e934889abd395f7bb1794fed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626663Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#668503}
-
Mohammad Refaat authored
This test was not possible in EG1 as EG1 can't detect system views (in this case the activity view). - Test that open in bar appears when a PDF is opened and test that interacting with it will show the activityView. Also test that after dismiss the activity view tapping on the web view will bring back the open in bar. - This CL also include a fix for the path problem where the default EmbededTestServer uses the Runner.app directory as the root directory. Instead change that to use the bundle path in the server initialization inside ChromeTestCase (This is a variation of Eugenebut@ solution created on https://chromium-review.googlesource.com/c/chromium/src/+/1650271 ) Bug: 945461 Change-Id: Ie8b53a7b662412b6516d8f2c654a19ac657416da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650613 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#668502}
-
Tommy Steimel authored
This CL takes layout tests out of media/controls/modern and puts them directly into media/controls. We no longer support legacy controls so there's no need to differentiate between the two. Bug: 884215 Change-Id: I5eb8f5e4db9c5a5db675703c153fefdc34d7b145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655982Reviewed-by:
Becca Hughes <beccahughes@google.com> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#668501}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/08fa95371129..51db421682d6 git log 08fa95371129..51db421682d6 --date=short --no-merges --format='%ad %ae %s' 2019-06-12 noahric@chromium.org Skip cropping for frames that can't be converted to i420. 2019-06-12 nisse@webrtc.org Delete TestAudioDeviceModule methods using rtc::PlatformFile Created with: gclient setdep -r src/third_party/webrtc@51db421682d6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I536d8fadf99f8cc0ddc40374b5ea3c6c97c0ea39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655893Reviewed-by:
-
Erik Chen authored
The script was previously implicitly relying on the location of a hermetic Xcode checkout. Bug: 965663 Change-Id: If911d17f278646e17efc87550833665baa40b917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652010Reviewed-by:
-
Jeffrey Cohen authored
Bug: 970284 Change-Id: I2375285647ee5fdabba32aaf936d4f0c70eec353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653653 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#668498}
-
Gayane Petrosyan authored
screencast: https://drive.google.com/file/d/1QHXS_yo7zwifGUcaZ0RxHDtqleG7UkZ3/view?usp=sharing Bug: 960982 Change-Id: Iee690545e96a89c7344087ebdce45d1fdae77a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650447 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#668497}
-
Shimi Zhang authored
Magnifier is in prod for a while, we don't need this feature to behind a flag anymore. Bug: 967056 Change-Id: I8697aaab5aacbca56693118498729b9bd1aa1768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654628Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#668496}
-
Zentaro Kavanagh authored
- cr-slider has never sent the value to cr-slider-value-changed - When cr-slider replaced paper-slider [1] as the backing for settings-slider it caused an empty event details to be sent - Display zoom tries to read the value in onDisplaySizeSliderDrag_ (display.js) [2] and gets undefined. - This caused calculations with the zoom value to use undefined which resulted in displaying NaN - Added test to cr-slider [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1362245/17/ui/webui/resources/cr_elements/cr_slider/cr_slider.js [2] - https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/device_page/display.js?q=onDisplaySizeSliderD&sq=package:chromium&g=0&l=729 BUG=chromium:932007 TEST=browser_tests --gtest-filter="CrElementsSliderTest.*" Change-Id: Iac2fb4d63d0df09d95bdcfffd72c329afd30297b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652554Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#668495}
-
Esmael El-Moslimany authored
Bug: 967793 Change-Id: I670edee44a43173c31fa0f53b4ee00d7947897b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649067Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#668494}
-
Yining Wang authored
This reverts commit 742a867b. Reason for revert: <INSERT REASONING HERE> Original change's description: > Fix Toolbar content for Focus Mode Window > > Toolbar is not showing correct content for Focus Mode Window when the > site is not secure. This cl resolve this issue by processing an UI > update after tab inserted to browser. > > Change-Id: I35c4baf20ba6c90c85a03f471c51356853e8f165 > > Bug: 961820 > Change-Id: I35c4baf20ba6c90c85a03f471c51356853e8f165 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603768 > Commit-Queue: Yining Wang <yiningwang@google.com> > Reviewed-by: Dana Fried <dfried@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658820} TBR=avi@chromium.org,dfried@chromium.org,yiningwang@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 964900 Change-Id: I92344a883c4497830268b9e7dce2ebf605075560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656031 Commit-Queue: Yining Wang <yiningwang@google.com> Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#668493}
-
Christopher Grant authored
Each use of native module functionality needs to be conditional on both the feature it pertains to, and the global switch that turns native code modules on and off. TBR'ing agrieve - trivial change to not-yet-enabled code. TBR=agrieve@chromium.org Bug: 874590 Change-Id: I0743af75e1534fb4c0771623b9082d1c6feb54b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654520 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#668492}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I2107c9975d3605a4937d4e6946d8ea716fab2789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652391 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#668491}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b2fc666bf9c..7d984193c8c4 Created with: gclient setdep -r src-internal@7d984193c8c4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=haraken@google.com,tangltom@google.com,flackr@google.com Change-Id: I660224da904d51cb3f29c707def2e8b0dc17f318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656013Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#668490}
-
Edward Jung authored
- Increase touch target size of the checkbox. Making the sizing of the check box to use proportional dimensions. - Fix bug where the opt in text doesn't respond to default font size changes. The flex box wrapper causes this problem, switching to grid layout fixes this. Bug: 968171,968189 Change-Id: I45d4ca0cf9ebfe441817bb820d29d7fa11e9c359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655868Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#668489}
-
Tom McKee authored
The User Timing L3 specification requires TypeErrors to be thrown when calls to `performance.measure()` are malformed. The User Timing L2 specification used SyntaxErrors for similar error conditions. This CL changes our use of SyntaxError to TypeError when L3 conformance is active. Bug: 953960 Change-Id: I87bb0717687f4a3b149eaeb6fc190fa9a98d1f9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647342Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Auto-Submit: Tom McKee <tommckee@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#668488}
-
Esmael El-Moslimany authored
Bug: 967793 Change-Id: Ic6585b524e6e3d20c415619a2e811b8d03af0d95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650083Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d62d406aa24c..072e6fc374db git log d62d406aa24c..072e6fc374db --date=short --no-merges --format='%ad %ae %s' 2019-06-12 brianosman@google.com Remove version string from Viewer's "highlight" SkSL shader 2019-06-12 mtklein@google.com remove moot comment 2019-06-12 nifong@google.com Minor optimization to serialization of SkPictures with many subpictures. Created with: gclient setdep -r src/third_party/skia@072e6fc374db The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@google.com Change-Id: Icbdd8cad3e937dd8b4373612a8989dbeacb2dee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656012Reviewed-by:
-
Alex Moshchuk authored
This test does a navigation to an extension URL as part of test setup, but does not wait for the navigation to finish before attempting to download a filesystem URL for that extension. This results in a race between granting proper privileges to the extension process and the download request checking for those privileges. See bug for more details. The fix is to wait for the initial navigation to the extension URL to commit. Bug: 973271 Change-Id: Icada285b20e9ec3efefc1a39cc65481070f83352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654430 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#668485}
-
Andrew Xu authored
Bug: 969810 Change-Id: I48acc58094ca38cc251cbeee83603ba1ecfad52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650537 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#668484}
-
Nico Weber authored
A few years ago, we added ios-device to the try jobs run on clang rolls, in #493848. At some point, that bot disappeared, and after the luci switch non-existent bots on a try invocation are apparently ignored silently. So we never noticed that this bot stopped doing anything, but we _did_ notice clang rolls breaking iOS device builds more frequently. Remove the defunct ios-device bot and add the new and (for now) funct iphone-device and ipad-device bots, which will hopefully catch iOS device issues caused by clang rolls before the rolls land. Bug: 754829,967387 Change-Id: I5cf9ff2bbb9458c547e1a0427fcc31ff788a3759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652541 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#668483}
-
Nicolas Ouellet-Payeur authored
This is a reland of this change, with a fix for symbol_level=0: https://chromium-review.googlesource.com/c/chromium/src/+/1589457 To do so, this CL also adds support for the x86 toolchain in an x64 build. Instead of generating one DLL, we now generate 2 DLLs in the root out-dir: - browser_switcher_bho.dll (x86) - browser_switcher_bho_64.dll (x64) The one that is cross-built (i.e. bitness doesn't match the host) is built in a sub-directory, and then copied to the root out-dir. Bug: 952897 Change-Id: Ie18544fb97ba3091bc8113932e634c539d6d7502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653660Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#668482}
-
Yun Liu authored
exec file name might be the same when test method is the same but for different classes, in this case existing exec file will be replaced when new file pulled out with the same name. exec file will not be generated on device when coverage_directory wasn't created before, error like below: W 205.072s run_tests_on_device(ZX1G22LL36) Failed to handle coverage data after tests: (device: ZX1G22LL36) adb pull /sdcard/chrome/test/coverage /usr/local/google/code/clankium/src/out/Coverage/coverage: failed with exit status 1 and output: - adb: error: remote object '/sdcard/chrome/test/coverage' does not exist Bug: 961808 Change-Id: Iaa0a59881ad7af1f9d0cda4d3544561e425485c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654049 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#668481}
-
Tom Anderson authored
*.xml must be excluded from the grit generated source_set. This is necessary because gn would otherwise error-out because adding a binary file (anything that's not .cpp, .h, etc.) to a source set (like .xml) is a no-op. No effect on generated build files. The process_version gn template generates data files from template files (eg. myfile.h.in -> myfile.h). The gn template automatically adds a source_set with the generated files in it, but it may be useless if only binary files were generated, and in fact gn will now error-out if any binary files are added. Adding "process_only=true" disables creation of the source_set, so we add this in cases where the output files are all binary files. BUG=964411 R=sky Change-Id: I0c170564c89d52168da1facbe9dfde408b21374c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652569Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#668480}
-
